Re: [External] Re: MFT- Dropbox Transport Implementation

2020-04-24 Thread Aravind Ramalingam
Hi Dimuthu,

Thank you for the response. We have incorporated the changes and raised a
PR [1] for Dropbox transport implementation.

Please do review and let us know your feedback.

[1] https://github.com/apache/airavata-mft/pull/9

Thank you
Aravind Ramalingam

On Fri, Apr 24, 2020 at 11:21 AM DImuthu Upeksha 
wrote:

> I would say support for both. Do a small validation in the transport. If
> user has provided /, use it as it is and if he didn't provide, add a / to
> the beginning.
>
> Dimuthu
>
> On Thu, Apr 23, 2020 at 11:46 PM Rajvanshi, Akshay 
> wrote:
>
>> Hello,
>>
>>
>>
>> We had a doubt regarding Dropbox transport implementation. In the
>> resources.json file, the Dropbox API requires the resource path to be
>> appended with a “/” in the starting as a part of the Dropbox file system
>> convention.
>>
>>
>>
>> We wanted to ask if we should add the “/” manually or expect the user to
>> add this on their own? Also, as a test, we added a “/” on our own while
>> parsing the resourcePath, but if the user adds a “/” on their own in the
>> resources.json, you get the same error again.
>>
>>
>>
>> [image: A screenshot of a computer Description automatically generated]
>>
>>
>>
>> Kind Regards
>>
>> Akshay Rajvanshi
>>
>>
>>
>> *From: *DImuthu Upeksha 
>> *Reply-To: *"dev@airavata.apache.org" 
>> *Date: *Thursday, April 23, 2020 at 14:47
>> *To: *Airavata Dev 
>> *Subject: *[External] Re: MFT- Dropbox Transport Implementation
>>
>>
>>
>> This message was sent from a non-IU address. Please exercise caution when
>> clicking links or opening attachments from external sources.
>>
>>
>>
>> If you set the md5 to null, it will not be evaluated. So you should be
>> fine
>>
>>
>>
>> Dimuthu
>>
>>
>>
>> On Thu, Apr 23, 2020 at 2:41 PM Ravichandran, Sharanya 
>> wrote:
>>
>> Hi,
>>
>>
>>
>> We were taking a look at dropbox's documentation and dropbox's API
>> doesnt provide the md5checksum.
>>
>>
>>
>> Since we have md5 integrity checks whenever a transfer takes place, can
>> we skip the md5 check instead by setting the metadata to null ?
>>
>>
>>
>> Thanks,
>>
>> Sharanya R.
>>
>>


Re: [External] Re: MFT- Dropbox Transport Implementation

2020-04-24 Thread DImuthu Upeksha
I would say support for both. Do a small validation in the transport. If
user has provided /, use it as it is and if he didn't provide, add a / to
the beginning.

Dimuthu

On Thu, Apr 23, 2020 at 11:46 PM Rajvanshi, Akshay  wrote:

> Hello,
>
>
>
> We had a doubt regarding Dropbox transport implementation. In the
> resources.json file, the Dropbox API requires the resource path to be
> appended with a “/” in the starting as a part of the Dropbox file system
> convention.
>
>
>
> We wanted to ask if we should add the “/” manually or expect the user to
> add this on their own? Also, as a test, we added a “/” on our own while
> parsing the resourcePath, but if the user adds a “/” on their own in the
> resources.json, you get the same error again.
>
>
>
> [image: A screenshot of a computer Description automatically generated]
>
>
>
> Kind Regards
>
> Akshay Rajvanshi
>
>
>
> *From: *DImuthu Upeksha 
> *Reply-To: *"dev@airavata.apache.org" 
> *Date: *Thursday, April 23, 2020 at 14:47
> *To: *Airavata Dev 
> *Subject: *[External] Re: MFT- Dropbox Transport Implementation
>
>
>
> This message was sent from a non-IU address. Please exercise caution when
> clicking links or opening attachments from external sources.
>
>
>
> If you set the md5 to null, it will not be evaluated. So you should be
> fine
>
>
>
> Dimuthu
>
>
>
> On Thu, Apr 23, 2020 at 2:41 PM Ravichandran, Sharanya 
> wrote:
>
> Hi,
>
>
>
> We were taking a look at dropbox's documentation and dropbox's API doesnt
> provide the md5checksum.
>
>
>
> Since we have md5 integrity checks whenever a transfer takes place, can we
> skip the md5 check instead by setting the metadata to null ?
>
>
>
> Thanks,
>
> Sharanya R.
>
>


Re: [External] Re: MFT- Dropbox Transport Implementation

2020-04-23 Thread Rajvanshi, Akshay
Hello,

We had a doubt regarding Dropbox transport implementation. In the 
resources.json file, the Dropbox API requires the resource path to be appended 
with a “/” in the starting as a part of the Dropbox file system convention.

We wanted to ask if we should add the “/” manually or expect the user to add 
this on their own? Also, as a test, we added a “/” on our own while parsing the 
resourcePath, but if the user adds a “/” on their own in the resources.json, 
you get the same error again.

[A screenshot of a computer  Description automatically generated]

Kind Regards
Akshay Rajvanshi

From: DImuthu Upeksha 
Reply-To: "dev@airavata.apache.org" 
Date: Thursday, April 23, 2020 at 14:47
To: Airavata Dev 
Subject: [External] Re: MFT- Dropbox Transport Implementation

This message was sent from a non-IU address. Please exercise caution when 
clicking links or opening attachments from external sources.

If you set the md5 to null, it will not be evaluated. So you should be fine

Dimuthu

On Thu, Apr 23, 2020 at 2:41 PM Ravichandran, Sharanya 
mailto:shar...@iu.edu>> wrote:

Hi,



We were taking a look at dropbox's documentation and dropbox's API doesnt 
provide the md5checksum.



Since we have md5 integrity checks whenever a transfer takes place, can we skip 
the md5 check instead by setting the metadata to null ?



Thanks,

Sharanya R.