[allura:tickets] #8222 TestForumMessageHandling fails occasionally

[Kenton Taylor]

- **status**: review --> closed
- **Comment**:

Merged.



---

** [tickets:#8222] TestForumMessageHandling fails occasionally**

**Status:** closed
**Milestone:** unreleased
**Created:** Thu Aug 02, 2018 02:38 PM UTC by Dave Brondsema
**Last Updated:** Thu Dec 06, 2018 05:15 PM UTC
**Owner:** Dave Brondsema


The jenkins build sometimes fails with this:

~~~
==
ERROR: 
forgediscussion.tests.functional.test_forum.TestForumMessageHandling.test_posts
--
Traceback (most recent call last):
  File 
"
 line 197, in runTest
self.test(*self.arg)
  File 
"
 line 248, in test_posts
r = self.app.get(url, params=dict(version='1'))
  File 
"
 line 322, in get
resp = super(ValidatingTestApp, self).get(*args, **kw)
  File 
"
 line 269, in get
return super(PostParamCheckingTestApp, self).get(*args, **kwargs)
  File 
"
 line 756, in get
expect_errors=expect_errors)
  File 
"
 line 1099, in do_request
res = req.get_response(app, catch_exc_info=True)
  File 
"
 line 1049, in get_response
application, catch_exc_info=True)
  File 
"
 line 1022, in call_application
app_iter = application(self.environ, start_response)
  File 
"
 line 179, in lint_app
iterator = application(environ, start_response_wrapper)
  File 
"
 line 150, in __call__
self.app, environ, catch_exc_info=True)
  File 
"
 line 51, in call_wsgi_application
output.extend(app_iter)
  File 
"
 line 409, in streaming_iter
for item in self.application(environ, start_response):
  File 
"
 line 29, in __call__
result = self.app(environ, start_response)
  File 
"
 line 60, in __call__
return self.app(environ, start_response)
  File 
"
 line 65, in __call__
result = self.app(environ, start_response)
  File 
"
 line 260, in __call__
return resp(environ, start_response)
  File 
" 
line 207, in AlluraGlobalsMiddleware
return app(environ, start_response)
  File 
"
 line 214, in __call__
return self._app(environ, session_start_response)
  File 
"
 line 202, in __call__
resp = req.get_response(self.app)
  File 
"
 line 1053, in get_response
application, catch_exc_info=False)
  File 
"
 line 1022, in call_application
app_iter = application(self.environ, start_response)
  File 
"
 line 153, in __call__
self.app, environ, catch_exc_info=True)
  File 
"
 line 48, in call_wsgi_application
app_iter = application(environ, start_response)
  File 
"
 line 402, in __call__
return self.app(environ, remember_login_start

[allura:tickets] #8222 TestForumMessageHandling fails occasionally

[Dave Brondsema]

- **status**: open --> review
- **assigned_to**: Dave Brondsema
- **Comment**:

This test exercises a URL form we don't use anywhere - accessing a specific 
post and its version, e.g. 
/p/test/discussion/general/thread/072c2e4f8a/e13a?version=1  This makes a new 
`Object` instance which is not an artifact.  Then the test fails only when a 
markdown `cached_convert` takes long enough to trigger saving the cached result 
- which is why the test doesn't fail often.

Fix on db/8222  You can manually test by creating a forum post, then getting 
its permalink and dropping the `#` so that the target portion is now part of 
the URL.  Then add ?version=1



---

** [tickets:#8222] TestForumMessageHandling fails occasionally**

**Status:** review
**Milestone:** unreleased
**Created:** Thu Aug 02, 2018 02:38 PM UTC by Dave Brondsema
**Last Updated:** Thu Aug 02, 2018 02:38 PM UTC
**Owner:** Dave Brondsema


The jenkins build sometimes fails with this:

~~~
==
ERROR: 
forgediscussion.tests.functional.test_forum.TestForumMessageHandling.test_posts
--
Traceback (most recent call last):
  File 
"
 line 197, in runTest
self.test(*self.arg)
  File 
"
 line 248, in test_posts
r = self.app.get(url, params=dict(version='1'))
  File 
"
 line 322, in get
resp = super(ValidatingTestApp, self).get(*args, **kw)
  File 
"
 line 269, in get
return super(PostParamCheckingTestApp, self).get(*args, **kwargs)
  File 
"
 line 756, in get
expect_errors=expect_errors)
  File 
"
 line 1099, in do_request
res = req.get_response(app, catch_exc_info=True)
  File 
"
 line 1049, in get_response
application, catch_exc_info=True)
  File 
"
 line 1022, in call_application
app_iter = application(self.environ, start_response)
  File 
"
 line 179, in lint_app
iterator = application(environ, start_response_wrapper)
  File 
"
 line 150, in __call__
self.app, environ, catch_exc_info=True)
  File 
"
 line 51, in call_wsgi_application
output.extend(app_iter)
  File 
"
 line 409, in streaming_iter
for item in self.application(environ, start_response):
  File 
"
 line 29, in __call__
result = self.app(environ, start_response)
  File 
"
 line 60, in __call__
return self.app(environ, start_response)
  File 
"
 line 65, in __call__
result = self.app(environ, start_response)
  File 
"
 line 260, in __call__
return resp(environ, start_response)
  File 
" 
line 207, in AlluraGlobalsMiddleware
return app(environ, start_response)
  File 
"
 line 214, in __call__
return self._app(environ, session_start_response)
  File 
"
 line 202, in __call__
resp = req.get_response(self.app)
  File 
"
 line 1053, in get_response
application, catch_exc_info=False)
  File 
"
 line 1022, in call