[allura:tickets] #8167 errors when updating blog post, if feed item doesn't exist
- **Milestone**: unreleased --> v1.8.0 --- ** [tickets:#8167] errors when updating blog post, if feed item doesn't exist** **Status:** closed **Milestone:** v1.8.0 **Created:** Fri Oct 06, 2017 08:47 PM UTC by Dave Brondsema **Last Updated:** Wed Oct 11, 2017 07:08 PM UTC **Owner:** Dave Brondsema If you create a blog post with project/tool permissions such that the public cannot read it, then the "feed" item is not created (see `Feed.post` method). After that if you go to delete or edit the blog post, it errors out because it tries to do update the feed item also. ``` File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 413 in save self.post.commit() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 261 in commit feed_item.title = self.title AttributeError: 'NoneType' object has no attribute 'title' File '/var/local/allura/Allura/allura/lib/patches.py', line 80 in without_trailing_slash return func(*args, **kwargs) File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 405 in save self.post.delete() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 313 in delete self.feed_item().delete() AttributeError: 'NoneType' object has no attribute 'delete' ``` ``` File '/var/local/allura/Allura/allura/lib/patches.py', line 80 in without_trailing_slash return func(*args, **kwargs) File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 413 in save self.post.commit() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 261 in commit feed_item.title = self.title AttributeError: 'NoneType' object has no attribute 'title' ``` --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8167 errors when updating blog post, if feed item doesn't exist
- **status**: review --> closed - **Comment**: Merged. --- ** [tickets:#8167] errors when updating blog post, if feed item doesn't exist** **Status:** closed **Milestone:** unreleased **Created:** Fri Oct 06, 2017 08:47 PM UTC by Dave Brondsema **Last Updated:** Mon Oct 09, 2017 03:13 PM UTC **Owner:** Dave Brondsema If you create a blog post with project/tool permissions such that the public cannot read it, then the "feed" item is not created (see `Feed.post` method). After that if you go to delete or edit the blog post, it errors out because it tries to do update the feed item also. ``` File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 413 in save self.post.commit() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 261 in commit feed_item.title = self.title AttributeError: 'NoneType' object has no attribute 'title' File '/var/local/allura/Allura/allura/lib/patches.py', line 80 in without_trailing_slash return func(*args, **kwargs) File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 405 in save self.post.delete() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 313 in delete self.feed_item().delete() AttributeError: 'NoneType' object has no attribute 'delete' ``` ``` File '/var/local/allura/Allura/allura/lib/patches.py', line 80 in without_trailing_slash return func(*args, **kwargs) File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 413 in save self.post.commit() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 261 in commit feed_item.title = self.title AttributeError: 'NoneType' object has no attribute 'title' ``` --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8167 errors when updating blog post, if feed item doesn't exist
- **status**: open --> review - **assigned_to**: Dave Brondsema - **Comment**: Fixed on db/8167 --- ** [tickets:#8167] errors when updating blog post, if feed item doesn't exist** **Status:** review **Milestone:** unreleased **Created:** Fri Oct 06, 2017 08:47 PM UTC by Dave Brondsema **Last Updated:** Fri Oct 06, 2017 08:51 PM UTC **Owner:** Dave Brondsema If you create a blog post with project/tool permissions such that the public cannot read it, then the "feed" item is not created (see `Feed.post` method). After that if you go to delete or edit the blog post, it errors out because it tries to do update the feed item also. ``` File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 413 in save self.post.commit() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 261 in commit feed_item.title = self.title AttributeError: 'NoneType' object has no attribute 'title' File '/var/local/allura/Allura/allura/lib/patches.py', line 80 in without_trailing_slash return func(*args, **kwargs) File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 405 in save self.post.delete() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 313 in delete self.feed_item().delete() AttributeError: 'NoneType' object has no attribute 'delete' ``` ``` File '/var/local/allura/Allura/allura/lib/patches.py', line 80 in without_trailing_slash return func(*args, **kwargs) File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 413 in save self.post.commit() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 261 in commit feed_item.title = self.title AttributeError: 'NoneType' object has no attribute 'title' ``` --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8167 errors when updating blog post, if feed item doesn't exist
Would be good to make sure the feed item gets created once possible. Not sure how realistic that is though, if the project permissions are the only thing that changes. Change permission logic in `Feed.post` and trust that permission checks happen on the places feeds are shown? --- ** [tickets:#8167] errors when updating blog post, if feed item doesn't exist** **Status:** open **Milestone:** unreleased **Created:** Fri Oct 06, 2017 08:47 PM UTC by Dave Brondsema **Last Updated:** Fri Oct 06, 2017 08:47 PM UTC **Owner:** nobody If you create a blog post with project/tool permissions such that the public cannot read it, then the "feed" item is not created (see `Feed.post` method). After that if you go to delete or edit the blog post, it errors out because it tries to do update the feed item also. ``` File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 413 in save self.post.commit() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 261 in commit feed_item.title = self.title AttributeError: 'NoneType' object has no attribute 'title' File '/var/local/allura/Allura/allura/lib/patches.py', line 80 in without_trailing_slash return func(*args, **kwargs) File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 405 in save self.post.delete() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 313 in delete self.feed_item().delete() AttributeError: 'NoneType' object has no attribute 'delete' ``` ``` File '/var/local/allura/Allura/allura/lib/patches.py', line 80 in without_trailing_slash return func(*args, **kwargs) File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 413 in save self.post.commit() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 261 in commit feed_item.title = self.title AttributeError: 'NoneType' object has no attribute 'title' ``` --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8167 errors when updating blog post, if feed item doesn't exist
--- ** [tickets:#8167] errors when updating blog post, if feed item doesn't exist** **Status:** open **Milestone:** unreleased **Created:** Fri Oct 06, 2017 08:47 PM UTC by Dave Brondsema **Last Updated:** Fri Oct 06, 2017 08:47 PM UTC **Owner:** nobody If you create a blog post with project/tool permissions such that the public cannot read it, then the "feed" item is not created (see `Feed.post` method). After that if you go to delete or edit the blog post, it errors out because it tries to do update the feed item also. ``` File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 413 in save self.post.commit() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 261 in commit feed_item.title = self.title AttributeError: 'NoneType' object has no attribute 'title' File '/var/local/allura/Allura/allura/lib/patches.py', line 80 in without_trailing_slash return func(*args, **kwargs) File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 405 in save self.post.delete() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 313 in delete self.feed_item().delete() AttributeError: 'NoneType' object has no attribute 'delete' ``` ``` File '/var/local/allura/Allura/allura/lib/patches.py', line 80 in without_trailing_slash return func(*args, **kwargs) File '/var/local/allura/ForgeBlog/forgeblog/main.py', line 413 in save self.post.commit() File '/var/local/allura/ForgeBlog/forgeblog/model/blog.py', line 261 in commit feed_item.title = self.title AttributeError: 'NoneType' object has no attribute 'title' ``` --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
