Re: Contributor Access to Apache Ambari
Hi Viraj, Jonathan Hurley added you to the contributors role of Ambari project in Jira. You should now be able to assign tasks to yourself. Please check now and let us know. -Vivek Ratnavel On Wed, Dec 5, 2018 at 6:33 AM Viraj Jasani wrote: > Thanks Vivek for your response. > > I recently created a JIRA and I wanted to work on it. However, I did not > have access to assign that JIRA to myself. Can you please help me with that > access in JIRA? > > > On Mon, 3 Dec 2018 at 9:08 AM, Vivek Ratnavel > wrote: > >> >> >> -- Forwarded message - >> From: Vivek Ratnavel >> Date: Sun, Dec 2, 2018 at 7:36 PM >> Subject: Re: Contributor Access to Apache Ambari >> To: >> >> >> Hi, >> >> You do not need any special access to contribute to Ambari. Please follow >> this guide to contribute - >> https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute >> >> Once you raise a Pull Request in Github, committers and PMC of Ambari >> will take a look at your PR and if everything looks good, the PR will be >> merged. >> >> Thanks for your interest in Ambari and happy contributing! >> >> Regards, >> Vivek Ratnavel >> PMC, Apache Ambari >> >> On Sun, Dec 2, 2018 at 8:02 AM Viraj Jasani >> wrote: >> >>> Hi, >>> >>> Could you please provide me the access? Please let me know if I need to >>> follow some procedure for the same. >>> >>> Thanks, >>> Viraj >>> >>> >>> On Tue, Nov 27, 2018 at 9:16 PM Viraj Jasani >>> wrote: >>> >>> > Hi, >>> > >>> > I am working on a project where we are migrating all of our Hadoop and >>> > HBase clusters to Ambari. We have a tool which is currently being used >>> in >>> > Production that usually performs ssh login to all hosts of a cluster >>> and >>> > then deploy Bigdata packages, start and stop services. >>> > >>> > We have written a tool to Takeover existing clusters by Ambari using >>> > RequestSchedule feature of Ambari. Since I have been using Ambari for a >>> > while and I would like to be part of the community, I am requesting for >>> > Contributor Access. Recently, I raised a JIRA: >>> > https://issues.apache.org/jira/browse/AMBARI-24916 >>> > However, I could not assign it to myself since I do not have >>> contributor >>> > access. >>> > Kindly provide contributor access. >>> > >>> > Username:vjasaniFull name:Viraj Jasani >>> > >>> > >>> > Thanks, >>> > Viraj >>> > >>> >> -- > Thanks, > Viraj >
Re: Contributor Access to Apache Ambari
Hi, You do not need any special access to contribute to Ambari. Please follow this guide to contribute - https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute Once you raise a Pull Request in Github, committers and PMC of Ambari will take a look at your PR and if everything looks good, the PR will be merged. Thanks for your interest in Ambari and happy contributing! Regards, Vivek Ratnavel PMC, Apache Ambari On Sun, Dec 2, 2018 at 8:02 AM Viraj Jasani wrote: > Hi, > > Could you please provide me the access? Please let me know if I need to > follow some procedure for the same. > > Thanks, > Viraj > > > On Tue, Nov 27, 2018 at 9:16 PM Viraj Jasani > wrote: > > > Hi, > > > > I am working on a project where we are migrating all of our Hadoop and > > HBase clusters to Ambari. We have a tool which is currently being used in > > Production that usually performs ssh login to all hosts of a cluster and > > then deploy Bigdata packages, start and stop services. > > > > We have written a tool to Takeover existing clusters by Ambari using > > RequestSchedule feature of Ambari. Since I have been using Ambari for a > > while and I would like to be part of the community, I am requesting for > > Contributor Access. Recently, I raised a JIRA: > > https://issues.apache.org/jira/browse/AMBARI-24916 > > However, I could not assign it to myself since I do not have contributor > > access. > > Kindly provide contributor access. > > > > Username:vjasaniFull name:Viraj Jasani > > > > > > Thanks, > > Viraj > > >
Re: Ambari 2.7.1 release management
+1 for Oliver Regards, Vivek Ratnavel On Mon, Aug 20, 2018 at 12:00 PM, Aravindan Vijayan < avija...@hortonworks.com> wrote: > +1. Thanks for taking this up Oliver. > > -- > Thanks and Regards, > Aravindan Vijayan > > On 8/20/18, 11:45 AM, "Oliver Szabo" wrote: > > Hi all! > > I would like to volunteer to be the Release Manger for the upcoming > Ambari 2.7.1 release. > (apache email: oleew...@apache.org) > Will keep everyone posted > > Regards, > Oliver Szabo > > >
Re: pull requests without description
+1 I agree with Jonathan that commits without +1 from reviewers are most concerning. This shouldn't be happening. -Vivek Ratnavel On Wed, Apr 11, 2018 at 8:37 AM, Jonathan Hurley <jhur...@hortonworks.com> wrote: > Agreed - the reviews without +1's are most concerning. We can't be > committing without proper reviews. I think the only exceptions are: > > - reverts > - merges from a main branch to a feature branch > > > On Apr 11, 2018, at 11:28 AM, Robert Levas <rle...@hortonworks.com> > wrote: > > > > +1 > > > > On 4/11/18, 10:50 AM, "Doroszlai, Attila" <adorosz...@apache.org> > wrote: > > > >Hi all, > > > >Can you please make sure to include meaningful description and test > >steps in your pull requests? Please take some time to replace the > >placeholder text from the template (everything except the 2 headings) > >to help others (reviewers, users) understand the context. > > > >https://github.com/apache/ambari/pulls?q=is%3Apr+in% > 3Abody+NOT+tested+NOT+proposed > > > >On a related note, please merge only after the PR is approved by > reviewers. > > > >https://github.com/apache/ambari/pulls?q=is%3Apr+is% > 3Amerged+review%3Anone+in%3Acomments+NOT+LGTM > > > >-Attila > > > > > > > >
Re: No Jenkins job results for pull request after 24 hours
Hi all, I updated the wiki ( https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) with this information long ago. -Vivek Ratnavel On Fri, Feb 16, 2018 at 11:04 AM, Jayush Luniya <jlun...@hortonworks.com> wrote: > Thanks Alexandr for this tip. I wasn¹t aware of it either. > > On 2/16/18, 6:57 AM, "Alexandr Kovalenko" <akovale...@hortonworks.com> > wrote: > > >Hi, > > > >you may post a comment "retest this please" to restart job > > > >Thanks, > >Aleksandr Kovalenko > > > >From: Di Li <osji...@gmail.com> > >Sent: Friday, February 16, 2018 4:55 PM > >To: dev@ambari.apache.org > >Subject: No Jenkins job results for pull request after 24 hours > > > >Hello folks, > > > >My PR doesn't have any update of its jenkins job status after 24 hours > >while many other PRs created around the same time as mine got their build > >results back within hours of creation. > > > >Is there a way to restart the jenkins job associated with a pull request > >or > >at least check if it's run ? > > > >The Jenkins job web UI only lists the most recent ones and many at the top > >are just pending ones that do show associated PR id. > >https://builds.apache.org/view/A/view/Ambari/job/Ambari- > Github-PullRequest > >-Builder/ > > > > > >
Re: [DISCUSS] Splitting the repos - ambari-metrics and ambari-logsearch
+1 -Vivek Ratnavel On Sun, Jan 28, 2018 at 8:51 PM, Nishant Bangarwa <nbanga...@hortonworks.com > wrote: > +1 > -- > Nishant Bangarwa > Hortonworks > (M): +91-9729200044 > > > > > > > > On 1/29/18, 10:20 AM, "Swapan Shridhar" <sshrid...@hortonworks.com> wrote: > > >+1 for the splitting. > > > >Thanks. > > > >Regards, > >Swapan. > > > > > > > > > > > > > > > > > > > >On 1/28/18, 11:58 AM, "Don Bosco Durai" <bo...@apache.org> wrote: > > > >>+1 > >> > >> > >>On 1/28/18, 11:56 AM, "Dmytro Grinenko" <dgrine...@hortonworks.com> > wrote: > >> > >>+1 > >> > >>-Original Message- > >>From: Siddharth Wagle [mailto:swa...@hortonworks.com] > >>Sent: Friday, January 26, 2018 7:19 AM > >>To: dev@ambari.apache.org > >>Subject: [DISCUSS] Splitting the repos - ambari-metrics and > ambari-logsearch > >> > >>Hi devs, > >> > >> > >>We had a brief discussion about the release management of Ambari > w.r.t to the new work that is on-going with Mpacks and multi-services, > amongst the developers working on the respective pieces. The main point of > discussion was that although Metrics and LogSearch are sub-projects of > Ambari, the release cadence of these sub-projects and Ambari core does not > have to be tied together. Having an Infra Mpack will allow changes to these > two modules to be published independently. > >> > >> > >>The general consensus was to have separate repos for Ambari Metrics, > Ambari Log Search and Ambari Infra which would mean we can build and > version these modules separately and simplify the release process. I wanted > to start a discuss/vote thread for this. I will follow this up with an > Infra ticket to fork off the git repos for Ambari Metrics, Ambari LogSearch > and Ambari Infra separate from the core codebase once we reach consensus. > >> > >> > >>Note: These sub-projects do not have any compile-time or run-time > dependencies on Ambari except logical dependency on Ambari stack advisor > feature to configure the services correctly based on cluster resources. > With the MPack effort this behavior will be delegated to individual stack > services and the corresponding code will be housed in the service repos > anyways. Ambari depends on Ambari Metrics at compile time on the > ambari-metrics-common module which is already published to maven central > and we would continue to do so if anything changes in the common library. > >> > >> > >>[ ] +1 approve > >>[ ] +0 no opinion > >>[ ] -1 disapprove (and reason why) > >> > >> > >>Here is my +1 to start. > >> > >> > >>Best Regards, > >> > >>Sid > >> > >> > >> > >> >
Re: Necessary to attach patch to Jira?
Hi Jason, There is no need to attach the patch to JIRA. The link to github PR should automatically be added to the JIRA if PR title contains the JIRA id in the format specified in docs - https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute Thanks, Vivek Ratnavel On Thu, Jan 25, 2018 at 12:52 PM, Jason Golieb <jgol...@hortonworks.com> wrote: > Now that we are using pull requests, is it necessary to attach a patch to > a Jira if the Jira is linked to the PR? >
Re: Removal of old/defunct branches
+1 to remove the old branches. It would be great if we clean up all the old branches. Thanks for taking the initiative Jonathan. -Vivek Ratnavel On Wed, Jan 24, 2018 at 10:59 AM, Jonathan Hurley <jhur...@hortonworks.com> wrote: > Hi committers and contributors, > > Ambari seems to have a bunch of branches that are dead and don't seem to > serve any useful purposes. These include: > > origin/AMBARI-12885 > origin/trunk > remote/branch-2.4 > remote/branch-2.5 > trunkj > trunkpwd > > They all seem to be either wrong (including the name of the origin or > remote in them) or misspellings. > > I am sure some of the other branches we have are dead too (like > feature-improved-rack-awareness-handling), but I thought we'd start with > the obvious ones. I'd like to see if the community is OK removing the above > mentioned branches. > >
Re: Permissions to modify Jenkins job at builds.apache.org
Update: The build jobs seem to work as I expected after the config change.
:) Please let me know if it doesn't work as expected in the future.
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/212/consoleFull
GitHub pull request #154 of commit
cdf3f623831d45b30525635982612e96622c9671, no merge conflicts.
Setting status of cdf3f623831d45b30525635982612e96622c9671 to PENDING
with url https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/212/
and message: 'Build started sha1 is merged.'
Using context: Jenkins Build
[EnvInject] - Loading node environment variables.
Building remotely on H2 <https://builds.apache.org/computer/H2>
(Hadoop) in workspace
/home/jenkins/jenkins-slave/workspace/Ambari-Github-PullRequest-Builder
Cloning the remote Git repository
Cloning repository git://github.com/apache/ambari.git
> git init
> /home/jenkins/jenkins-slave/workspace/Ambari-Github-PullRequest-Builder
# timeout=10
Fetching upstream changes from git://github.com/apache/ambari.git
> git --version # timeout=10
> git fetch --tags --progress git://github.com/apache/ambari.git
+refs/heads/*:refs/remotes/origin/*
> git config remote.origin.url git://github.com/apache/ambari.git # timeout=10
> git config --add remote.origin.fetch
+refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url git://github.com/apache/ambari.git # timeout=10
Fetching upstream changes from git://github.com/apache/ambari.git
> git fetch --tags --progress git://github.com/apache/ambari.git
+refs/pull/*:refs/remotes/origin/pr/*
> git rev-parse refs/remotes/origin/pr/154/merge^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/pr/154/merge^{commit} # timeout=10
Checking out Revision 24339d1338262b7fa780488ca85ada3d8d93538f
(refs/remotes/origin/pr/154/merge)
> git config core.sparsecheckout # timeout=10
> git checkout -f 24339d1338262b7fa780488ca85ada3d8d93538f
Commit message: "Merge cdf3f623831d45b30525635982612e96622c9671 into
6283ae4f688fbbe04cbb904d4469d3b0f9203335"
On Fri, Jan 19, 2018 at 1:10 PM, Vivek Ratnavel <vivekratna...@apache.org>
wrote:
> Hi Myroslav,
>
> Thanks for pointing this out. I think there was a misconfiguration in a
> couple of the parameters in Github Pull Request builder Jenkins plugin
> configured by the Apache Infra team. I have now corrected those and
> hopefully, the new builds should validate the merge of commits in pull
> requests against the target branch. I will keep an eye on this for a few
> days.
>
> @Dmytro: We use https://wiki.jenkins.io/display/JENKINS/GitHub+pull+
> request+builder+plugin to trigger our builds. As mentioned in the
> document, the phrase "retest this please" can be used to start a new build.
>
> Thanks,
> Vivek Ratnavel
>
> On Fri, Jan 19, 2018 at 3:15 AM, Myroslav Papyrkovskyy <
> mpapyrkovs...@hortonworks.com> wrote:
>
>> Vivek, it looks like something is really wrong with jenkins builds for
>> pull requests (to feature branches at least)
>> I’m trying to look at builds for my PR#150 (https://github.com/apache/amb
>> ari/pull/150).
>> linked build is
>> https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/193/
>>
>> - list of changes seem to be completely unrelated
>> - build seem to be executed agains trunk, not branch-3.0-perf
>> - didn't find any mentions of my commit in output except linking build to
>> PR
>>
>> found another jenkins build with my PR in description
>> https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/198/
>>
>> for branch-2.6 this time, list of changes is also unrelated.
>>
>> Can you check this please?
>>
>>
>> Regards,
>> Myroslav Papirkovskyi
>>
>> 13 січ. 2018 р. о 01:04 Vivek Ratnavel <vivekratna...@apache.org> vivekratna...@apache.org>> написав(ла):
>>
>> Hi team,
>>
>> We have successfully configured Github PullRequest Builder
>> <https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request
>> +builder+plugin>
>> plugin. This will give us the ability to re-trigger build jobs by just
>> leaving a comment "@asfbot retest" in the PR. I have updated the How to
>> Contribute
>> <https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute>
>> guide to include this piece.
>>
>> There was also an issue where github comments and events were not logged
>> in
>> the "Worklog" section of corresponding JIRA. I worked with Infra team on
>> this and they have resolved this issue as well. We should now see all of
>> those comments in the "Worklog" section going forward.
>>
>> Please let me know if you have any questions on this.
>>
>
Re: Permissions to modify Jenkins job at builds.apache.org
Hi Myroslav, Thanks for pointing this out. I think there was a misconfiguration in a couple of the parameters in Github Pull Request builder Jenkins plugin configured by the Apache Infra team. I have now corrected those and hopefully, the new builds should validate the merge of commits in pull requests against the target branch. I will keep an eye on this for a few days. @Dmytro: We use https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin to trigger our builds. As mentioned in the document, the phrase "retest this please" can be used to start a new build. Thanks, Vivek Ratnavel On Fri, Jan 19, 2018 at 3:15 AM, Myroslav Papyrkovskyy < mpapyrkovs...@hortonworks.com> wrote: > Vivek, it looks like something is really wrong with jenkins builds for > pull requests (to feature branches at least) > I’m trying to look at builds for my PR#150 (https://github.com/apache/ > ambari/pull/150). > linked build is > https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/193/ > > - list of changes seem to be completely unrelated > - build seem to be executed agains trunk, not branch-3.0-perf > - didn't find any mentions of my commit in output except linking build to > PR > > found another jenkins build with my PR in description > https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/198/ > > for branch-2.6 this time, list of changes is also unrelated. > > Can you check this please? > > > Regards, > Myroslav Papirkovskyi > > 13 січ. 2018 р. о 01:04 Vivek Ratnavel <vivekratna...@apache.org vivekratna...@apache.org>> написав(ла): > > Hi team, > > We have successfully configured Github PullRequest Builder > <https://wiki.jenkins.io/display/JENKINS/GitHub+pull+ > request+builder+plugin> > plugin. This will give us the ability to re-trigger build jobs by just > leaving a comment "@asfbot retest" in the PR. I have updated the How to > Contribute > <https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute> > guide to include this piece. > > There was also an issue where github comments and events were not logged in > the "Worklog" section of corresponding JIRA. I worked with Infra team on > this and they have resolved this issue as well. We should now see all of > those comments in the "Worklog" section going forward. > > Please let me know if you have any questions on this. > > Thanks, > Vivek Ratnavel > > > > > On Fri, Jan 12, 2018 at 1:54 PM, Vivek Ratnavel <vivekratna...@apache.org< > mailto:vivekratna...@apache.org>> > wrote: > > Hi all, > > I see that there are many build failures and there is no way to re-trigger > the failed builds from github. So, I am working with Apache Infra team to > resolve this issue by using another Jenkins plugin. So, please bear with us > for another few hours while we test this new plugin to trigger the builds. > I will update soon on the status. > > Thanks, > Vivek Ratnavel > > On Thu, Jan 11, 2018 at 11:28 AM, Vivek Ratnavel <vivekratna...@apache.org > <mailto:vivekratna...@apache.org> > wrote: > > I have modified the name of the Jenkins job to avoid confusion. Here is > the new url - https://builds.apache.org/view/A/view/Ambari/job/Ambari-Gi > thub-PullRequest-Builder/ > > Thanks, > Vivek Ratnavel > > On Thu, Jan 11, 2018 at 10:16 AM, Vivek Ratnavel < > vivekratnave...@gmail.com<mailto:vivekratnave...@gmail.com>> wrote: > > That is a good point, Attila. It is definitely possible. Let's work on > this. > > On Thu, Jan 11, 2018 at 9:52 AM, Doroszlai, Attila < > adorosz...@apache.org<mailto:adorosz...@apache.org>> wrote: > > Would you like to work with Vivek on this? > > Sure. > > -Attila > > On Thu, Jan 11, 2018 at 6:29 PM, Yusaku Sako <yus...@hortonworks.com< > mailto:yus...@hortonworks.com>> > wrote: > That is a good suggestion, Attila. > Would you like to work with Vivek on this? > > Yusaku > > On 1/11/18, 2:25 AM, "Doroszlai, Attila" <adorosz...@apache.org adorosz...@apache.org>> > wrote: > >Hi Vivek, > >Would it be possible to put the script that the job runs under > version >control (somewhere in dev-support directory)? > >-Attila > >On Thu, Jan 11, 2018 at 1:30 AM, Vivek Ratnavel ><vivekratna...@apache.org<mailto:vivekratna...@apache.org>> wrote: > Hi Team, > > I have created a jenkins job to monitor Github pull requests > and build and > report tests at > https://builds.apache.org/view/A/view/Ambari/job/Github-Pull > Request-Builder/ > > I will keep an eye on it for the next few days and keep
Re: Add reviewers to PR as a non-committer?
I have seen some other very active Apache projects including Apache Spark using this model successfully for a long time now. They have a portal to keep track of open PRs and stale PRs categorized by components - https://spark-prs.appspot.com/ The contributors open PRs and wait for the community to review it. For instance, take a look at this - https://github.com/apache/spark/pull/20297 On Wed, Jan 17, 2018 at 12:00 PM, Jonathan Hurley <jhur...@hortonworks.com> wrote: > We have a very active project with potentially dozens of new PRs coming in > every day - I don't think relying on the community to look is a very > sustainable model. Is there no way to add reviewers without tagging them? > There seems to be a way to filter by reviews needing attention - seems > silly that non-committers can't add committers ... > > > On Jan 17, 2018, at 2:51 PM, Vivek Ratnavel <vivekratnave...@gmail.com> > wrote: > > > > Hi Jason, > > > > Thanks for bringing this up. For contributors, the best way to notify > > people would be to tag them in comments. This is another good reason to > add > > [component] tags to the PR title, so that committers who are working on > > those components can pro-actively take a look at the newly opened pull > > requests. The committers of the community should actively check newly > > created PRs and resolve them. If the PR is not reviewed by any committer > > for a long time, then the contributor can try pinging the committers by > > tagging them in comments as I mentioned before. Relevant committers can > be > > found by doing a git blame on the files contributed in the patch. > > > > Thanks, > > Vivek Ratnavel > > > > On Wed, Jan 17, 2018 at 11:33 AM, Jason Golieb <jgol...@hortonworks.com> > > wrote: > > > >> As a non-committer, is it possible to add reviewers to a pull request? > It > >> doesn’t look like it to me. What’s the suggested procedure for getting > eyes > >> on my PRs? > >> > > > > > > > > -- > > -Vivek Ratnavel S > >
Re: Add reviewers to PR as a non-committer?
Hi Jason, Thanks for bringing this up. For contributors, the best way to notify people would be to tag them in comments. This is another good reason to add [component] tags to the PR title, so that committers who are working on those components can pro-actively take a look at the newly opened pull requests. The committers of the community should actively check newly created PRs and resolve them. If the PR is not reviewed by any committer for a long time, then the contributor can try pinging the committers by tagging them in comments as I mentioned before. Relevant committers can be found by doing a git blame on the files contributed in the patch. Thanks, Vivek Ratnavel On Wed, Jan 17, 2018 at 11:33 AM, Jason Golieb <jgol...@hortonworks.com> wrote: > As a non-committer, is it possible to add reviewers to a pull request? It > doesn’t look like it to me. What’s the suggested procedure for getting eyes > on my PRs? > -- -Vivek Ratnavel S
Re: Permissions to modify Jenkins job at builds.apache.org
Hi team, We have successfully configured Github PullRequest Builder <https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin> plugin. This will give us the ability to re-trigger build jobs by just leaving a comment "@asfbot retest" in the PR. I have updated the How to Contribute <https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute> guide to include this piece. There was also an issue where github comments and events were not logged in the "Worklog" section of corresponding JIRA. I worked with Infra team on this and they have resolved this issue as well. We should now see all of those comments in the "Worklog" section going forward. Please let me know if you have any questions on this. Thanks, Vivek Ratnavel On Fri, Jan 12, 2018 at 1:54 PM, Vivek Ratnavel <vivekratna...@apache.org> wrote: > Hi all, > > I see that there are many build failures and there is no way to re-trigger > the failed builds from github. So, I am working with Apache Infra team to > resolve this issue by using another Jenkins plugin. So, please bear with us > for another few hours while we test this new plugin to trigger the builds. > I will update soon on the status. > > Thanks, > Vivek Ratnavel > > On Thu, Jan 11, 2018 at 11:28 AM, Vivek Ratnavel <vivekratna...@apache.org > > wrote: > >> I have modified the name of the Jenkins job to avoid confusion. Here is >> the new url - https://builds.apache.org/view/A/view/Ambari/job/Ambari-Gi >> thub-PullRequest-Builder/ >> >> Thanks, >> Vivek Ratnavel >> >> On Thu, Jan 11, 2018 at 10:16 AM, Vivek Ratnavel < >> vivekratnave...@gmail.com> wrote: >> >>> That is a good point, Attila. It is definitely possible. Let's work on >>> this. >>> >>> On Thu, Jan 11, 2018 at 9:52 AM, Doroszlai, Attila < >>> adorosz...@apache.org> wrote: >>> >>>> > Would you like to work with Vivek on this? >>>> >>>> Sure. >>>> >>>> -Attila >>>> >>>> On Thu, Jan 11, 2018 at 6:29 PM, Yusaku Sako <yus...@hortonworks.com> >>>> wrote: >>>> > That is a good suggestion, Attila. >>>> > Would you like to work with Vivek on this? >>>> > >>>> > Yusaku >>>> > >>>> > On 1/11/18, 2:25 AM, "Doroszlai, Attila" <adorosz...@apache.org> >>>> wrote: >>>> > >>>> > Hi Vivek, >>>> > >>>> > Would it be possible to put the script that the job runs under >>>> version >>>> > control (somewhere in dev-support directory)? >>>> > >>>> > -Attila >>>> > >>>> > On Thu, Jan 11, 2018 at 1:30 AM, Vivek Ratnavel >>>> > <vivekratna...@apache.org> wrote: >>>> > > Hi Team, >>>> > > >>>> > > I have created a jenkins job to monitor Github pull requests >>>> and build and >>>> > > report tests at >>>> > > https://builds.apache.org/view/A/view/Ambari/job/Github-Pull >>>> Request-Builder/ >>>> > > >>>> > > I will keep an eye on it for the next few days and keep >>>> modifying its >>>> > > configuration if needed to work as expected. It is expected >>>> that ASF bot >>>> > > will leave a comment in the Pull Request along with a link to >>>> the build job >>>> > > for every new pull request. Please let me know if you feel >>>> something wrong >>>> > > about this job. >>>> > > >>>> > > Thanks, >>>> > > Vivek Ratnavel >>>> > > >>>> > > On Tue, Jan 9, 2018 at 3:32 PM, Yusaku Sako < >>>> yus...@hortonworks.com> wrote: >>>> > > >>>> > >> Hi Vivek, >>>> > >> >>>> > >> Thanks for looking into this. >>>> > >> I’ve given you edit access to builds.apache.org Jenkins jobs. >>>> > >> >>>> > >> Yusaku >>>> > >> >>>> > >> On 1/9/18, 3:07 PM, "Vivek Ratnavel" <vivekratna...@apache.org> >>>> wrote: >>>> > >> >>>> > >> Hi Team, >>>> > >> >>>> > >> There is a jenkins job >>>> > >> <https://builds.apache.org/view/A/view/Ambari/job/Ambari- >>>> > >> trunk-find-patches-available/> >>>> > >> that runs every 10 minutes looking for Ambari JIRA with >>>> new patches. >>>> > >> This >>>> > >> will no longer run due to our new Github pull request >>>> model to review >>>> > >> and >>>> > >> merge changes. >>>> > >> >>>> > >> I can edit this job to look for new github pull requests >>>> and run tests >>>> > >> on >>>> > >> the pull request branch. But, I don't have permissions to >>>> edit or >>>> > >> create >>>> > >> new jenkins job at builds.apache.org. >>>> > >> >>>> > >> I request the PMC chair to grant me access to edit the >>>> jenkins job to >>>> > >> do >>>> > >> the needful. >>>> > >> >>>> > >> Thanks, >>>> > >> Vivek Ratnavel >>>> > >> >>>> > >> >>>> > >> >>>> > >>>> > >>>> > >>>> >>> >>> >>> >>> -- >>> -Vivek Ratnavel S >>> >> >> >
Re: Permissions to modify Jenkins job at builds.apache.org
Hi all, I see that there are many build failures and there is no way to re-trigger the failed builds from github. So, I am working with Apache Infra team to resolve this issue by using another Jenkins plugin. So, please bear with us for another few hours while we test this new plugin to trigger the builds. I will update soon on the status. Thanks, Vivek Ratnavel On Thu, Jan 11, 2018 at 11:28 AM, Vivek Ratnavel <vivekratna...@apache.org> wrote: > I have modified the name of the Jenkins job to avoid confusion. Here is > the new url - https://builds.apache.org/view/A/view/Ambari/job/Ambari- > Github-PullRequest-Builder/ > > Thanks, > Vivek Ratnavel > > On Thu, Jan 11, 2018 at 10:16 AM, Vivek Ratnavel < > vivekratnave...@gmail.com> wrote: > >> That is a good point, Attila. It is definitely possible. Let's work on >> this. >> >> On Thu, Jan 11, 2018 at 9:52 AM, Doroszlai, Attila <adorosz...@apache.org >> > wrote: >> >>> > Would you like to work with Vivek on this? >>> >>> Sure. >>> >>> -Attila >>> >>> On Thu, Jan 11, 2018 at 6:29 PM, Yusaku Sako <yus...@hortonworks.com> >>> wrote: >>> > That is a good suggestion, Attila. >>> > Would you like to work with Vivek on this? >>> > >>> > Yusaku >>> > >>> > On 1/11/18, 2:25 AM, "Doroszlai, Attila" <adorosz...@apache.org> >>> wrote: >>> > >>> > Hi Vivek, >>> > >>> > Would it be possible to put the script that the job runs under >>> version >>> > control (somewhere in dev-support directory)? >>> > >>> > -Attila >>> > >>> > On Thu, Jan 11, 2018 at 1:30 AM, Vivek Ratnavel >>> > <vivekratna...@apache.org> wrote: >>> > > Hi Team, >>> > > >>> > > I have created a jenkins job to monitor Github pull requests and >>> build and >>> > > report tests at >>> > > https://builds.apache.org/view/A/view/Ambari/job/Github-Pull >>> Request-Builder/ >>> > > >>> > > I will keep an eye on it for the next few days and keep >>> modifying its >>> > > configuration if needed to work as expected. It is expected that >>> ASF bot >>> > > will leave a comment in the Pull Request along with a link to >>> the build job >>> > > for every new pull request. Please let me know if you feel >>> something wrong >>> > > about this job. >>> > > >>> > > Thanks, >>> > > Vivek Ratnavel >>> > > >>> > > On Tue, Jan 9, 2018 at 3:32 PM, Yusaku Sako < >>> yus...@hortonworks.com> wrote: >>> > > >>> > >> Hi Vivek, >>> > >> >>> > >> Thanks for looking into this. >>> > >> I’ve given you edit access to builds.apache.org Jenkins jobs. >>> > >> >>> > >> Yusaku >>> > >> >>> > >> On 1/9/18, 3:07 PM, "Vivek Ratnavel" <vivekratna...@apache.org> >>> wrote: >>> > >> >>> > >> Hi Team, >>> > >> >>> > >> There is a jenkins job >>> > >> <https://builds.apache.org/view/A/view/Ambari/job/Ambari- >>> > >> trunk-find-patches-available/> >>> > >> that runs every 10 minutes looking for Ambari JIRA with new >>> patches. >>> > >> This >>> > >> will no longer run due to our new Github pull request model >>> to review >>> > >> and >>> > >> merge changes. >>> > >> >>> > >> I can edit this job to look for new github pull requests >>> and run tests >>> > >> on >>> > >> the pull request branch. But, I don't have permissions to >>> edit or >>> > >> create >>> > >> new jenkins job at builds.apache.org. >>> > >> >>> > >> I request the PMC chair to grant me access to edit the >>> jenkins job to >>> > >> do >>> > >> the needful. >>> > >> >>> > >> Thanks, >>> > >> Vivek Ratnavel >>> > >> >>> > >> >>> > >> >>> > >>> > >>> > >>> >> >> >> >> -- >> -Vivek Ratnavel S >> > >
Re: Wait for pending Jenkins job before Merge
Hi Attila, Thanks for pointing this out. I have added "Delete workspace after build" as a post action to the jenkins job. This should hopefully resolve those issues in the future. Thanks, Vivek Ratnavel On Fri, Jan 12, 2018 at 4:28 AM, Doroszlai, Attila <adorosz...@apache.org> wrote: > Hi Vivek, > > Sometimes the job seems to fail before checking out the change in the > pull request. > > https://builds.apache.org/job/Ambari-Github-PullRequest- > Builder/25/consoleText > https://builds.apache.org/job/Ambari-Github-PullRequest- > Builder/26/consoleText > https://builds.apache.org/job/Ambari-Github-PullRequest- > Builder/27/consoleText > > Here is a successful checkout for comparison: > > https://builds.apache.org/job/Ambari-Github-PullRequest- > Builder/21/consoleText > > Can you please check? Thanks. > > -Attila > > On Thu, Jan 11, 2018 at 7:58 PM, Vivek Ratnavel > <vivekratna...@apache.org> wrote: > > Hi Team, > > > > I am happy that the jenkins job works as expected. It gets triggered on > > every new pull request and performs the following tasks: > > > > Validate the merge > > Build Ambari > > Run unit tests > > > > The job will report failure if any one of these steps fail. Github UI > will > > show a pending check when the jenkins job is running. > > > > Please merge the PR only after the job is complete. > > > > Please let me know if you have any questions. > > > > Thanks, > > Vivek Ratnavel > > >
Re: [VOTE] [RESULT] Move ASF Github Bot comments to Worklog in JIRA
Update: The comments should now be pushed to "Worklog" section in JIRA. -Vivek Ratnavel On Thu, Jan 11, 2018 at 4:51 PM, Vivek Ratnavel <vivekratna...@apache.org> wrote: > Update: I have created a JIRA against INFRA - https://issues.apache.org/ > jira/browse/INFRA-15832 > > -Vivek Ratnavel > > On Thu, Jan 11, 2018 at 4:36 PM, Vivek Ratnavel <vivekratna...@apache.org> > wrote: > >> The vote passed with the following +1's: >> >> Binding (PMC): >> Nate Cole >> Jonathan Hurley >> >> Non-binding: >> Sandor Molnar >> Attila Doroszlai >> Krisztian Kasa >> Balazs Bence Sari >> Dmytro Grinenko >> >> I will follow-up with Apache Infra to move the ASF Github Bot comments to >> the Worklog section in JIRA. >> >> Thank you, >> Vivek Ratnavel >> >> >> On Wed, Jan 10, 2018 at 5:24 AM, Dmytro Grinenko < >> dgrine...@hortonworks.com> wrote: >> >>> +1 >>> >>> >>> "although it seems to me like a workaround, the best thing probably >>> would be to add the patch as an attachment" >>> >>> Is there any need on that? Afaik any pull request stay in git while >>> repo is hosted on git, and any patch/diff from pull request could be >>> downloaded using pull id. >>> >>> >>> For example AMBARI-22739: >>> >>> Curl https://api.github.com/repos/apache/ambari/pulls/72 will show: >>> >>> "diff_url": "https://github.com/apache/ambari/pull/72.diff;, >>> "patch_url": "https://github.com/apache/ambari/pull/72.patch; >>> >>> I.e. diff or patch could be always be downloaded using url pattern >>> above. As a solution, we could create links for them in jira, instead of >>> attaching them >>> >>> -Original Message- >>> From: Balazs Bence Sari [mailto:bs...@hortonworks.com] >>> Sent: Wednesday, January 10, 2018 11:29 AM >>> To: dev@ambari.apache.org >>> Subject: Re: [VOTE] Move ASF Github Bot comments to Worklog in JIRA >>> >>> +1 (although it seems to me like a workaround, the best thing probably >>> would be to add the patch as an attachment) >>> >>> >>> >>> >>> >>> On 1/10/18, 10:15, "Krisztian Kasa" <kk...@hortonworks.com> wrote: >>> >>> >+1 >>> > >>> >On Jan 9, 2018, at 8:04 PM, Vivek Ratnavel <vivekratna...@apache.org >>> <mailto:vivekratna...@apache.org>> wrote: >>> > >>> >Hi Team, >>> > >>> >The Apache Ambari repository was moved to gitbox yesterday for deeper >>> integration with github and folks have started using github for review and >>> merge of patches. If you are unsure of any step, please read the updated >>> How to Contribute<https://cwiki.apache.org/confluence/display/AMBAR >>> I/How+to+Contribute> guide. >>> > >>> >With JIRA linking enabled on Github pull requests, the ASF Github Bot >>> automatically posts several messages as comments in the related JIRA. Check >>> this JIRA for example - https://issues.apache.org/jira >>> /browse/AMBARI-22739. While it is nice to have these comments, we don't >>> want to pollute the comments section of JIRA. When I contacted Apache Infra >>> team on this issue, they suggested that there is an option to push these >>> messages to "Worklog" section of JIRA which made sense to me. >>> > >>> >I am starting this thread to get your vote on moving ASF Github Bot >>> comments to "Worklog" section in JIRA. >>> > >>> >[cid:ii_jc808qxg0_160dc4eda9a1917b] >>> > >>> >Thanks, >>> >Vivek Ratnavel >>> > >>> >> >> >
Re: [VOTE] [RESULT] Move ASF Github Bot comments to Worklog in JIRA
Update: I have created a JIRA against INFRA - https://issues.apache.org/jira/browse/INFRA-15832 -Vivek Ratnavel On Thu, Jan 11, 2018 at 4:36 PM, Vivek Ratnavel <vivekratna...@apache.org> wrote: > The vote passed with the following +1's: > > Binding (PMC): > Nate Cole > Jonathan Hurley > > Non-binding: > Sandor Molnar > Attila Doroszlai > Krisztian Kasa > Balazs Bence Sari > Dmytro Grinenko > > I will follow-up with Apache Infra to move the ASF Github Bot comments to > the Worklog section in JIRA. > > Thank you, > Vivek Ratnavel > > > On Wed, Jan 10, 2018 at 5:24 AM, Dmytro Grinenko < > dgrine...@hortonworks.com> wrote: > >> +1 >> >> >> "although it seems to me like a workaround, the best thing probably would >> be to add the patch as an attachment" >> >> Is there any need on that? Afaik any pull request stay in git while >> repo is hosted on git, and any patch/diff from pull request could be >> downloaded using pull id. >> >> >> For example AMBARI-22739: >> >> Curl https://api.github.com/repos/apache/ambari/pulls/72 will show: >> >> "diff_url": "https://github.com/apache/ambari/pull/72.diff;, >> "patch_url": "https://github.com/apache/ambari/pull/72.patch; >> >> I.e. diff or patch could be always be downloaded using url pattern above. >> As a solution, we could create links for them in jira, instead of attaching >> them >> >> -Original Message- >> From: Balazs Bence Sari [mailto:bs...@hortonworks.com] >> Sent: Wednesday, January 10, 2018 11:29 AM >> To: dev@ambari.apache.org >> Subject: Re: [VOTE] Move ASF Github Bot comments to Worklog in JIRA >> >> +1 (although it seems to me like a workaround, the best thing probably >> would be to add the patch as an attachment) >> >> >> >> >> >> On 1/10/18, 10:15, "Krisztian Kasa" <kk...@hortonworks.com> wrote: >> >> >+1 >> > >> >On Jan 9, 2018, at 8:04 PM, Vivek Ratnavel <vivekratna...@apache.org >> <mailto:vivekratna...@apache.org>> wrote: >> > >> >Hi Team, >> > >> >The Apache Ambari repository was moved to gitbox yesterday for deeper >> integration with github and folks have started using github for review and >> merge of patches. If you are unsure of any step, please read the updated >> How to Contribute<https://cwiki.apache.org/confluence/display/AMBAR >> I/How+to+Contribute> guide. >> > >> >With JIRA linking enabled on Github pull requests, the ASF Github Bot >> automatically posts several messages as comments in the related JIRA. Check >> this JIRA for example - https://issues.apache.org/jira >> /browse/AMBARI-22739. While it is nice to have these comments, we don't >> want to pollute the comments section of JIRA. When I contacted Apache Infra >> team on this issue, they suggested that there is an option to push these >> messages to "Worklog" section of JIRA which made sense to me. >> > >> >I am starting this thread to get your vote on moving ASF Github Bot >> comments to "Worklog" section in JIRA. >> > >> >[cid:ii_jc808qxg0_160dc4eda9a1917b] >> > >> >Thanks, >> >Vivek Ratnavel >> > >> > >
[VOTE] [RESULT] Move ASF Github Bot comments to Worklog in JIRA
The vote passed with the following +1's: Binding (PMC): Nate Cole Jonathan Hurley Non-binding: Sandor Molnar Attila Doroszlai Krisztian Kasa Balazs Bence Sari Dmytro Grinenko I will follow-up with Apache Infra to move the ASF Github Bot comments to the Worklog section in JIRA. Thank you, Vivek Ratnavel On Wed, Jan 10, 2018 at 5:24 AM, Dmytro Grinenko <dgrine...@hortonworks.com> wrote: > +1 > > > "although it seems to me like a workaround, the best thing probably would > be to add the patch as an attachment" > > Is there any need on that? Afaik any pull request stay in git while repo > is hosted on git, and any patch/diff from pull request could be downloaded > using pull id. > > > For example AMBARI-22739: > > Curl https://api.github.com/repos/apache/ambari/pulls/72 will show: > > "diff_url": "https://github.com/apache/ambari/pull/72.diff;, > "patch_url": "https://github.com/apache/ambari/pull/72.patch; > > I.e. diff or patch could be always be downloaded using url pattern above. > As a solution, we could create links for them in jira, instead of attaching > them > > -Original Message- > From: Balazs Bence Sari [mailto:bs...@hortonworks.com] > Sent: Wednesday, January 10, 2018 11:29 AM > To: dev@ambari.apache.org > Subject: Re: [VOTE] Move ASF Github Bot comments to Worklog in JIRA > > +1 (although it seems to me like a workaround, the best thing probably > would be to add the patch as an attachment) > > > > > > On 1/10/18, 10:15, "Krisztian Kasa" <kk...@hortonworks.com> wrote: > > >+1 > > > >On Jan 9, 2018, at 8:04 PM, Vivek Ratnavel <vivekratna...@apache.org< > mailto:vivekratna...@apache.org>> wrote: > > > >Hi Team, > > > >The Apache Ambari repository was moved to gitbox yesterday for deeper > integration with github and folks have started using github for review and > merge of patches. If you are unsure of any step, please read the updated > How to Contribute<https://cwiki.apache.org/confluence/display/ > AMBARI/How+to+Contribute> guide. > > > >With JIRA linking enabled on Github pull requests, the ASF Github Bot > automatically posts several messages as comments in the related JIRA. Check > this JIRA for example - https://issues.apache.org/jira/browse/AMBARI-22739. > While it is nice to have these comments, we don't want to pollute the > comments section of JIRA. When I contacted Apache Infra team on this issue, > they suggested that there is an option to push these messages to "Worklog" > section of JIRA which made sense to me. > > > >I am starting this thread to get your vote on moving ASF Github Bot > comments to "Worklog" section in JIRA. > > > >[cid:ii_jc808qxg0_160dc4eda9a1917b] > > > >Thanks, > >Vivek Ratnavel > > >
Re: New JIRA - Commit messages
Hi Nate,
I find the addition of (username) to commit messages as redundant, since
the user who contributed can be identified from the "Author" tag in git
command line. I use "git log --grep=AMBARI-X" and get an output with
the author tag. Regardless of the committer who merged the pull request,
the "Author" tag will contain the original contributors name. In your
example, it will be "Author: Joe Smith". The PR might have been merged by
any committer with write access, but it becomes irrelevant.
commit 1eead54f467c7ff6abafa908abf5b66a7278a45a
Author: Olivér Szabó <oleew...@gmail.com>
Date: Wed Jan 10 21:13:12 2018 +0100
[AMBARI-22749] ADDENDUM: Create Pull Request Template - fix rat check
(#82)
commit 493612494740ab9b6a7b1e470951baf5cfbee78e
Merge: 30f3a04 1bb2355
Author: Vivek Ratnavel Subramanian <vivekratnave...@gmail.com>
Date: Tue Jan 9 13:00:09 2018 -0800
Merge pull request #70 from vivekratnavel/AMBARI-22749-trunk
[AMBARI-22749] Create Pull Request Template
-Vivek Ratnavel
On Thu, Jan 11, 2018 at 3:37 PM, Nate Cole <nc...@apache.org> wrote:
> All,
>
>
>
> Previous to the fork/pull request framework, we used to use commit message
> variations like so:
>
>
>
> “AMBARI-XX. Great change for stack (ncole)” (for committers)
>
> or
>
> “AMBARI-XX. Great change for stack (Joe Smith via ncole)” (for
> contributors)
>
>
>
> Commits have started abandoning this syntax.
>
>
>
> While I agree that the new workflow makes it clear the committer vs the
> author, it was useful to search just commit messages and pair them with the
> author.
>
>
>
> I would propose we keep the “(username)” practice with commit message
>
>
>
> since we don’t always use github for viewing history. Contributors can
> use something like:
>
>
>
> “(Joe Smith via pull request)” or just “(Joe Smith)”
>
>
>
> Thoughts?
>
> -Nate
>
>
>
>
Re: Wait for pending Jenkins job before Merge
This is the new url due to name change - https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/9/console On Thu, Jan 11, 2018 at 1:17 PM, Dmytro Grinenko <dgrine...@hortonworks.com> wrote: > How to check this job? For me it showing as 404 Not Found > > -Original Message- > From: Vivek Ratnavel [mailto:vivekratnave...@gmail.com] > Sent: Thursday, January 11, 2018 9:18 PM > To: dev@ambari.apache.org > Subject: Re: Wait for pending Jenkins job before Merge > > It looks like the build failed - > https://builds.apache.org/job/Github-PullRequest-Builder/9/console > > On Thu, Jan 11, 2018 at 11:15 AM, Siddharth Wagle <swa...@hortonworks.com> > wrote: > > > I believe there is a problem in posting back the result: > > > > > > https://github.com/apache/ambari/pull/90? > > > > > > - Sid > > > > > > > > From: Vivek Ratnavel <vivekratna...@apache.org> > > Sent: Thursday, January 11, 2018 10:58 AM > > To: dev@ambari.apache.org > > Subject: Wait for pending Jenkins job before Merge > > > > Hi Team, > > > > I am happy that the jenkins job<https://builds.apache.org/ > > view/A/view/Ambari/job/Github-PullRequest-Builder/> works as expected. > > It gets triggered on every new pull request and performs the following > tasks: > > > > * Validate the merge > > * Build Ambari > > * Run unit tests > > > > The job will report failure if any one of these steps fail. Github UI > > will show a pending check when the jenkins job is running. > > > > [cid:ii_jcaut18c0_160e69370c099864] > > Please merge the PR only after the job is complete. > > [cid:ii_jcauv2s01_160e694e637bfc0a] > > > > Please let me know if you have any questions. > > > > Thanks?, > > Vivek Ratnavel > > ? > > > > > > -- > -Vivek Ratnavel S >
Re: Permissions to modify Jenkins job at builds.apache.org
I have modified the name of the Jenkins job to avoid confusion. Here is the new url - https://builds.apache.org/view/A/view/Ambari/job/Ambari-Github-PullRequest-Builder/ Thanks, Vivek Ratnavel On Thu, Jan 11, 2018 at 10:16 AM, Vivek Ratnavel <vivekratnave...@gmail.com> wrote: > That is a good point, Attila. It is definitely possible. Let's work on > this. > > On Thu, Jan 11, 2018 at 9:52 AM, Doroszlai, Attila <adorosz...@apache.org> > wrote: > >> > Would you like to work with Vivek on this? >> >> Sure. >> >> -Attila >> >> On Thu, Jan 11, 2018 at 6:29 PM, Yusaku Sako <yus...@hortonworks.com> >> wrote: >> > That is a good suggestion, Attila. >> > Would you like to work with Vivek on this? >> > >> > Yusaku >> > >> > On 1/11/18, 2:25 AM, "Doroszlai, Attila" <adorosz...@apache.org> wrote: >> > >> > Hi Vivek, >> > >> > Would it be possible to put the script that the job runs under >> version >> > control (somewhere in dev-support directory)? >> > >> > -Attila >> > >> > On Thu, Jan 11, 2018 at 1:30 AM, Vivek Ratnavel >> > <vivekratna...@apache.org> wrote: >> > > Hi Team, >> > > >> > > I have created a jenkins job to monitor Github pull requests and >> build and >> > > report tests at >> > > https://builds.apache.org/view/A/view/Ambari/job/Github-Pull >> Request-Builder/ >> > > >> > > I will keep an eye on it for the next few days and keep modifying >> its >> > > configuration if needed to work as expected. It is expected that >> ASF bot >> > > will leave a comment in the Pull Request along with a link to the >> build job >> > > for every new pull request. Please let me know if you feel >> something wrong >> > > about this job. >> > > >> > > Thanks, >> > > Vivek Ratnavel >> > > >> > > On Tue, Jan 9, 2018 at 3:32 PM, Yusaku Sako < >> yus...@hortonworks.com> wrote: >> > > >> > >> Hi Vivek, >> > >> >> > >> Thanks for looking into this. >> > >> I’ve given you edit access to builds.apache.org Jenkins jobs. >> > >> >> > >> Yusaku >> > >> >> > >> On 1/9/18, 3:07 PM, "Vivek Ratnavel" <vivekratna...@apache.org> >> wrote: >> > >> >> > >> Hi Team, >> > >> >> > >> There is a jenkins job >> > >> <https://builds.apache.org/view/A/view/Ambari/job/Ambari- >> > >> trunk-find-patches-available/> >> > >> that runs every 10 minutes looking for Ambari JIRA with new >> patches. >> > >> This >> > >> will no longer run due to our new Github pull request model >> to review >> > >> and >> > >> merge changes. >> > >> >> > >> I can edit this job to look for new github pull requests and >> run tests >> > >> on >> > >> the pull request branch. But, I don't have permissions to >> edit or >> > >> create >> > >> new jenkins job at builds.apache.org. >> > >> >> > >> I request the PMC chair to grant me access to edit the >> jenkins job to >> > >> do >> > >> the needful. >> > >> >> > >> Thanks, >> > >> Vivek Ratnavel >> > >> >> > >> >> > >> >> > >> > >> > >> > > > > -- > -Vivek Ratnavel S >
Re: Wait for pending Jenkins job before Merge
It looks like the build failed - https://builds.apache.org/job/Github-PullRequest-Builder/9/console On Thu, Jan 11, 2018 at 11:15 AM, Siddharth Wagle <swa...@hortonworks.com> wrote: > I believe there is a problem in posting back the result: > > > https://github.com/apache/ambari/pull/90? > > > - Sid > > > ____ > From: Vivek Ratnavel <vivekratna...@apache.org> > Sent: Thursday, January 11, 2018 10:58 AM > To: dev@ambari.apache.org > Subject: Wait for pending Jenkins job before Merge > > Hi Team, > > I am happy that the jenkins job<https://builds.apache.org/ > view/A/view/Ambari/job/Github-PullRequest-Builder/> works as expected. It > gets triggered on every new pull request and performs the following tasks: > > * Validate the merge > * Build Ambari > * Run unit tests > > The job will report failure if any one of these steps fail. Github UI will > show a pending check when the jenkins job is running. > > [cid:ii_jcaut18c0_160e69370c099864] > Please merge the PR only after the job is complete. > [cid:ii_jcauv2s01_160e694e637bfc0a] > > Please let me know if you have any questions. > > Thanks?, > Vivek Ratnavel > ? > -- -Vivek Ratnavel S
Wait for pending Jenkins job before Merge
Hi Team, I am happy that the jenkins job <https://builds.apache.org/view/A/view/Ambari/job/Github-PullRequest-Builder/> works as expected. It gets triggered on every new pull request and performs the following tasks: - Validate the merge - Build Ambari - Run unit tests The job will report failure if any one of these steps fail. Github UI will show a pending check when the jenkins job is running. Please merge the PR only after the job is complete. Please let me know if you have any questions. Thanks, Vivek Ratnavel
Re: Permissions to modify Jenkins job at builds.apache.org
That is a good point, Attila. It is definitely possible. Let's work on this. On Thu, Jan 11, 2018 at 9:52 AM, Doroszlai, Attila <adorosz...@apache.org> wrote: > > Would you like to work with Vivek on this? > > Sure. > > -Attila > > On Thu, Jan 11, 2018 at 6:29 PM, Yusaku Sako <yus...@hortonworks.com> > wrote: > > That is a good suggestion, Attila. > > Would you like to work with Vivek on this? > > > > Yusaku > > > > On 1/11/18, 2:25 AM, "Doroszlai, Attila" <adorosz...@apache.org> wrote: > > > > Hi Vivek, > > > > Would it be possible to put the script that the job runs under > version > > control (somewhere in dev-support directory)? > > > > -Attila > > > > On Thu, Jan 11, 2018 at 1:30 AM, Vivek Ratnavel > > <vivekratna...@apache.org> wrote: > > > Hi Team, > > > > > > I have created a jenkins job to monitor Github pull requests and > build and > > > report tests at > > > https://builds.apache.org/view/A/view/Ambari/job/Github- > PullRequest-Builder/ > > > > > > I will keep an eye on it for the next few days and keep modifying > its > > > configuration if needed to work as expected. It is expected that > ASF bot > > > will leave a comment in the Pull Request along with a link to the > build job > > > for every new pull request. Please let me know if you feel > something wrong > > > about this job. > > > > > > Thanks, > > > Vivek Ratnavel > > > > > > On Tue, Jan 9, 2018 at 3:32 PM, Yusaku Sako < > yus...@hortonworks.com> wrote: > > > > > >> Hi Vivek, > > >> > > >> Thanks for looking into this. > > >> I’ve given you edit access to builds.apache.org Jenkins jobs. > > >> > > >> Yusaku > > >> > > >> On 1/9/18, 3:07 PM, "Vivek Ratnavel" <vivekratna...@apache.org> > wrote: > > >> > > >> Hi Team, > > >> > > >> There is a jenkins job > > >> <https://builds.apache.org/view/A/view/Ambari/job/Ambari- > > >> trunk-find-patches-available/> > > >> that runs every 10 minutes looking for Ambari JIRA with new > patches. > > >> This > > >> will no longer run due to our new Github pull request model > to review > > >> and > > >> merge changes. > > >> > > >> I can edit this job to look for new github pull requests and > run tests > > >> on > > >> the pull request branch. But, I don't have permissions to > edit or > > >> create > > >> new jenkins job at builds.apache.org. > > >> > > >> I request the PMC chair to grant me access to edit the > jenkins job to > > >> do > > >> the needful. > > >> > > >> Thanks, > > >> Vivek Ratnavel > > >> > > >> > > >> > > > > > > > -- -Vivek Ratnavel S
Re: Permissions to modify Jenkins job at builds.apache.org
Hi Team, I have created a jenkins job to monitor Github pull requests and build and report tests at https://builds.apache.org/view/A/view/Ambari/job/Github-PullRequest-Builder/ I will keep an eye on it for the next few days and keep modifying its configuration if needed to work as expected. It is expected that ASF bot will leave a comment in the Pull Request along with a link to the build job for every new pull request. Please let me know if you feel something wrong about this job. Thanks, Vivek Ratnavel On Tue, Jan 9, 2018 at 3:32 PM, Yusaku Sako <yus...@hortonworks.com> wrote: > Hi Vivek, > > Thanks for looking into this. > I’ve given you edit access to builds.apache.org Jenkins jobs. > > Yusaku > > On 1/9/18, 3:07 PM, "Vivek Ratnavel" <vivekratna...@apache.org> wrote: > > Hi Team, > > There is a jenkins job > <https://builds.apache.org/view/A/view/Ambari/job/Ambari- > trunk-find-patches-available/> > that runs every 10 minutes looking for Ambari JIRA with new patches. > This > will no longer run due to our new Github pull request model to review > and > merge changes. > > I can edit this job to look for new github pull requests and run tests > on > the pull request branch. But, I don't have permissions to edit or > create > new jenkins job at builds.apache.org. > > I request the PMC chair to grant me access to edit the jenkins job to > do > the needful. > > Thanks, > Vivek Ratnavel > > >
Permissions to modify Jenkins job at builds.apache.org
Hi Team, There is a jenkins job <https://builds.apache.org/view/A/view/Ambari/job/Ambari-trunk-find-patches-available/> that runs every 10 minutes looking for Ambari JIRA with new patches. This will no longer run due to our new Github pull request model to review and merge changes. I can edit this job to look for new github pull requests and run tests on the pull request branch. But, I don't have permissions to edit or create new jenkins job at builds.apache.org. I request the PMC chair to grant me access to edit the jenkins job to do the needful. Thanks, Vivek Ratnavel
Re: How to read web api-docs and start to develop web
Hi Dai Xiang, You can take a look at https://cwiki.apache.org/confluence/display/AMBARI/Add+a+host+and+deploy+components+using+APIs and all the pages under "API usage scenarios, troubleshooting, and other FAQs" menu item to get familiar with Aari APIs. To test ambari-web, you can run: cd ambari/ambari-web npm test If you would like to contribute code, then please read the How to Contribute <https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute> guide. Thanks, Vivek Ratnavel On Tue, Jan 9, 2018 at 2:17 AM, Dai Xiang <xiang@sky-data.cn> wrote: > Hi! > > Ambari web is wonderful and it uses many js framework. > > I want to read api-docs but do not know how to read since they are in > html and i want to read them from brower. > > Also, is there a easy way to test web from brower without build rpm > pkgs? > > Please help me and share details if possible. > > -- > Best Regards > Dai Xiang >
[VOTE] Move ASF Github Bot comments to Worklog in JIRA
Hi Team, The Apache Ambari repository was moved to gitbox yesterday for deeper integration with github and folks have started using github for review and merge of patches. If you are unsure of any step, please read the updated How to Contribute <https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute> guide. With JIRA linking enabled on Github pull requests, the ASF Github Bot automatically posts several messages as comments in the related JIRA. Check this JIRA for example - https://issues.apache.org/jira/browse/AMBARI-22739. While it is nice to have these comments, we don't want to pollute the comments section of JIRA. When I contacted Apache Infra team on this issue, they suggested that there is an option to push these messages to "Worklog" section of JIRA which made sense to me. I am starting this thread to get your vote on moving ASF Github Bot comments to "Worklog" section in JIRA. Thanks, Vivek Ratnavel
Re: [DISCUSS] Future code review and commit process
Hi Team, The Apache Infrastructure team has successfully moved ambari git repo to gitbox. New remote url: https://gitbox.apache.org/repos/asf/ambari.git If you have a local clone and would like to just update the remote url, then follow these steps: 1. Fork <https://help.github.com/articles/fork-a-repo/> the https://github.com/apache/ambari repo in github. 2. Run "git remote set-url origin [remote-url]". Replace the [remote-url] with your fork's remote url. This would be of the form https://github.com/username/ambari.git 3. Run "git remote add upstream https://gitbox.apache.org /repos/asf/ambari.git" I have updated the How to Contribute <https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute> guide for detailed instructions on creating pull requests and reviewing patches. I have created this guide by taking suggestions discussed in this email thread and by referring to other Apache project's contribution guides. Please take a look and let me know if you would like any part of the documentation edited. Cheers, Vivek Ratnavel On Mon, Jan 8, 2018 at 4:58 PM, Vivek Ratnavel <vivekratna...@apache.org> wrote: > +1 to open a new pull request. > > On Mon, Jan 8, 2018 at 2:25 PM, Jonathan Hurley <jhur...@hortonworks.com> > wrote: > >> My vote would be to open a new pull request - if anything just to get >> more practice. Even if you already have +1's, it's good to open it and >> reference the reviewboard. >> >> On Jan 8, 2018, at 2:00 PM, Attila Doroszlai <adorosz...@hortonworks.com >> <mailto:adorosz...@hortonworks.com>> wrote: >> >> Is there a policy for pending review requests (ie. the ones already open >> at https://reviews.apache.org/groups/Ambari/ )? Should we open a PR for >> each, or should they be wrapped up on Review Board, or is it up to us? >> >> Thanks. >> >> -Attila >> >> From: Vivek Ratnavel <vivekratna...@apache.org> vivekratna...@apache.org><mailto:vivekratna...@apache.org>> >> Reply-To: "dev@ambari.apache.org<mailto:dev@ambari.apache.org>> dev@ambari.apache.org>" <dev@ambari.apache.org> dev@ambari.apache.org><mailto:dev@ambari.apache.org>> >> Date: Friday, January 5, 2018 at 12:16 AM >> To: "dev@ambari.apache.org<mailto:dev@ambari.apache.org>> dev@ambari.apache.org>" <dev@ambari.apache.org> dev@ambari.apache.org><mailto:dev@ambari.apache.org>> >> Subject: Re: [DISCUSS] Future code review and commit process >> >> Further clarifications: >> >> - Creating the fork >> https://help.github.com/articles/fork-a-repo/ >> >> - Creating a branch for every commit (and creating the pull request) >> https://help.github.com/articles/creating-a-pull-request-from-a-fork/ >> >> - How to keep your fork in-sync with the upstream repository >> >> https://help.github.com/articles/syncing-a-fork/ >> >> - How long-lived Apache feature branches will work in this model. In this >> case, we'd still need a branch off of the feature branch for every commit >> from the fork. >> >> In this workflow, a feature branch is no different than any other branch. >> If you want a commit to land in a branch, then you create a new branch >> based off that branch. You create multiple branches if you want your >> commits to land in multiple branches. It might sound like a daunting task >> initially, but believe me, its very easy and straightforward to create a >> branch and open pull requests for review. And once a pull request is >> opened, you can make changes by simply pushing commits to the same branch. >> >> - How to merge long-lived feature branches into Apache >> >> Feature branches or any other branch could be merged with trunk or any >> branch by creating a new pull request. A new pull request could be opened >> by selecting two branches - a base branch and a head branch. In this case, >> if you want to merge a feature branch with trunk, then you select feature >> branch as base branch and trunk as head branch. >> >> I have attached a screen-shot for reference. >> >> [cid:ii_jc13wnyl0_160c3724ae47072e] >> >> >> I agree with you on creating a wiki page to cover all the scenarios. >> >> >> Thanks, >> Vivek Ratnavel >> >> >> >> On Thu, Jan 4, 2018 at 1:05 PM, Jonathan Hurley <jhur...@hortonworks.com >> <mailto:jhur...@hortonworks.com><mailto:jhur...@hortonworks.com>> wrote: >> Thanks for the clarifications. This sounds like the "Forking Workflow" as >> opposed to the "Feat
Re: [DISCUSS] Future code review and commit process
+1 to open a new pull request. On Mon, Jan 8, 2018 at 2:25 PM, Jonathan Hurley <jhur...@hortonworks.com> wrote: > My vote would be to open a new pull request - if anything just to get more > practice. Even if you already have +1's, it's good to open it and reference > the reviewboard. > > On Jan 8, 2018, at 2:00 PM, Attila Doroszlai <adorosz...@hortonworks.com< > mailto:adorosz...@hortonworks.com>> wrote: > > Is there a policy for pending review requests (ie. the ones already open > at https://reviews.apache.org/groups/Ambari/ )? Should we open a PR for > each, or should they be wrapped up on Review Board, or is it up to us? > > Thanks. > > -Attila > > From: Vivek Ratnavel <vivekratna...@apache.org vivekratna...@apache.org><mailto:vivekratna...@apache.org>> > Reply-To: "dev@ambari.apache.org<mailto:dev@ambari.apache.org> dev@ambari.apache.org>" <dev@ambari.apache.org dev@ambari.apache.org><mailto:dev@ambari.apache.org>> > Date: Friday, January 5, 2018 at 12:16 AM > To: "dev@ambari.apache.org<mailto:dev@ambari.apache.org> dev@ambari.apache.org>" <dev@ambari.apache.org dev@ambari.apache.org><mailto:dev@ambari.apache.org>> > Subject: Re: [DISCUSS] Future code review and commit process > > Further clarifications: > > - Creating the fork > https://help.github.com/articles/fork-a-repo/ > > - Creating a branch for every commit (and creating the pull request) > https://help.github.com/articles/creating-a-pull-request-from-a-fork/ > > - How to keep your fork in-sync with the upstream repository > > https://help.github.com/articles/syncing-a-fork/ > > - How long-lived Apache feature branches will work in this model. In this > case, we'd still need a branch off of the feature branch for every commit > from the fork. > > In this workflow, a feature branch is no different than any other branch. > If you want a commit to land in a branch, then you create a new branch > based off that branch. You create multiple branches if you want your > commits to land in multiple branches. It might sound like a daunting task > initially, but believe me, its very easy and straightforward to create a > branch and open pull requests for review. And once a pull request is > opened, you can make changes by simply pushing commits to the same branch. > > - How to merge long-lived feature branches into Apache > > Feature branches or any other branch could be merged with trunk or any > branch by creating a new pull request. A new pull request could be opened > by selecting two branches - a base branch and a head branch. In this case, > if you want to merge a feature branch with trunk, then you select feature > branch as base branch and trunk as head branch. > > I have attached a screen-shot for reference. > > [cid:ii_jc13wnyl0_160c3724ae47072e] > > > I agree with you on creating a wiki page to cover all the scenarios. > > > Thanks, > Vivek Ratnavel > > > > On Thu, Jan 4, 2018 at 1:05 PM, Jonathan Hurley <jhur...@hortonworks.com< > mailto:jhur...@hortonworks.com><mailto:jhur...@hortonworks.com>> wrote: > Thanks for the clarifications. This sounds like the "Forking Workflow" as > opposed to the "Feature Branch Workflow". I'm fine with that since it lets > non-commiters help. > > We should try to capture all of these scenarios in a wiki page which we > can then all agree upon. Things which we need to cover are: > > - Creating the fork > - Creating a branch for every commit (and creating the pull request) > - How to keep your fork in-sync with the upstream repository > - How long-lived Apache feature branches will work in this model. In this > case, we'd still need a branch off of the feature branch for every commit > from the fork. > - How to merge long-lived feature branches into Apache > > A few of the items above haven't been specified yet - like keeping the > forked repo in sync and how to manage long-lived feature branches in Apache. > > I still do not think we need [component-1][component-2] in the commit > message. We can use the fields in Apache Jira for this. It makes our commit > messages long, hard to read, and ugly. > > On Jan 4, 2018, at 12:57 PM, Vivek Ratnavel <vivekratna...@apache.org< > mailto:vivekratna...@apache.org><mailto:vivekratna...@apache.org>> wrote: > > Let me clarify a few things here. > > > - Before opening any pull requests, one needs to fork > https://github.com/apache/ambari. This is a one time process. > - Before working on any JIRA, lets say AMBARI-12345, one needs to create > a branch from their own fork. Everyone can have their own naming >
Re: [DISCUSS] Future code review and commit process
Further clarifications: - Creating the fork https://help.github.com/articles/fork-a-repo/ - Creating a branch for every commit (and creating the pull request) https://help.github.com/articles/creating-a-pull-request-from-a-fork/ - How to keep your fork in-sync with the upstream repository https://help.github.com/articles/syncing-a-fork/ - How long-lived Apache feature branches will work in this model. In this case, we'd still need a branch off of the feature branch for every commit from the fork. In this workflow, a feature branch is no different than any other branch. If you want a commit to land in a branch, then you create a new branch based off that branch. You create multiple branches if you want your commits to land in multiple branches. It might sound like a daunting task initially, but believe me, its very easy and straightforward to create a branch and open pull requests for review. And once a pull request is opened, you can make changes by simply pushing commits to the same branch. - How to merge long-lived feature branches into Apache Feature branches or any other branch could be merged with trunk or any branch by creating a new pull request. A new pull request could be opened by selecting two branches - a base branch and a head branch. In this case, if you want to merge a feature branch with trunk, then you select feature branch as base branch and trunk as head branch. I have attached a screen-shot for reference. I agree with you on creating a wiki page to cover all the scenarios. Thanks, Vivek Ratnavel On Thu, Jan 4, 2018 at 1:05 PM, Jonathan Hurley <jhur...@hortonworks.com> wrote: > Thanks for the clarifications. This sounds like the "Forking Workflow" as > opposed to the "Feature Branch Workflow". I'm fine with that since it lets > non-commiters help. > > We should try to capture all of these scenarios in a wiki page which we > can then all agree upon. Things which we need to cover are: > > - Creating the fork > - Creating a branch for every commit (and creating the pull request) > - How to keep your fork in-sync with the upstream repository > - How long-lived Apache feature branches will work in this model. In this > case, we'd still need a branch off of the feature branch for every commit > from the fork. > - How to merge long-lived feature branches into Apache > > A few of the items above haven't been specified yet - like keeping the > forked repo in sync and how to manage long-lived feature branches in Apache. > > I still do not think we need [component-1][component-2] in the commit > message. We can use the fields in Apache Jira for this. It makes our commit > messages long, hard to read, and ugly. > > > On Jan 4, 2018, at 12:57 PM, Vivek Ratnavel <vivekratna...@apache.org> > wrote: > > > > Let me clarify a few things here. > > > > > > - Before opening any pull requests, one needs to fork > > https://github.com/apache/ambari. This is a one time process. > > - Before working on any JIRA, lets say AMBARI-12345, one needs to > create > > a branch from their own fork. Everyone can have their own naming > > conventions to name this branch since this is not going to affect the > > public repository in any way. > > - To answer Nate's question, if a JIRA has to be committed to > branch-2.6 > > and trunk, one needs to create two branches from their own fork - a > branch > > based on branch-2.6 and another branch based on trunk. Let's name them > > AMBARI-12345-branch-2.6 and AMBARI-12345-trunk. Again this could be > > anything as long as you can differentiate. > > - After committing patches to both the newly created branches, you need > > to open two pull requests against two public branches - branch2.6 and > > trunk. This link should help - > > https://help.github.com/articles/creating-a-pull-request-from-a-fork/ > > - If there is no conflict, github offers "squash and merge" option > which > > will let you remove unnecessary commit messages and merge any number of > > commits as one commit. For more info - > > https://help.github.com/articles/about-pull-request-merges > > > > Hope this clarifies the flow. > > > > To clarify Jonathan's suggestion > > > > * I do not think that adding a [COMPONENT] tag is useful. Many commits > span > > ambari-server and ambari-agent, and a good number also span ambari-web > and > > ambari-server. I also think that we should have the title of the JIra > match > > the commit exactly as we do today. > > > > If a commit spans multiple components, lets say ambari-server and > > ambari-web, the PR title should be [AMBARI-12345][ambari-server][ > ambari-web] > &g
Re: [DISCUSS] Future code review and commit process
Let me clarify a few things here. - Before opening any pull requests, one needs to fork https://github.com/apache/ambari. This is a one time process. - Before working on any JIRA, lets say AMBARI-12345, one needs to create a branch from their own fork. Everyone can have their own naming conventions to name this branch since this is not going to affect the public repository in any way. - To answer Nate's question, if a JIRA has to be committed to branch-2.6 and trunk, one needs to create two branches from their own fork - a branch based on branch-2.6 and another branch based on trunk. Let's name them AMBARI-12345-branch-2.6 and AMBARI-12345-trunk. Again this could be anything as long as you can differentiate. - After committing patches to both the newly created branches, you need to open two pull requests against two public branches - branch2.6 and trunk. This link should help - https://help.github.com/articles/creating-a-pull-request-from-a-fork/ - If there is no conflict, github offers "squash and merge" option which will let you remove unnecessary commit messages and merge any number of commits as one commit. For more info - https://help.github.com/articles/about-pull-request-merges Hope this clarifies the flow. To clarify Jonathan's suggestion * I do not think that adding a [COMPONENT] tag is useful. Many commits span ambari-server and ambari-agent, and a good number also span ambari-web and ambari-server. I also think that we should have the title of the JIra match the commit exactly as we do today. If a commit spans multiple components, lets say ambari-server and ambari-web, the PR title should be [AMBARI-12345][ambari-server][ambari-web] Title. This is especially useful to categorize the open pull requests based on their components, so that other folks working in those components can work on clearing those open pull requests. Please let me know if you need more clarification on anything discussed here. Thanks, Vivek Ratnavel On Thu, Jan 4, 2018 at 8:45 AM, Nate Cole <nc...@hortonworks.com> wrote: > Please also clarify the following scenario: > > I’m working on a fix for branch-2.6, and when I’m done, I need to merge to > trunk. > > What is the flow? > - Create a fork > - Commit to branch-2.6 (on my fork) > - Commit to trunk (on my fork) > - Create pull request to bring changes to both branches? > Or > - Create a fork > - Commit to branch-2.6 (on my fork) > - Create pull request > - Commit to trunk (on my fork) > - Create pull request > > This is exposing my git n00bness > > > > > > On 1/4/18, 11:32 AM, "Attila Doroszlai" <adorosz...@hortonworks.com> > wrote: > > > * Since this new flow model requires a branch for a commit, we > should enforce a naming strategy. These short-lived feature branches for > commits must be easy to find and remove. We should also make the community > aware that once you have had your pull request merged, you should get rid > of your branch. As for branch naming conventions, I haven't thought through > it very much, but perhaps simply the name of the associated JIRA, such as > AMBARI-12345. > > Correct me if I'm wrong, but the branch to be merged should be created > in your own fork, not in the apache/ambari repo. Otherwise non-committers > would not be able to create pull requests. I think this eliminates the > need to coordinate branch naming, although some convention or pattern would > be helpful anyway. > > -Attila > > >
[DISCUSS] Future code review and commit process
Hi all, As we are linking our github accounts with gitbox to gain write access to github repository, I wanted to start a discussion on the future code review and commit process. After taking a look at other Apache projects including Apache Spark, I suggest we adapt the following flow: - A JIRA is created with all the required details at https://issues.apache.org/ - Create a new branch from local fork and push commits to that branch - Run all the tests and update or add new tests if required - Open a pull request against trunk or any other branch. I suggest using PR title format similar to what Apache Spark is using. 1. The pull request title should be of the form [AMBARI-][COMPONENT] Title, where AMBARI- is the relevant JIRA number, COMPONENT is one of the ambari components such as ambari-server, ambari-web, etc. and Title may be the JIRA’s title or a more specific title describing the PR itself. 2. If the pull request is still a work in progress, and so is not ready to be merged, but needs to be pushed to Github to facilitate review, then add [WIP] after the component. Following such a format to create pull requests will help us create a portal such as https://spark-prs.appspot.com/ in the future to keep track of open pull requests. Thanks to github's rich set of APIs. - Wait for a +1 or approval of PR from any committer. If there is a need for update, keep pushing commits to the same branch and notify the reviewer of the update. - If a PR has +1 from a committer, any committer can then go ahead and merge the PR and mark the JIRA as resolved Please let me know what you think about this flow. Your feedback is appreciated. Thanks, Vivek Ratnavel
Re: [VOTE][RESULT] Migrate to gitbox
Hi all, I am excited to use the Github's Pull Request model to review and commit patches to Ambari. As Yusaku is going to follow up with the Apache Infra to migrate the repository to gitbox, everyone needs to follow the instructions in this page - https://gitbox.apache.org/setup/ and make sure that you have linked your github account to gitbox. This step will make sure that you get read/write access to Apache Ambari repository in github. Please feel free to reach out to me or seek help from the Apache Infra team if you are facing any difficulties while linking your github account. Thanks, Vivek Ratnavel On Tue, Jan 2, 2018 at 1:43 PM, Yusaku Sako <yus...@hortonworks.com> wrote: > The vote passed with the following +1’s: > > Binding (PMC): > Nate Cole > Jayush Luniya > Swapan Shridhar > Aravindan Vijayan > Rob Levas > Jonathan Hurley > > Non-binding: > Vivek Ratnavel > Di Li > Nishant Bangarwa > Sean Roberts > 李书明 > > I will follow up with a request for Apache Infra to set this up. > > Thanks, > Yusaku > > > On 12/11/17, 4:09 PM, "Nate Cole" <nc...@hortonworks.com> wrote: > > +1 > > On 12/7/17, 6:48 PM, "Vivek Ratnavel" <vivekratna...@apache.org> > wrote: > > Hi all, > > I am starting this vote to migrate Apache Ambari project from > git-wip > repository to gitbox, which allows a deeper integration with github > features. Moving to gitbox will allow committers to merge, close > or edit > pull requests in the github UI. > > Other advantages: > >- JIRA linking can be enabled on request to the Apache Infra > team, which >will automatically link a PR with its corresponding JIRA in >https://issues.apache.org/jira >- It will make our code review process cleaner and more > efficient when >compared to the Review Board. >- Opens up a lot of opportunities on leveraging the rich set of > github >APIs and web hooks to develop tools that can help monitor the > open PRs, > trigger a jenkins job to run unit tests, etc.. > > [ ] +1, Migrate Ambari repository to gitbox > [ ] -1, Keep git-wip + github read-only mirror > > Regards, > Vivek Ratnavel > > > > > -- -Vivek Ratnavel S
Re: Gentle reminder / Re: [VOTE] Apache Ambari 2.6.1 RC1
+1 for RC1. Verified checksums and signature. -Vivek Ratnavel On Thu, Dec 14, 2017 at 12:34 PM, Jayush Luniya <jlun...@hortonworks.com> wrote: > +1 for RC1. > > On 12/14/17, 11:22 AM, "Yusaku Sako" <yus...@hortonworks.com> wrote: > > >+1 on RC1. > >Verified checksums, signature, and rat check. > >Build and unit tests passed. > > > >Yusaku > > > >On 12/14/17, 3:55 AM, "Swapan Shridhar" <sshrid...@hortonworks.com> > wrote: > > > > > >Thanks. > > > >Regards, > >Swapan. > > > > > >From: Swapan Shridhar > >Date: Tuesday, December 12, 2017 at 1:03 PM > >To: "dev@ambari.apache.org<mailto:dev@ambari.apache.org>" > >Subject: [VOTE] Apache Ambari 2.6.1 RC1 > > > > > > > >Hi All, > > > >I have created another apache-ambari-2.6.1 release candidate 'rc1', > >as we got a down vote on 'rc0' because of a blocker bug discovered on Dec > >11'17. > > > >GIT source tag (release-2.6.1-rc1): > >https://git-wip-us.apache.org/repos/asf/ambari/repo?p= > ambari.git;a=log;h=r > >efs/tags/release-2.6.1-rc1 > > > >Staging site: http://home.apache.org/~swapan/apache-ambari-2.6.1- > rc1/ > > > >PGP release keys (signed using D0203B18): > >http://pgp.mit.edu:11371/pks/lookup?search=0xBCC5EA25D0203B18=vindex > > > >One can look into the issues fixed in this release at: > >https://issues.apache.org/jira/projects/AMBARI/versions/12341944 > > > >Vote will be open for 72 hours. > >[ ] +1 approve > >[ ] +0 no opinion > >[ ] -1 disapprove (and reason why) > > > > > >Regards, > >Swapan Shridhar > >Apache Ambari 2.6.X Release Manager > > > > > >
[VOTE] Migrate to gitbox
Hi all, I am starting this vote to migrate Apache Ambari project from git-wip repository to gitbox, which allows a deeper integration with github features. Moving to gitbox will allow committers to merge, close or edit pull requests in the github UI. Other advantages: - JIRA linking can be enabled on request to the Apache Infra team, which will automatically link a PR with its corresponding JIRA in https://issues.apache.org/jira - It will make our code review process cleaner and more efficient when compared to the Review Board. - Opens up a lot of opportunities on leveraging the rich set of github APIs and web hooks to develop tools that can help monitor the open PRs, trigger a jenkins job to run unit tests, etc.. [ ] +1, Migrate Ambari repository to gitbox [ ] -1, Keep git-wip + github read-only mirror Regards, Vivek Ratnavel
Re: Review Request 37003: Add Data Visualization to Hive View
Thanks, Vivek Ratnavel Subramanian
Re: Review Request 37003: Add Data Visualization to Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37003/ --- (Updated Aug. 3, 2015, 3:33 p.m.) Review request for Ambari and Yusaku Sako. Changes --- Fixed build error. Bugs: AMBARI-12615 https://issues.apache.org/jira/browse/AMBARI-12615 Repository: ambari Description --- Refer to the description in AMBARI-12615 Diffs (updated) - ambari-web/app/views/main/views/details.js e90cb20 contrib/views/hive/pom.xml 39f6848 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java a0d44f5 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java 526f13f contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 18152ad contrib/views/hive/src/main/resources/ui/hive-web/.jshintrc c1fe863 contrib/views/hive/src/main/resources/ui/hive-web/app/components/visualization-tabs-widget.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/query-tabs.js 4f5176c contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visualization-ui.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js af5e3a7 contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/visualization-tabs-widget.hbs PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/templates/visualization-ui.hbs PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js e4e445a contrib/views/hive/src/main/resources/ui/hive-web/app/views/visualization-ui.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/bower.json 37ea901 Diff: https://reviews.apache.org/r/37003/diff/ Testing --- Tested manually with different datasets of different size. Tested switching to visualization tab with multiple SQL tabs having different queries. Tested switching between the two visualization tabs multiple times. Tested with upto 3 rows in the resultset with all possible combinations of scale and chart types. Tested with Google Chrome, Safari, Firefox and Internet Explorer 10. Tested end to end with Ambari Web and Hive View. Existing Ambari Web unit tests pass. 6482 tests complete (22 seconds) 94 tests pending [INFO] [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web --- [INFO] 51 implicit excludes (use -debug for more details). [INFO] Exclude: .idea/** [INFO] Exclude: package.json [INFO] Exclude: public/** [INFO] Exclude: public-static/** [INFO] Exclude: app/assets/** [INFO] Exclude: vendor/** [INFO] Exclude: node_modules/** [INFO] Exclude: node/** [INFO] Exclude: npm-debug.log [INFO] 1169 resources included (use -debug for more details) Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. Compiler warnings: WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.' Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1169 licence. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 49.809s [INFO] Finished at: Fri Jul 31 18:39:11 PDT 2015 [INFO] Final Memory: 12M/439M [INFO] Thanks, Vivek Ratnavel Subramanian
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Attachment: (was: AMBARI-12615.patch) Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 Attachments: AMBARI-12615.patch There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Attachment: AMBARI-12615.patch Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 Attachments: AMBARI-12615.patch There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 37003: Add Data Visualization to Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37003/ --- (Updated Aug. 3, 2015, 4:53 p.m.) Review request for Ambari and Yusaku Sako. Changes --- Moved the position of visualization tab Bugs: AMBARI-12615 https://issues.apache.org/jira/browse/AMBARI-12615 Repository: ambari Description --- Refer to the description in AMBARI-12615 Diffs (updated) - ambari-web/app/views/main/views/details.js e90cb20 contrib/views/hive/pom.xml 39f6848 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java a0d44f5 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java 526f13f contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 18152ad contrib/views/hive/src/main/resources/ui/hive-web/.jshintrc c1fe863 contrib/views/hive/src/main/resources/ui/hive-web/app/components/visualization-tabs-widget.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/query-tabs.js 4f5176c contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visualization-ui.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js af5e3a7 contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/visualization-tabs-widget.hbs PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/templates/visualization-ui.hbs PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js e4e445a contrib/views/hive/src/main/resources/ui/hive-web/app/views/visualization-ui.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/bower.json 37ea901 Diff: https://reviews.apache.org/r/37003/diff/ Testing --- Tested manually with different datasets of different size. Tested switching to visualization tab with multiple SQL tabs having different queries. Tested switching between the two visualization tabs multiple times. Tested with upto 3 rows in the resultset with all possible combinations of scale and chart types. Tested with Google Chrome, Safari, Firefox and Internet Explorer 10. Tested end to end with Ambari Web and Hive View. Existing Ambari Web unit tests pass. 6482 tests complete (22 seconds) 94 tests pending [INFO] [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web --- [INFO] 51 implicit excludes (use -debug for more details). [INFO] Exclude: .idea/** [INFO] Exclude: package.json [INFO] Exclude: public/** [INFO] Exclude: public-static/** [INFO] Exclude: app/assets/** [INFO] Exclude: vendor/** [INFO] Exclude: node_modules/** [INFO] Exclude: node/** [INFO] Exclude: npm-debug.log [INFO] 1169 resources included (use -debug for more details) Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. Compiler warnings: WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.' Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1169 licence. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 49.809s [INFO] Finished at: Fri Jul 31 18:39:11 PDT 2015 [INFO] Final Memory: 12M/439M [INFO] Thanks, Vivek Ratnavel Subramanian
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Attachment: (was: AMBARI-12615.patch) Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Attachment: AMBARI-12615.patch Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 Attachments: AMBARI-12615.patch There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Attachment: (was: AMBARI-12615.patch) Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 Attachments: AMBARI-12615.patch There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Attachment: AMBARI-12615.patch Revised patch Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 Attachments: AMBARI-12615.patch, AMBARI-12615.patch There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Attachment: (was: AMBARI-12615.patch) Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 Attachments: AMBARI-12615.patch There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 37003: Add Data Visualization to Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37003/ --- (Updated Aug. 2, 2015, 5:15 a.m.) Review request for Ambari and Yusaku Sako. Changes --- Fixed build error. Bugs: AMBARI-12615 https://issues.apache.org/jira/browse/AMBARI-12615 Repository: ambari Description --- Refer to the description in AMBARI-12615 Diffs (updated) - ambari-web/app/views/main/views/details.js e90cb20 contrib/views/hive/pom.xml 39f6848 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java a0d44f5 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java 526f13f contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 18152ad contrib/views/hive/src/main/resources/ui/hive-web/.jshintrc c1fe863 contrib/views/hive/src/main/resources/ui/hive-web/app/components/visualization-tabs-widget.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/query-tabs.js 4f5176c contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visualization-ui.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js af5e3a7 contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/visualization-tabs-widget.hbs PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/templates/visualization-ui.hbs PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js e4e445a contrib/views/hive/src/main/resources/ui/hive-web/app/views/visualization-ui.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/bower.json 37ea901 Diff: https://reviews.apache.org/r/37003/diff/ Testing --- Tested manually with different datasets of different size. Tested switching to visualization tab with multiple SQL tabs having different queries. Tested switching between the two visualization tabs multiple times. Tested with upto 3 rows in the resultset with all possible combinations of scale and chart types. Tested with Google Chrome, Safari, Firefox and Internet Explorer 10. Tested end to end with Ambari Web and Hive View. Existing Ambari Web unit tests pass. 6482 tests complete (22 seconds) 94 tests pending [INFO] [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web --- [INFO] 51 implicit excludes (use -debug for more details). [INFO] Exclude: .idea/** [INFO] Exclude: package.json [INFO] Exclude: public/** [INFO] Exclude: public-static/** [INFO] Exclude: app/assets/** [INFO] Exclude: vendor/** [INFO] Exclude: node_modules/** [INFO] Exclude: node/** [INFO] Exclude: npm-debug.log [INFO] 1169 resources included (use -debug for more details) Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. Compiler warnings: WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.' Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1169 licence. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 49.809s [INFO] Finished at: Fri Jul 31 18:39:11 PDT 2015 [INFO] Final Memory: 12M/439M [INFO] Thanks, Vivek Ratnavel Subramanian
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Attachment: AMBARI-12615.patch Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 Attachments: AMBARI-12615.patch There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Description: There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 37003: Add Data Visualization to Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37003/ --- Review request for Ambari and Yusaku Sako. Bugs: AMBARI-12615 https://issues.apache.org/jira/browse/AMBARI-12615 Repository: ambari Description --- Refer to the description in AMBARI-12615 Diffs - ambari-web/app/views/main/views/details.js e90cb20 contrib/views/hive/pom.xml 39f6848 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java a0d44f5 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java 526f13f contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 18152ad contrib/views/hive/src/main/resources/ui/hive-web/.jshintrc c1fe863 contrib/views/hive/src/main/resources/ui/hive-web/app/components/visualization-tabs-widget.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/query-tabs.js 4f5176c contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visualization-ui.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js af5e3a7 contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/visualization-tabs-widget.hbs PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/templates/visualization-ui.hbs PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js e4e445a contrib/views/hive/src/main/resources/ui/hive-web/app/views/visualization-ui.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/bower.json 37ea901 Diff: https://reviews.apache.org/r/37003/diff/ Testing --- Tested manually with different datasets of different size. Tested switching to visualization tab with multiple SQL tabs having different queries. Tested switching between the two visualization tabs multiple times. Tested with upto 3 rows in the resultset with all possible combinations of scale and chart types. Tested with Google Chrome, Safari, Firefox and Internet Explorer 10. Tested end to end with Ambari Web and Hive View. Existing Ambari Web unit tests pass. 6482 tests complete (22 seconds) 94 tests pending [INFO] [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web --- [INFO] 51 implicit excludes (use -debug for more details). [INFO] Exclude: .idea/** [INFO] Exclude: package.json [INFO] Exclude: public/** [INFO] Exclude: public-static/** [INFO] Exclude: app/assets/** [INFO] Exclude: vendor/** [INFO] Exclude: node_modules/** [INFO] Exclude: node/** [INFO] Exclude: npm-debug.log [INFO] 1169 resources included (use -debug for more details) Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. Compiler warnings: WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.' Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1169 licence. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 49.809s [INFO] Finished at: Fri Jul 31 18:39:11 PDT 2015 [INFO] Final Memory: 12M/439M [INFO] Thanks, Vivek Ratnavel Subramanian
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: External issue URL: https://reviews.apache.org/r/37003/ Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Attachment: AMBARI-12615.patch Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 Attachments: AMBARI-12615.patch There is no existing visualization tool to visualize the result set data in Hive View. Hive view should support a visualization tool with the following features. 1) Ability to visualize result set data in Hive View. 2) Ability to visualize multiple dimensions in the result set with different types of charts 3) Support all modern browsers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMBARI-12615) Add Data Visualization to Hive View
[ https://issues.apache.org/jira/browse/AMBARI-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12615: Summary: Add Data Visualization to Hive View (was: Data Visualization to Hive View) Add Data Visualization to Hive View --- Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AMBARI-12615) Data Visualization to Hive View
Vivek Ratnavel Subramanian created AMBARI-12615: --- Summary: Data Visualization to Hive View Key: AMBARI-12615 URL: https://issues.apache.org/jira/browse/AMBARI-12615 Project: Ambari Issue Type: New Feature Components: ambari-views Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Assignee: Vivek Ratnavel Subramanian Fix For: 2.2.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 36806: Enabling full screen for ambari views iframe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36806/ --- (Updated July 31, 2015, 10:10 p.m.) Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-12542 https://issues.apache.org/jira/browse/AMBARI-12542 Repository: ambari Description --- The allowfullscreen attribute of iframe needs to be set to true for the components in the iframe to toggle full screen. The iframe tag used in ambari-web to display different views does not have this attribute enabled. This is required for the visualization component of hive views to toggle full screen. Diffs - ambari-web/app/views/main/views/details.js e90cb20 Diff: https://reviews.apache.org/r/36806/diff/ Testing (updated) --- Tested end to end with Hive View and new Data Visualization feature being worked on via AMBARI-12615. Existing Ambari Web unit tests pass. [92m [0m[32m 6478 tests complete[0m[90m (10 seconds)[0m [36m [0m[36m 94 tests pending[0m [INFO] [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web --- [INFO] 51 implicit excludes (use -debug for more details). [INFO] Exclude: .idea/** [INFO] Exclude: package.json [INFO] Exclude: public/** [INFO] Exclude: public-static/** [INFO] Exclude: app/assets/** [INFO] Exclude: vendor/** [INFO] Exclude: node_modules/** [INFO] Exclude: node/** [INFO] Exclude: npm-debug.log [INFO] 1192 resources included (use -debug for more details) [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1192 licence. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 22.258s [INFO] Finished at: Fri Jul 24 18:17:49 PDT 2015 [INFO] Final Memory: 10M/308M [INFO] Thanks, Vivek Ratnavel Subramanian
Re: Review Request 36806: Enabling full screen for ambari views iframe
On July 25, 2015, 2:58 p.m., Yusaku Sako wrote: Next time, you can just paste the summary of the unit test results (X passed, etc). Sure, thanks. - Vivek Ratnavel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36806/#review93031 --- On July 25, 2015, 1:26 a.m., Vivek Ratnavel Subramanian wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36806/ --- (Updated July 25, 2015, 1:26 a.m.) Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-12542 https://issues.apache.org/jira/browse/AMBARI-12542 Repository: ambari Description --- The allowfullscreen attribute of iframe needs to be set to true for the components in the iframe to toggle full screen. The iframe tag used in ambari-web to display different views does not have this attribute enabled. This is required for the visualization component of hive views to toggle full screen. Diffs - ambari-web/app/views/main/views/details.js e90cb20 Diff: https://reviews.apache.org/r/36806/diff/ Testing --- [INFO] Scanning for projects... [INFO] [INFO] [INFO] Building Ambari Web 2.0.0-SNAPSHOT [INFO] [INFO] [INFO] --- build-helper-maven-plugin:1.8:regex-property (parse-package-version) @ ambari-web --- [INFO] [INFO] --- build-helper-maven-plugin:1.8:regex-property (parse-package-release) @ ambari-web --- [INFO] [INFO] --- build-helper-maven-plugin:1.8:parse-version (parse-version) @ ambari-web --- [INFO] [INFO] --- build-helper-maven-plugin:1.8:regex-property (regex-property) @ ambari-web --- [INFO] [INFO] --- exec-maven-plugin:1.2.1:exec (compile-npm) @ ambari-web --- [INFO] [INFO] --- exec-maven-plugin:1.2.1:exec (compile-brunch) @ ambari-web --- 24 Jul 18:17:33 - [32minfo[0m: compiled 1018 files into 5 files, copied 314 in 3838ms [INFO] [INFO] --- exec-maven-plugin:1.2.1:exec (set-ambari-version) @ ambari-web --- Setting Ambari version to 2.0.0 [INFO] [INFO] --- exec-maven-plugin:1.2.1:exec (set-default-stack-version) @ ambari-web --- [INFO] [INFO] --- exec-maven-plugin:1.2.1:exec (toggle-experimental) @ ambari-web --- [INFO] [INFO] --- exec-maven-plugin:1.2.1:exec (ambari-web unit tests) @ ambari-web --- Ambari@2.1.0 test /Users/vsubramanian/Downloads/ambari-vagrant/centos6.4/ambari/ambari-web mocha-phantomjs -R min public/test/test.html CLDR.pluralForm not found. Em.I18n will not support count-based inflection. doing a cleanup TRACE: Entering db:cleanup function In cleanup./.. Trace: Entering db:getAuthenticated function STATEMANAGER: Entering root TRACE: Entering db:getUser function TRACE: Entering db:getupgradeId TRACE: Entering db:getupgradeVersion TRACE: Entering db:getcurrentVersion TRACE: Entering db:getisDowngrade Trace: Entering db:getLoginName function Trace: Entering db:getWizardCurrentStep function for kerberosWizard getWizardCurrentStep: loginName=, currentStep=undefined returning currentStep=1 Trace: Entering db:getLoginName function Trace: Entering db:getWizardCurrentStep function for kerberosProgressPage getWizardCurrentStep: loginName=, currentStep=0 returning currentStep=1 Trace: Entering db:getLoginName function Trace: Entering db:getWizardCurrentStep function for kerberosDisable getWizardCurrentStep: loginName=, currentStep=undefined returning currentStep=1 Trace: Entering db:getLoginName function Trace: Entering db:getWizardCurrentStep function for kerberosWizardStep3 getWizardCurrentStep: loginName=, currentStep=0 returning currentStep=1 Trace: Entering db:getLoginName function Trace: Entering db:getWizardCurrentStep function for kerberosWizardStep5 getWizardCurrentStep: loginName=, currentStep=0 returning currentStep=1 Trace: Entering db:getLoginName function Trace: Entering db:getWizardCurrentStep function for kerberosWizardStep6 getWizardCurrentStep: loginName=, currentStep=0 returning currentStep=1 Trace: Entering db:getLoginName function Trace: Entering db:getWizardCurrentStep function for kerberosWizardStep7 getWizardCurrentStep: loginName=, currentStep=0 returning currentStep=1 Trace: Entering db:getLoginName function Trace: Entering db:getWizardCurrentStep function for kerberosWizardStep8 getWizardCurrentStep: loginName=, currentStep=0 returning currentStep=1 Trace: Entering db:getLoginName function Trace: Entering db:getWizardCurrentStep function for widgetWizard
[jira] [Updated] (AMBARI-12542) Enabling full screen for ambari views iframe
[ https://issues.apache.org/jira/browse/AMBARI-12542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12542: External issue URL: https://reviews.apache.org/r/36806/ Enabling full screen for ambari views iframe - Key: AMBARI-12542 URL: https://issues.apache.org/jira/browse/AMBARI-12542 Project: Ambari Issue Type: Task Components: ambari-web Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Fix For: 2.2.0 Attachments: AMBARI-12542.patch The allowfullscreen attribute of iframe needs to be set to true for the components in the iframe to toggle full screen. The iframe tag used in ambari-web to display different views does not have this attribute enabled. This is required for the visualization component of hive views to toggle full screen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 36806: Enabling full screen for ambari views iframe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36806/ --- Review request for Ambari. Repository: ambari Description --- The allowfullscreen attribute of iframe needs to be set to true for the components in the iframe to toggle full screen. The iframe tag used in ambari-web to display different views does not have this attribute enabled. This is required for the visualization component of hive views to toggle full screen. Diffs - ambari-web/app/views/main/views/details.js e90cb20 Diff: https://reviews.apache.org/r/36806/diff/ Testing --- Thanks, Vivek Ratnavel Subramanian
[jira] [Created] (AMBARI-12542) Enabling full screen for ambari views iframe
Vivek Ratnavel Subramanian created AMBARI-12542: --- Summary: Enabling full screen for ambari views iframe Key: AMBARI-12542 URL: https://issues.apache.org/jira/browse/AMBARI-12542 Project: Ambari Issue Type: Task Components: ambari-web Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Fix For: 2.2.0 The allowfullscreen attribute of iframe needs to be set to true for the components in the iframe to toggle full screen. The iframe tag used in ambari-web to display different views does not have this attribute enabled. This is required for the visualization component of hive views to toggle full screen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMBARI-12542) Enabling full screen for ambari views iframe
[ https://issues.apache.org/jira/browse/AMBARI-12542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated AMBARI-12542: Attachment: AMBARI-12542.patch Enabling full screen for ambari views iframe - Key: AMBARI-12542 URL: https://issues.apache.org/jira/browse/AMBARI-12542 Project: Ambari Issue Type: Task Components: ambari-web Affects Versions: 2.2.0 Reporter: Vivek Ratnavel Subramanian Fix For: 2.2.0 Attachments: AMBARI-12542.patch The allowfullscreen attribute of iframe needs to be set to true for the components in the iframe to toggle full screen. The iframe tag used in ambari-web to display different views does not have this attribute enabled. This is required for the visualization component of hive views to toggle full screen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 36806: Enabling full screen for ambari views iframe
function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
TRACE: Entering db:cleanup function
In cleanup./..
Calling set on destroyed view
Calling set on destroyed view
Calling set on destroyed view
Calling set on destroyed view
TRACE: Entering db:getStartIndex function
TRACE: Entering db:getDisplayLength function
TRACE: Entering db:getStartIndex function
TRACE: Entering db:getDisplayLength function
/views/ADMIN_VIEW/2.1.0/INSTANCE/#/stackVersions
Got persist value from server with key undefined. Value is: [object Object]
Got persist value from server with key undefined. Value is: [object Object]
[{isClient:true,service:{serviceName:WITH_CONFIGS}},{isClient:true,service:{serviceName:WITHOUT_CONFIGS}},{isClient:false,service:{serviceName:SAMPLE_SERVICE}}]
TRACE: Entering db:setFilterConditions function
TRACE: Inside success view step9
TRACE: Inside success view step9
TRACE: Inside success view step9
TRACE: Inside error view step9
TRACE: Inside error view step9
TRACE: Inside error view step9
TRACE: Inside error view step9
TRACE: Inside error view step9
TRACE: Inside error view step9
TRACE: Inside error view step9
TRACE: Inside error view step9
App.supports.sup0 = true
App.supports.sup1 = false
Configuration test is randomized
TRACE: Entering db:getUser function
Trace: Entering db:getLoginName function
TRACE: Entering db:setUser function
TRACE: Entering db:setLoginName function
field0 IS INVALID : This is required
FORM FIELD VALUE: true
displayName = HDFS
displayName = YARN
new_password IS INVALID : This is required
password IS INVALID : This is required
passwordRetype IS INVALID : This is required
[92m [0m[32m 6478 tests complete[0m[90m (10 seconds)[0m
[36m [0m[36m 94 tests pending[0m
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .idea/**
[INFO] Exclude: package.json
[INFO] Exclude: public/**
[INFO] Exclude: public-static/**
[INFO] Exclude: app/assets/**
[INFO] Exclude: vendor/**
[INFO] Exclude: node_modules/**
[INFO] Exclude: node/**
[INFO] Exclude: npm-debug.log
[INFO] 1192 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0
approved: 1192 licence.
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 22.258s
[INFO] Finished at: Fri Jul 24 18:17:49 PDT 2015
[INFO] Final Memory: 10M/308M
[INFO]
Thanks,
Vivek Ratnavel Subramanian
