Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-07 Thread Keta Patel


> On March 7, 2016, 10:18 p.m., Di Li wrote:
> > ambari-web/app/templates/main/host/details/host_component.hbs, line 30
> > 
> >
> > How is the service name displayed when the component name is extra 
> > long, in relation to the new divs added ?
> > 
> > The service name should be visible so that user can navigate back to 
> > the corresponding service.
> > 
> > What about fixing the width of the component name and trancate it with 
> > ... when it reaches the limite.
> > 
> > For example, ExtraLongZookeeperComponentName would be dispalyed as 
> > 
> > ExtraLongZook.../Zookeeper
> > 
> > The ExtraLongZookeeperComponentName is still displayed on zookeeper's 
> > dashboard where user can hover over to reveal the host name, yes ?

Hello Di,
I have attached a screenshot "Extra Long Service Names with Fix.tiff" on the 
Jira which shows how extra long service names look with the current fix.
Yes, you are right about the entire service name being displayed on the 
dashboard's navigation menu on the left side.
I am looking into how we could use "..." or flyouts for this issue.
Thanks!


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122388
---


On March 7, 2016, 9:57 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> ---
> 
> (Updated March 7, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Ambari UI, navigate to Hosts and click on the hostname where the service 
> is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon 
> etc. spills to the next line (see attachment "Original spacing with long 
> service name").
> Also, note the indentation of the last button for Clients does not align well 
> with the buttons above it.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 755dff2 
>   ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
>   ambari-web/app/templates/main/host/summary.hbs 17a0b69 
> 
> Diff: https://reviews.apache.org/r/44457/diff/
> 
> 
> Testing
> ---
> 
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component 
> was fixed in a  tag.
> The fix here also uses a similar approach where every component is surrounded 
> by a  tag and the width is fixed for them so that the appear in their 
> respective positions regardless of the length of service names. I have also 
> adjusted the width of the left  component with "span8" instead of 
> "span7" and the right  component of the button to "span4" instead of 
> "span5" to better adjust the spacing.
> 
> TESTS:
> No tests are written for these changes as the fix involves updates in the 
> stylesheet.
> However, the changes were tested by zooming in and out and checking if the 
> icons and names were contained in their respective blocks and not overlapping 
> with other  blocks.
> 
> 
> The following is the result of running ambari-web tests:
> 
>   24565 tests complete (28 seconds)
>   145 tests pending
> 
> 
> File Attachments
> 
> 
> AMBARI-15310 (patch-2)
>   
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>



Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-07 Thread Keta Patel


> On March 7, 2016, 10:24 p.m., Di Li wrote:
> > ambari-web/app/templates/main/host/details/host_component.hbs, line 40
> > 
> >
> > In additional to a fixed width (number of chars) field, it'd also be 
> > much more flexible to use a flyout. User simply mouses over the component 
> > name and the flyout  appears with the fullname. User mouses away from the 
> > component name, the flyout disappears.

Hello Di,
I am looking into this issue of using flyout.
Thanks!


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122390
---


On March 7, 2016, 9:57 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> ---
> 
> (Updated March 7, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Ambari UI, navigate to Hosts and click on the hostname where the service 
> is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon 
> etc. spills to the next line (see attachment "Original spacing with long 
> service name").
> Also, note the indentation of the last button for Clients does not align well 
> with the buttons above it.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 755dff2 
>   ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
>   ambari-web/app/templates/main/host/summary.hbs 17a0b69 
> 
> Diff: https://reviews.apache.org/r/44457/diff/
> 
> 
> Testing
> ---
> 
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component 
> was fixed in a  tag.
> The fix here also uses a similar approach where every component is surrounded 
> by a  tag and the width is fixed for them so that the appear in their 
> respective positions regardless of the length of service names. I have also 
> adjusted the width of the left  component with "span8" instead of 
> "span7" and the right  component of the button to "span4" instead of 
> "span5" to better adjust the spacing.
> 
> TESTS:
> No tests are written for these changes as the fix involves updates in the 
> stylesheet.
> However, the changes were tested by zooming in and out and checking if the 
> icons and names were contained in their respective blocks and not overlapping 
> with other  blocks.
> 
> 
> The following is the result of running ambari-web tests:
> 
>   24565 tests complete (28 seconds)
>   145 tests pending
> 
> 
> File Attachments
> 
> 
> AMBARI-15310 (patch-2)
>   
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>



Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-07 Thread Keta Patel


> On March 7, 2016, 10:03 p.m., Alejandro Fernandez wrote:
> > ambari-web/app/templates/main/host/summary.hbs, line 71
> > 
> >
> > In the image for "Updated Fix (Mar-07).tiff" the component name of 
> > "ZOOKEEPER SERVER" is missing.

Hello Alexandr,
I was testing the length for long component names and I updated the "Zookeeper" 
text with ".." as you can see in the line below 
"Zookeeper Server". 
There was also a space added following component names in the original code, 
which I removed (you can see how the dots stop right at the right border of the 
 block). This space was originally added to separate the name from the 
icons appearing after it. Since we are providing  blocks to each of the 
elements, I have added padding in the medkit-icon-block to adjust this spacing.
Thanks!


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122386
---


On March 7, 2016, 9:57 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> ---
> 
> (Updated March 7, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Ambari UI, navigate to Hosts and click on the hostname where the service 
> is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon 
> etc. spills to the next line (see attachment "Original spacing with long 
> service name").
> Also, note the indentation of the last button for Clients does not align well 
> with the buttons above it.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 755dff2 
>   ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
>   ambari-web/app/templates/main/host/summary.hbs 17a0b69 
> 
> Diff: https://reviews.apache.org/r/44457/diff/
> 
> 
> Testing
> ---
> 
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component 
> was fixed in a  tag.
> The fix here also uses a similar approach where every component is surrounded 
> by a  tag and the width is fixed for them so that the appear in their 
> respective positions regardless of the length of service names. I have also 
> adjusted the width of the left  component with "span8" instead of 
> "span7" and the right  component of the button to "span4" instead of 
> "span5" to better adjust the spacing.
> 
> TESTS:
> No tests are written for these changes as the fix involves updates in the 
> stylesheet.
> However, the changes were tested by zooming in and out and checking if the 
> icons and names were contained in their respective blocks and not overlapping 
> with other  blocks.
> 
> 
> The following is the result of running ambari-web tests:
> 
>   24565 tests complete (28 seconds)
>   145 tests pending
> 
> 
> File Attachments
> 
> 
> AMBARI-15310 (patch-2)
>   
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>



Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-07 Thread Di Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122390
---




ambari-web/app/templates/main/host/details/host_component.hbs (line 40)


In additional to a fixed width (number of chars) field, it'd also be much 
more flexible to use a flyout. User simply mouses over the component name and 
the flyout  appears with the fullname. User mouses away from the component 
name, the flyout disappears.


- Di Li


On March 7, 2016, 9:57 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> ---
> 
> (Updated March 7, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Ambari UI, navigate to Hosts and click on the hostname where the service 
> is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon 
> etc. spills to the next line (see attachment "Original spacing with long 
> service name").
> Also, note the indentation of the last button for Clients does not align well 
> with the buttons above it.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 755dff2 
>   ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
>   ambari-web/app/templates/main/host/summary.hbs 17a0b69 
> 
> Diff: https://reviews.apache.org/r/44457/diff/
> 
> 
> Testing
> ---
> 
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component 
> was fixed in a  tag.
> The fix here also uses a similar approach where every component is surrounded 
> by a  tag and the width is fixed for them so that the appear in their 
> respective positions regardless of the length of service names. I have also 
> adjusted the width of the left  component with "span8" instead of 
> "span7" and the right  component of the button to "span4" instead of 
> "span5" to better adjust the spacing.
> 
> TESTS:
> No tests are written for these changes as the fix involves updates in the 
> stylesheet.
> However, the changes were tested by zooming in and out and checking if the 
> icons and names were contained in their respective blocks and not overlapping 
> with other  blocks.
> 
> 
> The following is the result of running ambari-web tests:
> 
>   24565 tests complete (28 seconds)
>   145 tests pending
> 
> 
> File Attachments
> 
> 
> AMBARI-15310 (patch-2)
>   
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>



Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-07 Thread Di Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122388
---




ambari-web/app/templates/main/host/details/host_component.hbs (line 30)


How is the service name displayed when the component name is extra long, in 
relation to the new divs added ?

The service name should be visible so that user can navigate back to the 
corresponding service.

What about fixing the width of the component name and trancate it with ... 
when it reaches the limite.

For example, ExtraLongZookeeperComponentName would be dispalyed as 

ExtraLongZook.../Zookeeper

The ExtraLongZookeeperComponentName is still displayed on zookeeper's 
dashboard where user can hover over to reveal the host name, yes ?


- Di Li


On March 7, 2016, 9:57 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> ---
> 
> (Updated March 7, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Ambari UI, navigate to Hosts and click on the hostname where the service 
> is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon 
> etc. spills to the next line (see attachment "Original spacing with long 
> service name").
> Also, note the indentation of the last button for Clients does not align well 
> with the buttons above it.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 755dff2 
>   ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
>   ambari-web/app/templates/main/host/summary.hbs 17a0b69 
> 
> Diff: https://reviews.apache.org/r/44457/diff/
> 
> 
> Testing
> ---
> 
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component 
> was fixed in a  tag.
> The fix here also uses a similar approach where every component is surrounded 
> by a  tag and the width is fixed for them so that the appear in their 
> respective positions regardless of the length of service names. I have also 
> adjusted the width of the left  component with "span8" instead of 
> "span7" and the right  component of the button to "span4" instead of 
> "span5" to better adjust the spacing.
> 
> TESTS:
> No tests are written for these changes as the fix involves updates in the 
> stylesheet.
> However, the changes were tested by zooming in and out and checking if the 
> icons and names were contained in their respective blocks and not overlapping 
> with other  blocks.
> 
> 
> The following is the result of running ambari-web tests:
> 
>   24565 tests complete (28 seconds)
>   145 tests pending
> 
> 
> File Attachments
> 
> 
> AMBARI-15310 (patch-2)
>   
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>



Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-07 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122386
---




ambari-web/app/templates/main/host/summary.hbs (line 71)


In the image for "Updated Fix (Mar-07).tiff" the component name of 
"ZOOKEEPER SERVER" is missing.


- Alejandro Fernandez


On March 7, 2016, 9:57 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> ---
> 
> (Updated March 7, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Ambari UI, navigate to Hosts and click on the hostname where the service 
> is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon 
> etc. spills to the next line (see attachment "Original spacing with long 
> service name").
> Also, note the indentation of the last button for Clients does not align well 
> with the buttons above it.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 755dff2 
>   ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
>   ambari-web/app/templates/main/host/summary.hbs 17a0b69 
> 
> Diff: https://reviews.apache.org/r/44457/diff/
> 
> 
> Testing
> ---
> 
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component 
> was fixed in a  tag.
> The fix here also uses a similar approach where every component is surrounded 
> by a  tag and the width is fixed for them so that the appear in their 
> respective positions regardless of the length of service names. I have also 
> adjusted the width of the left  component with "span8" instead of 
> "span7" and the right  component of the button to "span4" instead of 
> "span5" to better adjust the spacing.
> 
> TESTS:
> No tests are written for these changes as the fix involves updates in the 
> stylesheet.
> However, the changes were tested by zooming in and out and checking if the 
> icons and names were contained in their respective blocks and not overlapping 
> with other  blocks.
> 
> 
> The following is the result of running ambari-web tests:
> 
>   24565 tests complete (28 seconds)
>   145 tests pending
> 
> 
> File Attachments
> 
> 
> AMBARI-15310 (patch-2)
>   
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>



Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-07 Thread Keta Patel


> On March 7, 2016, 7:49 p.m., Alexandr Antonenko wrote:
> > Ship It!

Hello Alexandr,
I have updated the patch with some more minor changes that I found while 
zooming in. 
Kindly please have a look at the final updated patch labeled "AMBARI-15310 
(patch-2)".

Thank you!
Keta


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122361
---


On March 7, 2016, 9:57 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> ---
> 
> (Updated March 7, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Ambari UI, navigate to Hosts and click on the hostname where the service 
> is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon 
> etc. spills to the next line (see attachment "Original spacing with long 
> service name").
> Also, note the indentation of the last button for Clients does not align well 
> with the buttons above it.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 755dff2 
>   ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
>   ambari-web/app/templates/main/host/summary.hbs 17a0b69 
> 
> Diff: https://reviews.apache.org/r/44457/diff/
> 
> 
> Testing
> ---
> 
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component 
> was fixed in a  tag.
> The fix here also uses a similar approach where every component is surrounded 
> by a  tag and the width is fixed for them so that the appear in their 
> respective positions regardless of the length of service names. I have also 
> adjusted the width of the left  component with "span8" instead of 
> "span7" and the right  component of the button to "span4" instead of 
> "span5" to better adjust the spacing.
> 
> TESTS:
> No tests are written for these changes as the fix involves updates in the 
> stylesheet.
> However, the changes were tested by zooming in and out and checking if the 
> icons and names were contained in their respective blocks and not overlapping 
> with other  blocks.
> 
> 
> The following is the result of running ambari-web tests:
> 
>   24565 tests complete (28 seconds)
>   145 tests pending
> 
> 
> File Attachments
> 
> 
> AMBARI-15310 (patch-2)
>   
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>



Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-07 Thread Keta Patel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
---

(Updated March 7, 2016, 9:57 p.m.)


Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310


Repository: ambari


Description
---

In Ambari UI, navigate to Hosts and click on the hostname where the service is 
installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. 
spills to the next line (see attachment "Original spacing with long service 
name").
Also, note the indentation of the last button for Clients does not align well 
with the buttons above it.


Diffs
-

  ambari-web/app/styles/application.less 755dff2 
  ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
  ambari-web/app/templates/main/host/summary.hbs 17a0b69 

Diff: https://reviews.apache.org/r/44457/diff/


Testing (updated)
---

FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was 
fixed in a  tag.
The fix here also uses a similar approach where every component is surrounded 
by a  tag and the width is fixed for them so that the appear in their 
respective positions regardless of the length of service names. I have also 
adjusted the width of the left  component with "span8" instead of "span7" 
and the right  component of the button to "span4" instead of "span5" to 
better adjust the spacing.

TESTS:
No tests are written for these changes as the fix involves updates in the 
stylesheet.
However, the changes were tested by zooming in and out and checking if the 
icons and names were contained in their respective blocks and not overlapping 
with other  blocks.


The following is the result of running ambari-web tests:

  24565 tests complete (28 seconds)
  145 tests pending


File Attachments (updated)


AMBARI-15310 (patch-2)
  
https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch


Thanks,

Keta Patel



Re: Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-07 Thread Alexandr Antonenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122361
---


Ship it!




Ship It!

- Alexandr Antonenko


On March 7, 2016, 4:59 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> ---
> 
> (Updated March 7, 2016, 4:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Ambari UI, navigate to Hosts and click on the hostname where the service 
> is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon 
> etc. spills to the next line (see attachment "Original spacing with long 
> service name").
> Also, note the indentation of the last button for Clients does not align well 
> with the buttons above it.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 755dff2 
>   ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
>   ambari-web/app/templates/main/host/summary.hbs 17a0b69 
> 
> Diff: https://reviews.apache.org/r/44457/diff/
> 
> 
> Testing
> ---
> 
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component 
> was fixed in a  tag.
> The fix here also uses a similar approach where every component is surrounded 
> by a  tag and the width is fixed for them so that the appear in their 
> respective positions regardless of the length of service names. I have also 
> adjusted the width of the left  component with "span8" instead of 
> "span7" and the right  component of the button to "span4" instead of 
> "span5" to better adjust the spacing.
> 
> TESTS:
> No tests are written for these changes as the fix involves updates in the 
> stylesheet.
> 
> 
> Thanks,
> 
> Keta Patel
> 
>



Review Request 44457: AMBARI-15310: Host Service Summary Page does not display long service names well

2016-03-07 Thread Keta Patel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
---

Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310


Repository: ambari


Description
---

In Ambari UI, navigate to Hosts and click on the hostname where the service is 
installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. 
spills to the next line (see attachment "Original spacing with long service 
name").
Also, note the indentation of the last button for Clients does not align well 
with the buttons above it.


Diffs
-

  ambari-web/app/styles/application.less 755dff2 
  ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
  ambari-web/app/templates/main/host/summary.hbs 17a0b69 

Diff: https://reviews.apache.org/r/44457/diff/


Testing
---

FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was 
fixed in a  tag.
The fix here also uses a similar approach where every component is surrounded 
by a  tag and the width is fixed for them so that the appear in their 
respective positions regardless of the length of service names. I have also 
adjusted the width of the left  component with "span8" instead of "span7" 
and the right  component of the button to "span4" instead of "span5" to 
better adjust the spacing.

TESTS:
No tests are written for these changes as the fix involves updates in the 
stylesheet.


Thanks,

Keta Patel