Re: [PR] AMBARI-26000: Make Ambari supports Python3 environment [ambari]
arshadmohammad commented on code in PR #3751: URL: https://github.com/apache/ambari/pull/3751#discussion_r1374896426 ## ambari-server/src/main/resources/common-services/AMBARI_METRICS/3.0.0/package/scripts/metrics_collector.py: ## @@ -22,21 +22,21 @@ from resource_management.libraries.functions.security_commons import build_expectations, \ cached_kinit_executor, get_params_from_filesystem, validate_security_config_properties, \ FILE_TYPE_XML -from ams import ams -from ams_service import ams_service -from hbase import hbase -from status import check_service_status +from scripts.ams import ams Review Comment: Ambari metrics collector start is failing with following error `Traceback (most recent call last): File "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/3.0.0/package/scripts/metrics_collector.py", line 25, in from scripts.ams import ams ModuleNotFoundError: No module named 'scripts' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26009: Add Rocky8 operating system support [ambari]
arshadmohammad commented on code in PR #3758: URL: https://github.com/apache/ambari/pull/3758#discussion_r1374901412 ## ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/repos/repoinfo.xml: ## @@ -23,4 +23,11 @@ bigtop + Review Comment: make this change in BIGTOP 3.3.0 also, seems this repoinfo is not inheritted in higher stack version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26000: Make Ambari supports Python3 environment [ambari]
arshadmohammad commented on code in PR #3751: URL: https://github.com/apache/ambari/pull/3751#discussion_r1374894047 ## ambari-common/src/main/python/ambari_commons/repo_manager/yum_manager.py: ## @@ -352,7 +330,7 @@ def rpm_check_package_available(self, name): regex = re.compile(name_regex) for package in packages: - if regex.match(package['name']): + if regex.match(package['name'].decode()): Review Comment: This is not working, it is failing with following error `2023-10-27 19:00:36,138 - Reporting component version failed Traceback (most recent call last): File "/usr/lib/ambari-agent/lib/resource_management/libraries/script/script.py", line 354, in execute method(env) File "/var/lib/ambari-agent/cache/stack-hooks/before-INSTALL/scripts/hook.py", line 33, in hook install_packages() File "/var/lib/ambari-agent/cache/stack-hooks/before-INSTALL/scripts/shared_initialization.py", line 37, in install_packages retry_count=params.agent_stack_retry_count) File "/usr/lib/ambari-agent/lib/resource_management/core/base.py", line 123, in __new__ cls(names_list.pop(0), env, provider, **kwargs) File "/usr/lib/ambari-agent/lib/resource_management/core/base.py", line 164, in __init__ self.env.run() File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", line 163, in run self.run_action(resource, action) File "/usr/lib/ambari-agent/lib/resource_management/core/environment.py", line 127, in run_action provider_action() File "/usr/lib/ambari-agent/lib/resource_management/core/providers/packaging.py", line 30, in action_install self._pkg_manager.install_package(package_name, self.__create_context()) File "/usr/lib/ambari-agent/lib/ambari_commons/repo_manager/yum_manager.py", line 211, in install_package elif not self._check_existence(name) or context.action_force: File "/usr/lib/ambari-agent/lib/ambari_commons/repo_manager/yum_manager.py", line 279, in _check_existence return self.rpm_check_package_available(name) File "/usr/lib/ambari-agent/lib/ambari_commons/repo_manager/yum_manager.py", line 333, in rpm_check_package_available if regex.match(package['name'].decode()): AttributeError: 'str' object has no attribute 'decode'` package['name'] is already unicode_string, no need to decode it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
Re: [PR] AMBARI-26000: Make Ambari supports Python3 environment [ambari]
arshadmohammad commented on PR #3751:
URL: https://github.com/apache/ambari/pull/3751#issuecomment-1783426982
> Therefore, on Rocky8, the old python2 soft link needs to be deleted, and
create a new one using ln -s /usr/bin/python3 /usr/bin/python.
I am using rocky linux 8.8, it does not have python2 installed on it. It has
only python 3.6. So the build failure was not related to python version. But
the build failure is because some files do not have shebang as expected. I
skipped the shebang validation with %global __brp_mangle_shebangs %{nil} for
time being, we can check this part later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org
