DO NOT REPLY [Bug 19099] - [PATCH] add resultproperty support to java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19099. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19099 [PATCH] add resultproperty support to java --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 00:25 --- Attachment now attached. Donal
Re: ant tutorial
On Thu, 17 Apr 2003 01:01 am, Craeg Strong wrote: This tutorial is incredibly valuable, IMO. I would love to see this checked into CVS and given a permanent home on the ant website, kind of like ant in anger... 2c, Thanks for the positive feedback. I am intending to write a series of tutorials on Ant at a few different levels (beginners, build file writers, task writers, core developers). http://codefeed.com/tutorial/ While I do have an outline of things I want to cover, suggestions for topics are welcome. I'm not sure about putting this into Ant's CVS just yet - I want to develop it all a bit more and see where it goes. Conor
Re: ant tutorial
On Thu, 17 Apr 2003 02:43 am, Gus Heck wrote:
I agree. This is really cool. The section labeled Top Level Tasks
seems to say that tasks on the top level are run at parse-time. Does
this mean that the order of tasks at the top level is the order of
execution, or do the old toplevel tasks still run first?
In 1.6 all top-level tasks are gathered, in build-file order, into an
invisible target which is executed at the end of parsing (so technically, not
at parse-time). There is no distinction between old top-level tasks and other
tasks.
So, given this build,
project name=toplevel default=main
echo message=Task 1 test.prop=${test.prop}/
target name=main
echo message=Task 2 test.prop=${test.prop}/
/target
property name=test.prop value=fubar/
echo message=Task 3 test.prop=${test.prop}/
/project
the output is
Buildfile: build.xml
[echo] Task 1 test.prop=${test.prop}
[echo] Task 3 test.prop=fubar
main:
[echo] Task 2 test.prop=fubar
BUILD SUCCESSFUL
So, still somethings to be careful about :-)
Conor
DO NOT REPLY [Bug 19101] New: - Project.fireMessageLoggedEvent performance fix
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19101. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19101 Project.fireMessageLoggedEvent performance fix Summary: Project.fireMessageLoggedEvent performance fix Product: Ant Version: 1.5.3 Platform: Macintosh OS/Version: MacOS X Status: NEW Severity: Minor Priority: Other Component: Core AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] In trying to speed up my builds, I ran ant with the -Xprof option to see what what slow. According to the profiler, an inordinate amount of time was being spent in Vector.size(). The profiler also showed that Project.fireMessageLoggedEvent() was chewing up a lot of time, so I started looking there. It turns out a simple optimization sped up my build from 1:45 to 1:30 (about 15%). The optimization is to pull the call to listeners.size() out of the loop.
DO NOT REPLY [Bug 19101] - Project.fireMessageLoggedEvent performance fix
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19101. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19101 Project.fireMessageLoggedEvent performance fix --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 02:16 --- Created an attachment (id=5871) Xprof profile from Ant 1.5.3-1
DO NOT REPLY [Bug 19101] - Project.fireMessageLoggedEvent performance fix
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19101. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19101 Project.fireMessageLoggedEvent performance fix --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 02:17 --- Created an attachment (id=5872) Xprof profile from ant 1.5.3-1 with fix described in bug report
cvs commit: ant/src/main/org/apache/tools/ant Project.java
conor 2003/04/16 21:50:27
Modified:src/main/org/apache/tools/ant Project.java
Log:
Improve event dispatch performance (OK because we are using a cloned
list of listeners)
PR: 19101
Submiitted By:smagoun from mac.com
Revision ChangesPath
1.137 +16 -9 ant/src/main/org/apache/tools/ant/Project.java
Index: Project.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/Project.java,v
retrieving revision 1.136
retrieving revision 1.137
diff -u -w -u -r1.136 -r1.137
--- Project.java 15 Apr 2003 17:23:15 - 1.136
+++ Project.java 17 Apr 2003 04:50:27 - 1.137
@@ -1958,7 +1958,8 @@
public void fireBuildStarted() {
BuildEvent event = new BuildEvent(this);
Vector listeners = getBuildListeners();
-for (int i = 0; i listeners.size(); i++) {
+int size = listeners.size();
+for (int i = 0; i size; i++) {
BuildListener listener = (BuildListener) listeners.elementAt(i);
listener.buildStarted(event);
}
@@ -1974,7 +1975,8 @@
BuildEvent event = new BuildEvent(this);
event.setException(exception);
Vector listeners = getBuildListeners();
-for (int i = 0; i listeners.size(); i++) {
+int size = listeners.size();
+for (int i = 0; i size; i++) {
BuildListener listener = (BuildListener) listeners.elementAt(i);
listener.buildFinished(event);
}
@@ -1990,7 +1992,8 @@
protected void fireTargetStarted(Target target) {
BuildEvent event = new BuildEvent(target);
Vector listeners = getBuildListeners();
-for (int i = 0; i listeners.size(); i++) {
+int size = listeners.size();
+for (int i = 0; i size; i++) {
BuildListener listener = (BuildListener) listeners.elementAt(i);
listener.targetStarted(event);
}
@@ -2010,7 +2013,8 @@
BuildEvent event = new BuildEvent(target);
event.setException(exception);
Vector listeners = getBuildListeners();
-for (int i = 0; i listeners.size(); i++) {
+int size = listeners.size();
+for (int i = 0; i size; i++) {
BuildListener listener = (BuildListener) listeners.elementAt(i);
listener.targetFinished(event);
}
@@ -2027,7 +2031,8 @@
registerThreadTask(Thread.currentThread(), task);
BuildEvent event = new BuildEvent(task);
Vector listeners = getBuildListeners();
-for (int i = 0; i listeners.size(); i++) {
+int size = listeners.size();
+for (int i = 0; i size; i++) {
BuildListener listener = (BuildListener) listeners.elementAt(i);
listener.taskStarted(event);
}
@@ -2050,7 +2055,8 @@
BuildEvent event = new BuildEvent(task);
event.setException(exception);
Vector listeners = getBuildListeners();
-for (int i = 0; i listeners.size(); i++) {
+int size = listeners.size();
+for (int i = 0; i size; i++) {
BuildListener listener = (BuildListener) listeners.elementAt(i);
listener.taskFinished(event);
}
@@ -2077,7 +2083,8 @@
+ - infinite loop terminated);
}
loggingMessage = true;
-for (int i = 0; i listeners.size(); i++) {
+int size = listeners.size();
+for (int i = 0; i size; i++) {
BuildListener listener = (BuildListener)
listeners.elementAt(i);
listener.messageLogged(event);
}
DO NOT REPLY [Bug 19101] - Project.fireMessageLoggedEvent performance fix
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19101. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19101 Project.fireMessageLoggedEvent performance fix [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 04:53 --- Applied - thanks
DO NOT REPLY [Bug 18695] - Fix ant startup script to fully suport a relative link to it.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18695. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18695 Fix ant startup script to fully suport a relative link to it. --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 08:07 --- It works if you have ANT_HOME properly defined in the $HOME/.antrc file. My proposed patch would also fix it in my case ... (but now I prefer the non-magic $HOME/.antrc form).
DO NOT REPLY [Bug 18695] - Fix ant startup script to fully suport a relative link to it.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18695. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18695 Fix ant startup script to fully suport a relative link to it. --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 12:32 --- Sorry, WORKSFORME, really means works for me. If I don't set ANT_HOME, the script from Ant 1.5.3 works - and I do have a relative symbolic link to my ant script. The scripts before 1.5.3 don't work with this setup, but I know it does now as this is exactly the problem bug 17721 addressed.
DO NOT REPLY [Bug 18484] - Please add parameters into script task.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18484. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18484 Please add parameters into script task. --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 12:38 --- references are mutable
DO NOT REPLY [Bug 10719] - Files processed under SQL task are hacked
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10719. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10719 Files processed under SQL task are hacked [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Target Milestone|--- |1.6 --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 12:47 --- Seems as if Steve just forgot to close this report. Fixed since nightly build 2003-03-14.
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Pack.java
bodewig 2003/04/17 06:09:19
Modified:.build.xml
docs/manual/CoreTasks pack.html war.html zip.html
src/main/org/apache/tools/ant/taskdefs Pack.java
Log:
Add destfile attribute to gzip and bzip2.
PR: 11102
Revision ChangesPath
1.366 +4 -4 ant/build.xml
Index: build.xml
===
RCS file: /home/cvs/ant/build.xml,v
retrieving revision 1.365
retrieving revision 1.366
diff -u -r1.365 -r1.366
--- build.xml 15 Apr 2003 15:21:47 - 1.365
+++ build.xml 17 Apr 2003 13:09:17 - 1.366
@@ -1213,9 +1213,9 @@
exclude name=${dist.name}/bin/*.py/
/tarfileset
/tar
-gzip zipfile=${dist.base}/bin/${dist.name}-bin.tar.gz
+gzip destfile=${dist.base}/bin/${dist.name}-bin.tar.gz
src=${dist.base}/bin/${dist.name}-bin.tar/
-bzip2 zipfile=${dist.base}/bin/${dist.name}-bin.tar.bz2
+bzip2 destfile=${dist.base}/bin/${dist.name}-bin.tar.bz2
src=${dist.base}/bin/${dist.name}-bin.tar/
delete file=${dist.base}/bin/${dist.name}-bin.tar/
delete dir=${dist.name}/
@@ -1253,9 +1253,9 @@
exclude name=${dist.name}/build.sh/
/tarfileset
/tar
-gzip zipfile=${dist.base}/src/${dist.name}-src.tar.gz
+gzip destfile=${dist.base}/src/${dist.name}-src.tar.gz
src=${dist.base}/src/${dist.name}-src.tar/
-bzip2 zipfile=${dist.base}/src/${dist.name}-src.tar.bz2
+bzip2 destfile=${dist.base}/src/${dist.name}-src.tar.bz2
src=${dist.base}/src/${dist.name}-src.tar/
delete file=${dist.base}/src/${dist.name}-src.tar/
delete dir=${dist.name}/
1.8 +9 -5 ant/docs/manual/CoreTasks/pack.html
Index: pack.html
===
RCS file: /home/cvs/ant/docs/manual/CoreTasks/pack.html,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- pack.html 4 Sep 2002 11:05:16 - 1.7
+++ pack.html 17 Apr 2003 13:09:18 - 1.8
@@ -25,20 +25,24 @@
td align=center valign=topYes/td
/tr
tr
+td valign=topdestfile/td
+td valign=topthe destination file to create./td
+td align=center valign=top rowspan=2Exactly one of the two./td
+ /tr
+ tr
td valign=topzipfile/td
-td valign=topthe destination file./td
-td align=center valign=topYes/td
+td valign=topthe ideprecated/i old name of destfile./td
/tr
/table
h3Examples/h3
blockquote
- pcodelt;gzip src=quot;test.tarquot;
zipfile=quot;test.tar.gzquot;/gt;/code/p
+ pcodelt;gzip src=quot;test.tarquot;
destfile=quot;test.tar.gzquot;/gt;/code/p
/blockquote
blockquote
- pcodelt;bzip2 src=quot;test.tarquot;
zipfile=quot;test.tar.bz2quot;/gt;/code/p
+ pcodelt;bzip2 src=quot;test.tarquot;
destfile=quot;test.tar.bz2quot;/gt;/code/p
/blockquote
hr
-p align=centerCopyright copy; 2000-2002 Apache Software Foundation. All
rights
+p align=centerCopyright copy; 2000-2003 Apache Software Foundation. All
rights
Reserved./p
/body
1.19 +1 -2 ant/docs/manual/CoreTasks/war.html
Index: war.html
===
RCS file: /home/cvs/ant/docs/manual/CoreTasks/war.html,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- war.html 11 Apr 2003 13:31:18 - 1.18
+++ war.html 17 Apr 2003 13:09:18 - 1.19
@@ -28,13 +28,12 @@
tr
td valign=topdestfile/td
td valign=topthe WAR file to create./td
-td valign=top align=centerYes/td
+td align=center valign=top rowspan=2Exactly one of the two./td
/tr
tr
td valign=topwarfile/td
td valign=topiDeprecatedi name of the file to create
-use ttdestfile/tt instead./td
-td valign=top align=centerNo/td
/tr
tr
td valign=topwebxml/td
1.19 +1 -2 ant/docs/manual/CoreTasks/zip.html
Index: zip.html
===
RCS file: /home/cvs/ant/docs/manual/CoreTasks/zip.html,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- zip.html 11 Apr 2003 13:31:18 - 1.18
+++ zip.html 17 Apr 2003 13:09:18 - 1.19
@@ -76,12 +76,11 @@
tr
td valign=topdestfile/td
td valign=topthe zip-file to create./td
-td align=center valign=topYes/td
+td align=center valign=top rowspan=2Exactly one of the two./td
/tr
tr
td valign=topzipfile/td
td valign=topthe ideprecated/i old name of destfile./td
-td align=center valign=topYes/td
/tr
tr
td valign=topbasedir/td
1.14 +9 -1 ant/src/main/org/apache/tools/ant/taskdefs/Pack.java
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Javadoc.java
bodewig 2003/04/17 06:41:25
Modified:docs/manual/CoreTasks javadoc.html
src/main/org/apache/tools/ant/taskdefs Javadoc.java
Log:
Add linksource attribute to Javadoc.
Submitted by: smagoun at mac dot com
Add breakiterator attribute to Javadoc.
PR: 11569
Revision ChangesPath
1.24 +18 -2 ant/docs/manual/CoreTasks/javadoc.html
Index: javadoc.html
===
RCS file: /home/cvs/ant/docs/manual/CoreTasks/javadoc.html,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- javadoc.html 5 Mar 2003 03:03:11 - 1.23
+++ javadoc.html 17 Apr 2003 13:41:25 - 1.24
@@ -40,7 +40,7 @@
instead./i/p
pIn the table below, 1.1 means available if your current Java VM is
-a 1.1 VM, 1.2 for either 1.2 or 1.3 and 1.4 for a 1.4 Java VM. 1.2+
+a 1.1 VM, 1.2 for either 1.2 or 1.3 and 1.4+ for any VM of at least version
1.4. 1.2+
means any VM of at least version 1.2./p
h3Parameters/h3
@@ -397,7 +397,23 @@
present in J2SE v 1.4 source code. Set this to quot;1.4quot; to
documents code that compiles using codequot;javac -source
1.4quot;/code./td
-td align=center valign=top1.4/td
+td align=center valign=top1.4+/td
+td align=center valign=topNo/td
+ /tr
+ tr
+td valign=toplinksource/td
+td valign=topGenerate hyperlinks to source files.
+ emsince Ant 1.6/em.
+ (codeyes/code | codeno/code). Default is no./td
+td align=center valign=top1.4+/td
+td align=center valign=topNo/td
+ /tr
+ tr
+td valign=topbreakiterator/td
+td valign=topUse the new breakiterator algorithm.
+ emsince Ant 1.6/em.
+ (codeyes/code | codeno/code). Default is no./td
+td align=center valign=top1.4+/td
td align=center valign=topNo/td
/tr
/table
1.112 +37 -0 ant/src/main/org/apache/tools/ant/taskdefs/Javadoc.java
Index: Javadoc.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Javadoc.java,v
retrieving revision 1.111
retrieving revision 1.112
diff -u -r1.111 -r1.112
--- Javadoc.java 4 Apr 2003 13:51:11 - 1.111
+++ Javadoc.java 17 Apr 2003 13:41:25 - 1.112
@@ -466,6 +466,8 @@
private boolean useExternalFile = false;
private FileUtils fileUtils = FileUtils.newFileUtils();
private String source = null;
+private boolean linksource = false;
+private boolean breakiterator = false;
private Vector fileSets = new Vector();
private Vector packageSets = new Vector();
@@ -1502,6 +1504,34 @@
fileSets.addElement(fs);
}
+/**
+ * Enables the -linksource switch, will be ignored if javadoc is not
+ * the 1.4 version. Default is false
+ *
+ * @since Ant 1.6
+ */
+public void setLinksource(boolean b) {
+if (!javadoc4) {
+log (-linksource option not supported on JavaDoc 1.4,
+ Project.MSG_VERBOSE);
+}
+this.linksource = b;
+}
+
+/**
+ * Enables the -linksource switch, will be ignored if javadoc is not
+ * the 1.4 version. Default is false
+ *
+ * @since Ant 1.6
+ */
+public void setBreakiterator(boolean b) {
+if (!javadoc4) {
+log (-breakiterator option not supported on JavaDoc 1.4,
+ Project.MSG_VERBOSE);
+}
+this.breakiterator = b;
+}
+
public void execute() throws BuildException {
if (javadoc2.equals(getTaskType())) {
log(!! javadoc2 is deprecated. Use javadoc instead. !!);
@@ -1792,6 +1822,13 @@
if (source != null) {
toExecute.createArgument().setValue(-source);
toExecute.createArgument().setValue(source);
+}
+
+if (linksource doclet == null) {
+toExecute.createArgument().setValue(-linksource);
+}
+if (breakiterator doclet == null) {
+toExecute.createArgument().setValue(-breakiterator);
}
}
DO NOT REPLY [Bug 11569] - Javadoc core task does not support new -linksource and -breakiterator options.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11569. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11569 Javadoc core task does not support new -linksource and -breakiterator options. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Target Milestone|--- |Ant 2 --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 13:43 --- fixed in nightly build 2003-04-18
DO NOT REPLY [Bug 11569] - Javadoc core task does not support new -linksource and -breakiterator options.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11569. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11569 Javadoc core task does not support new -linksource and -breakiterator options. [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|Ant 2 |1.6
DO NOT REPLY [Bug 13042] - Need to have a way to override Java version when parsing
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13042. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13042 Need to have a way to override Java version when parsing --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 13:57 --- If all you want to do is getting the target names, why can't you go ahead and attach a build logger of your own that swallows the warnings? I assume you are talking about non-fatal things like the source attribute in javadoc will be ignored or so.
DO NOT REPLY [Bug 13042] - Need to have a way to override Java version when parsing
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13042. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13042 Need to have a way to override Java version when parsing --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 13:59 --- If you try a recent nightly build, you shouldn't see any warnings except for the top-level tasks, BTW. Setting of attributes and creation of child elements has been delayed beyond the point you are going to reach IIRC. And finally, you could run ant -projecthelp to get the target names - doing so programmatically should be possible as well.
DO NOT REPLY [Bug 19101] - Project.fireMessageLoggedEvent performance fix
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19101. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19101 Project.fireMessageLoggedEvent performance fix --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 14:02 --- I also tend to make such an optimization, but add the final keyword to the count variable, so make it absolutely clear to an optimizer it can agressively unroll the loop potentially. Not sure if it makes a difference in this case. -- DD
DO NOT REPLY [Bug 13767] - sysproperty needs refid
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13767. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13767 sysproperty needs refid [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 14:07 --- not exactly a duplicate but will be resolved as a side effect of the other bug. *** This bug has been marked as a duplicate of 12024 ***
DO NOT REPLY [Bug 12024] - [PATCH] Enable junit to inherit Ant properties as system properties
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12024. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12024 [PATCH] Enable junit to inherit Ant properties as system properties [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 14:07 --- *** Bug 13767 has been marked as a duplicate of this bug. ***
DO NOT REPLY [Bug 13852] - create a stderr property for exec where the output to stderr can be accessed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13852. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13852 create a stderr property for exec where the output to stderr can be accessed [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Target Milestone|--- |1.6 --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 14:13 --- Since some weeks now, you can separate output and error together with various options (like send error output to the logging system as well). I think it now addresses all your requirements.
DO NOT REPLY [Bug 17045] - junitx adding syspropertyset
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17045. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17045 junitx adding syspropertyset [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 14:20 --- *** This bug has been marked as a duplicate of 12024 ***
DO NOT REPLY [Bug 12024] - [PATCH] Enable junit to inherit Ant properties as system properties
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12024. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12024 [PATCH] Enable junit to inherit Ant properties as system properties [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 14:20 --- *** Bug 17045 has been marked as a duplicate of this bug. ***
DO NOT REPLY [Bug 13510] - CvsChangeLog should accept a branch as an optional parameter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13510. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13510 CvsChangeLog should accept a branch as an optional parameter --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 15:16 --- Simon, what version of CVS are you using? This is a know issue with cvs that has been resolved. Is upgrading your version of cvs an option. Passing the -S option may be useful as well (doesn't show files that have 0 revisions selected). Eg cvs log -S -rbranch_name.
DO NOT REPLY [Bug 19099] - [PATCH] add resultproperty support to java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19099. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19099 [PATCH] add resultproperty support to java [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
DO NOT REPLY [Bug 19113] New: - XMLJUnitResultFormatter fails to detect embedded CDATA sections
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19113 XMLJUnitResultFormatter fails to detect embedded CDATA sections Summary: XMLJUnitResultFormatter fails to detect embedded CDATA sections Product: Ant Version: 1.5.3 Platform: All OS/Version: All Status: NEW Severity: Minor Priority: Other Component: Optional Tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] The formatOutput(String type, String output) method of the class XMLJUnitResultFormatter embeds the output string in a CDATA section. If the output string itself has a CDATA section, an invalid XML file is produced. One way to solve this is to remove all CDATA section end delimiters from the output string prior to writing.
DO NOT REPLY [Bug 19116] New: - Tar/TarFileSet userId and groupId
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19116.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19116
Tar/TarFileSet userId and groupId
Summary: Tar/TarFileSet userId and groupId
Product: Ant
Version: 1.4.1
Platform: PC
OS/Version: Windows NT/2K
Status: NEW
Severity: Enhancement
Priority: Other
Component: Core tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
Setting the username and group in a TarFileSet does not produce useful results
when untarring with tar or pax under QNX 4--the uid:gid defaults to 0:0
(root:root).
I would like to be able to set the uid and gid directly in a TarFileSet. For
example:
tar tarfile=mystuff.tar longfile=gnu
tarFileSet dir=${TMP_DIR_INSTALL} mode=775 username=leader
group=sysprj
include name=TDS_Data/
include name=TDS_Data/config/
include name=TDS_Data/Program/
/tarFileSet
DO NOT REPLY [Bug 19116] - Tar/TarFileSet userId and groupId
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19116. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19116 Tar/TarFileSet userId and groupId [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID
DO NOT REPLY [Bug 19118] New: - JUnitReport does not fail when it encounters an invalid XML file
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19118. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19118 JUnitReport does not fail when it encounters an invalid XML file Summary: JUnitReport does not fail when it encounters an invalid XML file Product: Ant Version: 1.5.3 Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Optional Tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Currently the JUnitReport task only logs a warning if it encounters an invalid XML file (see the SAXException catch clause in the createDocument method in XMLResultAggregator). As written, it is impossible to check for this condition within an Ant script. Bug 19113 describes a case where the JUnit task can produce an invalid XML output file. One possibility would be to support an errorproperty parameter (like the one one the JUnit task) that gets set if an error occurs. Another choice (a little less flexible) would be to support a failOnError parameter.
cvs commit: ant/docs/manual/CoreTasks mail.html
antoine 2003/04/17 10:09:35
Modified:src/main/org/apache/tools/ant/taskdefs/email MimeMailer.java
Message.java EmailTask.java
docs/manual/CoreTasks mail.html
Log:
add international support for mailtask - bug report 15434
Revision ChangesPath
1.9 +103 -10
ant/src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java
Index: MimeMailer.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- MimeMailer.java 10 Feb 2003 14:13:45 - 1.8
+++ MimeMailer.java 17 Apr 2003 17:09:35 - 1.9
@@ -1,7 +1,7 @@
/*
* The Apache Software License, Version 1.1
*
- * Copyright (c) 2002 The Apache Software Foundation. All rights
+ * Copyright (c) 2002-2003 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -53,16 +53,23 @@
*/
package org.apache.tools.ant.taskdefs.email;
+import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
import java.io.PrintStream;
import java.io.UnsupportedEncodingException;
+
import java.util.Enumeration;
import java.util.Properties;
+import java.util.StringTokenizer;
import java.util.Vector;
+
import javax.activation.DataHandler;
import javax.activation.FileDataSource;
+
import javax.mail.Message;
import javax.mail.MessagingException;
import javax.mail.Session;
@@ -72,17 +79,75 @@
import javax.mail.internet.MimeBodyPart;
import javax.mail.internet.MimeMessage;
import javax.mail.internet.MimeMultipart;
+
import org.apache.tools.ant.BuildException;
/**
* Uses the JavaMail classes to send Mime format email.
*
* @author [EMAIL PROTECTED] Rob Oxspring
+ * @author a href=mailto:[EMAIL PROTECTED]Aleksandr Ishutin/a
* @since Ant 1.5
*/
class MimeMailer extends Mailer {
-/** Sends the email */
-public void send() {
+// Default character set
+private static final String defaultCharset =
System.getProperty(file.encoding);
+
+// To work poperly with national charsets we have to use
+// implementation of interface javax.activation.DataSource
+/**
+ * @since Ant 1.6
+ */
+class StringDataSource implements javax.activation.DataSource {
+ private String data=null;
+ private String type=null;
+ private String charset = null;
+ private ByteArrayOutputStream out;
+
+ public InputStream getInputStream() throws IOException {
+if(data == null out == null)
+ throw new IOException(No data);
+else {
+ if(out!=null) {
+
data=(data!=null)?data.concat(out.toString(charset)):out.toString(charset);
+out=null;
+ }
+ return new ByteArrayInputStream(data.getBytes(charset));
+}
+ }
+
+ public OutputStream getOutputStream() throws IOException {
+if(out==null) {
+ out=new ByteArrayOutputStream();
+}
+return out;
+ }
+
+ public void setContentType(String type) {
+this.type=type.toLowerCase();
+ }
+
+ public String getContentType() {
+if(type !=null type.indexOf(charset)0
type.startsWith(text/))
+ return type;
+// Must be like text/plain; charset=windows-1251
+return type!=null?type.concat(; charset=.concat(charset)):
+ text/plain.concat(; charset=.concat(charset));
+ }
+
+ public String getName() {
+return StringDataSource;
+ }
+ public void setCharset(String charset) {
+this.charset = charset;
+ }
+ public String getCharset() {
+return charset;
+ }
+ }
+
+ /** Sends the email */
+ public void send() {
try {
Properties props = new Properties();
@@ -113,20 +178,38 @@
msg.setRecipients(Message.RecipientType.BCC,
internetAddresses(bccList));
-if (subject != null) {
-msg.setSubject(subject);
+// Choosing character set of the mail message
+// First: looking it from MimeType
+String charset = parseCharSetFromMimeType(message.getMimeType());
+if(charset!=null) {
+ // Assign/reassign message charset from MimeType
+message.setCharset(charset);
}
-msg.addHeader(Date, getDate());
+// Next: looking if charset having explict definition
+
DO NOT REPLY [Bug 15434] - MimeMailer doesn't work properly with national charset
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15434. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15434 MimeMailer doesn't work properly with national charset [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Target Milestone|--- |1.6 --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 17:13 --- Patches submitted, thank you Aleksandr
DO NOT REPLY [Bug 18129] - p4label hangs when setting 'locked' label state w/ JVM 1.3
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18129. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18129 p4label hangs when setting 'locked' label state w/ JVM 1.3 --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 17:21 --- might be related to http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18956 I have fixed P4HandlerAdapter.java because of this bug report. Can you try to download a nightly build and see if it fixes your problem.
DO NOT REPLY [Bug 13042] - Need to have a way to override Java version when parsing
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13042. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13042 Need to have a way to override Java version when parsing --- Additional Comments From [EMAIL PROTECTED] 2003-04-17 17:21 --- I'll do that, thanks. Fortunately, there's now a version of JBuilder (8) that runs on 1.4.1, so this is less of a problem, but there might well be future situations when this happens (e.g. when JDK 1.5 comes out, and there's some Ant feature that depends on JDK 1.5)..
DO NOT REPLY [Bug 19120] New: - Tar/TarFileSet/TarEntry uid and gid
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19120. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19120 Tar/TarFileSet/TarEntry uid and gid Summary: Tar/TarFileSet/TarEntry uid and gid Product: Ant Version: 1.4.1 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Enhancement Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Setting the username and group in a TarFileSet stores the user and group strings in the tar file, but the uid:gid numbers default to 0:0 (root:root). When I untar with tar or pax [under QNX 4], the username and group are ignored and the uid and gid are used instead. This does not produce the desired results since everything is owned by root:root. I would like to be able to set the uid and gid in a TarFileSet and have them set in the corresponding TarEntry in the Tar object. !-- Usage Example: -- tar tarfile=thisandthat.tar tarFileSet dir=. mode=775 uid=100 gid=200 include name=this/ include name=that/ /tarFileSet /tar
Re: ant tutorial
Conor,
Thanks for posting the tutorial. It is an excellent explanation of the
parts of Ant that are a struggle to figure out from just reading code
and api docs. It alsow answered a question that I had posted a bug about
-- the extra blank target in Ant 1.6. Not a bug, it's a design
feature. Definitely continue working on these, they aer well worth the
trouble.
Dale
Conor MacNeill wrote:
On Thu, 17 Apr 2003 02:43 am, Gus Heck wrote:
I agree. This is really cool. The section labeled Top Level Tasks
seems to say that tasks on the top level are run at parse-time. Does
this mean that the order of tasks at the top level is the order of
execution, or do the old toplevel tasks still run first?
In 1.6 all top-level tasks are gathered, in build-file order, into an
invisible target which is executed at the end of parsing (so technically, not
at parse-time). There is no distinction between old top-level tasks and other
tasks.
So, given this build,
project name=toplevel default=main
echo message=Task 1 test.prop=${test.prop}/
target name=main
echo message=Task 2 test.prop=${test.prop}/
/target
property name=test.prop value=fubar/
echo message=Task 3 test.prop=${test.prop}/
/project
the output is
Buildfile: build.xml
[echo] Task 1 test.prop=${test.prop}
[echo] Task 3 test.prop=fubar
main:
[echo] Task 2 test.prop=fubar
BUILD SUCCESSFUL
So, still somethings to be careful about :-)
Conor
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
