AW: Online Bookstore

2005-05-30 Thread Jan . Materne
No, if you add the isbn flag, the links are generated for all.

If some publishers only support certain books you have to have
a matrix (publisher-book) just for generating simple links. That´s too
much work IMO. Who could maintain this matrix? Adding manually would be
easier then.

On a more enterprise you could have that matrix and a servlet which provides
the
vital information of that book and all supporting resellers if you call it
with isbn.
But that would mean much more work ...

Final question: are these links ok? Then I will commit that (hopefully)
today.


Jan



 -Ursprüngliche Nachricht-
 Von: Ted Husted [mailto:[EMAIL PROTECTED]
 Gesendet am: Donnerstag, 26. Mai 2005 01:57
 An: Ant Developers List
 Betreff: Re: Online Bookstore
 
 Looks good, Jan. 
 
 So, aside from the retailers, some of the publishers, like O'Reilly
 and Manning, have affiliates programs too. Would the approach you're
 using let you add publisher links for just certain books. For example,
 the Manning link would apply to Java Development with Ant, but not the
 others. Not a  vital feature, just wondering. The links you have are
 great!
 
 -Ted.
 
 On 25 May 2005 15:26:19 -, [EMAIL PROTECTED]
 [EMAIL PROTECTED] wrote:
  Ok, I uploaded the example to http://www.apache.org/~jhm/bookstore/
  cheers
  Jan
  
  
 -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
  
  
 
 
 -- 
 HTH, Ted.
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 


cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs MacroDefTest.java

2005-05-30 Thread peterreilly
peterreilly2005/05/30 03:04:42

  Modified:.WHATSNEW
   src/main/org/apache/tools/ant/taskdefs MacroDef.java
   src/etc/testcases/taskdefs macrodef.xml
   src/testcases/org/apache/tools/ant/taskdefs
MacroDefTest.java
  Log:
  * macrodef with redefined default values was incorrect. (Fix for
 31215 had a bug). Bugzilla report 35109.
  PR: 35109
  
  Revision  ChangesPath
  1.835 +15 -0 ant/WHATSNEW
  
  Index: WHATSNEW
  ===
  RCS file: /home/cvs/ant/WHATSNEW,v
  retrieving revision 1.834
  retrieving revision 1.835
  diff -u -r1.834 -r1.835
  --- WHATSNEW  26 May 2005 17:04:47 -  1.834
  +++ WHATSNEW  30 May 2005 10:04:41 -  1.835
  @@ -233,6 +233,21 @@
   * Try to make subprojects of custom Project subclasses instances of the
 same type. Bugzilla report 17901.
   
  +Changes from Ant 1.6.4 to current Ant 1.6 CVS version
  +=
  +
  +Changes that could break older environments:
  +
  +
  +Fixed bugs:
  +---
  +
  +* move was unable to replace existing files or write into
  +  existing directories.  Bugzilla report 34962.
  +
  +* macrodef with redefined default values was incorrect. (Fix for
  +   31215 had a bug). Bugzilla report 35109.
  +
   Changes from Ant 1.6.3 to Ant 1.6.4
   ===
   
  
  
  
  1.33  +26 -4 ant/src/main/org/apache/tools/ant/taskdefs/MacroDef.java
  
  Index: MacroDef.java
  ===
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/MacroDef.java,v
  retrieving revision 1.32
  retrieving revision 1.33
  diff -u -r1.32 -r1.33
  --- MacroDef.java 21 Apr 2005 09:49:55 -  1.32
  +++ MacroDef.java 30 May 2005 10:04:42 -  1.33
  @@ -715,13 +715,14 @@
   }
   
   /**
  - * similar equality method for macrodef, ignores project and
  + * same or similar equality method for macrodef, ignores project and
* runtime info.
*
* @param obj an codeObject/code value
  + * @param same if true test for sameness, otherwise just similiar
* @return a codeboolean/code value
*/
  -public boolean similar(Object obj) {
  +private boolean sameOrSimilar(Object obj, boolean same) {
   if (obj == this) {
   return true;
   }
  @@ -742,7 +743,8 @@
   // Allow two macro definitions with the same location
   // to be treated as similar - bugzilla 31215
   if (other.getLocation() != null
  - other.getLocation().equals(getLocation())) {
  + other.getLocation().equals(getLocation())
  + !same) {
   return true;
   }
   if (text == null) {
  @@ -779,6 +781,26 @@
   }
   
   /**
  + * Similar method for this definition
  + *
  + * @param obj another definition
  + * @return true if the definitions are similar
  + */
  +public boolean similar(Object obj) {
  +return sameOrSimilar(obj, false);
  +}
  +
  +/**
  + * Equality method for this definition
  + *
  + * @param obj another definition
  + * @return true if the definitions are the same
  + */
  +public boolean sameDefinition(Object obj) {
  +return sameOrSimilar(obj, true);
  +}
  +
  +/**
* extends AntTypeDefinition, on create
* of the object, the template macro definition
* is given.
  @@ -822,7 +844,7 @@
   return false;
   }
   MyAntTypeDefinition otherDef = (MyAntTypeDefinition) other;
  -return macroDef.similar(otherDef.macroDef);
  +return macroDef.sameDefinition(otherDef.macroDef);
   }
   
   /**
  
  
  
  1.14  +17 -0 ant/src/etc/testcases/taskdefs/macrodef.xml
  
  Index: macrodef.xml
  ===
  RCS file: /home/cvs/ant/src/etc/testcases/taskdefs/macrodef.xml,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- macrodef.xml  21 Apr 2005 09:49:55 -  1.13
  +++ macrodef.xml  30 May 2005 10:04:42 -  1.14
  @@ -220,7 +220,24 @@
   explicit/
 /sequential
   /macrodef
  +  /target
  +
  +  property name=default.override value=old/
  +  macrodef name=simple.override
  +attribute name=attr default=${default.override}/
  +sequential
  +  echovalue is @{attr}/echo
  +/sequential
  +  /macrodef
  +
  +  target name=override.default
  +antcall target=override.call
  +  param name=default.override value=new/
  +/antcall
  +  /target
   
  +  target name=override.call
  +simple.override/
 /target
   
 target 

cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs MacroDefTest.java

2005-05-30 Thread peterreilly
peterreilly2005/05/30 03:05:41

  Modified:.Tag: ANT_16_BRANCH WHATSNEW
   src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH
MacroDef.java
   src/etc/testcases/taskdefs Tag: ANT_16_BRANCH macrodef.xml
   src/testcases/org/apache/tools/ant/taskdefs Tag:
ANT_16_BRANCH MacroDefTest.java
  Log:
  sync fix for 35109
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.503.2.232 +3 -0  ant/WHATSNEW
  
  Index: WHATSNEW
  ===
  RCS file: /home/cvs/ant/WHATSNEW,v
  retrieving revision 1.503.2.231
  retrieving revision 1.503.2.232
  diff -u -r1.503.2.231 -r1.503.2.232
  --- WHATSNEW  20 May 2005 16:13:46 -  1.503.2.231
  +++ WHATSNEW  30 May 2005 10:05:40 -  1.503.2.232
  @@ -10,6 +10,9 @@
   * move was unable to replace existing files or write into
 existing directories.  Bugzilla report 34962.
   
  +* macrodef with redefined default values was incorrect. (Fix for
  +   31215 had a bug). Bugzilla report 35109.
  +
   Changes from Ant 1.6.3 to Ant 1.6.4
   ===
   
  
  
  
  No   revision
  No   revision
  1.7.2.22  +26 -4 ant/src/main/org/apache/tools/ant/taskdefs/MacroDef.java
  
  Index: MacroDef.java
  ===
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/MacroDef.java,v
  retrieving revision 1.7.2.21
  retrieving revision 1.7.2.22
  diff -u -r1.7.2.21 -r1.7.2.22
  --- MacroDef.java 15 Mar 2005 15:11:24 -  1.7.2.21
  +++ MacroDef.java 30 May 2005 10:05:41 -  1.7.2.22
  @@ -622,13 +622,14 @@
   }
   
   /**
  - * similar equality method for macrodef, ignores project and
  + * same or similar equality method for macrodef, ignores project and
* runtime info.
*
* @param obj an codeObject/code value
  + * @param same if true test for sameness, otherwise just similiar
* @return a codeboolean/code value
*/
  -public boolean similar(Object obj) {
  +private boolean sameOrSimilar(Object obj, boolean same) {
   if (obj == this) {
   return true;
   }
  @@ -649,7 +650,8 @@
   // Allow two macro definitions with the same location
   // to be treated as similar - bugzilla 31215
   if (other.getLocation() != null
  - other.getLocation().equals(getLocation())) {
  + other.getLocation().equals(getLocation())
  + !same) {
   return true;
   }
   if (text == null) {
  @@ -686,6 +688,26 @@
   }
   
   /**
  + * Similar method for this definition
  + *
  + * @param obj another definition
  + * @return true if the definitions are similar
  + */
  +public boolean similar(Object obj) {
  +return sameOrSimilar(obj, false);
  +}
  +
  +/**
  + * Equality method for this definition
  + *
  + * @param obj another definition
  + * @return true if the definitions are the same
  + */
  +public boolean sameDefinition(Object obj) {
  +return sameOrSimilar(obj, true);
  +}
  +
  +/**
* extends AntTypeDefinition, on create
* of the object, the template macro definition
* is given.
  @@ -729,7 +751,7 @@
   return false;
   }
   MyAntTypeDefinition otherDef = (MyAntTypeDefinition) other;
  -return macroDef.similar(otherDef.macroDef);
  +return macroDef.sameDefinition(otherDef.macroDef);
   }
   
   /**
  
  
  
  No   revision
  No   revision
  1.2.2.11  +17 -0 ant/src/etc/testcases/taskdefs/macrodef.xml
  
  Index: macrodef.xml
  ===
  RCS file: /home/cvs/ant/src/etc/testcases/taskdefs/macrodef.xml,v
  retrieving revision 1.2.2.10
  retrieving revision 1.2.2.11
  diff -u -r1.2.2.10 -r1.2.2.11
  --- macrodef.xml  4 Jun 2004 07:39:08 -   1.2.2.10
  +++ macrodef.xml  30 May 2005 10:05:41 -  1.2.2.11
  @@ -220,7 +220,24 @@
   explicit/
 /sequential
   /macrodef
  +  /target
  +
  +  property name=default.override value=old/
  +  macrodef name=simple.override
  +attribute name=attr default=${default.override}/
  +sequential
  +  echovalue is @{attr}/echo
  +/sequential
  +  /macrodef
  +
  +  target name=override.default
  +antcall target=override.call
  +  param name=default.override value=new/
  +/antcall
  +  /target
   
  +  target name=override.call
  +simple.override/
 /target
   
   /project
  
  
  
  No   revision
  No   revision
  1.2.2.15  +5 -0  

DO NOT REPLY [Bug 35109] - xml attribute:: the default attribute doesn't refer to the right property

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35109.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35109


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||FIXED
   Target Milestone|--- |1.6




--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 12:07 ---
This is a bug. It was caused by an incorrect fix to
bug 31215. I have committed a fix and a test for
the fix. The fix will be in 1.6.5.

Thanks for the timely report!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 35109] - xml attribute:: the default attribute doesn't refer to the right property

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35109.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35109


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Target Milestone|1.6 |1.6.5




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34534] - Should document $$ escaping (or show where other than javac.html it is documented).

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34534.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34534





--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 14:10 ---
OK, where should this documentation go?  It seems that this applies not just to
the FTP task's password attribute but potentially to all task attributes.  I'm
not sure where the best place to document this is so that users like Jiangtao
Yan would find it if they happened to stumble onto this situation.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34257] - Add the SITE command as an action

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34257.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34257


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 16:42 ---
a siteCommand attribute has been added as per your patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34853] - [PATCH] FTP Task enhancement to a site command to be sent to FTP server after login

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34853.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34853


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 16:43 ---
an initialSiteCommand attribute (named differently from your suggestion but with
similar functionality) has been added.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: ant/xdocs resources.xml

2005-05-30 Thread jhm
jhm 2005/05/30 08:45:40

  Modified:xdocsresources.xml
  Log:
  Added ISBNs for later use (e.g. Online Bookstore)
  
  Revision  ChangesPath
  1.44  +9 -9  ant/xdocs/resources.xml
  
  Index: resources.xml
  ===
  RCS file: /home/cvs/ant/xdocs/resources.xml,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- resources.xml 18 May 2005 10:00:53 -  1.43
  +++ resources.xml 30 May 2005 15:45:40 -  1.44
  @@ -91,7 +91,7 @@
   section name=Books
 pThe most recent books come first/p
   
  -  subsection name=Ant: The Definitive Guide, 2nd edition
  +  subsection name=Ant: The Definitive Guide, 2nd edition 
isbn=0596006098
   pPublished April 2005, and covers Ant release 1.6.1./p
   
   pThis is a complete rewrite of the first edition; this book is
  @@ -117,11 +117,11 @@
   /table
 /subsection
   
  -  subsection name=Pragmatic Project Automation
  +  subsection name=Pragmatic Project Automation isbn=0974514039
   p
   
   How to Build, Deploy, and Monitor Java Applications.
  -Published: July 2004 ISBN:   0-9745140-3-9
  +Published: July 2004 ISBN:0-9745140-3-9
   /p
   p
 This is not a reference guide to Ant, but a book on how to 
automate the build process.
  @@ -144,7 +144,7 @@
   
   
   
  -  subsection name=Extreme Programming with Ant
  +  subsection name=Extreme Programming with Ant isbn=0672325624
p This book shows how to implement an XP project using Ant 1.5.3, 
and many other 3rd party tools.  Covers:/p
   ul
  liThe fundamentals of Ant: concepts, core and optional 
tasks/li
  @@ -172,7 +172,7 @@
   /table
 /subsection
   
  -  subsection name=Ant. Das Java-Build-Tool in der Praxis
  +  subsection name=Ant. Das Java-Build-Tool in der Praxis 
isbn=3827320666
   pA German language book on Ant that covers Ant 1.5.
   This is the original description:/p
   source
  @@ -200,7 +200,7 @@
   /table
 /subsection
   
  -  subsection name=Java Development with Ant
  +  subsection name=Java Development with Ant isbn=1930110588
   pPublished 2002. This book covers Ant 1.5, including:/p
   ul
   liThe new Ant 1.5 features/li
  @@ -235,7 +235,7 @@
   /table
 /subsection
   
  -  subsection name=Ant: The Definitive Guide, 1st edition
  +  subsection name=Ant: The Definitive Guide, 1st edition 
isbn=0596001843
 !-- a soon as somebody submits a description, let's add it --
   pPublished 2002, Covers Ant release 1.4.1./p
   table class=externals
  @@ -250,7 +250,7 @@
   /table
 /subsection
   
  -  subsection name=Ant. Kurz und Gut.
  +  subsection name=Ant. Kurz und Gut. isbn=3897212412
   
   pA German language short reference for Ant that covers Ant
   1.4.  This is the original description:/p
  @@ -274,7 +274,7 @@
   /table
 /subsection
   
  -  subsection name=Java Tools for eXtreme Programming
  +  subsection name=Java Tools for eXtreme Programming 
isbn=047120708X
   pThis book covers the following XP subjects:/p
   ul
   liAutomated unit and functional testing/li
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: ant/docs resources.html

2005-05-30 Thread jhm
jhm 2005/05/30 08:54:00

  Modified:xdocs/stylesheets site.vsl templates.vm
   docs resources.html
  Log:
  The Bookstore
  
  Revision  ChangesPath
  1.13  +13 -0 ant/xdocs/stylesheets/site.vsl
  
  Index: site.vsl
  ===
  RCS file: /home/cvs/ant/xdocs/stylesheets/site.vsl,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- site.vsl  14 Jun 2004 15:05:36 -  1.12
  +++ site.vsl  30 May 2005 15:54:00 -  1.13
  @@ -34,6 +34,15 @@
   
   ## This is where the common page macro's live
   
  +#macro ( isbn $isbn)
  +pbAvailable from:/bbr
  +a 
href=http://www.amazon.com/exec/obidos/tg/detail/-/$!isbn/apachesoftwar-20/; 
target=_blankAmazon.com/a
  +  | a 
href=http://service.bfast.com/bfast/click?bfmid=2181amp;bfmtype=bookamp;sourceid=41462544amp;bfpid=$!isbn;
 target=_blankBarnes amp; Noble/a
  +  | a 
href=http://www.booksense.com/product/info.jsp?affiliateId=Apacheamp;isbn=$!isbn;
 target=_blankBook Sense/a
  +  | a 
href=http://www.powells.com/cgi-bin/biblio?isbn=$!isbnamp;partner_id=29693; 
target=_blankPowells.com/a
  +br/p
  +#end
  +
   #macro ( subsection $subsection)
 h4 class=subsection
   a name=$escape.getText($subsection.getAttributeValue(name))/a
  @@ -52,6 +61,10 @@
 $xmlout.outputString($items)
   #end
 #end
  +  #if ($subsection.getAttributeValue(isbn))
  +#set ($isbn = $subsection.getAttributeValue(isbn))
  +#isbn ($isbn)
  +  #end
   #end
   
   #macro ( subsubsection $subsubsection)
  
  
  
  1.38  +7 -3  ant/xdocs/stylesheets/templates.vm
  
  Index: templates.vm
  ===
  RCS file: /home/cvs/ant/xdocs/stylesheets/templates.vm,v
  retrieving revision 1.37
  retrieving revision 1.38
  diff -u -r1.37 -r1.38
  --- templates.vm  10 May 2005 07:03:33 -  1.37
  +++ templates.vm  30 May 2005 15:54:00 -  1.38
  @@ -1,4 +1,4 @@
  -#* 
  +#*
* Copyright  2000-2005 The Apache Software Foundation
*
*  Licensed under the Apache License, Version 2.0 (the License);
  @@ -12,7 +12,7 @@
*  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
*  See the License for the specific language governing permissions and
*  limitations under the License.
  - * 
  + *
*#
   
   ## This is where the common macro's live
  @@ -29,6 +29,10 @@
 #tr ($items)
   #end
 #end
  +  #if ($table.getParent().getAttributeValue(isbn))
  +#set ($isbn = $table.getParent().getAttributeValue(isbn))
  +trthISBN:/thtd$!isbn/td/tr
  +  #end
 /table
   #end
   
  @@ -291,4 +295,4 @@
 /p
   /body
 /html
  -#end
  +#end
  \ No newline at end of file
  
  
  
  1.89  +132 -75   ant/docs/resources.html
  
  Index: resources.html
  ===
  RCS file: /home/cvs/ant/docs/resources.html,v
  retrieving revision 1.88
  retrieving revision 1.89
  diff -u -r1.88 -r1.89
  --- resources.html18 May 2005 10:00:53 -  1.88
  +++ resources.html30 May 2005 15:54:00 -  1.89
  @@ -197,8 +197,8 @@
 a href=faq.htmlhttp://ant.apache.org/faq.html/a
 /td
 /tr
  -/table
  -h4 class=subsection
  +  /table
  +  h4 
class=subsection
   a name=jGuru/a
   jGuru
 /h4
  @@ -224,8 +224,8 @@
 a 
href=http://www.jguru.com/faq/home.jsp?topic=Ant;http://www.jguru.com/faq/home.jsp?topic=Ant/a
 /td
 /tr
  -/table
  -h4 class=subsection
  +  /table
  +  h4 
class=subsection
   a name=FAQ about Borland Application Server tasks/a
   FAQ about Borland Application Server tasks
 /h4
  @@ -243,8 +243,8 @@
 a 
href=http://www.moussaud.org/ejbjar.html;http://www.moussaud.org/ejbjar.html/a
 /td
 /tr
  -/table
  -  h3 class=section
  +  /table
  +h3 class=section
 a name=WIKIs/a
 WIKIs
   /h3
  @@ -274,8 +274,8 @@
 a href=http://wiki.apache.org/ant/;Ant Wiki/a
 /td
 /tr
  -/table
  -  h3 class=section
  +  /table
  +h3 class=section
 a name=Books/a
 Books
   /h3
  @@ -315,15 +315,22 @@
   
 /td
 /tr
  -/table
  -h4 class=subsection
  +trthISBN:/thtd0596006098/td/tr
  +

DO NOT REPLY [Bug 33214] - Refactore FTP task to get an analogous design as e.g. TELNEt

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33214.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33214


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 18:04 ---
I agree with Matt.  This is almost a different task. interactive-ftp or some
such.  What it lacks is the ability to deal with filesets.  If the files are not
in your local current directory you'd have to be able to do LCD commands.  It
might work, it might even be useful, but in some sense, it's not quite the ant
way, for good or for ill.

I hadn't ever really paid much attention to the telnet task before.  After a
quick look-see, I see that it depends reading certain prompts from the server. 
Which, I guess, is fine if you know exactly the server you are dealing with and
it never changes.  It may even be good - since you can adjust for any locale 
issues.

I think a lot of the present users will not want to work this way.  They'll not
want to have to think about the specific prompts and such on the server. 
Another possible objection is how dependency checking will get done in the
context of a sequential series of commands.  As a series of separate targets,
the dependency checking is relatively easy to understand.  As a bunch of
sequential commands sent to the server, it's much less so.

I recommend creating a contribution of interactive-ftp.  It shouldn't be that
hard to do, I just don't think it fits into the ftp task as now developed. 
Possibly we can put it into the main stem if there is demand for it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs resources.html

2005-05-30 Thread Alexey Solofnenko
If Amazon and others do not sponsor us, we can just put a single link to 
www.addall.com http://www.addall.com for people to find the best price.

- Alexey.

On 30 May 2005 15:54:00 -, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
 
 jhm 2005/05/30 08:54:00
 
 Modified: xdocs/stylesheets site.vsl templates.vm
 docs resources.html
 Log:
 The Bookstore
 
 Revision Changes Path
 1.13 +13 -0 ant/xdocs/stylesheets/site.vsl
 
 Index: site.vsl
 ===
 RCS file: /home/cvs/ant/xdocs/stylesheets/site.vsl,v
 retrieving revision 1.12
 retrieving revision 1.13
 diff -u -r1.12 -r1.13
 --- site.vsl 14 Jun 2004 15:05:36 - 1.12
 +++ site.vsl 30 May 2005 15:54:00 - 1.13
 @@ -34,6 +34,15 @@
 
 ## This is where the common page macro's live
 
 +#macro ( isbn $isbn)
 +pbAvailable from:/bbr
 + a href=
 http://www.amazon.com/exec/obidos/tg/detail/-/$!isbn/apachesoftwar-20/; 
 target=_blankAmazon.com http://Amazon.com/a
 + | a href=
 http://service.bfast.com/bfast/click?bfmid=2181amp;bfmtype=bookamp;sourceid=41462544amp;bfpid=$!isbn;
  
 target=_blankBarnes amp; Noble/a
 + | a href=
 http://www.booksense.com/product/info.jsp?affiliateId=Apacheamp;isbn=$!isbn; 
 target=_blankBook Sense/a
 + | a href=
 http://www.powells.com/cgi-bin/biblio?isbn=$!isbnamp;partner_id=29693; 
 target=_blankPowells.com http://Powells.com/a
 +br/p
 +#end
 


-- 
Alexey N. Solofnenko trelony at gmail.com http://gmail.com
home: http://trelony.cjb.net/
Pleasant Hill, CA (GMT-8 hours usually)


DO NOT REPLY [Bug 31744] - FTP subtasks should all share one connection

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31744.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31744





--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 18:12 ---
This is a very interesting suggestion and I am considering how best to 
implement it.

I have an idea.  I'd like some of the other ant developers to chime in on it.

Suppose we had an ftp-connection data type, with an id, etc.  Could we wrap
that around a jakarta-commons-net FTPClient object, and keep its connection
live?  Then we could refer to it via refid in subsequent invocations of the
ftp task within the same target.  Some care would have to be taken to insure
that the connection is closed within the target.

So ant-dev's please chime in here.  Is there any glaring flaw in this plan that
would cause it not to work?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Ant Logging isVerbose()?

2005-05-30 Thread Steve Cohen

In log4j, commons-logging, etc.  a common pattern is

if (isDebugEnabled()) {
   // some expensive string building to put message together
  log.debug(expensiveMessage);
}

The point is that without the isXXXEnabled(), the expensive string 
building must occur even if the most verbose logger activated is not 
verbose enough to cause the log message to be written.


I don't see such functionality in Ant and yet it seems to me like an 
obviously useful extension.  Has there been discussion before about this 
and a conscious decision not to do it?




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31744] - FTP subtasks should all share one connection

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31744.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31744





--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 19:34 ---
Should work fine. :-)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31744] - FTP subtasks should all share one connection

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31744.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31744





--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 19:52 ---
I'd in that case propose an ftp open and a close task, with the other ftp tasks
not closing the connection when an id is given.




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31812] - added logging of local and remote timestamps

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31812.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31812


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 19:54 ---
I've implemented your suggestion in a slightly different way than your patch.

Output as follows:

  [ftp] checking date for A.timed
  [ftp][2005-05-30 12:47:16] local
  [ftp][2005-05-30 12:47:00] remote - (raw: 2005-05-30 12:46:00)
  [ftp] File /home/scohen/tmp.ftp.local/A.timed copied to localhost
  [ftp] checking date for B.timed
  [ftp][2005-05-30 12:47:16] local
  [ftp][2005-05-30 12:48:00] remote - (raw: 2005-05-30 12:47:00)
  [ftp] checking date for C.timed
  [ftp][2005-05-30 12:47:16] local
  [ftp][2005-05-30 12:48:00] remote - (raw: 2005-05-30 12:47:00)
  [ftp] checking date for D.timed
  [ftp][2005-05-30 12:47:16] local
  [ftp][2005-05-30 12:48:00] remote - (raw: 2005-05-30 12:47:00)

The raw part is the raw time on the server without all the adjustments.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/net FTP.java

2005-05-30 Thread scohen
scohen  2005/05/30 10:56:33

  Modified:src/main/org/apache/tools/ant/taskdefs/optional/net FTP.java
  Log:
  Add logging of local vs remote timestamps in ftp task.
  PR:31812
  
  Revision  ChangesPath
  1.79  +28 -8 
ant/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java
  
  Index: FTP.java
  ===
  RCS file: 
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java,v
  retrieving revision 1.78
  retrieving revision 1.79
  diff -u -r1.78 -r1.79
  --- FTP.java  30 May 2005 14:41:34 -  1.78
  +++ FTP.java  30 May 2005 17:56:33 -  1.79
  @@ -26,7 +26,9 @@
   import java.io.IOException;
   import java.io.InputStream;
   import java.io.OutputStream;
  +import java.text.SimpleDateFormat;
   import java.util.Collection;
  +import java.util.Date;
   import java.util.Enumeration;
   import java.util.HashMap;
   import java.util.HashSet;
  @@ -1817,6 +1819,10 @@
   }
   return null;
   }
  +
  +private static final SimpleDateFormat TIMESTAMP_LOGGING_SDF = 
  +new SimpleDateFormat(-MM-dd HH:mm:ss);
  +
   /**
* Checks to see if the remote file is current as compared with the local
* file. Returns true if the target file is up to date.
  @@ -1853,16 +1859,30 @@
   
   long remoteTimestamp = files[0].getTimestamp().getTime().getTime();
   long localTimestamp = localFile.lastModified();
  +long adjustedRemoteTimestamp = 
  +remoteTimestamp + this.timeDiffMillis + this.granularityMillis; 
  +
  +StringBuffer msg = new StringBuffer(   [)
  + .append(TIMESTAMP_LOGGING_SDF.format(new Date(localTimestamp)))
  + .append(] local);
  +log(msg.toString(), Project.MSG_VERBOSE);
  +
  +msg = new StringBuffer(   [)
  + .append(TIMESTAMP_LOGGING_SDF.format(new 
Date(adjustedRemoteTimestamp)))
  + .append(] remote);
  +if (remoteTimestamp != adjustedRemoteTimestamp) {
  +msg.append( - (raw: )
  + .append(TIMESTAMP_LOGGING_SDF.format(new Date(remoteTimestamp)))
  +.append());
  +}
  +log(msg.toString(), Project.MSG_VERBOSE);
  +
  +
  +
   if (this.action == SEND_FILES) {
  -return remoteTimestamp 
  - + this.timeDiffMillis 
  - + this.granularityMillis 
  - = localTimestamp;
  +return adjustedRemoteTimestamp = localTimestamp;
   } else {
  -return localTimestamp 
  - = remoteTimestamp 
  - + this.timeDiffMillis
  - + this.granularityMillis;
  +return localTimestamp = adjustedRemoteTimestamp;
   }
   }
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Online Bookstore

2005-05-30 Thread Ted Husted
On 5/30/05, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
 Final question: are these links ok? Then I will commit that (hopefully)
 today. 

You seem to be using a slightly different form for the Powerll's link,
but the right page comes up, so I suppose it's all right. The
affiliate ID is correct.

-Ted.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




DO NOT REPLY [Bug 31744] - FTP subtasks should all share one connection

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31744.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31744





--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 20:14 ---
A better idea might be something like this:

ftp user=me
 password=mypassword
 server=ftp.big.server
 port=21
 systemTypeKey=UNIX
 serverTimeZone=Asia/Tokyo


 action name=mkdir remotedir=public/private/
 action name=put remotedir=public/private newer=true
 fileset dir=mylocaldir/
 /action 
 action name=get .../
/ftp

This looks like a better plan.  Question now is how to do it and still preserve
backward compatibility.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32579] - [net] Nullpointer exception after using parseFTPEntry in FTPFileEntryParser

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32579.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32579


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Core tasks  |Net
Product|Ant |Commons
Summary|Nullpointer exception after |[net] Nullpointer exception
   |using parseFTPEntry in  |after using parseFTPEntry in
   |FTPFileEntryParser  |FTPFileEntryParser
Version|1.6.2   |1.4 Final




--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 20:24 ---
Hmm.  Are group names restricted to letters only?  If not, how would one tell
where one began and the other ended?  Does HP-UX restrict the group name to a
maximum length?  If so, and if this is a particularity of HPUX, we could
consider a separate parser.  I wonder why we haven't seen this more frequently.
 Do some FTP servers force a space while others don't?

Anyway, moving this one to Jakarta-Commons-Net which is the only place where
this can possibly get fixed.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32579] - [net] Nullpointer exception after using parseFTPEntry in FTPFileEntryParser

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32579.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32579


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|dev@ant.apache.org  |commons-
   ||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33771] - Default username and password for ftp task

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33771.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33771


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 20:33 ---
But isn't the standard protocol with anonymous FTP to leave your email address
as the password?  Granted you can lie, but should Ant encourage this?  I think
not.  And what password WOULD you use?

So at most, we save one property from being defined.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31744] - FTP subtasks should all share one connection

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31744.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31744





--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 20:41 ---
or better yet:

ftp user=me
 password=mypassword
 server=ftp.big.server
 port=21
 systemTypeKey=UNIX
 serverTimeZone=Asia/Tokyo


 mkdir remotedir=public/private/
 put remotedir=public/private newer=true
 fileset dir=mylocaldir/
 /put 
 get .../
/ftp

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Ant Logging isVerbose()?

2005-05-30 Thread Stefan Bodewig
On Mon, 30 May 2005, Steve Cohen [EMAIL PROTECTED] wrote:
 In log4j, commons-logging, etc.  a common pattern is
 
 if (isDebugEnabled()) {
 // some expensive string building to put message together
log.debug(expensiveMessage);
 }
 
 I don't see such functionality in Ant

Because Ant doesn't have a way to determine isDebugEnabled().
XmlLogger, for example, logs everything and ignores the command line
switches.  So the only thing which would know it is the listeners
themselves.

Since the listener API doesn't expose the verbosity - and changing the
interface is no good idea either - I don't see how we could do it.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Ant Logging isVerbose()?

2005-05-30 Thread Steve Cohen

Stefan Bodewig wrote:

On Mon, 30 May 2005, Steve Cohen [EMAIL PROTECTED] wrote:


In log4j, commons-logging, etc.  a common pattern is

if (isDebugEnabled()) {
   // some expensive string building to put message together
  log.debug(expensiveMessage);
}

I don't see such functionality in Ant



Because Ant doesn't have a way to determine isDebugEnabled().
XmlLogger, for example, logs everything and ignores the command line
switches.  So the only thing which would know it is the listeners
themselves.

Since the listener API doesn't expose the verbosity - and changing the
interface is no good idea either - I don't see how we could do it.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Yeah, that's what I thought.  I found the BuildLogger interface with 
setters and no getters and couldn't see a way around that, without 
changing the interface, which of course, has problems of its own.


Oh well.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 6606] - META-BUG problems with delegating classloaders

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=6606.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=6606





--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 21:39 ---
I have a patch that makes junit work without any changes to the ant 
installation.
The only requirement is that you fork a new JVM for the junit test.
How did I do this? I changed the ant-junit.jar so it does not load/reference any
junit classes before it forks a new JVM. That way the classloader problems
disappear since junit classes are not loaded inside ant's JVM.

If you want to give it a testspin, get the jar file here:
1) Download ant-junit.jar from here http://tobiasen.dk/ant/ant-junit.jar
2) Drop it in $ANT_HOME/lib
3) Run your tests, remember to set fork=yes in your tests and have the
junit.jar in the classpath of the test. 
junit fork=yes printsummary=yes
  classpath
include junit.jar here...
  /classpath
...

I have compiled the ant-junit.jar using jdk 1.4.2_08 and against ant 1.6.4.

I would like to submit the patch, but I have no experience in submitting
patches. Please tell me how. 
The patch is quite big, since almost all classes in
org/apache/tools/ant/taskdefs/optional/junit are changed and I have introduced
some new interfaces. 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 6606] - META-BUG problems with delegating classloaders

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=6606.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=6606


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs/manual/OptionalTasks ftp.html

2005-05-30 Thread Steve Loughran

[EMAIL PROTECTED] wrote:

scohen  2005/05/29 17:40:21

  Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/net
FTPTest.java
   src/main/org/apache/tools/ant/taskdefs/optional/net FTP.java
   src/etc/testcases/taskdefs/optional/net ftp.xml
   docs/manual/OptionalTasks ftp.html
  Added:   src/main/org/apache/tools/ant/util Retryable.java
RetryHandler.java
  Log:
  Based on a patch submitted by Neeme Praks, allow support for a retry count on 
FTP transfers.  Some
  servers are unreliable for unknown - this allows for a retry count to be 
specified to accomodate work on such
  flaky servers.



nice. Are you doing any kind of back-off algorithm to deal with load 
problems? If so, add a bit of jitter to increase the randomness. (I 
remember an embedded system without back-off but not jitter failing to 
deal with the situation of an entire building with 120+ nodes having its 
power toggled...)


-steve

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Ant Logging isVerbose()?

2005-05-30 Thread Steve Loughran

Stefan Bodewig wrote:

On Mon, 30 May 2005, Steve Cohen [EMAIL PROTECTED] wrote:


In log4j, commons-logging, etc.  a common pattern is

if (isDebugEnabled()) {
   // some expensive string building to put message together
  log.debug(expensiveMessage);
}

I don't see such functionality in Ant



Because Ant doesn't have a way to determine isDebugEnabled().
XmlLogger, for example, logs everything and ignores the command line
switches.  So the only thing which would know it is the listeners
themselves.

Since the listener API doesn't expose the verbosity - and changing the
interface is no good idea either - I don't see how we could do it.


I've always wondered how much overhead the verbose/debug log info takes 
up. It would make sense to determine the cost before addressing the 
issue. And, as you say, the only solution is changing the interface (or 
cheating, using reflection on the side).


-steve

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 6606] - META-BUG problems with delegating classloaders

2005-05-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=6606.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=6606





--- Additional Comments From [EMAIL PROTECTED]  2005-05-30 22:37 ---
http://ant.apache.org/ant_task_guidelines.html to read about how to create
patches 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: ant/docs/manual cover.html

2005-05-30 Thread antoine
antoine 2005/05/30 13:47:21

  Modified:.Tag: ANT_16_BRANCH WHATSNEW build.xml
   xdocsTag: ANT_16_BRANCH antnews.xml faq.xml index.xml
srcdownload.xml bindownload.xml
   docs Tag: ANT_16_BRANCH antnews.html faq.html index.html
srcdownload.html bindownload.html
   docs/manual Tag: ANT_16_BRANCH cover.html
  Log:
  Preparation for Ant 1.6.5 release
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.503.2.233 +2 -2  ant/WHATSNEW
  
  Index: WHATSNEW
  ===
  RCS file: /home/cvs/ant/WHATSNEW,v
  retrieving revision 1.503.2.232
  retrieving revision 1.503.2.233
  diff -u -r1.503.2.232 -r1.503.2.233
  --- WHATSNEW  30 May 2005 10:05:40 -  1.503.2.232
  +++ WHATSNEW  30 May 2005 20:47:20 -  1.503.2.233
  @@ -1,5 +1,5 @@
  -Changes from Ant 1.6.4 to current Ant 1.6 CVS version
  -=
  +Changes from Ant 1.6.4 to Ant 1.6.5
  +===
   
   Changes that could break older environments:
   
  
  
  
  1.392.2.46 +2 -2  ant/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/ant/build.xml,v
  retrieving revision 1.392.2.45
  retrieving revision 1.392.2.46
  diff -u -r1.392.2.45 -r1.392.2.46
  --- build.xml 19 May 2005 13:51:08 -  1.392.2.45
  +++ build.xml 30 May 2005 20:47:20 -  1.392.2.46
  @@ -25,8 +25,8 @@
 --
 property name=Name value=Apache Ant/
 property name=name value=ant/
  -  property name=version value=1.6.4/
  -  property name=manifest-version value=1.6.4/
  +  property name=version value=1.6.5/
  +  property name=manifest-version value=1.6.5/
 property name=bootstrap.jar value=ant-bootstrap.jar/
   
 property name=ant.package value=org/apache/tools/ant/
  
  
  
  No   revision
  No   revision
  1.48.2.13 +8 -1  ant/xdocs/antnews.xml
  
  Index: antnews.xml
  ===
  RCS file: /home/cvs/ant/xdocs/antnews.xml,v
  retrieving revision 1.48.2.12
  retrieving revision 1.48.2.13
  diff -u -r1.48.2.12 -r1.48.2.13
  --- antnews.xml   19 May 2005 12:22:09 -  1.48.2.12
  +++ antnews.xml   30 May 2005 20:47:20 -  1.48.2.13
  @@ -25,10 +25,17 @@
 /properties
   
   body
  +  section name=Ant 1.6.5
  +h3June 2, 2005 - Ant 1.6.5 Available/h3
  +pApache Ant 1.6.5 is now available for a
  +href=http://ant.apache.org/bindownload.cgi;download/a./p
  +pThis is a bug fix release./p
  +  /section
  +
 section name=Ant 1.6.4
   h3May 19, 2005 - Ant 1.6.4 Available/h3
   pApache Ant 1.6.4 is now available for a
  -href=http://ant.apache.org/bindownload.cgi;download/a./p
  +href=http://archive.apache.org/dist/ant/;download/a./p
   pThis is a bug fix release./p
 /section
   
  
  
  
  1.38.2.24 +5 -0  ant/xdocs/faq.xml
  
  Index: faq.xml
  ===
  RCS file: /home/cvs/ant/xdocs/faq.xml,v
  retrieving revision 1.38.2.23
  retrieving revision 1.38.2.24
  diff -u -r1.38.2.23 -r1.38.2.24
  --- faq.xml   19 May 2005 12:22:09 -  1.38.2.23
  +++ faq.xml   30 May 2005 20:47:20 -  1.38.2.24
  @@ -206,6 +206,11 @@
   td1.6.4/td
   td19 May 2005/td
 /tr
  +
  +  tr
  +td1.6.5/td
  +td2 June 2005/td
  +  /tr
   /table
 /answer
   /faq
  
  
  
  1.52.2.16 +4 -5  ant/xdocs/index.xml
  
  Index: index.xml
  ===
  RCS file: /home/cvs/ant/xdocs/index.xml,v
  retrieving revision 1.52.2.15
  retrieving revision 1.52.2.16
  diff -u -r1.52.2.15 -r1.52.2.16
  --- index.xml 19 May 2005 12:22:09 -  1.52.2.15
  +++ index.xml 30 May 2005 20:47:20 -  1.52.2.16
  @@ -23,12 +23,11 @@
 /properties
   
   body
  -  section name=Ant 1.6.4
  -h3May 19, 2005 - Ant 1.6.4 Available/h3
  -pApache Ant 1.6.4 is now available for a
  +  section name=Ant 1.6.5
  +h3June 2, 2005 - Ant 1.6.5 Available/h3
  +pApache Ant 1.6.5 is now available for a
   href=http://ant.apache.org/bindownload.cgi;download/a./p
  -pThere is a large list of fixed bugs and enhancements./p
  -pSome of the bugs affecting the embedded use of Ant are fixed./p
  +pThis is a bug fix release./p
 /section
   
   
  
  
  
  1.15.2.10 +17 -17ant/xdocs/srcdownload.xml
  
  Index: srcdownload.xml
  ===
  RCS file: /home/cvs/ant/xdocs/srcdownload.xml,v
  retrieving revision 1.15.2.9
  retrieving revision 

Re: cvs commit: ant/docs/manual/OptionalTasks ftp.html

2005-05-30 Thread Steve Cohen

Steve Loughran wrote:

[EMAIL PROTECTED] wrote:


scohen  2005/05/29 17:40:21

  Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/net
FTPTest.java
   src/main/org/apache/tools/ant/taskdefs/optional/net 
FTP.java

   src/etc/testcases/taskdefs/optional/net ftp.xml
   docs/manual/OptionalTasks ftp.html
  Added:   src/main/org/apache/tools/ant/util Retryable.java
RetryHandler.java
  Log:
  Based on a patch submitted by Neeme Praks, allow support for a retry 
count on FTP transfers.  Some
  servers are unreliable for unknown - this allows for a retry count 
to be specified to accomodate work on such

  flaky servers.




nice. Are you doing any kind of back-off algorithm to deal with load 
problems? If so, add a bit of jitter to increase the randomness. (I 
remember an embedded system without back-off but not jitter failing to 
deal with the situation of an entire building with 120+ nodes having its 
power toggled...)


-steve

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



I'm not entirely sure what you mean.  By jitter, are you referring to 
varying the time delay?  I asked Neeme Praks why he didn't put in a time 
delay and he said he didn't need one.  In his use case, he simply sets 
it up to run forever, and that works for him.  Eventually it succeeds. 
But I wonder about this.  Sounds like it could be a tight loop that eats 
all processing under the wrong conditions.


And I'm not sure at all what you mean by a back-off algorithm.

So please elaborate.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]