DO NOT REPLY [Bug 20699] - [PATCH] rmic and seaprate input/output directories
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=20699. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=20699 --- Additional Comments From [EMAIL PROTECTED] 2005-08-22 11:46 --- - Updated detection to see if _Skel.class files were created or not, as by default they are no longer created in JDK1.5. (This included additional functionality in JavaEnvUtils for future reusability, I hope.) You need to be working with CVS_HEAD rmic. This changed the default to explicitly ask for _Skel files, and should have the JavaEnvUtils stuff to detect java1.5 already. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20699] - [PATCH] rmic and seaprate input/output directories
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=20699. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=20699 --- Additional Comments From [EMAIL PROTECTED] 2005-08-22 15:24 --- Will re-prepare once more. I looked at CVS_HEAD, and EnvUtils was unchanged. It already had 1.5 detection - I didn't add that - but there was no good way to test for less than /greater than. (The 1.5 check would fail for 1.6 (Mustang) for example.) I also want to check that JRMC 1.1 is still the default for JDK's 1.5 - I didn't see this to be in the head code at first glance, will look into it. Also, after reviewing your comments on bug #33862, I can get the rmi 1.3 idea taken care of. Any ideas better than Float parsing to deal with the version #'s the user passes in? Thanks for reviewing this! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36301] New: - echoXML echoes the ?xml? header, even when appending
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36301. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36301 Summary: echoXML echoes the ?xml? header, even when appending Product: Ant Version: 1.7Alpha (nightly) Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Core tasks AssignedTo: dev@ant.apache.org ReportedBy: [EMAIL PROTECTED] echoXML hands off XML writing to DOMElementWriter,write(), which always writes the ?xml? header to a document. this means when append=true, we dont build up a proper XML document. options: -omit the header on append -dont allow append -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36302] New: - sshexec closes System.out
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36302. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36302 Summary: sshexec closes System.out Product: Ant Version: 1.6.5 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Optional Tasks AssignedTo: dev@ant.apache.org ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] ChannelExec as an output stream uses TeeOutputStream which is created using directly System.out. Finalization of this channel object closes System.out. The effect is that there is no output from second and subsequent calls to the sshexec task. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36301] - echoXML echoes the ?xml? header, even when appending
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36301. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36301 --- Additional Comments From [EMAIL PROTECTED] 2005-08-22 16:26 --- Why did I write that? Seems like you wanted it for something so I, just fooling around to a great degree, wrote something. What was it? Would it make more sense to use the external xmltask stuff rather than try to reinvent here? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
antlib loading in typedef
Why do you have to repeat the full path to an antlib in typedef, when declaring into an antlib url. surely this should be sufficient typedef uri=antlib:org.smarfrog.tools.ant classpathref=smartfrog.tasks.classpath onerror=failall / I think if we have special handling of antlib namespaces, typedef ought to adopt that same logic, and get the path to the resource from the URI, if it is an antlib URI - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs LoadProperties.java
stevel 2005/08/22 08:38:45
Modified:src/main/org/apache/tools/ant/taskdefs LoadProperties.java
Log:
more diagnostics
Revision ChangesPath
1.30 +2 -2
ant/src/main/org/apache/tools/ant/taskdefs/LoadProperties.java
Index: LoadProperties.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/LoadProperties.java,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- LoadProperties.java 10 Mar 2005 12:50:57 - 1.29
+++ LoadProperties.java 22 Aug 2005 15:38:45 - 1.30
@@ -156,11 +156,11 @@
if (srcFile != null) {
if (!srcFile.exists()) {
-throw new BuildException(Source file does not exist.);
+throw new BuildException(Source file does not exist
:+srcFile);
}
if (!srcFile.isFile()) {
-throw new BuildException(Source file is not a file.);
+throw new BuildException(Source file is not a file
:+srcFile);
}
try {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/xdocs external.xml
jhm 2005/08/22 09:25:28 Modified:xdocsexternal.xml Log: remove blank lines Revision ChangesPath 1.167 +0 -8 ant/xdocs/external.xml Index: external.xml === RCS file: /home/cvs/ant/xdocs/external.xml,v retrieving revision 1.166 retrieving revision 1.167 diff -u -r1.166 -r1.167 --- external.xml 22 Aug 2005 16:15:41 - 1.166 +++ external.xml 22 Aug 2005 16:25:27 - 1.167 @@ -148,9 +148,6 @@ /table /subsection - - - subsection name=ant4eclipse pant4eclipse provides a set of Ant tasks to make several @@ -182,11 +179,6 @@ /table /subsection - - - - - subsection name=AntDoc pAntDoc is a tool that generates HTML documentation from Ant - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36301] - echoXML echoes the ?xml? header, even when appending
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36301. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36301 --- Additional Comments From [EMAIL PROTECTED] 2005-08-22 18:26 --- hey, I have used it in places. I was just noting that the append feature was broken, and may best be stripped. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs MakeUrlTest.java
stevel 2005/08/22 09:49:44
Modified:src/main/org/apache/tools/ant/taskdefs defaults.properties
Added: src/main/org/apache/tools/ant/taskdefs MakeUrl.java
src/etc/testcases/taskdefs makeurl.xml
src/testcases/org/apache/tools/ant/taskdefs MakeUrlTest.java
Log:
This is an official contrib of the smartfrog tourl task to the apache
codebase; its aim has been to set up rmic classpaths, but it turns out to use
maven2 its kind of convenient to be able to turn any location into a file: url.
That is only, what, 3 lines of code, but what this task does is bulk conversion
and a set of unit tests that work.
Docs are to be xdoc generated
Revision ChangesPath
1.174 +1 -0
ant/src/main/org/apache/tools/ant/taskdefs/defaults.properties
Index: defaults.properties
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/defaults.properties,v
retrieving revision 1.173
retrieving revision 1.174
diff -u -r1.173 -r1.174
--- defaults.properties 9 Aug 2005 15:26:49 - 1.173
+++ defaults.properties 22 Aug 2005 16:49:44 - 1.174
@@ -208,6 +208,7 @@
verifyjar=org.apache.tools.ant.taskdefs.VerifyJar
resourcecount=org.apache.tools.ant.taskdefs.ResourceCount
echoxml=org.apache.tools.ant.taskdefs.EchoXML
+makeurl=org.apache.tools.ant.taskdefs.MakeUrl
# deprecated ant tasks (kept for back compatibility)
starteam=org.apache.tools.ant.taskdefs.optional.scm.AntStarTeamCheckOut
1.1 ant/src/main/org/apache/tools/ant/taskdefs/MakeUrl.java
Index: MakeUrl.java
===
/*
* Copyright 2005 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
package org.apache.tools.ant.taskdefs;
import org.apache.tools.ant.BuildException;
import org.apache.tools.ant.Project;
import org.apache.tools.ant.Task;
import org.apache.tools.ant.DirectoryScanner;
import org.apache.tools.ant.types.FileSet;
import org.apache.tools.ant.types.Path;
import java.io.File;
import java.net.MalformedURLException;
import java.util.List;
import java.util.LinkedList;
import java.util.ListIterator;
/**
* This task takes file and turns them into a URL, which it then assigns
* to a property. Use when for setting up RMI codebases.
* p/
* nested filesets are supported; if present, these are turned into the
* url with the given separator between them (default = ).
*
* @ant.task category=core name=tourl
*/
public class MakeUrl extends Task {
/**
* name of the property to set
*/
private String property;
/**
* name of a file to turn into a URL
*/
private File file;
/**
* separator char
*/
private String separator = ;
/**
* filesets of nested files to add to this url
*/
private List filesets = new LinkedList();
/**
* paths to add
*/
private List paths = new LinkedList();
/**
* validation flag
*/
private boolean validate = true;
/**
* error message
*/
public static final String ERROR_MISSING_FILE = A source file is missing
:;
public static final String ERROR_NO_PROPERTY = No property defined;
public static final String ERROR_NO_FILES = No files defined;
/**
* set the name of a property to fill with the URL
*
* @param property
*/
public void setProperty(String property) {
this.property = property;
}
/**
* the name of a file to be converted into a URL
*
* @param file
*/
public void setFile(File file) {
this.file = file;
}
/**
* a fileset of jar files to include in the URL, each
* separated by the separator
*
* @param fileset
*/
public void addFileSet(FileSet fileset) {
filesets.add(fileset);
}
/**
* set the separator for the multi-url option.
*
* @param separator
*/
public void setSeparator(String separator) {
this.separator = separator;
}
/**
* set this flag to trigger
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Definer.java
stevel 2005/08/22 09:51:16
Modified:src/main/org/apache/tools/ant ComponentHelper.java
src/main/org/apache/tools/ant/taskdefs Definer.java
Log:
move to constants to define policy strings; change so that ignore loads print
out something at -v level. Why so? to debug antlib namespace declarations.
Revision ChangesPath
1.59 +1 -1 ant/src/main/org/apache/tools/ant/ComponentHelper.java
Index: ComponentHelper.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/ComponentHelper.java,v
retrieving revision 1.58
retrieving revision 1.59
diff -u -r1.58 -r1.59
--- ComponentHelper.java 13 Aug 2005 15:15:23 - 1.58
+++ ComponentHelper.java 22 Aug 2005 16:51:16 - 1.59
@@ -781,7 +781,7 @@
uri.substring(ANTLIB_PREFIX.length()).replace('.', '/')
+ /antlib.xml);
// a fishing expedition :- ignore errors if antlib not present
-definer.setOnError(new Typedef.OnError(ignore));
+definer.setOnError(new
Typedef.OnError(Typedef.OnError.POLICY_IGNORE));
definer.init();
definer.execute();
}
1.57 +25 -3 ant/src/main/org/apache/tools/ant/taskdefs/Definer.java
Index: Definer.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Definer.java,v
retrieving revision 1.56
retrieving revision 1.57
diff -u -r1.56 -r1.57
--- Definer.java 12 Nov 2004 15:14:59 - 1.56
+++ Definer.java 22 Aug 2005 16:51:16 - 1.57
@@ -41,6 +41,7 @@
* handling is handled by DefBase
*
* @since Ant 1.4
+ * @noinspection ParameterHidesMemberVariable
*/
public abstract class Definer extends DefBase {
private static class ResourceStack extends ThreadLocal {
@@ -74,6 +75,24 @@
public static class OnError extends EnumeratedAttribute {
/** Enumerated values */
public static final int FAIL = 0, REPORT = 1, IGNORE = 2, FAIL_ALL
= 3;
+
+/**
+ * text value of onerror option [EMAIL PROTECTED]
+ */
+public static final String POLICY_FAIL = fail;
+/**
+ * text value of onerror option [EMAIL PROTECTED]
+ */
+public static final String POLICY_REPORT = report;
+/**
+ * text value of onerror option [EMAIL PROTECTED]
+ */
+public static final String POLICY_IGNORE = ignore;
+/**
+ * text value of onerror option [EMAIL PROTECTED]
+ */
+public static final String POLICY_FAILALL = failall;
+
/**
* Constructor
*/
@@ -94,7 +113,7 @@
* @return an array of the allowed values for this attribute.
*/
public String[] getValues() {
-return new String[] {fail, report, ignore, failall};
+return new String[] {POLICY_FAIL, POLICY_REPORT, POLICY_IGNORE,
POLICY_FAILALL};
}
}
@@ -270,7 +289,9 @@
log(message, Project.MSG_WARN);
break;
case OnError.IGNORE:
-// Fall Through
+// log at a lower level
+log(message, Project.MSG_VERBOSE);
+break;
default:
// Ignore the problem
break;
@@ -298,7 +319,8 @@
log(message, Project.MSG_WARN);
break;
case OnError.IGNORE:
-// Fall Through
+log(message, Project.MSG_VERBOSE);
+break;
default:
// Ignore the problem
break;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[Ant Wiki] Update of InstallTroubleshooting by sompol
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Ant Wiki for change
notification.
The following page has been changed by sompol:
http://wiki.apache.org/ant/InstallTroubleshooting
--
== Testing your installation ==
- After installing, a quick test of Ant makes sure that everything is well.
+ bAfter installing, a quick test of Ant makes sure that everything is well.
=== Test Ant is on the path ===
{{{ant}}}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[Ant Wiki] Update of InstallTroubleshooting by MartijnKruithof
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Ant Wiki for change
notification.
The following page has been changed by MartijnKruithof:
http://wiki.apache.org/ant/InstallTroubleshooting
--
== Testing your installation ==
- bAfter installing, a quick test of Ant makes sure that everything is well.
+ After installing, a quick test of Ant makes sure that everything is well.
=== Test Ant is on the path ===
{{{ant}}}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[Ant Wiki] Update of InstallTroubleshooting by MartijnKruithof
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Ant Wiki for change
notification.
The following page has been changed by MartijnKruithof:
http://wiki.apache.org/ant/InstallTroubleshooting
--
== Testing your installation ==
+
+ /!\ '''Edit conflict - other version:'''
After installing, a quick test of Ant makes sure that everything is well.
+
+ /!\ '''Edit conflict - your version:'''
+ After installing, a quick test of Ant makes sure that everything is well.
+
+ /!\ '''End of edit conflict'''
=== Test Ant is on the path ===
{{{ant}}}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[Ant Wiki] Update of InstallTroubleshooting by MartijnKruithof
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Ant Wiki for change
notification.
The following page has been changed by MartijnKruithof:
http://wiki.apache.org/ant/InstallTroubleshooting
--
== Testing your installation ==
-
- /!\ '''Edit conflict - other version:'''
After installing, a quick test of Ant makes sure that everything is well.
-
- /!\ '''Edit conflict - your version:'''
- After installing, a quick test of Ant makes sure that everything is well.
-
- /!\ '''End of edit conflict'''
=== Test Ant is on the path ===
{{{ant}}}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36258] - Solution for ant ftp fails with Nullpointerexception when a symlink is evaluated in method checkRemoteSensitivity in FTP.java for a z/OS ftp server
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36258. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36258 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|dev@ant.apache.org |[EMAIL PROTECTED] -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant WHATSNEW
stevel 2005/08/22 12:44:45 Modified:.WHATSNEW Log: updated Revision ChangesPath 1.851 +11 -3 ant/WHATSNEW Index: WHATSNEW === RCS file: /home/cvs/ant/WHATSNEW,v retrieving revision 1.850 retrieving revision 1.851 diff -u -r1.850 -r1.851 --- WHATSNEW 18 Aug 2005 12:32:16 - 1.850 +++ WHATSNEW 22 Aug 2005 19:44:45 - 1.851 @@ -218,7 +218,7 @@ Bugzilla Report 34374. * os condition adds winnt as a family which can be tested. This is - all windows platforms other than the Win9x line, and windows CE. + all windows platforms other than the Win9x line or Windows CE. * exec (and hence, apply and any other derived classes) have an OsFamily attribute, which can restrict execution to a single OS family. @@ -242,7 +242,9 @@ * check for 1.5.* Ant main class. (weblogic.jar in classpath reports) -* New condition isfailure that tests the return-code of an executable. +* New condition isfailure that tests the return-code of an executable. This + contains platform-specific logic and is better than comparing the result with + 0. * Added initial support for Resource Collections, including the resourcecount task. @@ -253,7 +255,8 @@ * New mapper, scriptmapper, supports scripted mapping of source files/strings to destination strings. -* Add the echoxml task. +* Add the echoxml task. This will echo nested XML to a file, with + the normal ?xml ? processor instruction. UTF-8 encoding only. * Try to make subprojects of custom Project subclasses instances of the same type. Bugzilla report 17901. @@ -269,6 +272,11 @@ * junitreport now generates pages alltests-errors.html and alltests-fails.html, that list only the errors and failures, respectively. Bugzilla Report: 36226 +* New task makeurl that can turn a file reference into an absolute file:// url; and + nested filesets/paths into a (space, comma, whatever) separated list of URLs. Useful + for RMI classpath setup, amongst other things. + + Changes from Ant 1.6.4 to Ant 1.6.5 === - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36235] - Reorganize src/main to separate 3rd-party components
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36235. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36235 --- Additional Comments From [EMAIL PROTECTED] 2005-08-22 23:05 --- Thanks, Jeff! That's _exactly_ what I was looking for! I remember seeing that feature in Eclipse, but honestly, I hadn't used it before, so I didn't recall it as a solution. Just as I was starting to get used to NetBeans... (But I still favor Eclipse! :-) I still think that optional tasks w/out the necessary included libraries should at least be separated out into their own project, possibly individual projects. It just seems to promote better organization of the code, and the idea that they are not part of the core classes. In a project-oriented IDE like Eclipse, the optional project would depend upon core, but not the other way around - making it impossible to link to optional code without moving it into the core package. This, however, is only my $0.02, and it's barely worth that now that I have a feasible way to develop from my regular IDE. This ticket can be closed if desired, but the comments from Steve and Alexey sounded like they were coming towards agreement on the idea. Thanks! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36235] - Reorganize src/main to separate 3rd-party components
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36235. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36235 --- Additional Comments From [EMAIL PROTECTED] 2005-08-22 23:22 --- I understand the concept the desire; I disagree on the importance. My point is: Would you have committers spending time energy diddling around reorganizing the source tree (and the endless discussion votes to follow on how *exactly* to do it), or would you rather see them working on new function / fixing *real* bugs? My personal vote would be for the latter. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/main/org/apache/tools/ant/launch Launcher.java
stevel 2005/08/22 14:24:22
Modified:src/main/org/apache/tools/ant ComponentHelper.java
MagicNames.java
src/main/org/apache/tools/ant/launch Launcher.java
Log:
just making some strings constants, adding javadocs
Revision ChangesPath
1.60 +10 -4 ant/src/main/org/apache/tools/ant/ComponentHelper.java
Index: ComponentHelper.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/ComponentHelper.java,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -r1.59 -r1.60
--- ComponentHelper.java 22 Aug 2005 16:51:16 - 1.59
+++ ComponentHelper.java 22 Aug 2005 21:24:22 - 1.60
@@ -94,6 +94,12 @@
private static final String ANTLIB_PREFIX = antlib:;
/**
+ * string used to control build.syspath policy [EMAIL PROTECTED]
+ */
+private static final String BUILD_SYSCLASSPATH_ONLY = only;
+private static final String ANT_PROPERTY_TASK = property;
+
+/**
* Find a project component for a specific project, creating
* it if it does not exist.
* @param project the project.
@@ -435,10 +441,10 @@
*/
public Task createTask(String taskType) throws BuildException {
Task task = createNewTask(taskType);
-if (task == null taskType.equals(property)) {
+if (task == null taskType.equals(ANT_PROPERTY_TASK)) {
// quick fix for Ant.java use of property before
// initializing the project
-addTaskDefinition(property,
+addTaskDefinition(ANT_PROPERTY_TASK,
org.apache.tools.ant.taskdefs.Property.class);
task = createNewTask(taskType);
}
@@ -676,7 +682,7 @@
private void initTasks() {
ClassLoader classLoader = null;
if (project.getCoreLoader() != null
- !(only.equals(project.getProperty(build.sysclasspath {
+
!(BUILD_SYSCLASSPATH_ONLY.equals(project.getProperty(MagicNames.BUILD_SYSCLASSPATH
{
classLoader = project.getCoreLoader();
}
String dataDefs = MagicNames.TASKDEF_PROPERTIES_RESOURCE;
@@ -721,7 +727,7 @@
private void initTypes() {
ClassLoader classLoader = null;
if (project.getCoreLoader() != null
- !(only.equals(project.getProperty(build.sysclasspath {
+
!(BUILD_SYSCLASSPATH_ONLY.equals(project.getProperty(MagicNames.BUILD_SYSCLASSPATH
{
classLoader = project.getCoreLoader();
}
String dataDefs = MagicNames.TYPEDEFS_PROPERTIES_RESOURCE;
1.10 +8 -3 ant/src/main/org/apache/tools/ant/MagicNames.java
Index: MagicNames.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/MagicNames.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- MagicNames.java 10 Jun 2005 23:06:10 - 1.9
+++ MagicNames.java 22 Aug 2005 21:24:22 - 1.10
@@ -24,14 +24,19 @@
* @since Ant 1.6
*/
public final class MagicNames {
+
+private MagicNames() {
+}
+
/**
* Ant version property. [EMAIL PROTECTED]
*/
public static final String ANT_VERSION = ant.version;
-private MagicNames() {
-}
-
+/**
+ * System classpath policy. [EMAIL PROTECTED]
+ */
+public static final String BUILD_SYSCLASSPATH = build.sysclasspath;
/**
* The name of the script repository used by the script repo task
1.33 +22 -6 ant/src/main/org/apache/tools/ant/launch/Launcher.java
Index: Launcher.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/launch/Launcher.java,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- Launcher.java 9 Aug 2005 15:24:52 - 1.32
+++ Launcher.java 22 Aug 2005 21:24:22 - 1.33
@@ -41,26 +41,42 @@
/** The Ant Library Directory property */
public static final String ANTLIBDIR_PROPERTY = ant.library.dir;
-/** The directory name of the per-user ant directory */
+/**
+ * The directory name of the per-user ant directory
+ * [EMAIL PROTECTED]
+ */
public static final String ANT_PRIVATEDIR = .ant;
/**
- * The location of a per-user library directory
+ * The name of a per-user library directory
+ * [EMAIL PROTECTED]
*/
public static final String ANT_PRIVATELIB = lib;
-/** The location of a per-user library directory */
+/** The location of a per-user library directory
+ * [EMAIL PROTECTED]
+
DO NOT REPLY [Bug 36235] - Reorganize src/main to separate 3rd-party components
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36235. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36235 --- Additional Comments From [EMAIL PROTECTED] 2005-08-23 01:01 --- Point taken, thanks. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs AntlibTest.java
stevel 2005/08/22 16:02:52
Modified:.build.xml
src/etc/testcases/taskdefs antlib.xml
src/main/org/apache/tools/ant ComponentHelper.java
MagicNames.java
src/main/org/apache/tools/ant/taskdefs Definer.java
src/testcases/org/apache/tools/ant/taskdefs AntlibTest.java
Log:
Antlib changes. One I like, one I am still not sure I have right
1. you can go typedef uri=antlib:something / and the resource is worked
out automatically from the URI.
2. if you use antlib://org/ex/resource.xml we load in the resource by its
full path, so you dont need multiple packages to have multiple antlib files.
I'm not sure about #2; I think it is convenient once you have antlib-only
distros (i.e. inline declaration and script; nothing else), but am not sure
about the syntax. Maybe
antlib://org.ex/antlib.xml would be better, and more in keeping with WWW
URLs; if /antlib.xml is omitted, we would add it by default.
Revision ChangesPath
1.478 +4 -1 ant/build.xml
Index: build.xml
===
RCS file: /home/cvs/ant/build.xml,v
retrieving revision 1.477
retrieving revision 1.478
diff -u -r1.477 -r1.478
--- build.xml 5 Aug 2005 22:57:54 - 1.477
+++ build.xml 22 Aug 2005 23:02:52 - 1.478
@@ -1602,7 +1602,8 @@
value=${tests-classpath.value}/
sysproperty key=root file=${basedir}/
sysproperty key=build.compiler value=${build.compiler}/
-
+ sysproperty key=tests.and.ant.share.classloader
+ value=${tests.and.ant.share.classloader}/
formatter type=brief usefile=false/
batchtest
@@ -1775,6 +1776,8 @@
value=${tests-classpath.value}/
sysproperty key=root file=${basedir}/
sysproperty key=build.compiler value=${build.compiler}/
+ sysproperty key=tests.and.ant.share.classloader
+ value=${tests.and.ant.share.classloader}/
classpath refid=tests-classpath/
formatter type=plain usefile=false/
test name=${testcase}/
1.5 +17 -0 ant/src/etc/testcases/taskdefs/antlib.xml
Index: antlib.xml
===
RCS file: /home/cvs/ant/src/etc/testcases/taskdefs/antlib.xml,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- antlib.xml24 Oct 2003 10:16:16 - 1.4
+++ antlib.xml22 Aug 2005 23:02:52 - 1.5
@@ -36,4 +36,21 @@
x:preset.echo xmlns:x=abc name=p/
x:p xmlns:x=abcHello from x:p/x:p
/target
+
+ target name=antlib_uri
+typedef uri=antlib:org.example.tasks onerror=failall/
+ /target
+
+ target name=antlib_uri_auto xmlns:ex=antlib:org.example.tasks
+ex:simple
+ echo message=inside simple /
+/ex:simple
+ /target
+
+ target name=antlib_uri_auto2
xmlns:ex=antlib://org/example/tasks/antlib2.xml
+ex:simple
+ echo message=inside simple/
+/ex:simple
+ /target
+
/project
\ No newline at end of file
1.61 +8 -6 ant/src/main/org/apache/tools/ant/ComponentHelper.java
Index: ComponentHelper.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/ComponentHelper.java,v
retrieving revision 1.60
retrieving revision 1.61
diff -u -r1.60 -r1.61
--- ComponentHelper.java 22 Aug 2005 21:24:22 - 1.60
+++ ComponentHelper.java 22 Aug 2005 23:02:52 - 1.61
@@ -36,6 +36,7 @@
import java.lang.reflect.InvocationTargetException;
import org.apache.tools.ant.taskdefs.Typedef;
+import org.apache.tools.ant.taskdefs.Definer;
import org.apache.tools.ant.launch.Launcher;
/**
@@ -91,7 +92,6 @@
private static final String ERROR_NO_TASK_LIST_LOAD = Can't load
default task list;
private static final String ERROR_NO_TYPE_LIST_LOAD = Can't load
default type list;
public static final String COMPONENT_HELPER_REFERENCE =
ant.ComponentHelper;
-private static final String ANTLIB_PREFIX = antlib:;
/**
* string used to control build.syspath policy [EMAIL PROTECTED]
@@ -782,13 +782,15 @@
checkedNamespaces.add(uri);
Typedef definer = new Typedef();
definer.setProject(project);
+definer.init();
definer.setURI(uri);
-definer.setResource(
-uri.substring(ANTLIB_PREFIX.length()).replace('.', '/')
-+ /antlib.xml);
+//there to stop error messages being null
+definer.setTaskName(uri);
+//if this is left out, bad things happen. like all build files break
+//on the first element encountered.
+
DO NOT REPLY [Bug 36301] - echoXML echoes the ?xml? header, even when appending
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36301. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36301 --- Additional Comments From [EMAIL PROTECTED] 2005-08-23 01:50 --- we can do whatever we like, since it's never seen a release... including delete it. But if it's salvageable, we can do whatever... seems pretty intuitive that append would omit the header. I knew there was something broken about this task but I never got the chance to work on it... until I forgot what was wrong with it. :) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36290] - copy filtering=on mutilates LATIN1 text files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36290. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36290 --- Additional Comments From [EMAIL PROTECTED] 2005-08-23 03:16 --- why would we make the default latin1? Why not Big5? If there has to be a default would not some sort of universal charset such as utf-8 not be a better choice. Why not leave this as the platform default? Am I missing something? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36311] New: - Minor typo in move documentation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36311. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36311 Summary: Minor typo in move documentation Product: Ant Version: 1.6.5 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P2 Component: Documentation AssignedTo: dev@ant.apache.org ReportedBy: [EMAIL PROTECTED] In /docs/manual/CoreTasks/move.html, shouldn't: The default mapper used by copy is the identity. Actually be: The default mapper used by move is the identity. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: antlib loading in typedef
On Mon, 22 Aug 2005, Steve Loughran [EMAIL PROTECTED] wrote: Why do you have to repeat the full path to an antlib in typedef, when declaring into an antlib url. antlib descriptor, you mean? If so, I agree with you, we should magically provide a default for the resource attribute if uri has been specified and uses the antlib protocol. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs MakeUrlTest.java
On 22 Aug 2005, [EMAIL PROTECTED] wrote: url = fileToConvert.toURI().toURL().toExternalForm(); I think File.toURI is JDK 1.4+. What is wrong with FileUtils.toURL()? Shouldn't we improve FileUtils and use that from the task if anything is wrong? Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs AntlibTest.java
bodewig 2005/08/22 21:11:12 Modified:src/main/org/apache/tools/ant/taskdefs Definer.java src/testcases/org/apache/tools/ant/taskdefs AntlibTest.java Log: 2005 Revision ChangesPath 1.59 +1 -1 ant/src/main/org/apache/tools/ant/taskdefs/Definer.java Index: Definer.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Definer.java,v retrieving revision 1.58 retrieving revision 1.59 diff -u -r1.58 -r1.59 --- Definer.java 22 Aug 2005 23:02:52 - 1.58 +++ Definer.java 23 Aug 2005 04:11:12 - 1.59 @@ -1,5 +1,5 @@ /* - * Copyright 2001-2004 The Apache Software Foundation + * Copyright 2001-2005 The Apache Software Foundation * * Licensed under the Apache License, Version 2.0 (the License); * you may not use this file except in compliance with the License. 1.10 +1 -1 ant/src/testcases/org/apache/tools/ant/taskdefs/AntlibTest.java Index: AntlibTest.java === RCS file: /home/cvs/ant/src/testcases/org/apache/tools/ant/taskdefs/AntlibTest.java,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- AntlibTest.java 22 Aug 2005 23:02:52 - 1.9 +++ AntlibTest.java 23 Aug 2005 04:11:12 - 1.10 @@ -1,5 +1,5 @@ /* - * Copyright 2003-2004 The Apache Software Foundation + * Copyright 2003-2005 The Apache Software Foundation * * Licensed under the Apache License, Version 2.0 (the License); * you may not use this file except in compliance with the License. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
AW: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs MakeUrlTest.java
Index: MakeUrl.java
===
...
* @ant.task category=core name=tourl
s/tourl/makeurl/ you are using that in the default.properties (not the
SmartFrog name :-)
/**
* error message
*/
public static final String ERROR_MISSING_FILE = A source file is missing
:;
public static final String ERROR_NO_PROPERTY = No property defined;
public static final String ERROR_NO_FILES = No files defined;
A JavaDoc comment only for the first? No [EMAIL PROTECTED] ? g
private String filesetsToURL() {
...
log(asUrl, Project.MSG_DEBUG);
Would the output of the origin file be helpful?
log(f + -- + asUrl, Project.MSG_DEBUG);
Mmh - same log statement in pathsToURL() ...
public void execute() throws BuildException {
validate();
//now exit here if the property is already set
if (getProject().getProperty(property) != null) {
return;
}
A log statement would be helpful
if (getProject().getProperty(property) != null) {
log(property ' + property + ' already set, exiting makeurl,
Project.MSG_VERBOSE);
//same log level as setting the property
return;
}
cheers
Jan
-Ursprüngliche Nachricht-
Von: Stefan Bodewig [mailto:[EMAIL PROTECTED]
Gesendet: Dienstag, 23. August 2005 06:06
An: dev@ant.apache.org
Betreff: Re: cvs commit:
ant/src/testcases/org/apache/tools/ant/taskdefs MakeUrlTest.java
On 22 Aug 2005, [EMAIL PROTECTED] wrote:
url = fileToConvert.toURI().toURL().toExternalForm();
I think File.toURI is JDK 1.4+.
What is wrong with FileUtils.toURL()? Shouldn't we improve
FileUtils and use that from the task if anything is wrong?
Stefan
-
To unsubscribe, e-mail: [EMAIL PROTECTED] For
additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
AW: request to change External Tools and Tasks page
page updated, please recheck Jan -Ursprüngliche Nachricht- Von: Tom Brus [mailto:[EMAIL PROTECTED] Gesendet: Donnerstag, 18. August 2005 21:51 An: dev@ant.apache.org Betreff: request to change External Tools and Tasks page Hi, Could you run the following patch on the External Tools and Tasks page? === snip === --- external.xml2005-08-16 23:55:11.883272000 +0200 +++ external2.xml 2005-08-16 23:58:19.513070400 +0200 @@ -435,15 +435,15 @@ table class=externals tr thCompatibility:/th -tdAnt 1.3/td +tdAnt 1.3 and up/td /tr tr thURL:/th -tda href=http://www.euronet.nl/users/tomb/cleanImports/index.html; http://www.e uronet.nl/users/tomb/cleanImports/index.html/a/td +tda href=http://www.cleanimports.tombrus.nl;http://www.cleanimpor ts.tombrus.nl /a/td /tr tr thContact:/th -tda href=mailto:[EMAIL PROTECTED]Tom Brus/a/td +tda href=mailto:[EMAIL PROTECTED]Tom + Brus/a/td /tr tr thLicense:/th === snip === I also included the patch as an attachment, for your convenience. Thanks, Tom Brus - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
AW: Announcement: new release of ant4eclipse
added to external page, please check Jan -Ursprüngliche Nachricht- Von: Nils Hartmann [mailto:[EMAIL PROTECTED] Gesendet: Samstag, 20. August 2005 00:10 An: Ant Developers List Betreff: Announcement: new release of ant4eclipse Hi, today we published the 0.2 release of ant4eclipse, a project that provides Ant tasks to access configuration files from the Eclipse IDE. Enhancements in this release include the support of eclipse container classpathes and variables. Also included is a new task that executes ant targets for eclipse buildCommands. It would be nice if you could add a reference to the External Tools and Tasks page with the informations below. Thanks! Regards, Nils Name: ant4eclipse Description: ant4eclipse provides a set of Ant tasks to make several configurations from the Eclipse IDE available in Ant buildscripts. The tasks are aimed to avoid redundancy between Eclipse and Ant configurations in order to build small but powerful build systems for the continuous integration process Compatibility: Ant 1.6.1 and higher URL: http://ant4eclipse.sf.net Contact: a href=http://sourceforge.net/mail/?group_id=137377;ant4eclipse user mailing list/a License: Sun Public License - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
AW: cvs commit: ant/src/main/org/apache/tools/ant/launch Launcher.java
Index: ComponentHelper.java === /** + * string used to control build.syspath policy [EMAIL PROTECTED] + */ +private static final String BUILD_SYSCLASSPATH_ONLY = only; +private static final String ANT_PROPERTY_TASK = property; Only documenting one constant? ;-) Jan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
