Re: Where to submit patch to SQLExec.java
Kevin Jackson wrote: If I recall, there was a previous discussion about whether SQLExec should/shouldn't be refactored to deal with the myriad backend dbs that it must support. I don't think the discussion went anywhere in the end, but this task does have a lot of bug reps/enhancements filed against it Kev Let's make this something for the 1.7.1 timeframe :) As I mentioned on ant-user last week, I pulled a bit of the SqlExec task out for use in smartfrog, stripping it down quite a lot. There were some things there that I felt wouldnt work, like the delimiter checking if keepformatting=true, as a space at the end of the line would break the logic: Bad :DROP TABLE foo; Good: DROP TABLE foo One big problem with sqlexec is the many databases out there, some of which cost $100K+, ignoring the hardware you need too. But that should not stop us testing on hssql, derby and possibly mysql, postgres all of which cost $0. Getting the test system up and running would be the first part of the problem. -steve - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39798] - Verbose attribute in delete task not working
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39798. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39798 --- Additional Comments From [EMAIL PROTECTED] 2006-10-31 03:04 --- I have tried with jdk1.4.2_12 on a win 2k box with ant 1.6.5 and do not see the problem. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36274] - XmlLogger does not work with targets containing input core task.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36274. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36274 --- Additional Comments From [EMAIL PROTECTED] 2006-10-31 03:21 --- input means that it is waiting for user input for the console. The issue here is that the output of the input task goes to the logger and not to the console, so there is no prompt for input. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release Apache .NET Antlib 1.0 final
+1 Peter I have had a quick look at the antlib, just a couple of comments - for a 1.0.1 version; 1) the antlib.xml does not set the onerror attribute, this means that all the definitions will be loaded when one is loaded, using onerror=ignore should be used. (ignore is a bit of a misnomer - it should be deferred, i.e. the check will be made when the task is first used). 2) the doc of the old core tasks is a bit confusing, it is not completly apparent that the tasks are in the antlib and not in ant itself. (old versions of which are of course). The examples need to be namespaceized. Peter On 10/30/06, Martijn Kruithof [EMAIL PROTECTED] wrote: +0 Martijn On 10/29/06, Stefan Bodewig [EMAIL PROTECTED] wrote: Hi, I've created distribution files for the .NET Antlib and uploaded them to http://people.apache.org/~bodewig/dotnet-antlib/ and propose to release them as 1.0 final. As described on the release plan for this Antlib I don't expect the betas to get enough people to test it and the Antlib needs more testers outside the Ant team so I'd like to skip further betas. The release has been tested on: WinXP + Microsoft .NET 1.1 WinXP + Microsoft .NET 2.0 WinXP + Mono 1.1.17 Linux + Mono 1.1.14 (Gump) Linux + Mono 1.1.17 Mac OS X + Mono 1.1.18 Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: antlib attributes - WAS: [VOTE] Release Apache .NET Antlib 1.0 final
On 10/31/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: 1) the antlib.xml does not set the onerror attribute, this means that all the definitions will be loaded when one is loaded, using onerror=ignore should be used. (ignore is a bit of a misnomer - it should be deferred, i.e. the check will be made when the task is first used). Where is this documented? Good point! It is not documented. taskdef name=mytask classname=this.does.not.exist onerror=ignore will be accepted ok. However when used, mytask/ one gets the message: C:\Documents and Settings\reilly\learning\a\typedef\build.xml:6: Problem: failed to create task or type mytask Cause: the class this.does.not.exist was not found. Action: Check that the component has been correctly declared . The idea of using the value ignore in an antlib is to defer creating the types/tasks until they are used by the build script - this emulates the built-in tasks/types of ant and allows thirdparty antlibs to have optional types/tasks Peter Jan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
antlib attributes - WAS: [VOTE] Release Apache .NET Antlib 1.0 final
1) the antlib.xml does not set the onerror attribute, this means that all the definitions will be loaded when one is loaded, using onerror=ignore should be used. (ignore is a bit of a misnomer - it should be deferred, i.e. the check will be made when the task is first used). Where is this documented? Jan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: echo task documentation error
empty. If foo is empty by mistake, how will one troubleshoot this?
and not a blank line. Undefined properties are echoed as literal text, not
skipped.
I'm well aware of that ;-) That's why I wrote empty, not not
defined. As in empty string vs null string.
The proper way to output a line separator is by using
echo${line.separator}/echo. That this doesn't work in Maven is a
bug for Maven, not a feature of Ant.
AFAIK, *any* task output is prefixed by the task's name. A line
separator is output in my book ;-) I fail to see why it would be good
to make an exception for echo/ somehow.
Go ahead and fix the doc bug if you want. Strictly speaking this is
in keeping with BC; but this is yet another one of these little quirks
Ant is full of. --DD
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: echo task documentation error
--- Dominique Devienne [EMAIL PROTECTED] wrote: [SNIP] AFAIK, *any* task output is prefixed by the task's name. A line separator is output in my book ;-) I fail to see why it would be good to make an exception for echo/ somehow. FWIW, I agree. -Matt Go ahead and fix the doc bug if you want. Strictly speaking this is in keeping with BC; but this is yet another one of these little quirks Ant is full of. --DD - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Low, Low, Low Rates! Check out Yahoo! Messenger's cheap PC-to-Phone call rates (http://voice.yahoo.com) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39798] - Verbose attribute in delete task not working
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39798. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39798 --- Additional Comments From [EMAIL PROTECTED] 2006-10-31 07:03 --- (In reply to comment #8) Do not be too hard on reporters of bugs, it is important to get reports on user experiances with ant. Hell, I smiled, didn't I? :) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r469506 - in /ant/core/trunk: ./ src/etc/poms/ src/etc/poms/ant-antlr/ src/etc/poms/ant-apache-bcel/ src/etc/poms/ant-apache-bsf/ src/etc/poms/ant-apache-log4j/ src/etc/poms/ant-apache-oro
Author: antoine
Date: Tue Oct 31 06:54:29 2006
New Revision: 469506
URL: http://svn.apache.org/viewvc?view=revrev=469506
Log:
set the groupId of ant from maven to org.apache.ant
as discussed on the repository mailing list
Modified:
ant/core/trunk/build.xml
ant/core/trunk/src/etc/poms/ant-antlr/pom.xml
ant/core/trunk/src/etc/poms/ant-apache-bcel/pom.xml
ant/core/trunk/src/etc/poms/ant-apache-bsf/pom.xml
ant/core/trunk/src/etc/poms/ant-apache-log4j/pom.xml
ant/core/trunk/src/etc/poms/ant-apache-oro/pom.xml
ant/core/trunk/src/etc/poms/ant-apache-regexp/pom.xml
ant/core/trunk/src/etc/poms/ant-apache-resolver/pom.xml
ant/core/trunk/src/etc/poms/ant-commons-logging/pom.xml
ant/core/trunk/src/etc/poms/ant-commons-net/pom.xml
ant/core/trunk/src/etc/poms/ant-jai/pom.xml
ant/core/trunk/src/etc/poms/ant-javamail/pom.xml
ant/core/trunk/src/etc/poms/ant-jdepend/pom.xml
ant/core/trunk/src/etc/poms/ant-jmf/pom.xml
ant/core/trunk/src/etc/poms/ant-jsch/pom.xml
ant/core/trunk/src/etc/poms/ant-junit/pom.xml
ant/core/trunk/src/etc/poms/ant-launcher/pom.xml
ant/core/trunk/src/etc/poms/ant-netrexx/pom.xml
ant/core/trunk/src/etc/poms/ant-nodeps/pom.xml
ant/core/trunk/src/etc/poms/ant-starteam/pom.xml
ant/core/trunk/src/etc/poms/ant-stylebook/pom.xml
ant/core/trunk/src/etc/poms/ant-swing/pom.xml
ant/core/trunk/src/etc/poms/ant-trax/pom.xml
ant/core/trunk/src/etc/poms/ant-weblogic/pom.xml
ant/core/trunk/src/etc/poms/ant/pom.xml
ant/core/trunk/src/etc/poms/pom.xml
Modified: ant/core/trunk/build.xml
URL:
http://svn.apache.org/viewvc/ant/core/trunk/build.xml?view=diffrev=469506r1=469505r2=469506
==
--- ant/core/trunk/build.xml (original)
+++ ant/core/trunk/build.xml Tue Oct 31 06:54:29 2006
@@ -32,6 +32,8 @@
--
property name=Name value=Apache Ant/
property name=name value=ant/
+ !-- this is the groupId of ant in the Maven repository --
+ property name=groupid value=org.apache.ant/
property name=project.version value=1.7.0Beta3/
!-- pom.version is used when doing a distribution and must match with what
is checked in under src/etc/poms --
property name=pom.version value=1.7.0-SNAPSHOT/
@@ -153,7 +155,7 @@
property name=src.dist.docs value=${src.dist.dir}/docs/
property name=src.dist.lib value=${src.dist.dir}/lib/
- property name=java-repository.dir value=java-repository/${name}/
+ property name=java-repository.dir value=java-repository/${groupid}/
property name=java-repository.jars.dir
value=${java-repository.dir}/jars/
property name=java-repository.poms.dir
value=${java-repository.dir}/poms/
Modified: ant/core/trunk/src/etc/poms/ant-antlr/pom.xml
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/etc/poms/ant-antlr/pom.xml?view=diffrev=469506r1=469505r2=469506
==
--- ant/core/trunk/src/etc/poms/ant-antlr/pom.xml (original)
+++ ant/core/trunk/src/etc/poms/ant-antlr/pom.xml Tue Oct 31 06:54:29 2006
@@ -3,20 +3,20 @@
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
parent
-groupIdant/groupId
+groupIdorg.apache.ant/groupId
artifactIdant-parent/artifactId
relativePath../pom.xml/relativePath
version1.7.0-SNAPSHOT/version
/parent
modelVersion4.0.0/modelVersion
- groupIdant/groupId
+ groupIdorg.apache.ant/groupId
artifactIdant-antlr/artifactId
version1.7.0-SNAPSHOT/version
descriptionantlr specific task.
The implementation forks a java process, therefore the antlr jar file is
only needed at runtime/description
dependencies
dependency
- groupIdant/groupId
+ groupIdorg.apache.ant/groupId
artifactIdant/artifactId
version1.7.0-SNAPSHOT/version
optionaltrue/optional
Modified: ant/core/trunk/src/etc/poms/ant-apache-bcel/pom.xml
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/etc/poms/ant-apache-bcel/pom.xml?view=diffrev=469506r1=469505r2=469506
==
--- ant/core/trunk/src/etc/poms/ant-apache-bcel/pom.xml (original)
+++ ant/core/trunk/src/etc/poms/ant-apache-bcel/pom.xml Tue Oct 31 06:54:29 2006
@@ -3,18 +3,18 @@
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
parent
-groupIdant/groupId
+groupIdorg.apache.ant/groupId
artifactIdant-parent/artifactId
relativePath../pom.xml/relativePath
version1.7.0-SNAPSHOT/version
/parent
modelVersion4.0.0/modelVersion
- groupIdant/groupId
+ groupIdorg.apache.ant/groupId
artifactIdant-apache-bcel/artifactId
version1.7.0-SNAPSHOT/version
dependencies
dependency
- groupIdant/groupId
+
DO NOT REPLY [Bug 39798] - Verbose attribute in delete task not working
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39798. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39798 --- Additional Comments From [EMAIL PROTECTED] 2006-10-31 06:53 --- Opps, you are right, I did not see the -verbose in the included bat file, I did not use the included bat file as the java and ant dirs are hard-coded. Do not be too hard on reporters of bugs, it is important to get reports on user experiances with ant. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 40852] - Javadoc failed: java.io.IOException: CreateProcess
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40852. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=40852 --- Additional Comments From [EMAIL PROTECTED] 2006-10-31 09:25 --- Just a couple of problems. 1) the optionsListWriter is not closed/flushed, so the file is not completed 2) the code does not handle spaces in directory names 3) if the paths have \ and they are in quoted strings, javadoc does not like them 4) the patch should be provided as a diff agaist the current svn version of ant (using svn diff command) 5) the manual doc for javadoc would need to updated to describe new behaviour of useExternalFile However, I think that this is a good idea, I do not know if it can get into Ant 1.7.0. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 40852] - JavaDoc cannot handle very large classpath on windows
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40852. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=40852 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Javadoc failed: |JavaDoc cannot handle very |java.io.IOException:|large classpath on windows |CreateProcess | -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 40852] - JavaDoc cannot handle very large classpath on windows
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40852. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=40852 --- Additional Comments From [EMAIL PROTECTED] 2006-10-31 09:27 --- Created an attachment (id=19060) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=19060action=view) patch containing mods to javadoc This patch should take care of the problems described in #2, except for the update to the manual -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 40852] New: - Javadoc failed: java.io.IOException: CreateProcess
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40852.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40852
Summary: Javadoc failed: java.io.IOException: CreateProcess
Product: Ant
Version: 1.6.5
Platform: PC
OS/Version: Windows XP
Status: NEW
Keywords: PatchAvailable
Severity: normal
Priority: P2
Component: Core tasks
AssignedTo: dev@ant.apache.org
ReportedBy: [EMAIL PROTECTED]
I had an exception (Javadoc failed: java.io.IOException: CreateProcess) when
I run my Doclet task on Windows XP. The fact is : my classpath is very long and
Windows' shell can not handle it.
The 'useExternalFile' flag is set to true but it does not affect the
classpath's variable.
So I modify javadoc.java with the following code, is it possible to include
it within a new release of Ant ?
--
File tmpList = null;
File optionsTmpList = null;
PrintWriter srcListWriter = null;
PrintWriter optionsListWriter = null;
try {
/**
* Write sourcefiles and package names to a temporary file
* if requested.
*/
// Code added
// Write all options to a file
if (useExternalFile) {
if (optionsTmpList == null) {
optionsTmpList = fileUtils.createTempFile
(javadocOptions, , null);
optionsTmpList.deleteOnExit();
String[] listOpt = toExecute.getArguments();
toExecute.clearArgs();
toExecute.createArgument()
.setValue(@ + optionsTmpList.getAbsolutePath());
optionsListWriter = new PrintWriter(
new FileWriter(optionsTmpList.getAbsolutePath(),
true));
for (int i = 0; i listOpt.length; i++) {
String string = listOpt[i];
if (string.startsWith(-J-)) {
toExecute.createArgument
().setValue(string);
} else {
if (string.startsWith(-
)) {
optionsListWriter.println();
optionsListWriter.print(string);
} else {
optionsListWriter.print(string);
}
optionsListWriter.print
( );
}
}
}
// End of added code
if (tmpList == null) {
tmpList = fileUtils.createTempFile(javadoc, , null);
tmpList.deleteOnExit();
toExecute.createArgument()
.setValue(@ + tmpList.getAbsolutePath());
}
...
} finally {
if (srcListWriter != null) {
srcListWriter.close();
}
// Added code
if (optionsListWriter != null) {
optionsListWriter.close();
}
}
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 40852] - JavaDoc cannot handle very large classpath on windows
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40852. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=40852 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||26739 --- Additional Comments From [EMAIL PROTECTED] 2006-10-31 09:34 --- There is already a request for this: http://issues.apache.org/bugzilla/show_bug.cgi?id=26739 Some code needs to be added to support jdk 1.3. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26739] - javadoc should put all parameters into an external file when requested or automatically
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=26739. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=26739 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||40852 nThis|| -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 40847] - Possible NullPointerException in Jar.createIndexList()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40847. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=40847 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |minor --- Additional Comments From [EMAIL PROTECTED] 2006-10-31 06:00 --- I don't think this could happen using Ant via XML, but I guess Java API usage would be susceptible. Downgrading to minor for this reason. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39798] - Verbose attribute in delete task not working
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39798. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39798 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2006-10-31 06:40 --- well, duh. Peter, did you run the build with plain Ant or with the included batch file? The batch file passes -verbose to Ant, which causes the huge listing. I'm not sure why you're using this custom batch file to launch Ant anyway. You should probably join the userlist to get a better idea of how to configure your system without having to resort to such things. Especially, forgive me for saying, when they waste others' time looking for problems that are not there. :) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release Apache .NET Antlib 1.0 final
On Tue, 31 Oct 2006, Peter Reilly [EMAIL PROTECTED] wrote: 1) the antlib.xml does not set the onerror attribute, this means that all the definitions will be loaded when one is loaded, using onerror=ignore should be used. This is a good advice in general but in the case of AntUnit or the .NET Antlib you don't have any external dependencies. Either you are able to run any task of it, or none. 2) the doc of the old core tasks is a bit confusing, it is not completly apparent that the tasks are in the antlib and not in ant itself. So true. Thanks Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39108] - FTP.java missing checks when file type is unknown
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39108. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39108 --- Additional Comments From [EMAIL PROTECTED] 2006-10-31 14:41 --- (In reply to comment #6) Are you closing it as WONTFIX because you believe that there is no one in the Ant community who wants to process this bug report ? yes, that is a pretty accurate description. But I understand you have a lot to do, and my solution works for me. I think that your bug report makes a valid point. Actually, I am the one who wrote these methods isFunctioningAsFile and isFunctioningAsDirectory. Yes, I did not have in mind directory entries which are neither files nor directories. Yes it might be a good idea to avoid doing anything with these directory entries FTP wise. yes. I had to patch Ant locally to avoid the problem when the commons.net.MVSFTPEntryParser returns filetype unknown. I am reopening the report. thanks. Basically, if filetype is unknown both methods isFile and isDir should return false. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r469717 - in /ant/core/trunk/src/main/org/apache/tools/ant: ./ filters/ helper/ input/ launch/
Author: peterreilly
Date: Tue Oct 31 16:13:43 2006
New Revision: 469717
URL: http://svn.apache.org/viewvc?view=revrev=469717
Log:
some checkstyle changes
Modified:
ant/core/trunk/src/main/org/apache/tools/ant/AntClassLoader.java
ant/core/trunk/src/main/org/apache/tools/ant/AntTypeDefinition.java
ant/core/trunk/src/main/org/apache/tools/ant/ComponentHelper.java
ant/core/trunk/src/main/org/apache/tools/ant/Diagnostics.java
ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java
ant/core/trunk/src/main/org/apache/tools/ant/MagicNames.java
ant/core/trunk/src/main/org/apache/tools/ant/Main.java
ant/core/trunk/src/main/org/apache/tools/ant/Project.java
ant/core/trunk/src/main/org/apache/tools/ant/ProjectComponent.java
ant/core/trunk/src/main/org/apache/tools/ant/Task.java
ant/core/trunk/src/main/org/apache/tools/ant/UnknownElement.java
ant/core/trunk/src/main/org/apache/tools/ant/filters/FixCrLfFilter.java
ant/core/trunk/src/main/org/apache/tools/ant/filters/ReplaceTokens.java
ant/core/trunk/src/main/org/apache/tools/ant/helper/ProjectHelper2.java
ant/core/trunk/src/main/org/apache/tools/ant/helper/ProjectHelperImpl.java
ant/core/trunk/src/main/org/apache/tools/ant/input/GreedyInputHandler.java
ant/core/trunk/src/main/org/apache/tools/ant/input/InputRequest.java
ant/core/trunk/src/main/org/apache/tools/ant/launch/Launcher.java
Modified: ant/core/trunk/src/main/org/apache/tools/ant/AntClassLoader.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/AntClassLoader.java?view=diffrev=469717r1=469716r2=469717
==
--- ant/core/trunk/src/main/org/apache/tools/ant/AntClassLoader.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/AntClassLoader.java Tue Oct 31
16:13:43 2006
@@ -1538,6 +1538,10 @@
}
}
+/**
+ * Returns a codeString/code representing this loader.
+ * @return the path that this classloader has.
+ */
public String toString() {
return AntClassLoader[ + getClasspath() + ];
}
Modified: ant/core/trunk/src/main/org/apache/tools/ant/AntTypeDefinition.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/AntTypeDefinition.java?view=diffrev=469717r1=469716r2=469717
==
--- ant/core/trunk/src/main/org/apache/tools/ant/AntTypeDefinition.java
(original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/AntTypeDefinition.java Tue Oct
31 16:13:43 2006
@@ -163,8 +163,9 @@
/**
* Try and load a class, with no attempt to catch any fault.
* @return the class that implements this component
- * @throws ClassNotFoundException
- * @throws NoClassDefFoundError
+ * @throws ClassNotFoundException if the class cannot be found.
+ * @throws NoClassDefFoundError if the there is an error
+ *finding the class.
*/
public Class innerGetTypeClass() throws ClassNotFoundException {
if (clazz != null) {
@@ -284,10 +285,10 @@
* @param newclass class to create
* @param project
* @return a newly constructed and bound instance.
- * @throws NoSuchMethodException
- * @throws InstantiationException
- * @throws IllegalAccessException
- * @throws InvocationTargetException
+ * @throws NoSuchMethodException no good construtor.
+ * @throws InstantiationException cannot initialize the object.
+ * @throws IllegalAccessException cannot access the object.
+ * @throws InvocationTargetException error in invocation.
*/
public Object innerCreateAndSet(Class newclass, Project project)
throws NoSuchMethodException,
Modified: ant/core/trunk/src/main/org/apache/tools/ant/ComponentHelper.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/ComponentHelper.java?view=diffrev=469717r1=469716r2=469717
==
--- ant/core/trunk/src/main/org/apache/tools/ant/ComponentHelper.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/ComponentHelper.java Tue Oct
31 16:13:43 2006
@@ -124,8 +124,8 @@
* contrived work here to enable this early.
*/
private static final String ANT_PROPERTY_TASK = property;
-
- // {tasks, types}
+
+// {tasks, types}
private static Properties[] defaultDefinitions = new Properties[2];
@@ -502,14 +502,17 @@
if (c == null || !(Task.class.isAssignableFrom(c))) {
return null;
}
-Object _task = createComponent(taskType);
-if (_task == null) {
+Object obj= createComponent(taskType);
+if (obj == null) {
return null;
}
-if (!(_task instanceof Task)) {
-throw new BuildException(Expected
svn commit: r469751 - in /ant/core/trunk: docs/manual/CoreTasks/echo.html src/main/org/apache/tools/ant/taskdefs/Echo.java
Author: scohen
Date: Tue Oct 31 18:04:27 2006
New Revision: 469751
URL: http://svn.apache.org/viewvc?view=revrev=469751
Log:
remove from documentation (and from comment in source code) the incorrect
statement that a message attribute or character data within the element is
required.
Modified:
ant/core/trunk/docs/manual/CoreTasks/echo.html
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Echo.java
Modified: ant/core/trunk/docs/manual/CoreTasks/echo.html
URL:
http://svn.apache.org/viewvc/ant/core/trunk/docs/manual/CoreTasks/echo.html?view=diffrev=469751r1=469750r2=469751
==
--- ant/core/trunk/docs/manual/CoreTasks/echo.html (original)
+++ ant/core/trunk/docs/manual/CoreTasks/echo.html Tue Oct 31 18:04:27 2006
@@ -44,8 +44,9 @@
tr
td valign=topmessage/td
td valign=topthe message to echo./td
-td valign=top align=centerYes, unless data is included in a
- character section within this element./td
+td valign=top align=centerNo. Text may also be included in a
+ character section within this element. If neither is included a
+ blank line will be emitted in the output./td
/tr
tr
td valign=topfile/td
Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Echo.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Echo.java?view=diffrev=469751r1=469750r2=469751
==
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Echo.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Echo.java Tue Oct 31
18:04:27 2006
@@ -40,7 +40,7 @@
* @ant.task category=utility
*/
public class Echo extends Task {
-protected String message = ; // required
+protected String message = ;
protected File file = null;
protected boolean append = false;
/** encoding; set to null or empty means 'default' */
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: echo task documentation error
Dominique Devienne wrote:
empty. If foo is empty by mistake, how will one troubleshoot this?
and not a blank line. Undefined properties are echoed as literal
text, not skipped.
I'm well aware of that ;-) That's why I wrote empty, not not
defined. As in empty string vs null string.
The proper way to output a line separator is by using
echo${line.separator}/echo. That this doesn't work in Maven is a
bug for Maven, not a feature of Ant.
AFAIK, *any* task output is prefixed by the task's name. A line
separator is output in my book ;-) I fail to see why it would be good
to make an exception for echo/ somehow.
Go ahead and fix the doc bug if you want. Strictly speaking this is
in keeping with BC; but this is yet another one of these little quirks
Ant is full of. --DD
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
I stand corrected, thanks.
I checked in the manual change.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r469781 - in /ant/core/trunk/src/main/org/apache/tools/ant: ProjectComponent.java types/AbstractFileSet.java types/DataType.java types/PatternSet.java
Author: antoine
Date: Tue Oct 31 21:11:27 2006
New Revision: 469781
URL: http://svn.apache.org/viewvc?view=revrev=469781
Log:
reactivate mergePatterns in AbstractFileSet, implement clone in DataType and
ProjectComponent
Modified:
ant/core/trunk/src/main/org/apache/tools/ant/ProjectComponent.java
ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java
ant/core/trunk/src/main/org/apache/tools/ant/types/DataType.java
ant/core/trunk/src/main/org/apache/tools/ant/types/PatternSet.java
Modified: ant/core/trunk/src/main/org/apache/tools/ant/ProjectComponent.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/ProjectComponent.java?view=diffrev=469781r1=469780r2=469781
==
--- ant/core/trunk/src/main/org/apache/tools/ant/ProjectComponent.java
(original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/ProjectComponent.java Tue Oct
31 21:11:27 2006
@@ -18,12 +18,13 @@
package org.apache.tools.ant;
+
/**
* Base class for components of a project, including tasks and data types.
* Provides common facilities.
*
*/
-public abstract class ProjectComponent {
+public abstract class ProjectComponent implements Cloneable {
/**
* Project object of this component.
@@ -121,5 +122,15 @@
System.err.println(msg);
}
}
+}
+/**
+ * @since Ant 1.7
+ * @return a shallow copy of this projectcomponent.
+ */
+public Object clone() throws CloneNotSupportedException {
+ProjectComponent pc = (ProjectComponent) super.clone();
+pc.setLocation(getLocation());
+pc.setProject(getProject());
+return pc;
}
}
Modified:
ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java?view=diffrev=469781r1=469780r2=469781
==
--- ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java
(original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java Tue
Oct 31 21:11:27 2006
@@ -459,16 +459,12 @@
}
ds.setBasedir(dir);
-final int count = additionalPatterns.size();
-for (int i = 0; i count; i++) {
-Object o = additionalPatterns.elementAt(i);
-defaultPatterns.append((PatternSet) o, p);
-}
+PatternSet ps = mergePatterns(p);
p.log(getDataTypeName() + : Setup scanner in dir + dir
-+ with + defaultPatterns, Project.MSG_DEBUG);
++ with + ps, Project.MSG_DEBUG);
-ds.setIncludes(defaultPatterns.getIncludePatterns(p));
-ds.setExcludes(defaultPatterns.getExcludePatterns(p));
+ds.setIncludes(ps.getIncludePatterns(p));
+ds.setExcludes(ps.getExcludePatterns(p));
if (ds instanceof SelectorScanner) {
SelectorScanner ss = (SelectorScanner) ds;
ss.setSelectors(getSelectors(p));
@@ -803,8 +799,7 @@
if (isReference()) {
return getRef(p).mergePatterns(p);
}
-PatternSet ps = new PatternSet();
-ps.append(defaultPatterns, p);
+PatternSet ps = (PatternSet) defaultPatterns.clone();
final int count = additionalPatterns.size();
for (int i = 0; i count; i++) {
Object o = additionalPatterns.elementAt(i);
Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/DataType.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/DataType.java?view=diffrev=469781r1=469780r2=469781
==
--- ant/core/trunk/src/main/org/apache/tools/ant/types/DataType.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/types/DataType.java Tue Oct 31
21:11:27 2006
@@ -37,7 +37,7 @@
* but not lt;pathgt;)./p
*
*/
-public abstract class DataType extends ProjectComponent {
+public abstract class DataType extends ProjectComponent implements Cloneable {
/**
* The description the user has set.
@@ -352,5 +352,18 @@
return d == null ? getDataTypeName() : getDataTypeName() + + d;
}
+/**
+ * @since Ant 1.7
+ * @return a shallow copy of this DataType.
+ */
+public Object clone() throws CloneNotSupportedException {
+DataType dt = (DataType) super.clone();
+dt.setDescription(getDescription());
+if (getRefid() != null) {
+ dt.setRefid(getRefid());
+ }
+dt.setChecked(isChecked());
+return dt;
+}
}
Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/PatternSet.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/PatternSet.java?view=diffrev=469781r1=469780r2=469781
