Re: [EMAIL PROTECTED]: Project ivy-tests (in module ivy) failed
This is my fault, I'll take care of fixing this later today. Xavier On Mon, Mar 24, 2008 at 10:42 PM, Gump Integration Build [EMAIL PROTECTED] wrote: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project ivy-tests has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - ivy-tests : Ivy is a tool for managing (recording, tracking, resolving a... Full details are available at: http://vmgump.apache.org/gump/public/ivy/ivy-tests/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/ivy/build/test-report The following work was performed: http://vmgump.apache.org/gump/public/ivy/ivy-tests/gump_work/build_ivy_ivy-tests.html Work Name: build_ivy_ivy-tests (Type: Build) Work ended in a state of : Failed Elapsed: 3 mins 29 secs Command Line: /usr/lib/jvm/java-1.5.0-sun/bin/java - Djava.awt.headless=true-Xbootclasspath/p:/srv/gump/public/workspace/xml-commons/java/external/build/xml- apis.jar:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar org.apache.tools.ant.Main - Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only-Doffline=true - Dno.resolve=true test [Working Directory: /srv/gump/public/workspace/ivy] CLASSPATH: /usr/lib/jvm/java-1.5.0-sun /lib/tools.jar:/srv/gump/public/workspace/ivy/build/test:/srv/gump/public/workspace/ivy/build/artifact/jars/ivy- 24032008.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/packages/junit3.8.1/junit.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/httpcomponents/oac.hc3x/dist/commons-httpclient.jar:/srv/gump/public/workspace/apache-commons/codec/dist/commons-codec-24032008.jar:/srv/gump/public/workspace/commons-cli-1.0.x/target/commons-cli-24032008.jar:/srv/gump/public/workspace/jakarta-oro/jakarta-oro- 24032008.jar:/srv/gump/public/workspace/apache-commons/vfs/target/commons-vfs-24032008.jar:/srv/gump/public/workspace/apache-commons/vfs/sandbox/target/commons-vfs-sandbox-24032008.jar:/srv/gump/public/workspace/jakarta-slide/webdavclient/dist/lib/jakarta-slide-webdavlib-24032008.jar:/srv/gump/packages/jsch/jsch-0.1.28.jar:/srv/gump/public/workspace/junit/dist/junit-24032008.jar:/srv/gump/public/workspace/apache-commons/lang/commons-lang-24032008.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-24032008.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-24032008.jar:/srv/gump/public/workspace/apache-commons/collections/build/commons-collections-24032008.jar:/srv/gump/public/workspace/commons-sandbox/compress/target/commons-compress-24032008.jar:/srv/gump/public/workspace/apache-commons/net/dist/commons-net-24032008.jar:/srv/gump/public/worksp a ce/httpcomponents/2.0.2/commons- httpclient-2.0.2.jar:/srv/gump/packages/jcifs/jcifs-0.8.1.jar - [junit] Running org.apache.ivy.plugins.conflict.StrictConflictManagerTest [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 1,128 sec [junit] Running org.apache.ivy.plugins.latest.LatestRevisionStrategyTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0,656 sec [junit] Running org.apache.ivy.plugins.lock.ArtifactLockStrategyTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 13,153 sec [junit] Running org.apache.ivy.plugins.namespace.MRIDTransformationRuleTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,236 sec [junit] Running org.apache.ivy.plugins.parser.ModuleDescriptorParserRegistryTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,558 sec [junit] Running org.apache.ivy.plugins.parser.m2.PomModuleDescriptorParserTest [junit] Tests run: 25, Failures: 0, Errors: 0, Time elapsed: 0,889 sec [junit] Running org.apache.ivy.plugins.parser.m2.PomModuleDescriptorWriterTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0,7 sec [junit] Running
Re: [Vote] 1.7.1beta2
Kevin Jackson wrote: Hi, I've been informed (on the q.t) that I never actually requested a vote before announcing that the ant 1.7.1 beta tarballs were available. So officially at the moment, the tarballs on people.apache.org that I announced are beta-in-potentia :( A retrospective vote on these tarballs has been proposed, so Available tarballs at http://people.apache.org/dist/ant/v1.7.1beta2/ are ready: yes [ x ] (+1) no [ ] (-1) my vote yes [ x ] (+1) no [ ] (-1) -- Steve Loughran http://www.1060.org/blogxter/publish/5 Author: Ant in Action http://antbook.org/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: AW: [VOTE][RESULT] add Nicolas Lalevée as committer
Le lundi 25 février 2008, [EMAIL PROTECTED] a écrit : With 13 binding +1, 1 non binding, and one accordez moi, I'm pleased to announce that this vote passed successfully. Nicolas, we are honoured to welcome you as a new Apache Ant committer. I will contact you in private to give you some details on what you need to do now to wear your ASF committer hat :-) Welcome aboard! I am honoured to be part of the Apache family. :) Following the tradition let's introduce myself. I am 27 years old, french, and I live in Toulouse, while being in the heart a mediterranean as all my childhood was in front of the see. I started to not only use computers but try to improve them with a Ti-89 calculator [1]. So I started at a very low level with some 68k asm, and then I quickly learned C to avoid some headache. Then I discovered Java in my french engineering school which I found pretty cool in transforming segmentation faults into NPEs. After my graduation I did an internship at Anyware Technologies where I discovered the web applications, the open source and the Apache Foundation via Sylvain Wallez. Thank you Sylvain for introducing me to the Apache projects, but most of all to the community aspect of the foundation. Working on different projects I learned first about Cocoon, then I did some Eclipse plugins. After that I deeply looked into Lucene, also OpenRDF, and learned about Ivy after some maven frustration. I also get interested by Husdon, did an Ivy plugin and became a committer there. Then little on my own (I would like to thank my managers to allow me to do so) I decided to try to make IvyDE work because I was bugging me and a lot of my colleagues, forcing us to use some tricks. I had some difficulties to enter into the Eclipse JDT framework, but some thread on the ivy user mailing list keep me investigating bugs. Now that I know deeper Eclipse, I will continue to improve IvyDE because I think that even if Ant + Ivy can be a standalone core build system, tools for users do make the difference between a application and a great application. Thank you everyone! Nicolas [1] http://www.hibnet.org/ti.php PS: special dedication to my father who wrote me a dedication in his book : you have to contribute to the open source !. Done dad ! ;) Welcome Nicolas. Maybe you could update the committer page when you have commit rights. I got my commits rights, it is time to test them :) But I am not sure which page you are talking about. There is this one : http://ant.apache.org/contributors.html But I don't see Xavier, Maarten or Gilles over there. And as far as I know there isn't a such page on the ivy site. So only reference to them I have found is there: https://svn.apache.org/repos/asf/ant/ivy/core/trunk/RELEASE_NOTES Nicolas - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: AW: [VOTE][RESULT] add Nicolas Lalevée as committer
On Tue, Mar 25, 2008 at 3:03 PM, Nicolas Lalevée [EMAIL PROTECTED] wrote: Le lundi 25 février 2008, [EMAIL PROTECTED] a écrit : With 13 binding +1, 1 non binding, and one accordez moi, I'm pleased to announce that this vote passed successfully. Nicolas, we are honoured to welcome you as a new Apache Ant committer. I will contact you in private to give you some details on what you need to do now to wear your ASF committer hat :-) Welcome aboard! I am honoured to be part of the Apache family. :) Following the tradition let's introduce myself. I am 27 years old, french, and I live in Toulouse, while being in the heart a mediterranean as all my childhood was in front of the see. I started to not only use computers but try to improve them with a Ti-89 calculator [1]. So I started at a very low level with some 68k asm, and then I quickly learned C to avoid some headache. Then I discovered Java in my french engineering school which I found pretty cool in transforming segmentation faults into NPEs. After my graduation I did an internship at Anyware Technologies where I discovered the web applications, the open source and the Apache Foundation via Sylvain Wallez. Thank you Sylvain for introducing me to the Apache projects, but most of all to the community aspect of the foundation. Working on different projects I learned first about Cocoon, then I did some Eclipse plugins. After that I deeply looked into Lucene, also OpenRDF, and learned about Ivy after some maven frustration. I also get interested by Husdon, did an Ivy plugin and became a committer there. Then little on my own (I would like to thank my managers to allow me to do so) I decided to try to make IvyDE work because I was bugging me and a lot of my colleagues, forcing us to use some tricks. I had some difficulties to enter into the Eclipse JDT framework, but some thread on the ivy user mailing list keep me investigating bugs. Now that I know deeper Eclipse, I will continue to improve IvyDE because I think that even if Ant + Ivy can be a standalone core build system, tools for users do make the difference between a application and a great application. Thank you everyone! Nicolas [1] http://www.hibnet.org/ti.php PS: special dedication to my father who wrote me a dedication in his book : you have to contribute to the open source !. Done dad ! ;) Welcome Nicolas. Maybe you could update the committer page when you have commit rights. I got my commits rights, Excellent! it is time to test them :) But I am not sure which page you are talking about. There is this one : http://ant.apache.org/contributors.html But I don't see Xavier, Maarten or Gilles over there. And as far as I know there isn't a such page on the ivy site. So only reference to them I have found is there: https://svn.apache.org/repos/asf/ant/ivy/core/trunk/RELEASE_NOTES Indeed, there is no committers page on the site, sorry for the confusion. The files I suggest to update are the RELEASE_NOTES and CHANGES.txt in trunk. Then I guess you already have plenty of code to check in in IvyDE :-) Xavier https://svn.apache.org/repos/asf/ant/ivy/core/trunk/RELEASE_NOTES Nicolas - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Xavier Hanin - Independent Java Consultant http://xhab.blogspot.com/ http://ant.apache.org/ivy/ http://www.xoocode.org/
Re: svn commit: r640867 - in /ant/ivy/core/trunk: CHANGES.txt RELEASE_NOTES
On Tue, Mar 25, 2008 at 4:55 PM, [EMAIL PROTECTED] wrote: Author: hibou Date: Tue Mar 25 08:55:08 2008 New Revision: 640867 URL: http://svn.apache.org/viewvc?rev=640867view=rev Log: - moved my name from the contributor list to the committer list - unified space and tabs use Modified: ant/ivy/core/trunk/CHANGES.txt ant/ivy/core/trunk/RELEASE_NOTES Modified: ant/ivy/core/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/CHANGES.txt?rev=640867r1=640866r2=640867view=diff == --- ant/ivy/core/trunk/CHANGES.txt (original) +++ ant/ivy/core/trunk/CHANGES.txt Tue Mar 25 08:55:08 2008 @@ -8,6 +8,7 @@ Committers Maarten Coene Xavier Hanin + Nicolas LalevÃ(c)e It seems you have an encoding problem. We use ISO-8859-1 encoding. Could you check that you use the same, and commit again with the properly encoded é ? Xavier Gilles Scokart Contributors @@ -33,7 +34,6 @@ Christer Jonsson Matthias Kilian Gregory Kisling - Nicolas Lalevée Tat Leung Costin Leau Antoine Levy-Lambert Modified: ant/ivy/core/trunk/RELEASE_NOTES URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/RELEASE_NOTES?rev=640867r1=640866r2=640867view=diff == --- ant/ivy/core/trunk/RELEASE_NOTES (original) +++ ant/ivy/core/trunk/RELEASE_NOTES Tue Mar 25 08:55:08 2008 @@ -154,20 +154,20 @@ Committers Maarten Coene Xavier Hanin + Nicolas LalevÃ(c)e Gilles Scokart Contributors -Andrea Bernardo Ciddio -Mikkel Bjerg -Mirko Bulovic -Danno Ferrin -Benjamin Francisoud - Nicolas Lalevée -Markus M. May -Adrian Sandor -Ruslan Shevchenko -Johan Stuyts - + Andrea Bernardo Ciddio + Mikkel Bjerg + Mirko Bulovic + Danno Ferrin + Benjamin Francisoud + Markus M. May + Adrian Sandor + Ruslan Shevchenko + Johan Stuyts + 8. List of Changes in this Release For a full release history of Ivy see the file CHANGES.txt -- Xavier Hanin - Independent Java Consultant http://xhab.blogspot.com/ http://ant.apache.org/ivy/ http://www.xoocode.org/
Re: svn commit: r640867 - in /ant/ivy/core/trunk: CHANGES.txt RELEASE_NOTES
Le mardi 25 mars 2008, Xavier Hanin a écrit : On Tue, Mar 25, 2008 at 4:55 PM, [EMAIL PROTECTED] wrote: Author: hibou Date: Tue Mar 25 08:55:08 2008 New Revision: 640867 URL: http://svn.apache.org/viewvc?rev=640867view=rev Log: - moved my name from the contributor list to the committer list - unified space and tabs use Modified: ant/ivy/core/trunk/CHANGES.txt ant/ivy/core/trunk/RELEASE_NOTES Modified: ant/ivy/core/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/CHANGES.txt?rev=640867r1 =640866r2=640867view=diff = = --- ant/ivy/core/trunk/CHANGES.txt (original) +++ ant/ivy/core/trunk/CHANGES.txt Tue Mar 25 08:55:08 2008 @@ -8,6 +8,7 @@ Committers Maarten Coene Xavier Hanin + Nicolas LalevÃ(c)e It seems you have an encoding problem. We use ISO-8859-1 encoding. Could you check that you use the same, and commit again with the properly encoded é ? yep, I just saw it and it is already fixed and committed. Nicolas Xavier Gilles Scokart Contributors @@ -33,7 +34,6 @@ Christer Jonsson Matthias Kilian Gregory Kisling - Nicolas Lalevée Tat Leung Costin Leau Antoine Levy-Lambert Modified: ant/ivy/core/trunk/RELEASE_NOTES URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/RELEASE_NOTES?rev=640867; r1=640866r2=640867view=diff = = --- ant/ivy/core/trunk/RELEASE_NOTES (original) +++ ant/ivy/core/trunk/RELEASE_NOTES Tue Mar 25 08:55:08 2008 @@ -154,20 +154,20 @@ Committers Maarten Coene Xavier Hanin + Nicolas LalevÃ(c)e Gilles Scokart Contributors -Andrea Bernardo Ciddio -Mikkel Bjerg -Mirko Bulovic -Danno Ferrin -Benjamin Francisoud - Nicolas Lalevée -Markus M. May -Adrian Sandor -Ruslan Shevchenko -Johan Stuyts - + Andrea Bernardo Ciddio + Mikkel Bjerg + Mirko Bulovic + Danno Ferrin + Benjamin Francisoud + Markus M. May + Adrian Sandor + Ruslan Shevchenko + Johan Stuyts + 8. List of Changes in this Release For a full release history of Ivy see the file CHANGES.txt -- Nicolas LALEVÉE ANYWARE TECHNOLOGIES Tel : +33 (0)5 61 00 52 90 Fax : +33 (0)5 61 00 51 46 http://www.anyware-tech.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r640867 - in /ant/ivy/core/trunk: CHANGES.txt RELEASE_NOTES
Xavier Hanin wrote: == --- ant/ivy/core/trunk/CHANGES.txt (original) +++ ant/ivy/core/trunk/CHANGES.txt Tue Mar 25 08:55:08 2008 @@ -8,6 +8,7 @@ Committers Maarten Coene Xavier Hanin + Nicolas LalevÃ(c)e It seems you have an encoding problem. We use ISO-8859-1 encoding. Could you check that you use the same, and commit again with the properly encoded é ? Just curious, why would anybody use anything other than UTF-8 for international characters? Btw, my name is Adrian Sándor (assuming it shows up correctly), but I don't consider it a big issue. Adrian
Re: svn commit: r640867 - in /ant/ivy/core/trunk: CHANGES.txt RELEASE_NOTES
On Tue, Mar 25, 2008 at 5:27 PM, Adrian Sandor [EMAIL PROTECTED] wrote: Xavier Hanin wrote: == --- ant/ivy/core/trunk/CHANGES.txt (original) +++ ant/ivy/core/trunk/CHANGES.txt Tue Mar 25 08:55:08 2008 @@ -8,6 +8,7 @@ Committers Maarten Coene Xavier Hanin + Nicolas LalevÃ(c)e It seems you have an encoding problem. We use ISO-8859-1 encoding. Could you check that you use the same, and commit again with the properly encoded é ? Just curious, why would anybody use anything other than UTF-8 for international characters? I guess the answer is only because ISO-8859-1 is the default encoding on french boxes, and I didn't changed the default when I first start developing Ivy. But it shouldn't be a big issue, we shouldn't have international characters in our files except for the names. Actually we've avoided any such trouble so far by removing accents in contributors names. IMO it's not worth the trouble, but I don't have any accent in my name, so I'm certainly biased :-) Btw, my name is Adrian Sándor (assuming it shows up correctly), but I don't consider it a big issue. So I'd prefer keeping it like it is now. For contributors names I simply copy paste their names from JIRA. I don't know if JIRA support accents in usernames, but I guess not, so it's a good way to filter out accents :-) Xavier Adrian -- Xavier Hanin - Independent Java Consultant http://xhab.blogspot.com/ http://ant.apache.org/ivy/ http://www.xoocode.org/
Jira permissions
Hi, I got commit rights, and everything works like a charm apart some encoding issues :) Then about Jira, shouldn't I have more edition right ? Like assigning myself to an issue ? And it seems that I can edit some workflow : https://issues.apache.org/jira/browse/IVYDE-70 But not on this one: https://issues.apache.org/jira/browse/IVYDE-39 Did something strange happen when the jira database was imported from Jayasoft ? Nicolas - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r640878 - in /ant/ivy/core/trunk: CHANGES.txt RELEASE_NOTES
Text files do not specify an encoding. It this utf-8 or win1252 or latin1 ? Peter On Tue, Mar 25, 2008 at 4:11 PM, [EMAIL PROTECTED] wrote: Author: hibou Date: Tue Mar 25 09:11:41 2008 New Revision: 640878 URL: http://svn.apache.org/viewvc?rev=640878view=rev Log: Encoding fix Modified: ant/ivy/core/trunk/CHANGES.txt ant/ivy/core/trunk/RELEASE_NOTES Modified: ant/ivy/core/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/CHANGES.txt?rev=640878r1=640877r2=640878view=diff == --- ant/ivy/core/trunk/CHANGES.txt (original) +++ ant/ivy/core/trunk/CHANGES.txt Tue Mar 25 09:11:41 2008 @@ -8,7 +8,7 @@ Committers Maarten Coene Xavier Hanin - Nicolas LalevÃ(c)e + Nicolas Lalevée Gilles Scokart Contributors Modified: ant/ivy/core/trunk/RELEASE_NOTES URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/RELEASE_NOTES?rev=640878r1=640877r2=640878view=diff == --- ant/ivy/core/trunk/RELEASE_NOTES (original) +++ ant/ivy/core/trunk/RELEASE_NOTES Tue Mar 25 09:11:41 2008 @@ -154,7 +154,7 @@ Committers Maarten Coene Xavier Hanin - Nicolas LalevÃ(c)e + Nicolas Lalevée Gilles Scokart Contributors - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Vote] 1.7.1beta2
+1 Kevin Jackson wrote: A retrospective vote on these tarballs has been proposed, so Available tarballs at http://people.apache.org/dist/ant/v1.7.1beta2/ are ready: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Should ScriptRunner call terminate() on the BSFManager?
Hi, We've recently integrated Jepp (http://jepp.sourceforge.net/) into our use of Ant via the BSF engine. This is very useful because we use Python for scripting quite a lot and it allows Python code to be used in full while also allowing access to Java objects. This has resulted in a Java OOM error, which I suspect is due to this integration change. There is a comment in the Jepp usage instructions that close() must be called on the Jep objects. This is done inside the terminate() method of the BSFJepEngine, which is called by the BSFManager on all engines. However I cannot see anywhere where BSFManager.terminate() is called inside ScriptRunner or elsewhere inside Ant. Should terminate() be called by ScriptRunner(), perhaps in the finally section in the executeScript method? thanks paul
Re: Should ScriptRunner call terminate() on the BSFManager?
[EMAIL PROTECTED] wrote: Hi, We've recently integrated Jepp (http://jepp.sourceforge.net/) into our use of Ant via the BSF engine. This is very useful because we use Python for scripting quite a lot and it allows Python code to be used in full while also allowing access to Java objects. This has resulted in a Java OOM error, which I suspect is due to this integration change. There is a comment in the Jepp usage instructions that close() must be called on the Jep objects. This is done inside the terminate() method of the BSFJepEngine, which is called by the BSFManager on all engines. However I cannot see anywhere where BSFManager.terminate() is called inside ScriptRunner or elsewhere inside Ant. Should terminate() be called by ScriptRunner(), perhaps in the finally section in the executeScript method? Others will be more familiar with the ScriptRunnerXXX classes than me but in WebTest, its Script task has a keep flag. This might be a useful concept to have here. Basically the flag allows you to distinguish between scenarios where you want the binding retained across tasks (and hence in the scenario above I suspect you don't want terminate() called) and the case where you want a fresh manager/runner for each run. Again, I haven't done a complete analysis of what gets called where in Ant at the moment. Just noting an important use case for WebTest which I know is in use in the field in many places. Paul. P.S. For those that aren't aware, WebTest is an Ant extension for testing web applications. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Should ScriptRunner call terminate() on the BSFManager?
On Tue, Mar 25, 2008 at 8:59 PM, Paul King [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: Hi, We've recently integrated Jepp (http://jepp.sourceforge.net/) into our use of Ant via the BSF engine. This is very useful because we use Python for scripting quite a lot and it allows Python code to be used in full while also allowing access to Java objects. This has resulted in a Java OOM error, which I suspect is due to this integration change. There is a comment in the Jepp usage instructions that close() must be called on the Jep objects. This is done inside the terminate() method of the BSFJepEngine, which is called by the BSFManager on all engines. However I cannot see anywhere where BSFManager.terminate() is called inside ScriptRunner or elsewhere inside Ant. Should terminate() be called by ScriptRunner(), perhaps in the finally section in the executeScript method? Just had a quick look, we should call the terminate method - it is part of the life cycle that we missed. Looking at some of the languages: beanshell does not use the terminate method jruby does rhino does not groovy does not jython does not netrexx does not jacl does not so it is not surprising that we missed this. The odd thing is that javax.scripting does not seem to have a corresponding method and the jruby javax.script engine calls the terminate for each invoke method. Others will be more familiar with the ScriptRunnerXXX classes than me but in WebTest, its Script task has a keep flag. This might be a useful concept to have here. Basically the flag allows you to distinguish between scenarios where you want the binding retained across tasks (and hence in the scenario above I suspect you don't want terminate() called) and the case where you want a fresh manager/runner for each run. Again, I haven't done a complete analysis of what gets called where in Ant at the moment. Just noting an important use case for WebTest which I know is in use in the field in many places. It should be possible to modify the scripting code in such a way that will not affect people that use the code. Peter Paul. P.S. For those that aren't aware, WebTest is an Ant extension for testing web applications. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Should ScriptRunner call terminate() on the BSFManager?
Peter Reilly wrote: On Tue, Mar 25, 2008 at 8:59 PM, Paul King [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: Hi, We've recently integrated Jepp (http://jepp.sourceforge.net/) into our use of Ant via the BSF engine. This is very useful because we use Python for scripting quite a lot and it allows Python code to be used in full while also allowing access to Java objects. This has resulted in a Java OOM error, which I suspect is due to this integration change. There is a comment in the Jepp usage instructions that close() must be called on the Jep objects. This is done inside the terminate() method of the BSFJepEngine, which is called by the BSFManager on all engines. However I cannot see anywhere where BSFManager.terminate() is called inside ScriptRunner or elsewhere inside Ant. Should terminate() be called by ScriptRunner(), perhaps in the finally section in the executeScript method? Just had a quick look, we should call the terminate method - it is part of the life cycle that we missed. Looking at some of the languages: beanshell does not use the terminate method jruby does rhino does not groovy does not jython does not netrexx does not jacl does not so it is not surprising that we missed this. The odd thing is that javax.scripting does not seem to have a corresponding method and the jruby javax.script engine calls the terminate for each invoke method. Others will be more familiar with the ScriptRunnerXXX classes than me but in WebTest, its Script task has a keep flag. This might be a useful concept to have here. Basically the flag allows you to distinguish between scenarios where you want the binding retained across tasks (and hence in the scenario above I suspect you don't want terminate() called) and the case where you want a fresh manager/runner for each run. Again, I haven't done a complete analysis of what gets called where in Ant at the moment. Just noting an important use case for WebTest which I know is in use in the field in many places. It should be possible to modify the scripting code in such a way that will not affect people that use the code. OK, that is good to know. Here is a sample of what WebTest does: scriptStep keep=true language=javascript var foo = bar; /scriptStep !-- other tasks here ... -- storeProperty name=upperfoo value=#{script:foo.toUpperCase()}/ verifyProperty name=upperfoo text=BAR/ The storeProperty task relies on the same BSFManager being used with all of its variables intack. Under the covers it is calling the eval() method in BSFManager. If you get around to making this change, I'll test out that this stuff still works. Cheers, Paul. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]