Ant Version

2013-12-09 Thread Andre-John Mas
Hi,

I recently made a code contribution and had the task get the version from the 
Main class. I appreciate this probably want the best approach and I am trying 
to consider options going forward. I had looked at the ant.version property, 
but the is only available in the project scope and also limited to the 'long' 
version. 

Some possibilities I am thinking of going forward:
 - Version class
 - AntRuntime class

Does anyone else have suggestions or preferences as to the best way going 
forward?

André-John

Sent from my phone. Envoyé depuis mon téléphone. 
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant Version

2013-12-09 Thread Matt Benson
Are you looking for compatibility with the version?  I.e., this task will
work on versions = n?  A commonly taken approach there is to use the
presence of some particular class introduced in the target version, rather
than fiddling with version numbers per se.

HTH,
Matt


On Mon, Dec 9, 2013 at 1:08 PM, Andre-John Mas andrejohn@gmail.comwrote:

 Hi,

 I recently made a code contribution and had the task get the version from
 the Main class. I appreciate this probably want the best approach and I am
 trying to consider options going forward. I had looked at the ant.version
 property, but the is only available in the project scope and also limited
 to the 'long' version.

 Some possibilities I am thinking of going forward:
  - Version class
  - AntRuntime class

 Does anyone else have suggestions or preferences as to the best way going
 forward?

 André-John

 Sent from my phone. Envoyé depuis mon téléphone.
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org




Re: Ant Version

2013-12-09 Thread Andre-John Mas
Hi,

This was the Get Task, whereby I was getting the ant version for use in the 
user-agent response. I am using the value uninterpreted. 

André-John

Sent from my phone. Envoyé depuis mon téléphone. 

 On Dec 9, 2013, at 14:23, Matt Benson gudnabr...@gmail.com wrote:
 
 Are you looking for compatibility with the version?  I.e., this task will
 work on versions = n?  A commonly taken approach there is to use the
 presence of some particular class introduced in the target version, rather
 than fiddling with version numbers per se.
 
 HTH,
 Matt
 
 
 On Mon, Dec 9, 2013 at 1:08 PM, Andre-John Mas andrejohn@gmail.comwrote:
 
 Hi,
 
 I recently made a code contribution and had the task get the version from
 the Main class. I appreciate this probably want the best approach and I am
 trying to consider options going forward. I had looked at the ant.version
 property, but the is only available in the project scope and also limited
 to the 'long' version.
 
 Some possibilities I am thinking of going forward:
 - Version class
 - AntRuntime class
 
 Does anyone else have suggestions or preferences as to the best way going
 forward?
 
 André-John
 
 Sent from my phone. Envoyé depuis mon téléphone.
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 
 

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant Version

2013-12-09 Thread Matt Benson
Looks like Main.getAntVersion() is your friend.

Matt


On Mon, Dec 9, 2013 at 2:50 PM, Andre-John Mas andrejohn@gmail.comwrote:

 Hi,

 This was the Get Task, whereby I was getting the ant version for use in
 the user-agent response. I am using the value uninterpreted.

 André-John

 Sent from my phone. Envoyé depuis mon téléphone.

  On Dec 9, 2013, at 14:23, Matt Benson gudnabr...@gmail.com wrote:
 
  Are you looking for compatibility with the version?  I.e., this task will
  work on versions = n?  A commonly taken approach there is to use the
  presence of some particular class introduced in the target version,
 rather
  than fiddling with version numbers per se.
 
  HTH,
  Matt
 
 
  On Mon, Dec 9, 2013 at 1:08 PM, Andre-John Mas andrejohn@gmail.com
 wrote:
 
  Hi,
 
  I recently made a code contribution and had the task get the version
 from
  the Main class. I appreciate this probably want the best approach and I
 am
  trying to consider options going forward. I had looked at the
 ant.version
  property, but the is only available in the project scope and also
 limited
  to the 'long' version.
 
  Some possibilities I am thinking of going forward:
  - Version class
  - AntRuntime class
 
  Does anyone else have suggestions or preferences as to the best way
 going
  forward?
 
  André-John
 
  Sent from my phone. Envoyé depuis mon téléphone.
  -
  To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
  For additional commands, e-mail: dev-h...@ant.apache.org
 
 

 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org




Re: Ant Version

2013-12-09 Thread Andre-John Mas
It is what I used and how the patch was accepted, but since I was told it 
wasn't ideal I wanted to see if there were ways to deal with this going 
forward. 

André-John

Sent from my phone. Envoyé depuis mon téléphone. 

 On Dec 9, 2013, at 15:56, Matt Benson gudnabr...@gmail.com wrote:
 
 Looks like Main.getAntVersion() is your friend.
 
 Matt
 
 
 On Mon, Dec 9, 2013 at 2:50 PM, Andre-John Mas andrejohn@gmail.comwrote:
 
 Hi,
 
 This was the Get Task, whereby I was getting the ant version for use in
 the user-agent response. I am using the value uninterpreted.
 
 André-John
 
 Sent from my phone. Envoyé depuis mon téléphone.
 
 On Dec 9, 2013, at 14:23, Matt Benson gudnabr...@gmail.com wrote:
 
 Are you looking for compatibility with the version?  I.e., this task will
 work on versions = n?  A commonly taken approach there is to use the
 presence of some particular class introduced in the target version,
 rather
 than fiddling with version numbers per se.
 
 HTH,
 Matt
 
 
 On Mon, Dec 9, 2013 at 1:08 PM, Andre-John Mas andrejohn@gmail.com
 wrote:
 
 Hi,
 
 I recently made a code contribution and had the task get the version
 from
 the Main class. I appreciate this probably want the best approach and I
 am
 trying to consider options going forward. I had looked at the
 ant.version
 property, but the is only available in the project scope and also
 limited
 to the 'long' version.
 
 Some possibilities I am thinking of going forward:
 - Version class
 - AntRuntime class
 
 Does anyone else have suggestions or preferences as to the best way
 going
 forward?
 
 André-John
 
 Sent from my phone. Envoyé depuis mon téléphone.
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 
 

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant Version

2013-12-09 Thread Matt Benson
Do you have a link to that discussion?  I'd be interested to catch up the
context here.

Thanks,
Matt


On Mon, Dec 9, 2013 at 3:01 PM, Andre-John Mas andrejohn@gmail.comwrote:

 It is what I used and how the patch was accepted, but since I was told it
 wasn't ideal I wanted to see if there were ways to deal with this going
 forward.

 André-John

 Sent from my phone. Envoyé depuis mon téléphone.

  On Dec 9, 2013, at 15:56, Matt Benson gudnabr...@gmail.com wrote:
 
  Looks like Main.getAntVersion() is your friend.
 
  Matt
 
 
  On Mon, Dec 9, 2013 at 2:50 PM, Andre-John Mas andrejohn@gmail.com
 wrote:
 
  Hi,
 
  This was the Get Task, whereby I was getting the ant version for use in
  the user-agent response. I am using the value uninterpreted.
 
  André-John
 
  Sent from my phone. Envoyé depuis mon téléphone.
 
  On Dec 9, 2013, at 14:23, Matt Benson gudnabr...@gmail.com wrote:
 
  Are you looking for compatibility with the version?  I.e., this task
 will
  work on versions = n?  A commonly taken approach there is to use the
  presence of some particular class introduced in the target version,
  rather
  than fiddling with version numbers per se.
 
  HTH,
  Matt
 
 
  On Mon, Dec 9, 2013 at 1:08 PM, Andre-John Mas 
 andrejohn@gmail.com
  wrote:
 
  Hi,
 
  I recently made a code contribution and had the task get the version
  from
  the Main class. I appreciate this probably want the best approach and
 I
  am
  trying to consider options going forward. I had looked at the
  ant.version
  property, but the is only available in the project scope and also
  limited
  to the 'long' version.
 
  Some possibilities I am thinking of going forward:
  - Version class
  - AntRuntime class
 
  Does anyone else have suggestions or preferences as to the best way
  going
  forward?
 
  André-John
 
  Sent from my phone. Envoyé depuis mon téléphone.
  -
  To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
  For additional commands, e-mail: dev-h...@ant.apache.org
 
  -
  To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
  For additional commands, e-mail: dev-h...@ant.apache.org
 
 

 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org




Re: Ant Version

2013-12-09 Thread Andre-John Mas
Covered in this ticket:

https://issues.apache.org/bugzilla/show_bug.cgi?id=55489

On 9-Dec-2013, at 17:00, Matt Benson wrote:

 Do you have a link to that discussion?  I'd be interested to catch up the
 context here.
 
 Thanks,
 Matt
 
 
 On Mon, Dec 9, 2013 at 3:01 PM, Andre-John Mas andrejohn@gmail.comwrote:
 
 It is what I used and how the patch was accepted, but since I was told it
 wasn't ideal I wanted to see if there were ways to deal with this going
 forward.
 
 André-John
 
 Sent from my phone. Envoyé depuis mon téléphone.
 
 On Dec 9, 2013, at 15:56, Matt Benson gudnabr...@gmail.com wrote:
 
 Looks like Main.getAntVersion() is your friend.
 
 Matt
 
 
 On Mon, Dec 9, 2013 at 2:50 PM, Andre-John Mas andrejohn@gmail.com
 wrote:
 
 Hi,
 
 This was the Get Task, whereby I was getting the ant version for use in
 the user-agent response. I am using the value uninterpreted.
 
 André-John
 
 Sent from my phone. Envoyé depuis mon téléphone.
 
 On Dec 9, 2013, at 14:23, Matt Benson gudnabr...@gmail.com wrote:
 
 Are you looking for compatibility with the version?  I.e., this task
 will
 work on versions = n?  A commonly taken approach there is to use the
 presence of some particular class introduced in the target version,
 rather
 than fiddling with version numbers per se.
 
 HTH,
 Matt
 
 
 On Mon, Dec 9, 2013 at 1:08 PM, Andre-John Mas 
 andrejohn@gmail.com
 wrote:
 
 Hi,
 
 I recently made a code contribution and had the task get the version
 from
 the Main class. I appreciate this probably want the best approach and
 I
 am
 trying to consider options going forward. I had looked at the
 ant.version
 property, but the is only available in the project scope and also
 limited
 to the 'long' version.
 
 Some possibilities I am thinking of going forward:
 - Version class
 - AntRuntime class
 
 Does anyone else have suggestions or preferences as to the best way
 going
 forward?
 
 André-John
 
 Sent from my phone. Envoyé depuis mon téléphone.
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant Version

2013-12-09 Thread Stefan Bodewig
On 2013-12-09, Andre-John Mas wrote:

 It is what I used and how the patch was accepted, but since I was told
 it wasn't ideal I wanted to see if there were ways to deal with this
 going forward.

It was me who said it wasn't ideal.  My concern is IDE integration which
might start Ant differently and bypass Main so the static methods on
Main don't work properly.

Andre-John's contribution made me look at the implementation again and
since the methods are static and only rely on ther version.txt file
being present, I no longer see a problem.  An implementation outside of
Main wouldn't look any different and I highly doubt an IDE integration
would remove the Main class completely.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org