[GitHub] ant issue #57: Make junitreport with Saxon
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/57 Looks good, thanks @adamretter I don't think the WiX configuration really is current as we don't use it - it used to be an experiment many years ago that we never completed. Updating it won't hurt, though. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/62#discussion_r167136873
--- Diff:
src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java ---
@@ -91,6 +91,9 @@ protected ResolvedResource
findResourceUsingPatterns(ModuleRevisionId moduleRevi
Set foundRevisions = new HashSet<>();
boolean dynamic =
getSettings().getVersionMatcher().isDynamic(moduleRevision);
for (String pattern : patternList) {
+if (Thread.currentThread().isInterrupted()) {
+return null;
--- End diff --
@apupier I originally intended it to be `InterruptedException` but given
that it's a checked exception you would end up changing the method signature of
this method which then causes issues with callers of this API. Hence I
suggested a runtime exception. Returning null could have other (side) effects
than what you intend here - i.e. to abort the execution, so throwing the
exception would be the right thing.
I might have some time tonight, I'll see if this check can be moved to a
better location or handle in a better way.
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #68: Why no new Ivy version yet?
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/68 There will be one soon. There's a discussion going on, in the mailing list to work towards a release soon. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #68: Why no new Ivy version yet?
GitHub user chinhodado opened a pull request: https://github.com/apache/ant-ivy/pull/68 Why no new Ivy version yet? I'm just making this PR because the mailing list is a pain to use and there's no issue tracker here on GitHub for the project...but why isn't there a new release for Ivy yet, given the project has resumed development for so long now? You can merge this pull request into a Git repository by running: $ git pull https://github.com/chinhodado/ant-ivy patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/68.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #68 commit ea69b704b77d0321cfc19f85bab3c9627040b9f3 Author: Trung Do Date: 2018-02-09T04:02:16Z Why no new version yet --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #66: IVY-1545 Detect circular dependencies in POMs
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/66 @javabrett, thank you reporting as well as providing the fix for this. This is now merged. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #66: IVY-1545 Detect circular dependencies in POMs
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/66 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #57: Make junitreport with Saxon
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/57 Looks good to me. If @bodewig doesn't have any concerns with this change, I'll go ahead and merge this, this week. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #57: Make junitreport with Saxon
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/57 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/33/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #57: Make junitreport with Saxon
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/57 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/39/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #59: Fix NPE in ChainedMapper.
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/59 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #59: Fix NPE in ChainedMapper.
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/59 Thanks for the PR @jpountz. Can we add you to our contributors file, crediting you for this fix? If yes, what would you like your name to be mentioned as? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #59: Fix NPE in ChainedMapper.
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/59 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/32/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #59: Fix NPE in ChainedMapper.
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/59 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/38/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #59: Fix NPE in ChainedMapper.
GitHub user jpountz opened a pull request: https://github.com/apache/ant/pull/59 Fix NPE in ChainedMapper. This NPE happens whenever any of the sub mappers returns `null`, which may happen eg. with `GlobPatternMapper`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpountz/ant fix/chained_mapper_npe Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit e777ee85a5c077949c81e23c359cf857dd13ca83 Author: Adrien Grand Date: 2018-02-08T14:22:02Z Fix NPE in ChainedMapper. This NPE happens whenever any of the sub mappers returns `null`, which may happen eg. with `GlobPatternMapper`. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: github PR builds
On 06/02/18 10:10 PM, Stefan Bodewig wrote: On 2018-02-06, Jaikiran Pai wrote: The PR build on Jenkins is backed by the github PR integration plugin[1]. One of the features of that plugin is to prevent some malicious/rogue PR (imagine someone creating a PR with code which does some odd things with the host on which it runs) being auto-triggered against the Jenkins hosts. I see. It's just that I never saw this in use before - and to be honest am a bit annoyed by the bot asking for confirmation on every pull request :-) If it continues to be annoying, please do let me know and I'll disable this feature on that job. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Ivy-2.5.0
I think it's time to start moving this release process further. My work
on IVY-1485 isn't complete nor is it in a state where I'm confident that
it won't break/regress other things. So I think it's safe to move it out
of this release and try and get it into some next release. We have a
good amount of bug fixes that have been done since 2.4.0 and I think we
should start looking at what it takes to do the release formalities.
-Jaikiran
On 09/01/18 12:29 PM, Jaikiran Pai wrote:
Hi Jan,
My efforts to resolve IVY-1485 have taken longer than I expected,
mainly due to not finding enough time to sort it out. A few weekends I
tried to focus on this, with my local WIP changes, I ran into merge
issues with the latest upstream changes. I resolved them then and
continued with the WIP changes. But a few weeks down the line I ran
into the merge conflicts again. I haven't yet been able to find time
to resolve them locally and spend time on the real fix (I do admit
that I lost a bit of focus/interest with the merges).
I'll try again this weekend and see how far I can get this working.
Either way, I don't want to block the release anymore. If I can't get
IVY-1485 solved by this weekend, I propose to have it marked as a
known issue for this release and I will try and get it out in the next
release after that.
As you note, we do have good number of fixes in this release and it's
time that we have them available to the general public.
-Jaikiran
On 08/01/18 8:18 PM, Jan Matèrne (jhm) wrote:
I took my old TODO list for Ivy-2.5.0.
Most of them are still open, how to deal with that?
In my opinion we should try to get a release out and postpone these to a
2.5.1 (means reducing stopper->later).
We have lots of changes we could deliver in this way. We also show a
sign of
life in that way.
Jan
- https://issues.apache.org/jira/browse/IVY-1485
Incorrect revision of dependencies put in to delivered Ivy files
Status:
11.09.2017: Jaikiran wanted to focus on that
prio: stopper ("but it was IVY-1485 which reanimated the community")
- SVG-graphics
Status:
08.01.2018: unknown
prio: should be included, as it seems to be nearly finished (for me)
- https://github.com/apache/ant-ivy/pull/60
use Unicode glyphs or SVG data URLs instead of bitmaps
Status:
11.09.2017: review required
08.01.2018: not sure what to do or what impact this have
prio: should be included (as part of the "svg-bulk")
- https://github.com/apache/ant-ivy/pull/57
fix the last inconsistencies in generics
Status:
11.09.2017: This includes a change which breaks BC
08.01.2018: no consense on the API change
prio: solve that or delay (this PR should not delay the new
version in my
opinion)
- https://github.com/apache/ant-ivy/pull/55
use the vectorised logo
Status:
11.09.2017: nearly finished (missing header)
08.01.2018: no changes (license header missing)
prio: include that as is nearly finished
- https://issues.apache.org/jira/browse/IVY-1420
defaultconfmapping on element is not written to
delivered ivy file
Status:
11.09.2017: "I need about a week"
08.01.2018: done (27.09.2017)
prio: should be included
- upgrading BouncyCastle
Status: done
- IVY-1420/IVY-1437, defaultconf/defaultconfmapping/confmappingoverride
attributes
"according to ivy.xsd, all three attributes can be used on both
dependencies and configurations.
So, it's the documentation that must be adjusted accordingly"
Status:
11.09.2017: open
08.01.2018: done
prio: maybe delay (and open a Jira ticket)
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Apache EU Roadshow in Berlin 13-14 June
Hi all I'm not sure whether you've seen the announcement of an Apache community happening this summer at the same time and place as FOSS Backstage https://blogs.apache.org/foundation/entry/the-apache-software-foundation-announces28 The CfP for this is still open http://apachecon.com/euroadshow18/ as well as the one for FOSS Backstage https://foss-backstage.de/call-papers Cheers Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
