Re: JDK 12 enters Rampdown Phase Two

2019-02-18 Thread Jaikiran Pai
Hi Dalibor,

It took me a while to get back to this, but I just gave this a try.
Jacoco has released 0.8.3 version with this fix to support Java 13 and I
gave it a try against the original project which was running into this
issue. I can now confirm that this now works fine with Jacoco 0.8.3 and
Java 13 (even the latest EA 8 build).

-Jaikiran

On 23/01/19 7:00 PM, Jaikiran Pai wrote:
> Hi Dalibor,
>
> On 23/01/19 2:51 PM, Dalibor Topic wrote:
>>
>> On 23.01.2019 08:56, Jaikiran Pai wrote:
>>> Our Ant testsuite against this EA version of JDK 13 has passed fine on
>>> Linux. However, one of our other projects within the Ant umbrella has
>>> shown an issue with the Jacoco library usage (which internally uses ASM
>>> library). Narrowing this down to a simple standalone Java program has
>>> shown that this version of Java isn't compatible with ASM 7.0. It runs
>>> into:
>>>
>>>
>>> java.lang.IllegalArgumentException: Unsupported class file major
>>> version 57
>>>  at org.objectweb.asm.ClassReader.(ClassReader.java:184)
>>>  at org.objectweb.asm.ClassReader.(ClassReader.java:166)
>>>  at org.objectweb.asm.ClassReader.(ClassReader.java:152)
>>>
>>>
>>> while trying to instrument a class compiled with that JDK 13 EA build. I
>>> haven't yet had a chance to see if there's a newer version of ASM which
>>> works against this version, but my quick checks haven't shown any newer
>>> versions.
>> Hi Jaikiran,
>>
>> the changes for experimental support of JDK 13 bytecode have just gone
>> into jacoco, per https://github.com/jacoco/jacoco/pull/835 .
>>
> Thank you for pointing me to that commit, I'll give that snapshot
> version a try against our project and see how it goes, over the next few
> days.
>
> -Jaikiran

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: JDK 12: First Release Candidate available

2019-02-18 Thread Jaikiran Pai
Hello Rory,

Our testsuite, of the master branch of Ant, has come up clean for both
the JDK 12 build 32[1] and JDK 13 build EA 8[2]. These initial test runs
are only against Linux setup and one of these days I'll run these tests
against Windows as well. In the next few days, I'll run some of our
other Ant projects with these JDK builds (especially JDK 12) to make
sure they are fine too.

[1]
https://builds.apache.org/job/Ant%20Master%20(latest%20EA%20JDK)/5/jdk_axis=jdk12-ea,label_exp=ubuntu/

[2]
https://builds.apache.org/job/Ant%20Master%20(latest%20EA%20JDK)/5/jdk_axis=jdk13-ea,label_exp=ubuntu/

-Jaikiran

On 18/02/19 4:55 PM, Rory O'Donnell wrote:
>   Hi Stefan/Jaikiran,
>
> **OpenJDK builds *- JDK 12 Early Access build 32 **is now available
> **at : - jdk.java.net/12/*
> **JDK 12:  First Release Candidate [1]**
>
>  * Per the JDK 12 schedule [2], we are now in Release Candidate Phase.
>  * The stabilization repository, jdk/jdk12, is open for P1 bug fixes
>    per the JDK Release Process (JEP 3) [3].
>  * All changes require approval via the Fix-Request Process [4].
>  *
>    Release note additions since last email
>
>  o
>    Build 31 - can_pop_frame and can_force_early_return capabilities
>    are disabled if JVMCI compiler is used (JDK-8218025
>    ) The JVMTI
>    |can_pop_frame| and |can_force_early_return| capabilities are
>    disabled if a JVMCI compiler (like Graal) is used. As a result
>    the corresponding functionality (|PopFrame| and
>    |ForceEarlyReturnXXX| functions) is not available to JVMTI
>    agents. This issue is being fixed via JDK-8218885
>    
>    [https://bugs.openjdk.java.net/browse/JDK-8218885
>    ].
>
>  o Build 28: JDK-8212233
>     : javadoc
>    fails on jdk12 with "The code being documented uses modules but
>    the packages defined in $URL are in the unnamed module."
>  * Changes in this build.
>   
> 
>
> **OpenJDK builds *- JDK 13 Early Access build 8 is **now available
> **at : - jdk.java.net/13/*
>
>  * These early-access, open-source builds are provided under the
>  o GNU General Public License, version 2, with the Classpath
>    Exception .
>  * Release Notes updates
>  * Build 8
>  o GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds()
>    are unified across the platforms (JDK-8214918
>    )
>  o The experimental FIPS 140 compliant mode has been removed from
>    the SunJSSE provider. (JDK-8217835
>    )
>  * Build 7
>  o Change DOM parser to not resolve EntityReference and add Text
>    node with
>    DocumentBuilderFactory.setExpandEntityReferences(false)
>    (JDK-8206132 )
>  * Build 6
>  o Base64.Encoder and Base64.Decoder methods can throw
>    OutOfMemoryError (JDK-8210583
>    )
>  * Changes in this build
>   
> 
>  * FOSS Bugs fixed in recent builds
>  o Build 6 : JDK-8216970
>     : condy
>    causes JVM crash
>  o Build 7: JDK-8215577
>     : Remove
>    javadoc support for HTML 4
>
>
> Rgds,Rory
>
> [1]
> https://mail.openjdk.java.net/pipermail/jdk-dev/2019-February/002623.html
> [2] http://openjdk.java.net/projects/jdk/12/#Schedule
> [3] http://openjdk.java.net/jeps/3
> [4] http://openjdk.java.net/jeps/3#Fix-Request-Process
>

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: How to commit?

2019-02-18 Thread Jaikiran Pai
Hi Craig,

Commits to the repository are only allowed for committers of the
project. For contributing patches (like this one), you can use the
github pull request process. Once reviewed, the merge will then be done
by one of the existing project committers and the contribution will be
credited to you.

-Jaikiran

On 19/02/19 3:04 AM, Craig Pell wrote:
> I have written a working solution for
>  and
> , the requests
> for the  task to support modular attributes.  My code modifies
> module-info.class directly in the .jar file.  (It actually wasn’t as
> hard as I was expecting it to be.)
>
> I would love to submit the changes, but I’m not clear on how to do it
> using gitbox.  I can clone the codebase easily enough, but I don’t
> know how to get an account there in order to submit changes.
>
> I figured I could just follow the instructions at
> , but that requires logging into
> , which in turn requires an Apache user ID,
> which I don’t seem to have.  When I submitted an ICLA a few months
> ago, I didn’t specify a desired user ID.  I’m now thinking I should
> have, but I’m not sure how to rectify the situation.
>
> From what I’ve been reading, it appears it’s still possible to use
> GitHub, but I’m not certain.  And even if it is possible and
> permissible, I’m not sure whether I should do that, or if I should be
> using gitbox as much as possible now.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



How to commit?

2019-02-18 Thread Craig Pell
I have written a working solution for 
 and 
, the requests for 
the  task to support modular attributes.  My code modifies 
module-info.class directly in the .jar file.  (It actually wasn’t as 
hard as I was expecting it to be.)


I would love to submit the changes, but I’m not clear on how to do it 
using gitbox.  I can clone the codebase easily enough, but I don’t know 
how to get an account there in order to submit changes.


I figured I could just follow the instructions at 
, but that requires logging into 
, which in turn requires an Apache user ID, which 
I don’t seem to have.  When I submitted an ICLA a few months ago, I 
didn’t specify a desired user ID.  I’m now thinking I should have, but 
I’m not sure how to rectify the situation.


From what I’ve been reading, it appears it’s still possible to use 
GitHub, but I’m not certain.  And even if it is possible and 
permissible, I’m not sure whether I should do that, or if I should be 
using gitbox as much as possible now.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



JDK 12: First Release Candidate available

2019-02-18 Thread Rory O'Donnell

  Hi Stefan/Jaikiran,

**OpenJDK builds *- JDK 12 Early Access build 32 **is now available **at 
: - jdk.java.net/12/*

**JDK 12:  First Release Candidate [1]**

 * Per the JDK 12 schedule [2], we are now in Release Candidate Phase.
 * The stabilization repository, jdk/jdk12, is open for P1 bug fixes
   per the JDK Release Process (JEP 3) [3].
 * All changes require approval via the Fix-Request Process [4].
 *
   Release note additions since last email

 o
   Build 31 - can_pop_frame and can_force_early_return capabilities
   are disabled if JVMCI compiler is used (JDK-8218025
   ) The JVMTI
   |can_pop_frame| and |can_force_early_return| capabilities are
   disabled if a JVMCI compiler (like Graal) is used. As a result
   the corresponding functionality (|PopFrame| and
   |ForceEarlyReturnXXX| functions) is not available to JVMTI
   agents. This issue is being fixed via JDK-8218885
   
   [https://bugs.openjdk.java.net/browse/JDK-8218885
   ].

 o Build 28: JDK-8212233
    : javadoc
   fails on jdk12 with "The code being documented uses modules but
   the packages defined in $URL are in the unnamed module."
 * Changes in this build.
   


**OpenJDK builds *- JDK 13 Early Access build 8 is **now available **at 
: - jdk.java.net/13/*


 * These early-access, open-source builds are provided under the
 o GNU General Public License, version 2, with the Classpath
   Exception .
 * Release Notes updates
 * Build 8
 o GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds()
   are unified across the platforms (JDK-8214918
   )
 o The experimental FIPS 140 compliant mode has been removed from
   the SunJSSE provider. (JDK-8217835
   )
 * Build 7
 o Change DOM parser to not resolve EntityReference and add Text
   node with
   DocumentBuilderFactory.setExpandEntityReferences(false)
   (JDK-8206132 )
 * Build 6
 o Base64.Encoder and Base64.Decoder methods can throw
   OutOfMemoryError (JDK-8210583
   )
 * Changes in this build
   

 * FOSS Bugs fixed in recent builds
 o Build 6 : JDK-8216970
    : condy
   causes JVM crash
 o Build 7: JDK-8215577
    : Remove
   javadoc support for HTML 4


Rgds,Rory

[1] 
https://mail.openjdk.java.net/pipermail/jdk-dev/2019-February/002623.html

[2] http://openjdk.java.net/projects/jdk/12/#Schedule
[3] http://openjdk.java.net/jeps/3
[4] http://openjdk.java.net/jeps/3#Fix-Request-Process

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland