[GitHub] ant-ivy pull request: Add feature for PomModuleDescriptorParser di...
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/6#issuecomment-136152918 I have implemented it with two properties, ivy.maven.sources.lookup and ivy.maven.javadoc.lookup, which defaults to true Thanks for the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: Add feature for PomModuleDescriptorParser di...
Github user jsuereth commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/6#discussion_r37987168
--- Diff:
src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParser.java ---
@@ -306,6 +306,15 @@ private void
addSourcesAndJavadocArtifactsIfPresent(PomModuleDescriptorBuilder m
// no main artifact in pom, we don't need to search for meta
artifacts
return;
}
+
+final boolean disabledForSourcesAndJavadoc =
"true".equals(ivySettings.substitute("${disabledForSourcesAndJavadoc}"));
--- End diff --
In pedantic mode, can we call this "disableMavenAutoSourcesAndJavadoc"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: Add feature for PomModuleDescriptorParser di...
Github user jsuereth commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/6#discussion_r37987042
--- Diff:
src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParser.java ---
@@ -306,6 +306,15 @@ private void
addSourcesAndJavadocArtifactsIfPresent(PomModuleDescriptorBuilder m
// no main artifact in pom, we don't need to search for meta
artifacts
return;
}
+
+final boolean disabledForSourcesAndJavadoc =
"true".equals(ivySettings.substitute("${disabledForSourcesAndJavadoc}"));
--- End diff --
This looks great. We should be able to set this in ivysettings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: Add feature for PomModuleDescriptorParser di...
Github user jsuereth commented on the pull request: https://github.com/apache/ant-ivy/pull/6#issuecomment-135037966 One naming comment, then LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
