[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/8 IVY-1522 Windows OS file path resolution fix The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1522. This commit includes a new test method to verify this fix. My local testing with these changes hasn't shown any regressions. However, I don't have a Windows OS to test this on and my testing has been on a *nix OS. The test included in this commit needs to be run against a Windows OS to ascertain that the fix indeed fixes the issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant-ivy IVY-1522 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/8.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8 commit adb9b664d0af140db454c888ce570645bfedc528 Author: Jaikiran Pai jaikiran@gmail.com Date: 2015-08-04T16:17:36Z IVY-1522 Windows OS file path resolution fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/pull/8#issuecomment-136174686 Thanks for testing this. I'll see if I can borrow a Windows OS to come up with a proper fix and test for this. Closing this for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/8#issuecomment-136174610 It seems to break badly Ivy on Windows. I tried to launch the test with a fresh checkout of your PR, and Ivy could not even resolve dependencies. Here are the logs: ``` BUILD FAILED C:\Users\nlalevee\dev\ivy\git\build.xml:184: impossible to resolve dependencies: java.io.FileNotFoundException: \:\Users\nlalevee\.ivy2\cache\resolved-org.apache.ivy-ivy-work...@hibpro7.xml (La syntaxe du nom de fichier, de râpertoire ou de volume est incorrecte) at java.io.FileOutputStream.open0(Native Method) at java.io.FileOutputStream.open(FileOutputStream.java:270) at java.io.FileOutputStream.init(FileOutputStream.java:213) at java.io.FileOutputStream.init(FileOutputStream.java:162) at org.apache.ivy.plugins.parser.xml.XmlModuleDescriptorUpdater.update(XmlModuleDescriptorUpdater.java:135) at org.apache.ivy.plugins.parser.xml.XmlModuleDescriptorParser.toIvyFile(XmlModuleDescriptorParser.java:160) at org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor.toIvyFile(DefaultModuleDescriptor.java:552) at org.apache.ivy.core.cache.DefaultResolutionCacheManager.saveResolvedModuleDescriptor(DefaultResolutionCacheManager.java:176) at org.apache.ivy.core.resolve.ResolveEngine.resolve(ResolveEngine.java:243) at org.apache.ivy.core.resolve.ResolveEngine.resolve(ResolveEngine.java:195) at org.apache.ivy.Ivy.resolve(Ivy.java:509) at org.apache.ivy.ant.IvyResolve.doExecute(IvyResolve.java:325) at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272) at org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:228) at org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179) at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88) at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:435) at org.apache.tools.ant.Target.performTasks(Target.java:456) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405) at org.apache.tools.ant.Project.executeTarget(Project.java:1376) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1260) at org.apache.tools.ant.Main.runBuild(Main.java:853) at org.apache.tools.ant.Main.startAnt(Main.java:235) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:285) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:112) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
