DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|--- |1.7 --- Additional Comments From [EMAIL PROTECTED] 2005-05-23 22:06 --- By popular demand, the clone task has been removed. The recommended solution for this problem will be ResourceCollections, just added to CVS HEAD. Right now the only tasks specifically fitted to ResourceCollections are concat, pathconvert, the new length, and the newer resourcecount. However, tasks that accept paths should be able to use filesystem-only resource collections OOTB. Feel welcome to submit patches for ResourceCollection support to any other task. Thanks, Matt -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
On Mon, 10 Jan 2005, Matt Benson [EMAIL PROTECTED] wrote: --- Stefan Bodewig [EMAIL PROTECTED] wrote: could you guys please come over to [EMAIL PROTECTED] again? 8-) I'm here. Oh, I know. It's just that I'm trying to catch up with my vacation backlog and find it very hard to follow discussions in bugzilla - or any web based non-structured forum for that matter. It happened in at least one other bug report as well. So... fire away. :) Will do in a separate thread. Cheers Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 --- Additional Comments From [EMAIL PROTECTED] 2005-01-10 15:29 --- I don't know about others, but I find this clone task strange at the very least, and not necessarily desirable. The name's obviously confusing, but even the functionality's strange (to me). Is this something we really want in Ant? -- DD -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 --- Additional Comments From [EMAIL PROTECTED] 2005-01-10 16:30 --- It is weird, isn't it? I was wondering what kind of controversy it might generate, but on the overall it's such a small bit of code that it seems quite harmless to me. Do you suggest a different name, cloneobject perhaps? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 --- Additional Comments From [EMAIL PROTECTED] 2005-01-10 16:41 --- I don't have a better name, and don't like the feature so far. I'll leave it at that if I'm the only one who doesn't like it, but otherwise my personal opinion is that although the use case has some merit, I don't think we should address it this way (or at all). I'd be more inclined if anything to allow nested filesets in a dir-less fileset (with the additional constraint that all nested filesets should have the same dir) than to have a generic clone. The use case would then be: fileset fileset refid=webapp / include name=WEB-INF/ / fileset --DD -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 --- Additional Comments From [EMAIL PROTECTED] 2005-01-10 17:07 --- Is a dedicated clone task really the correct approach? Shouldn't we solve it in the type's domain. For example: fileset id=webapp !-- ... -- /fileset fileset id=webapp-webinf-only extends=webapp includes=WEB-INF/**/ The meaning of extends is: all attributes, that are not overridden locally, default to those of the supertype. likewise all nested elements, specified locally, supplement those of the supertype. Holger -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
--- Stefan Bodewig [EMAIL PROTECTED] wrote: On Mon, 10 Jan 2005, [EMAIL PROTECTED] wrote: I don't have a better name, and don't like the feature so far. FWIW I tend to agree with DD, but don't want to continue the discussion in bugzilla - could you guys please come over to [EMAIL PROTECTED] again? 8-) I'm here. Basically the clone task is a minimally functional extension to UnknownElement. I added a little bit of code to UnknownElement and RuntimeConfigurable to make it easier to add the level of indirection using a UE subclass. Clone just puts it to use. So... fire away. :) -Matt __ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
Matt Benson wrote: --- Stefan Bodewig [EMAIL PROTECTED] wrote: On Mon, 10 Jan 2005, [EMAIL PROTECTED] wrote: I don't have a better name, and don't like the feature so far. FWIW I tend to agree with DD, but don't want to continue the discussion in bugzilla - could you guys please come over to [EMAIL PROTECTED] again? 8-) I'm here. Basically the clone task is a minimally functional extension to UnknownElement. I added a little bit of code to UnknownElement and RuntimeConfigurable to make it easier to add the level of indirection using a UE subclass. Clone just puts it to use. So... fire away. :) I do feel a bit quesy about using a sub-task of UnknownElement as a task. There is a lot of magic going on with UEs and RCs. Peter -Matt __ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
--- Peter Reilly [EMAIL PROTECTED] wrote: Matt Benson wrote: [SNIP] I'm here. Basically the clone task is a minimally functional extension to UnknownElement. I added a little bit of code to UnknownElement and RuntimeConfigurable to make it easier to add the level of indirection using a UE subclass. Clone just puts it to use. So... fire away. :) I do feel a bit quesy about using a sub-task of UnknownElement as a task. There is a lot of magic going on with UEs and RCs. Next question on that subject... I had thought of retroactively causing UE.makeObject() satisfy the contract of some new interface and having Clone also implement that interface. Same result, slightly more structured design. Does that affect your feelings on the subject, Peter? -Matt __ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-01-07 22:58 --- I have just added a clone task to CVS HEAD. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |enhancement -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 --- Additional Comments From [EMAIL PROTECTED] 2004-12-13 08:45 --- (In reply to comment #3) the future it might be possible to provide such a task to obtain a cloned fileset instance (possibly of any Cloneable object). Yes, that's the proper solution. Is this enhancement already planned / scheduled. I can't find the related issue. Thanks!! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 --- Additional Comments From [EMAIL PROTECTED] 2004-12-13 18:22 --- I will look into this. We should be able to come up with something at least for fileset, if not for all Cloneables. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 --- Additional Comments From [EMAIL PROTECTED] 2004-12-10 14:06 --- The attributes includes and excludes are - simply spoken - an easier way for defining the include/exclude selectors. fileset dir=. includes=WEB-INF// is the same as fileset dir=. include name=WEB-INF// /fileset Adding these two attributes together with refid would result in the question why not using all the other selectors too. That would result in a completely different meaning. refid refers to an existing ProjectComponent (not only filesets) as it was defined earlier. You want to use that as a template for defining new. But you can solve your need: fileset id=webapp.only ... includes=WEB-INF// fileset id=webapp.rest ... excludes=WEB-INF// Then uses both references. copy|javac|... fileset refid=webapp.only/ fileset refid=webapp.rest/ / -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 --- Additional Comments From [EMAIL PROTECTED] 2004-12-10 14:16 --- .. then allow all selectors. With http://antifact.sf.net you can import filesets from other modules. Every module exports its artifacts as filesets with ids. If you import filesets (artifacts) from other modules / build files, you don't define the filesets yourself. They are defined by someone else. You can only use them as they are. Then it would be handy, if you could refine the using my proposed construct. This extensions is IMHO much better than nested filesets or sets of filesets as described in other feature requests. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32631] - allow includes / excludes for fileset references
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32631. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32631 --- Additional Comments From [EMAIL PROTECTED] 2004-12-10 17:07 --- That's just not what id/refid DO. refid is a link to a previously defined object. A significant amount of code in Ant serves the purpose of enforcing the principle that to define any other attribute in conjunction with refid is an error, not only on filesets but most if not all tasks and types. The normal way to do this is by defining the patternsets and selectors that make your fileset what it is and mix and match these by refid into different filesets. Another possible means of defining a fileset for later refinement might involve the presetdef task. These are the options open to you today. If you have no control over the template filesets the only solution I see is a custom task. In the future it might be possible to provide such a task to obtain a cloned fileset instance (possibly of any Cloneable object). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
