Re: Possibly issue with Any23 2.2 RC 1

[Hans Brende]

I upgraded you to commons-csv version 1.5. Hope that helps. Impatiently
awaiting the 2.2 release, lol.

https://github.com/apache/any23/pull/63

On Thu, Feb 8, 2018 at 2:42 PM, Peter Ansell  wrote:

> Alternatively, we could look into the possibility of reusing jackson
> csv that we are already inheriting through RDF4J.
>
> Cheers,
>
> Peter
>
> On 9 February 2018 at 05:29, lewis john mcgibbney 
> wrote:
> > Hi Folks,
> > There 'may' be an issue with us using our project-hosted SNAPSHOT version
> > of comons-csv [0]. This stems from the fact that the commons-csv source
> has
> > not been officially released, but that we are using it as if it has been!
> > I have taken this query to a larger audience over on dev@community, I
> will
> > crosspost feedback here.
> > Thanks Andy for bringing this up, and thank you to anyone else able to
> > review the release candidate.
> > Lewis
> >
> > [0] https://github.com/apache/any23/blob/master/pom.xml#L603-L606
> > [1] https://s.apache.org/gOjG
> >
> > --
> > http://home.apache.org/~lewismc/
> > http://people.apache.org/keys/committer/lewismc
>

[jira] [Commented] (ANY23-264) Upgrade to use public commons-csv instead of custom SNAPSHOT

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ANY23-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357970#comment-16357970
 ] 

ASF GitHub Bot commented on ANY23-264:
--

GitHub user HansBrende opened a pull request:

https://github.com/apache/any23/pull/63

ANY23-264 Upgrade to use public commons-csv instead of custom SNAPSHOT

I upgraded the commons-csv dependency from `1.0-SNAPSHOT-rev1148315` to 
`1.5`.

On running `mvn clean install`, all tests pass.

A couple of minor code changes I made along the way:
1. Deleted dead code in `if (delimiter.length() != 1 || 
delimiter.equals(""))`
2. Added a null-check in `CSVExtractor.processHeader()`
3. Deleted `NULL_CHAR = ' '` from `CSVReaderBuilder`. Not sure why that was 
being used as a comment marker--guessing it was meant to disable comments 
during strategy testing, which the default `CSVFormat` does already.
4. Deleted non-standard use of the character `'` for encapsulation. Not 
sure why that was being used as such. Both `CSVFormat.DEFAULT` and the defunct 
`CSVStrategy.DEFAULT_STRATEGY`, as well as the RFC 4180 standard use `"` as the 
encapsulation character.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HansBrende/any23 ANY23-264

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/any23/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #63


commit 7a7db20069da63bb1312dd12820c2f2ca301856f
Author: Hans 
Date:   2018-02-09T05:27:30Z

ANY23-264 Upgrade to use public commons-csv instead of custom SNAPSHOT




> Upgrade to use public commons-csv instead of custom SNAPSHOT
> 
>
> Key: ANY23-264
> URL: https://issues.apache.org/jira/browse/ANY23-264
> Project: Apache Any23
>  Issue Type: Improvement
>Affects Versions: 1.1
>Reporter: Lewis John McGibbney
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> Unbeknown to me, it appears that commons-csv finally released a couple of 
> artifacts which means we can drop support of our [old SNAPSHOT dependency and 
> makeshift 
> repository|http://svn.apache.org/repos/asf/any23/repo-ext/org/apache/commons/commons-csv/]
>  in favor of a nice new shiny public artifact
> http://search.maven.org/#artifactdetails|org.apache.commons|commons-csv|1.1|jar



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] any23 pull request #63: ANY23-264 Upgrade to use public commons-csv instead ...

[HansBrende]

GitHub user HansBrende opened a pull request:

https://github.com/apache/any23/pull/63

ANY23-264 Upgrade to use public commons-csv instead of custom SNAPSHOT

I upgraded the commons-csv dependency from `1.0-SNAPSHOT-rev1148315` to 
`1.5`.

On running `mvn clean install`, all tests pass.

A couple of minor code changes I made along the way:
1. Deleted dead code in `if (delimiter.length() != 1 || 
delimiter.equals(""))`
2. Added a null-check in `CSVExtractor.processHeader()`
3. Deleted `NULL_CHAR = ' '` from `CSVReaderBuilder`. Not sure why that was 
being used as a comment marker--guessing it was meant to disable comments 
during strategy testing, which the default `CSVFormat` does already.
4. Deleted non-standard use of the character `'` for encapsulation. Not 
sure why that was being used as such. Both `CSVFormat.DEFAULT` and the defunct 
`CSVStrategy.DEFAULT_STRATEGY`, as well as the RFC 4180 standard use `"` as the 
encapsulation character.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HansBrende/any23 ANY23-264

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/any23/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #63


commit 7a7db20069da63bb1312dd12820c2f2ca301856f
Author: Hans 
Date:   2018-02-09T05:27:30Z

ANY23-264 Upgrade to use public commons-csv instead of custom SNAPSHOT




---

[jira] [Assigned] (ANY23-264) Upgrade to use public commons-csv instead of custom SNAPSHOT

[Hans Brende (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ANY23-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Brende reassigned ANY23-264:
-

Assignee: Hans Brende

> Upgrade to use public commons-csv instead of custom SNAPSHOT
> 
>
> Key: ANY23-264
> URL: https://issues.apache.org/jira/browse/ANY23-264
> Project: Apache Any23
>  Issue Type: Improvement
>Affects Versions: 1.1
>Reporter: Lewis John McGibbney
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.3
>
>
> Unbeknown to me, it appears that commons-csv finally released a couple of 
> artifacts which means we can drop support of our [old SNAPSHOT dependency and 
> makeshift 
> repository|http://svn.apache.org/repos/asf/any23/repo-ext/org/apache/commons/commons-csv/]
>  in favor of a nice new shiny public artifact
> http://search.maven.org/#artifactdetails|org.apache.commons|commons-csv|1.1|jar



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ANY23-321) Add openie toggle functionality to service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ANY23-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357614#comment-16357614
 ] 

ASF GitHub Bot commented on ANY23-321:
--

Github user ansell commented on the issue:

https://github.com/apache/any23/pull/56
  
I don't have time right now to debug this or work on its design. It isn't a 
pattern I have worked on in the past. All ``ServiceLoader`` projects that I 
have worked on in the past either have all of the service Factory objects 
initialised as startup, or they do periodic scans, but always create and 
initialise the service Factory objects whenever they are discovered. 

Is this issue attempting to delay/extract the OpenIE initialisation by 
delaying/postponing the Factory initialisation? If so, the focus could possibly 
be on making the OpenIE initialisation lazy to only occur when the Factory is 
actually required/used to create an object instance.

A more configurable lifecycle possibly requires OSGi, which I again have 
absolutely no experience with, but from the little understanding each time I 
look, it appears to allow user driven initialisation (push rather than pull, if 
that makes sense).


> Add openie toggle functionality to service
> --
>
> Key: ANY23-321
> URL: https://issues.apache.org/jira/browse/ANY23-321
> Project: Apache Any23
>  Issue Type: Bug
>  Components: openie, service
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Major
> Fix For: 2.3
>
>
> This issue is to add new functionality which provides an on-off switch for 
> running the openie module in addition to existing extractions. Basically 
> replicating the 'Report' or 'Annotate' check boxes would be ideal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

[ansell]

Github user ansell commented on the issue:

https://github.com/apache/any23/pull/56
  
I don't have time right now to debug this or work on its design. It isn't a 
pattern I have worked on in the past. All ``ServiceLoader`` projects that I 
have worked on in the past either have all of the service Factory objects 
initialised as startup, or they do periodic scans, but always create and 
initialise the service Factory objects whenever they are discovered. 

Is this issue attempting to delay/extract the OpenIE initialisation by 
delaying/postponing the Factory initialisation? If so, the focus could possibly 
be on making the OpenIE initialisation lazy to only occur when the Factory is 
actually required/used to create an object instance.

A more configurable lifecycle possibly requires OSGi, which I again have 
absolutely no experience with, but from the little understanding each time I 
look, it appears to allow user driven initialisation (push rather than pull, if 
that makes sense).


---

Re: Possibly issue with Any23 2.2 RC 1

[Peter Ansell]

Alternatively, we could look into the possibility of reusing jackson
csv that we are already inheriting through RDF4J.

Cheers,

Peter

On 9 February 2018 at 05:29, lewis john mcgibbney  wrote:
> Hi Folks,
> There 'may' be an issue with us using our project-hosted SNAPSHOT version
> of comons-csv [0]. This stems from the fact that the commons-csv source has
> not been officially released, but that we are using it as if it has been!
> I have taken this query to a larger audience over on dev@community, I will
> crosspost feedback here.
> Thanks Andy for bringing this up, and thank you to anyone else able to
> review the release candidate.
> Lewis
>
> [0] https://github.com/apache/any23/blob/master/pom.xml#L603-L606
> [1] https://s.apache.org/gOjG
>
> --
> http://home.apache.org/~lewismc/
> http://people.apache.org/keys/committer/lewismc

[jira] [Commented] (ANY23-321) Add openie toggle functionality to service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ANY23-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357485#comment-16357485
 ] 

ASF GitHub Bot commented on ANY23-321:
--

Github user lewismc commented on the issue:

https://github.com/apache/any23/pull/56
  
@HansBrende not yet sorry, I have been overloaded :( I will try tonight.


> Add openie toggle functionality to service
> --
>
> Key: ANY23-321
> URL: https://issues.apache.org/jira/browse/ANY23-321
> Project: Apache Any23
>  Issue Type: Bug
>  Components: openie, service
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Major
> Fix For: 2.3
>
>
> This issue is to add new functionality which provides an on-off switch for 
> running the openie module in addition to existing extractions. Basically 
> replicating the 'Report' or 'Annotate' check boxes would be ideal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

[lewismc]

Github user lewismc commented on the issue:

https://github.com/apache/any23/pull/56
  
@HansBrende not yet sorry, I have been overloaded :( I will try tonight.


---

[jira] [Commented] (ANY23-321) Add openie toggle functionality to service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ANY23-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357468#comment-16357468
 ] 

ASF GitHub Bot commented on ANY23-321:
--

Github user HansBrende commented on the issue:

https://github.com/apache/any23/pull/56
  
@lewismc have you been able to test whether or not my suggested insertion 
fixes your problem?


> Add openie toggle functionality to service
> --
>
> Key: ANY23-321
> URL: https://issues.apache.org/jira/browse/ANY23-321
> Project: Apache Any23
>  Issue Type: Bug
>  Components: openie, service
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Major
> Fix For: 2.3
>
>
> This issue is to add new functionality which provides an on-off switch for 
> running the openie module in addition to existing extractions. Basically 
> replicating the 'Report' or 'Annotate' check boxes would be ideal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

[HansBrende]

Github user HansBrende commented on the issue:

https://github.com/apache/any23/pull/56
  
@lewismc have you been able to test whether or not my suggested insertion 
fixes your problem?


---

[jira] [Assigned] (ANY23-264) Upgrade to use public commons-csv instead of custom SNAPSHOT

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ANY23-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney reassigned ANY23-264:
--

Assignee: (was: Peter Ansell)

> Upgrade to use public commons-csv instead of custom SNAPSHOT
> 
>
> Key: ANY23-264
> URL: https://issues.apache.org/jira/browse/ANY23-264
> Project: Apache Any23
>  Issue Type: Improvement
>Affects Versions: 1.1
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: 2.3
>
>
> Unbeknown to me, it appears that commons-csv finally released a couple of 
> artifacts which means we can drop support of our [old SNAPSHOT dependency and 
> makeshift 
> repository|http://svn.apache.org/repos/asf/any23/repo-ext/org/apache/commons/commons-csv/]
>  in favor of a nice new shiny public artifact
> http://search.maven.org/#artifactdetails|org.apache.commons|commons-csv|1.1|jar



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Possibly issue with Any23 2.2 RC 1

[lewis john mcgibbney]

Hi Folks,
There 'may' be an issue with us using our project-hosted SNAPSHOT version
of comons-csv [0]. This stems from the fact that the commons-csv source has
not been officially released, but that we are using it as if it has been!
I have taken this query to a larger audience over on dev@community, I will
crosspost feedback here.
Thanks Andy for bringing this up, and thank you to anyone else able to
review the release candidate.
Lewis

[0] https://github.com/apache/any23/blob/master/pom.xml#L603-L606
[1] https://s.apache.org/gOjG

-- 
http://home.apache.org/~lewismc/
http://people.apache.org/keys/committer/lewismc