[jira] [Commented] (ANY23-328) Problem parsing json-ld content surrounded by comments

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ANY23-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361454#comment-16361454
 ] 

ASF GitHub Bot commented on ANY23-328:
--

Github user HansBrende commented on the issue:

https://github.com/apache/any23/pull/65
  
FYI, at around 1pm CST today, I refactored and rebased this commit to use
java.io.PushbackInputStream instead of my own custom pushback logic. This
should make things less complicated and more readable. So if you were
testing this PR before 1pm, please pull the current version.

On Mon, Feb 12, 2018 at 9:44 AM, Lewis John McGibbney <
notificati...@github.com> wrote:

> +1, tested locally. Anyone else have comments?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 

> .
>



> Problem parsing json-ld content surrounded by comments
> --
>
> Key: ANY23-328
> URL: https://issues.apache.org/jira/browse/ANY23-328
> Project: Apache Any23
>  Issue Type: Bug
>  Components: core
>Affects Versions: 2.1
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.2
>
>
> Sometimes in json-ld script blocks (e.g., on https://www.guthriegreen.com), 
> you will see
> //
> or 
> //
>  
> Currently we are stripping CDATA markers, but we are not stripping leading & 
> trailing comments, which will cause json-ld parsing to fail. This may be 
> related to issue #17. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] any23 issue #65: ANY23-328 Strip comments from json-ld to make parsing more ...

2018-02-12 Thread HansBrende 
Github user HansBrende commented on the issue:

https://github.com/apache/any23/pull/65
  
FYI, at around 1pm CST today, I refactored and rebased this commit to use
java.io.PushbackInputStream instead of my own custom pushback logic. This
should make things less complicated and more readable. So if you were
testing this PR before 1pm, please pull the current version.

On Mon, Feb 12, 2018 at 9:44 AM, Lewis John McGibbney <
notificati...@github.com> wrote:

> +1, tested locally. Anyone else have comments?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 

> .
>



---

[jira] [Commented] (ANY23-328) Problem parsing json-ld content surrounded by comments

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ANY23-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361260#comment-16361260
 ] 

ASF GitHub Bot commented on ANY23-328:
--

Github user HansBrende commented on the issue:

https://github.com/apache/any23/pull/65
  
@lewismc I just refactored this to use the `java.io.PushbackInputStream` 
class instead of my own custom pushback buffer logic. Should make this commit 
less complex and more readable!


> Problem parsing json-ld content surrounded by comments
> --
>
> Key: ANY23-328
> URL: https://issues.apache.org/jira/browse/ANY23-328
> Project: Apache Any23
>  Issue Type: Bug
>  Components: core
>Affects Versions: 2.1
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.2
>
>
> Sometimes in json-ld script blocks (e.g., on https://www.guthriegreen.com), 
> you will see
> //
> or 
> //
>  
> Currently we are stripping CDATA markers, but we are not stripping leading & 
> trailing comments, which will cause json-ld parsing to fail. This may be 
> related to issue #17. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] any23 issue #65: ANY23-328 Strip comments from json-ld to make parsing more ...

2018-02-12 Thread HansBrende 
Github user HansBrende commented on the issue:

https://github.com/apache/any23/pull/65
  
@lewismc I just refactored this to use the `java.io.PushbackInputStream` 
class instead of my own custom pushback buffer logic. Should make this commit 
less complex and more readable!


---

[jira] [Commented] (ANY23-329) master branch broken with pom.xml any23 version

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ANY23-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361146#comment-16361146
 ] 

ASF GitHub Bot commented on ANY23-329:
--

Github user ferrerod commented on the issue:

https://github.com/apache/any23/pull/64
  
I changed the version to 2.2-SNAPSHOT in the pom.xml project root in order 
to successfully build the master branch. I thought master should always be 
buildable.


> master branch broken with pom.xml any23 version
> ---
>
> Key: ANY23-329
> URL: https://issues.apache.org/jira/browse/ANY23-329
> Project: Apache Any23
>  Issue Type: Bug
>  Components: build
>Affects Versions: 2.3
>Reporter: David Ferrero
>Priority: Blocker
>  Labels: easyfix
> Fix For: 2.3
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> simple one character mistake in the pom version is breaking the master branch 
> build. Change from 2.3-SNAPSHOT to 2.2-SNAPSHOT fixes the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] any23 issue #64: ANY23-329 fixed pom.xml version to 2.2-SNAPSHOT

2018-02-12 Thread ferrerod 
Github user ferrerod commented on the issue:

https://github.com/apache/any23/pull/64
  
I changed the version to 2.2-SNAPSHOT in the pom.xml project root in order 
to successfully build the master branch. I thought master should always be 
buildable.


---

[jira] [Commented] (ANY23-329) master branch broken with pom.xml any23 version

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ANY23-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360919#comment-16360919
 ] 

ASF GitHub Bot commented on ANY23-329:
--

Github user lewismc commented on the issue:

https://github.com/apache/any23/pull/64
  
This will be fixed when I run a new release candidate folks. When we 
release 2.2 we will increment version to 2.3-SNAPSHOT


> master branch broken with pom.xml any23 version
> ---
>
> Key: ANY23-329
> URL: https://issues.apache.org/jira/browse/ANY23-329
> Project: Apache Any23
>  Issue Type: Bug
>  Components: build
>Affects Versions: 2.3
>Reporter: David Ferrero
>Priority: Blocker
>  Labels: easyfix
> Fix For: 2.3
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> simple one character mistake in the pom version is breaking the master branch 
> build. Change from 2.3-SNAPSHOT to 2.2-SNAPSHOT fixes the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] any23 issue #64: ANY23-329 fixed pom.xml version to 2.2-SNAPSHOT

2018-02-12 Thread lewismc 
Github user lewismc commented on the issue:

https://github.com/apache/any23/pull/64
  
This will be fixed when I run a new release candidate folks. When we 
release 2.2 we will increment version to 2.3-SNAPSHOT


---

[jira] [Commented] (ANY23-328) Problem parsing json-ld content surrounded by comments

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ANY23-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360918#comment-16360918
 ] 

ASF GitHub Bot commented on ANY23-328:
--

Github user lewismc commented on the issue:

https://github.com/apache/any23/pull/65
  
+1, tested locally. Anyone else have comments?


> Problem parsing json-ld content surrounded by comments
> --
>
> Key: ANY23-328
> URL: https://issues.apache.org/jira/browse/ANY23-328
> Project: Apache Any23
>  Issue Type: Bug
>  Components: core
>Affects Versions: 2.1
>Reporter: Hans Brende
>Assignee: Hans Brende
>Priority: Major
> Fix For: 2.2
>
>
> Sometimes in json-ld script blocks (e.g., on https://www.guthriegreen.com), 
> you will see
> //
> or 
> //
>  
> Currently we are stripping CDATA markers, but we are not stripping leading & 
> trailing comments, which will cause json-ld parsing to fail. This may be 
> related to issue #17. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] any23 issue #65: ANY23-328 Strip comments from json-ld to make parsing more ...

2018-02-12 Thread lewismc 
Github user lewismc commented on the issue:

https://github.com/apache/any23/pull/65
  
+1, tested locally. Anyone else have comments?


---

[jira] [Commented] (ANY23-329) master branch broken with pom.xml any23 version

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ANY23-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360727#comment-16360727
 ] 

ASF GitHub Bot commented on ANY23-329:
--

Github user stain commented on the issue:

https://github.com/apache/any23/pull/64
  
Thanks - these also seem to remain at `2.3-SNAPSHOT`:

```
stain@biggie:~/src/any23$ grep -r 2.3-SNAPSHOT .
./plugins/basic-crawler/pom.xml:  2.3-SNAPSHOT
./plugins/basic-crawler/pom.xml:  2.3-SNAPSHOT
./plugins/basic-crawler/pom.xml:  2.3-SNAPSHOT
./plugins/basic-crawler/pom.xml:  2.3-SNAPSHOT
./plugins/html-scraper/pom.xml:  2.3-SNAPSHOT
./plugins/office-scraper/pom.xml:  2.3-SNAPSHOT
```


> master branch broken with pom.xml any23 version
> ---
>
> Key: ANY23-329
> URL: https://issues.apache.org/jira/browse/ANY23-329
> Project: Apache Any23
>  Issue Type: Bug
>  Components: build
>Affects Versions: 2.3
>Reporter: David Ferrero
>Priority: Blocker
>  Labels: easyfix
> Fix For: 2.3
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> simple one character mistake in the pom version is breaking the master branch 
> build. Change from 2.3-SNAPSHOT to 2.2-SNAPSHOT fixes the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] any23 issue #64: ANY23-329 fixed pom.xml version to 2.2-SNAPSHOT

2018-02-12 Thread stain 
Github user stain commented on the issue:

https://github.com/apache/any23/pull/64
  
Thanks - these also seem to remain at `2.3-SNAPSHOT`:

```
stain@biggie:~/src/any23$ grep -r 2.3-SNAPSHOT .
./plugins/basic-crawler/pom.xml:  2.3-SNAPSHOT
./plugins/basic-crawler/pom.xml:  2.3-SNAPSHOT
./plugins/basic-crawler/pom.xml:  2.3-SNAPSHOT
./plugins/basic-crawler/pom.xml:  2.3-SNAPSHOT
./plugins/html-scraper/pom.xml:  2.3-SNAPSHOT
./plugins/office-scraper/pom.xml:  2.3-SNAPSHOT
```


---