[GitHub] [any23] lewismc opened a new pull request #151: ANY23-445 Review spotbugs issues
lewismc opened a new pull request #151: ANY23-445 Review spotbugs issues URL: https://github.com/apache/any23/pull/151 First pass at addressing https://issues.apache.org/jira/browse/ANY23-445. Still loads to do. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ANY23-269) Support auto.schema.org
[ https://issues.apache.org/jira/browse/ANY23-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney updated ANY23-269: --- Fix Version/s: (was: 2.5) 2.4 > Support auto.schema.org > --- > > Key: ANY23-269 > URL: https://issues.apache.org/jira/browse/ANY23-269 > Project: Apache Any23 > Issue Type: Sub-task > Components: core >Affects Versions: 1.1 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > > Recently watch a schema.org presentation (part of 2 part series) and there > was mention of auto.schema.org, we should investigate if we support it in > Any23. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ANY23-269) Support auto.schema.org
[ https://issues.apache.org/jira/browse/ANY23-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney resolved ANY23-269. Resolution: Not A Problem > Support auto.schema.org > --- > > Key: ANY23-269 > URL: https://issues.apache.org/jira/browse/ANY23-269 > Project: Apache Any23 > Issue Type: Sub-task > Components: core >Affects Versions: 1.1 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > > Recently watch a schema.org presentation (part of 2 part series) and there > was mention of auto.schema.org, we should investigate if we support it in > Any23. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ANY23-270) Support bib.schema.org
[ https://issues.apache.org/jira/browse/ANY23-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney resolved ANY23-270. Resolution: Not A Problem > Support bib.schema.org > -- > > Key: ANY23-270 > URL: https://issues.apache.org/jira/browse/ANY23-270 > Project: Apache Any23 > Issue Type: Sub-task > Components: core >Affects Versions: 1.1 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > > Recently watch a schema.org presentation (part of 2 part series) and there > was mention of bib.schema.org, we should investigate if we support it in > Any23. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ANY23-270) Support bib.schema.org
[ https://issues.apache.org/jira/browse/ANY23-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney updated ANY23-270: --- Fix Version/s: (was: 2.5) 2.4 > Support bib.schema.org > -- > > Key: ANY23-270 > URL: https://issues.apache.org/jira/browse/ANY23-270 > Project: Apache Any23 > Issue Type: Sub-task > Components: core >Affects Versions: 1.1 >Reporter: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > > Recently watch a schema.org presentation (part of 2 part series) and there > was mention of bib.schema.org, we should investigate if we support it in > Any23. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ANY23-436) Upgrade commons-csv to v1.7
[ https://issues.apache.org/jira/browse/ANY23-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952503#comment-16952503 ] Hudson commented on ANY23-436: -- SUCCESS: Integrated in Jenkins build Any23-trunk #1676 (See [https://builds.apache.org/job/Any23-trunk/1676/]) ANY23-436 Upgrade commons-csv to v1.7 (#150) (github: rev 1c91b0ee356fcfeb73d02ce58b3bba6100bc18cd) * (edit) pom.xml > Upgrade commons-csv to v1.7 > --- > > Key: ANY23-436 > URL: https://issues.apache.org/jira/browse/ANY23-436 > Project: Apache Any23 > Issue Type: Task >Reporter: Hans Brende >Assignee: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ANY23-437) Upgrade snakeyaml to v1.25
[ https://issues.apache.org/jira/browse/ANY23-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952502#comment-16952502 ] Hudson commented on ANY23-437: -- SUCCESS: Integrated in Jenkins build Any23-trunk #1676 (See [https://builds.apache.org/job/Any23-trunk/1676/]) ANY23-437 Upgrade snakeyaml to v1.25 (lewis.mcgibbney: rev e872daa38dd58a5e66d82f25df41621d404dbd1c) * (edit) pom.xml > Upgrade snakeyaml to v1.25 > -- > > Key: ANY23-437 > URL: https://issues.apache.org/jira/browse/ANY23-437 > Project: Apache Any23 > Issue Type: Task >Reporter: Hans Brende >Assignee: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ANY23-436) Upgrade commons-csv to v1.7
[ https://issues.apache.org/jira/browse/ANY23-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney reassigned ANY23-436: -- Assignee: Lewis John McGibbney > Upgrade commons-csv to v1.7 > --- > > Key: ANY23-436 > URL: https://issues.apache.org/jira/browse/ANY23-436 > Project: Apache Any23 > Issue Type: Task >Reporter: Hans Brende >Assignee: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ANY23-436) Upgrade commons-csv to v1.7
[ https://issues.apache.org/jira/browse/ANY23-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney resolved ANY23-436. Resolution: Fixed > Upgrade commons-csv to v1.7 > --- > > Key: ANY23-436 > URL: https://issues.apache.org/jira/browse/ANY23-436 > Project: Apache Any23 > Issue Type: Task >Reporter: Hans Brende >Assignee: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ANY23-437) Upgrade snakeyaml to v1.25
[ https://issues.apache.org/jira/browse/ANY23-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney resolved ANY23-437. Resolution: Fixed > Upgrade snakeyaml to v1.25 > -- > > Key: ANY23-437 > URL: https://issues.apache.org/jira/browse/ANY23-437 > Project: Apache Any23 > Issue Type: Task >Reporter: Hans Brende >Assignee: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [any23] lewismc merged pull request #149: ANY23-437 Upgrade snakeyaml to v1.25
lewismc merged pull request #149: ANY23-437 Upgrade snakeyaml to v1.25 URL: https://github.com/apache/any23/pull/149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [any23] lewismc merged pull request #150: ANY23-436 Upgrade commons-csv to v1.7
lewismc merged pull request #150: ANY23-436 Upgrade commons-csv to v1.7 URL: https://github.com/apache/any23/pull/150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [any23] lewismc commented on issue #150: ANY23-436 Upgrade commons-csv to v1.7
lewismc commented on issue #150: ANY23-436 Upgrade commons-csv to v1.7 URL: https://github.com/apache/any23/pull/150#issuecomment-542452736 @davidcockbill any comments? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [any23] lewismc commented on issue #149: ANY23-437 Upgrade snakeyaml to v1.25
lewismc commented on issue #149: ANY23-437 Upgrade snakeyaml to v1.25 URL: https://github.com/apache/any23/pull/149#issuecomment-542452682 @davidcockbill any comments? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (ANY23-445) Review spotbugs issues
[
https://issues.apache.org/jira/browse/ANY23-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lewis John McGibbney reassigned ANY23-445:
--
Assignee: Lewis John McGibbney
> Review spotbugs issues
> --
>
> Key: ANY23-445
> URL: https://issues.apache.org/jira/browse/ANY23-445
> Project: Apache Any23
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.4
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Major
> Fix For: 2.4
>
>
> Post ANY23-444 we can now run spotsbugs... currently it flags the following
> issues
> {code}
> [INFO] --- spotbugs-maven-plugin:3.1.12.2:check (default-cli) @
> apache-any23-api ---
> [INFO] BugInstance size is 131
> [INFO] Error size is 0
> [INFO] Total bugs: 131
> [ERROR]
> org.apache.any23.configuration.DefaultConfiguration.loadDefaultProperties()
> may fail to clean up java.io.InputStream
> [org.apache.any23.configuration.DefaultConfiguration,
> org.apache.any23.configuration.DefaultConfiguration,
> org.apache.any23.configuration.DefaultConfiguration] Obligation to clean up
> resource created at DefaultConfiguration.java:[line 78] is not dischargedPath
> continues at DefaultConfiguration.java:[line 81]Path continues at
> DefaultConfiguration.java:[line 82] OBL_UNSATISFIED_OBLIGATION
> [ERROR] Redundant nullcheck of value, which is known to be non-null in
> org.apache.any23.configuration.DefaultConfiguration.getFlagProperty(String)
> [org.apache.any23.configuration.DefaultConfiguration] Redundant null check at
> DefaultConfiguration.java:[line 132] RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> [ERROR] Found reliance on default encoding in
> org.apache.any23.extractor.ExtractionException.printStackTrace(PrintStream):
> new java.io.PrintWriter(OutputStream)
> [org.apache.any23.extractor.ExtractionException] At
> ExtractionException.java:[line 47] DM_DEFAULT_ENCODING
> [ERROR] String is incompatible with expected argument type
> org.apache.any23.mime.MIMEType in
> org.apache.any23.extractor.ExtractorGroup.supportsAllContentTypes(ExtractorFactory)
> [org.apache.any23.extractor.ExtractorGroup] At ExtractorGroup.java:[line 82]
> GC_UNRELATED_TYPES
> [ERROR] org.apache.any23.mime.MIMEType defines compareTo(MIMEType) and uses
> Object.equals() [org.apache.any23.mime.MIMEType] At MIMEType.java:[line 134]
> EQ_COMPARETO_USE_OBJECT_EQUALS
> [ERROR] Possible null pointer dereference in
> org.apache.any23.plugin.Any23PluginManager.loadJARDir(File) due to return
> value of called method [org.apache.any23.plugin.Any23PluginManager,
> org.apache.any23.plugin.Any23PluginManager] Dereferenced at
> Any23PluginManager.java:[line 194]Known null at Any23PluginManager.java:[line
> 194] NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
> [ERROR] The field name org.apache.any23.vocab.HCard.Address doesn't start
> with a lower case letter [org.apache.any23.vocab.HCard] In HCard.java
> NM_FIELD_NAMING_CONVENTION
> [ERROR] The field name org.apache.any23.vocab.HCard.Card doesn't start with a
> lower case letter [org.apache.any23.vocab.HCard] In HCard.java
> NM_FIELD_NAMING_CONVENTION
> [ERROR] The field name org.apache.any23.vocab.HCard.Geo doesn't start with a
> lower case letter [org.apache.any23.vocab.HCard] In HCard.java
> NM_FIELD_NAMING_CONVENTION
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.Address
> [org.apache.any23.vocab.HCard] At HCard.java:[line 40]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.Card
> [org.apache.any23.vocab.HCard] At HCard.java:[line 39]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.Geo
> [org.apache.any23.vocab.HCard] At HCard.java:[line 41]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field:
> org.apache.any23.vocab.HCard.additional_name [org.apache.any23.vocab.HCard]
> At HCard.java:[line 47] URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.adr
> [org.apache.any23.vocab.HCard] At HCard.java:[line 70]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.altitude
> [org.apache.any23.vocab.HCard] At HCard.java:[line 81]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field:
> org.apache.any23.vocab.HCard.anniversary [org.apache.any23.vocab.HCard] At
> HCard.java:[line 68] URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.bday
> [org.apache.any23.vocab.HCard] At HCard.java:[line 60]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.category
>
[jira] [Commented] (ANY23-445) Review spotbugs issues
[
https://issues.apache.org/jira/browse/ANY23-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952175#comment-16952175
]
Lewis John McGibbney commented on ANY23-445:
Going to start work on this as my next issue.
> Review spotbugs issues
> --
>
> Key: ANY23-445
> URL: https://issues.apache.org/jira/browse/ANY23-445
> Project: Apache Any23
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.4
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Major
> Fix For: 2.4
>
>
> Post ANY23-444 we can now run spotsbugs... currently it flags the following
> issues
> {code}
> [INFO] --- spotbugs-maven-plugin:3.1.12.2:check (default-cli) @
> apache-any23-api ---
> [INFO] BugInstance size is 131
> [INFO] Error size is 0
> [INFO] Total bugs: 131
> [ERROR]
> org.apache.any23.configuration.DefaultConfiguration.loadDefaultProperties()
> may fail to clean up java.io.InputStream
> [org.apache.any23.configuration.DefaultConfiguration,
> org.apache.any23.configuration.DefaultConfiguration,
> org.apache.any23.configuration.DefaultConfiguration] Obligation to clean up
> resource created at DefaultConfiguration.java:[line 78] is not dischargedPath
> continues at DefaultConfiguration.java:[line 81]Path continues at
> DefaultConfiguration.java:[line 82] OBL_UNSATISFIED_OBLIGATION
> [ERROR] Redundant nullcheck of value, which is known to be non-null in
> org.apache.any23.configuration.DefaultConfiguration.getFlagProperty(String)
> [org.apache.any23.configuration.DefaultConfiguration] Redundant null check at
> DefaultConfiguration.java:[line 132] RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> [ERROR] Found reliance on default encoding in
> org.apache.any23.extractor.ExtractionException.printStackTrace(PrintStream):
> new java.io.PrintWriter(OutputStream)
> [org.apache.any23.extractor.ExtractionException] At
> ExtractionException.java:[line 47] DM_DEFAULT_ENCODING
> [ERROR] String is incompatible with expected argument type
> org.apache.any23.mime.MIMEType in
> org.apache.any23.extractor.ExtractorGroup.supportsAllContentTypes(ExtractorFactory)
> [org.apache.any23.extractor.ExtractorGroup] At ExtractorGroup.java:[line 82]
> GC_UNRELATED_TYPES
> [ERROR] org.apache.any23.mime.MIMEType defines compareTo(MIMEType) and uses
> Object.equals() [org.apache.any23.mime.MIMEType] At MIMEType.java:[line 134]
> EQ_COMPARETO_USE_OBJECT_EQUALS
> [ERROR] Possible null pointer dereference in
> org.apache.any23.plugin.Any23PluginManager.loadJARDir(File) due to return
> value of called method [org.apache.any23.plugin.Any23PluginManager,
> org.apache.any23.plugin.Any23PluginManager] Dereferenced at
> Any23PluginManager.java:[line 194]Known null at Any23PluginManager.java:[line
> 194] NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
> [ERROR] The field name org.apache.any23.vocab.HCard.Address doesn't start
> with a lower case letter [org.apache.any23.vocab.HCard] In HCard.java
> NM_FIELD_NAMING_CONVENTION
> [ERROR] The field name org.apache.any23.vocab.HCard.Card doesn't start with a
> lower case letter [org.apache.any23.vocab.HCard] In HCard.java
> NM_FIELD_NAMING_CONVENTION
> [ERROR] The field name org.apache.any23.vocab.HCard.Geo doesn't start with a
> lower case letter [org.apache.any23.vocab.HCard] In HCard.java
> NM_FIELD_NAMING_CONVENTION
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.Address
> [org.apache.any23.vocab.HCard] At HCard.java:[line 40]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.Card
> [org.apache.any23.vocab.HCard] At HCard.java:[line 39]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.Geo
> [org.apache.any23.vocab.HCard] At HCard.java:[line 41]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field:
> org.apache.any23.vocab.HCard.additional_name [org.apache.any23.vocab.HCard]
> At HCard.java:[line 47] URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.adr
> [org.apache.any23.vocab.HCard] At HCard.java:[line 70]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.altitude
> [org.apache.any23.vocab.HCard] At HCard.java:[line 81]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field:
> org.apache.any23.vocab.HCard.anniversary [org.apache.any23.vocab.HCard] At
> HCard.java:[line 68] URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field: org.apache.any23.vocab.HCard.bday
> [org.apache.any23.vocab.HCard] At HCard.java:[line 60]
> URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
> [ERROR] Unread public/protected field:
[GitHub] [any23] lewismc opened a new pull request #150: ANY23-436 Upgrade commons-csv to v1.7
lewismc opened a new pull request #150: ANY23-436 Upgrade commons-csv to v1.7 URL: https://github.com/apache/any23/pull/150 This PR addresses https://issues.apache.org/jira/browse/ANY23-436 Trivial. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [any23] lewismc opened a new pull request #149: ANY23-437 Upgrade snakeyaml to v1.25
lewismc opened a new pull request #149: ANY23-437 Upgrade snakeyaml to v1.25 URL: https://github.com/apache/any23/pull/149 This issue addresses https://issues.apache.org/jira/browse/ANY23-437 Trivial. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ANY23-437) Upgrade snakeyaml to v1.25
[ https://issues.apache.org/jira/browse/ANY23-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney updated ANY23-437: --- Summary: Upgrade snakeyaml to v1.25 (was: Upgrade snakeyaml to v1.24) > Upgrade snakeyaml to v1.25 > -- > > Key: ANY23-437 > URL: https://issues.apache.org/jira/browse/ANY23-437 > Project: Apache Any23 > Issue Type: Task >Reporter: Hans Brende >Assignee: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ANY23-437) Upgrade snakeyaml to v1.24
[ https://issues.apache.org/jira/browse/ANY23-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney reassigned ANY23-437: -- Assignee: Lewis John McGibbney > Upgrade snakeyaml to v1.24 > -- > > Key: ANY23-437 > URL: https://issues.apache.org/jira/browse/ANY23-437 > Project: Apache Any23 > Issue Type: Task >Reporter: Hans Brende >Assignee: Lewis John McGibbney >Priority: Major > Fix For: 2.4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
