[jira] [Commented] (APEXCORE-470) New Api for setting the attribute on the operator ( setOperatorAttribute )
[ https://issues.apache.org/jira/browse/APEXCORE-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339574#comment-15339574 ] ASF GitHub Bot commented on APEXCORE-470: - Github user asfgit closed the pull request at: https://github.com/apache/apex-core/pull/349 > New Api for setting the attribute on the operator ( setOperatorAttribute ) > -- > > Key: APEXCORE-470 > URL: https://issues.apache.org/jira/browse/APEXCORE-470 > Project: Apache Apex Core > Issue Type: Improvement >Reporter: Sandesh >Assignee: Sandesh > > Currently, *setAttribute* is used to set the operator attributes. Other 2 > Attribute setting APIs are specific to input ports (*setInputPortAttributes*) > and output ports (*setOutputPortsAttributes*). > Proposal is to have *SetOperatorAttribute* api, which will clearly indicate > that user wants set attributes on the operator. > ( setOperatorAttribute(Operator operator, Attribute key, T value) ) > Following will be the roles for the APIs > *setAttributes* --> for setting Attributes for the whole DAG ( > setAttribute(Operator operator, Attribute key, T value) - can be > deprecated ) > *setOperatorAttributes* --> for setting Attributes for the operator > All the unit test cases using the previous API will be renamed as a part of > this change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (APEXCORE-470) New Api for setting the attribute on the operator ( setOperatorAttribute )
[
https://issues.apache.org/jira/browse/APEXCORE-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332479#comment-15332479
]
ASF GitHub Bot commented on APEXCORE-470:
-
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/349#discussion_r67238893
--- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
@@ -236,11 +236,22 @@
public abstract void setAttribute(Attribute key, T value);
/**
- * setAttribute.
+ *
+ * Use {@link #setOperatorAttribute} instead
*/
--- End diff --
Addressed all the review comments. Travis builds fails randomly. I just
updated JavaDoc, so it shouldn't have updated the Travis.
> New Api for setting the attribute on the operator ( setOperatorAttribute )
> --
>
> Key: APEXCORE-470
> URL: https://issues.apache.org/jira/browse/APEXCORE-470
> Project: Apache Apex Core
> Issue Type: Improvement
>Reporter: Sandesh
>Assignee: Sandesh
>
> Currently, *setAttribute* is used to set the operator attributes. Other 2
> Attribute setting APIs are specific to input ports (*setInputPortAttributes*)
> and output ports (*setOutputPortsAttributes*).
> Proposal is to have *SetOperatorAttribute* api, which will clearly indicate
> that user wants set attributes on the operator.
> ( setOperatorAttribute(Operator operator, Attribute key, T value) )
> Following will be the roles for the APIs
> *setAttributes* --> for setting Attributes for the whole DAG (
> setAttribute(Operator operator, Attribute key, T value) - can be
> deprecated )
> *setOperatorAttributes* --> for setting Attributes for the operator
> All the unit test cases using the previous API will be renamed as a part of
> this change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (APEXCORE-470) New Api for setting the attribute on the operator ( setOperatorAttribute )
[
https://issues.apache.org/jira/browse/APEXCORE-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330752#comment-15330752
]
ASF GitHub Bot commented on APEXCORE-470:
-
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/349#discussion_r67068235
--- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
@@ -236,11 +236,22 @@
public abstract void setAttribute(Attribute key, T value);
/**
- * setAttribute.
+ *
+ * Use {@link #setOperatorAttribute} instead
*/
--- End diff --
How about using javadoc deprecation as well
https://docs.oracle.com/javase/tutorial/java/annotations/predefined.html
> New Api for setting the attribute on the operator ( setOperatorAttribute )
> --
>
> Key: APEXCORE-470
> URL: https://issues.apache.org/jira/browse/APEXCORE-470
> Project: Apache Apex Core
> Issue Type: Improvement
>Reporter: Sandesh
>Assignee: Sandesh
>
> Currently, *setAttribute* is used to set the operator attributes. Other 2
> Attribute setting APIs are specific to input ports (*setInputPortAttributes*)
> and output ports (*setOutputPortsAttributes*).
> Proposal is to have *SetOperatorAttribute* api, which will clearly indicate
> that user wants set attributes on the operator.
> ( setOperatorAttribute(Operator operator, Attribute key, T value) )
> Following will be the roles for the APIs
> *setAttributes* --> for setting Attributes for the whole DAG (
> setAttribute(Operator operator, Attribute key, T value) - can be
> deprecated )
> *setOperatorAttributes* --> for setting Attributes for the operator
> All the unit test cases using the previous API will be renamed as a part of
> this change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (APEXCORE-470) New Api for setting the attribute on the operator ( setOperatorAttribute )
[
https://issues.apache.org/jira/browse/APEXCORE-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330750#comment-15330750
]
ASF GitHub Bot commented on APEXCORE-470:
-
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/349#discussion_r67067938
--- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
@@ -236,11 +236,22 @@
public abstract void setAttribute(Attribute key, T value);
/**
- * setAttribute.
+ *
+ * Use {@link #setOperatorAttribute} instead
*/
+ @Deprecated
public abstract void setAttribute(Operator operator, Attribute
key, T value);
/**
+ * Set an attribute on the operator.
+ * @param Object type of the attribute.
--- End diff --
The value type
> New Api for setting the attribute on the operator ( setOperatorAttribute )
> --
>
> Key: APEXCORE-470
> URL: https://issues.apache.org/jira/browse/APEXCORE-470
> Project: Apache Apex Core
> Issue Type: Improvement
>Reporter: Sandesh
>Assignee: Sandesh
>
> Currently, *setAttribute* is used to set the operator attributes. Other 2
> Attribute setting APIs are specific to input ports (*setInputPortAttributes*)
> and output ports (*setOutputPortsAttributes*).
> Proposal is to have *SetOperatorAttribute* api, which will clearly indicate
> that user wants set attributes on the operator.
> ( setOperatorAttribute(Operator operator, Attribute key, T value) )
> Following will be the roles for the APIs
> *setAttributes* --> for setting Attributes for the whole DAG (
> setAttribute(Operator operator, Attribute key, T value) - can be
> deprecated )
> *setOperatorAttributes* --> for setting Attributes for the operator
> All the unit test cases using the previous API will be renamed as a part of
> this change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (APEXCORE-470) New Api for setting the attribute on the operator ( setOperatorAttribute )
[
https://issues.apache.org/jira/browse/APEXCORE-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330747#comment-15330747
]
ASF GitHub Bot commented on APEXCORE-470:
-
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/349#discussion_r67067785
--- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
@@ -236,11 +236,22 @@
public abstract void setAttribute(Attribute key, T value);
/**
- * setAttribute.
+ *
+ * Use {@link #setOperatorAttribute} instead
*/
+ @Deprecated
public abstract void setAttribute(Operator operator, Attribute
key, T value);
/**
+ * Set an attribute on the operator.
--- End diff --
for an operator
> New Api for setting the attribute on the operator ( setOperatorAttribute )
> --
>
> Key: APEXCORE-470
> URL: https://issues.apache.org/jira/browse/APEXCORE-470
> Project: Apache Apex Core
> Issue Type: Improvement
>Reporter: Sandesh
>Assignee: Sandesh
>
> Currently, *setAttribute* is used to set the operator attributes. Other 2
> Attribute setting APIs are specific to input ports (*setInputPortAttributes*)
> and output ports (*setOutputPortsAttributes*).
> Proposal is to have *SetOperatorAttribute* api, which will clearly indicate
> that user wants set attributes on the operator.
> ( setOperatorAttribute(Operator operator, Attribute key, T value) )
> Following will be the roles for the APIs
> *setAttributes* --> for setting Attributes for the whole DAG (
> setAttribute(Operator operator, Attribute key, T value) - can be
> deprecated )
> *setOperatorAttributes* --> for setting Attributes for the operator
> All the unit test cases using the previous API will be renamed as a part of
> this change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (APEXCORE-470) New Api for setting the attribute on the operator ( setOperatorAttribute )
[ https://issues.apache.org/jira/browse/APEXCORE-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319709#comment-15319709 ] ASF GitHub Bot commented on APEXCORE-470: - Github user PramodSSImmaneni commented on a diff in the pull request: https://github.com/apache/apex-core/pull/349#discussion_r66172343 --- Diff: api/src/main/java/com/datatorrent/api/DAG.java --- @@ -238,9 +238,15 @@ /** * setAttribute. */ + @Deprecated public abstract void setAttribute(Operator operator, Attribute key, T value); /** + * setOperatorAttribute. --- End diff -- javadoc > New Api for setting the attribute on the operator ( setOperatorAttribute ) > -- > > Key: APEXCORE-470 > URL: https://issues.apache.org/jira/browse/APEXCORE-470 > Project: Apache Apex Core > Issue Type: Improvement >Reporter: Sandesh >Assignee: Sandesh > > Currently, *setAttribute* is used to set the operator attributes. Other 2 > Attribute setting APIs are specific to input ports (*setInputPortAttributes*) > and output ports (*setOutputPortsAttributes*). > Proposal is to have *SetOperatorAttribute* api, which will clearly indicate > that user wants set attributes on the operator. > ( setOperatorAttribute(Operator operator, Attribute key, T value) ) > Following will be the roles for the APIs > *setAttributes* --> for setting Attributes for the whole DAG ( > setAttribute(Operator operator, Attribute key, T value) - can be > deprecated ) > *setOperatorAttributes* --> for setting Attributes for the operator > All the unit test cases using the previous API will be renamed as a part of > this change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
