[jira] [Commented] (APEXCORE-678) Shutdown of application should start from input nodes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXCORE-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970283#comment-15970283
 ] 

ASF GitHub Bot commented on APEXCORE-678:
-

Github user asfgit closed the pull request at:

https://github.com/apache/apex-core/pull/509


> Shutdown of application should start from input nodes
> -
>
> Key: APEXCORE-678
> URL: https://issues.apache.org/jira/browse/APEXCORE-678
> Project: Apache Apex Core
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Bhupesh Chawda
> Fix For: 3.6.0
>
>
> Streaming container calls shutdown() for all nodes instead of just input 
> nodes.
> {code}
>   private void stopInputNodes()
>   {
> for (Entry e : nodes.entrySet()) {
>   Node node = e.getValue();
>   if (node instanceof InputNode) {
> final Thread thread = e.getValue().context.getThread();
> if (thread == null || !thread.isAlive()) {
>   continue;
> }
>   }
>   node.shutdown(true);
> }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (APEXCORE-678) Shutdown of application should start from input nodes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXCORE-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967715#comment-15967715
 ] 

ASF GitHub Bot commented on APEXCORE-678:
-

GitHub user bhupeshchawda opened a pull request:

https://github.com/apache/apex-core/pull/509

APEXCORE-678 Fixed shutdown of input nodes in StreamingContainer

This was a straightforward bug. Also did not find any easy way to add test 
for it.

@tushargosavi please see

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bhupeshchawda/apex-core 
APEXCORE-678-shutdown-input-nodes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/apex-core/pull/509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #509


commit 06df668a83c30af30b7c440039f0101b566542ac
Author: bhupeshchawda 
Date:   2017-03-23T11:27:33Z

APEXCORE-678 Fixed shutdown of input nodes in StreamingContainer




> Shutdown of application should start from input nodes
> -
>
> Key: APEXCORE-678
> URL: https://issues.apache.org/jira/browse/APEXCORE-678
> Project: Apache Apex Core
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Bhupesh Chawda
> Fix For: 3.6.0
>
>
> Streaming container calls shutdown() for all nodes instead of just input 
> nodes.
> {code}
>   private void stopInputNodes()
>   {
> for (Entry e : nodes.entrySet()) {
>   Node node = e.getValue();
>   if (node instanceof InputNode) {
> final Thread thread = e.getValue().context.getThread();
> if (thread == null || !thread.isAlive()) {
>   continue;
> }
>   }
>   node.shutdown(true);
> }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)