Re: scan-build on apr/trunk
Am 31.07.2010 16:03, schrieb Stefan Fritsch: On Saturday 31 July 2010, Philip M. Gollucci wrote: http://p6m7g8.net/~pgollucci/sb/ I might take a stab at some of these next week. $ ./buildconf $ scan-build ./configure $ scan-build make -j12 One more issue found by gcc: Error handling in apr_memcache.c is broken: apr/memcache/apr_memcache.c:793: warning: comparison of unsigned expression 0 is always false apr/memcache/apr_memcache.c:1368: warning: comparison of unsigned expression= 0 is always true I've played a bit with recent OpenWatcom 1.9, and this compiler also found the above as well as a couple of others: http://people.apache.org/~fuankg/openwatcom/owc_w32_log.txt http://people.apache.org/~fuankg/openwatcom/owc_nw_log.txt if someone is interested in the prelimary makefiles these are also in same folder. Gün.
Re: undefined behaviour from apr_pollset_create
On Wed, Aug 04, 2010 at 02:17:04PM +, Carlo Marcelo Arenas Belon wrote: apr_pollset_create in apr 0.9 used to keep that pointer unchanged (NULL) for that case and by looking at the code/behaviour from newer versions it would seem that it gets allocated an apr_pollset_t* always, resulting on an application bug, where an infinite loop was created while polling repeatedly and empty pollset. after further investigation this resulted to be a wrong assumption on my part, the pollset pointer inside the opaque apr_pollset_t structure is indeed NULL in 0.9, but considering that it is opaque anyway, its status shouldn't matter and therefore this should be instead considered just as undocumented behaviour then. Carlo
