Re: Making Subversion folks APR committers?
On 4/9/2010 9:21 PM, Hyrum K. Wright wrote: Speaking as one of the Subversion committers in question, I tend to agree with this sentiment. It really doesn't make much sense to grandfather an entire group of people into the project: just because somebody knows and understands the Subversion community, doesn't mean the same holds true for APR. (That being said, it makes sense to perhaps take their history with Subversion, as well as other Apache projects, into account when discussing commit access proposals.) +1; APR was seeded by committership in httpd and/or svn back in the day, so the projects already have a very strong affinity in terms of style, quality and expectations of committers.
Re: Making Subversion folks APR committers?
On Thu, Apr 8, 2010 at 4:43 PM, Sander Temme san...@temme.net wrote: On Apr 8, 2010, at 5:15 AM, William A. Rowe Jr. wrote: On 4/7/2010 8:56 PM, Bojan Smojver wrote: On Thu, 2010-04-08 at 00:37 +0100, Nick Kew wrote: Who do you have in mind, or are you suggesting a blanket commit? For instance, Hyrum K. Wright submitted a patch for apr_hash and asked about it a few times. My understanding is that he's a Subversion committer. Instead of him waiting for some of us to do it, we can just make him a committer here. When other Subversion folks submit patches, we can then do the same. It would help APR move along quicker, I guess... We can, and actually Hyrum would be a fine choice. But as an en masse thing? Even Subversion graduates their committers into different levels of trust, just as httpd does. I think we can ask for and expect some quality patches before adding them to the apr ldap commit group. If it were up to me, I'd favor giving commit on the basis of merit and demonstrated involvement, just like anyone else. Speaking as one of the Subversion committers in question, I tend to agree with this sentiment. It really doesn't make much sense to grandfather an entire group of people into the project: just because somebody knows and understands the Subversion community, doesn't mean the same holds true for APR. (That being said, it makes sense to perhaps take their history with Subversion, as well as other Apache projects, into account when discussing commit access proposals.) -Hyrum
Re: Making Subversion folks APR committers?
On 4/7/2010 8:56 PM, Bojan Smojver wrote: On Thu, 2010-04-08 at 00:37 +0100, Nick Kew wrote: Who do you have in mind, or are you suggesting a blanket commit? For instance, Hyrum K. Wright submitted a patch for apr_hash and asked about it a few times. My understanding is that he's a Subversion committer. Instead of him waiting for some of us to do it, we can just make him a committer here. When other Subversion folks submit patches, we can then do the same. It would help APR move along quicker, I guess... We can, and actually Hyrum would be a fine choice. But as an en masse thing? Even Subversion graduates their committers into different levels of trust, just as httpd does. I think we can ask for and expect some quality patches before adding them to the apr ldap commit group.
Re: Making Subversion folks APR committers?
On Apr 8, 2010, at 5:15 AM, William A. Rowe Jr. wrote: On 4/7/2010 8:56 PM, Bojan Smojver wrote: On Thu, 2010-04-08 at 00:37 +0100, Nick Kew wrote: Who do you have in mind, or are you suggesting a blanket commit? For instance, Hyrum K. Wright submitted a patch for apr_hash and asked about it a few times. My understanding is that he's a Subversion committer. Instead of him waiting for some of us to do it, we can just make him a committer here. When other Subversion folks submit patches, we can then do the same. It would help APR move along quicker, I guess... We can, and actually Hyrum would be a fine choice. But as an en masse thing? Even Subversion graduates their committers into different levels of trust, just as httpd does. I think we can ask for and expect some quality patches before adding them to the apr ldap commit group. If it were up to me, I'd favor giving commit on the basis of merit and demonstrated involvement, just like anyone else. S. -- san...@temme.net http://www.temme.net/sander/ PGP FP: 51B4 8727 466A 0BC3 69F4 B7B8 B2BE BC40 1529 24AF
Re: Making Subversion folks APR committers?
On 7 Apr 2010, at 23:58, Bojan Smojver wrote: Now that Subversion is an Apache project, I think it would be great if we could make folks from that project committers on APR, so that they can improve the code at will. Does that sound reasonable? Who do you have in mind, or are you suggesting a blanket commit? If the latter, then why should HTTPD be different? Don't we already have significant overlap with both APR-user projects, precisely because of the natural overlaps in developer interests? -- Nick Kew
Re: Making Subversion folks APR committers?
On Thu, 2010-04-08 at 00:37 +0100, Nick Kew wrote: Who do you have in mind, or are you suggesting a blanket commit? For instance, Hyrum K. Wright submitted a patch for apr_hash and asked about it a few times. My understanding is that he's a Subversion committer. Instead of him waiting for some of us to do it, we can just make him a committer here. When other Subversion folks submit patches, we can then do the same. It would help APR move along quicker, I guess... -- Bojan
