Re: svn commit: r1902219 - in /apr/apr/branches/1.8.x: ./ test/testlock.c

[Yann Ylavic]

On Sat, Jun 25, 2022 at 6:34 PM Christophe JAILLET
 wrote:
>
> Le 24/06/2022 à 11:06, yla...@apache.org a écrit :
> >
> > --- apr/apr/branches/1.8.x/test/testlock.c (original)
> > +++ apr/apr/branches/1.8.x/test/testlock.c Fri Jun 24 09:06:05 2022
> > @@ -111,6 +111,7 @@ static void *APR_THREAD_FUNC thread_mute
> >   break;
> >   }
> >   return NULL;
> > +return NULL;
>
> ???

Just in case :)
Fixed in r1902254, thanks.

Regards;
Yann.

Re: svn commit: r1902219 - in /apr/apr/branches/1.8.x: ./ test/testlock.c

[Christophe JAILLET]

Le 24/06/2022 à 11:06, yla...@apache.org a écrit :

Author: ylavic
Date: Fri Jun 24 09:06:05 2022
New Revision: 1902219

URL: http://svn.apache.org/viewvc?rev=1902219=rev
Log:
test/testlock: Fix -Werror=return-type

* test/testlock.c(thread_mutex_function,
   thread_mutex_sleep_function):
   Thread (APR_THREAD_FUNC) functions should return a pointer (NULL).


Merge r1902181 from trunk.
Submitted by: ylavic

Modified:
 apr/apr/branches/1.8.x/   (props changed)
 apr/apr/branches/1.8.x/test/testlock.c

Propchange: apr/apr/branches/1.8.x/
--
   Merged /apr/apr/trunk:r1902181

Modified: apr/apr/branches/1.8.x/test/testlock.c
URL: 
http://svn.apache.org/viewvc/apr/apr/branches/1.8.x/test/testlock.c?rev=1902219=1902218=1902219=diff
==
--- apr/apr/branches/1.8.x/test/testlock.c (original)
+++ apr/apr/branches/1.8.x/test/testlock.c Fri Jun 24 09:06:05 2022
@@ -111,6 +111,7 @@ static void *APR_THREAD_FUNC thread_mute
  break;
  }
  return NULL;
+return NULL;


???


  }
  
  /* Sleepy-loop until f_ value matches val: */

@@ -139,6 +140,7 @@ static void *APR_THREAD_FUNC thread_mute
  rv = apr_thread_mutex_unlock(timeout_mutex);
  
  apr_thread_exit(thd, APR_SUCCESS);

+return NULL;
  }
  
  static void *APR_THREAD_FUNC thread_cond_producer(apr_thread_t *thd, void *data)