get_attribute function not supporting SELF as

2017-12-04 Thread Vaishali Krishnamurthy
Hi,

We have observed the attribute resolution is not proper when we use SELF as
 in  get_attribute function and it works fine when
we use the node name as  .  With SELF it takes the
default value. Could you confirm if there is any fix for this issue ?


Regards,

Vaishali


Apache ARIA TOSCA Weekly Grooming Meeting Notes - 4th Dec '17

2017-12-04 Thread Arthur Berezin
ARIA Grooming Meeting notes:

Attendees:Apache ARIA TOSCA Weekly Grooming Meeting

Tom, Ido, Tal, Arthur, Miguel, Avia, Maxim, Guy

Meeting Notes:

   1.

   Done with GitBox integration.
   2.

   Update the website with the gitbox process
   3.

   Tal closed ARIA-1 which is adding a lot of test permutations
   4.

   Adding ARIA-422 Fix a bug in CSAR creation process is in 0.2.0
   5.

   Planning to start voting on 0.2.0 ASF tomorrow EOD
   6.

   Potential items to pick up for 0.3:
   1.

  ARIA Configurations mechanism
  2.

  Gaps to complete TOSCA Simple Profile 1.0
  1.

 Requirements and Capabilities
 2.

 Artifacts
 3.

  Support for TOSCA simple profile 1.2
  4.

  Support for node agents
  5.

  ARIA native plugins
  7.

   We agreed on 3 Sprints per release, 2 weeks per sprint.
   8.

   Miguel wants to take ARIA-419, finished ARIA-420, will create a PR on
   GitHub


[GitHub] jachinte opened a new pull request #6: ARIA-420: update community.md

2017-12-04 Thread GitBox
jachinte opened a new pull request #6: ARIA-420: update community.md
URL: https://github.com/apache/incubator-ariatosca-website/pull/6
 
 
   Explain how to gain writing permissions on JIRA and Confluence, and how to 
join the slack channel.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #214: ARIA-422 Parsing CSARs is broken

2017-12-04 Thread GitBox
asfgit commented on issue #214: ARIA-422 Parsing CSARs is broken
URL: 
https://github.com/apache/incubator-ariatosca/pull/214#issuecomment-349009666
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mxmrlv opened a new pull request #214: ARIA-422 Parsing CSARs is broken

2017-12-04 Thread GitBox
mxmrlv opened a new pull request #214: ARIA-422 Parsing CSARs is broken
URL: https://github.com/apache/incubator-ariatosca/pull/214
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


grooming Zoom

2017-12-04 Thread Thomas Nadeau
https://cloudify.zoom.us/j/5055197842


[GitHub] tnadeauaria closed pull request #5: ARIA-415 Add git installation instructions to GettingStarted Guide

2017-12-04 Thread GitBox
tnadeauaria closed pull request #5: ARIA-415 Add git installation instructions 
to GettingStarted Guide
URL: https://github.com/apache/incubator-ariatosca-website/pull/5
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/gettingstarted.md b/gettingstarted.md
index 5a02dfb..196e874 100644
--- a/gettingstarted.md
+++ b/gettingstarted.md
@@ -5,28 +5,39 @@ permalink: /getting-started/
 share: false
 ---
 
-Installation
-
+There are multiple ways of installing and running ARIA TOSCA. Specifically, 
there
+essentially two different branches of installations: user and developer. Both
+are documented below.
 
-ARIA is [available on PyPI](https://pypi.python.org/pypi/apache-ariatosca).
+While the instructions below strive to be complete, we're human and make 
mistakes from time to time. In situations where something doesn't work as 
described, do not hesitate to reach out to the community for assistance by 
sending email to dev@ariatosca.incubator.apache.org
 
-ARIA requires Python 2.6/2.7. Python 3 is currently not supported.
 
-To install ARIA directly from PyPI (using a ``wheel``), use::
+Package-Based PIP Package Installation
+--
+
+ARIA TOSCA is [available on 
PyPI](https://pypi.python.org/pypi/apache-ariatosca).
+
+ARIA TOSCA requires Python 2.6/2.7. Python 3 is currently not supported.
+
+To install ARIA TOSCA directly from PyPI (using a ``wheel``), use::
 
 pip install --upgrade pip setuptools
 pip install apache-ariatosca
 
-To install ARIA from source, download the source tarball from
+
+Source-based PIP Package Installation
+-
+
+To install ARIA TOSCA from source, download the source tarball from
 [PyPI](https://pypi.python.org/pypi/apache-ariatosca), extract and ``cd`` into 
the extract dir, and run::
 
 pip install --upgrade pip setuptools
 pip install .
 
-| The source package comes along with relevant examples, documentation, 
``requirements.txt`` (for installing specifically the frozen dependencies' 
versions with which ARIA was tested) and more.
+| The source package comes along with relevant examples, documentation, 
``requirements.txt`` (for installing specifically the frozen dependencies' 
versions with which ARIA TOSCA was tested) and more.
 |
 |
-| ARIA has additional optional dependencies. These are required for running 
operations over SSH.
+| ARIA TOSCA has additional optional dependencies. These are required for 
running operations over SSH.
 | Below are instructions on how to install these dependencies, including 
required system dependencies per OS.
 |
 | Note: These dependencies may have varying licenses which may not be 
compatible with Apache license 2.0.
@@ -34,12 +45,12 @@ To install ARIA from source, download the source tarball 
from
 
 **Ubuntu/Debian** (tested on Ubuntu14.04, Ubuntu16.04)::
 
-apt-get install -y python-dev gcc libffi-dev libssl-dev
+apt-get install -y python-dev gcc libffi-dev libssl-dev 
 pip install apache-ariatosca[ssh]
 
 **Centos** (tested on Centos6.6, Centos7)::
 
-yum install -y python-devel gcc libffi-devel openssl-devel
+yum install -y python-devel gcc libffi-devel openssl-devel 
 pip install apache-ariatosca[ssh]
 
 **Archlinux**::
@@ -57,24 +68,63 @@ To install ARIA from source, download the source tarball 
from
 # TODO
 
 
-
 To install ``pip``, either use your distro's package management system, or 
run::
 
 wget http://bootstrap.pypa.io/get-pip.py
 python get-pip.py
 
 
+Developer Installation
+--
+
+Developers will want to pull their base code from github and then
+build from that locally. Note there are two code repositories for
+ARIA TOSCA: one for the website and one for the main code base. Instructions
+for pulling and running each are detailed below. 
+
+
+**Ubuntu/Debian** (tested on Ubuntu14.04, Ubuntu16.04):
+
+apt-get install -y python-dev gcc libffi-dev libssl-dev git
+
+# In addition to the above, install the following for website development
+sudo apt-get install ruby-dev
+sudo gem install jekyll bundler
+# you may have to install jekyll's dependancies 
+bundle install
+
+**Centos** (tested on Centos6.6, Centos7):
+
+yum install -y python-devel gcc libffi-devel openssl-devel 
+
+# In addition to the above, install the following for website development
+sudo yum install ruby-dev
+sudo gem install jekyll bundler
+# you may have to install jekyll's dependancies 
+bundle install
+
+**Building from your pulled code** :
+
+Instructions are 
[here](https://cwiki.apache.org/confluence/display/ARIATOSCA/Contributing+Code)
+
+
+Running The Generated Website
+-
+
+The website is 

Re: ARIA-118 plugin.yaml importing

2017-12-04 Thread Tal Liron
Sorry, but I don't think we did a thorough review yet. However, feel free
to rebase on master and push it again to ensure that the CI tests pass.

On Mon, Dec 4, 2017 at 2:48 PM, Thomas Nadeau  wrote:

> BTW I noticed that the Travis CI failed for your PR earlier. Tal and I
> discussed and he thinks this might be fixed with a rebase now that ARIA-1
> has been pushed.  You can test this theory for yourself by rebasing your
> branch.
>
> --Tom
>
>
> On Mon, Dec 4, 2017 at 12:31 PM, D Jayachandran <
> d.jayachand...@ericsson.com
> > wrote:
>
> > Thanks Thomas, I made the PR now.
> >
> > -Original Message-
> > From: Thomas Nadeau [mailto:tnad...@apache.org]
> > Sent: Monday, December 04, 2017 1:07 PM
> > To: dev@ariatosca.incubator.apache.org
> > Subject: Re: ARIA-118 plugin.yaml importing
> >
> > Nothing has changed for non-committers; use the canonical GitHub
> fork->push
> > patches->propose patch request method
> > on the same two GitHub repos:
> >
> > https://github.com/apache/incubator-ariatosca-website
> >
> > and
> >
> > https://github.com/apache/incubator-ariatosca
> >
> > I’ll be on slack from now too if you need additional help.
> >
> > —Tom
> >
> >
> > On Dec 4, 2017, at 8:28 AM, D Jayachandran 
> > wrote:
> >
> > Hi,
> >
> > I need to contribute for this JIRA item. Previously I had made my
> > contribution by forking from the apache-ariatosca project.
> > Is the process changed now ? What is the process which I should follow
> now
> > ?
> >
> >
> > Regards,
> > DJ
> >
>


[GitHub] aviyoop closed pull request #211: ARIA-417 Encoding models to json is too strict

2017-12-04 Thread GitBox
aviyoop closed pull request #211: ARIA-417 Encoding models to json is too strict
URL: https://github.com/apache/incubator-ariatosca/pull/211
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] aviyoop closed pull request #209: ARIA-414 Current events handler mechanism relies on sqlalchemy

2017-12-04 Thread GitBox
aviyoop closed pull request #209: ARIA-414 Current events handler mechanism 
relies on sqlalchemy
URL: https://github.com/apache/incubator-ariatosca/pull/209
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] vishwanathj closed pull request #213: ARIA-399: Sample Dockerfile and docker-compose.yaml file that installs/runs ARIA

2017-12-04 Thread GitBox
vishwanathj closed pull request #213: ARIA-399: Sample Dockerfile and 
docker-compose.yaml file that installs/runs ARIA
URL: https://github.com/apache/incubator-ariatosca/pull/213
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/examples/docker/ubuntu1604/Dockerfile 
b/examples/docker/ubuntu1604/Dockerfile
new file mode 100644
index ..e2795f82
--- /dev/null
+++ b/examples/docker/ubuntu1604/Dockerfile
@@ -0,0 +1,26 @@
+FROM ubuntu:16.04
+
+#COMMAND TO BUILD THE IMAGE ==> docker build --build-arg ARIA_VER=0.1.1 
--build-arg GTAG_VER=0.1.1 -t aria_011:16.04 .
+ARG ARIA_VER=0.1.1
+ARG GTAG_VER=0.1.1
+
+RUN apt-get update && apt-get install -y \
+python-dev \
+gcc \
+libffi-dev \
+libssl-dev \
+python-pip \
+git \
+wget
+
+RUN pip install --upgrade pip setuptools
+
+RUN pip install apache-ariatosca[ssh]==$ARIA_VER apache-ariatosca
+
+WORKDIR /tmp
+
+RUN git clone https://github.com/apache/incubator-ariatosca.git 
/tmp/incubator-ariatosca
+
+WORKDIR /tmp/incubator-ariatosca
+
+RUN git checkout tags/$GTAG_VER
\ No newline at end of file
diff --git a/examples/docker/ubuntu1604/README.md 
b/examples/docker/ubuntu1604/README.md
new file mode 100644
index ..49734c79
--- /dev/null
+++ b/examples/docker/ubuntu1604/README.md
@@ -0,0 +1,25 @@
+1. The Dockefile is used to build the Docker image of ARIA for Ubuntu 16.04.
+   Below is a sample command to build the ARIA 0.1.1 docker image:
+   
+   'docker build --build-arg ARIA_VER=0.1.1 --build-arg GTAG_VER=0.1.1 -t 
aria_011:7 .'
+   
+   NOTE: The build command has to be executed from the location where the 
Dockerfile resides.
+   
+2. The docker-compose file executes the below commands in the 'Getting 
Started' page on
+   ARIA website:
+   
+   a. aria service-templates store examples/hello-world/helloworld.yaml 
my-service-template
+   
+   b. aria services create my-service -t my-service-template
+   
+   c. aria executions start install -s my-service
+   
+   NOTE 1: The value for 'image' in the docker-compose file needs to match the 
image you plan to use.
+   
+   NOTE 2: The command to run docker-compose is "docker-compose up -d" from 
the location where docker-compose file resides.
+   
+   You can check if the docker-compose ran successfully by executing the 
command 'docker-compose ps'
+   
+   You can also verify that aria executed the commands by launching a web 
browser with http://localhost:29090
+   
+   
\ No newline at end of file
diff --git a/examples/docker/ubuntu1604/docker-compose.yaml 
b/examples/docker/ubuntu1604/docker-compose.yaml
new file mode 100644
index ..0ee08057
--- /dev/null
+++ b/examples/docker/ubuntu1604/docker-compose.yaml
@@ -0,0 +1,11 @@
+version: "3"
+services:
+  aria:
+#Make sure to provide the right value for image field below and uncomment 
the below line
+#image: vishwanathj/aria_011:16.04
+hostname: aria
+ports:
+  - "29090:9090"
+stdin_open: true
+tty: true
+command: sh -c "aria service-templates store 
examples/hello-world/helloworld.yaml my-service-template && sleep 2 && aria 
services create my-service -t my-service-template && sleep 2 && aria executions 
start install -s my-service && bash"
\ No newline at end of file


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] vishwanathj commented on issue #213: ARIA-399: Sample Dockerfile and docker-compose.yaml file that installs/runs ARIA

2017-12-04 Thread GitBox
vishwanathj commented on issue #213: ARIA-399: Sample Dockerfile and 
docker-compose.yaml file that installs/runs ARIA
URL: 
https://github.com/apache/incubator-ariatosca/pull/213#issuecomment-348966598
 
 
   Tal, 
   Appreciate your valuable feedback.
   Would creating a docker-examples similar to tosca-examples at 
https://cwiki.apache.org/confluence/display/ARIATOSCA/TOSCA+Examples work?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: ARIA-118 plugin.yaml importing

2017-12-04 Thread Thomas Nadeau
BTW I noticed that the Travis CI failed for your PR earlier. Tal and I
discussed and he thinks this might be fixed with a rebase now that ARIA-1
has been pushed.  You can test this theory for yourself by rebasing your
branch.

--Tom


On Mon, Dec 4, 2017 at 12:31 PM, D Jayachandran  wrote:

> Thanks Thomas, I made the PR now.
>
> -Original Message-
> From: Thomas Nadeau [mailto:tnad...@apache.org]
> Sent: Monday, December 04, 2017 1:07 PM
> To: dev@ariatosca.incubator.apache.org
> Subject: Re: ARIA-118 plugin.yaml importing
>
> Nothing has changed for non-committers; use the canonical GitHub fork->push
> patches->propose patch request method
> on the same two GitHub repos:
>
> https://github.com/apache/incubator-ariatosca-website
>
> and
>
> https://github.com/apache/incubator-ariatosca
>
> I’ll be on slack from now too if you need additional help.
>
> —Tom
>
>
> On Dec 4, 2017, at 8:28 AM, D Jayachandran 
> wrote:
>
> Hi,
>
> I need to contribute for this JIRA item. Previously I had made my
> contribution by forking from the apache-ariatosca project.
> Is the process changed now ? What is the process which I should follow now
> ?
>
>
> Regards,
> DJ
>


[GitHub] mxmrlv opened a new pull request #209: ARIA-414 Current events handler mechanism relies on sqlalchemy

2017-12-04 Thread GitBox
mxmrlv opened a new pull request #209: ARIA-414 Current events handler 
mechanism relies on sqlalchemy
URL: https://github.com/apache/incubator-ariatosca/pull/209
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #209: ARIA-414 Current events handler mechanism relies on sqlalchemy

2017-12-04 Thread GitBox
asfgit commented on issue #209: ARIA-414 Current events handler mechanism 
relies on sqlalchemy
URL: 
https://github.com/apache/incubator-ariatosca/pull/209#issuecomment-348940999
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] aviyoop closed pull request #209: ARIA-414 Current events handler mechanism relies on sqlalchemy

2017-12-04 Thread GitBox
aviyoop closed pull request #209: ARIA-414 Current events handler mechanism 
relies on sqlalchemy
URL: https://github.com/apache/incubator-ariatosca/pull/209
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


AriaTosca Team grooming meeting invite

2017-12-04 Thread Thomas Nadeau
https://calendar.google.com/event?action=TEMPLATE=NmttcGFpMDU5azE5c3I0c2ZqM3JiaTl2NG5fMjAxNzEyMDRUMTYwMDAwWiB0bmFkZWF1QGNsb3VkaWZ5LmNv=tnadeau%40cloudify.co=ALL


Re: ARIA-118 plugin.yaml importing

2017-12-04 Thread Thomas Nadeau
Got it.  Avia and Tal reviewed and it looked good. Will get merged soon.

—Tom


> On Dec 4, 2017, at 12:31 PM, D Jayachandran  
> wrote:
> 
> Thanks Thomas, I made the PR now.
> 
> -Original Message-
> From: Thomas Nadeau [mailto:tnad...@apache.org] 
> Sent: Monday, December 04, 2017 1:07 PM
> To: dev@ariatosca.incubator.apache.org
> Subject: Re: ARIA-118 plugin.yaml importing
> 
> Nothing has changed for non-committers; use the canonical GitHub fork->push
> patches->propose patch request method
> on the same two GitHub repos:
> 
> https://github.com/apache/incubator-ariatosca-website
> 
> and
> 
> https://github.com/apache/incubator-ariatosca
> 
> I’ll be on slack from now too if you need additional help.
> 
> —Tom
> 
> 
> On Dec 4, 2017, at 8:28 AM, D Jayachandran 
> wrote:
> 
> Hi,
> 
> I need to contribute for this JIRA item. Previously I had made my 
> contribution by forking from the apache-ariatosca project.
> Is the process changed now ? What is the process which I should follow now ?
> 
> 
> Regards,
> DJ



[GitHub] aviyoop commented on a change in pull request #209: ARIA-414 Current events handler mechanism relies on sqlalchemy

2017-12-04 Thread GitBox
aviyoop commented on a change in pull request #209: ARIA-414 Current events 
handler mechanism relies on sqlalchemy
URL: 
https://github.com/apache/incubator-ariatosca/pull/209#discussion_r154609888
 
 

 ##
 File path: tests/orchestrator/workflows/executor/test_executor.py
 ##
 @@ -28,45 +28,48 @@
 import aria
 from aria.modeling import models
 from aria.orchestrator import events
+from aria.orchestrator.workflows.core import events_handler
 from aria.orchestrator.workflows.executor import (
 thread,
 process,
 # celery
 )
 
 import tests
+from .. import helpers
 from . import MockContext
 
 
+
 
 Review comment:
   remove (if this is not the only change)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


RE: ARIA-118 plugin.yaml importing

2017-12-04 Thread D Jayachandran
Thanks Thomas, I made the PR now.

-Original Message-
From: Thomas Nadeau [mailto:tnad...@apache.org] 
Sent: Monday, December 04, 2017 1:07 PM
To: dev@ariatosca.incubator.apache.org
Subject: Re: ARIA-118 plugin.yaml importing

Nothing has changed for non-committers; use the canonical GitHub fork->push
patches->propose patch request method
on the same two GitHub repos:

https://github.com/apache/incubator-ariatosca-website

and

https://github.com/apache/incubator-ariatosca

I’ll be on slack from now too if you need additional help.

—Tom


On Dec 4, 2017, at 8:28 AM, D Jayachandran 
wrote:

Hi,

I need to contribute for this JIRA item. Previously I had made my contribution 
by forking from the apache-ariatosca project.
Is the process changed now ? What is the process which I should follow now ?


Regards,
DJ


[GitHub] tliron closed pull request #207: ARIA-1 Parser test suite

2017-12-04 Thread GitBox
tliron closed pull request #207: ARIA-1 Parser test suite
URL: https://github.com/apache/incubator-ariatosca/pull/207
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tliron commented on issue #213: ARIA-399: Sample Dockerfile and docker-compose.yaml file that installs/runs ARIA

2017-12-04 Thread GitBox
tliron commented on issue #213: ARIA-399: Sample Dockerfile and 
docker-compose.yaml file that installs/runs ARIA
URL: 
https://github.com/apache/incubator-ariatosca/pull/213#issuecomment-348908289
 
 
   Thank you for this contribution. In my opinion it would be better to share 
these files on the wiki. This is not a TOSCA example, so it definitely doesn't 
belong in our examples dir. And I think generally it's more about how to 
package/deploy ARIA, which should be part of the instructions on the wiki.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] aviyoop commented on a change in pull request #210: ARIA-416 Providing handlers to logging_handlers only adds handles inst?

2017-12-04 Thread GitBox
aviyoop commented on a change in pull request #210: ARIA-416 Providing handlers 
to logging_handlers only adds handles inst?
URL: 
https://github.com/apache/incubator-ariatosca/pull/210#discussion_r154592494
 
 

 ##
 File path: aria/orchestrator/context/common.py
 ##
 @@ -115,14 +115,19 @@ def __repr__(self):
 
 @contextmanager
 def logging_handlers(self, handlers=None):
+original_handlers = self.logger.handlers
 handlers = handlers or []
 try:
 for handler in handlers:
 self.logger.addHandler(handler)
+for handler in original_handlers:
+self.logger.removeHandler(handler)
 yield self.logger
 finally:
 for handler in handlers:
 
 Review comment:
   To prevent the original handlers from being duplicated, you should first (in 
the `finally` block) empty the logger from handlers, and then add the original 
handlers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] aviyoop commented on a change in pull request #210: ARIA-416 Providing handlers to logging_handlers only adds handles inst?

2017-12-04 Thread GitBox
aviyoop commented on a change in pull request #210: ARIA-416 Providing handlers 
to logging_handlers only adds handles inst?
URL: 
https://github.com/apache/incubator-ariatosca/pull/210#discussion_r154590889
 
 

 ##
 File path: aria/orchestrator/context/common.py
 ##
 @@ -115,14 +115,19 @@ def __repr__(self):
 
 @contextmanager
 def logging_handlers(self, handlers=None):
 
 Review comment:
   why would you call this context manager without providing handlers?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] vishwanathj opened a new pull request #213: ARIA-399: Sample Dockerfile and docker-compose.yaml file that installs/runs ARIA

2017-12-04 Thread GitBox
vishwanathj opened a new pull request #213: ARIA-399: Sample Dockerfile and 
docker-compose.yaml file that installs/runs ARIA
URL: https://github.com/apache/incubator-ariatosca/pull/213
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #213: ARIA-399: Sample Dockerfile and docker-compose.yaml file that installs/runs ARIA

2017-12-04 Thread GitBox
asfgit commented on issue #213: ARIA-399: Sample Dockerfile and 
docker-compose.yaml file that installs/runs ARIA
URL: 
https://github.com/apache/incubator-ariatosca/pull/213#issuecomment-348900226
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services