[GitHub] incubator-ariatosca pull request #25: CLI commands for parser

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-ariatosca/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #25: CLI commands for parser

[dankilman]

Github user dankilman commented on a diff in the pull request:

https://github.com/apache/incubator-ariatosca/pull/25#discussion_r88400885
  
--- Diff: README.md ---
@@ -1,4 +1,193 @@
-Aria
+ARIA
 
 
-See http://ariatosca.org/
+[ARIA](http://ariatosca.org/) is a minimal TOSCA orchestrator, as well as 
a platform for building
+TOSCA-based products. Its features can be accessed via a well-documented 
Python API, as well as a
--- End diff --

no language-agnostic RESTful API for now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #25: CLI commands for parser

[dankilman]

Github user dankilman commented on a diff in the pull request:

https://github.com/apache/incubator-ariatosca/pull/25#discussion_r88400659
  
--- Diff: aria/cli/cli.py ---
@@ -44,6 +46,7 @@ def __init__(self, *args, **kwargs):
 self.commands = {
 'init': InitCommand.with_logger(base_logger=self.logger),
 'execute': ExecuteCommand.with_logger(base_logger=self.logger),
+'parse': ParseCommand.with_logger(base_logger=self.logger),
--- End diff --

why did you decide to leave out `spec`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #25: CLI commands for parser

[dankilman]

Github user dankilman commented on a diff in the pull request:

https://github.com/apache/incubator-ariatosca/pull/25#discussion_r88400526
  
--- Diff: aria/cli/commands.py ---
@@ -164,10 +162,11 @@ def _workspace_setup(self):
 return local_storage()
 
 def _parse_blueprint(self, blueprint_path, inputs=None):
-plan = parse_from_path(blueprint_path)
-self.logger.info('blueprint parsed successfully')
-deployment_plan = prepare_deployment_plan(plan=plan.copy(), 
inputs=inputs)
-return plan, deployment_plan
+#plan = parse_from_path(blueprint_path)
--- End diff --

can we implement this functionality using the new parser? if not, let's 
remove the commented lines


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #25: CLI commands for parser

[tliron]

GitHub user tliron opened a pull request:

https://github.com/apache/incubator-ariatosca/pull/25

CLI commands for parser

Also includes some fixed to TOSCA extension.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tliron/incubator-ariatosca 
ARIATOSCA-22-cli-commands-for-parser

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-ariatosca/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #25


commit 6c8345d7ed56a46d1414a3879c1b122a3c529749
Author: Tal Liron 
Date:   2016-11-16T22:05:39Z

CLI commands for parser




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---