[jira] [Commented] (ARIES-1368) Fragment resources receive the osgi.identity capability type of osgi.bundle but should receive osgi.fragment. Also, osgi.wiring.host capabilities and requirements are n
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698238#comment-14698238 ] Tom De Wolf commented on ARIES-1368: John, In your commit at https://github.com/apache/aries/commit/8ad6b99df1fd22d8d89aae9d53975dd634215e74#diff-71f7b1ba9fdbe73d19d4343685d7acad I put a comment on a line which seems strange. As a fragment host requirement has to match with a bundle with identity equal to the host specified in the fragment's manifest I find it strange that a bundleResource has a fragmentHostCapability given when it itself has the Fragment-Host manifest header? A host does not have any header making it a fragment host. Only the fragment itself has a Fragment-Host header. Or am I missing something? Is it not more logical that a fragment host requirement matches to an osgi.identity capability of a bundle matching the name of the fragment host required? Fragment resources receive the osgi.identity capability type of osgi.bundle but should receive osgi.fragment. Also, osgi.wiring.host capabilities and requirements are not computed for bundle or fragment resources. - Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.0.0, subsystem-core-1.1.0, subsystem-core-1.2.0, subsystem-2.0.1, subsystem-2.0.2 Reporter: Wouter Bancken Assignee: John Ross Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg, org.apache.aries.subsystem.core.patch, org.apache.aries.subsystem.itests.patch, test-service-fragment-subsystem-1.0.1-SNAPSHOT.esa The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (ARIES-1368) Fragment resources receive the osgi.identity capability type of osgi.bundle but should receive osgi.fragment. Also, osgi.wiring.host capabilities and requir
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom De Wolf updated ARIES-1368: --- Comment: was deleted (was: John, In your commit at https://github.com/apache/aries/commit/8ad6b99df1fd22d8d89aae9d53975dd634215e74#diff-71f7b1ba9fdbe73d19d4343685d7acad I put a comment on a line which seems strange. As a fragment host requirement has to match with a bundle with identity equal to the host specified in the fragment's manifest I find it strange that a bundleResource has a fragmentHostCapability given when it itself has the Fragment-Host manifest header? A host does not have any header making it a fragment host. Only the fragment itself has a Fragment-Host header. Or am I missing something? Is it not more logical that a fragment host requirement matches to an osgi.identity capability of a bundle matching the name of the fragment host required?) Fragment resources receive the osgi.identity capability type of osgi.bundle but should receive osgi.fragment. Also, osgi.wiring.host capabilities and requirements are not computed for bundle or fragment resources. - Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.0.0, subsystem-core-1.1.0, subsystem-core-1.2.0, subsystem-2.0.1, subsystem-2.0.2 Reporter: Wouter Bancken Assignee: John Ross Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg, org.apache.aries.subsystem.core.patch, org.apache.aries.subsystem.itests.patch, test-service-fragment-subsystem-1.0.1-SNAPSHOT.esa The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
