[jira] [Commented] (ARIES-1437) Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.

[David Bosschaert (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARIES-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990517#comment-14990517
 ] 

David Bosschaert commented on ARIES-1437:
-

Actually, I just kicked off the release process: 
http://aries.15396.n3.nabble.com/VOTE-Release-SPI-Fly-1-0-6-td4031882.html

> Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.
> -
>
> Key: ARIES-1437
> URL: https://issues.apache.org/jira/browse/ARIES-1437
> Project: Aries
>  Issue Type: Bug
>  Components: SPI Fly
>Affects Versions: spifly-1.0.2
>Reporter: Romain Gilles
>Assignee: David Bosschaert
> Fix For: spifly-1.0.6
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If weaving code use Java 8 specific language features you will end-up with 
> this kind of exception:
> {code:java}
> Caused by: java.lang.IllegalArgumentException: INVOKESPECIAL/STATIC on 
> interfaces require ASM 5
> at org.objectweb.asm.MethodVisitor.visitMethodInsn(Unknown Source)
> at org.objectweb.asm.ClassReader.a(Unknown Source)
> at org.objectweb.asm.ClassReader.b(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at 
> org.apache.aries.spifly.dynamic.ClientWeavingHook.weave(ClientWeavingHook.java:61)
> {code}
> I provide a pull request in order to solve it:
> [https://github.com/apache/aries/pull/29]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release SPI-Fly 1.0.6

[davidb]

Here's my +1

David

On 4 November 2015 at 22:50,   wrote:
> Hi all,
>
> I'm calling a vote on SPI-Fly 1.0.6.
>
> The following bug has been fixed:
> ARIES-1437 Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor 
> api.
>
> This release includes the following modules:
>
> spi-fly-core
> spi-fly-dynamic-bundle
> spi-fly-examples
> spi-fly-static-bundle
> spi-fly-static-tool
> spi-fly-weaver
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachearies-1048
>
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://svn.apache.org/repos/asf/aries/scripts/verify_staged_release.sh
>
> Usage:
> sh verify_staged_release.sh 1048 tmpdir 2>&1 | tee verifyresults.txt
> grep FAIL verifyresults.txt
> grep ERROR verifyresults.txt
>
> More details on verifying the release here:
> http://aries.apache.org/development/verifyingrelease.html
>
> Please vote:
>  +1 Approve the release
>  -1 Do not approve the release (please explain why)
>
> This vote will be open for at least 72 hours.
>
> Best regards,
>
> David Bosschaert

[jira] [Updated] (ARIES-1437) Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARIES-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated ARIES-1437:

Fix Version/s: spifly-1.0.6

> Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.
> -
>
> Key: ARIES-1437
> URL: https://issues.apache.org/jira/browse/ARIES-1437
> Project: Aries
>  Issue Type: Bug
>  Components: SPI Fly
>Affects Versions: spifly-1.0.2
>Reporter: Romain Gilles
>Assignee: David Bosschaert
> Fix For: spifly-1.0.6
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If weaving code use Java 8 specific language features you will end-up with 
> this kind of exception:
> {code:java}
> Caused by: java.lang.IllegalArgumentException: INVOKESPECIAL/STATIC on 
> interfaces require ASM 5
> at org.objectweb.asm.MethodVisitor.visitMethodInsn(Unknown Source)
> at org.objectweb.asm.ClassReader.a(Unknown Source)
> at org.objectweb.asm.ClassReader.b(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at 
> org.apache.aries.spifly.dynamic.ClientWeavingHook.weave(ClientWeavingHook.java:61)
> {code}
> I provide a pull request in order to solve it:
> [https://github.com/apache/aries/pull/29]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[VOTE] Release SPI-Fly 1.0.6

[davidb]

Hi all,

I'm calling a vote on SPI-Fly 1.0.6.

The following bug has been fixed:
ARIES-1437 Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.

This release includes the following modules:

spi-fly-core
spi-fly-dynamic-bundle
spi-fly-examples
spi-fly-static-bundle
spi-fly-static-tool
spi-fly-weaver

Staging repository:
https://repository.apache.org/content/repositories/orgapachearies-1048

You can use this UNIX script to download the release and verify the signatures:
https://svn.apache.org/repos/asf/aries/scripts/verify_staged_release.sh

Usage:
sh verify_staged_release.sh 1048 tmpdir 2>&1 | tee verifyresults.txt
grep FAIL verifyresults.txt
grep ERROR verifyresults.txt

More details on verifying the release here:
http://aries.apache.org/development/verifyingrelease.html

Please vote:
 +1 Approve the release
 -1 Do not approve the release (please explain why)

This vote will be open for at least 72 hours.

Best regards,

David Bosschaert

[jira] [Comment Edited] (ARIES-1437) Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.

[Adam Juszkiewicz (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARIES-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990213#comment-14990213
 ] 

Adam Juszkiewicz edited comment on ARIES-1437 at 11/4/15 7:18 PM:
--

Hello,

[~bosschaert] - When is new SPI Fly version with this fix planned to be 
released? I am using Java8 and I am getting this exact exception so I am really 
interested in this fix :)

Regards,
Adam.


was (Author: ajuszkiewicz):
Hello,

[~bosschaert] - When isnew SPI Fly version with this fix planned to be 
released? I am using Java8 and I am getting this exact exception so I am really 
interested in this fix :)

Regards,
Adam.

> Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.
> -
>
> Key: ARIES-1437
> URL: https://issues.apache.org/jira/browse/ARIES-1437
> Project: Aries
>  Issue Type: Bug
>  Components: SPI Fly
>Affects Versions: spifly-1.0.2
>Reporter: Romain Gilles
>Assignee: David Bosschaert
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If weaving code use Java 8 specific language features you will end-up with 
> this kind of exception:
> {code:java}
> Caused by: java.lang.IllegalArgumentException: INVOKESPECIAL/STATIC on 
> interfaces require ASM 5
> at org.objectweb.asm.MethodVisitor.visitMethodInsn(Unknown Source)
> at org.objectweb.asm.ClassReader.a(Unknown Source)
> at org.objectweb.asm.ClassReader.b(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at 
> org.apache.aries.spifly.dynamic.ClientWeavingHook.weave(ClientWeavingHook.java:61)
> {code}
> I provide a pull request in order to solve it:
> [https://github.com/apache/aries/pull/29]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARIES-1437) Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.

[Adam Juszkiewicz (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARIES-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990213#comment-14990213
 ] 

Adam Juszkiewicz commented on ARIES-1437:
-

Hello,

[~bosschaert] - When isnew SPI Fly version with this fix planned to be 
released? I am using Java8 and I am getting this exact exception so I am really 
interested in this fix :)

Regards,
Adam.

> Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.
> -
>
> Key: ARIES-1437
> URL: https://issues.apache.org/jira/browse/ARIES-1437
> Project: Aries
>  Issue Type: Bug
>  Components: SPI Fly
>Affects Versions: spifly-1.0.2
>Reporter: Romain Gilles
>Assignee: David Bosschaert
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If weaving code use Java 8 specific language features you will end-up with 
> this kind of exception:
> {code:java}
> Caused by: java.lang.IllegalArgumentException: INVOKESPECIAL/STATIC on 
> interfaces require ASM 5
> at org.objectweb.asm.MethodVisitor.visitMethodInsn(Unknown Source)
> at org.objectweb.asm.ClassReader.a(Unknown Source)
> at org.objectweb.asm.ClassReader.b(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at 
> org.apache.aries.spifly.dynamic.ClientWeavingHook.weave(ClientWeavingHook.java:61)
> {code}
> I provide a pull request in order to solve it:
> [https://github.com/apache/aries/pull/29]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARIES-1437) Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.

[Romain Gilles (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARIES-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989131#comment-14989131
 ] 

Romain Gilles commented on ARIES-1437:
--

You're welcome

> Use ASM5 Opcodes instead of the ASM4 and implement ASM 5 visitor api.
> -
>
> Key: ARIES-1437
> URL: https://issues.apache.org/jira/browse/ARIES-1437
> Project: Aries
>  Issue Type: Bug
>  Components: SPI Fly
>Affects Versions: spifly-1.0.2
>Reporter: Romain Gilles
>Assignee: David Bosschaert
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If weaving code use Java 8 specific language features you will end-up with 
> this kind of exception:
> {code:java}
> Caused by: java.lang.IllegalArgumentException: INVOKESPECIAL/STATIC on 
> interfaces require ASM 5
> at org.objectweb.asm.MethodVisitor.visitMethodInsn(Unknown Source)
> at org.objectweb.asm.ClassReader.a(Unknown Source)
> at org.objectweb.asm.ClassReader.b(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at 
> org.apache.aries.spifly.dynamic.ClientWeavingHook.weave(ClientWeavingHook.java:61)
> {code}
> I provide a pull request in order to solve it:
> [https://github.com/apache/aries/pull/29]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)