[jira] [Resolved] (ARIES-1665) Initial contribution of implementation of OSGi RFC-193

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARIES-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved ARIES-1665.
-
Resolution: Fixed

Committed in the following commits with many thanks!

https://svn.apache.org/viewvc?view=revision=1780123
https://svn.apache.org/viewvc?view=revision=1780127

> Initial contribution of implementation of OSGi RFC-193
> --
>
> Key: ARIES-1665
> URL: https://issues.apache.org/jira/browse/ARIES-1665
> Project: Aries
>  Issue Type: New Feature
>Reporter: Raymond Augé
>Assignee: David Bosschaert
>
> This contribution will begin to implement *RFC-193 CDI Integration*
> https://github.com/osgi/design/blob/master/rfcs/rfc0193/rfc-0193-CDI-Integration.pdf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARIES-1665) Initial contribution of implementation of OSGi RFC-193

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARIES-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836898#comment-15836898
 ] 

ASF GitHub Bot commented on ARIES-1665:
---

Github user asfgit closed the pull request at:

https://github.com/apache/aries/pull/64


> Initial contribution of implementation of OSGi RFC-193
> --
>
> Key: ARIES-1665
> URL: https://issues.apache.org/jira/browse/ARIES-1665
> Project: Aries
>  Issue Type: New Feature
>Reporter: Raymond Augé
>Assignee: David Bosschaert
>
> This contribution will begin to implement *RFC-193 CDI Integration*
> https://github.com/osgi/design/blob/master/rfcs/rfc0193/rfc-0193-CDI-Integration.pdf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARIES-1665) Initial contribution of implementation of OSGi RFC-193

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARIES-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836897#comment-15836897
 ] 

ASF subversion and git services commented on ARIES-1665:


Commit 1780127 from [~bosschaert] in branch 'aries/trunk'
[ https://svn.apache.org/r1780127 ]

ARIES-1665 Initial contribution of implementation of OSGi RFC-193

Committed on behalf of Raymond Augé with many thanks.
This closes https://github.com/apache/aries/pull/64

> Initial contribution of implementation of OSGi RFC-193
> --
>
> Key: ARIES-1665
> URL: https://issues.apache.org/jira/browse/ARIES-1665
> Project: Aries
>  Issue Type: New Feature
>Reporter: Raymond Augé
>Assignee: David Bosschaert
>
> This contribution will begin to implement *RFC-193 CDI Integration*
> https://github.com/osgi/design/blob/master/rfcs/rfc0193/rfc-0193-CDI-Integration.pdf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] aries pull request #64: ARIES-1665 Initial contribution of implementation of...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/aries/pull/64


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ARIES-1665) Initial contribution of implementation of OSGi RFC-193

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARIES-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836867#comment-15836867
 ] 

ASF subversion and git services commented on ARIES-1665:


Commit 1780123 from [~bosschaert] in branch 'aries/trunk'
[ https://svn.apache.org/r1780123 ]

ARIES-1665 Initial contribution of OSGi-CDI API from OSGi

Originating OSGi commit: 0e64a3a27df0eaab24f68758ff1309774574143e (core branch)

> Initial contribution of implementation of OSGi RFC-193
> --
>
> Key: ARIES-1665
> URL: https://issues.apache.org/jira/browse/ARIES-1665
> Project: Aries
>  Issue Type: New Feature
>Reporter: Raymond Augé
>Assignee: David Bosschaert
>
> This contribution will begin to implement *RFC-193 CDI Integration*
> https://github.com/osgi/design/blob/master/rfcs/rfc0193/rfc-0193-CDI-Integration.pdf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [DISCUSS] [POLICY] IP tracking for OSGi APIs

[Carsten Ziegeler]

Guillaume Nodet wrote
> My point is that there is a source identified, preferably public if
> possible, private if not.
> 
> Of course if the API is not public, we can refer to the private commit so
> that  PMC members which are not OSGi members can be confident about the IP
> tracking.
> I think it depends on what stage the API is.  For example, consider the
> work Ray is working on for CDI, I don't think the API is in the OSGi git
> repo yet, so either the API is committed there first, or the commit can
> refer to Ray's github repo directly.  If a spec has been published
> officially by the OSGi Alliance, we can refer to a public source too.
> Given the API code becomes public at the time it's given to the ASF, I
> didn't thought that would be a problem to have it in a public repo in the
> first place, but if you're saying it is... I'm fine with that.
> 
> So what about:
>   "All commits that includes API code from the OSGi Alliance are done in
> separate commit and include a reference to the public (preferably) or
> private (if not public) source  where the code comes from."
> 
> Does that look better to you ?
> 
Absolutely

 Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [DISCUSS] [POLICY] IP tracking for OSGi APIs

[Guillaume Nodet]

My point is that there is a source identified, preferably public if
possible, private if not.

Of course if the API is not public, we can refer to the private commit so
that  PMC members which are not OSGi members can be confident about the IP
tracking.
I think it depends on what stage the API is.  For example, consider the
work Ray is working on for CDI, I don't think the API is in the OSGi git
repo yet, so either the API is committed there first, or the commit can
refer to Ray's github repo directly.  If a spec has been published
officially by the OSGi Alliance, we can refer to a public source too.
Given the API code becomes public at the time it's given to the ASF, I
didn't thought that would be a problem to have it in a public repo in the
first place, but if you're saying it is... I'm fine with that.

So what about:
  "All commits that includes API code from the OSGi Alliance are done in
separate commit and include a reference to the public (preferably) or
private (if not public) source  where the code comes from."

Does that look better to you ?

2017-01-24 11:42 GMT+01:00 Carsten Ziegeler :

> Guillaume Nodet wrote
> > 2017-01-24 0:02 GMT+01:00 Carsten Ziegeler :
> >
> >> Guillaume Nodet wrote
> >>> Well maybe it should, but again, I don't think it has always been done
> >>> correctly in the past...
> >>> Hence this proposal to discuss what options we have to actually
> correctly
> >>> implement it.
> >>>
> >> As said, it must be option #2, always and I'm not aware of any case
> >> where it hasn't.
> >>
> >
> > Cool.  Then it should be very easy to simply add the source of the api in
> > the commit log, is it ?
> > David just did it yesterday, it does not seem very complicated:
> >
> > https://github.com/apache/felix/commit/94b4ca9a58ab15f70eead73736d801
> 83688a6325
> > Where's the problem ? I really don't understand.
> >
> What David did is exactly what I said is the way to do it. But still the
> OSGi API is
> not available in public, so unless you have access to the private OSGi
> git repo,
> you can't check whether the reference given there is correct or not.
> But you had exactly this requirement in your original proposal.
>
> As Felix proposed, let's extend our policy with what we can do and we're
> all happy.
>
>  Carsten
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>



-- 

Guillaume Nodet

Re: [DISCUSS] [POLICY] IP tracking for OSGi APIs

[Carsten Ziegeler]

Guillaume Nodet wrote
> 2017-01-24 0:02 GMT+01:00 Carsten Ziegeler :
> 
>> Guillaume Nodet wrote
>>> Well maybe it should, but again, I don't think it has always been done
>>> correctly in the past...
>>> Hence this proposal to discuss what options we have to actually correctly
>>> implement it.
>>>
>> As said, it must be option #2, always and I'm not aware of any case
>> where it hasn't.
>>
> 
> Cool.  Then it should be very easy to simply add the source of the api in
> the commit log, is it ?
> David just did it yesterday, it does not seem very complicated:
> 
> https://github.com/apache/felix/commit/94b4ca9a58ab15f70eead73736d80183688a6325
> Where's the problem ? I really don't understand.
> 
What David did is exactly what I said is the way to do it. But still the
OSGi API is
not available in public, so unless you have access to the private OSGi
git repo,
you can't check whether the reference given there is correct or not.
But you had exactly this requirement in your original proposal.

As Felix proposed, let's extend our policy with what we can do and we're
all happy.

 Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [DISCUSS] [POLICY] IP tracking for OSGi APIs

[Guillaume Nodet]

2017-01-24 0:02 GMT+01:00 Carsten Ziegeler :

> Guillaume Nodet wrote
> > Well maybe it should, but again, I don't think it has always been done
> > correctly in the past...
> > Hence this proposal to discuss what options we have to actually correctly
> > implement it.
> >
> As said, it must be option #2, always and I'm not aware of any case
> where it hasn't.
>

Cool.  Then it should be very easy to simply add the source of the api in
the commit log, is it ?
David just did it yesterday, it does not seem very complicated:

https://github.com/apache/felix/commit/94b4ca9a58ab15f70eead73736d80183688a6325
Where's the problem ? I really don't understand.



>
> Carsten
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>



-- 

Guillaume Nodet