[jira] [Commented] (ARIES-1803) Upgrade proxy to ASM 6.1.1

[Andy Guibert (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARIES-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501816#comment-16501816
 ] 

Andy Guibert commented on ARIES-1803:
-

I attempted to upgrade WebSphere Liberty from ASM 6.0 to 6.1.1 and hit this 
error:

 

org.osgi.service.blueprint.container.ComponentDefinitionException: Error 
setting property: PropertyDescriptor https://gitlab.ow2.org/asm/asm/blob/master/asm-commons/src/main/java/org/objectweb/asm/commons/GeneratorAdapter.java#L784]

before the method `public void cast(final Type from, final Type to)` was 
falling through, and in ASM 6.1.1 they prevented the fallthrough by throwing 
the IllegalArgumentException.

> Upgrade proxy to ASM 6.1.1
> --
>
> Key: ARIES-1803
> URL: https://issues.apache.org/jira/browse/ARIES-1803
> Project: Aries
>  Issue Type: Dependency upgrade
>  Components: Proxy
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ARIES-1801) SPI Fly does not work with a dynamic class object

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARIES-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved ARIES-1801.
-
Resolution: Fixed

> SPI Fly does not work with a dynamic class object
> -
>
> Key: ARIES-1801
> URL: https://issues.apache.org/jira/browse/ARIES-1801
> Project: Aries
>  Issue Type: Bug
>Affects Versions: spifly-1.0.10
>Reporter: Björn Kautler
>Assignee: David Bosschaert
>Priority: Major
> Fix For: spifly-1.0.12
>
>
> SLF4J changes in version 1.8 how implementations are looked up to 
> {{java.util.ServiceLoader}}.
> In our codebase we dynamically search for an SLF4J implementation and use a 
> default logger if none is found.
> To adapt to the new mechanism but remain compatible with SLF4J 1.7 I added to 
> our codebase
> {code:java}
> try {
> // post-1.8 mechanism
> Class slf4jServiceProviderClass = 
> Class.forName("org.slf4j.spi.SLF4JServiceProvider");
> if (ServiceLoader.load(slf4jServiceProviderClass).iterator().hasNext()) {
> noLogger.set(false);
> return true;
> }
> } catch (ClassNotFoundException e) {
> // ignore
> }
> {code}
> If I now use the {{org.apache.aries.spifly.dynamic.bundle}} 1.0.10, I get an 
> exception as SPI Fly seemingly only supports class constants. While 
> traversing the ASM tree it remembers the last class constant seen and uses 
> that to transform the {{load}} call.
> Here the exception I get:
> {code:java}
> java.lang.ClassFormatError: Weaving hook failed.
>   at 
> org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.transformClass(BundleWiringImpl.java:2479)
>   at 
> org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.findClass(BundleWiringImpl.java:2152)
>   at 
> org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1607)
>   at 
> org.apache.felix.framework.BundleWiringImpl.access$200(BundleWiringImpl.java:80)
>   at 
> org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:2053)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>   at 
> org.javacord.core.util.logging.ExceptionLoggerDelegateImpl.(ExceptionLoggerDelegateImpl.java:20)
>   at 
> org.javacord.core.util.DelegateFactoryDelegateImpl.createExceptionLoggerDelegate(DelegateFactoryDelegateImpl.java:180)
>   at 
> org.javacord.api.util.internal.DelegateFactory.(DelegateFactory.java:74)
>   at org.javacord.api.DiscordApiBuilder.(DiscordApiBuilder.java:20)
>   at net.kautler.test.osgi.OsgiTest.start(OsgiTest.java:17)
>   at 
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:697)
>   at org.apache.felix.framework.Felix.activateBundle(Felix.java:2240)
>   at org.apache.felix.framework.Felix.startBundle(Felix.java:2146)
>   at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1373)
>   at 
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
>   at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.IllegalArgumentException: value null
>   at org.objectweb.asm.ClassWriter.newConstItem(ClassWriter.java:1057)
>   at org.objectweb.asm.MethodWriter.visitLdcInsn(MethodWriter.java:1126)
>   at 
> org.apache.aries.spifly.weaver.TCCLSetterVisitor$TCCLSetterMethodVisitor.visitMethodInsn(TCCLSetterVisitor.java:194)
>   at org.objectweb.asm.ClassReader.readCode(ClassReader.java:1416)
>   at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1017)
>   at org.objectweb.asm.ClassReader.accept(ClassReader.java:693)
>   at org.objectweb.asm.ClassReader.accept(ClassReader.java:506)
>   at 
> org.apache.aries.spifly.dynamic.ClientWeavingHook.weave(ClientWeavingHook.java:61)
>   at 
> org.apache.felix.framework.util.SecureAction.invokeWeavingHook(SecureAction.java:1203)
>   at 
> org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.transformClass(BundleWiringImpl.java:2465)
>   ... 16 more
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[RESULT][VOTE] Release SPI-Fly 1.0.12

[davidb]

With 5+s this vote succeeds. I'll promote the artifacts.

David

On 1 June 2018 at 13:43,  wrote:

> Hi all,
>
> I'm calling a vote on SPI-Fly 1.0.12
>
> The following bugs have been fixed:
> ARIES-1801 SPI Fly does not work with a dynamic class object
> ARIES-1321 NPE when calling ServiceLoader.load with a variable
>
> This release includes the following modules:
>
> spi-fly-core
> spi-fly-dynamic-bundle
> spi-fly-static-bundle
> spi-fly-static-tool
> spi-fly-weaver
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachearies-1133
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://svn.apache.org/repos/asf/aries/scripts/verify_staged_release.sh
>
> Usage:
> sh verify_staged_release.sh 1044 tmpdir 2>&1 | tee verifyresults.txt
> grep FAIL verifyresults.txt
> grep ERROR verifyresults.txt
>
> More details on verifying the release here:
> http://aries.apache.org/development/verifyingrelease.html
>
> Please vote:
>  +1 Approve the release
>  -1 Do not approve the release (please explain why)
>
> This vote will be open for at least 72 hours.
>
> Best regards,
>
> David Bosschaert
>

Re: [VOTE] Release Blueprint 1.10

[David Bosschaert]

+1

David

On 4 June 2018 at 17:21, Guillaume Nodet  wrote:

> I've staged a bunch of blueprint artifacts to the following repositories:
> https://repository.apache.org/content/repositories/orgapachearies-1134
> 
> https://repository.apache.org/content/repositories/orgapachearies-1135
>
> Below is a list of changes.  The most important one is ARIES-1298 which
> affects a bunch of bundles and warrant a minor (vs micro) update.
>
> 
>
> cb260e7d9 [ARIES-1793] Blueprint interceptors do not work anymore
>
> a3413a963 [ARIES-1805] Blueprint core does not honor Java beans
> specification
>
> 4fda9b5dc [ARIES-1761] Provide support for camel-spring from
> blueprint-spring
>
> 4e89276a0 [ARIES-1298] Support typed configurations in property
> placeholders
>
> df905723c [ARIES-1009] BlueprintContainerImpl - Add INFO logging when the
> blueprint container has been created
>
> e832f7917 Upgrade blueprint-noosgi to latest blueprint-core / parser
>
> 3188ff944 [ARIES-1781] ExtendedReferenceMetadata should extend
> ExtendedServiceReferenceMetadata
>
> Please review and vote !
>
> Cheers,
> Guillaume Nodet
>

Re: [VOTE] Release transaction-jdbc 2.1.3

[David Bosschaert]

+1

David

On 4 June 2018 at 17:28, Guillaume Nodet  wrote:

> I've staged another release at:
>   https://repository.apache.org/content/repositories/orgapachearies-1136
>
> This fixes the following problems:
>
> 7499ef6a3 [ARIES-1790] ValidatingDelegatingManagedConnectionFactory is not
> used with aries.xa.validateOnMatch
>
> 5eca2985c [ARIES-1550] getConnection with null user. Closes #47
>
> 01ef4c88c ARIES-1276: Add monitoring capability via MBean to Aries
> Transaction JDBC
>
> Please review and vote !
>
> Cheers,
> Guillaume
>

Re: [VOTE] Release Blueprint 1.10

[Jean-Baptiste Onofré]

+1 (binding)

Regards
JB

On 04/06/2018 18:21, Guillaume Nodet wrote:
> I've staged a bunch of blueprint artifacts to the following repositories:
> https://repository.apache.org/content/repositories/orgapachearies-1134
> 
> https://repository.apache.org/content/repositories/orgapachearies-1135
> 
> Below is a list of changes.  The most important one is ARIES-1298 which
> affects a bunch of bundles and warrant a minor (vs micro) update.
> 
> 
> 
> cb260e7d9 [ARIES-1793] Blueprint interceptors do not work anymore
> 
> a3413a963 [ARIES-1805] Blueprint core does not honor Java beans
> specification
> 
> 4fda9b5dc [ARIES-1761] Provide support for camel-spring from
> blueprint-spring
> 
> 4e89276a0 [ARIES-1298] Support typed configurations in property placeholders
> 
> df905723c [ARIES-1009] BlueprintContainerImpl - Add INFO logging when the
> blueprint container has been created
> 
> e832f7917 Upgrade blueprint-noosgi to latest blueprint-core / parser
> 
> 3188ff944 [ARIES-1781] ExtendedReferenceMetadata should extend
> ExtendedServiceReferenceMetadata
> 
> Please review and vote !
> 
> Cheers,
> Guillaume Nodet
> 

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: [VOTE] Release transaction-jdbc 2.1.3

[Jean-Baptiste Onofré]

+1 (binding)

Regards
JB

On 04/06/2018 18:28, Guillaume Nodet wrote:
> I've staged another release at:
>   https://repository.apache.org/content/repositories/orgapachearies-1136
> 
> This fixes the following problems:
> 
> 7499ef6a3 [ARIES-1790] ValidatingDelegatingManagedConnectionFactory is not
> used with aries.xa.validateOnMatch
> 
> 5eca2985c [ARIES-1550] getConnection with null user. Closes #47
> 
> 01ef4c88c ARIES-1276: Add monitoring capability via MBean to Aries
> Transaction JDBC
> 
> Please review and vote !
> 
> Cheers,
> Guillaume
> 

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: [VOTE] Release Aries Component-DSL 1.1.0

[Carlos Sierra Andrés]

Hi...

you are right :-)

so this vote passes then. I will be releasing the artifacts during the day.

Thx to all.

Carlos.


El 4/6/18 a las 21:30, Christian Schneider escribió:
> Davids vote is binding. So you should be fine.
>
> Best
> Christian
>
> Carlos Sierra Andrés  schrieb am Mo., 4. Juni 2018,
> 18:27:
>
>> hello there...
>>
>> calling out for one more positive binding vote!
>>
>> thx!
>>
>> Carlos.
>>
>>> On 1 June 2018 at 11:39, Carlos Sierra Andrés 
>> wrote:
>>> Hello all,
>>>
>>> As discussed in an earlier mail thread, I have staged a release 1.1.0
>>> for Aries Component DSL.
>>>
>>> The module is tagged at
>>> https://svn.apache.org/repos/asf/aries/tags/org.apache.
>>> aries.component-dsl.parent-1.1.0
>>>
>>> Artifacts are in one staged repo,
>>> https://repository.apache.org/content/repositories/orgapachearies-1132
>>>
>>> Instructions for verifying the release are at
>>> http://aries.apache.org/development/verifyingrelease.html. Alternately,
>>> cut and paste the following to run a full check:
>>>
>>> -
>>>
>>> wget --no-check-certificate https://svn.apache.org/repos/
>>> asf/aries/scripts/verify_staged_release.sh
>>> chmod a+x verify_staged_release.sh
>>> MAVEN_OPTS='-Dbnd.baseline.skip=true' ./verify_staged_release.sh 1132
>>> mytempdirectory 2>&1 | tee verifyresults.txt
>>> grep FAIL verifyresults.txt
>>> grep ERROR verifyresults.txt
>>>
>>> -
>>>
>>> I add the bnd.baseline.skip because the plugin is incorrectly using
>>> 1.1.0-SNAPSHOT as the baseline instead of 1.0.0.
>>>
>>> The vote will be open for at least 72 hours. [ ] +1 [ ] 0 [ ] -1
>>>
>>> Bests,
>>>
>>> Carlos Sierra.
>>>
>>>
>>