[jira] [Closed] (ARIES-1848) jaxrs whiteboard jar contains SseEventSource.Builder but not the impl

2018-10-22 Thread Timothy Ward (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARIES-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Ward closed ARIES-1848.
---
Resolution: Won't Fix

Support for SSE is required by the OSGi JAX-RS whiteboard specification. There 
is an argument that the whiteboard could be separated into server and client 
modules, but the client module would still need to contain the SSE 
implementation to comply with the OSGi spec.

I am also not sure that it would be worth separating the client and server 
features of the whiteboard. It would add deployment complexity, and I'm pretty 
sure it would add bloat as we would end up inlining multiple copies of CXF 
(common code used by server and client).

Note that it is not possible for the JAX-RS whiteboard to use an external CXF 
dependency (i.e. it must be embedded). There are some CXF packages that have 
additional classes added (to customize/extend CXF behaviour) and we could not 
do that as an external module. This was a deliberate implementation decision to 
allow the Aries implementation to be small and easily deployable.

> jaxrs whiteboard jar contains SseEventSource.Builder but not the impl
> -
>
> Key: ARIES-1848
> URL: https://issues.apache.org/jira/browse/ARIES-1848
> Project: Aries
>  Issue Type: Bug
>Reporter: Romain Manni-Bucau
>Priority: Major
>
> org.apache.aries.jax.rs.whiteboard-1.0.1.jar!/META-INF/services/javax.ws.rs.sse.SseEventSource.Builder
>  shouldn't be part of aries jaxrs whiteboard packaging since the impl is not 
> provided and is optional for cxf



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARIES-1852) Missing null check in PromiseAwareJAXRSInvoker

2018-10-22 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARIES-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658702#comment-16658702
 ] 

ASF subversion and git services commented on ARIES-1852:


Commit 16f3c9f9c3f494e7fc930294866291d863f7a750 in aries-jax-rs-whiteboard's 
branch refs/heads/master from [~csierra]
[ https://gitbox.apache.org/repos/asf?p=aries-jax-rs-whiteboard.git;h=16f3c9f ]

[ARIES-1852] Missing null check


> Missing null check in PromiseAwareJAXRSInvoker
> --
>
> Key: ARIES-1852
> URL: https://issues.apache.org/jira/browse/ARIES-1852
> Project: Aries
>  Issue Type: Bug
>  Components: jax-rs-whiteboard
>Affects Versions: jax-rs-whiteboard-1.0.1
>Reporter: Carlos Sierra
>Assignee: Carlos Sierra
>Priority: Major
> Fix For: jax-rs-whiteboard-1.0.2
>
>
> Looks like {{Object result}} might be null and it is not being checked.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ARIES-1852) Missing null check in PromiseAwareJAXRSInvoker

2018-10-22 Thread Carlos Sierra (JIRA) 
Carlos Sierra created ARIES-1852:


 Summary: Missing null check in PromiseAwareJAXRSInvoker
 Key: ARIES-1852
 URL: https://issues.apache.org/jira/browse/ARIES-1852
 Project: Aries
  Issue Type: Bug
  Components: jax-rs-whiteboard
Affects Versions: jax-rs-whiteboard-1.0.1
Reporter: Carlos Sierra
Assignee: Carlos Sierra
 Fix For: jax-rs-whiteboard-1.0.2


Looks like {{Object result}} might be null and it is not being checked.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)