Re: [VOTE] Aries JPA 2.7.1

2018-12-03 Thread Grzegorz Grzybek 
+1

best regards
Grzegorz Grzybek

pon., 3 gru 2018 o 19:09 David Bosschaert 
napisał(a):

> +1
>
> David
>
> On Mon, 3 Dec 2018 at 16:35, Christian Schneider 
> wrote:
>
> > I've staged a release for vote at:
> > https://repository.apache.org/content/repositories/orgapachearies-1148
> >
> > It mainly contains an important bugfix when mixing transactional and non
> > transactional behaviour. Thanks to Daniel for the fix.
> >
> > I was also notified that the Aries JPA example currently does not work in
> > apache karaf 4.2.1.
> > The error is in blueprint core. So it does not affect our release. JB is
> > working on a fix for karaf 4.2.2. See
> > https://github.com/apache/aries-jpa/tree/master/examples
> >
> > Release Notes - Aries - Version jpa-2.7.1
> >
> > https://issues.apache.org/jira/projects/ARIES/versions/12343100
> >
> > ** Bug
> >
> > * [ARIES-1783] - TransactionRequiredException when non-transactional
> > method precedes a transactional one in the same service.
> >
> > * [ARIES-1869] - Example does not work with current karaf 4.2.1
> >
> > Please review and vote:
> >
> >   [ ] +1 Release the above artifacts
> >   [ ] -1 Do not
> >
> > Here is my +1
> >
> > Cheers,
> > Christian
> >
> > --
> > --
> > Christian Schneider
> > http://www.liquid-reality.de
> >
> > Computer Scientist
> > http://www.adobe.com
> >
>

Re: [VOTE] Aries JPA 2.7.1

2018-12-03 Thread David Bosschaert 
+1

David

On Mon, 3 Dec 2018 at 16:35, Christian Schneider 
wrote:

> I've staged a release for vote at:
> https://repository.apache.org/content/repositories/orgapachearies-1148
>
> It mainly contains an important bugfix when mixing transactional and non
> transactional behaviour. Thanks to Daniel for the fix.
>
> I was also notified that the Aries JPA example currently does not work in
> apache karaf 4.2.1.
> The error is in blueprint core. So it does not affect our release. JB is
> working on a fix for karaf 4.2.2. See
> https://github.com/apache/aries-jpa/tree/master/examples
>
> Release Notes - Aries - Version jpa-2.7.1
>
> https://issues.apache.org/jira/projects/ARIES/versions/12343100
>
> ** Bug
>
> * [ARIES-1783] - TransactionRequiredException when non-transactional
> method precedes a transactional one in the same service.
>
> * [ARIES-1869] - Example does not work with current karaf 4.2.1
>
> Please review and vote:
>
>   [ ] +1 Release the above artifacts
>   [ ] -1 Do not
>
> Here is my +1
>
> Cheers,
> Christian
>
> --
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Computer Scientist
> http://www.adobe.com
>

Re: [VOTE] Aries JPA 2.7.1

2018-12-03 Thread Francois Papon 
+1 (non-binding)

Thanks!

regards,

François Papon
fpa...@apache.org

Le 03/12/2018 à 20:35, Christian Schneider a écrit :
> I've staged a release for vote at:
> https://repository.apache.org/content/repositories/orgapachearies-1148
>
> It mainly contains an important bugfix when mixing transactional and non
> transactional behaviour. Thanks to Daniel for the fix.
>
> I was also notified that the Aries JPA example currently does not work in
> apache karaf 4.2.1.
> The error is in blueprint core. So it does not affect our release. JB is
> working on a fix for karaf 4.2.2. See
> https://github.com/apache/aries-jpa/tree/master/examples
>
> Release Notes - Aries - Version jpa-2.7.1
>
> https://issues.apache.org/jira/projects/ARIES/versions/12343100
>
> ** Bug
>
> * [ARIES-1783] - TransactionRequiredException when non-transactional
> method precedes a transactional one in the same service.
>
> * [ARIES-1869] - Example does not work with current karaf 4.2.1
>
> Please review and vote:
>
>   [ ] +1 Release the above artifacts
>   [ ] -1 Do not
>
> Here is my +1
>
> Cheers,
> Christian
>

Re: [VOTE] Aries JPA 2.7.1

2018-12-03 Thread Jean-Baptiste Onofré 

+1 (binding)

Regards
JB

On 03/12/2018 17:35, Christian Schneider wrote:

I've staged a release for vote at:
https://repository.apache.org/content/repositories/orgapachearies-1148

It mainly contains an important bugfix when mixing transactional and non
transactional behaviour. Thanks to Daniel for the fix.

I was also notified that the Aries JPA example currently does not work in
apache karaf 4.2.1.
The error is in blueprint core. So it does not affect our release. JB is
working on a fix for karaf 4.2.2. See
https://github.com/apache/aries-jpa/tree/master/examples

Release Notes - Aries - Version jpa-2.7.1

https://issues.apache.org/jira/projects/ARIES/versions/12343100

** Bug

 * [ARIES-1783] - TransactionRequiredException when non-transactional
method precedes a transactional one in the same service.

 * [ARIES-1869] - Example does not work with current karaf 4.2.1

Please review and vote:

   [ ] +1 Release the above artifacts
   [ ] -1 Do not

Here is my +1

Cheers,
Christian

Re: [VOTE] Aries JPA 2.7.1

2018-12-03 Thread Raymond Auge 
+1

- Ray

On Mon, Dec 3, 2018 at 11:35 AM Christian Schneider 
wrote:

> I've staged a release for vote at:
> https://repository.apache.org/content/repositories/orgapachearies-1148
>
> It mainly contains an important bugfix when mixing transactional and non
> transactional behaviour. Thanks to Daniel for the fix.
>
> I was also notified that the Aries JPA example currently does not work in
> apache karaf 4.2.1.
> The error is in blueprint core. So it does not affect our release. JB is
> working on a fix for karaf 4.2.2. See
> https://github.com/apache/aries-jpa/tree/master/examples
>
> Release Notes - Aries - Version jpa-2.7.1
>
> https://issues.apache.org/jira/projects/ARIES/versions/12343100
>
> ** Bug
>
> * [ARIES-1783] - TransactionRequiredException when non-transactional
> method precedes a transactional one in the same service.
>
> * [ARIES-1869] - Example does not work with current karaf 4.2.1
>
> Please review and vote:
>
>   [ ] +1 Release the above artifacts
>   [ ] -1 Do not
>
> Here is my +1
>
> Cheers,
> Christian
>
> --
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Computer Scientist
> http://www.adobe.com
>


-- 
*Raymond Augé* 
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* 
 (@Liferay)
Board Member & EEG Co-Chair, OSGi Alliance  (@OSGiAlliance)

[VOTE] Aries JPA 2.7.1

2018-12-03 Thread Christian Schneider 
I've staged a release for vote at:
https://repository.apache.org/content/repositories/orgapachearies-1148

It mainly contains an important bugfix when mixing transactional and non
transactional behaviour. Thanks to Daniel for the fix.

I was also notified that the Aries JPA example currently does not work in
apache karaf 4.2.1.
The error is in blueprint core. So it does not affect our release. JB is
working on a fix for karaf 4.2.2. See
https://github.com/apache/aries-jpa/tree/master/examples

Release Notes - Aries - Version jpa-2.7.1

https://issues.apache.org/jira/projects/ARIES/versions/12343100

** Bug

* [ARIES-1783] - TransactionRequiredException when non-transactional
method precedes a transactional one in the same service.

* [ARIES-1869] - Example does not work with current karaf 4.2.1

Please review and vote:

  [ ] +1 Release the above artifacts
  [ ] -1 Do not

Here is my +1

Cheers,
Christian

-- 
-- 
Christian Schneider
http://www.liquid-reality.de

Computer Scientist
http://www.adobe.com

[jira] [Commented] (ARIES-1869) Example does not work with current karaf 4.2.1

2018-12-03 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARIES-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707315#comment-16707315
 ] 

ASF subversion and git services commented on ARIES-1869:


Commit c16e5d48287b82eedb853a47abe9db0208ff534a in aries-jpa's branch 
refs/heads/master from [~ch...@die-schneider.net]
[ https://gitbox.apache.org/repos/asf?p=aries-jpa.git;h=c16e5d4 ]

ARIES-1869 - Warning in the example about issue in karaf 4.2.1


> Example does not work with current karaf 4.2.1
> --
>
> Key: ARIES-1869
> URL: https://issues.apache.org/jira/browse/ARIES-1869
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: jpa-2.8.0
>
>
> See 
> [https://stackoverflow.com/questions/53433775/org-apache-aries-jpaorg-apache-aries-jpa-blueprint2-3-0-cant-make-run]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARIES-1793) Blueprint interceptors do not work anymore

2018-12-03 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARIES-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707279#comment-16707279
 ] 

ASF GitHub Bot commented on ARIES-1793:
---

cschneider opened a new pull request #671: Revert "[ARIES-1793] Upgrade to 
blueprint-core 1.10.0"
URL: https://github.com/apache/karaf/pull/671
 
 
   Reverts apache/karaf#670 . Because the update to 1.10.0 breaks camel 
blueprint. We will try to create blueprint core 1.9.1 that works with camel and 
jpa.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Blueprint interceptors do not work anymore
> --
>
> Key: ARIES-1793
> URL: https://issues.apache.org/jira/browse/ARIES-1793
> Project: Aries
>  Issue Type: Bug
>  Components: Blueprint
>Affects Versions: blueprint-core-1.9.0
> Environment: Karaf 4.2.0
>Reporter: Nicolas Dutertry
>Assignee: Guillaume Nodet
>Priority: Blocker
> Fix For: blueprint-core-1.10.0
>
> Attachments: aries-interceptor.patch
>
>
> I have committed a project on Github to illustrate the issue : 
> [https://github.com/nicolas-dutertry/test-jpa]
> This project contains a blueprint bundle with a bean TestRepository annotated 
> with @PersistenceContext. This bean is then injected into another bean 
> TestServiceImpl which is then published as an osgi service :
> {code:xml}
> 
>     
> 
>      class="com.dutertry.test.karaf.jpa.service.impl.TestRepository"/>
>  class="com.dutertry.test.karaf.jpa.service.impl.TestServiceImpl">
>     
>     
>  ref="testService"/>
> {code}
> With Karaf 4.1.5 the instance of TestRepository injected in testService is an 
> aries proxy managing JPA stuff, but with Karaf 4.2.0 the injected instance is 
> not a proxy. Thus when using testService, the following error occurs:
> {code:java}
> java.lang.IllegalStateException: Need active coordination
>     at 
> org.apache.aries.jpa.support.impl.EMSupplierImpl.get(EMSupplierImpl.java:81) 
> ~[?:?]
>     at org.apache.aries.jpa.support.osgi.impl.EmProxy.invoke(EmProxy.java:38) 
> ~[?:?]
>     at com.sun.proxy.$Proxy77.createQuery(Unknown Source) ~[?:?]
>     at Proxy4c2993b8_dc6f_46b4_8e62_524dc0ad05f5.createQuery(Unknown Source) 
> ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.service.impl.TestRepository.list(TestRepository.java:26)
>  ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.service.impl.TestServiceImpl.list(TestServiceImpl.java:25)
>  ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.cmd.ListPersonCommand.execute(ListPersonCommand.java:24)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.action.command.ActionCommand.execute(ActionCommand.java:84)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:68)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:86)
>  ~[?:?]
>     at org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:571) 
> ~[?:?]
>     at 
> org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:497) 
> ~[?:?]
>     at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:386) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.doCall(Pipe.java:417) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:229) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59) ~[?:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:?]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[?:?]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  ~[?:?]
>     at java.lang.Thread.run(Thread.java:748) [?:?]{code}
>  
> After some investigation, I have found that this bug is due to the resolution 
> of issue ARIES-1544. I have done a patch (see attached file) which solve the 
> issue I think.
> [^aries-interceptor.patch]
> Can you please integrate my patch or correct the issue another way ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ARIES-1777) need to add aries-blueprint as a dependency to jpa feature

2018-12-03 Thread Christian Schneider (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARIES-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1777:
---
Fix Version/s: (was: jpa-2.8.0)

> need to add aries-blueprint as a dependency to jpa feature
> --
>
> Key: ARIES-1777
> URL: https://issues.apache.org/jira/browse/ARIES-1777
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.6.1
>Reporter: AmirMohammad Vosough
>Assignee: Christian Schneider
>Priority: Major
>  Labels: easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When working on Vaseline framework, I faced this problem:
> After using karaf-assembly I found out I can not have jpa as a startup 
> feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARIES-1793) Blueprint interceptors do not work anymore

2018-12-03 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARIES-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707281#comment-16707281
 ] 

ASF GitHub Bot commented on ARIES-1793:
---

cschneider closed pull request #671: Revert "[ARIES-1793] Upgrade to 
blueprint-core 1.10.0"
URL: https://github.com/apache/karaf/pull/671
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Blueprint interceptors do not work anymore
> --
>
> Key: ARIES-1793
> URL: https://issues.apache.org/jira/browse/ARIES-1793
> Project: Aries
>  Issue Type: Bug
>  Components: Blueprint
>Affects Versions: blueprint-core-1.9.0
> Environment: Karaf 4.2.0
>Reporter: Nicolas Dutertry
>Assignee: Guillaume Nodet
>Priority: Blocker
> Fix For: blueprint-core-1.10.0
>
> Attachments: aries-interceptor.patch
>
>
> I have committed a project on Github to illustrate the issue : 
> [https://github.com/nicolas-dutertry/test-jpa]
> This project contains a blueprint bundle with a bean TestRepository annotated 
> with @PersistenceContext. This bean is then injected into another bean 
> TestServiceImpl which is then published as an osgi service :
> {code:xml}
> 
>     
> 
>      class="com.dutertry.test.karaf.jpa.service.impl.TestRepository"/>
>  class="com.dutertry.test.karaf.jpa.service.impl.TestServiceImpl">
>     
>     
>  ref="testService"/>
> {code}
> With Karaf 4.1.5 the instance of TestRepository injected in testService is an 
> aries proxy managing JPA stuff, but with Karaf 4.2.0 the injected instance is 
> not a proxy. Thus when using testService, the following error occurs:
> {code:java}
> java.lang.IllegalStateException: Need active coordination
>     at 
> org.apache.aries.jpa.support.impl.EMSupplierImpl.get(EMSupplierImpl.java:81) 
> ~[?:?]
>     at org.apache.aries.jpa.support.osgi.impl.EmProxy.invoke(EmProxy.java:38) 
> ~[?:?]
>     at com.sun.proxy.$Proxy77.createQuery(Unknown Source) ~[?:?]
>     at Proxy4c2993b8_dc6f_46b4_8e62_524dc0ad05f5.createQuery(Unknown Source) 
> ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.service.impl.TestRepository.list(TestRepository.java:26)
>  ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.service.impl.TestServiceImpl.list(TestServiceImpl.java:25)
>  ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.cmd.ListPersonCommand.execute(ListPersonCommand.java:24)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.action.command.ActionCommand.execute(ActionCommand.java:84)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:68)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:86)
>  ~[?:?]
>     at org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:571) 
> ~[?:?]
>     at 
> org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:497) 
> ~[?:?]
>     at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:386) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.doCall(Pipe.java:417) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:229) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59) ~[?:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:?]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[?:?]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  ~[?:?]
>     at java.lang.Thread.run(Thread.java:748) [?:?]{code}
>  
> After some investigation, I have found that this bug is due to the resolution 
> of issue ARIES-1544. I have done a patch (see attached file) which solve the 
> issue I think.
> [^aries-interceptor.patch]
> Can you please integrate my patch or correct the issue another way ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARIES-1777) need to add aries-blueprint as a dependency to jpa feature

2018-12-03 Thread Christian Schneider (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARIES-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707267#comment-16707267
 ] 

Christian Schneider commented on ARIES-1777:


Aries JPA does not have a direct dependency to blueprint. We currently handle 
the eventual blueprint dependency using a conditional:

[https://github.com/apache/aries-jpa/blob/master/jpa-features/src/main/feature/feature.xml#L36]

How would a direct dependency to blueprint help with this? Cant you imply also 
add blueprint to your boot featues?

> need to add aries-blueprint as a dependency to jpa feature
> --
>
> Key: ARIES-1777
> URL: https://issues.apache.org/jira/browse/ARIES-1777
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.6.1
>Reporter: AmirMohammad Vosough
>Assignee: Christian Schneider
>Priority: Major
>  Labels: easyfix
> Fix For: jpa-2.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When working on Vaseline framework, I faced this problem:
> After using karaf-assembly I found out I can not have jpa as a startup 
> feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ARIES-1869) Example does not work with current karaf 4.2.1

2018-12-03 Thread Christian Schneider (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARIES-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1869.

Resolution: Fixed

> Example does not work with current karaf 4.2.1
> --
>
> Key: ARIES-1869
> URL: https://issues.apache.org/jira/browse/ARIES-1869
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: jpa-2.8.0
>
>
> See 
> [https://stackoverflow.com/questions/53433775/org-apache-aries-jpaorg-apache-aries-jpa-blueprint2-3-0-cant-make-run]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ARIES-1777) need to add aries-blueprint as a dependency to jpa feature

2018-12-03 Thread Christian Schneider (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARIES-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1777:
--

Assignee: Christian Schneider

> need to add aries-blueprint as a dependency to jpa feature
> --
>
> Key: ARIES-1777
> URL: https://issues.apache.org/jira/browse/ARIES-1777
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.6.1
>Reporter: AmirMohammad Vosough
>Assignee: Christian Schneider
>Priority: Major
>  Labels: easyfix
> Fix For: jpa-2.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When working on Vaseline framework, I faced this problem:
> After using karaf-assembly I found out I can not have jpa as a startup 
> feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARIES-1869) Example does not work with current karaf 4.2.1

2018-12-03 Thread Christian Schneider (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARIES-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707263#comment-16707263
 ] 

Christian Schneider commented on ARIES-1869:


[~soundcrac...@gmail.com] found the reason for this to be an error in 
blueprint-core 1.9.0 (https://issues.apache.org/jira/browse/ARIES-1793) which 
is used in karaf 4.2.1. So we do not need any fix in Aries JPA.

This is fixed in the karaf feature file in this commit 
[https://github.com/apache/karaf/pull/670] . It will be part of karaf 4.2.2.

 

> Example does not work with current karaf 4.2.1
> --
>
> Key: ARIES-1869
> URL: https://issues.apache.org/jira/browse/ARIES-1869
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: jpa-2.8.0
>
>
> See 
> [https://stackoverflow.com/questions/53433775/org-apache-aries-jpaorg-apache-aries-jpa-blueprint2-3-0-cant-make-run]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARIES-1793) Blueprint interceptors do not work anymore

2018-12-03 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARIES-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707255#comment-16707255
 ] 

ASF GitHub Bot commented on ARIES-1793:
---

cschneider closed pull request #670: [ARIES-1793] Upgrade to blueprint-core 
1.10.0
URL: https://github.com/apache/karaf/pull/670
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 81f8d40447..36fcad37c6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -218,7 +218,7 @@
 1.0.0
 
1.0.0
 1.0.1
-1.9.0
+1.10.0
 
1.0.0
 1.2.0
 1.0.1


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Blueprint interceptors do not work anymore
> --
>
> Key: ARIES-1793
> URL: https://issues.apache.org/jira/browse/ARIES-1793
> Project: Aries
>  Issue Type: Bug
>  Components: Blueprint
>Affects Versions: blueprint-core-1.9.0
> Environment: Karaf 4.2.0
>Reporter: Nicolas Dutertry
>Assignee: Guillaume Nodet
>Priority: Blocker
> Fix For: blueprint-core-1.10.0
>
> Attachments: aries-interceptor.patch
>
>
> I have committed a project on Github to illustrate the issue : 
> [https://github.com/nicolas-dutertry/test-jpa]
> This project contains a blueprint bundle with a bean TestRepository annotated 
> with @PersistenceContext. This bean is then injected into another bean 
> TestServiceImpl which is then published as an osgi service :
> {code:xml}
> 
>     
> 
>      class="com.dutertry.test.karaf.jpa.service.impl.TestRepository"/>
>  class="com.dutertry.test.karaf.jpa.service.impl.TestServiceImpl">
>     
>     
>  ref="testService"/>
> {code}
> With Karaf 4.1.5 the instance of TestRepository injected in testService is an 
> aries proxy managing JPA stuff, but with Karaf 4.2.0 the injected instance is 
> not a proxy. Thus when using testService, the following error occurs:
> {code:java}
> java.lang.IllegalStateException: Need active coordination
>     at 
> org.apache.aries.jpa.support.impl.EMSupplierImpl.get(EMSupplierImpl.java:81) 
> ~[?:?]
>     at org.apache.aries.jpa.support.osgi.impl.EmProxy.invoke(EmProxy.java:38) 
> ~[?:?]
>     at com.sun.proxy.$Proxy77.createQuery(Unknown Source) ~[?:?]
>     at Proxy4c2993b8_dc6f_46b4_8e62_524dc0ad05f5.createQuery(Unknown Source) 
> ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.service.impl.TestRepository.list(TestRepository.java:26)
>  ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.service.impl.TestServiceImpl.list(TestServiceImpl.java:25)
>  ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.cmd.ListPersonCommand.execute(ListPersonCommand.java:24)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.action.command.ActionCommand.execute(ActionCommand.java:84)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:68)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:86)
>  ~[?:?]
>     at org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:571) 
> ~[?:?]
>     at 
> org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:497) 
> ~[?:?]
>     at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:386) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.doCall(Pipe.java:417) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:229) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59) ~[?:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:?]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[?:?]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  ~[?:?]
>     at java.lang.Thread.run(Thread.java:748) [?:?]{code}
>  
> After some investigation, I have found that this bug is due to the resolution 
> of issue ARIES-1544. I have done a patch (see attached file) which solve the 
> issue I think.
> [^aries-interceptor.patch]
> Can you please integrate my patch or correct the issue another way ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARIES-1793) Blueprint interceptors do not work anymore

2018-12-03 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARIES-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707244#comment-16707244
 ] 

ASF GitHub Bot commented on ARIES-1793:
---

Smasherr opened a new pull request #670: [ARIES-1793] Upgrade to blueprint-core 
1.10.0
URL: https://github.com/apache/karaf/pull/670
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Blueprint interceptors do not work anymore
> --
>
> Key: ARIES-1793
> URL: https://issues.apache.org/jira/browse/ARIES-1793
> Project: Aries
>  Issue Type: Bug
>  Components: Blueprint
>Affects Versions: blueprint-core-1.9.0
> Environment: Karaf 4.2.0
>Reporter: Nicolas Dutertry
>Assignee: Guillaume Nodet
>Priority: Blocker
> Fix For: blueprint-core-1.10.0
>
> Attachments: aries-interceptor.patch
>
>
> I have committed a project on Github to illustrate the issue : 
> [https://github.com/nicolas-dutertry/test-jpa]
> This project contains a blueprint bundle with a bean TestRepository annotated 
> with @PersistenceContext. This bean is then injected into another bean 
> TestServiceImpl which is then published as an osgi service :
> {code:xml}
> 
>     
> 
>      class="com.dutertry.test.karaf.jpa.service.impl.TestRepository"/>
>  class="com.dutertry.test.karaf.jpa.service.impl.TestServiceImpl">
>     
>     
>  ref="testService"/>
> {code}
> With Karaf 4.1.5 the instance of TestRepository injected in testService is an 
> aries proxy managing JPA stuff, but with Karaf 4.2.0 the injected instance is 
> not a proxy. Thus when using testService, the following error occurs:
> {code:java}
> java.lang.IllegalStateException: Need active coordination
>     at 
> org.apache.aries.jpa.support.impl.EMSupplierImpl.get(EMSupplierImpl.java:81) 
> ~[?:?]
>     at org.apache.aries.jpa.support.osgi.impl.EmProxy.invoke(EmProxy.java:38) 
> ~[?:?]
>     at com.sun.proxy.$Proxy77.createQuery(Unknown Source) ~[?:?]
>     at Proxy4c2993b8_dc6f_46b4_8e62_524dc0ad05f5.createQuery(Unknown Source) 
> ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.service.impl.TestRepository.list(TestRepository.java:26)
>  ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.service.impl.TestServiceImpl.list(TestServiceImpl.java:25)
>  ~[?:?]
>     at 
> com.dutertry.test.karaf.jpa.cmd.ListPersonCommand.execute(ListPersonCommand.java:24)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.action.command.ActionCommand.execute(ActionCommand.java:84)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:68)
>  ~[?:?]
>     at 
> org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:86)
>  ~[?:?]
>     at org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:571) 
> ~[?:?]
>     at 
> org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:497) 
> ~[?:?]
>     at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:386) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.doCall(Pipe.java:417) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:229) ~[?:?]
>     at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59) ~[?:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:?]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  ~[?:?]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  ~[?:?]
>     at java.lang.Thread.run(Thread.java:748) [?:?]{code}
>  
> After some investigation, I have found that this bug is due to the resolution 
> of issue ARIES-1544. I have done a patch (see attached file) which solve the 
> issue I think.
> [^aries-interceptor.patch]
> Can you please integrate my patch or correct the issue another way ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARIES-1867) ContainerResponseFilter not fired for SSE endpoint

2018-12-03 Thread Tom Quarendon (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARIES-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706915#comment-16706915
 ] 

Tom Quarendon commented on ARIES-1867:
--

In case you were worried ( :) ) my problem was the fact I had a configuration 
pid used in two places unexpectedly. One didn't have an @modified, which caused 
odd behaviour.

 

> ContainerResponseFilter not fired for SSE endpoint
> --
>
> Key: ARIES-1867
> URL: https://issues.apache.org/jira/browse/ARIES-1867
> Project: Aries
>  Issue Type: Bug
>  Components: jax-rs-whiteboard
>Affects Versions: jax-rs-whiteboard-1.0.2
>Reporter: Tom Quarendon
>Assignee: Carlos Sierra
>Priority: Major
> Attachments: CORSFilter.java, Server.java, TestService3.java, 
> make.out, make2.out
>
>
> I have a resource class such as the following:
> {code:java}
> @Path("events")
> @JaxrsResource
> public class EventsResource {
>   private Sse sse;
>   private SseBroadcaster eventBroadcaster;
>   @Context
>   public void setSse(Sse sse) {
> this.sse = sse;
> this.eventBroadcaster = sse.newBroadcaster();
>   }
>   @GET
>   @Produces(MediaType.SERVER_SENT_EVENTS)
>   public void suscribeToEvents(@Context SseEventSink eventSink) {
> eventBroadcaster.register(eventSink);
>   }
> }
> {code}
>  
>  
> In addition, I have a CORS filter:
>  
> {code:java}
> @Component(immediate=true)
> @Provider
> @JaxrsExtension
> public class CORSFilter implements ContainerResponseFilter {
>   @Override
>   public void filter(ContainerRequestContext requestContext, 
> ContainerResponseContext responseContext) throws IOException {
> System.out.println("CORSFilter for 
> "+requestContext.getUriInfo().getPath());
> MultivaluedMap headers = responseContext.getHeaders();
> headers.add("Access-Control-Allow-Origin", 
> requestContext.getHeaderString("Origin"));
> ...
> {code}
>  
> The CORS filter gets fired on all requests as I expect, _except_ for ones to 
> the EventResource.subscribeToEvents method. Hence browsers complain when 
> receiving SSE events.
> This used to work fine with jersey as the JAXRS implementation. CORS filter 
> got called for the EventsResource.subscribeToEvents call.
> I've no idea whether this is a jaxrs-whiteboard level issue, or a CXF level 
> issue. I will try and come up with a plain CXF test of the same thing for 
> comparison.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARIES-1870) URLs are not correctly reported on Windows

2018-12-03 Thread Tom Quarendon (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARIES-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706827#comment-16706827
 ] 

Tom Quarendon commented on ARIES-1870:
--

[~csierra] Yes this now builds successfully on Windows. (sorry for late reply)

Thanks

> URLs are not correctly reported on Windows
> --
>
> Key: ARIES-1870
> URL: https://issues.apache.org/jira/browse/ARIES-1870
> Project: Aries
>  Issue Type: Bug
>  Components: jax-rs-whiteboard
>Affects Versions: jax-rs-whiteboard-1.0.2
>Reporter: Carlos Sierra
>Assignee: Carlos Sierra
>Priority: Major
> Fix For: jax-rs-whiteboard-1.0.2
>
>
> The report was using FileSystem dependent classes that have different 
> implementations depending on the operating system.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)