[jira] [Resolved] (ARIES-2042) Local discovery missing from repository

2021-09-18 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-2042.

Resolution: Fixed

I am resolving this issue as it seems to be fixed with the commit. 
Please reopen if something is still missing.

> Local discovery missing from repository
> ---
>
> Key: ARIES-2042
> URL: https://issues.apache.org/jira/browse/ARIES-2042
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.16.0
>Reporter: Amichai Rothman
>Assignee: Amichai Rothman
>Priority: Major
> Fix For: rsa-1.17.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-2043) LocalDiscovery not updated when listener scope changes

2021-09-18 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-2043.

Resolution: Fixed

I am resolving this issue as it seems to be fixed with the commit. 
Please reopen if something is still missing.

> LocalDiscovery not updated when listener scope changes
> --
>
> Key: ARIES-2043
> URL: https://issues.apache.org/jira/browse/ARIES-2043
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.16.0
>Reporter: Amichai Rothman
>Assignee: Amichai Rothman
>Priority: Major
> Fix For: rsa-1.17.0
>
>
> EnpointListenerManager updates the scope via the service properties when 
> there is a new interest in a service, but LocalDelivery does not get updated 
> accordingly, so it does not match any service listeners added after a bundle 
> is initially started.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARIES-2043) LocalDiscovery not updated when listener scope changes

2021-09-16 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/ARIES-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17415951#comment-17415951
 ] 

Christian Schneider commented on ARIES-2043:


[~amichai] I saw you committed a fix for this issue. Is this done? 

> LocalDiscovery not updated when listener scope changes
> --
>
> Key: ARIES-2043
> URL: https://issues.apache.org/jira/browse/ARIES-2043
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.16.0
>Reporter: Amichai Rothman
>Assignee: Amichai Rothman
>Priority: Major
> Fix For: rsa-1.17.0
>
>
> EnpointListenerManager updates the scope via the service properties when 
> there is a new interest in a service, but LocalDelivery does not get updated 
> accordingly, so it does not match any service listeners added after a bundle 
> is initially started.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARIES-2042) Local discovery missing from repository

2021-09-16 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/ARIES-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17415952#comment-17415952
 ] 

Christian Schneider commented on ARIES-2042:


[~amichai] I saw you committed a fix for this issue. Is this done? 

> Local discovery missing from repository
> ---
>
> Key: ARIES-2042
> URL: https://issues.apache.org/jira/browse/ARIES-2042
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.16.0
>Reporter: Amichai Rothman
>Assignee: Amichai Rothman
>Priority: Major
> Fix For: rsa-1.17.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-2060) mDNS discovery

2021-09-16 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-2060.

Resolution: Fixed

[https://github.com/apache/aries-rsa/commit/ebb97c1ed461e767172825c7ce1e27cbf4d3f26f]

[https://github.com/apache/aries-rsa/commit/410b2bd80dcc55c3b4900a32d15f1106d2c0c10e]

 

> mDNS discovery
> --
>
> Key: ARIES-2060
> URL: https://issues.apache.org/jira/browse/ARIES-2060
> Project: Aries
>  Issue Type: New Feature
>  Components: Remote Service Admin
>Reporter: Christian Schneider
>Assignee: Timothy James Ward
>Priority: Major
> Fix For: rsa-1.17.0
>
>
> Zookeeper discovery does not work properly in the OSGi TCK. So Tim added a 
> new mDNS discovery.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARIES-2060) mDNS discovery

2021-09-16 Thread Christian Schneider (Jira)
Christian Schneider created ARIES-2060:
--

 Summary: mDNS discovery
 Key: ARIES-2060
 URL: https://issues.apache.org/jira/browse/ARIES-2060
 Project: Aries
  Issue Type: New Feature
  Components: Remote Service Admin
Reporter: Christian Schneider
Assignee: Timothy James Ward
 Fix For: rsa-1.17.0


Zookeeper discovery does not work properly in the OSGi TCK. So Tim added a new 
mDNS discovery.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ARIES-2058) Aries 1.16.0 RSA fails OSGi RemoteServiceAdmin TCK test

2021-09-16 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-2058:
--

Assignee: Timothy James Ward

> Aries 1.16.0 RSA fails OSGi RemoteServiceAdmin TCK test
> ---
>
> Key: ARIES-2058
> URL: https://issues.apache.org/jira/browse/ARIES-2058
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.16.0
>Reporter: A. J. David Bosschaert
>Assignee: Timothy James Ward
>Priority: Major
> Fix For: rsa-1.17.0
>
> Attachments: aries.log
>
>
> When running the OSGi RSA TCK 13 of the 39 tests fail:
> {code:java}
> Test run finished after 458266 ms
> [11 containers found  ]
> [ 0 containers skipped]
> [11 containers started]
> [ 0 containers aborted]
> [11 containers successful ]
> [ 0 containers failed ]
> [39 tests found   ]
> [ 0 tests skipped ]
> [39 tests started ]
> [ 0 tests aborted ]
> [26 tests successful  ]
> [13 tests failed  ]
> # test ran
> # queue []
>  
> > Task :org.osgi.test.cases.remoteserviceadmin:testOSGi FAILED {code}
> To reproduce make the following change in https://github.com/osgi/osgi:
> {code}
> $ git diff
> diff --git a/cnf/ext/central.mvn b/cnf/ext/central.mvn
> index 2a8e2f44b2..e43331adac 100644
> --- a/cnf/ext/central.mvn
> +++ b/cnf/ext/central.mvn
> @@ -89,12 +89,12 @@ 
> org.apache.aries.jpa:org.apache.aries.jpa.eclipselink.adapter:2.4.0
>  org.apache.aries.spec:org.apache.aries.javax.jax.rs-api:1.0.4
>  org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle:1.0.8
>  
> org.apache.aries.spifly:org.apache.aries.spifly.dynamic.framework.extension:1.3.3
> -org.apache.aries.rsa:org.apache.aries.rsa.core:1.13.0
> -org.apache.aries.rsa:org.apache.aries.rsa.spi:1.13.0
> -org.apache.aries.rsa:org.apache.aries.rsa.topology-manager:1.13.0
> -org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.local:1.13.0
> -org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.zookeeper:1.13.0
> -org.apache.aries.rsa.provider:org.apache.aries.rsa.provider.tcp:1.13.0
> +org.apache.aries.rsa:org.apache.aries.rsa.core:1.16.0
> +org.apache.aries.rsa:org.apache.aries.rsa.spi:1.16.0
> +org.apache.aries.rsa:org.apache.aries.rsa.topology-manager:1.16.0
> +org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.local:1.16.0
> +org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.zookeeper:1.16.0
> +org.apache.aries.rsa.provider:org.apache.aries.rsa.provider.tcp:1.16.0
>  org.apache.felix:org.apache.felix.configadmin:1.9.22
>  org.apache.felix:org.apache.felix.configurator:1.0.8
> {code}
> Then run in the {{org.osgi.test.cases.remoteserviceadmin}} directory:
> {code}
> $ ../gradlew check
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-2058) Aries 1.16.0 RSA fails OSGi RemoteServiceAdmin TCK test

2021-09-16 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-2058.

Resolution: Fixed

> Aries 1.16.0 RSA fails OSGi RemoteServiceAdmin TCK test
> ---
>
> Key: ARIES-2058
> URL: https://issues.apache.org/jira/browse/ARIES-2058
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.16.0
>Reporter: A. J. David Bosschaert
>Assignee: Timothy James Ward
>Priority: Major
> Fix For: rsa-1.17.0
>
> Attachments: aries.log
>
>
> When running the OSGi RSA TCK 13 of the 39 tests fail:
> {code:java}
> Test run finished after 458266 ms
> [11 containers found  ]
> [ 0 containers skipped]
> [11 containers started]
> [ 0 containers aborted]
> [11 containers successful ]
> [ 0 containers failed ]
> [39 tests found   ]
> [ 0 tests skipped ]
> [39 tests started ]
> [ 0 tests aborted ]
> [26 tests successful  ]
> [13 tests failed  ]
> # test ran
> # queue []
>  
> > Task :org.osgi.test.cases.remoteserviceadmin:testOSGi FAILED {code}
> To reproduce make the following change in https://github.com/osgi/osgi:
> {code}
> $ git diff
> diff --git a/cnf/ext/central.mvn b/cnf/ext/central.mvn
> index 2a8e2f44b2..e43331adac 100644
> --- a/cnf/ext/central.mvn
> +++ b/cnf/ext/central.mvn
> @@ -89,12 +89,12 @@ 
> org.apache.aries.jpa:org.apache.aries.jpa.eclipselink.adapter:2.4.0
>  org.apache.aries.spec:org.apache.aries.javax.jax.rs-api:1.0.4
>  org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle:1.0.8
>  
> org.apache.aries.spifly:org.apache.aries.spifly.dynamic.framework.extension:1.3.3
> -org.apache.aries.rsa:org.apache.aries.rsa.core:1.13.0
> -org.apache.aries.rsa:org.apache.aries.rsa.spi:1.13.0
> -org.apache.aries.rsa:org.apache.aries.rsa.topology-manager:1.13.0
> -org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.local:1.13.0
> -org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.zookeeper:1.13.0
> -org.apache.aries.rsa.provider:org.apache.aries.rsa.provider.tcp:1.13.0
> +org.apache.aries.rsa:org.apache.aries.rsa.core:1.16.0
> +org.apache.aries.rsa:org.apache.aries.rsa.spi:1.16.0
> +org.apache.aries.rsa:org.apache.aries.rsa.topology-manager:1.16.0
> +org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.local:1.16.0
> +org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.zookeeper:1.16.0
> +org.apache.aries.rsa.provider:org.apache.aries.rsa.provider.tcp:1.16.0
>  org.apache.felix:org.apache.felix.configadmin:1.9.22
>  org.apache.felix:org.apache.felix.configurator:1.0.8
> {code}
> Then run in the {{org.osgi.test.cases.remoteserviceadmin}} directory:
> {code}
> $ ../gradlew check
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARIES-2058) Aries 1.16.0 RSA fails OSGi RemoteServiceAdmin TCK test

2021-09-16 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/ARIES-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17415946#comment-17415946
 ] 

Christian Schneider commented on ARIES-2058:


I got some more details about the failures from [~timothyjward] who also 
provided the fixes.
 
1. Export Registrations were not properly closed
[https://github.com/apache/aries-rsa/commit/568642c463239e8081c93eead94cb010cc598bcf]
2. The TCP provider had the intents string “osgi.basic,osgi.async” instead of a 
String[] with “osgi.basic”, “osgi.async”
[https://github.com/apache/aries-rsa/commit/2b0d2fbd086c1003d4cce12fe633bd1a755b4478]
3. The local discovery provider only injected a single event listener, not all 
event listeners
[https://github.com/apache/aries-rsa/commit/33579827bc4533fde8fdedca8313a6ec039475ce]
 
 
 
 

> Aries 1.16.0 RSA fails OSGi RemoteServiceAdmin TCK test
> ---
>
> Key: ARIES-2058
> URL: https://issues.apache.org/jira/browse/ARIES-2058
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.16.0
>Reporter: A. J. David Bosschaert
>Priority: Major
> Fix For: rsa-1.17.0
>
> Attachments: aries.log
>
>
> When running the OSGi RSA TCK 13 of the 39 tests fail:
> {code:java}
> Test run finished after 458266 ms
> [11 containers found  ]
> [ 0 containers skipped]
> [11 containers started]
> [ 0 containers aborted]
> [11 containers successful ]
> [ 0 containers failed ]
> [39 tests found   ]
> [ 0 tests skipped ]
> [39 tests started ]
> [ 0 tests aborted ]
> [26 tests successful  ]
> [13 tests failed  ]
> # test ran
> # queue []
>  
> > Task :org.osgi.test.cases.remoteserviceadmin:testOSGi FAILED {code}
> To reproduce make the following change in https://github.com/osgi/osgi:
> {code}
> $ git diff
> diff --git a/cnf/ext/central.mvn b/cnf/ext/central.mvn
> index 2a8e2f44b2..e43331adac 100644
> --- a/cnf/ext/central.mvn
> +++ b/cnf/ext/central.mvn
> @@ -89,12 +89,12 @@ 
> org.apache.aries.jpa:org.apache.aries.jpa.eclipselink.adapter:2.4.0
>  org.apache.aries.spec:org.apache.aries.javax.jax.rs-api:1.0.4
>  org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle:1.0.8
>  
> org.apache.aries.spifly:org.apache.aries.spifly.dynamic.framework.extension:1.3.3
> -org.apache.aries.rsa:org.apache.aries.rsa.core:1.13.0
> -org.apache.aries.rsa:org.apache.aries.rsa.spi:1.13.0
> -org.apache.aries.rsa:org.apache.aries.rsa.topology-manager:1.13.0
> -org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.local:1.13.0
> -org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.zookeeper:1.13.0
> -org.apache.aries.rsa.provider:org.apache.aries.rsa.provider.tcp:1.13.0
> +org.apache.aries.rsa:org.apache.aries.rsa.core:1.16.0
> +org.apache.aries.rsa:org.apache.aries.rsa.spi:1.16.0
> +org.apache.aries.rsa:org.apache.aries.rsa.topology-manager:1.16.0
> +org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.local:1.16.0
> +org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.zookeeper:1.16.0
> +org.apache.aries.rsa.provider:org.apache.aries.rsa.provider.tcp:1.16.0
>  org.apache.felix:org.apache.felix.configadmin:1.9.22
>  org.apache.felix:org.apache.felix.configurator:1.0.8
> {code}
> Then run in the {{org.osgi.test.cases.remoteserviceadmin}} directory:
> {code}
> $ ../gradlew check
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARIES-2058) Aries 1.16.0 RSA fails OSGi RemoteServiceAdmin TCK test

2021-09-16 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-2058:
---
Fix Version/s: rsa-1.17.0

> Aries 1.16.0 RSA fails OSGi RemoteServiceAdmin TCK test
> ---
>
> Key: ARIES-2058
> URL: https://issues.apache.org/jira/browse/ARIES-2058
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.16.0
>Reporter: A. J. David Bosschaert
>Priority: Major
> Fix For: rsa-1.17.0
>
> Attachments: aries.log
>
>
> When running the OSGi RSA TCK 13 of the 39 tests fail:
> {code:java}
> Test run finished after 458266 ms
> [11 containers found  ]
> [ 0 containers skipped]
> [11 containers started]
> [ 0 containers aborted]
> [11 containers successful ]
> [ 0 containers failed ]
> [39 tests found   ]
> [ 0 tests skipped ]
> [39 tests started ]
> [ 0 tests aborted ]
> [26 tests successful  ]
> [13 tests failed  ]
> # test ran
> # queue []
>  
> > Task :org.osgi.test.cases.remoteserviceadmin:testOSGi FAILED {code}
> To reproduce make the following change in https://github.com/osgi/osgi:
> {code}
> $ git diff
> diff --git a/cnf/ext/central.mvn b/cnf/ext/central.mvn
> index 2a8e2f44b2..e43331adac 100644
> --- a/cnf/ext/central.mvn
> +++ b/cnf/ext/central.mvn
> @@ -89,12 +89,12 @@ 
> org.apache.aries.jpa:org.apache.aries.jpa.eclipselink.adapter:2.4.0
>  org.apache.aries.spec:org.apache.aries.javax.jax.rs-api:1.0.4
>  org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle:1.0.8
>  
> org.apache.aries.spifly:org.apache.aries.spifly.dynamic.framework.extension:1.3.3
> -org.apache.aries.rsa:org.apache.aries.rsa.core:1.13.0
> -org.apache.aries.rsa:org.apache.aries.rsa.spi:1.13.0
> -org.apache.aries.rsa:org.apache.aries.rsa.topology-manager:1.13.0
> -org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.local:1.13.0
> -org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.zookeeper:1.13.0
> -org.apache.aries.rsa.provider:org.apache.aries.rsa.provider.tcp:1.13.0
> +org.apache.aries.rsa:org.apache.aries.rsa.core:1.16.0
> +org.apache.aries.rsa:org.apache.aries.rsa.spi:1.16.0
> +org.apache.aries.rsa:org.apache.aries.rsa.topology-manager:1.16.0
> +org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.local:1.16.0
> +org.apache.aries.rsa.discovery:org.apache.aries.rsa.discovery.zookeeper:1.16.0
> +org.apache.aries.rsa.provider:org.apache.aries.rsa.provider.tcp:1.16.0
>  org.apache.felix:org.apache.felix.configadmin:1.9.22
>  org.apache.felix:org.apache.felix.configurator:1.0.8
> {code}
> Then run in the {{org.osgi.test.cases.remoteserviceadmin}} directory:
> {code}
> $ ../gradlew check
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ARIES-2039) Aspire Health Network

2021-02-15 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider closed ARIES-2039.
--
Resolution: Invalid

> Aspire Health Network
> -
>
> Key: ARIES-2039
> URL: https://issues.apache.org/jira/browse/ARIES-2039
> Project: Aries
>  Issue Type: Project
>Reporter: Aspire Health Network
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARIES-2039) Aspire Health Network

2021-02-15 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-2039:
---
Description: (was:                                               
!ahn-logo-80h.png!

The [*Aspire Health 
Network*|https://aspirehealthnetwork.com/best-place-to-buy-soma-online-in-usa/] 
is the nation's leading provider of drug rehab centers. We are committed to 
providing the highest caliber of medical, therapeutic, and holistic care for 
individuals in need of treatment for addiction and alcoholism. We believe that 
everyone's situation is unique, and that each individual should be matched to a 
rehab facility that fits their specific needs. Our mission is to help as many 
people as possible find life long sobriety and happiness.)

> Aspire Health Network
> -
>
> Key: ARIES-2039
> URL: https://issues.apache.org/jira/browse/ARIES-2039
> Project: Aries
>  Issue Type: Project
>Reporter: Aspire Health Network
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARIES-2039) Aspire Health Network

2021-02-15 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-2039:
---
Attachment: (was: ahn-logo-80h.png)

> Aspire Health Network
> -
>
> Key: ARIES-2039
> URL: https://issues.apache.org/jira/browse/ARIES-2039
> Project: Aries
>  Issue Type: Project
>Reporter: Aspire Health Network
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ARIES-1943) TopologyManagerImport assumes all referenced ImportRegistrations are not closed

2021-02-15 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1943:
--

Assignee: Christian Schneider

> TopologyManagerImport assumes all referenced ImportRegistrations are not 
> closed
> ---
>
> Key: ARIES-1943
> URL: https://issues.apache.org/jira/browse/ARIES-1943
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
>Reporter: Arnoud Glimmerveen
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.16.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When an ImportRegistration is closed, all other methods must return null. 
> Obtaining for instance the ImportReference after close is therefor not 
> possible and the associated getter is expected to return null.
> The current importer logic appears to assume that at least the 
> ImportReference can always be obtained. This holds true when assuming that 
> only a single thread performs the import task, however de current 
> implementation uses up to 10 Threads. In that case whilst one Thread is busy 
> closing an ImportRegistration, another may already have the reference to it 
> and without the check for null will run into a NPE.
> Note that apparently the Apache Aries RSA implementation does not have 
> ImportRegistration.getImportReference() return null after close, which is I 
> guess the reason why this has gone unnoticed. Looking at the 
> [spec|https://osgi.org/specification/osgi.cmpn/7.0.0/service.remoteserviceadmin.html#org.osgi.service.remoteserviceadmin.ImportRegistration]
>  this in itself should also be considered a bug.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARIES-1943) TopologyManagerImport assumes all referenced ImportRegistrations are not closed

2021-02-15 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/ARIES-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284676#comment-17284676
 ] 

Christian Schneider commented on ARIES-1943:


I just tried a build and it worked without test failures. So I will try to do a 
release.

> TopologyManagerImport assumes all referenced ImportRegistrations are not 
> closed
> ---
>
> Key: ARIES-1943
> URL: https://issues.apache.org/jira/browse/ARIES-1943
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
>Reporter: Arnoud Glimmerveen
>Priority: Major
> Fix For: rsa-1.15.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When an ImportRegistration is closed, all other methods must return null. 
> Obtaining for instance the ImportReference after close is therefor not 
> possible and the associated getter is expected to return null.
> The current importer logic appears to assume that at least the 
> ImportReference can always be obtained. This holds true when assuming that 
> only a single thread performs the import task, however de current 
> implementation uses up to 10 Threads. In that case whilst one Thread is busy 
> closing an ImportRegistration, another may already have the reference to it 
> and without the check for null will run into a NPE.
> Note that apparently the Apache Aries RSA implementation does not have 
> ImportRegistration.getImportReference() return null after close, which is I 
> guess the reason why this has gone unnoticed. Looking at the 
> [spec|https://osgi.org/specification/osgi.cmpn/7.0.0/service.remoteserviceadmin.html#org.osgi.service.remoteserviceadmin.ImportRegistration]
>  this in itself should also be considered a bug.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-1944) Make sure closed import registrations are cleaned up

2020-10-12 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1944.

Resolution: Fixed

> Make sure closed import registrations are cleaned up
> 
>
> Key: ARIES-1944
> URL: https://issues.apache.org/jira/browse/ARIES-1944
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently we use TopologyManagerImport.unimportService to close and remove 
> import registrations.
> If a registration is closed by another thread then 
> ImportRegistration.getImportRefernce might already return null. So we should 
> have a safer way to remove the registrations.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARIES-1988) Code comment with issue numbers

2020-06-23 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/ARIES-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143535#comment-17143535
 ] 

Christian Schneider commented on ARIES-1988:


Sometimes it makes sense to have such comments pointing to issues but it should 
be a very rare case. Instead the code should be made cleaner and more obvious.

> Code comment with issue numbers
> ---
>
> Key: ARIES-1988
> URL: https://issues.apache.org/jira/browse/ARIES-1988
> Project: Aries
>  Issue Type: Improvement
>Reporter: ackelcn
>Priority: Major
>
> When I read the code of aries, I find some comments with issue numbers. One 
> of them comes from AbstractServiceRegistryContext.java:
> {code:java}
> public AbstractServiceRegistryContext(BundleContext callerContext, 
> Hashtable environment) {
>...
>env.putAll((Map) environment);
> // ARIES-397:, If the caller has provided a BundleContext
> // in the hashtable, use this in preference to callerContext
> if (augmenterInvoker == null && callerContext != null) {
> ServiceReference augmenterSR = 
> callerContext.getServiceReference(AugmenterInvoker.class.getName());
> if (augmenterSR != null) augmenterInvoker = (AugmenterInvoker) 
> callerContext.getService(augmenterSR);
> }
> }{code}
> These comments are quite useful for other programmers and me to understand 
> the code, but I notice that not all issue numbers are written in code 
> comments. It can be already quite tedious to write them into commit messages 
> :)
>  
> To handle the problem, I implemented a tool to automatically instrument issue 
> numbers into code comments. I tried my tool on activemq, and the instrumented 
> version is [https://github.com/ackelcn/aries] 
> [ |https://github.com/ackelcn/arieswithissuecomment]
> To avoid confusion, if there is already an issue number in code comments, my 
> tool ignored the issue number. All my generated comments start from //IC, so 
> it is easy to find them.
>  
> Would you please some feedbacks to my tool? Please feel free to merge my 
> generated comments in your code, if you feel that some are useful.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARIES-1988) Code comment with issue numbers

2020-06-23 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/ARIES-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143533#comment-17143533
 ] 

Christian Schneider commented on ARIES-1988:


I think this is a very bad idea. Github can already provide this functionality. 
Adding the comments in the code just lets them rot from there on. For every 
code change you then have to carefully move / remove add comments. Typically 
people are too afraid of removing them so they simply would pile up.

> Code comment with issue numbers
> ---
>
> Key: ARIES-1988
> URL: https://issues.apache.org/jira/browse/ARIES-1988
> Project: Aries
>  Issue Type: Improvement
>Reporter: ackelcn
>Priority: Major
>
> When I read the code of aries, I find some comments with issue numbers. One 
> of them comes from AbstractServiceRegistryContext.java:
> {code:java}
> public AbstractServiceRegistryContext(BundleContext callerContext, 
> Hashtable environment) {
>...
>env.putAll((Map) environment);
> // ARIES-397:, If the caller has provided a BundleContext
> // in the hashtable, use this in preference to callerContext
> if (augmenterInvoker == null && callerContext != null) {
> ServiceReference augmenterSR = 
> callerContext.getServiceReference(AugmenterInvoker.class.getName());
> if (augmenterSR != null) augmenterInvoker = (AugmenterInvoker) 
> callerContext.getService(augmenterSR);
> }
> }{code}
> These comments are quite useful for other programmers and me to understand 
> the code, but I notice that not all issue numbers are written in code 
> comments. It can be already quite tedious to write them into commit messages 
> :)
>  
> To handle the problem, I implemented a tool to automatically instrument issue 
> numbers into code comments. I tried my tool on activemq, and the instrumented 
> version is [https://github.com/ackelcn/aries] 
> [ |https://github.com/ackelcn/arieswithissuecomment]
> To avoid confusion, if there is already an issue number in code comments, my 
> tool ignored the issue number. All my generated comments start from //IC, so 
> it is easy to find them.
>  
> Would you please some feedbacks to my tool? Please feel free to merge my 
> generated comments in your code, if you feel that some are useful.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARIES-1975) JAX-RS impl in Adobe Experience Manager

2020-04-16 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/ARIES-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084954#comment-17084954
 ] 

Christian Schneider commented on ARIES-1975:


What error do you get?

> JAX-RS impl in Adobe Experience Manager
> ---
>
> Key: ARIES-1975
> URL: https://issues.apache.org/jira/browse/ARIES-1975
> Project: Aries
>  Issue Type: Question
>  Components: jax-rs-whiteboard
>Affects Versions: jax-rs-whiteboard-1.0.7
>Reporter: Matija Kovacek
>Priority: Minor
>
>  
> {code:java}
> {code}
> I'm trying to use JAX-RS in AEM (OSGi), but my bundle is not active because 
> of missing requirements.
> Can you try to tell me what I'm missing? Should I use 
> org.apache.aries.jax.rs.whiteboard or both, something else?
>  
> org.apache.aries.javax.jax.rs-api is installed as a separate bundle and it's 
> active
> {code:java}
> // org.osgi.framework.BundleException: Unable to resolve com.aem.demo.core 
> [603](R 603.11): missing requirement [com.aem.demo.core [603](R 603.11)] 
> osgi.implementation; 
> (&(osgi.implementation=osgi.jaxrs)(version>=1.0.0)(!(version>=2.0.0))) 
> Unresolved requirements: [[com.aem.demo.core [603](R 603.11)] 
> osgi.implementation; 
> (&(osgi.implementation=osgi.jaxrs)(version>=1.0.0)(!(version>=2.0.0)))]
> 
> org.osgi
> osgi.core
> 7.0.0
> provided
> 
> 
> org.osgi
> osgi.cmpn
> 7.0.0
> provided
> 
> 
> org.osgi
> osgi.annotation
> 7.0.0
> provided
> 
> 
> org.osgi
> org.osgi.service.component.annotations
> 1.4.0
> provided
> 
> 
> org.osgi
> org.osgi.service.metatype.annotations
> 1.4.0
> provided
> 
> 
> org.osgi
> org.osgi.service.component
> 1.4.0
> provided
> 
> 
> biz.aQute.bnd
> biz.aQute.bndlib
> 5.0.0
> provided
> 
> 
> org.apache.aries.spec
> org.apache.aries.javax.jax.rs-api
> 1.0.4
> provided
> 
> {code}
> Manifest of my bundle
>  
> {code:java}
> // Symbolic Name   com.aem.demo.core
> Version 1.0.0.20200225143408035
> Bundle Location 
> jcrinstall:/apps/my-aem-project/install/com.aem.demo.core-1.0.0-SNAPSHOT.jar
> Last Modification   Tue Feb 25 15:34:51 CET 2020
> Description "Core bundle for My AEM Project"
> Start Level 20
> Exported Packages   com.aem.demo.core.controllers,version=1.0
> com.aem.demo.core.dto,version=1.0
> com.aem.demo.core.filters,version=1.0
> com.aem.demo.core.listeners,version=1.0
> com.aem.demo.core.models,version=1.0
> com.aem.demo.core.schedulers,version=1.0
> com.aem.demo.core.services,version=1.0
> com.aem.demo.core.servlets,version=1.0
> Imported Packages   com.day.cq.wcm.api,version=[1.27,2) from 
> com.day.cq.wcm.cq-wcm-api (461)
> com.aem.demo.core.controllers,version=[1.0,2) from com.aem.demo.core (603)
> com.aem.demo.core.dto,version=[1.0,2) from com.aem.demo.core (603)
> com.aem.demo.core.filters,version=[1.0,2) from com.aem.demo.core (603)
> com.aem.demo.core.listeners,version=[1.0,2) from com.aem.demo.core (603)
> com.aem.demo.core.servlets,version=[1.0,2) from com.aem.demo.core (603)
> javax.annotation,version=0.0.0 from 
> org.apache.geronimo.specs.geronimo-annotation_1.3_spec (2)
> javax.servlet,version=[2.6,3) from org.apache.felix.http.servlet-api (52)
> javax.ws.rs from org.apache.aries.javax.jax.rs-api (598)
> org.apache.sling.api,version=[2.3,3) from org.apache.sling.api (77)
> org.apache.sling.api.request,version=[2.4,3) from org.apache.sling.api (77)
> org.apache.sling.api.resource,version=[2.11,3) from org.apache.sling.api (77)
> org.apache.sling.api.servlets,version=[2.2,3) from org.apache.sling.api (77)
> org.apache.sling.models.annotations,version=[1.5,2) from 
> org.apache.sling.models.api (543)
> org.apache.sling.models.annotations.injectorspecific,version=[1.1,2) from 
> org.apache.sling.models.api (543)
> org.apache.sling.settings,version=[1.3,2) from org.apache.sling.settings (4)
> org.osgi.service.event,version=[1.4,2) from org.apache.felix.eventadmin (40)
> org.slf4j,version=[1.7,2) from slf4j.api (7)
> Manifest HeadersBnd-LastModified: 1582641248035
> Build-Jdk-Spec: 1.8
> Bundle-Category: demo
> Bundle-Description: "Core bundle for My AEM Project"
> Bundle-ManifestVersion: 2
> Bundle-Name: My AEM Project - Core
> Bundle-SymbolicName: com.aem.demo.core
> Bundle-Version: 1.0.0.20200225143408035
> Created-By: 1.8.0_162 (Oracle Corporation)
> Export-Package: com.aem.demo.core.controllers; 

[jira] [Closed] (ARIES-1777) need to add aries-blueprint as a dependency to jpa feature

2019-12-23 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider closed ARIES-1777.
--
Resolution: Abandoned

> need to add aries-blueprint as a dependency to jpa feature
> --
>
> Key: ARIES-1777
> URL: https://issues.apache.org/jira/browse/ARIES-1777
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.6.1
>Reporter: AmirMohammad Vosough
>Assignee: Christian Schneider
>Priority: Major
>  Labels: easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When working on Vaseline framework, I faced this problem:
> After using karaf-assembly I found out I can not have jpa as a startup 
> feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ARIES-1488) Add OBR repository for blueprint bundles

2019-12-23 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1488:
--

Assignee: (was: Christian Schneider)

> Add OBR repository for blueprint bundles
> 
>
> Key: ARIES-1488
> URL: https://issues.apache.org/jira/browse/ARIES-1488
> Project: Aries
>  Issue Type: New Feature
>  Components: Blueprint
>Reporter: Christian Schneider
>Priority: Major
> Fix For: blueprint-repository-1.6.0
>
>
> Use the bnd-indexer-plugin to create an OBR repository for a consistent set 
> of blueprint bundles.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ARIES-1512) Create chronicle provider

2019-12-23 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1512:
--

Assignee: (was: Christian Schneider)

> Create chronicle provider
> -
>
> Key: ARIES-1512
> URL: https://issues.apache.org/jira/browse/ARIES-1512
> Project: Aries
>  Issue Type: New Feature
>  Components: Remote Service Admin
>Reporter: Christian Schneider
>Priority: Major
> Fix For: rsa-2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-1934) Make sure jar/zip files are jailed to the destination directory

2019-11-18 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1934.

Fix Version/s: spifly-1.2.4
   Resolution: Fixed

> Make sure jar/zip files are jailed to the destination directory
> ---
>
> Key: ARIES-1934
> URL: https://issues.apache.org/jira/browse/ARIES-1934
> Project: Aries
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Assignee: Christian Schneider
>Priority: Major
> Fix For: spifly-1.2.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There are a number of locations in Aries where we unzip a jar or zip file to 
> the filesystem, without checking that the all of the files are jailed to the 
> intended destination directory. This is a potential security issue as it 
> allows an attacked to overwrite files on the system outside of the intended 
> directory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ARIES-1934) Make sure jar/zip files are jailed to the destination directory

2019-11-18 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1934:
--

Assignee: Christian Schneider

> Make sure jar/zip files are jailed to the destination directory
> ---
>
> Key: ARIES-1934
> URL: https://issues.apache.org/jira/browse/ARIES-1934
> Project: Aries
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Assignee: Christian Schneider
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are a number of locations in Aries where we unzip a jar or zip file to 
> the filesystem, without checking that the all of the files are jailed to the 
> intended destination directory. This is a potential security issue as it 
> allows an attacked to overwrite files on the system outside of the intended 
> directory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARIES-1887) org.apache.aries.transaction.blueprint is not thread safe

2019-11-18 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/ARIES-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976358#comment-16976358
 ] 

Christian Schneider commented on ARIES-1887:


I was just going through the old PRs. Any news about this one? [~jbonofre]

> org.apache.aries.transaction.blueprint is not thread safe
> -
>
> Key: ARIES-1887
> URL: https://issues.apache.org/jira/browse/ARIES-1887
> Project: Aries
>  Issue Type: Bug
>  Components: Transaction
>Affects Versions: transaction-blueprint-2.2.0
>Reporter: Nicolas Dutertry
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: transaction-blueprint-2.3.0
>
>
> The class ComponentTxData in org.apache.aries.transaction.blueprint uses a 
> HashMap
> {code:java}
> private Map txMap = new 
> HashMap();{code}
> This is very dangerous because txMap can be modified and accessed after 
> initialization.
> It should be replaced with a ConcurrentHashMap.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARIES-1942) Use annotation based bundle config

2019-11-10 Thread Christian Schneider (Jira)
Christian Schneider created ARIES-1942:
--

 Summary: Use annotation based bundle config
 Key: ARIES-1942
 URL: https://issues.apache.org/jira/browse/ARIES-1942
 Project: Aries
  Issue Type: Improvement
  Components: Remote Service Admin
Affects Versions: rsa-1.14.0
Reporter: Christian Schneider
Assignee: Christian Schneider
 Fix For: rsa-1.15.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-1941) Thread unsafe iteration of thread-safe MultiMap by TopologyManagerImport

2019-11-09 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1941.

Resolution: Fixed

Many thanks for this fix. 

I plan to do a release in about a week . Let me know if you plan to get more 
changes in.

 

> Thread unsafe iteration of thread-safe MultiMap by TopologyManagerImport
> 
>
> Key: ARIES-1941
> URL: https://issues.apache.org/jira/browse/ARIES-1941
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
>Reporter: Arnoud Glimmerveen
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The TopologyMangerImport class uses the MultiMap (Map>). The 
> operations on the MultiMap itself are thread safe (by means of synchronised 
> keyword), however in some cases the Set value is obtained and iterated 
> over, without holding the right mutex. As a result you may see 
> ConcurrentModificationExceptions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-1780) Switch Zookeeper Discovery to DS

2019-11-09 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1780.

Resolution: Fixed

> Switch Zookeeper Discovery to DS
> 
>
> Key: ARIES-1780
> URL: https://issues.apache.org/jira/browse/ARIES-1780
> Project: Aries
>  Issue Type: Improvement
>  Components: Remote Service Admin
>Affects Versions: rsa-1.11.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARIES-1941) Thread unsafe iteration of thread-safe MultiMap by TopologyManagerImport

2019-11-09 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1941:
---
Fix Version/s: rsa-1.15.0

> Thread unsafe iteration of thread-safe MultiMap by TopologyManagerImport
> 
>
> Key: ARIES-1941
> URL: https://issues.apache.org/jira/browse/ARIES-1941
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
>Reporter: Arnoud Glimmerveen
>Priority: Major
> Fix For: rsa-1.15.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The TopologyMangerImport class uses the MultiMap (Map>). The 
> operations on the MultiMap itself are thread safe (by means of synchronised 
> keyword), however in some cases the Set value is obtained and iterated 
> over, without holding the right mutex. As a result you may see 
> ConcurrentModificationExceptions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ARIES-1941) Thread unsafe iteration of thread-safe MultiMap by TopologyManagerImport

2019-11-09 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1941:
--

Assignee: Christian Schneider

> Thread unsafe iteration of thread-safe MultiMap by TopologyManagerImport
> 
>
> Key: ARIES-1941
> URL: https://issues.apache.org/jira/browse/ARIES-1941
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
>Reporter: Arnoud Glimmerveen
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The TopologyMangerImport class uses the MultiMap (Map>). The 
> operations on the MultiMap itself are thread safe (by means of synchronised 
> keyword), however in some cases the Set value is obtained and iterated 
> over, without holding the right mutex. As a result you may see 
> ConcurrentModificationExceptions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARIES-1940) Failure during service export is not properly handled by RemoteServiceAdminCore

2019-11-09 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/ARIES-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970933#comment-16970933
 ] 

Christian Schneider commented on ARIES-1940:


I think you are right about the cleanup. Do you have an idea how to improve 
this?

> Failure during service export is not properly handled by 
> RemoteServiceAdminCore
> ---
>
> Key: ARIES-1940
> URL: https://issues.apache.org/jira/browse/ARIES-1940
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
> Environment: Apache Aries 1.14.0
> Apache Felix Framework 6.0.2
>Reporter: Arnoud Glimmerveen
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When a DistributionProvider throws an Exception from the 
> DistributionProvider.exportService() method, the RemoteServiceAdminCore 
> detects this properly and keeps track of this failure by creating a 
> ExportRegistration instance that references the thrown Exception.
> The specification mandates that if a service export failed, the 
> ExportRegistration should provide access to the thrown Exception (which the 
> current implementation does) and that the ExportReference of the 
> ExportRegistration should throw an IllegalStateException.
> The current implementation of RemoteServiceAdminCore handles this in an 
> inconsistent way:
> * The ExportRegistration.getExportReference() returns null rather then 
> throwing the IllegalStateException
> * The use of ExportRegistration assumes that there always is an 
> ExportReference instance. This assumption is wrong in cases that the export 
> failed.
> The latter triggers exceptions such as as the one below; typically triggered 
> by an event unrelated to the export service failure:
> {noformat}
> java.lang.NullPointerException
> at 
> org.apache.aries.rsa.core.RemoteServiceAdminCore.removeServiceExports(RemoteServiceAdminCore.java:505)
> at 
> org.apache.aries.rsa.core.RemoteServiceAdminCore$2.serviceChanged(RemoteServiceAdminCore.java:104)
> at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
> at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
> at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
> at 
> org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
> at org.apache.felix.framework.Felix.access$000(Felix.java:112)
> at 
> org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:434)
> at 
> org.apache.felix.framework.ServiceRegistry.unregisterService(ServiceRegistry.java:170)
> at 
> org.apache.felix.framework.ServiceRegistrationImpl.unregister(ServiceRegistrationImpl.java:145)
> ...
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARIES-1675) Provide a module to run the tck tests

2019-11-09 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1675:
---
Fix Version/s: (was: rsa-1.15.0)
   rsa-2.0.0

> Provide a module to run the tck tests
> -
>
> Key: ARIES-1675
> URL: https://issues.apache.org/jira/browse/ARIES-1675
> Project: Aries
>  Issue Type: Test
>  Components: Remote Service Admin
>Affects Versions: rsa-1.9.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARIES-1614) Support callback for TopologyManager to change the published properties

2019-11-09 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1614:
---
Fix Version/s: (was: rsa-1.15.0)
   rsa-2.0.0

> Support callback for TopologyManager to change the published properties
> ---
>
> Key: ARIES-1614
> URL: https://issues.apache.org/jira/browse/ARIES-1614
> Project: Aries
>  Issue Type: New Feature
>  Components: Remote Service Admin
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-2.0.0
>
>
> We currently have the DiscoveryPlugin spi in zookeeper discovery that allows 
> to change properties before they are placed in zookeeper. As this SPI 
> currently can not be used (the spi package is private) we can also try to 
> improve this model.
> The idea is to move the property changing SPI to TopologyManager. It would be 
> called before each Endpoint is published. This would allow to provide the 
> same adapted view of the Endpoint for all EndpointListeners. So the changed 
> proerties would for example also be visible in the endpoint shell command.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-1836) Test failure in TestFastbinRoundTrip: SocketException: Invalid argument

2019-11-09 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1836.

  Assignee: Christian Schneider
Resolution: Cannot Reproduce

I can not reproduce test failures anymore. All recent builds succeeded.

> Test failure in TestFastbinRoundTrip: SocketException: Invalid argument
> ---
>
> Key: ARIES-1836
> URL: https://issues.apache.org/jira/browse/ARIES-1836
> Project: Aries
>  Issue Type: Test
>  Components: Remote Service Admin
>Affects Versions: rsa-1.12.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>
> Sometimes TestFastbinRoundTrip still fails with these exceptions being shown:
> [https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d]
> ConnectException 
> [https://gist.github.com/cschneider/48b8b72bf972e4da0a01021341fa5bfe]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-1940) Failure during service export is not properly handled by RemoteServiceAdminCore

2019-11-08 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1940.

  Assignee: Christian Schneider
Resolution: Fixed

Many thanks for the PR. 

> Failure during service export is not properly handled by 
> RemoteServiceAdminCore
> ---
>
> Key: ARIES-1940
> URL: https://issues.apache.org/jira/browse/ARIES-1940
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
> Environment: Apache Aries 1.14.0
> Apache Felix Framework 6.0.2
>Reporter: Arnoud Glimmerveen
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When a DistributionProvider throws an Exception from the 
> DistributionProvider.exportService() method, the RemoteServiceAdminCore 
> detects this properly and keeps track of this failure by creating a 
> ExportRegistration instance that references the thrown Exception.
> The specification mandates that if a service export failed, the 
> ExportRegistration should provide access to the thrown Exception (which the 
> current implementation does) and that the ExportReference of the 
> ExportRegistration should throw an IllegalStateException.
> The current implementation of RemoteServiceAdminCore handles this in an 
> inconsistent way:
> * The ExportRegistration.getExportReference() returns null rather then 
> throwing the IllegalStateException
> * The use of ExportRegistration assumes that there always is an 
> ExportReference instance. This assumption is wrong in cases that the export 
> failed.
> The latter triggers exceptions such as as the one below; typically triggered 
> by an event unrelated to the export service failure:
> {noformat}
> java.lang.NullPointerException
> at 
> org.apache.aries.rsa.core.RemoteServiceAdminCore.removeServiceExports(RemoteServiceAdminCore.java:505)
> at 
> org.apache.aries.rsa.core.RemoteServiceAdminCore$2.serviceChanged(RemoteServiceAdminCore.java:104)
> at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
> at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
> at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
> at 
> org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
> at org.apache.felix.framework.Felix.access$000(Felix.java:112)
> at 
> org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:434)
> at 
> org.apache.felix.framework.ServiceRegistry.unregisterService(ServiceRegistry.java:170)
> at 
> org.apache.felix.framework.ServiceRegistrationImpl.unregister(ServiceRegistrationImpl.java:145)
> ...
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARIES-1940) Failure during service export is not properly handled by RemoteServiceAdminCore

2019-11-08 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1940:
---
Fix Version/s: rsa-1.15.0

> Failure during service export is not properly handled by 
> RemoteServiceAdminCore
> ---
>
> Key: ARIES-1940
> URL: https://issues.apache.org/jira/browse/ARIES-1940
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
> Environment: Apache Aries 1.14.0
> Apache Felix Framework 6.0.2
>Reporter: Arnoud Glimmerveen
>Priority: Major
> Fix For: rsa-1.15.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When a DistributionProvider throws an Exception from the 
> DistributionProvider.exportService() method, the RemoteServiceAdminCore 
> detects this properly and keeps track of this failure by creating a 
> ExportRegistration instance that references the thrown Exception.
> The specification mandates that if a service export failed, the 
> ExportRegistration should provide access to the thrown Exception (which the 
> current implementation does) and that the ExportReference of the 
> ExportRegistration should throw an IllegalStateException.
> The current implementation of RemoteServiceAdminCore handles this in an 
> inconsistent way:
> * The ExportRegistration.getExportReference() returns null rather then 
> throwing the IllegalStateException
> * The use of ExportRegistration assumes that there always is an 
> ExportReference instance. This assumption is wrong in cases that the export 
> failed.
> The latter triggers exceptions such as as the one below; typically triggered 
> by an event unrelated to the export service failure:
> {noformat}
> java.lang.NullPointerException
> at 
> org.apache.aries.rsa.core.RemoteServiceAdminCore.removeServiceExports(RemoteServiceAdminCore.java:505)
> at 
> org.apache.aries.rsa.core.RemoteServiceAdminCore$2.serviceChanged(RemoteServiceAdminCore.java:104)
> at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
> at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
> at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
> at 
> org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
> at org.apache.felix.framework.Felix.access$000(Felix.java:112)
> at 
> org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:434)
> at 
> org.apache.felix.framework.ServiceRegistry.unregisterService(ServiceRegistry.java:170)
> at 
> org.apache.felix.framework.ServiceRegistrationImpl.unregister(ServiceRegistrationImpl.java:145)
> ...
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-1937) Require Java 8

2019-10-29 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1937.

Resolution: Fixed

> Require Java 8
> --
>
> Key: ARIES-1937
> URL: https://issues.apache.org/jira/browse/ARIES-1937
> Project: Aries
>  Issue Type: Improvement
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARIES-1937) Require Java 8

2019-10-29 Thread Christian Schneider (Jira)
Christian Schneider created ARIES-1937:
--

 Summary: Require Java 8
 Key: ARIES-1937
 URL: https://issues.apache.org/jira/browse/ARIES-1937
 Project: Aries
  Issue Type: Improvement
  Components: Remote Service Admin
Affects Versions: rsa-1.14.0
Reporter: Christian Schneider
Assignee: Christian Schneider
 Fix For: rsa-1.15.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARIES-1936) Switch zookeeper starter to DS and mockito

2019-10-28 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1936.

Resolution: Fixed

> Switch zookeeper starter to DS and mockito
> --
>
> Key: ARIES-1936
> URL: https://issues.apache.org/jira/browse/ARIES-1936
> Project: Aries
>  Issue Type: Improvement
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARIES-1936) Switch zookeeper starter to DS and mockito

2019-10-28 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1936:
---
Affects Version/s: (was: rsa-1.13.0)
   rsa-1.14.0

> Switch zookeeper starter to DS and mockito
> --
>
> Key: ARIES-1936
> URL: https://issues.apache.org/jira/browse/ARIES-1936
> Project: Aries
>  Issue Type: Improvement
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARIES-1936) Switch zookeeper starter to DS and mockito

2019-10-28 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/ARIES-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1936:
---
Fix Version/s: (was: rsa-1.14.0)
   rsa-1.15.0

> Switch zookeeper starter to DS and mockito
> --
>
> Key: ARIES-1936
> URL: https://issues.apache.org/jira/browse/ARIES-1936
> Project: Aries
>  Issue Type: Improvement
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARIES-1936) Switch zookeeper starter to DS and mockito

2019-10-28 Thread Christian Schneider (Jira)
Christian Schneider created ARIES-1936:
--

 Summary: Switch zookeeper starter to DS and mockito
 Key: ARIES-1936
 URL: https://issues.apache.org/jira/browse/ARIES-1936
 Project: Aries
  Issue Type: Improvement
  Components: Remote Service Admin
Affects Versions: rsa-1.13.0
Reporter: Christian Schneider
Assignee: Christian Schneider
 Fix For: rsa-1.14.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARIES-1932) Karaf feature lacks the "features" classifier

2019-09-26 Thread Christian Schneider (Jira)


[ 
https://issues.apache.org/jira/browse/ARIES-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938478#comment-16938478
 ] 

Christian Schneider commented on ARIES-1932:


The features classifier is not mandatory for karaf features. You only need a 
slightly different feature repo url.

Try this one: 

{{feature:repo-add 
mvn:org.apache.aries.jax.rs/org.apache.aries.jax.rs.features/1.0.5/xml}}

{{I hope this url also works for a custom distro. If not then let me know.}}

> Karaf feature lacks the "features" classifier
> -
>
> Key: ARIES-1932
> URL: https://issues.apache.org/jira/browse/ARIES-1932
> Project: Aries
>  Issue Type: Bug
>  Components: jax-rs-whiteboard
>Affects Versions: jax-rs-whiteboard-1.0.4, jax-rs-whiteboard-1.0.5, 
> jax-rs-whiteboard-1.0.6
> Environment: Karaf plugin version: 4.1.7
>  
>Reporter: Joao Assuncao
>Priority: Major
>
> The jax-rs-whiteboard  Karaf feature cannot be used when building a custom 
> Karaf distribution. 
> During assembly, karaf-maven-plugin will fail with an error complaining that 
> aries-jax-rs-whiteboard can't be found.
> Adding the features to the attach-artifact 
> configuration fixes this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARIES-1675) Provide a module to run the tck tests

2019-05-16 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1675:
---
Fix Version/s: (was: rsa-1.14.0)
   rsa-1.15.0

> Provide a module to run the tck tests
> -
>
> Key: ARIES-1675
> URL: https://issues.apache.org/jira/browse/ARIES-1675
> Project: Aries
>  Issue Type: Test
>  Components: Remote Service Admin
>Affects Versions: rsa-1.9.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1614) Support callback for TopologyManager to change the published properties

2019-05-16 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1614:
---
Fix Version/s: (was: rsa-1.14.0)
   rsa-1.15.0

> Support callback for TopologyManager to change the published properties
> ---
>
> Key: ARIES-1614
> URL: https://issues.apache.org/jira/browse/ARIES-1614
> Project: Aries
>  Issue Type: New Feature
>  Components: Remote Service Admin
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>
> We currently have the DiscoveryPlugin spi in zookeeper discovery that allows 
> to change properties before they are placed in zookeeper. As this SPI 
> currently can not be used (the spi package is private) we can also try to 
> improve this model.
> The idea is to move the property changing SPI to TopologyManager. It would be 
> called before each Endpoint is published. This would allow to provide the 
> same adapted view of the Endpoint for all EndpointListeners. So the changed 
> proerties would for example also be visible in the endpoint shell command.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARIES-1836) Test failure in TestFastbinRoundTrip: SocketException: Invalid argument

2019-05-16 Thread Christian Schneider (JIRA)


[ 
https://issues.apache.org/jira/browse/ARIES-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841291#comment-16841291
 ] 

Christian Schneider commented on ARIES-1836:


Yes .. seems to be a different case.

> Test failure in TestFastbinRoundTrip: SocketException: Invalid argument
> ---
>
> Key: ARIES-1836
> URL: https://issues.apache.org/jira/browse/ARIES-1836
> Project: Aries
>  Issue Type: Test
>  Components: Remote Service Admin
>Affects Versions: rsa-1.12.0
>Reporter: Christian Schneider
>Priority: Major
> Fix For: rsa-1.14.0
>
>
> Sometimes TestFastbinRoundTrip still fails with these exceptions being shown:
> [https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d]
> ConnectException 
> [https://gist.github.com/cschneider/48b8b72bf972e4da0a01021341fa5bfe]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1836) Test failure in TestFastbinRoundTrip: SocketException: Invalid argument

2019-05-16 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1836:
---
Fix Version/s: (was: rsa-1.14.0)
   rsa-1.15.0

> Test failure in TestFastbinRoundTrip: SocketException: Invalid argument
> ---
>
> Key: ARIES-1836
> URL: https://issues.apache.org/jira/browse/ARIES-1836
> Project: Aries
>  Issue Type: Test
>  Components: Remote Service Admin
>Affects Versions: rsa-1.12.0
>Reporter: Christian Schneider
>Priority: Major
> Fix For: rsa-1.15.0
>
>
> Sometimes TestFastbinRoundTrip still fails with these exceptions being shown:
> [https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d]
> ConnectException 
> [https://gist.github.com/cschneider/48b8b72bf972e4da0a01021341fa5bfe]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1913) Exception event properties are incorrect

2019-05-16 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1913:
---
Fix Version/s: rsa-1.14.0

> Exception event properties are incorrect
> 
>
> Key: ARIES-1913
> URL: https://issues.apache.org/jira/browse/ARIES-1913
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Amichai Rothman
>Priority: Minor
> Fix For: rsa-1.14.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The "exception.class" event property value is set to the Class instance 
> instead of the class name string, and is then overwritten by the exception 
> message (which should have been in a property named "exception.message").



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1913) Exception event properties are incorrect

2019-05-16 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1913.

Resolution: Fixed

> Exception event properties are incorrect
> 
>
> Key: ARIES-1913
> URL: https://issues.apache.org/jira/browse/ARIES-1913
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Amichai Rothman
>Assignee: Christian Schneider
>Priority: Minor
> Fix For: rsa-1.14.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The "exception.class" event property value is set to the Class instance 
> instead of the class name string, and is then overwritten by the exception 
> message (which should have been in a property named "exception.message").



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ARIES-1913) Exception event properties are incorrect

2019-05-16 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1913:
--

Assignee: Christian Schneider

> Exception event properties are incorrect
> 
>
> Key: ARIES-1913
> URL: https://issues.apache.org/jira/browse/ARIES-1913
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Amichai Rothman
>Assignee: Christian Schneider
>Priority: Minor
> Fix For: rsa-1.14.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The "exception.class" event property value is set to the Class instance 
> instead of the class name string, and is then overwritten by the exception 
> message (which should have been in a property named "exception.message").



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1907) IllegalStateException when stopping bundle

2019-05-16 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1907.

   Resolution: Fixed
 Assignee: Christian Schneider
Fix Version/s: rsa-1.14.0

> IllegalStateException when stopping bundle
> --
>
> Key: ARIES-1907
> URL: https://issues.apache.org/jira/browse/ARIES-1907
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.14.0
>Reporter: Amichai Rothman
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.14.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Happened during the automated build on a PR in github - 
> [https://github.com/apache/aries-rsa/pull/20#issuecomment-477604538.] Here is 
> the stack trace from the build log:
>  
> ERROR: Bundle org.apache.aries.rsa.core [21] ServiceRegistrationImpl: Error 
> ungetting service. (java.lang.IllegalStateException: Invalid BundleContext.)
> java.lang.IllegalStateException: Invalid BundleContext.
>   at 
> org.apache.felix.framework.BundleContextImpl.checkValidity(BundleContextImpl.java:511)
>   at 
> org.apache.felix.framework.BundleContextImpl.getBundle(BundleContextImpl.java:114)
>   at 
> org.apache.aries.rsa.core.RemoteServiceAdminInstance.close(RemoteServiceAdminInstance.java:83)
>   at 
> org.apache.aries.rsa.core.RemoteServiceadminFactory.ungetService(RemoteServiceadminFactory.java:49)
>   at 
> org.apache.aries.rsa.core.RemoteServiceadminFactory.ungetService(RemoteServiceadminFactory.java:28)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.ungetFactoryUnchecked(ServiceRegistrationImpl.java:388)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.ungetService(ServiceRegistrationImpl.java:286)
>   at 
> org.apache.felix.framework.ServiceRegistry.ungetService(ServiceRegistry.java:470)
>   at 
> org.apache.felix.framework.ServiceRegistry.ungetServices(ServiceRegistry.java:529)
>   at org.apache.felix.framework.Felix.stopBundle(Felix.java:2638)
>   at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1389)
>   at 
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
>   at java.lang.Thread.run(Thread.java:748)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARIES-1836) Test failure in TestFastbinRoundTrip: SocketException: Invalid argument

2019-05-13 Thread Christian Schneider (JIRA)


[ 
https://issues.apache.org/jira/browse/ARIES-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838366#comment-16838366
 ] 

Christian Schneider commented on ARIES-1836:


[~amichai] this is the issue for the test failure if you want to look into it.

> Test failure in TestFastbinRoundTrip: SocketException: Invalid argument
> ---
>
> Key: ARIES-1836
> URL: https://issues.apache.org/jira/browse/ARIES-1836
> Project: Aries
>  Issue Type: Test
>  Components: Remote Service Admin
>Affects Versions: rsa-1.12.0
>Reporter: Christian Schneider
>Priority: Major
> Fix For: rsa-1.14.0
>
>
> Sometimes TestFastbinRoundTrip still fails with these exceptions being shown:
> [https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d]
> ConnectException 
> [https://gist.github.com/cschneider/48b8b72bf972e4da0a01021341fa5bfe]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1886) Globally configurable number of extender threads and grace period timeout

2019-02-24 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1886:
---
Fix Version/s: blueprint-core-1.9.1

> Globally configurable number of extender threads and grace period timeout
> -
>
> Key: ARIES-1886
> URL: https://issues.apache.org/jira/browse/ARIES-1886
> Project: Aries
>  Issue Type: Wish
>  Components: Blueprint
>Affects Versions: blueprint-core-1.9.0
>Reporter: Daniel Estermann
>Assignee: Christian Schneider
>Priority: Major
> Fix For: blueprint-core-1.9.1
>
>
> At Seeburger AG we migrated from JBoss to Karaf. We use Aries modules for 
> transaction capable beans. Since the migration, the number of blueprint 
> bundles increased and we started to get errors of this kind:
> {code}
> org.apache.aries.blueprint.container.BlueprintContainerImplJB2688  
> Blueprint Extender: 1   B6AIO1@b6aio1bd4ef  ERROR 
>   Unable to start blueprint container for bundle 
> com.seeburger.portal.backend/2.55.0 due to unresolved dependencies 
> [(objectClass=javax.transaction.TransactionSynchronizationRegistry)]
> @LGW800   2018-07-04T12:01:36.637+0200
> {code}
> So we tried to increase the number of extender threads and grace period 
> timeout in our blueprint fork to fix it. We introduced this in our master 
> branch in July 2018 and it increased the stability of our software. This is 
> why we want to propose this change also to be done in aries, which can be 
> reviewed in [PR91|https://github.com/apache/aries/pull/91]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1886) Globally configurable number of extender threads and grace period timeout

2019-02-24 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1886.

Resolution: Fixed

> Globally configurable number of extender threads and grace period timeout
> -
>
> Key: ARIES-1886
> URL: https://issues.apache.org/jira/browse/ARIES-1886
> Project: Aries
>  Issue Type: Wish
>  Components: Blueprint
>Affects Versions: blueprint-core-1.9.0
>Reporter: Daniel Estermann
>Assignee: Christian Schneider
>Priority: Major
> Fix For: blueprint-core-1.9.1
>
>
> At Seeburger AG we migrated from JBoss to Karaf. We use Aries modules for 
> transaction capable beans. Since the migration, the number of blueprint 
> bundles increased and we started to get errors of this kind:
> {code}
> org.apache.aries.blueprint.container.BlueprintContainerImplJB2688  
> Blueprint Extender: 1   B6AIO1@b6aio1bd4ef  ERROR 
>   Unable to start blueprint container for bundle 
> com.seeburger.portal.backend/2.55.0 due to unresolved dependencies 
> [(objectClass=javax.transaction.TransactionSynchronizationRegistry)]
> @LGW800   2018-07-04T12:01:36.637+0200
> {code}
> So we tried to increase the number of extender threads and grace period 
> timeout in our blueprint fork to fix it. We introduced this in our master 
> branch in July 2018 and it increased the stability of our software. This is 
> why we want to propose this change also to be done in aries, which can be 
> reviewed in [PR91|https://github.com/apache/aries/pull/91]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ARIES-1886) Globally configurable number of extender threads and grace period timeout

2019-02-24 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1886:
--

Assignee: Christian Schneider

> Globally configurable number of extender threads and grace period timeout
> -
>
> Key: ARIES-1886
> URL: https://issues.apache.org/jira/browse/ARIES-1886
> Project: Aries
>  Issue Type: Wish
>  Components: Blueprint
>Affects Versions: blueprint-core-1.9.0
>Reporter: Daniel Estermann
>Assignee: Christian Schneider
>Priority: Major
>
> At Seeburger AG we migrated from JBoss to Karaf. We use Aries modules for 
> transaction capable beans. Since the migration, the number of blueprint 
> bundles increased and we started to get errors of this kind:
> {code}
> org.apache.aries.blueprint.container.BlueprintContainerImplJB2688  
> Blueprint Extender: 1   B6AIO1@b6aio1bd4ef  ERROR 
>   Unable to start blueprint container for bundle 
> com.seeburger.portal.backend/2.55.0 due to unresolved dependencies 
> [(objectClass=javax.transaction.TransactionSynchronizationRegistry)]
> @LGW800   2018-07-04T12:01:36.637+0200
> {code}
> So we tried to increase the number of extender threads and grace period 
> timeout in our blueprint fork to fix it. We introduced this in our master 
> branch in July 2018 and it increased the stability of our software. This is 
> why we want to propose this change also to be done in aries, which can be 
> reviewed in [PR91|https://github.com/apache/aries/pull/91]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1891) Memory Leak in aries-jpa-support

2019-02-13 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1891.

Resolution: Fixed

> Memory Leak in aries-jpa-support
> 
>
> Key: ARIES-1891
> URL: https://issues.apache.org/jira/browse/ARIES-1891
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.1
>Reporter: Daniel Estermann
>Assignee: Christian Schneider
>Priority: Critical
> Fix For: jpa-2.7.2
>
>
> The fix for ARIES-1783 has a memory leak. The method 
> org.apache.aries.jpa.supplier.EmSupplier.get() is called every time when a 
> method on EntityManager is called. And every time a ServiceReference to a 
> TransactionManager gets created. But it doesn't get deleted. So we have as 
> many ServiceReferences in the memory as calls on EntityManager.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (ARIES-1891) Memory Leak in aries-jpa-support

2019-02-13 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reopened ARIES-1891:

  Assignee: Christian Schneider

Quickly reopening and closing just to have someone assigned :)

> Memory Leak in aries-jpa-support
> 
>
> Key: ARIES-1891
> URL: https://issues.apache.org/jira/browse/ARIES-1891
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.1
>Reporter: Daniel Estermann
>Assignee: Christian Schneider
>Priority: Critical
> Fix For: jpa-2.7.2
>
>
> The fix for ARIES-1783 has a memory leak. The method 
> org.apache.aries.jpa.supplier.EmSupplier.get() is called every time when a 
> method on EntityManager is called. And every time a ServiceReference to a 
> TransactionManager gets created. But it doesn't get deleted. So we have as 
> many ServiceReferences in the memory as calls on EntityManager.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1885) JpaInterceptor does not properly end coordination in case of Exception

2019-01-30 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1885.

Resolution: Fixed

Thanks for the fix. I merged the PR and built a snapshot. Would be great if you 
could test the 2.2.7-SNAPSHOT via 
[https://repository.apache.org/content/groups/snapshots/org/apache/aries/jpa/] .

Btw. Do you have a case where this bug surfaced? I would like to provide a test 
for this.

> JpaInterceptor does not properly end coordination in case of Exception
> --
>
> Key: ARIES-1885
> URL: https://issues.apache.org/jira/browse/ARIES-1885
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.1
>Reporter: Nicolas Dutertry
>Assignee: Christian Schneider
>Priority: Major
> Fix For: jpa-2.7.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In class JpaInterceptor the method postCallWithException calls 
> Coordination.fail() but not Coordination.end():
> {code:java}
> @Override
> public void postCallWithException(ComponentMetadata cm, Method m, Throwable 
> ex, Object preCallToken) {
>     LOG.debug("PostCallWithException for bean {}, method {}", cm.getId(), 
> m.getName(), ex);
>     if (preCallToken != null) {
>     ((Coordination)preCallToken).fail(ex);
>     }
> }
> {code}
>  
> However, the javadoc of Coordination.fail() states:
> {code:none}
> If this Coordination has been {@link #push() pushed} onto a thread local 
> Coordination stack, this Coordination is not removed from the stack. The 
> creator of this Coordination must still call {@link #end()} on this 
> Coordination to cause it to be removed from the thread local Coordination 
> stack.
> {code}
> This is causing issues for subsequent calls to jpa service because the 
> coordination is not removed from the stack.
> The method postCallWithException should be implemented like this:
> {code:java}
> @Override
> public void postCallWithException(ComponentMetadata cm, Method m, Throwable 
> ex, Object preCallToken) {
>     LOG.debug("PostCallWithException for bean {}, method {}", cm.getId(), 
> m.getName(), ex);
>     if (preCallToken != null) {
>     Coordination coordination = (Coordination)preCallToken;
>     coordination.fail(ex);
>     coordination.end();
>     }
> }
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1885) JpaInterceptor does not properly end coordination in case of Exception

2019-01-29 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1885:
---
Fix Version/s: jpa-2.7.2

> JpaInterceptor does not properly end coordination in case of Exception
> --
>
> Key: ARIES-1885
> URL: https://issues.apache.org/jira/browse/ARIES-1885
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.1
>Reporter: Nicolas Dutertry
>Assignee: Christian Schneider
>Priority: Major
> Fix For: jpa-2.7.2
>
>
> In class JpaInterceptor the method postCallWithException calls 
> Coordination.fail() but not Coordination.end():
> {code:java}
> @Override
> public void postCallWithException(ComponentMetadata cm, Method m, Throwable 
> ex, Object preCallToken) {
>     LOG.debug("PostCallWithException for bean {}, method {}", cm.getId(), 
> m.getName(), ex);
>     if (preCallToken != null) {
>     ((Coordination)preCallToken).fail(ex);
>     }
> }
> {code}
>  
> However, the javadoc of Coordination.fail() states:
> {code:none}
> If this Coordination has been {@link #push() pushed} onto a thread local 
> Coordination stack, this Coordination is not removed from the stack. The 
> creator of this Coordination must still call {@link #end()} on this 
> Coordination to cause it to be removed from the thread local Coordination 
> stack.
> {code}
> This is causing issues for subsequent calls to jpa service because the 
> coordination is not removed from the stack.
> The method postCallWithException should be implemented like this:
> {code:java}
> @Override
> public void postCallWithException(ComponentMetadata cm, Method m, Throwable 
> ex, Object preCallToken) {
>     LOG.debug("PostCallWithException for bean {}, method {}", cm.getId(), 
> m.getName(), ex);
>     if (preCallToken != null) {
>     Coordination coordination = (Coordination)preCallToken;
>     coordination.fail(ex);
>     coordination.end();
>     }
> }
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ARIES-1885) JpaInterceptor does not properly end coordination in case of Exception

2019-01-29 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1885:
--

Assignee: Christian Schneider

> JpaInterceptor does not properly end coordination in case of Exception
> --
>
> Key: ARIES-1885
> URL: https://issues.apache.org/jira/browse/ARIES-1885
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.1
>Reporter: Nicolas Dutertry
>Assignee: Christian Schneider
>Priority: Major
>
> In class JpaInterceptor the method postCallWithException calls 
> Coordination.fail() but not Coordination.end():
> {code:java}
> @Override
> public void postCallWithException(ComponentMetadata cm, Method m, Throwable 
> ex, Object preCallToken) {
>     LOG.debug("PostCallWithException for bean {}, method {}", cm.getId(), 
> m.getName(), ex);
>     if (preCallToken != null) {
>     ((Coordination)preCallToken).fail(ex);
>     }
> }
> {code}
>  
> However, the javadoc of Coordination.fail() states:
> {code:none}
> If this Coordination has been {@link #push() pushed} onto a thread local 
> Coordination stack, this Coordination is not removed from the stack. The 
> creator of this Coordination must still call {@link #end()} on this 
> Coordination to cause it to be removed from the thread local Coordination 
> stack.
> {code}
> This is causing issues for subsequent calls to jpa service because the 
> coordination is not removed from the stack.
> The method postCallWithException should be implemented like this:
> {code:java}
> @Override
> public void postCallWithException(ComponentMetadata cm, Method m, Throwable 
> ex, Object preCallToken) {
>     LOG.debug("PostCallWithException for bean {}, method {}", cm.getId(), 
> m.getName(), ex);
>     if (preCallToken != null) {
>     Coordination coordination = (Coordination)preCallToken;
>     coordination.fail(ex);
>     coordination.end();
>     }
> }
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARIES-1885) JpaInterceptor does not properly end coordination in case of Exception

2019-01-29 Thread Christian Schneider (JIRA)


[ 
https://issues.apache.org/jira/browse/ARIES-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755745#comment-16755745
 ] 

Christian Schneider commented on ARIES-1885:


Thanks for reporting this bug. Do you want to create a PR for it or should I 
simply fix it ?

> JpaInterceptor does not properly end coordination in case of Exception
> --
>
> Key: ARIES-1885
> URL: https://issues.apache.org/jira/browse/ARIES-1885
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.1
>Reporter: Nicolas Dutertry
>Priority: Major
>
> In class JpaInterceptor the method postCallWithException calls 
> Coordination.fail() but not Coordination.end():
> {code:java}
> @Override
> public void postCallWithException(ComponentMetadata cm, Method m, Throwable 
> ex, Object preCallToken) {
>     LOG.debug("PostCallWithException for bean {}, method {}", cm.getId(), 
> m.getName(), ex);
>     if (preCallToken != null) {
>     ((Coordination)preCallToken).fail(ex);
>     }
> }
> {code}
>  
> However, the javadoc of Coordination.fail() states:
> {code:none}
> If this Coordination has been {@link #push() pushed} onto a thread local 
> Coordination stack, this Coordination is not removed from the stack. The 
> creator of this Coordination must still call {@link #end()} on this 
> Coordination to cause it to be removed from the thread local Coordination 
> stack.
> {code}
> This is causing issues for subsequent calls to jpa service because the 
> coordination is not removed from the stack.
> The method postCallWithException should be implemented like this:
> {code:java}
> @Override
> public void postCallWithException(ComponentMetadata cm, Method m, Throwable 
> ex, Object preCallToken) {
>     LOG.debug("PostCallWithException for bean {}, method {}", cm.getId(), 
> m.getName(), ex);
>     if (preCallToken != null) {
>     Coordination coordination = (Coordination)preCallToken;
>     coordination.fail(ex);
>     coordination.end();
>     }
> }
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARIES-1883) kafka based implementation

2019-01-10 Thread Christian Schneider (JIRA)
Christian Schneider created ARIES-1883:
--

 Summary: kafka based implementation
 Key: ARIES-1883
 URL: https://issues.apache.org/jira/browse/ARIES-1883
 Project: Aries
  Issue Type: New Feature
  Components: Journaled Events
Reporter: Christian Schneider
 Fix For: journaled-events-0.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARIES-1882) API for scalable messaging

2019-01-07 Thread Christian Schneider (JIRA)
Christian Schneider created ARIES-1882:
--

 Summary: API for scalable messaging
 Key: ARIES-1882
 URL: https://issues.apache.org/jira/browse/ARIES-1882
 Project: Aries
  Issue Type: New Feature
  Components: Journaled Events
Reporter: Christian Schneider
Assignee: Christian Schneider


[~marett] suggest we should also look into a more scalable API that has similar 
features to kafka.

I will propose such a changed API in a PR. We should then discuss if we want to 
take the added complexity to allow for scalability.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARIES-1881) Mongo based implementation

2019-01-06 Thread Christian Schneider (JIRA)
Christian Schneider created ARIES-1881:
--

 Summary: Mongo based implementation
 Key: ARIES-1881
 URL: https://issues.apache.org/jira/browse/ARIES-1881
 Project: Aries
  Issue Type: New Feature
  Components: Journaled Events
Reporter: Christian Schneider
 Fix For: journaled-events-0.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1878) In memory implementation of journaled events

2019-01-05 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1878:
---
Fix Version/s: journaled-events-0.1.0

> In memory implementation of journaled events
> 
>
> Key: ARIES-1878
> URL: https://issues.apache.org/jira/browse/ARIES-1878
> Project: Aries
>  Issue Type: New Feature
>  Components: Journaled Events
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: journaled-events-0.1.0
>
>
> Create an in memory implementation of the API with good test coverage.
> This allows to validate the API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1879) Improve API

2019-01-05 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1879:
---
Fix Version/s: journaled-events-0.1.0

> Improve API
> ---
>
> Key: ARIES-1879
> URL: https://issues.apache.org/jira/browse/ARIES-1879
> Project: Aries
>  Issue Type: Improvement
>  Components: Journaled Events
>Reporter: Christian Schneider
>Priority: Major
> Fix For: journaled-events-0.1.0
>
>
> Umbrella issue to cover API changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1880) Use builder instead of many parameters in subscribe

2019-01-05 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1880.

Resolution: Fixed

> Use builder instead of many parameters in subscribe
> ---
>
> Key: ARIES-1880
> URL: https://issues.apache.org/jira/browse/ARIES-1880
> Project: Aries
>  Issue Type: Improvement
>  Components: Journaled Events
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Subscription subscribe(String topic, Position position, Seek seek, 
> Consumer callback);
> 4 Parameters which can partly be null is not a good idea. [~alien11689] 
> proposed on the list to use a DTO.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe

2019-01-04 Thread Christian Schneider (JIRA)


[ 
https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734161#comment-16734161
 ] 

Christian Schneider commented on ARIES-1880:


[~alien11689] .. is this what you thought of ? 
https://github.com/apache/aries-journaled-events/pull/10

> Use builder instead of many parameters in subscribe
> ---
>
> Key: ARIES-1880
> URL: https://issues.apache.org/jira/browse/ARIES-1880
> Project: Aries
>  Issue Type: Improvement
>  Components: Journaled Events
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Subscription subscribe(String topic, Position position, Seek seek, 
> Consumer callback);
> 4 Parameters which can partly be null is not a good idea. [~alien11689] 
> proposed on the list to use a DTO.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1880) Use builder instead of many parameters in subscribe

2019-01-04 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1880:
---
Description: 
Subscription subscribe(String topic, Position position, Seek seek, 
Consumer callback);

4 Parameters which can partly be null is not a good idea. [~alien11689] 
proposed on the list to use a DTO.

 

> Use builder instead of many parameters in subscribe
> ---
>
> Key: ARIES-1880
> URL: https://issues.apache.org/jira/browse/ARIES-1880
> Project: Aries
>  Issue Type: Improvement
>  Components: Journaled Events
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
>
> Subscription subscribe(String topic, Position position, Seek seek, 
> Consumer callback);
> 4 Parameters which can partly be null is not a good idea. [~alien11689] 
> proposed on the list to use a DTO.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARIES-1880) Use builder instead of many parameters in subscribe

2019-01-04 Thread Christian Schneider (JIRA)
Christian Schneider created ARIES-1880:
--

 Summary: Use builder instead of many parameters in subscribe
 Key: ARIES-1880
 URL: https://issues.apache.org/jira/browse/ARIES-1880
 Project: Aries
  Issue Type: Improvement
  Components: Journaled Events
Reporter: Christian Schneider
Assignee: Christian Schneider






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARIES-1879) Improve API

2019-01-02 Thread Christian Schneider (JIRA)
Christian Schneider created ARIES-1879:
--

 Summary: Improve API
 Key: ARIES-1879
 URL: https://issues.apache.org/jira/browse/ARIES-1879
 Project: Aries
  Issue Type: Improvement
  Components: Journaled Events
Reporter: Christian Schneider


Umbrella issue to cover API changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1878) In memory implementation of journaled events

2019-01-02 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1878:
---
Summary: In memory implementation of journaled events  (was: In memory 
implementation)

> In memory implementation of journaled events
> 
>
> Key: ARIES-1878
> URL: https://issues.apache.org/jira/browse/ARIES-1878
> Project: Aries
>  Issue Type: New Feature
>  Components: Journaled Events
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
>
> Create an in memory implementation of the API with good test coverage.
> This allows to validate the API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARIES-1878) In memory implementation

2019-01-02 Thread Christian Schneider (JIRA)
Christian Schneider created ARIES-1878:
--

 Summary: In memory implementation
 Key: ARIES-1878
 URL: https://issues.apache.org/jira/browse/ARIES-1878
 Project: Aries
  Issue Type: New Feature
  Components: Journaled Events
Reporter: Christian Schneider
Assignee: Christian Schneider


Create an in memory implementation of the API with good test coverage.

This allows to validate the API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ARIES-1375) Refactor to release by subproject

2018-12-04 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider closed ARIES-1375.
--
Resolution: Won't Fix

The projects inside tranaction folder are too unrelated to be released by 
subproject

> Refactor to release by subproject
> -
>
> Key: ARIES-1375
> URL: https://issues.apache.org/jira/browse/ARIES-1375
> Project: Aries
>  Issue Type: Improvement
>  Components: Transaction
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: transaction-3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1777) need to add aries-blueprint as a dependency to jpa feature

2018-12-03 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1777:
---
Fix Version/s: (was: jpa-2.8.0)

> need to add aries-blueprint as a dependency to jpa feature
> --
>
> Key: ARIES-1777
> URL: https://issues.apache.org/jira/browse/ARIES-1777
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.6.1
>Reporter: AmirMohammad Vosough
>Assignee: Christian Schneider
>Priority: Major
>  Labels: easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When working on Vaseline framework, I faced this problem:
> After using karaf-assembly I found out I can not have jpa as a startup 
> feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARIES-1777) need to add aries-blueprint as a dependency to jpa feature

2018-12-03 Thread Christian Schneider (JIRA)


[ 
https://issues.apache.org/jira/browse/ARIES-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707267#comment-16707267
 ] 

Christian Schneider commented on ARIES-1777:


Aries JPA does not have a direct dependency to blueprint. We currently handle 
the eventual blueprint dependency using a conditional:

[https://github.com/apache/aries-jpa/blob/master/jpa-features/src/main/feature/feature.xml#L36]

How would a direct dependency to blueprint help with this? Cant you imply also 
add blueprint to your boot featues?

> need to add aries-blueprint as a dependency to jpa feature
> --
>
> Key: ARIES-1777
> URL: https://issues.apache.org/jira/browse/ARIES-1777
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.6.1
>Reporter: AmirMohammad Vosough
>Assignee: Christian Schneider
>Priority: Major
>  Labels: easyfix
> Fix For: jpa-2.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When working on Vaseline framework, I faced this problem:
> After using karaf-assembly I found out I can not have jpa as a startup 
> feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1869) Example does not work with current karaf 4.2.1

2018-12-03 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1869.

Resolution: Fixed

> Example does not work with current karaf 4.2.1
> --
>
> Key: ARIES-1869
> URL: https://issues.apache.org/jira/browse/ARIES-1869
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: jpa-2.8.0
>
>
> See 
> [https://stackoverflow.com/questions/53433775/org-apache-aries-jpaorg-apache-aries-jpa-blueprint2-3-0-cant-make-run]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ARIES-1777) need to add aries-blueprint as a dependency to jpa feature

2018-12-03 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1777:
--

Assignee: Christian Schneider

> need to add aries-blueprint as a dependency to jpa feature
> --
>
> Key: ARIES-1777
> URL: https://issues.apache.org/jira/browse/ARIES-1777
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.6.1
>Reporter: AmirMohammad Vosough
>Assignee: Christian Schneider
>Priority: Major
>  Labels: easyfix
> Fix For: jpa-2.8.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When working on Vaseline framework, I faced this problem:
> After using karaf-assembly I found out I can not have jpa as a startup 
> feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARIES-1869) Example does not work with current karaf 4.2.1

2018-12-03 Thread Christian Schneider (JIRA)


[ 
https://issues.apache.org/jira/browse/ARIES-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707263#comment-16707263
 ] 

Christian Schneider commented on ARIES-1869:


[~soundcrac...@gmail.com] found the reason for this to be an error in 
blueprint-core 1.9.0 (https://issues.apache.org/jira/browse/ARIES-1793) which 
is used in karaf 4.2.1. So we do not need any fix in Aries JPA.

This is fixed in the karaf feature file in this commit 
[https://github.com/apache/karaf/pull/670] . It will be part of karaf 4.2.2.

 

> Example does not work with current karaf 4.2.1
> --
>
> Key: ARIES-1869
> URL: https://issues.apache.org/jira/browse/ARIES-1869
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: jpa-2.8.0
>
>
> See 
> [https://stackoverflow.com/questions/53433775/org-apache-aries-jpaorg-apache-aries-jpa-blueprint2-3-0-cant-make-run]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARIES-1869) Example does not work with current karaf 4.2.1

2018-11-27 Thread Christian Schneider (JIRA)


[ 
https://issues.apache.org/jira/browse/ARIES-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700245#comment-16700245
 ] 

Christian Schneider commented on ARIES-1869:


After the commit the closure based example works. The blueprint based example 
gives returns an exception:

java.lang.IllegalStateException: Need active coordination
 at org.apache.aries.jpa.support.impl.EMSupplierImpl.get(EMSupplierImpl.java:81)
 at org.apache.aries.jpa.support.osgi.impl.EmProxy.invoke(EmProxy.java:38)

 

> Example does not work with current karaf 4.2.1
> --
>
> Key: ARIES-1869
> URL: https://issues.apache.org/jira/browse/ARIES-1869
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: jpa-2.8.0
>
>
> See 
> [https://stackoverflow.com/questions/53433775/org-apache-aries-jpaorg-apache-aries-jpa-blueprint2-3-0-cant-make-run]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARIES-1869) Example does not work with current karaf 4.2.1

2018-11-27 Thread Christian Schneider (JIRA)
Christian Schneider created ARIES-1869:
--

 Summary: Example does not work with current karaf 4.2.1
 Key: ARIES-1869
 URL: https://issues.apache.org/jira/browse/ARIES-1869
 Project: Aries
  Issue Type: Bug
  Components: JPA
Affects Versions: jpa-2.7.0
Reporter: Christian Schneider
Assignee: Christian Schneider
 Fix For: jpa-2.8.0


See 
[https://stackoverflow.com/questions/53433775/org-apache-aries-jpaorg-apache-aries-jpa-blueprint2-3-0-cant-make-run]

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ARIES-1711) Mapping files in persistence.xml not used

2018-11-26 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1711:
--

Assignee: Timothy Ward

> Mapping files in persistence.xml not used
> -
>
> Key: ARIES-1711
> URL: https://issues.apache.org/jira/browse/ARIES-1711
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.7.0, jpa-2.6.1
> Environment: Apache Aries 2.6.1
> Hibernate 5.0.7.Final
> Felix 5.6.1
> JPA 2.1
>Reporter: Alexander Liepold
>Assignee: Timothy Ward
>Priority: Major
> Fix For: jpa-2.7.0
>
> Attachments: JPAHandler.patch, PersistenceUnit.patch, 
> aries-itest-mapping-files.zip
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The mapping files in a PeristenceUnit are not used by Apache Aries.
>  
> The same issue was noticed at this thread: 
> http://karaf.922171.n3.nabble.com/Aries-JPA-2-3-0-mapping-file-not-used-td4047501.html
> I have the same problem and I found out that the use of a mapping file in a 
> persistence.xml works only on particular circumstances.
> For example if I use the following declaration of a persistence.xml :
>  
> {code:xml}
> 
>version="2.1">
>  transaction-type="RESOURCE_LOCAL">
>   
> org.hibernate.jpa.HibernatePersistenceProvider
>   
> osgi:service/javax.sql.DataSource/(osgi.jndi.service.name=jdbc/testDB)
>   META-INF/developer-orm.xml
>   
>   META-INF/orm.xml
>   
>   test.Customer
>   ...
>   
>   ...
>   
>   
> 
> {code}
> On deployment of this persistence-unit the class {{test.Customer}} gets 
> bootstrapped from Hibernate. The mapping file {{META-INF/orm.xml}} is 
> detected automatically from the persistence provider.
> But the mapping file {{META-INF/developer-orm.xml}} is never detected.
>  
> If I fixed the particular code in the module Aries JPA Container locally. 
> After building and testing the Apache Aries Project I could deploy a 
> persistence.xml with multiple mapping files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1783) TransactionRequiredException when non-transactional method precedes a transactional one in the same service.

2018-11-26 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1783.

   Resolution: Fixed
Fix Version/s: jpa-2.8.0

> TransactionRequiredException when non-transactional method precedes a 
> transactional one in the same service.
> 
>
> Key: ARIES-1783
> URL: https://issues.apache.org/jira/browse/ARIES-1783
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.5.0
>Reporter: Daniel Estermann
>Assignee: Christian Schneider
>Priority: Major
> Fix For: jpa-2.8.0
>
>
> Assume I have a service implementation with a method annotated with 
> @Transactional and one of TxTypes not starting a transaction:
>  * NEVER
>  * NOT_SUPPORTED
>  * SUPPORTS
> From that non-transactional method I want to use a self-reference resolved 
> via BundleContext to call a transactional method in the same service, 
> annotated with one of those TxTypes:
>  * REQUIRED
>  * REQURES_NEW
> Since the resolved self-reference is a proxied object I expect it to be able 
> to start a new transaction. This is not the case however and the subject 
> exception occurs.
>  
> I created a test case revealing the issue in the following pull request: 
> https://github.com/apache/aries-jpa/pull/2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ARIES-1783) TransactionRequiredException when non-transactional method precedes a transactional one in the same service.

2018-11-26 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1783:
--

Assignee: Christian Schneider

> TransactionRequiredException when non-transactional method precedes a 
> transactional one in the same service.
> 
>
> Key: ARIES-1783
> URL: https://issues.apache.org/jira/browse/ARIES-1783
> Project: Aries
>  Issue Type: Bug
>  Components: JPA
>Affects Versions: jpa-2.5.0
>Reporter: Daniel Estermann
>Assignee: Christian Schneider
>Priority: Major
>
> Assume I have a service implementation with a method annotated with 
> @Transactional and one of TxTypes not starting a transaction:
>  * NEVER
>  * NOT_SUPPORTED
>  * SUPPORTS
> From that non-transactional method I want to use a self-reference resolved 
> via BundleContext to call a transactional method in the same service, 
> annotated with one of those TxTypes:
>  * REQUIRED
>  * REQURES_NEW
> Since the resolved self-reference is a proxied object I expect it to be able 
> to start a new transaction. This is not the case however and the subject 
> exception occurs.
>  
> I created a test case revealing the issue in the following pull request: 
> https://github.com/apache/aries-jpa/pull/2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1846) Topologymanager doesn't import org.osgi.service.clusterinfo.* remote services

2018-10-18 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1846.

Resolution: Fixed

> Topologymanager doesn't import org.osgi.service.clusterinfo.* remote services
> -
>
> Key: ARIES-1846
> URL: https://issues.apache.org/jira/browse/ARIES-1846
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Tim Verbelen
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.14.0
>
>
> The OSGi clusterinfo specification defines services in the 
> org.osgi.service.clusterinfo package that have to be exported and imported as 
> remote services. However, currently the TopologyManager filters out all 
> org.osgi.service.* services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1851) NoClassDefFoundError ZooTrace on shutdown of zookeeper discovery

2018-10-18 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1851.

Resolution: Fixed

> NoClassDefFoundError ZooTrace on shutdown of zookeeper discovery
> 
>
> Key: ARIES-1851
> URL: https://issues.apache.org/jira/browse/ARIES-1851
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.14.0
>
>
> org.apache.hadoop.zookeeper[org.apache.zookeeper.server.ZooKeeperThread] : 
> Exception occurred from thread Thread-28-SendThread(localhost:15201)
> java.lang.NoClassDefFoundError: org/apache/zookeeper/server/ZooTrace
>  at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1192)
> Caused by: java.lang.ClassNotFoundException: Unable to load class 
> 'org.apache.zookeeper.server.ZooTrace' because the bundle wiring for 
> org.apache.hadoop.zookeeper is no longer valid.
>  at 
> org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1539)
>  at 
> org.apache.felix.framework.BundleWiringImpl.access$400(BundleWiringImpl.java:79)
>  at 
> org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:2018)
>  at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>  ... 1 more



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARIES-1851) NoClassDefFoundError ZooTrace on shutdown of zookeeper discovery

2018-10-18 Thread Christian Schneider (JIRA)
Christian Schneider created ARIES-1851:
--

 Summary: NoClassDefFoundError ZooTrace on shutdown of zookeeper 
discovery
 Key: ARIES-1851
 URL: https://issues.apache.org/jira/browse/ARIES-1851
 Project: Aries
  Issue Type: Bug
  Components: Remote Service Admin
Affects Versions: rsa-1.13.0
Reporter: Christian Schneider
Assignee: Christian Schneider
 Fix For: rsa-1.14.0


org.apache.hadoop.zookeeper[org.apache.zookeeper.server.ZooKeeperThread] : 
Exception occurred from thread Thread-28-SendThread(localhost:15201)

java.lang.NoClassDefFoundError: org/apache/zookeeper/server/ZooTrace

 at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1192)

Caused by: java.lang.ClassNotFoundException: Unable to load class 
'org.apache.zookeeper.server.ZooTrace' because the bundle wiring for 
org.apache.hadoop.zookeeper is no longer valid.

 at 
org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1539)

 at 
org.apache.felix.framework.BundleWiringImpl.access$400(BundleWiringImpl.java:79)

 at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:2018)

 at java.lang.ClassLoader.loadClass(ClassLoader.java:357)

 ... 1 more



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1850) Local service modification is not reflected in changed export registration

2018-10-18 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1850.

Resolution: Fixed

> Local service modification is not reflected in changed export registration
> --
>
> Key: ARIES-1850
> URL: https://issues.apache.org/jira/browse/ARIES-1850
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.14.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARIES-1850) Local service modification is not reflected in changed export registration

2018-10-18 Thread Christian Schneider (JIRA)
Christian Schneider created ARIES-1850:
--

 Summary: Local service modification is not reflected in changed 
export registration
 Key: ARIES-1850
 URL: https://issues.apache.org/jira/browse/ARIES-1850
 Project: Aries
  Issue Type: Bug
  Components: Remote Service Admin
Affects Versions: rsa-1.13.0
Reporter: Christian Schneider
Assignee: Christian Schneider
 Fix For: rsa-1.14.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1817) Export remove do not always end up in REMOVE events (timing issue)

2018-10-18 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1817:
---
Summary: Export remove do not always end up in REMOVE events (timing issue) 
 (was: Export remove do no always end up in REMOVE events (timing issue))

> Export remove do not always end up in REMOVE events (timing issue)
> --
>
> Key: ARIES-1817
> URL: https://issues.apache.org/jira/browse/ARIES-1817
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.12.0
>Reporter: Mark Hoffmann
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.13.0
>
> Attachments: ServiceExportsRepository.patch
>
>
> During testing aries RSA I found several situations where my discovery did 
> not received a remove event. After some inspection I found that
> org.apache.aries.rsa.core.ExportRegistrationImpl#getExportReference returns 
> only the reference instance when its not closed, otherwise null.
> Usually I expected that the ExportRegistration is closed by the 
> TopologyManager, in this case 
> org.apache.aries.rsa.topologymanager.exporter.ServiceExportRepository. But 
> thats not true. While debugging I saw that sometimes 
> org.apache.aries.rsa.core.RemoteServiceAdminCore#removeServiceExports closes 
> the ExportRegistration a little bit earlier. That leads to a null 
> ExportReference instance in ServiceExportRepository#closeReg, which in return 
> leads to no remove event.
> So, there is no single point of truth, who closes the ExportRegistration. 
> Citing the Spec 122.5.1:
> _The Export Registrations remain open until:_
> _Explicitly closed by the Topology Manager, or_
> _The Remote Service Admin service is no longer used by the Topology Manager 
> that created the Export Registration._
> _If the Remote Service Admin service can no longer maintain the corresponding 
> Endpoint due to failures than these should be reported through the events. 
> However, the registrations should remain open until explicitly closed by the 
> Topology Manager._
> I attached a patch, that solve the problem, but is as well not compliant to 
> the spec, like the current implementation.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARIES-1847) IllegalArgumentException: Path cannot be null when handling zookeeper event

2018-10-18 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved ARIES-1847.

Resolution: Fixed

> IllegalArgumentException: Path cannot be null when handling zookeeper event
> ---
>
> Key: ARIES-1847
> URL: https://issues.apache.org/jira/browse/ARIES-1847
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.14.0
>
>
> INFO: Received event WatchedEvent state:Disconnected type:None path:null
> Oct 11, 2018 8:48:06 PM 
> org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository
>  watchRecursive
> INFO: Path cannot be null
> java.lang.IllegalArgumentException: Path cannot be null
>   at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:45)
>   at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1203)
>   at 
> org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository.handleZNodeChanged(ZookeeperEndpointRepository.java:237)
>   at 
> org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository.watchRecursive(ZookeeperEndpointRepository.java:174)
>   at 
> org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository.process(ZookeeperEndpointRepository.java:146)
>   at 
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:533)
>   at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:508)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARIES-1847) IllegalArgumentException: Path cannot be null when handling zookeeper event

2018-10-18 Thread Christian Schneider (JIRA)


[ 
https://issues.apache.org/jira/browse/ARIES-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654728#comment-16654728
 ] 

Christian Schneider commented on ARIES-1847:


Some events have a path null. We should not call watchRecursive for such events.

> IllegalArgumentException: Path cannot be null when handling zookeeper event
> ---
>
> Key: ARIES-1847
> URL: https://issues.apache.org/jira/browse/ARIES-1847
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.14.0
>
>
> INFO: Received event WatchedEvent state:Disconnected type:None path:null
> Oct 11, 2018 8:48:06 PM 
> org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository
>  watchRecursive
> INFO: Path cannot be null
> java.lang.IllegalArgumentException: Path cannot be null
>   at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:45)
>   at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1203)
>   at 
> org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository.handleZNodeChanged(ZookeeperEndpointRepository.java:237)
>   at 
> org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository.watchRecursive(ZookeeperEndpointRepository.java:174)
>   at 
> org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository.process(ZookeeperEndpointRepository.java:146)
>   at 
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:533)
>   at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:508)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARIES-1847) IllegalArgumentException: Path cannot be null when handling zookeeper event

2018-10-18 Thread Christian Schneider (JIRA)
Christian Schneider created ARIES-1847:
--

 Summary: IllegalArgumentException: Path cannot be null when 
handling zookeeper event
 Key: ARIES-1847
 URL: https://issues.apache.org/jira/browse/ARIES-1847
 Project: Aries
  Issue Type: Bug
  Components: Remote Service Admin
Affects Versions: rsa-1.13.0
Reporter: Christian Schneider
Assignee: Christian Schneider
 Fix For: rsa-1.14.0


INFO: Received event WatchedEvent state:Disconnected type:None path:null
Oct 11, 2018 8:48:06 PM 
org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository 
watchRecursive
INFO: Path cannot be null
java.lang.IllegalArgumentException: Path cannot be null
at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:45)
at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1203)
at 
org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository.handleZNodeChanged(ZookeeperEndpointRepository.java:237)
at 
org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository.watchRecursive(ZookeeperEndpointRepository.java:174)
at 
org.apache.aries.rsa.discovery.zookeeper.repository.ZookeeperEndpointRepository.process(ZookeeperEndpointRepository.java:146)
at 
org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:533)
at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:508)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ARIES-1846) Topologymanager doesn't import org.osgi.service.clusterinfo.* remote services

2018-10-17 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider reassigned ARIES-1846:
--

Assignee: Christian Schneider

> Topologymanager doesn't import org.osgi.service.clusterinfo.* remote services
> -
>
> Key: ARIES-1846
> URL: https://issues.apache.org/jira/browse/ARIES-1846
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Tim Verbelen
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.14.0
>
>
> The OSGi clusterinfo specification defines services in the 
> org.osgi.service.clusterinfo package that have to be exported and imported as 
> remote services. However, currently the TopologyManager filters out all 
> org.osgi.service.* services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1846) Topologymanager doesn't import org.osgi.service.clusterinfo.* remote services

2018-10-17 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1846:
---
Fix Version/s: rsa-1.14.0

> Topologymanager doesn't import org.osgi.service.clusterinfo.* remote services
> -
>
> Key: ARIES-1846
> URL: https://issues.apache.org/jira/browse/ARIES-1846
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.13.0
>Reporter: Tim Verbelen
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.14.0
>
>
> The OSGi clusterinfo specification defines services in the 
> org.osgi.service.clusterinfo package that have to be exported and imported as 
> remote services. However, currently the TopologyManager filters out all 
> org.osgi.service.* services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1815) ConcurrentModificationException in TopologyManagerImport.unImportForGoneEndpoints

2018-10-01 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1815:
---
Issue Type: Bug  (was: Improvement)

> ConcurrentModificationException in 
> TopologyManagerImport.unImportForGoneEndpoints
> -
>
> Key: ARIES-1815
> URL: https://issues.apache.org/jira/browse/ARIES-1815
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.12.0
> Environment: Happens in the CXF-DOSGi itests.
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.13.0
>
>
> org.apache.aries.rsa.topology-manager[org.apache.aries.rsa.topologymanager.importer.TopologyManagerImport]
>  : null
> java.util.ConcurrentModificationException
>  at java.util.HashMap$HashIterator.nextNode(HashMap.java:1442)
>  at java.util.HashMap$KeyIterator.next(HashMap.java:1466)
>  at 
> org.apache.aries.rsa.topologymanager.importer.TopologyManagerImport.unImportForGoneEndpoints(TopologyManagerImport.java:183)
>  at 
> org.apache.aries.rsa.topologymanager.importer.TopologyManagerImport.syncronizeImports(TopologyManagerImport.java:127)
>  at 
> org.apache.aries.rsa.topologymanager.importer.TopologyManagerImport.access$000(TopologyManagerImport.java:47)
>  at 
> org.apache.aries.rsa.topologymanager.importer.TopologyManagerImport$1.run(TopologyManagerImport.java:119)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1836) Test failure in TestFastbinRoundTrip

2018-09-28 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1836:
---
Description: 
Sometimes TestFastbinRoundTrip still fails with these exceptions being shown:

[https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d]

ConnectException 

[https://gist.github.com/cschneider/48b8b72bf972e4da0a01021341fa5bfe]

 

  was:
Sometimes the 

[https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d]

ConnectException 

[https://gist.github.com/cschneider/48b8b72bf972e4da0a01021341fa5bfe]

 


> Test failure in TestFastbinRoundTrip
> 
>
> Key: ARIES-1836
> URL: https://issues.apache.org/jira/browse/ARIES-1836
> Project: Aries
>  Issue Type: Test
>  Components: Remote Service Admin
>Affects Versions: rsa-1.12.0
>Reporter: Christian Schneider
>Priority: Major
> Fix For: rsa-1.13.0
>
>
> Sometimes TestFastbinRoundTrip still fails with these exceptions being shown:
> [https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d]
> ConnectException 
> [https://gist.github.com/cschneider/48b8b72bf972e4da0a01021341fa5bfe]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1836) Test failure in TestFastbinRoundTrip: SocketException: Invalid argument

2018-09-28 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1836:
---
Summary: Test failure in TestFastbinRoundTrip: SocketException: Invalid 
argument  (was: Test failure in TestFastbinRoundTrip)

> Test failure in TestFastbinRoundTrip: SocketException: Invalid argument
> ---
>
> Key: ARIES-1836
> URL: https://issues.apache.org/jira/browse/ARIES-1836
> Project: Aries
>  Issue Type: Test
>  Components: Remote Service Admin
>Affects Versions: rsa-1.12.0
>Reporter: Christian Schneider
>Priority: Major
> Fix For: rsa-1.13.0
>
>
> Sometimes TestFastbinRoundTrip still fails with these exceptions being shown:
> [https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d]
> ConnectException 
> [https://gist.github.com/cschneider/48b8b72bf972e4da0a01021341fa5bfe]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1836) Test failure in TestFastbinRoundTrip

2018-09-28 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1836:
---
Description: 
Sometimes the 

[https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d]

ConnectException 

[https://gist.github.com/cschneider/48b8b72bf972e4da0a01021341fa5bfe]

 

  was:https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d


> Test failure in TestFastbinRoundTrip
> 
>
> Key: ARIES-1836
> URL: https://issues.apache.org/jira/browse/ARIES-1836
> Project: Aries
>  Issue Type: Test
>  Components: Remote Service Admin
>Affects Versions: rsa-1.12.0
>Reporter: Christian Schneider
>Priority: Major
> Fix For: rsa-1.13.0
>
>
> Sometimes the 
> [https://gist.github.com/cschneider/2e342a72112597dab55c01d65a9f654d]
> ConnectException 
> [https://gist.github.com/cschneider/48b8b72bf972e4da0a01021341fa5bfe]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARIES-1838) Zookeeper discovery does not send modified events

2018-09-28 Thread Christian Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARIES-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated ARIES-1838:
---
Issue Type: Bug  (was: Test)

> Zookeeper discovery does not send modified events
> -
>
> Key: ARIES-1838
> URL: https://issues.apache.org/jira/browse/ARIES-1838
> Project: Aries
>  Issue Type: Bug
>  Components: Remote Service Admin
>Affects Versions: rsa-1.12.0
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: rsa-1.13.0
>
>
> We forgot to set a watcher for data changes on znode. So the zookeeper 
> discovery is not triggered for such changes. So no modified events are sent 
> to the EndpointEventListener



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   3   4   5   6   7   8   9   >