[jira] [Commented] (ARIES-1826) blueprint-maven-plugin IllegalArgumentException from ASM, possibly Java 9 related
[
https://issues.apache.org/jira/browse/ARIES-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619639#comment-16619639
]
Michael Vorburger commented on ARIES-1826:
--
It just occured to me, only now, that instead of stressing for a release here
:P one can, obviously, locally work around this quite easily:
{code:xml}
org.apache.aries.blueprint
blueprint-maven-plugin
1.10.0
org.apache.xbean
xbean-finder-shaded
4.9
{code}
> blueprint-maven-plugin IllegalArgumentException from ASM, possibly Java 9
> related
> -
>
> Key: ARIES-1826
> URL: https://issues.apache.org/jira/browse/ARIES-1826
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
>Affects Versions: blueprint-maven-plugin-1.10.0
>Reporter: Michael Vorburger
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: blueprint-maven-plugin-1.11.0
>
>
> From [https://jira.opendaylight.org/browse/ODLPARENT-167] :
> {code:java}
> [INFO] --- blueprint-maven-plugin:1.10.0:blueprint-generate (default) @
> northbound-api ---
> [INFO] Package org.opendaylight will be scanned
> (...)
> [ERROR] Failed to execute goal
> org.apache.aries.blueprint:blueprint-maven-plugin:1.10.0:blueprint-generate
> (default) on project northbound-api: Error during blueprint generation:
> IllegalArgumentException -> [Help 1]{code}
> With {{mvn-X}} (details in
> [ODLPARENT-167|https://jira.opendaylight.org/browse/ODLPARENT-167]) we find
> it's {{Caused by: java.lang.IllegalArgumentException at
> org.apache.xbean.asm5.ClassReader.}}, which could be related to it
> scanning some Java > 8 (9/10/11) class in some JAR?
> [~gnt] or [~ch...@die-schneider.net], I don't suppose this is a known issue
> for which you already have a fix, or an thoughts? [~skitt] FYI.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1826) blueprint-maven-plugin IllegalArgumentException from ASM, possibly Java 9 related
[
https://issues.apache.org/jira/browse/ARIES-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619227#comment-16619227
]
Michael Vorburger commented on ARIES-1826:
--
[~jbonofre] thanks for merging!
Were you also planning to release a 1.11.0 (not 1.10.1, noticed changed Fixed
Version) now?
> blueprint-maven-plugin IllegalArgumentException from ASM, possibly Java 9
> related
> -
>
> Key: ARIES-1826
> URL: https://issues.apache.org/jira/browse/ARIES-1826
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
>Affects Versions: blueprint-maven-plugin-1.10.0
>Reporter: Michael Vorburger
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: blueprint-maven-plugin-1.11.0
>
>
> From [https://jira.opendaylight.org/browse/ODLPARENT-167] :
> {code:java}
> [INFO] --- blueprint-maven-plugin:1.10.0:blueprint-generate (default) @
> northbound-api ---
> [INFO] Package org.opendaylight will be scanned
> (...)
> [ERROR] Failed to execute goal
> org.apache.aries.blueprint:blueprint-maven-plugin:1.10.0:blueprint-generate
> (default) on project northbound-api: Error during blueprint generation:
> IllegalArgumentException -> [Help 1]{code}
> With {{mvn-X}} (details in
> [ODLPARENT-167|https://jira.opendaylight.org/browse/ODLPARENT-167]) we find
> it's {{Caused by: java.lang.IllegalArgumentException at
> org.apache.xbean.asm5.ClassReader.}}, which could be related to it
> scanning some Java > 8 (9/10/11) class in some JAR?
> [~gnt] or [~ch...@die-schneider.net], I don't suppose this is a known issue
> for which you already have a fix, or an thoughts? [~skitt] FYI.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1826) blueprint-maven-plugin IllegalArgumentException from ASM, possibly Java 9 related
[
https://issues.apache.org/jira/browse/ARIES-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618154#comment-16618154
]
Michael Vorburger commented on ARIES-1826:
--
Heh, I fixed this! Turns out blueprint-maven-plugin used a really ancient
version of org.apache.xbean:xbean-finder-shaded, and just bumping this from 4.5
to latest 4.9 is enough to fix this - I've just tested this IRL, against
ODLPARENT-167. I'm guessing this pulls along a more recent version of ASM?
Whatever the reason, it does the trick.
[~skitt] or [~ch...@die-schneider.net] or [~gnt] would you be willing to merge
my PR #87 to Aries on GH (above) and release a 1.10.1 soon-ish?
> blueprint-maven-plugin IllegalArgumentException from ASM, possibly Java 9
> related
> -
>
> Key: ARIES-1826
> URL: https://issues.apache.org/jira/browse/ARIES-1826
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
>Affects Versions: blueprint-maven-plugin-1.10.0
>Reporter: Michael Vorburger
>Priority: Major
>
> From [https://jira.opendaylight.org/browse/ODLPARENT-167] :
> {code:java}
> [INFO] --- blueprint-maven-plugin:1.10.0:blueprint-generate (default) @
> northbound-api ---
> [INFO] Package org.opendaylight will be scanned
> (...)
> [ERROR] Failed to execute goal
> org.apache.aries.blueprint:blueprint-maven-plugin:1.10.0:blueprint-generate
> (default) on project northbound-api: Error during blueprint generation:
> IllegalArgumentException -> [Help 1]{code}
> With {{mvn-X}} (details in
> [ODLPARENT-167|https://jira.opendaylight.org/browse/ODLPARENT-167]) we find
> it's {{Caused by: java.lang.IllegalArgumentException at
> org.apache.xbean.asm5.ClassReader.}}, which could be related to it
> scanning some Java > 8 (9/10/11) class in some JAR?
> [~gnt] or [~ch...@die-schneider.net], I don't suppose this is a known issue
> for which you already have a fix, or an thoughts? [~skitt] FYI.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ARIES-1826) blueprint-maven-plugin IllegalArgumentException from ASM, possibly Java 9 related
Michael Vorburger created ARIES-1826:
Summary: blueprint-maven-plugin IllegalArgumentException from ASM,
possibly Java 9 related
Key: ARIES-1826
URL: https://issues.apache.org/jira/browse/ARIES-1826
Project: Aries
Issue Type: Bug
Components: Blueprint
Affects Versions: blueprint-maven-plugin-1.10.0
Reporter: Michael Vorburger
From [https://jira.opendaylight.org/browse/ODLPARENT-167] :
{code:java}
[INFO] --- blueprint-maven-plugin:1.10.0:blueprint-generate (default) @
northbound-api ---
[INFO] Package org.opendaylight will be scanned
(...)
[ERROR] Failed to execute goal
org.apache.aries.blueprint:blueprint-maven-plugin:1.10.0:blueprint-generate
(default) on project northbound-api: Error during blueprint generation:
IllegalArgumentException -> [Help 1]{code}
With {{mvn-X}} (details in
[ODLPARENT-167|https://jira.opendaylight.org/browse/ODLPARENT-167]) we find
it's {{Caused by: java.lang.IllegalArgumentException at
org.apache.xbean.asm5.ClassReader.}}, which could be related to it
scanning some Java > 8 (9/10/11) class in some JAR?
[~gnt] or [~ch...@die-schneider.net], I don't suppose this is a known issue for
which you already have a fix, or an thoughts? [~skitt] FYI.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ARIES-1820) blueprint-maven-plugin should fail instead of silently and arbitrarily choose one of several beans with an identical ID
Michael Vorburger created ARIES-1820:
Summary: blueprint-maven-plugin should fail instead of silently
and arbitrarily choose one of several beans with an identical ID
Key: ARIES-1820
URL: https://issues.apache.org/jira/browse/ARIES-1820
Project: Aries
Issue Type: Bug
Components: Blueprint
Reporter: Michael Vorburger
The blueprint-maven-plugin (1.4.0) will currently silently (!) pick one or
another of two (or more) singleton annotated classes with the same name for the
{{}} with an identical {{id=xyz}} to generate. This is VERY confusing...
:P
This happened to us (in OpenDaylight) when we had a {{@Singleton class
Something}} in {{package a;}} in one project, and another identically named
singleton class in another package in another project which was a dependency of
the first project (but both packages started with the same {{scanPath}} we
use). But it probably even happens if you have two classes of the same name in
different packages in the same project (not tested).
In an ideal world, such conflicts such lead to a build failure with a clear
message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ARIES-1808) ComponentDefinitionException message should contain actual class (interface) name instead of "ReferenceRecipe$ServiceProxyWrapper"
Michael Vorburger created ARIES-1808:
Summary: ComponentDefinitionException message should contain
actual class (interface) name instead of "ReferenceRecipe$ServiceProxyWrapper"
Key: ARIES-1808
URL: https://issues.apache.org/jira/browse/ARIES-1808
Project: Aries
Issue Type: Bug
Reporter: Michael Vorburger
I made some mistake in looking up a via an interface and then
passing that id as an to a which expected a concrete class
implementing that interface, and thought that kind error message could be a lot
more helpful if it contained the contain actual class (interface) names it was
about instead of (literally) "ReferenceRecipe$ServiceProxyWrapper" :
{noformat}
org.osgi.service.blueprint.container.ComponentDefinitionException: Unable to
find a matching constructor on class
org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter for
arguments
[org.apache.aries.blueprint.container.ReferenceRecipe$ServiceProxyWrapper@3be77953
(class
org.apache.aries.blueprint.container.ReferenceRecipe$ServiceProxyWrapper),
org.apache.aries.blueprint.container.ReferenceRecipe$ServiceProxyWrapper@333e9ff0
(class
org.apache.aries.blueprint.container.ReferenceRecipe$ServiceProxyWrapper)] when
instanciating bean tracingBindingDataBroker
org.osgi.service.blueprint.container.ComponentDefinitionException:
org.osgi.service.blueprint.container.ComponentDefinitionException: Unable to
find a matching constructor on class
org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter for
arguments
[org.apache.aries.blueprint.container.ReferenceRecipe$ServiceProxyWrapper@3be77953
(class
org.apache.aries.blueprint.container.ReferenceRecipe$ServiceProxyWrapper),
org.apache.aries.blueprint.container.ReferenceRecipe$ServiceProxyWrapper@333e9ff0
(class
org.apache.aries.blueprint.container.ReferenceRecipe$ServiceProxyWrapper)] when
instanciating bean tracingBindingDataBroker
at
org.apache.aries.blueprint.container.ServiceRecipe.createService(ServiceRecipe.java:310)
at
org.apache.aries.blueprint.container.ServiceRecipe.internalGetService(ServiceRecipe.java:252)
at
org.apache.aries.blueprint.container.ServiceRecipe.internalCreate(ServiceRecipe.java:149)
at org.apache.aries.blueprint.di.AbstractRecipe$1.call(AbstractRecipe.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at org.apache.aries.blueprint.di.AbstractRecipe.create(AbstractRecipe.java:88)
at
org.apache.aries.blueprint.container.BlueprintRepository.createInstances(BlueprintRepository.java:255)
at
org.apache.aries.blueprint.container.BlueprintRepository.createAll(BlueprintRepository.java:186)
at
org.apache.aries.blueprint.container.BlueprintContainerImpl.instantiateEagerComponents(BlueprintContainerImpl.java:704)
at
org.apache.aries.blueprint.container.BlueprintContainerImpl.doRun(BlueprintContainerImpl.java:410)
at
org.apache.aries.blueprint.container.BlueprintContainerImpl.run(BlueprintContainerImpl.java:275)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
org.apache.aries.blueprint.container.ExecutorServiceWrapper.run(ExecutorServiceWrapper.java:106)
at
org.apache.aries.blueprint.utils.threading.impl.DiscardableRunnable.run(DiscardableRunnable.java:48){noformat}
https://git.opendaylight.org/gerrit/#/c/72530/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1740) blueprint-maven-plugin should generate instead of for a @OsgiService List ?
[
https://issues.apache.org/jira/browse/ARIES-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184058#comment-16184058
]
Michael Vorburger commented on ARIES-1740:
--
I had a (brief) private email exchange with [~gnt] re. the removal of
@OsgiService in pax-cdi-api (which [he did in January in this
commit|https://github.com/ops4j/org.ops4j.pax.cdi/commit/0f39ef2f8121cf8afb4d822a0a32b10a9c0dde1d]),
and if I understand correctly, the @Service (and @Filter and @Attribute)
annotations are what replaces @OsgiService? So perhaps the
blueprint-maven-plugin should be (also) supporting generating the BP XML off of
those? And maybe that should become a separate new JIRA... we more "stumbled"
into this here! ;-)
> blueprint-maven-plugin should generate instead of id="list" interface="java.util.List"/> for a @OsgiService List ?
> ---
>
> Key: ARIES-1740
> URL: https://issues.apache.org/jira/browse/ARIES-1740
> Project: Aries
> Issue Type: New Feature
> Components: Blueprint
>Reporter: Michael Vorburger
>Assignee: Dominik Przybysz
> Fix For: blueprint-maven-plugin-1.9.0
>
>
> I may be misunderstanding something, but I would have expected the
> {{blueprint-maven-plugin}} (currently using its 1.4.0 in ODL) to generate
> {{}} instead of a {{ interface="java.util.List"/>}} for a {{@Singleton}}'s bean constructor
> {{@Inject @OsgiService List services}} argument?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARIES-1740) blueprint-maven-plugin should generate instead of for a @OsgiService List ?
[
https://issues.apache.org/jira/browse/ARIES-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179476#comment-16179476
]
Michael Vorburger commented on ARIES-1740:
--
> use @ReferenceListener annotation and track binding and unbinding of osgi
> services and then reference-list element will be generated
Ah, OK; tx. I thought letting Aries does it's dynamic proxy list thing was
nice, and seemed "better" to me than a listener.
> write reference-list in separate blueprint file and inject it without
> @OsgiService (but propably with @Named(...))
yep, that's exactly what we've done to move - just thought I'd raise as a
possible future enhancement/change request, fine.
> The main problem with reference and reference-list is how to decide if you
> need one service implementing java.util.List (as it is generated now) or list
> of services (what you want in this issue).
I see, OK. Personally I would think that one wanting to inject java.util.List
is perhaps unlikely, not real something anyone would ever want to do especially
without a TypeLiteral like in Guice DI (but you could use named and filters, of
course), so perhaps could even default to list of services. That would break
backwards compatibility though, so perhaps it's already too late for that?
FYI I've noticed a dynamic=true/false flag on the OsgiService annotation..
Peeking at it's JavaDoc here
https://github.com/ops4j/org.ops4j.pax.cdi/blob/cdi-1.0.0.RC2/pax-cdi-api/src/main/java/org/ops4j/pax/cdi/api/OsgiService.java#L53
makes me wonder if this could be used as an indication.. or better not to mix
up with that concept?
> Maybe we need another annotation e. g. @OsgiServices ?
Or just a new attribute on OsgiService? Like... well, referenceList? Maybe
default to true, so that it does OOB what I think one would normally want, but
one who wants the current behaviour could override to behave as today? Or again
if backwards compatibility is an issue, then default to false, and opt-in to
true.
BUT while trying to find the JavaDoc of the OsgiService annotation, I noticed
that the master branch of ops4j cdi doesn't have the OsgiService annotation
anymore, see
https://github.com/ops4j/org.ops4j.pax.cdi/tree/0.x/pax-cdi-api/src/main/java/org/ops4j/pax/cdi/api
- what's going on there? We're just starting to use it more in ODL, so if this
is removed, deprecated or somewhere else now, I'd be interesting in knowing
more about that...
> blueprint-maven-plugin should generate instead of id="list" interface="java.util.List"/> for a @OsgiService List ?
> ---
>
> Key: ARIES-1740
> URL: https://issues.apache.org/jira/browse/ARIES-1740
> Project: Aries
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Dominik Przybysz
>
> I may be misunderstanding something, but I would have expected the
> {{blueprint-maven-plugin}} (currently using its 1.4.0 in ODL) to generate
> {{}} instead of a {{ interface="java.util.List"/>}} for a {{@Singleton}}'s bean constructor
> {{@Inject @OsgiService List services}} argument?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (ARIES-1740) blueprint-maven-plugin should generate instead of for a @OsgiService List ?
Michael Vorburger created ARIES-1740:
Summary: blueprint-maven-plugin should generate
instead of for a @OsgiService
List ?
Key: ARIES-1740
URL: https://issues.apache.org/jira/browse/ARIES-1740
Project: Aries
Issue Type: Bug
Reporter: Michael Vorburger
I may be misunderstanding something, but I would have expected the
{{blueprint-maven-plugin}} (currently using its 1.4.0 in ODL) to generate
{{}} instead of a {{}} for a {{@Singleton}}'s bean constructor
{{@Inject @OsgiService List services}} argument?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (ARIES-1597) blueprint-maven-plugin new option to override generatedDir
[ https://issues.apache.org/jira/browse/ARIES-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated ARIES-1597: - Description: In ODL we use another place than the default "OSGI-INF/blueprint/" and would like to be able to customize the directory that the blueprint-maven-plugin generates the XML into. Proposed patch in https://github.com/apache/aries/pull/52 was:In ODL we use another place than the default "OSGI-INF/blueprint/" and would like to be able to customize the directory that the blueprint-maven-plugin generates the XML into. > blueprint-maven-plugin new option to override generatedDir > -- > > Key: ARIES-1597 > URL: https://issues.apache.org/jira/browse/ARIES-1597 > Project: Aries > Issue Type: Improvement > Components: Blueprint >Affects Versions: blueprint-maven-plugin-1.4.0 >Reporter: Michael Vorburger > Fix For: blueprint-maven-plugin-1.5.0 > > > In ODL we use another place than the default "OSGI-INF/blueprint/" and would > like to be able to customize the directory that the blueprint-maven-plugin > generates the XML into. > Proposed patch in https://github.com/apache/aries/pull/52 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARIES-1597) blueprint-maven-plugin new option to override generatedDir
[ https://issues.apache.org/jira/browse/ARIES-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated ARIES-1597: - Flags: Patch > blueprint-maven-plugin new option to override generatedDir > -- > > Key: ARIES-1597 > URL: https://issues.apache.org/jira/browse/ARIES-1597 > Project: Aries > Issue Type: Improvement > Components: Blueprint >Affects Versions: blueprint-maven-plugin-1.4.0 >Reporter: Michael Vorburger > Fix For: blueprint-maven-plugin-1.5.0 > > > In ODL we use another place than the default "OSGI-INF/blueprint/" and would > like to be able to customize the directory that the blueprint-maven-plugin > generates the XML into. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARIES-1597) blueprint-maven-plugin new option to override generatedDir
Michael Vorburger created ARIES-1597: Summary: blueprint-maven-plugin new option to override generatedDir Key: ARIES-1597 URL: https://issues.apache.org/jira/browse/ARIES-1597 Project: Aries Issue Type: Improvement Components: Blueprint Affects Versions: blueprint-maven-plugin-1.4.0 Reporter: Michael Vorburger Fix For: blueprint-maven-plugin-1.5.0 In ODL we use another place than the default "OSGI-INF/blueprint/" and would like to be able to customize the directory that the blueprint-maven-plugin generates the XML into. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
