GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/aries/pull/77
Fix the problem of using '+' and '+=' operators to concatenate string⦠â¦s in a loop. The method is building a String using concatenation in a loop. In each iteration, the String is converted to a StringBuilder, appended to, and converted back to a String. This can lead to a cost quadratic in the number of iterations, as the growing string is recopied in each iteration. Better performance can be obtained by using a StringBuilder explicitly. http://findbugs.sourceforge.net/bugDescriptions.html#SBSC_USE_STRINGBUFFER_CONCATENATION You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/aries trunk2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/aries/pull/77.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #77 ---- commit 5e8bb88a2b1df7e7372fdebd563fb47f421d5e80 Author: Kui LIU <brucekui...@gmail.com> Date: 2017-10-09T20:15:04Z Fix the problem of using '+' and '+=' operators to concatenate strings in a loop. The method is building a String using concatenation in a loop. In each iteration, the String is converted to a StringBuilder, appended to, and converted back to a String. This can lead to a cost quadratic in the number of iterations, as the growing string is recopied in each iteration. Better performance can be obtained by using a StringBuilder explicitly. http://findbugs.sourceforge.net/bugDescriptions.html#SBSC_USE_STRINGBUFFER_CONCATENATION ---- ---