[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734872#comment-16734872 ] ASF subversion and git services commented on ARIES-1880: Commit 7294f82aeb79ba271c5138ac931792134040ee06 in aries-journaled-events's branch refs/heads/master from Christian Schneider [ https://gitbox.apache.org/repos/asf?p=aries-journaled-events.git;h=7294f82 ] ARIES-1880 - Use proper builder > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: journaled-events-0.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734800#comment-16734800 ] ASF subversion and git services commented on ARIES-1880: Commit bc2769ade6b1c5c111e397e3830f6b5d4ebd91c3 in aries-journaled-events's branch refs/heads/master from Christian Schneider [ https://gitbox.apache.org/repos/asf?p=aries-journaled-events.git;h=bc2769a ] Merge pull request #10 from apache/ARIES-1880 ARIES-1880 - Use builder in subscribe > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734798#comment-16734798 ] ASF subversion and git services commented on ARIES-1880: Commit 12c21af3f7bea344f594546d74227dd1862d0eca in aries-journaled-events's branch refs/heads/master from Christian Schneider [ https://gitbox.apache.org/repos/asf?p=aries-journaled-events.git;h=12c21af ] ARIES-1880 - Use builder in subscribe > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734799#comment-16734799 ] ASF subversion and git services commented on ARIES-1880: Commit bc2769ade6b1c5c111e397e3830f6b5d4ebd91c3 in aries-journaled-events's branch refs/heads/master from Christian Schneider [ https://gitbox.apache.org/repos/asf?p=aries-journaled-events.git;h=bc2769a ] Merge pull request #10 from apache/ARIES-1880 ARIES-1880 - Use builder in subscribe > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[
https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734420#comment-16734420
]
Timothee Maret commented on ARIES-1880:
---
FWIW, using a Builder looks like a good approach to me. The current PR seems to
include a slightly different approach than the builder pattern though. If we
use the actual pattern (all building method return a
{{SubscribeRequestBuilder}}, a {{build}} method return the actual
{{SubscribeRequest}}) then we could add some checks in the builder that would
allow to enforce, for instance, that the Seek parameter is set.
> Use builder instead of many parameters in subscribe
> ---
>
> Key: ARIES-1880
> URL: https://issues.apache.org/jira/browse/ARIES-1880
> Project: Aries
> Issue Type: Improvement
> Components: Journaled Events
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Subscription subscribe(String topic, Position position, Seek seek,
> Consumer callback);
> 4 Parameters which can partly be null is not a good idea. [~alien11689]
> proposed on the list to use a DTO.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734339#comment-16734339 ] Dominik Przybysz commented on ARIES-1880: - Yes :) It will be even more readable if you replace the getters and setters with lombok :) > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734161#comment-16734161 ] Christian Schneider commented on ARIES-1880: [~alien11689] .. is this what you thought of ? https://github.com/apache/aries-journaled-events/pull/10 > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734159#comment-16734159 ] ASF subversion and git services commented on ARIES-1880: Commit 12c21af3f7bea344f594546d74227dd1862d0eca in aries-journaled-events's branch refs/heads/ARIES-1880 from Christian Schneider [ https://gitbox.apache.org/repos/asf?p=aries-journaled-events.git;h=12c21af ] ARIES-1880 - Use builder in subscribe > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
