Re: [Java] PR review for ARROW-11173

2021-01-21 Thread Fan Liya
I will take a look in one or two days.

Best,
Liya Fan

On Wed, Jan 20, 2021 at 3:48 AM Bryan Cutler  wrote:

> Hi Nick,
> I left a note in the PR that I will try to review soon, thanks!
>
>
> On Sun, Jan 17, 2021 at 8:22 PM Nick Bruno  wrote:
>
> > Hi All,
> >
> > I'd like to get feedback on the pull request I created a little over a
> > week ago - https://github.com/apache/arrow/pull/9151
> >
> > It adds support for Map types in the readers / writers.
> >
> > Let me know how I can improve it.
> >
> > Thanks,
> > Nick
> >
>


Re: [Java] PR review for ARROW-11173

2021-01-19 Thread Bryan Cutler
Hi Nick,
I left a note in the PR that I will try to review soon, thanks!


On Sun, Jan 17, 2021 at 8:22 PM Nick Bruno  wrote:

> Hi All,
>
> I'd like to get feedback on the pull request I created a little over a
> week ago - https://github.com/apache/arrow/pull/9151
>
> It adds support for Map types in the readers / writers.
>
> Let me know how I can improve it.
>
> Thanks,
> Nick
>


[Java] PR review for ARROW-11173

2021-01-17 Thread Nick Bruno
Hi All,

I'd like to get feedback on the pull request I created a little over a week ago 
- https://github.com/apache/arrow/pull/9151

It adds support for Map types in the readers / writers.

Let me know how I can improve it.

Thanks,
Nick