Jenkins build is unstable: asterix-integration-tests 3d7ec2ff

2017-01-05 Thread Asterix build server
See 



Re: Exception refactoring proposal

2017-01-05 Thread Mike Carey

+1;

:-)


On 1/5/17 11:12 AM, Yingyi Bu wrote:

Hi dev,

 I recent made a change that moved some exception error message
templates from the source code into properties files [1]. Here is an
exception refactoring proposal [2].

 I propose that:
 --  from now on, we all follow the proposal when we want to throw
exceptions, and enforce the key design during our code reviews.
 --  for existing code that does not follow the proposal, we refactor
them gradually according to the proposal.

 Feel free to share your thoughts.
 Thanks!

Best,
Yingyi

[1] https://asterix-gerrit.ics.uci.edu/#/c/1410/
[2] https://cwiki.apache.org/confluence/display/ASTERIXDB/Exception+Handling





Exception refactoring proposal

2017-01-05 Thread Yingyi Bu
Hi dev,

I recent made a change that moved some exception error message
templates from the source code into properties files [1]. Here is an
exception refactoring proposal [2].

I propose that:
--  from now on, we all follow the proposal when we want to throw
exceptions, and enforce the key design during our code reviews.
--  for existing code that does not follow the proposal, we refactor
them gradually according to the proposal.

Feel free to share your thoughts.
Thanks!

Best,
Yingyi

[1] https://asterix-gerrit.ics.uci.edu/#/c/1410/
[2] https://cwiki.apache.org/confluence/display/ASTERIXDB/Exception+Handling