Re: Review Request 64476: DSL Implementation using Antlr

2017-12-11 Thread Ashutosh Mestry

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64476/
---

(Updated Dec. 12, 2017, 7:53 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Updates include:
- Operators: LT, GT, LTE, GTE, EQ, NEQ, IN implemented. 
- Added support for traits with space in their name.
- Updated unit tests.


Bugs: ATLAS-2229
https://issues.apache.org/jira/browse/ATLAS-2229


Repository: atlas


Description
---

**Background**
Atlas' DSL implementation was removed with the removal of the older type system 
implementation, thus creating gap in functionality.

The patch implements Atlas' DSL using Antlr and a new from-scratch 
implementation.

**Approach**
Highlights of the implementation:
- Does not use any of the old scala-based implementation of lexer and parser. 
It uses Antlr library for this purpose.
- Generated Gremlin queries are much simpler than the earlier implementation. 
- Interface with rest of the application has been streamlined.

The Antlr's G4 (_Atlas.G4_) grammer file implements the DSL grammer. Antlr 
code-generates the requisit lexer and parser.

The _DSLVisitor_ class is the concrete visitor implementation for the generated 
syntax tree. 

_QueryProcessor_ maintains sequence of Gremlin clauses that are found during 
the abstract syntax tree traversal. It uses _TypeRegistry_ for creating 
qualified names.

Integration with rest of the application has had little impact.


Diffs (updated)
-

  3party-licenses/Antlr-LICENSE PRE-CREATION 
  pom.xml 233506c8 
  repository/pom.xml 35b74e32 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
67aeb308 
  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/Expressions.java 9e93ce41 
  repository/src/main/java/org/apache/atlas/query/GremlinQuery.java fcb1f483 
  repository/src/main/java/org/apache/atlas/query/GremlinTranslator.java 
5395ddd3 
  repository/src/main/java/org/apache/atlas/query/QueryParser.java 1e5e5ff9 
  repository/src/main/java/org/apache/atlas/query/QueryProcessor.java 04cf0b4d 
  repository/src/main/java/org/apache/atlas/query/SelectExpressionHelper.java 
a8748efa 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.tokens 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java
 PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
 PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java a338ae2a 


Diff: https://reviews.apache.org/r/64476/diff/9/

Changes: https://reviews.apache.org/r/64476/diff/8-9/


Testing
---

**Unit tests**
_QueryProcessorTest_ implements the testing framework for DSL. It has relevant 
code that setup up environment to verify various clauses implemented.

**Functional testing**
- Verified from web UI.
- Verified using '_Saved Search_' feature.

**Additional verification**
Generated Gremlin queries have been verified using JanusGraph shell customized 
for Atlas.


Thanks,

Ashutosh Mestry



Re: Review Request 64476: DSL Implementation using Antlr

2017-12-11 Thread Ashutosh Mestry

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64476/
---

(Updated Dec. 12, 2017, 4:27 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Updates include:
- Modification to _QuickStart_ to execute currently supported queries.
- Added tests for DSL that were removed as part of earlier clean-up exercise.


Bugs: ATLAS-2229
https://issues.apache.org/jira/browse/ATLAS-2229


Repository: atlas


Description
---

**Background**
Atlas' DSL implementation was removed with the removal of the older type system 
implementation, thus creating gap in functionality.

The patch implements Atlas' DSL using Antlr and a new from-scratch 
implementation.

**Approach**
Highlights of the implementation:
- Does not use any of the old scala-based implementation of lexer and parser. 
It uses Antlr library for this purpose.
- Generated Gremlin queries are much simpler than the earlier implementation. 
- Interface with rest of the application has been streamlined.

The Antlr's G4 (_Atlas.G4_) grammer file implements the DSL grammer. Antlr 
code-generates the requisit lexer and parser.

The _DSLVisitor_ class is the concrete visitor implementation for the generated 
syntax tree. 

_QueryProcessor_ maintains sequence of Gremlin clauses that are found during 
the abstract syntax tree traversal. It uses _TypeRegistry_ for creating 
qualified names.

Integration with rest of the application has had little impact.


Diffs (updated)
-

  3party-licenses/Antlr-LICENSE PRE-CREATION 
  pom.xml 233506c8 
  repository/pom.xml 35b74e32 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
67aeb308 
  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/Expressions.java 9e93ce41 
  repository/src/main/java/org/apache/atlas/query/GremlinQuery.java fcb1f483 
  repository/src/main/java/org/apache/atlas/query/GremlinTranslator.java 
5395ddd3 
  repository/src/main/java/org/apache/atlas/query/QueryParser.java 1e5e5ff9 
  repository/src/main/java/org/apache/atlas/query/QueryProcessor.java 04cf0b4d 
  repository/src/main/java/org/apache/atlas/query/SelectExpressionHelper.java 
a8748efa 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.tokens 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java
 PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
 PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java a338ae2a 


Diff: https://reviews.apache.org/r/64476/diff/8/

Changes: https://reviews.apache.org/r/64476/diff/7-8/


Testing
---

**Unit tests**
_QueryProcessorTest_ implements the testing framework for DSL. It has relevant 
code that setup up environment to verify various clauses implemented.

**Functional testing**
- Verified from web UI.
- Verified using '_Saved Search_' feature.

**Additional verification**
Generated Gremlin queries have been verified using JanusGraph shell customized 
for Atlas.


Thanks,

Ashutosh Mestry



Re: Review Request 64476: DSL Implementation using Antlr

2017-12-11 Thread Ashutosh Mestry

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64476/
---

(Updated Dec. 12, 2017, 3:23 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Updates include:
- Update G4 files. Updates to grammer to handle edge cases, and quoted 
identifiers.
- Updated unit tests.


Bugs: ATLAS-2229
https://issues.apache.org/jira/browse/ATLAS-2229


Repository: atlas


Description
---

**Background**
Atlas' DSL implementation was removed with the removal of the older type system 
implementation, thus creating gap in functionality.

The patch implements Atlas' DSL using Antlr and a new from-scratch 
implementation.

**Approach**
Highlights of the implementation:
- Does not use any of the old scala-based implementation of lexer and parser. 
It uses Antlr library for this purpose.
- Generated Gremlin queries are much simpler than the earlier implementation. 
- Interface with rest of the application has been streamlined.

The Antlr's G4 (_Atlas.G4_) grammer file implements the DSL grammer. Antlr 
code-generates the requisit lexer and parser.

The _DSLVisitor_ class is the concrete visitor implementation for the generated 
syntax tree. 

_QueryProcessor_ maintains sequence of Gremlin clauses that are found during 
the abstract syntax tree traversal. It uses _TypeRegistry_ for creating 
qualified names.

Integration with rest of the application has had little impact.


Diffs (updated)
-

  3party-licenses/Antlr-LICENSE PRE-CREATION 
  pom.xml 233506c8 
  repository/pom.xml 35b74e32 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
67aeb308 
  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/Expressions.java 9e93ce41 
  repository/src/main/java/org/apache/atlas/query/GremlinQuery.java fcb1f483 
  repository/src/main/java/org/apache/atlas/query/GremlinTranslator.java 
5395ddd3 
  repository/src/main/java/org/apache/atlas/query/QueryParser.java 1e5e5ff9 
  repository/src/main/java/org/apache/atlas/query/QueryProcessor.java 04cf0b4d 
  repository/src/main/java/org/apache/atlas/query/SelectExpressionHelper.java 
a8748efa 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.tokens 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java
 PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
 PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java a338ae2a 


Diff: https://reviews.apache.org/r/64476/diff/7/

Changes: https://reviews.apache.org/r/64476/diff/6-7/


Testing
---

**Unit tests**
_QueryProcessorTest_ implements the testing framework for DSL. It has relevant 
code that setup up environment to verify various clauses implemented.

**Functional testing**
- Verified from web UI.
- Verified using '_Saved Search_' feature.

**Additional verification**
Generated Gremlin queries have been verified using JanusGraph shell customized 
for Atlas.


Thanks,

Ashutosh Mestry



Build failed in Jenkins: Atlas-master-IntegrationTests #217

2017-12-11 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2308: Remove 'titan1' graph provider from atlas

--
[...truncated 360.01 KB...]
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:134)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
Caused by: java.lang.ClassNotFoundException: com.sleepycat.je.LockMode
at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass 
(SelfFirstStrategy.java:50)
at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass 
(ClassRealm.java:271)
at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass 
(ClassRealm.java:247)
at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass 
(ClassRealm.java:239)
at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass 
(WebAppClassLoader.java:487)
at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass 
(WebAppClassLoader.java:428)
at org.janusgraph.diskstorage.berkeleyje.BerkeleyJEStoreManager. 
(BerkeleyJEStoreManager.java:61)
at java.lang.Class.forName0 (Native Method)
at java.lang.Class.forName (Class.java:264)
at org.janusgraph.util.system.ConfigurationUtil.instantiate 
(ConfigurationUtil.java:56)
at org.janusgraph.diskstorage.Backend.getImplementationClass 
(Backend.java:477)
at org.janusgraph.diskstorage.Backend.getStorageManager (Backend.java:409)
at org.janusgraph.graphdb.configuration.GraphDatabaseConfiguration. 
(GraphDatabaseConfiguration.java:1376)
at org.janusgraph.core.JanusGraphFactory.open (JanusGraphFactory.java:164)
at org.janusgraph.core.JanusGraphFactory.open (JanusGraphFactory.java:133)
at org.janusgraph.core.JanusGraphFactory.open (JanusGraphFactory.java:113)
at 
org.apache.atlas.repository.graphdb.janus.AtlasJanusGraphDatabase.getGraphInstance
 (AtlasJanusGraphDatabase.java:108)
at 
org.apache.atlas.repository.graphdb.janus.AtlasJanusGraphDatabase.getGraph 
(AtlasJanusGraphDatabase.java:173)
at org.apache.atlas.repository.graph.AtlasGraphProvider.getGraphInstance 
(AtlasGraphProvider.java:40)
at org.apache.atlas.repository.graph.AtlasGraphProvider.get 
(AtlasGraphProvider.java:71)
at 
org.apache.atlas.repository.graph.AtlasGraphProvider$$EnhancerBySpringCGLIB$$147c0988.CGLIB$get$0
 ()
at 
org.apache.atlas.repository.graph.AtlasGraphProvider$$EnhancerBySpringCGLIB$$147c0988$$FastClassBySpringCGLIB$$1bdd2512.invoke
 ()
at org.springframework.cglib.proxy.MethodProxy.invokeSuper 
(MethodProxy.java:228)
at 
org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept
 (ConfigurationClassEnhancer.java:358)
at 
org.apache.atlas.repository.graph.AtlasGraphProvider$$EnhancerBySpringCGLIB$$147c0988.get
 ()
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at 

Re: Review Request 64476: DSL Implementation using Antlr

2017-12-11 Thread Ashutosh Mestry

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64476/
---

(Updated Dec. 12, 2017, 1:19 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Updates include:
- QuickStart clauses.
- Additional unit tests.


Bugs: ATLAS-2229
https://issues.apache.org/jira/browse/ATLAS-2229


Repository: atlas


Description
---

**Background**
Atlas' DSL implementation was removed with the removal of the older type system 
implementation, thus creating gap in functionality.

The patch implements Atlas' DSL using Antlr and a new from-scratch 
implementation.

**Approach**
Highlights of the implementation:
- Does not use any of the old scala-based implementation of lexer and parser. 
It uses Antlr library for this purpose.
- Generated Gremlin queries are much simpler than the earlier implementation. 
- Interface with rest of the application has been streamlined.

The Antlr's G4 (_Atlas.G4_) grammer file implements the DSL grammer. Antlr 
code-generates the requisit lexer and parser.

The _DSLVisitor_ class is the concrete visitor implementation for the generated 
syntax tree. 

_QueryProcessor_ maintains sequence of Gremlin clauses that are found during 
the abstract syntax tree traversal. It uses _TypeRegistry_ for creating 
qualified names.

Integration with rest of the application has had little impact.


Diffs (updated)
-

  3party-licenses/Antlr-LICENSE PRE-CREATION 
  pom.xml 4ee2d9ec 
  repository/pom.xml 35b74e32 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
67aeb308 
  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/Expressions.java 9e93ce41 
  repository/src/main/java/org/apache/atlas/query/GremlinQuery.java fcb1f483 
  repository/src/main/java/org/apache/atlas/query/GremlinTranslator.java 
5395ddd3 
  repository/src/main/java/org/apache/atlas/query/QueryParser.java 1e5e5ff9 
  repository/src/main/java/org/apache/atlas/query/QueryProcessor.java 04cf0b4d 
  repository/src/main/java/org/apache/atlas/query/SelectExpressionHelper.java 
a8748efa 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.tokens 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java
 PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
 PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java a338ae2a 


Diff: https://reviews.apache.org/r/64476/diff/6/

Changes: https://reviews.apache.org/r/64476/diff/5-6/


Testing
---

**Unit tests**
_QueryProcessorTest_ implements the testing framework for DSL. It has relevant 
code that setup up environment to verify various clauses implemented.

**Functional testing**
- Verified from web UI.
- Verified using '_Saved Search_' feature.

**Additional verification**
Generated Gremlin queries have been verified using JanusGraph shell customized 
for Atlas.


Thanks,

Ashutosh Mestry



Re: Review Request 64503: [ATLAS-2308]: Remove 'titan1' graph provider from atlas

2017-12-11 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64503/#review193475
---


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 11, 2017, 6:48 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64503/
> ---
> 
> (Updated Dec. 11, 2017, 6:48 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2308
> https://issues.apache.org/jira/browse/ATLAS-2308
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> We have 3 graph databases in atlas:
> 1. titan0 (Titan 0.5.4)
> 2. titan1 (Titan 1.0.0)
> 3. janus (JanusGraph 0.2.0)
> 
> The default graph-provider is JanusGraph currently. I propose we remove 
> 'titan1' graph provider from Atlas for reasons below:
> 1. 'titan1' has not been tested thoroughly and have higher chances of 
> potential issues.
> 2. We have moved on to use JanusGraph in Atlas which is an improved graph 
> database forked from Titan 1 with community support and active development 
> going on. 
> 3. TitanDB is retired, the new project JanusGraph which is now part of the 
> Linux foundation has more interest and backing.
> 
> We will continue to support 'titan0' as Titan 0.5.4 has been tested and have 
> wider audience within the community and also to support backward 
> compatibility.
> Attach one or more files to this issue
> 
> 
> Diffs
> -
> 
>   graphdb/pom.xml 426238cf 
>   graphdb/readme.txt 2ad78456 
>   graphdb/titan1/pom.xml b9483bad 
>   graphdb/titan1/readme.txt 4fcddbaf 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/GraphDbObjectFactory.java
>  7928a846 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Edge.java
>  bcc009bb 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1EdgeLabel.java
>  fdcc33dc 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Element.java
>  b1cd4583 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
>  d94289dc 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java
>  dfb53545 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java
>  5ec11803 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphManagement.java
>  a5d3815b 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
>  c7e4150f 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1PropertyKey.java
>  6b62f27e 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java
>  1670e929 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
>  a761a744 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/TitanObjectFactory.java
>  a4776a9f 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java
>  df67a836 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONMode.java
>  2bab2877 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONTokens.java
>  49bbdb43 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java
>  26abe2e4 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
>  733964de 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1GraphQuery.java
>  dd0176bf 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigDecimalSerializer.java
>  c1a096db 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigIntegerSerializer.java
>  dfda9f6e 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java
>  eb99faee 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/TypeCategorySerializer.java
>  c3e2d1c5 
>   
> graphdb/titan1/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory
>  24c8a755 
>   
> graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java
>  06e27851 
>   
> graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java
>  45fbbea6 
>   
> 

[jira] [Created] (ATLAS-2308) Remove 'titan1' graph provider from atlas

2017-12-11 Thread Sarath Subramanian (JIRA)
Sarath Subramanian created ATLAS-2308:
-

 Summary: Remove 'titan1' graph provider from atlas
 Key: ATLAS-2308
 URL: https://issues.apache.org/jira/browse/ATLAS-2308
 Project: Atlas
  Issue Type: Task
  Components:  atlas-core
Affects Versions: 1.0.0
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian
 Fix For: 1.0.0


We have 3 graph databases in atlas:
1. titan0 (Titan 0.5.4)
2. titan1 (Titan 1.0.0)
3. janus (JanusGraph 0.2.0)

The default graph-provider is *JanusGraph* currently. I propose we remove 
'titan1' graph provider from Atlas for reasons below:

1. 'titan1' has not been tested thoroughly and have higher chances of potential 
issues.
2. We have moved on to use JanusGraph in Atlas which is an improved graph 
database forked from Titan 1 with community support and active development 
going on. 
2. TitanDB is retired, the new project JanusGraph which is now part of the 
Linux foundation has more interest and backing.

We will continue to support 'titan0' as Titan 0.5.4 has been tested and have a 
wider audience within the community and also to support backward compatibility. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Jenkins build is back to normal : Atlas-master-UnitTests #200

2017-12-11 Thread Apache Jenkins Server
See 



[jira] [Commented] (ATLAS-2308) Remove 'titan1' graph provider from atlas

2017-12-11 Thread Sarath Subramanian (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286400#comment-16286400
 ] 

Sarath Subramanian commented on ATLAS-2308:
---

Code Review: https://reviews.apache.org/r/64503/

> Remove 'titan1' graph provider from atlas
> -
>
> Key: ATLAS-2308
> URL: https://issues.apache.org/jira/browse/ATLAS-2308
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
> Fix For: 1.0.0
>
> Attachments: ATLAS-2308.1.patch
>
>
> We have 3 graph databases in atlas:
> 1. titan0 (Titan 0.5.4)
> 2. titan1 (Titan 1.0.0)
> 3. janus (JanusGraph 0.2.0)
> The default graph-provider is *JanusGraph* currently. I propose we remove 
> 'titan1' graph provider from Atlas for reasons below:
> 1. 'titan1' has not been tested thoroughly and have higher chances of 
> potential issues.
> 2. We have moved on to use JanusGraph in Atlas which is an improved graph 
> database forked from Titan 1 with community support and active development 
> going on. 
> 2. TitanDB is retired, the new project JanusGraph which is now part of the 
> Linux foundation has more interest and backing.
> We will continue to support 'titan0' as Titan 0.5.4 has been tested and have 
> wider audience within the community and also to support backward 
> compatibility. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Review Request 64503: [ATLAS-2308]: Remove 'titan1' graph provider from atlas

2017-12-11 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64503/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2308
https://issues.apache.org/jira/browse/ATLAS-2308


Repository: atlas


Description
---

We have 3 graph databases in atlas:
1. titan0 (Titan 0.5.4)
2. titan1 (Titan 1.0.0)
3. janus (JanusGraph 0.2.0)

The default graph-provider is JanusGraph currently. I propose we remove 
'titan1' graph provider from Atlas for reasons below:
1. 'titan1' has not been tested thoroughly and have higher chances of potential 
issues.
2. We have moved on to use JanusGraph in Atlas which is an improved graph 
database forked from Titan 1 with community support and active development 
going on. 
3. TitanDB is retired, the new project JanusGraph which is now part of the 
Linux foundation has more interest and backing.

We will continue to support 'titan0' as Titan 0.5.4 has been tested and have 
wider audience within the community and also to support backward compatibility.
Attach one or more files to this issue


Diffs
-

  graphdb/pom.xml 426238cf 
  graphdb/readme.txt 2ad78456 
  graphdb/titan1/pom.xml b9483bad 
  graphdb/titan1/readme.txt 4fcddbaf 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/GraphDbObjectFactory.java
 7928a846 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Edge.java
 bcc009bb 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1EdgeLabel.java
 fdcc33dc 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Element.java
 b1cd4583 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
 d94289dc 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java
 dfb53545 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java
 5ec11803 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphManagement.java
 a5d3815b 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
 c7e4150f 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1PropertyKey.java
 6b62f27e 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java
 1670e929 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
 a761a744 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/TitanObjectFactory.java
 a4776a9f 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java
 df67a836 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONMode.java
 2bab2877 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONTokens.java
 49bbdb43 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java
 26abe2e4 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
 733964de 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1GraphQuery.java
 dd0176bf 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigDecimalSerializer.java
 c1a096db 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigIntegerSerializer.java
 dfda9f6e 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java
 eb99faee 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/TypeCategorySerializer.java
 c3e2d1c5 
  
graphdb/titan1/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory
 24c8a755 
  
graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java
 06e27851 
  
graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java
 45fbbea6 
  
graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java
 ab2c8c94 
  
graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/TitanGraphProviderTest.java
 53148fa6 
  graphdb/titan1/src/test/resources/atlas-application.properties af63dd82 
  pom.xml 4ee2d9ec 


Diff: https://reviews.apache.org/r/64503/diff/1/


Testing
---

mvn clean package succeeded.


Thanks,

Sarath Subramanian



[jira] [Updated] (ATLAS-2308) Remove 'titan1' graph provider from atlas

2017-12-11 Thread Sarath Subramanian (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-2308:
--
Attachment: ATLAS-2308.1.patch

> Remove 'titan1' graph provider from atlas
> -
>
> Key: ATLAS-2308
> URL: https://issues.apache.org/jira/browse/ATLAS-2308
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
> Fix For: 1.0.0
>
> Attachments: ATLAS-2308.1.patch
>
>
> We have 3 graph databases in atlas:
> 1. titan0 (Titan 0.5.4)
> 2. titan1 (Titan 1.0.0)
> 3. janus (JanusGraph 0.2.0)
> The default graph-provider is *JanusGraph* currently. I propose we remove 
> 'titan1' graph provider from Atlas for reasons below:
> 1. 'titan1' has not been tested thoroughly and have higher chances of 
> potential issues.
> 2. We have moved on to use JanusGraph in Atlas which is an improved graph 
> database forked from Titan 1 with community support and active development 
> going on. 
> 2. TitanDB is retired, the new project JanusGraph which is now part of the 
> Linux foundation has more interest and backing.
> We will continue to support 'titan0' as Titan 0.5.4 has been tested and have 
> wider audience within the community and also to support backward 
> compatibility. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 64476: DSL Implementation using Antlr

2017-12-11 Thread Apoorv Naik


> On Dec. 11, 2017, 9:41 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java
> > Lines 1 (patched)
> > 
> >
> > I am wondering why we are checking in generated files. I suggeste these 
> > are generated as part of the build and then .gitignored

It's better to check in the files to avoid compile time overhead and adding 
more configuration in maven pom (might become a problem across different dev 
environments), antlr docs for maven suggest adding directives to the POM so 
that the src code can refer to the generated files (I found it to be an 
unnecessary overhead and comes in the way to dev time)


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64476/#review193378
---


On Dec. 11, 2017, 6:51 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64476/
> ---
> 
> (Updated Dec. 11, 2017, 6:51 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2229
> https://issues.apache.org/jira/browse/ATLAS-2229
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Atlas' DSL implementation was removed with the removal of the older type 
> system implementation, thus creating gap in functionality.
> 
> The patch implements Atlas' DSL using Antlr and a new from-scratch 
> implementation.
> 
> **Approach**
> Highlights of the implementation:
> - Does not use any of the old scala-based implementation of lexer and parser. 
> It uses Antlr library for this purpose.
> - Generated Gremlin queries are much simpler than the earlier implementation. 
> - Interface with rest of the application has been streamlined.
> 
> The Antlr's G4 (_Atlas.G4_) grammer file implements the DSL grammer. Antlr 
> code-generates the requisit lexer and parser.
> 
> The _DSLVisitor_ class is the concrete visitor implementation for the 
> generated syntax tree. 
> 
> _QueryProcessor_ maintains sequence of Gremlin clauses that are found during 
> the abstract syntax tree traversal. It uses _TypeRegistry_ for creating 
> qualified names.
> 
> Integration with rest of the application has had little impact.
> 
> 
> Diffs
> -
> 
>   3party-licenses/Antlr-LICENSE PRE-CREATION 
>   pom.xml 4ee2d9ec 
>   repository/pom.xml 35b74e32 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  67aeb308 
>   repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/query/Expressions.java 9e93ce41 
>   repository/src/main/java/org/apache/atlas/query/GremlinQuery.java fcb1f483 
>   repository/src/main/java/org/apache/atlas/query/GremlinTranslator.java 
> 5395ddd3 
>   repository/src/main/java/org/apache/atlas/query/QueryParser.java 1e5e5ff9 
>   repository/src/main/java/org/apache/atlas/query/QueryProcessor.java 
> 04cf0b4d 
>   repository/src/main/java/org/apache/atlas/query/SelectExpressionHelper.java 
> a8748efa 
>   repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.tokens 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java
>  PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/repository/query/QueryProcessorTest.java
>  PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64476/diff/5/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> _QueryProcessorTest_ implements the testing framework for DSL. It has 
> relevant code that setup up environment to verify various clauses implemented.
> 
> **Functional testing**
> - Verified from web UI.
> - Verified using '_Saved Search_' feature.
> 
> **Additional verification**
> Generated Gremlin queries have been verified using JanusGraph shell 
> customized for Atlas.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>



[jira] [Updated] (ATLAS-2308) Remove 'titan1' graph provider from atlas

2017-12-11 Thread Sarath Subramanian (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-2308:
--
Description: 
We have 3 graph databases in atlas:
1. titan0 (Titan 0.5.4)
2. titan1 (Titan 1.0.0)
3. janus (JanusGraph 0.2.0)

The default graph-provider is *JanusGraph* currently. I propose we remove 
'titan1' graph provider from Atlas for reasons below:

1. 'titan1' has not been tested thoroughly and have higher chances of potential 
issues.
2. We have moved on to use JanusGraph in Atlas which is an improved graph 
database forked from Titan 1 with community support and active development 
going on. 
2. TitanDB is retired, the new project JanusGraph which is now part of the 
Linux foundation has more interest and backing.

We will continue to support 'titan0' as Titan 0.5.4 has been tested and have 
wider audience within the community and also to support backward compatibility. 

  was:
We have 3 graph databases in atlas:
1. titan0 (Titan 0.5.4)
2. titan1 (Titan 1.0.0)
3. janus (JanusGraph 0.2.0)

The default graph-provider is *JanusGraph* currently. I propose we remove 
'titan1' graph provider from Atlas for reasons below:

1. 'titan1' has not been tested thoroughly and have higher chances of potential 
issues.
2. We have moved on to use JanusGraph in Atlas which is an improved graph 
database forked from Titan 1 with community support and active development 
going on. 
2. TitanDB is retired, the new project JanusGraph which is now part of the 
Linux foundation has more interest and backing.

We will continue to support 'titan0' as Titan 0.5.4 has been tested and have a 
wider audience within the community and also to support backward compatibility. 


> Remove 'titan1' graph provider from atlas
> -
>
> Key: ATLAS-2308
> URL: https://issues.apache.org/jira/browse/ATLAS-2308
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
> Fix For: 1.0.0
>
>
> We have 3 graph databases in atlas:
> 1. titan0 (Titan 0.5.4)
> 2. titan1 (Titan 1.0.0)
> 3. janus (JanusGraph 0.2.0)
> The default graph-provider is *JanusGraph* currently. I propose we remove 
> 'titan1' graph provider from Atlas for reasons below:
> 1. 'titan1' has not been tested thoroughly and have higher chances of 
> potential issues.
> 2. We have moved on to use JanusGraph in Atlas which is an improved graph 
> database forked from Titan 1 with community support and active development 
> going on. 
> 2. TitanDB is retired, the new project JanusGraph which is now part of the 
> Linux foundation has more interest and backing.
> We will continue to support 'titan0' as Titan 0.5.4 has been tested and have 
> wider audience within the community and also to support backward 
> compatibility. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Apache Atlas 1.0.0-alpha release

2017-12-11 Thread Sarath Subramanian
Madhan,

Thanks for starting the thread on 1.0.0-alpha release. I agree with David to 
remove support for titan1, I have created ATLAS-2308 for this.

It would be good to support only titan0 and janusgraph in the alpha release.

My +1 for the release.


Thanks,
Sarath Subramanian

On 12/11/17, 3:30 AM, "David Radley"  wrote:

Hi Madhan,
This isa good idea. I suggest that we also include: 
- remove titan1 support
- update the documentation in line with all the improvements so it matches 
the current deliverable.
- make the change that asset inherits from referencable. This is a change 
that might have migration implications for some people - after this 
change, types that are children of Asset but not Referenceable, now need 
to have a mandatory unique qualifiedname. 
- agree and document community statements around community support for 
BerkleyDB and the Jiras that are looking to add Cassandra support. 
-add in OCF, OMRS and OMASes. 

   all the best, David. 



From:   Nixon Rodrigues 
To: dev@atlas.apache.org
Cc: "u...@atlas.apache.org" 
Date:   11/12/2017 05:59
Subject:Re: Apache Atlas 1.0.0-alpha release



Thanks Madhan for heads-up about the upcoming release.

My +1 for the release

Regards,
Nixon

On Mon, Dec 11, 2017 at 11:00 AM, Madhan Neethiraj 
wrote:

> Atlas community,
>
>
>
> A number of improvements and fixes have gone into master branch since
> branching for Apache Atlas 0.8.x releases earlier this year. I propose 
we
> do an alpha release in next few weeks; this will enable applications 
that
> integrate with Apache Atlas to review the changes and update. Here are 
the
> highlights for this release:
>
>
>
> More than 300 commits have gone in since branching for Apache Atlas 0.8
> release.
>
>
>
> Notable features, improvements:
>
>   - ATLAS-1852, ATLAS-1892: addition of relationship as a type to Apache
> Atlas type system
>
>   - ATLAS-1757, ATLAS-2264: support for JanusGraph 0.2.0, to replace use
> of Titan
>
>   - ATLAS-2229: replaced Scala based DSL implementation with use of 
ANTLR
>
>   - ATLAS-1839: models for Glossary (Area 3)
>
>
>
> Breaking changes:
>
>   - ATLAS-2251: removed library atlas-typesystem.jar. This functionality
> is replaced by type system implementation in atlas-intg.jar
>
>  - updated atlas-notification.jar, atlas-client-v1.jar, Atlas hooks 
to
> replace use of atlas-typesystem.jar classes with equivalent classes in
> atlas-intg.jar
>
>   - ATLAS-2265, ATLAS-2292: updated Jackson library from 1.9.13 to 2.9.2
>
> - AtlasClient methods updated to replace use of JSONObject, 
JSONArray
> with JsonNode, ArrayNode
>
>   - ATLAS-1757, ATLAS-2264: with JanusGraph 0.2.0 replacing Titan-0.5.4 
as
> the graph database, existing deployments need to migrate the data
>
>   - ATLAS-2216, ATLAS-2217: removed tech-preview implementation of
> taxonomy/catalog
>
> - this will be replaced by Glossary feature in a later release
>
>
>
> Works in Progress:
>
>   - Open Metadata Framework components: Open Connector Framework, Open
> Metadata Repository Services, Open Metadata Access Services
>
>
>
> Regards,
>
> Madhan
>
>
>
>
>
>
>
>



Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU




Build failed in Jenkins: Atlas-master-IntegrationTests #216

2017-12-11 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2306: Add Area 0 0045 model and other minor model amendments

--
[...truncated 379.38 KB...]
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized 
(ServletContextHandler.java:533)
at org.eclipse.jetty.server.handler.ContextHandler.startContext 
(ContextHandler.java:816)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext 
(ServletContextHandler.java:345)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp 
(WebAppContext.java:1404)
at org.eclipse.jetty.maven.plugin.JettyWebAppContext.startWebapp 
(JettyWebAppContext.java:323)
at org.eclipse.jetty.webapp.WebAppContext.startContext 
(WebAppContext.java:1366)
at org.eclipse.jetty.server.handler.ContextHandler.doStart 
(ContextHandler.java:778)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart 
(ServletContextHandler.java:262)
at org.eclipse.jetty.webapp.WebAppContext.doStart (WebAppContext.java:520)
at org.eclipse.jetty.maven.plugin.JettyWebAppContext.doStart 
(JettyWebAppContext.java:398)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:131)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:113)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:61)
at org.eclipse.jetty.server.handler.ContextHandlerCollection.doStart 
(ContextHandlerCollection.java:161)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:131)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:113)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:61)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:131)
at org.eclipse.jetty.server.Server.start (Server.java:422)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:105)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:61)
at org.eclipse.jetty.server.Server.doStart (Server.java:389)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:68)
at org.eclipse.jetty.maven.plugin.AbstractJettyMojo.startJetty 
(AbstractJettyMojo.java:460)
at org.eclipse.jetty.maven.plugin.AbstractJettyMojo.execute 
(AbstractJettyMojo.java:328)
at org.eclipse.jetty.maven.plugin.JettyRunWarMojo.execute 
(JettyRunWarMojo.java:64)
at org.eclipse.jetty.maven.plugin.JettyDeployWar.execute 
(JettyDeployWar.java:65)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:134)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
Caused by: java.lang.ClassNotFoundException: com.sleepycat.je.LockMode
   

Build failed in Jenkins: Atlas-master-UnitTests #199

2017-12-11 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2306: Add Area 0 0045 model and other minor model amendments

--
[...truncated 17.21 KB...]
[INFO] Copying 1 resource
[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ atlas-intg 
---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 84 source files to 

[INFO] 
:
 Some input files use or override a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-intg ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 7 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
atlas-intg ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 33 source files to 

[INFO] 
:
 Some input files use or override a deprecated API.
[INFO] 
:
 Recompile with -Xlint:deprecation for details.
[INFO] 
[INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @ atlas-intg ---
[INFO] 
[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO] Running org.apache.atlas.model.typedef.TestAtlasEnumDef
[INFO] Running org.apache.atlas.model.typedef.TestAtlasClassificationDef
[INFO] Running org.apache.atlas.type.TestAtlasFloatType
[INFO] Running org.apache.atlas.model.instance.TestAtlasEntity
[INFO] Running org.apache.atlas.ApplicationPropertiesTest
[INFO] Running org.apache.atlas.model.typedef.TestAtlasStructDef
[INFO] Running org.apache.atlas.type.TestAtlasBooleanType
[INFO] Running org.apache.atlas.type.TestAtlasClassificationType
[INFO] Running org.apache.atlas.type.TestAtlasDoubleType
[INFO] Running org.apache.atlas.type.TestAtlasBigDecimalType
[INFO] Running org.apache.atlas.model.instance.TestAtlasClassification
[INFO] Running org.apache.atlas.model.typedef.TestAtlasRelationshipDef
[INFO] Running org.apache.atlas.type.TestAtlasBuiltInTypesFloatDouble
[INFO] Running org.apache.atlas.type.TestAtlasRelationshipType
[INFO] Running org.apache.atlas.type.TestAtlasShortType
[INFO] Running org.apache.atlas.model.typedef.TestAtlasEntityDef
[INFO] Running org.apache.atlas.type.TestAtlasMapType
[INFO] Running org.apache.atlas.security.InMemoryJAASConfigurationTest
[INFO] Running org.apache.atlas.type.TestAtlasLongType
[INFO] Running org.apache.atlas.type.TestAtlasArrayType
[INFO] Running org.apache.atlas.type.TestAtlasIntType
[INFO] Running org.apache.atlas.type.TestAtlasStructType
[INFO] Running 
org.apache.atlas.security.InMemoryJAASConfigurationTicketBasedKafkaClientTest
[INFO] Running org.apache.atlas.type.TestAtlasStringType
[INFO] Running org.apache.atlas.TestRelationshipUtilsV2
[INFO] Running org.apache.atlas.TestUtilsV2
[INFO] Running org.apache.atlas.type.TestAtlasTypeRegistry
[INFO] Running org.apache.atlas.type.TestAtlasByteType
[INFO] Running org.apache.atlas.type.TestAtlasBigIntegerType
[INFO] Running org.apache.atlas.type.TestAtlasObjectIdType
[INFO] Running org.apache.atlas.type.TestAtlasEntityType
[INFO] Running org.apache.atlas.type.TestAtlasDateType
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.725 s 
- in org.apache.atlas.TestRelationshipUtilsV2
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.76 s - 
in org.apache.atlas.TestUtilsV2
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.377 s 
- in org.apache.atlas.security.InMemoryJAASConfigurationTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.642 s 
- in org.apache.atlas.type.TestAtlasBooleanType
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.699 s 
- in org.apache.atlas.type.TestAtlasBuiltInTypesFloatDouble

Re: Review Request 64453: ATLAS-2306 Add Area 0 0045 model and other minor model amendments

2017-12-11 Thread Mandy Chessell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64453/#review193397
---


Ship it!




Ship It!

- Mandy Chessell


On Dec. 11, 2017, 1:16 p.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64453/
> ---
> 
> (Updated Dec. 11, 2017, 1:16 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2306 Add Area 0 0045 model and other minor model amendments
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json fcc911cb 
>   addons/models/-Area0/0030-HostsAndPlatforms_model.json 18b10392 
>   addons/models/-Area0/0040-Servers_model.json fa505be6 
>   addons/models/-Area0/0045-ServerAndAssets_model.json PRE-CREATION 
>   addons/models/-Area0/0070-NetworksAndGateways_model.json 7e415362 
>   addons/models/-Area0/0090-CloudPlatformsAndServices.json de5fb363 
> 
> 
> Diff: https://reviews.apache.org/r/64453/diff/1/
> 
> 
> Testing
> ---
> 
> Brought up atlas and issued a rest call to get the new type content.
> 
> 
> Thanks,
> 
> David Radley
> 
>



[jira] [Updated] (ATLAS-2306) Add Area 0 0045 model and other minor model amendments

2017-12-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley updated ATLAS-2306:

Attachment: ATLAS2306.patch

> Add Area 0 0045 model and other minor model amendments
> --
>
> Key: ATLAS-2306
> URL: https://issues.apache.org/jira/browse/ATLAS-2306
> Project: Atlas
>  Issue Type: Bug
>Reporter: David Radley
>Assignee: David Radley
> Attachments: ATLAS2306.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Review Request 64453: ATLAS-2306 Add Area 0 0045 model and other minor model amendments

2017-12-11 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64453/
---

Review request for atlas, Madhan Neethiraj and Mandy Chessell.


Repository: atlas


Description
---

ATLAS-2306 Add Area 0 0045 model and other minor model amendments


Diffs
-

  addons/models/-Area0/0010-base_model.json fcc911cb 
  addons/models/-Area0/0030-HostsAndPlatforms_model.json 18b10392 
  addons/models/-Area0/0040-Servers_model.json fa505be6 
  addons/models/-Area0/0045-ServerAndAssets_model.json PRE-CREATION 
  addons/models/-Area0/0070-NetworksAndGateways_model.json 7e415362 
  addons/models/-Area0/0090-CloudPlatformsAndServices.json de5fb363 


Diff: https://reviews.apache.org/r/64453/diff/1/


Testing
---

Brought up atlas and issued a rest call to get the new type content.


Thanks,

David Radley



Re: Apache Atlas 1.0.0-alpha release

2017-12-11 Thread David Radley
Hi Madhan,
This isa good idea. I suggest that we also include: 
- remove titan1 support
- update the documentation in line with all the improvements so it matches 
the current deliverable.
- make the change that asset inherits from referencable. This is a change 
that might have migration implications for some people - after this 
change, types that are children of Asset but not Referenceable, now need 
to have a mandatory unique qualifiedname. 
- agree and document community statements around community support for 
BerkleyDB and the Jiras that are looking to add Cassandra support. 
-add in OCF, OMRS and OMASes. 

   all the best, David. 



From:   Nixon Rodrigues 
To: dev@atlas.apache.org
Cc: "u...@atlas.apache.org" 
Date:   11/12/2017 05:59
Subject:Re: Apache Atlas 1.0.0-alpha release



Thanks Madhan for heads-up about the upcoming release.

My +1 for the release

Regards,
Nixon

On Mon, Dec 11, 2017 at 11:00 AM, Madhan Neethiraj 
wrote:

> Atlas community,
>
>
>
> A number of improvements and fixes have gone into master branch since
> branching for Apache Atlas 0.8.x releases earlier this year. I propose 
we
> do an alpha release in next few weeks; this will enable applications 
that
> integrate with Apache Atlas to review the changes and update. Here are 
the
> highlights for this release:
>
>
>
> More than 300 commits have gone in since branching for Apache Atlas 0.8
> release.
>
>
>
> Notable features, improvements:
>
>   - ATLAS-1852, ATLAS-1892: addition of relationship as a type to Apache
> Atlas type system
>
>   - ATLAS-1757, ATLAS-2264: support for JanusGraph 0.2.0, to replace use
> of Titan
>
>   - ATLAS-2229: replaced Scala based DSL implementation with use of 
ANTLR
>
>   - ATLAS-1839: models for Glossary (Area 3)
>
>
>
> Breaking changes:
>
>   - ATLAS-2251: removed library atlas-typesystem.jar. This functionality
> is replaced by type system implementation in atlas-intg.jar
>
>  - updated atlas-notification.jar, atlas-client-v1.jar, Atlas hooks 
to
> replace use of atlas-typesystem.jar classes with equivalent classes in
> atlas-intg.jar
>
>   - ATLAS-2265, ATLAS-2292: updated Jackson library from 1.9.13 to 2.9.2
>
> - AtlasClient methods updated to replace use of JSONObject, 
JSONArray
> with JsonNode, ArrayNode
>
>   - ATLAS-1757, ATLAS-2264: with JanusGraph 0.2.0 replacing Titan-0.5.4 
as
> the graph database, existing deployments need to migrate the data
>
>   - ATLAS-2216, ATLAS-2217: removed tech-preview implementation of
> taxonomy/catalog
>
> - this will be replaced by Glossary feature in a later release
>
>
>
> Works in Progress:
>
>   - Open Metadata Framework components: Open Connector Framework, Open
> Metadata Repository Services, Open Metadata Access Services
>
>
>
> Regards,
>
> Madhan
>
>
>
>
>
>
>
>



Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU


Re: Review Request 64442: ATLAS-2304: fix Relationship search API to work TinkerPop3

2017-12-11 Thread Graham Wallis


> On Dec. 8, 2017, 9:39 a.m., Graham Wallis wrote:
> > Just something to check... in TP3 the range() step is non-inclusive at the 
> > lower bound, i.e.
> > 
> > gremlin> g.V().range(0,3)
> > ==>v[1]
> > ==>v[2]
> > ==>v[3]
> > gremlin> g.V().range(1,3)
> > ==>v[2]
> > ==>v[3]
> > 
> > In the TP2 query, it looked like we were wanting to include the lower bound 
> > (startIdx) and exclude the upper (endIdx).
> > Are we sure we're getting the same set of vertices in both cases?
> 
> Madhan Neethiraj wrote:
> Graham - TinkerPop3 documentation says the lower-bound is inclusive while 
> the upper bound is exclusive; this is consistent with our usage. 
> http://tinkerpop.apache.org/docs/3.3.0/reference/#range-step
> 
> The number seen in "v[1]" is the vertex ID; and not the array index.

You are correct. Thanks for checking - I think the tinkerpop documentation is 
self-contradictory on this point (where it says "When within the low 
(inclusive) and high (exclusive) range, traversers are emitted. Finally, when 
above the high range, the traversal breaks out of iteration"). Hence I struggle 
to remember which way round it is. I made the same mistake on ATLAS-2242 but it 
didn't affect the result.


- Graham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64442/#review193232
---


On Dec. 8, 2017, 7:13 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64442/
> ---
> 
> (Updated Dec. 8, 2017, 7:13 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2304
> https://issues.apache.org/jira/browse/ATLAS-2304
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated AtlasGremlin3QueryProvider to provide TinkerPop3 specific expressions 
> used in relationship queries
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  85b16b44 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java
>  a55f2611 
> 
> 
> Diff: https://reviews.apache.org/r/64442/diff/1/
> 
> 
> Testing
> ---
> 
> Verified that relationship API works correctly, by viewing table list in 
> hive_db entity details page
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>