Re: [GitHub] atlas pull request #3: choose GitHub git of atlas
On 2017-12-13 14:23, geoHeilwrote: > GitHub user geoHeil opened a pull request: > > https://github.com/apache/atlas/pull/3 The atlas team use the patch process described here rather than github pull requests - https://cwiki.apache.org/confluence/display/ATLAS/Using+Git+with+Atlas I took a look at the proposed change... but 'git clone http://git.apache.org/atlas.git -b master' still works fine for me - from company network, azure & home ISP. It's also the 'definitive' repo. I'd therefore suspect you have a DNS or firewall issue in your network that is preventing connectivity? Can you get to apache git at all? Can you try from another environment? The initial docker image was primarily for developers to experiment with... there are some JIRAs open to make it more usable, and in particular post a sane version to docker hub. The discussions over build configurations put this on hold somewhat, but as we're proposing a 1.0 release I think as a community we should aim to get a version on dockerhub then... Nigel.
Re: [GitHub] atlas pull request #3: choose GitHub git of atlas
On 2017-12-13 14:23, geoHeilwrote: > GitHub user geoHeil opened a pull request: > > https://github.com/apache/atlas/pull/3 The atlas team use the patch process described here rather than github pull requests - https://cwiki.apache.org/confluence/display/ATLAS/Using+Git+with+Atlas I took a look at the proposed change... but 'git clone http://git.apache.org/atlas.git -b master' still works fine for me - from company network, azure & home ISP. It's also the 'definitive' repo. I'd therefore suspect you have a DNS or firewall issue in your network that is preventing connectivity? Can you get to apache git at all? Can you try from another environment? The initial docker image was primarily for developers to experiment with... there are some JIRAs open to make it more usable, and in particular post a sane version to docker hub. The discussions over build configurations put this on hold somewhat, but as we're proposing a 1.0 release I think as a community we should aim to get a version on dockerhub then... Nigel.
Re: [GitHub] atlas pull request #3: choose GitHub git of atlas
On 2017-12-13 14:23, geoHeilwrote: > GitHub user geoHeil opened a pull request: > > https://github.com/apache/atlas/pull/3 > Hi - The process the atlas team uses for patches is at https://cwiki.apache.org/confluence/display/ATLAS/Using+Git+with+Atlas - rather than github pull requests I did take a look at the change, but the original URL ( http://git.apache.org/atlas.git ) is the official repository, and is still working for me. . the name resolves to 54.84.58.65 for me. I can access from my company intranet, azure, and from my home ISP just fine Perhaps you have a local network restriction that's preventing access to the site - firewall or DNS lookup? I think therefore the URL should be left as is? Regards Nigel.
Re: [GitHub] atlas pull request #3: choose GitHub git of atlas
On 2017-12-13 14:23, geoHeilwrote: > GitHub user geoHeil opened a pull request: > > https://github.com/apache/atlas/pull/3 The atlas team use the patch process described here rather than github pull requests - https://cwiki.apache.org/confluence/display/ATLAS/Using+Git+with+Atlas I took a look at the proposed change... but 'git clone http://git.apache.org/atlas.git -b master' still works fine for me - from company network, azure & home ISP. It's also the 'definitive' repo. I'd therefore suspect you have a DNS or firewall issue in your network that is preventing connectivity? Can you get to apache git at all? Can you try from another environment? The initial docker image was primarily for developers to experiment with... there are some JIRAs open to make it more usable, and in particular post a sane version to docker hub. The discussions over build configurations put this on hold somewhat, but as we're proposing a 1.0 release I think as a community we should aim to get a version on dockerhub then... Nigel. [Hoping multiple replies don't get sent, having some issues with ' lists.apache.org"] On Wed, 13 Dec 2017 at 14:23 geoHeil wrote: > GitHub user geoHeil opened a pull request: > > https://github.com/apache/atlas/pull/3 > > choose GitHub git of atlas > > apache git did not download for me - switch to GitHub git > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/geoHeil/atlas dockerAtlasChangeUrl > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/atlas/pull/3.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #3 > > > commit 9bc12d4e2f223baef0f3952faa576c24e98b4cb7 > Author: geoHeil > Date: 2017-12-13T14:22:05Z > > choose GitHub git of atlas > > apache git did not download for me - switch to GitHub git > > > > > --- >
[jira] [Updated] (ATLAS-2295) UI updates for classifications
[ https://issues.apache.org/jira/browse/ATLAS-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-2295: --- Attachment: ATLAS-2295-branch-0.8-1.patch > UI updates for classifications > -- > > Key: ATLAS-2295 > URL: https://issues.apache.org/jira/browse/ATLAS-2295 > Project: Atlas > Issue Type: Improvement > Components: atlas-webui >Affects Versions: 1.0.0, 0.8.2 >Reporter: Madhan Neethiraj >Assignee: Keval Bhatt > Attachments: ATLAS-2295-branch-0.8-1.patch, > ATLAS-2295-branch-0.8.patch, ATLAS-2295-master.patch > > > Atlas UI for classification (index.html#!/tag/tagAttribute) currently lists > super-types of the classification - if the classification has any super-type. > It will be useful to list sub-types as well. > In addition, listing of classifications in a hierarchical layout, instead of > current flat listing, would make it a lot more usable. Changes introduced in > ATLAS-2283 would provide necessary details for above UI updates. > Also, ATLAS-2020 added "entityTypes" fields to classification, to specify > entity-types for which this classification can be applied to. It will be > useful to include this detail as well in classification details page. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (ATLAS-2245) Update Maven dependency in build to 3.5.0
[ https://issues.apache.org/jira/browse/ATLAS-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2245: --- Attachment: ATLAS-2245-3.patch Removed additional dependency check in graph pom > Update Maven dependency in build to 3.5.0 > - > > Key: ATLAS-2245 > URL: https://issues.apache.org/jira/browse/ATLAS-2245 > Project: Atlas > Issue Type: Improvement >Reporter: Nigel Jones >Assignee: Nigel Jones >Priority: Trivial > Attachments: ATLAS-2245-3.patch > > > The version of maven on the jenkins build was recently updated to address > some build issues. > It seems a few people have hit maven issues so I now propose we update the > main build dependency to 3.5.0 as this is currently in the top level pom as > > 3.0.4 > > and change to 3.5.0 > The very latest is 3.5.2, but since jenkins is now at 3.5.0 and is known > working, plus homebrew (mac) at least only goes as far as 3.5.0, I suggest we > go with that as a prereq. 3.5.2 will work as well > A search through the source tree shows this is the only occurance, so this is > a one file change > NOTE: There is an impact to users, who need to upgrade to maven 3.5. I will > shortly check the wiki docs and would propose an email to the mailing list > remining developers to pull the latest maven -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 63462: ATLAS-2245: Update maven dependency to 3.5.0
> On Dec. 13, 2017, 12:05 p.m., Graham Wallis wrote: > > I think it would be preferable to also update graphdb/janus/pom.xml so that > > it uses a consistent version of the enforcer plugin and specifies the same > > requiremenets for java and maven versions - preferably simply inheriting > > them from the root pom if possible. > > There should be no need to make similar changes to titan1/pomx.ml as titan1 > > is being retired by ATLAS-2308. > > Nigel Jones wrote: > I can generate another patch which removes those changes (I'd missed the > fact they'd got added given the time between this initial proposal and the > janus integration). That should be fine as we'll inherit? > > That would remove this from graphdb/janus/pom.xml - the only place I see > maven-enforcer > > > org.apache.maven.plugins > maven-enforcer-plugin > 1.4.1 > > > enforce-java-8 > > enforce > > > > > 1.8.0 > > > 3.1.0 > > > > > > I removed - though note that with my previous patch this section is redundant in any case for now as we'd already have later versions, but could trip us up when updating in future - Nigel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63462/#review193673 --- On Dec. 13, 2017, 2:11 p.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63462/ > --- > > (Updated Dec. 13, 2017, 2:11 p.m.) > > > Review request for atlas, Apoorv Naik, David Radley, Graham Wallis, Madhan > Neethiraj, and Mandy Chessell. > > > Repository: atlas > > > Description > --- > > ATLAS-2245: Update maven dependency to 3.5.0 > Also updated Java Dependency to 8 > Both are enforced in the top level POM using the maven enforcer plugin > Initial implementation used the 'dependencies' tag in the pom. However this > is deprecated, not inherited, and was primarily intended for plugins rather > than projects. > > THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. > Many users will need to update maven in particular > > > Diffs > - > > graphdb/janus/pom.xml 5fe38184 > pom.xml 3b9a464b > > > Diff: https://reviews.apache.org/r/63462/diff/5/ > > > Testing > --- > > Test with mvn clean install > > If Maven version is not 3.5.0: > [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ > apache-atlas --- > [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion > failed with message: > ** Please upgrade maven to 3.5.2 or above. See > https://maven.apache.org/install.html > > Similar for Java > > If dependencies met, build continues ok > > Proposed (in Jira) to update wiki page & send out email on dist list due to > developer impact > THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. > Many users will need to update maven in particular > > -- Update with 13 Dec patch -- > * Tested with mvn clean install > * Checked JDK 1.8/151 or 152 works, that < 151 fails, and that Java 9 > produces a warning > * Checked maven 3.5.0 or above works, earlier fails > > Also checked build environment - from build logs build server is using maven > 3.5.2 & java 1.8.0_152 > > --> > REVIEW QUESTION - I went with 3.5.0 (as Apache ranger hit bugs with 3.5.2.. > though that was only with enuciate), and java 1.8.0_151 (as I know many have > that, and it's easy to select when downloading). OK??? > --< > > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T07:58:13Z) > Maven home: /home/jenkins/tools/maven/latest > Java version: 1.8.0_152, vendor: Oracle Corporation > Java home: /usr/local/asfpackages/java/jdk1.8.0_152/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "4.4.0-43-generic", arch: "amd64", family: "unix" > + java -version > java version "1.8.0_152" > Java(TM) SE Runtime Environment (build 1.8.0_152-b16) > Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode)
[jira] [Updated] (ATLAS-2245) Update Maven dependency in build to 3.5.0
[ https://issues.apache.org/jira/browse/ATLAS-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2245: --- Attachment: (was: ATLAS-2245-1.patch) > Update Maven dependency in build to 3.5.0 > - > > Key: ATLAS-2245 > URL: https://issues.apache.org/jira/browse/ATLAS-2245 > Project: Atlas > Issue Type: Improvement >Reporter: Nigel Jones >Assignee: Nigel Jones >Priority: Trivial > Attachments: ATLAS-2245-3.patch > > > The version of maven on the jenkins build was recently updated to address > some build issues. > It seems a few people have hit maven issues so I now propose we update the > main build dependency to 3.5.0 as this is currently in the top level pom as > > 3.0.4 > > and change to 3.5.0 > The very latest is 3.5.2, but since jenkins is now at 3.5.0 and is known > working, plus homebrew (mac) at least only goes as far as 3.5.0, I suggest we > go with that as a prereq. 3.5.2 will work as well > A search through the source tree shows this is the only occurance, so this is > a one file change > NOTE: There is an impact to users, who need to upgrade to maven 3.5. I will > shortly check the wiki docs and would propose an email to the mailing list > remining developers to pull the latest maven -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 63462: ATLAS-2245: Update maven dependency to 3.5.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63462/ --- (Updated Dec. 13, 2017, 2:11 p.m.) Review request for atlas, Apoorv Naik, David Radley, Graham Wallis, Madhan Neethiraj, and Mandy Chessell. Changes --- Removing maven-enforcer check in janus module as recommended by graham. (Top level pom should be effective, and I think preferable as we stop the build quickly) Repository: atlas Description --- ATLAS-2245: Update maven dependency to 3.5.0 Also updated Java Dependency to 8 Both are enforced in the top level POM using the maven enforcer plugin Initial implementation used the 'dependencies' tag in the pom. However this is deprecated, not inherited, and was primarily intended for plugins rather than projects. THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. Many users will need to update maven in particular Diffs (updated) - graphdb/janus/pom.xml 5fe38184 pom.xml 3b9a464b Diff: https://reviews.apache.org/r/63462/diff/5/ Changes: https://reviews.apache.org/r/63462/diff/4-5/ Testing --- Test with mvn clean install If Maven version is not 3.5.0: [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ apache-atlas --- [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message: ** Please upgrade maven to 3.5.2 or above. See https://maven.apache.org/install.html Similar for Java If dependencies met, build continues ok Proposed (in Jira) to update wiki page & send out email on dist list due to developer impact THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. Many users will need to update maven in particular -- Update with 13 Dec patch -- * Tested with mvn clean install * Checked JDK 1.8/151 or 152 works, that < 151 fails, and that Java 9 produces a warning * Checked maven 3.5.0 or above works, earlier fails Also checked build environment - from build logs build server is using maven 3.5.2 & java 1.8.0_152 --> REVIEW QUESTION - I went with 3.5.0 (as Apache ranger hit bugs with 3.5.2.. though that was only with enuciate), and java 1.8.0_151 (as I know many have that, and it's easy to select when downloading). OK??? --< Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=1024m; support was removed in 8.0 Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Maven home: /home/jenkins/tools/maven/latest Java version: 1.8.0_152, vendor: Oracle Corporation Java home: /usr/local/asfpackages/java/jdk1.8.0_152/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.4.0-43-generic", arch: "amd64", family: "unix" + java -version java version "1.8.0_152" Java(TM) SE Runtime Environment (build 1.8.0_152-b16) Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode) Example of failure errors: [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ apache-atlas --- [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireJavaVersion failed with message: ** JAVA VERSION ERROR ** Java 8 (b151) or above is required. or [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ apache-atlas --- [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message: ** MAVEN VERSION ERROR ** Maven 3.5.0 or above is required. See https://maven.apache.org/install.html [WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireJavaVersion warned with message: ** JAVA VERSION WARNING ** Java 9 and above has not been tested with Atlas. Thanks, Nigel Jones
Re: Review Request 63462: ATLAS-2245: Update maven dependency to 3.5.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63462/#review193673 --- I think it would be preferable to also update graphdb/janus/pom.xml so that it uses a consistent version of the enforcer plugin and specifies the same requiremenets for java and maven versions - preferably simply inheriting them from the root pom if possible. There should be no need to make similar changes to titan1/pomx.ml as titan1 is being retired by ATLAS-2308. - Graham Wallis On Dec. 13, 2017, 11:25 a.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63462/ > --- > > (Updated Dec. 13, 2017, 11:25 a.m.) > > > Review request for atlas, Apoorv Naik, David Radley, Graham Wallis, Madhan > Neethiraj, and Mandy Chessell. > > > Repository: atlas > > > Description > --- > > ATLAS-2245: Update maven dependency to 3.5.0 > Also updated Java Dependency to 8 > Both are enforced in the top level POM using the maven enforcer plugin > Initial implementation used the 'dependencies' tag in the pom. However this > is deprecated, not inherited, and was primarily intended for plugins rather > than projects. > > THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. > Many users will need to update maven in particular > > > Diffs > - > > pom.xml 3b9a464b > > > Diff: https://reviews.apache.org/r/63462/diff/4/ > > > Testing > --- > > Test with mvn clean install > > If Maven version is not 3.5.0: > [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ > apache-atlas --- > [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion > failed with message: > ** Please upgrade maven to 3.5.2 or above. See > https://maven.apache.org/install.html > > Similar for Java > > If dependencies met, build continues ok > > Proposed (in Jira) to update wiki page & send out email on dist list due to > developer impact > THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. > Many users will need to update maven in particular > > -- Update with 13 Dec patch -- > * Tested with mvn clean install > * Checked JDK 1.8/151 or 152 works, that < 151 fails, and that Java 9 > produces a warning > * Checked maven 3.5.0 or above works, earlier fails > > Also checked build environment - from build logs build server is using maven > 3.5.2 & java 1.8.0_152 > > --> > REVIEW QUESTION - I went with 3.5.0 (as Apache ranger hit bugs with 3.5.2.. > though that was only with enuciate), and java 1.8.0_151 (as I know many have > that, and it's easy to select when downloading). OK??? > --< > > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=1024m; > support was removed in 8.0 > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T07:58:13Z) > Maven home: /home/jenkins/tools/maven/latest > Java version: 1.8.0_152, vendor: Oracle Corporation > Java home: /usr/local/asfpackages/java/jdk1.8.0_152/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "4.4.0-43-generic", arch: "amd64", family: "unix" > + java -version > java version "1.8.0_152" > Java(TM) SE Runtime Environment (build 1.8.0_152-b16) > Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode) > > Example of failure errors: > > [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ > apache-atlas --- > [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireJavaVersion failed > with message: > ** JAVA VERSION ERROR ** Java 8 (b151) or above is required. > > > or > > [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ > apache-atlas --- > [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion > failed with message: > ** MAVEN VERSION ERROR ** Maven 3.5.0 or above is required. See > https://maven.apache.org/install.html > [WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireJavaVersion warned > with message: > ** JAVA VERSION WARNING ** Java 9 and above has not been tested with Atlas. > > > Thanks, > > Nigel Jones > >
Re: Review Request 63462: ATLAS-2245: Update maven dependency to 3.5.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63462/ --- (Updated Dec. 13, 2017, 11:25 a.m.) Review request for atlas, Apoorv Naik, David Radley, Graham Wallis, Madhan Neethiraj, and Mandy Chessell. Repository: atlas Description --- ATLAS-2245: Update maven dependency to 3.5.0 Also updated Java Dependency to 8 Both are enforced in the top level POM using the maven enforcer plugin Initial implementation used the 'dependencies' tag in the pom. However this is deprecated, not inherited, and was primarily intended for plugins rather than projects. THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. Many users will need to update maven in particular Diffs - pom.xml 3b9a464b Diff: https://reviews.apache.org/r/63462/diff/4/ Testing (updated) --- Test with mvn clean install If Maven version is not 3.5.0: [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ apache-atlas --- [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message: ** Please upgrade maven to 3.5.2 or above. See https://maven.apache.org/install.html Similar for Java If dependencies met, build continues ok Proposed (in Jira) to update wiki page & send out email on dist list due to developer impact THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. Many users will need to update maven in particular -- Update with 13 Dec patch -- * Tested with mvn clean install * Checked JDK 1.8/151 or 152 works, that < 151 fails, and that Java 9 produces a warning * Checked maven 3.5.0 or above works, earlier fails Also checked build environment - from build logs build server is using maven 3.5.2 & java 1.8.0_152 --> REVIEW QUESTION - I went with 3.5.0 (as Apache ranger hit bugs with 3.5.2.. though that was only with enuciate), and java 1.8.0_151 (as I know many have that, and it's easy to select when downloading). OK??? --< Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=1024m; support was removed in 8.0 Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Maven home: /home/jenkins/tools/maven/latest Java version: 1.8.0_152, vendor: Oracle Corporation Java home: /usr/local/asfpackages/java/jdk1.8.0_152/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.4.0-43-generic", arch: "amd64", family: "unix" + java -version java version "1.8.0_152" Java(TM) SE Runtime Environment (build 1.8.0_152-b16) Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode) Example of failure errors: [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ apache-atlas --- [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireJavaVersion failed with message: ** JAVA VERSION ERROR ** Java 8 (b151) or above is required. or [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ apache-atlas --- [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message: ** MAVEN VERSION ERROR ** Maven 3.5.0 or above is required. See https://maven.apache.org/install.html [WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireJavaVersion warned with message: ** JAVA VERSION WARNING ** Java 9 and above has not been tested with Atlas. Thanks, Nigel Jones