[jira] [Commented] (ATLAS-3995) Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214428#comment-17214428
 ] 

ASF subversion and git services commented on ATLAS-3995:


Commit fd24e652b5e2f607cad0d665c88d770479832263 in atlas's branch 
refs/heads/master from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=fd24e65 ]

ATLAS-3995 : Atlas should support additional keystore/truststores types besides 
JKS.


> Atlas should support additional keystore/truststores types besides JKS
> --
>
> Key: ATLAS-3995
> URL: https://issues.apache.org/jira/browse/ATLAS-3995
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>
> Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
> types. There are additional keystore/truststore types used for different 
> applications like for FIPS crypto algorithms.
> Atlas server should support the default keystore type specified for the JDK 
> and have option to configure other keystore/truststore  types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72893: ATLAS-3427: Hook Enhancements for Improved Resiliency

2020-10-14 Thread Ashutosh Mestry via Review Board 


> On Oct. 12, 2020, 7:21 a.m., Madhan Neethiraj wrote:
> > notification/src/main/java/org/apache/atlas/notification/LogConfigUtils.java
> > Lines 48 (patched)
> > 
> >
> > Atlas log4j configuration is likely to have multiple appenders to file 
> > - FILE, LARGE_FILE, AUDIT, METRICS, FAILED, perf_appender.
> > 
> > To be consistent/predictable, I suggest to look for appender named 
> > "FILE".

Any approach to infer log directory is not yielding predictable results. The 
cluster manager chages the appenders. In some cases redactors are applied, 
others are replaced with ConsoleAppenders.

The approach above works predictably only with Hive and Atlas.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72893/#review222012
---


On Oct. 6, 2020, 5:47 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72893/
> ---
> 
> (Updated Oct. 6, 2020, 5:47 p.m.)
> 
> 
> Review request for atlas, Deep Singh, Madhan Neethiraj, mayank jain, Nikhil 
> Bonte, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3427
> https://issues.apache.org/jira/browse/ATLAS-3427
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> (Internal review) 
> **Description**
> Integration: _AtlasHook_ receives enhanced _NotificationInterface_ in the 
> form of _AtlasFileSpool_. This capability can be optionally set using: 
> _atlas.hook.spool.dir_ configuration property.
> 
> _AtlasFileSpool_: Enhances default hook functionality by encapsulating the 
> default _NotificationInterface_ with file spooling capability. In case of 
> destination being unavailable, the messages received will be spooled to local 
> file system.
> 
> What is spool?
> - These are files containg data (messages in this specific case).
> 
> Files on the disk that are managed using index files. Index files have 
> special structure that is used to describe the spool files. 
> 
> Who generates spool files?
> _AtlasHook_ is base class from which all hooks. It is responsible for sending 
> messages to a destination (mostly Kafka). If destination is down, an 
> exception is raised by the destination. Before the implementation, the 
> message was logged after retry. With this implementation, the message will be 
> spooled, and when the destination is up, it is sent to the destination.
> 
> How are spool file stored?
> - Spool files and index files are store on disk in local file system.
> 
> Structure of _AtlasFileSpool_:
> - _IndexManagement_: Storage and retrieval of index files. Provides Spooler 
> (see below) with _PrintWriter_ to write messages to the disk.
> - _Spooler_: 
>   - Interacts with _IndexManagement_ to receive _PrintWriter_. 
>   - Serializes messages and writes to the spool file. 
> - _Publisher_: 
>   - Interacts with _IndexManagement_ to receive _IndexRecord_ that is ready 
> to be published.
>   - Reads messages from the spool file that is described in the _IndexRecord_ 
> and attempts to send it to the destination.
>   - If destination is down, it waits for destination to be up.
> - _SpoolConfiguration_: Stores configuration specific to the implementation.
> - _SpoolUtils_: Utility methods for file storage.
> 
> 
> **Impacted Areas**
> Hooks:
> - Hive: HS2
> - Hive: HMS
> - Impala.
> - HBase.
> - Spark.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 651323490 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveMetastoreHookImpl.java
>  3c0f0c106 
>   notification/pom.xml 8affd59a2 
>   notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 8659126eb 
>   notification/src/main/java/org/apache/atlas/hook/FailedMessagesLogger.java 
> b319e81b8 
>   notification/src/main/java/org/apache/atlas/kafka/NotificationProvider.java 
> 2dd970ef7 
>   
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java
>  45a66bf07 
>   
> notification/src/main/java/org/apache/atlas/notification/LogConfigUtils.java 
> PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationException.java
>  2dd9c9fa0 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
>  6caf7e2d5 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/Archiver.java 
> PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/AtlasFileSpool.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/FileOperations.java
>  PRE-CREATION 
>   
>

Re: Review Request 72962: ATLAS-3995 :- Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72962/#review222055
---


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 14, 2020, 4:39 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72962/
> ---
> 
> (Updated Oct. 14, 2020, 4:39 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
> Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
> types. There are additional keystore/truststore types used for different 
> applications like for FIPS crypto algorithms.
> 
> Atlas server should support the default keystore type specified for the JDK 
> and have option to configure other keystore/truststore  types.
> 
> This patch makes its configurable to add other keystore/truststore types via 
> atlas-application.properties.
> 
> keystore.type=bcfks
> truststore.type=bcfks
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
> 2e953eb02 
>   webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
> 34086aed8 
> 
> 
> Diff: https://reviews.apache.org/r/72962/diff/2/
> 
> 
> Testing
> ---
> 
> Tested Atlas with bcfks type keystores.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 72962: ATLAS-3995 :- Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72962/#review222053
---


Ship it!




Ship It!

- Sarath Subramanian


On Oct. 14, 2020, 9:39 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72962/
> ---
> 
> (Updated Oct. 14, 2020, 9:39 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
> Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
> types. There are additional keystore/truststore types used for different 
> applications like for FIPS crypto algorithms.
> 
> Atlas server should support the default keystore type specified for the JDK 
> and have option to configure other keystore/truststore  types.
> 
> This patch makes its configurable to add other keystore/truststore types via 
> atlas-application.properties.
> 
> keystore.type=bcfks
> truststore.type=bcfks
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
> 2e953eb02 
>   webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
> 34086aed8 
> 
> 
> Diff: https://reviews.apache.org/r/72962/diff/2/
> 
> 
> Testing
> ---
> 
> Tested Atlas with bcfks type keystores.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 72962: ATLAS-3995 :- Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72962/
---

(Updated Oct. 14, 2020, 4:39 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Changes
---

addressed review comment from Madhan


Repository: atlas


Description
---

Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
types. There are additional keystore/truststore types used for different 
applications like for FIPS crypto algorithms.

Atlas server should support the default keystore type specified for the JDK and 
have option to configure other keystore/truststore  types.

This patch makes its configurable to add other keystore/truststore types via 
atlas-application.properties.

keystore.type=bcfks
truststore.type=bcfks


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
2e953eb02 
  webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
34086aed8 


Diff: https://reviews.apache.org/r/72962/diff/2/

Changes: https://reviews.apache.org/r/72962/diff/1-2/


Testing
---

Tested Atlas with bcfks type keystores.


Thanks,

Nixon Rodrigues

Re: Review Request 72960: ATLAS-3994 : import-hive.sh script fails when missing mandatory attribute value is null

2020-10-14 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72960/#review222050
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Lines 385 (patched)


Is empty string an acceptable value for mandatory attribute 
ATTRIBUTE_USER_NAME? If not, consider reading default username from config - 
like:

  String defaultUserName = 
config.getString("atlas.hook.hive.default.username, "hive");


- Madhan Neethiraj


On Oct. 14, 2020, 10:35 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72960/
> ---
> 
> (Updated Oct. 14, 2020, 10:35 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3994
> https://issues.apache.org/jira/browse/ATLAS-3994
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 06:33:41.409 [main] ERROR org.apache.atlas.hive.bridge.HiveMetaStoreBridge - 
> Import failed for hive_table tobedeleted__wallet
> org.apache.atlas.AtlasServiceException: Metadata service API 
> org.apache.atlas.AtlasClientV2$API_V2@17f2dd85 failed with status 404 (Not 
> Found) Response Body (
> 
> {"errorCode":"ATLAS-404-00-007","errorMessage":"Invalid instance 
> creation/updation parameters passed : hive_process.userName: mandatory 
> attribute value missing in type hive_process"}
> 
> )
> 
> This patch adds the null check for "owner" to fix the bug.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  24e06dc2b 
> 
> 
> Diff: https://reviews.apache.org/r/72960/diff/1/
> 
> 
> Testing
> ---
> 
> Tested import hive script for db, tables
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 72962: ATLAS-3995 :- Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72962/#review222048
---


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java
Lines 106 (patched)


Consider replacing "JKS" with the constant defined above - 
ATLAS_KEYSTORE_FILE_TYPE_DEFAULT.



webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java
Lines 111 (patched)


Consider replacing "JKS" with the constant defined above - 
ATLAS_TRUSTSTORE_FILE_TYPE_DEFAULT.



webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java
Line 201 (original), 205 (patched)


Consider replacing "JKS" with existing constant - 
ATLAS_KEYSTORE_FILE_TYPE_DEFAULT.



webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java
Line 254 (original), 258 (patched)


Consider replacing "JKS" with existing constant - 
ATLAS_TRUSTSTORE_FILE_TYPE_DEFAULT.


- Madhan Neethiraj


On Oct. 14, 2020, 1:21 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72962/
> ---
> 
> (Updated Oct. 14, 2020, 1:21 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
> Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
> types. There are additional keystore/truststore types used for different 
> applications like for FIPS crypto algorithms.
> 
> Atlas server should support the default keystore type specified for the JDK 
> and have option to configure other keystore/truststore  types.
> 
> This patch makes its configurable to add other keystore/truststore types via 
> atlas-application.properties.
> 
> keystore.type=bcfks
> truststore.type=bcfks
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
> 2e953eb02 
>   webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
> 34086aed8 
> 
> 
> Diff: https://reviews.apache.org/r/72962/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Atlas with bcfks type keystores.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

[jira] [Updated] (ATLAS-3943) UI: Show Import/Export operations in administration audit.

2020-10-14 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3943:
---
Attachment: ATLAS-3943-3.patch

> UI: Show Import/Export operations in administration audit.
> --
>
> Key: ATLAS-3943
> URL: https://issues.apache.org/jira/browse/ATLAS-3943
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3943-1.patch, ATLAS-3943-2.patch, 
> ATLAS-3943-3.patch, ATLAS-3943.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3986) UI Allow user to update the date format from JAVA property file

2020-10-14 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213968#comment-17213968
 ] 

ASF subversion and git services commented on ATLAS-3986:


Commit 3768c9dcd33eb045c834a8e6cebe4703ab0d933d in atlas's branch 
refs/heads/branch-2.0 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3768c9d ]

ATLAS-3986: UI Allow user to update the date format from JAVA property file

(cherry picked from commit 39892854ffb696df70ecbc0f3e965c5a8261f621)


> UI Allow user to update the date format from JAVA property file
> ---
>
> Key: ATLAS-3986
> URL: https://issues.apache.org/jira/browse/ATLAS-3986
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 2.1.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3986.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (ATLAS-3986) UI Allow user to update the date format from JAVA property file

2020-10-14 Thread Mandar Ambawane (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213966#comment-17213966
 ] 

Mandar Ambawane edited comment on ATLAS-3986 at 10/14/20, 2:40 PM:
---

+1 for the patch


was (Author: mandar_va):
+1

> UI Allow user to update the date format from JAVA property file
> ---
>
> Key: ATLAS-3986
> URL: https://issues.apache.org/jira/browse/ATLAS-3986
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 2.1.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3986.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3986) UI Allow user to update the date format from JAVA property file

2020-10-14 Thread Mandar Ambawane (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213966#comment-17213966
 ] 

Mandar Ambawane commented on ATLAS-3986:


+1

> UI Allow user to update the date format from JAVA property file
> ---
>
> Key: ATLAS-3986
> URL: https://issues.apache.org/jira/browse/ATLAS-3986
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 2.1.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3986.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3986) UI Allow user to update the date format from JAVA property file

2020-10-14 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213967#comment-17213967
 ] 

ASF subversion and git services commented on ATLAS-3986:


Commit 39892854ffb696df70ecbc0f3e965c5a8261f621 in atlas's branch 
refs/heads/master from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3989285 ]

ATLAS-3986: UI Allow user to update the date format from JAVA property file


> UI Allow user to update the date format from JAVA property file
> ---
>
> Key: ATLAS-3986
> URL: https://issues.apache.org/jira/browse/ATLAS-3986
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 2.1.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3986.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3986) UI Allow user to update the date format from JAVA property file

2020-10-14 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3986:
---
Attachment: ATLAS-3986.patch

> UI Allow user to update the date format from JAVA property file
> ---
>
> Key: ATLAS-3986
> URL: https://issues.apache.org/jira/browse/ATLAS-3986
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3986.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 72962: ATLAS-3995 :- Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72962/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Repository: atlas


Description
---

Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
types. There are additional keystore/truststore types used for different 
applications like for FIPS crypto algorithms.

Atlas server should support the default keystore type specified for the JDK and 
have option to configure other keystore/truststore  types.

This patch makes its configurable to add other keystore/truststore types via 
atlas-application.properties.

keystore.type=bcfks
truststore.type=bcfks


Diffs
-

  intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
2e953eb02 
  webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
34086aed8 


Diff: https://reviews.apache.org/r/72962/diff/1/


Testing
---

Tested Atlas with bcfks type keystores.


Thanks,

Nixon Rodrigues

[jira] [Commented] (ATLAS-3990) UI: When user clicks to view hive-table details, shown some wrong tabs

2020-10-14 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213868#comment-17213868
 ] 

ASF subversion and git services commented on ATLAS-3990:


Commit d5db1a67cd5bb8adc357c465dedcd043429fc771 in atlas's branch 
refs/heads/branch-2.0 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d5db1a6 ]

ATLAS-3990: UI: When user clicks to view hive-table details, shown some wrong 
tabs


> UI: When user clicks to view hive-table details, shown some wrong tabs
> --
>
> Key: ATLAS-3990
> URL: https://issues.apache.org/jira/browse/ATLAS-3990
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3990.patch, wrong_tabs_showing_on_clicks.mkv
>
>
> Steps to reproduce::
>  # Have a hive_db with at least one table
>  # Click on 'Tables' tab
>  # Click on one of the tables listed in the tab
>  # The page renders the table details, including addition of 'Schema' tab
>  # However, 'Tables' tab is still visible; this tab needs to be hidden
>  # Also, on clicking the db link in Properties page of hive_table, 'Schema' 
> tab is still visible. This should be hidden
> PFA evidence file attached - wrong_tabs_showing_on_clicks.mkv



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3990) UI: When user clicks to view hive-table details, shown some wrong tabs

2020-10-14 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213866#comment-17213866
 ] 

ASF subversion and git services commented on ATLAS-3990:


Commit 94d43c63c6021450845ff17c5bd952dbf5f8958a in atlas's branch 
refs/heads/master from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=94d43c6 ]

ATLAS-3990: UI: When user clicks to view hive-table details, shown some wrong 
tabs


> UI: When user clicks to view hive-table details, shown some wrong tabs
> --
>
> Key: ATLAS-3990
> URL: https://issues.apache.org/jira/browse/ATLAS-3990
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3990.patch, wrong_tabs_showing_on_clicks.mkv
>
>
> Steps to reproduce::
>  # Have a hive_db with at least one table
>  # Click on 'Tables' tab
>  # Click on one of the tables listed in the tab
>  # The page renders the table details, including addition of 'Schema' tab
>  # However, 'Tables' tab is still visible; this tab needs to be hidden
>  # Also, on clicking the db link in Properties page of hive_table, 'Schema' 
> tab is still visible. This should be hidden
> PFA evidence file attached - wrong_tabs_showing_on_clicks.mkv



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3990) UI: When user clicks to view hive-table details, shown some wrong tabs

2020-10-14 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3990:
---
Affects Version/s: 2.1.0

> UI: When user clicks to view hive-table details, shown some wrong tabs
> --
>
> Key: ATLAS-3990
> URL: https://issues.apache.org/jira/browse/ATLAS-3990
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3990.patch, wrong_tabs_showing_on_clicks.mkv
>
>
> Steps to reproduce::
>  # Have a hive_db with at least one table
>  # Click on 'Tables' tab
>  # Click on one of the tables listed in the tab
>  # The page renders the table details, including addition of 'Schema' tab
>  # However, 'Tables' tab is still visible; this tab needs to be hidden
>  # Also, on clicking the db link in Properties page of hive_table, 'Schema' 
> tab is still visible. This should be hidden
> PFA evidence file attached - wrong_tabs_showing_on_clicks.mkv



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3990) UI: When user clicks to view hive-table details, shown some wrong tabs

2020-10-14 Thread Nixon Rodrigues (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213862#comment-17213862
 ] 

Nixon Rodrigues commented on ATLAS-3990:


+1 for the patch. Thanks [~kevalbhatt]

> UI: When user clicks to view hive-table details, shown some wrong tabs
> --
>
> Key: ATLAS-3990
> URL: https://issues.apache.org/jira/browse/ATLAS-3990
> Project: Atlas
>  Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Major
> Attachments: ATLAS-3990.patch, wrong_tabs_showing_on_clicks.mkv
>
>
> Steps to reproduce::
>  # Have a hive_db with at least one table
>  # Click on 'Tables' tab
>  # Click on one of the tables listed in the tab
>  # The page renders the table details, including addition of 'Schema' tab
>  # However, 'Tables' tab is still visible; this tab needs to be hidden
>  # Also, on clicking the db link in Properties page of hive_table, 'Schema' 
> tab is still visible. This should be hidden
> PFA evidence file attached - wrong_tabs_showing_on_clicks.mkv



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3990) UI: When user clicks to view hive-table details, shown some wrong tabs

2020-10-14 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3990:
---
Fix Version/s: 2.2.0
   3.0.0

> UI: When user clicks to view hive-table details, shown some wrong tabs
> --
>
> Key: ATLAS-3990
> URL: https://issues.apache.org/jira/browse/ATLAS-3990
> Project: Atlas
>  Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3990.patch, wrong_tabs_showing_on_clicks.mkv
>
>
> Steps to reproduce::
>  # Have a hive_db with at least one table
>  # Click on 'Tables' tab
>  # Click on one of the tables listed in the tab
>  # The page renders the table details, including addition of 'Schema' tab
>  # However, 'Tables' tab is still visible; this tab needs to be hidden
>  # Also, on clicking the db link in Properties page of hive_table, 'Schema' 
> tab is still visible. This should be hidden
> PFA evidence file attached - wrong_tabs_showing_on_clicks.mkv



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3990) UI: When user clicks to view hive-table details, shown some wrong tabs

2020-10-14 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3990:
---
Attachment: ATLAS-3990.patch

> UI: When user clicks to view hive-table details, shown some wrong tabs
> --
>
> Key: ATLAS-3990
> URL: https://issues.apache.org/jira/browse/ATLAS-3990
> Project: Atlas
>  Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Major
> Attachments: ATLAS-3990.patch, wrong_tabs_showing_on_clicks.mkv
>
>
> Steps to reproduce::
>  # Have a hive_db with at least one table
>  # Click on 'Tables' tab
>  # Click on one of the tables listed in the tab
>  # The page renders the table details, including addition of 'Schema' tab
>  # However, 'Tables' tab is still visible; this tab needs to be hidden
>  # Also, on clicking the db link in Properties page of hive_table, 'Schema' 
> tab is still visible. This should be hidden
> PFA evidence file attached - wrong_tabs_showing_on_clicks.mkv



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-3995) Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Nixon Rodrigues (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues reassigned ATLAS-3995:
--

Assignee: Nixon Rodrigues

> Atlas should support additional keystore/truststores types besides JKS
> --
>
> Key: ATLAS-3995
> URL: https://issues.apache.org/jira/browse/ATLAS-3995
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>
> Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
> types. There are additional keystore/truststore types used for different 
> applications like for FIPS crypto algorithms.
> Atlas server should support the default keystore type specified for the JDK 
> and have option to configure other keystore/truststore  types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3995) Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Nixon Rodrigues (Jira) 
Nixon Rodrigues created ATLAS-3995:
--

 Summary: Atlas should support additional keystore/truststores 
types besides JKS
 Key: ATLAS-3995
 URL: https://issues.apache.org/jira/browse/ATLAS-3995
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
types. There are additional keystore/truststore types used for different 
applications like for FIPS crypto algorithms.

Atlas server should support the default keystore type specified for the JDK and 
have option to configure other keystore/truststore  types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72960: ATLAS-3994 : import-hive.sh script fails when missing mandatory attribute value is null

2020-10-14 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72960/
---

(Updated Oct. 14, 2020, 10:35 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3994
https://issues.apache.org/jira/browse/ATLAS-3994


Repository: atlas


Description
---

06:33:41.409 [main] ERROR org.apache.atlas.hive.bridge.HiveMetaStoreBridge - 
Import failed for hive_table tobedeleted__wallet
org.apache.atlas.AtlasServiceException: Metadata service API 
org.apache.atlas.AtlasClientV2$API_V2@17f2dd85 failed with status 404 (Not 
Found) Response Body (

{"errorCode":"ATLAS-404-00-007","errorMessage":"Invalid instance 
creation/updation parameters passed : hive_process.userName: mandatory 
attribute value missing in type hive_process"}

)

This patch adds the null check for "owner" to fix the bug.


Diffs
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 24e06dc2b 


Diff: https://reviews.apache.org/r/72960/diff/1/


Testing (updated)
---

Tested import hive script for db, tables


Thanks,

chaitali

[jira] [Created] (ATLAS-3994) import-hive.sh script fails when missing mandatory attribute value is null

2020-10-14 Thread chaitali borole (Jira) 
chaitali borole created ATLAS-3994:
--

 Summary: import-hive.sh script fails when missing mandatory 
attribute value is null
 Key: ATLAS-3994
 URL: https://issues.apache.org/jira/browse/ATLAS-3994
 Project: Atlas
  Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: chaitali borole
Assignee: chaitali borole
 Fix For: 3.0.0


06:33:41.409 [main] ERROR org.apache.atlas.hive.bridge.HiveMetaStoreBridge - 
Import failed for hive_table tobedeleted__wallet
org.apache.atlas.AtlasServiceException: Metadata service API 
org.apache.atlas.AtlasClientV2$API_V2@17f2dd85 failed with status 404 (Not 
Found) Response Body ({"errorCode":"ATLAS-404-00-007","errorMessage":"Invalid 
instance creation/updation parameters passed : hive_process.userName: mandatory 
attribute value missing in type hive_process"})



--
This message was sent by Atlassian Jira
(v8.3.4#803005)