[jira] [Updated] (ATLAS-4179) [Atlas: Glossary Term Bulk Import] Incorrect error message when only dependent term is not present in bulk import

2021-02-25 Thread Dharshana M Krishnamoorthy (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4179:
--
Priority: Minor  (was: Major)

> [Atlas: Glossary Term Bulk Import] Incorrect error message when only 
> dependent term is not present in bulk import
> -
>
> Key: ATLAS-4179
> URL: https://issues.apache.org/jira/browse/ATLAS-4179
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Minor
> Attachments: Screenshot 2021-02-26 at 1.10.32 AM.png
>
>
> {code:java}
> glossary_rb,term_1,"short description","long description", "Example", "G1", 
> "Usage",,"gloss_1:term_2"{code}
> Consider the above input, say *gloss_1* is present but term *term_2* is not 
> present, error message conveys, that both glossary and term are not present
> Error message:
> {code:java}
> {"errorCode":"ATLAS-500-00-001",
> "errorMessage":"The uploaded file has not been processed due to the following 
> errors : \n[\nThe provided Reference Glossary and TermName does not exist in 
> the system term_2:gloss_1 for record with TermName  : term_1 and GlossaryName 
> : glossary_rb]"}{code}
> !Screenshot 2021-02-26 at 1.10.32 AM.png|width=606,height=247!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4179) [Atlas: Glossary Term Bulk Import] Incorrect error message when only dependent term is not present in bulk import

2021-02-25 Thread Dharshana M Krishnamoorthy (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4179:
--
Description: 
{code:java}
glossary_rb,term_1,"short description","long description", "Example", "G1", 
"Usage",,"gloss_1:term_2"{code}
Consider the above input, say *gloss_1* is present but term *term_2* is not 
present, error message conveys, that both glossary and term are not present

Error message:
{code:java}
{"errorCode":"ATLAS-500-00-001",
"errorMessage":"The uploaded file has not been processed due to the following 
errors : \n[\nThe provided Reference Glossary and TermName does not exist in 
the system term_2:gloss_1 for record with TermName  : term_1 and GlossaryName : 
glossary_rb]"}{code}
!Screenshot 2021-02-26 at 1.10.32 AM.png|width=606,height=247!

  was:
{code:java}
glossary_aaa,term_1,"short description","long description", "Example", "G1", 
"Usage",,"gloss_1:term_a"{code}
Consider the above input, say *gloss_1* is present but term *term_a* is not 
present, error message conveys, that both glossary and term are not present

Error message:
{code:java}
{"errorCode":"ATLAS-500-00-001","errorMessage":"The uploaded file has not been 
processed due to the following errors : \n[\nThe provided Reference Glossary 
and TermName does not exist in the system term_a:gloss_1 for record with 
TermName : term_1 and GlossaryName : glossary_aaa]"} {code}
!Screenshot 2021-02-26 at 1.10.32 AM.png|width=606,height=247!


> [Atlas: Glossary Term Bulk Import] Incorrect error message when only 
> dependent term is not present in bulk import
> -
>
> Key: ATLAS-4179
> URL: https://issues.apache.org/jira/browse/ATLAS-4179
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
> Attachments: Screenshot 2021-02-26 at 1.10.32 AM.png
>
>
> {code:java}
> glossary_rb,term_1,"short description","long description", "Example", "G1", 
> "Usage",,"gloss_1:term_2"{code}
> Consider the above input, say *gloss_1* is present but term *term_2* is not 
> present, error message conveys, that both glossary and term are not present
> Error message:
> {code:java}
> {"errorCode":"ATLAS-500-00-001",
> "errorMessage":"The uploaded file has not been processed due to the following 
> errors : \n[\nThe provided Reference Glossary and TermName does not exist in 
> the system term_2:gloss_1 for record with TermName  : term_1 and GlossaryName 
> : glossary_rb]"}{code}
> !Screenshot 2021-02-26 at 1.10.32 AM.png|width=606,height=247!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4179) [Atlas: Glossary Term Bulk Import] Incorrect error message when only dependent term is not present in bulk import

2021-02-25 Thread Dharshana M Krishnamoorthy (Jira)
Dharshana M Krishnamoorthy created ATLAS-4179:
-

 Summary: [Atlas: Glossary Term Bulk Import] Incorrect error 
message when only dependent term is not present in bulk import
 Key: ATLAS-4179
 URL: https://issues.apache.org/jira/browse/ATLAS-4179
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Dharshana M Krishnamoorthy
 Attachments: Screenshot 2021-02-26 at 1.10.32 AM.png

{code:java}
glossary_aaa,term_1,"short description","long description", "Example", "G1", 
"Usage",,"gloss_1:term_a"{code}
Consider the above input, say *gloss_1* is present but term *term_a* is not 
present, error message conveys, that both glossary and term are not present

Error message:
{code:java}
{"errorCode":"ATLAS-500-00-001","errorMessage":"The uploaded file has not been 
processed due to the following errors : \n[\nThe provided Reference Glossary 
and TermName does not exist in the system term_a:gloss_1 for record with 
TermName : term_1 and GlossaryName : glossary_aaa]"} {code}
!Screenshot 2021-02-26 at 1.10.32 AM.png|width=606,height=247!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73076: Deferred Actions Implementation

2021-02-25 Thread Ashutosh Mestry via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73076/
---

(Updated Feb. 26, 2021, 6:08 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, Nixon 
Rodrigues, and Sarath Subramanian.


Changes
---

Updates include: 
- Addressed failing Basic Search tests due to new fields.


Bugs: ATLAS-3919
https://issues.apache.org/jira/browse/ATLAS-3919


Repository: atlas


Description
---

**Approach**
Model: _TaskDef_
- Definition of task.
- Contains status of the task for querying.

_AbstractTask_
- Takes TaskDef as input and calls run.
- The concrete tasks has logic for doing real work.

_TaskFactory_

- Creates tasks given task type.
- Enumerates all the tasks that are supported.

_TaskManagement_

- Component/Service. Constructed after all existing components are constructed.
- Provides a simple interface for adding tasks.
- Processes tasks that are in pending state.
- Supports HA mode, where the tasks are not executed on passive instance.

_TaskManagement.Registry_

- CRUD operations with TaskDef vertex.

_TaskManagement.Processor_
- Provides mechanism for provides single queue for processing tasks in a way 
that is non-blocking.
- Uses task type and the associated TaskFactory to construct concrete task.

Changes to _EntityGraphMapper_
There are 3 new methods added that use portion of existing classification 
propagation logic and create a separate method.

New class _EntityGraphMapperWithTasks_ acts as a proxy for EntityGraphMapper. 
All calls that operate without tasks get channeled to the existing 
implementation. The ones involving tasks are modified to use the new task 
framework.

**Concurrent Changes to Classifications**
Via REST APIs and operations from web UI, it is possible to make changes to the 
same entity. This situation will be more pronounced in the new setup.

The existing framework has 
_GraphTransactionInterceptor.lockObjectAndReleasePostCommit_. This provides 
ReentrantLock on an entity that is identified by the supplied GUID. This will 
cause a lock on the entity and all the impacted vertices. This has potential 
for adversely impacting scalability.

**REST APIs**
+-++--+--+
| api/admin/tasks   | GET  |  guids   |  (optional) List of guids to be 
fetched. |
|   |  |  | If list of guids supplied is empty all 
tasks |
|   |  |  | that are in PENDING state are fetched. 
If list   |
|   |  |  | guids is specified, tasks corresponding 
to that guid are fetched.|
+---+--+--+--+
|api/admin/task |DELETE| guids| List of guids to be deleted. No action 
is taken if list of guids |
|   |  |  | supplied is empty or a Task guid does 
not exist. |
+---+--+--+--+

**New Updates**
- Separate log file for tasks.
- TaskDef now has _startTime_ and _endTime_ to indicating start and end of task.
- Refactored parameter passing during task creation. It now accepts Map instead 
of Object array. Each task creates its own set of parameters.
- Reduced use of TASKS_ENABLE flag checks.
- Added _AtlasEntity.getPendingTasks()_ that indicidate presence of tasks for a 
given entity.


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 61abfcaca 
  distro/src/conf/atlas-log4j.xml 7df963eb2 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 4d8c94894 
  intg/src/main/java/org/apache/atlas/model/tasks/AtlasTask.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 27c7f7391 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4c7f8c681 
  intg/src/main/java/org/apache/atlas/type/Constants.java 7ee852086 
  intg/src/test/resources/atlas-application.properties 7e74d5107 
  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
86b369fc9 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 d0ffb853f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 2cfcc0bc1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 8208d11c2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationPropagateTaskFactory.java
 PRE-CREATION 
  

[jira] [Assigned] (ATLAS-4178) [UI] Save and Cancel buttons do not disappear after closing their respective sections in Entity Details page

2021-02-25 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar reassigned ATLAS-4178:
--

Assignee: Prasad P. Pawar

> [UI] Save and Cancel buttons do not disappear after closing their respective 
> sections in Entity Details page
> 
>
> Key: ATLAS-4178
> URL: https://issues.apache.org/jira/browse/ATLAS-4178
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: save_cancel_entity_details_page.webm
>
>
> Steps:
> 1. Open any section like "User Defined Properties", "Labels" and "Business 
> Metadata"
> 2. Click on Add button
> 3.Save and Cancel button should show up 
> 4. Close the section 
> You will see the Save and Cancel buttons still remains on the page, and in 
> certain browser resolutions appear to be misaligned with other elements of 
> the page. The whole process can be seen in the attached video. They remain on 
> the page and are clickable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4178) [UI] Save and Cancel buttons do not disappear after closing their respective sections in Entity Details page

2021-02-25 Thread Rahul Kurup (Jira)
Rahul Kurup created ATLAS-4178:
--

 Summary: [UI] Save and Cancel buttons do not disappear after 
closing their respective sections in Entity Details page
 Key: ATLAS-4178
 URL: https://issues.apache.org/jira/browse/ATLAS-4178
 Project: Atlas
  Issue Type: Bug
Reporter: Rahul Kurup
 Attachments: save_cancel_entity_details_page.webm

Steps:

1. Open any section like "User Defined Properties", "Labels" and "Business 
Metadata"

2. Click on Add button

3.Save and Cancel button should show up 

4. Close the section 

You will see the Save and Cancel buttons still remains on the page, and in 
certain browser resolutions appear to be misaligned with other elements of the 
page. The whole process can be seen in the attached video. They remain on the 
page and are clickable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4177) [Atlas: Glossary Term Bulk Import] While importing large file of size 5 mb request did not complete even after an hour

2021-02-25 Thread Dharshana M Krishnamoorthy (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4177:
--
Description: 
While performing Bulk import via api, the request takes more than an hour for 5 
mb file

!Screenshot 2021-02-25 at 11.49.01 PM.png|width=753,height=285!

The request took more than an hour and the request was not complete

  was:
While performing Bulk import via api, the request takes more than an hour for 5 
mb file

!Screenshot 2021-02-25 at 11.49.01 PM.png|width=753,height=285!

The request took more than an hour and 


> [Atlas: Glossary Term Bulk Import] While importing large file of size 5 mb 
> request did not complete even after an hour
> --
>
> Key: ATLAS-4177
> URL: https://issues.apache.org/jira/browse/ATLAS-4177
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
> Attachments: Screenshot 2021-02-25 at 11.49.01 PM.png
>
>
> While performing Bulk import via api, the request takes more than an hour for 
> 5 mb file
> !Screenshot 2021-02-25 at 11.49.01 PM.png|width=753,height=285!
> The request took more than an hour and the request was not complete



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4177) [Atlas: Glossary Term Bulk Import] While importing large file of size 5 mb request did not complete even after an hour

2021-02-25 Thread Dharshana M Krishnamoorthy (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4177:
--
Summary: [Atlas: Glossary Term Bulk Import] While importing large file of 
size 5 mb request did not complete even after an hour  (was: [Atlas: Glossary 
Term Bulk Import] While up)

> [Atlas: Glossary Term Bulk Import] While importing large file of size 5 mb 
> request did not complete even after an hour
> --
>
> Key: ATLAS-4177
> URL: https://issues.apache.org/jira/browse/ATLAS-4177
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
> Attachments: Screenshot 2021-02-25 at 11.49.01 PM.png
>
>
> While performing Bulk import via api, the request takes more than an hour for 
> 5 mb file
> !Screenshot 2021-02-25 at 11.49.01 PM.png|width=753,height=285!
> The request took more than an hour and 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4177) [Atlas: Glossary Term Bulk Import] While up

2021-02-25 Thread Dharshana M Krishnamoorthy (Jira)
Dharshana M Krishnamoorthy created ATLAS-4177:
-

 Summary: [Atlas: Glossary Term Bulk Import] While up
 Key: ATLAS-4177
 URL: https://issues.apache.org/jira/browse/ATLAS-4177
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Dharshana M Krishnamoorthy
 Attachments: Screenshot 2021-02-25 at 11.49.01 PM.png

While performing Bulk import via api, the request takes more than an hour for 5 
mb file

!Screenshot 2021-02-25 at 11.49.01 PM.png|width=753,height=285!

The request took more than an hour and 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4176) [Atlas: Read type auth] When un-authorised user creates a sub type, incorrect error message is thrown

2021-02-25 Thread Dharshana M Krishnamoorthy (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4176:
--
Summary: [Atlas: Read type auth] When un-authorised user creates a sub 
type, incorrect error message is thrown   (was: [Atlas: Read type auth] When 
un-authorised user creates a sub type, in correct error message is thrown )

> [Atlas: Read type auth] When un-authorised user creates a sub type, incorrect 
> error message is thrown 
> --
>
> Key: ATLAS-4176
> URL: https://issues.apache.org/jira/browse/ATLAS-4176
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
>
> *hrt_20* is an *unauthorised_user*
> When hrt_20 tries to create an entity_type *sub_entity_1* with super_type as 
> "*entity_1*" the following is thrown
> {code:java}
> hrt_20 is not authorized to perform create entity-def sub_entity_1 {code}
> Expectation:
> {code:java}
> hrt_20 is not authorized to perform read type-def of category ENTITY entity_1 
> {code}
>  
> NOTE:
> This happens only for entity type and not for classification.
> When creating a classification *sub_class_1* with super_type as *class_1* the 
> following exception is thrown, which is correct
> {code:java}
> hrt_20 is not authorized to perform read type-def of category CLASSIFICATION 
> class_1 {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4176) [Atlas: Read type auth] When un-authorised user creates a sub type, in correct error message is thrown

2021-02-25 Thread Dharshana M Krishnamoorthy (Jira)
Dharshana M Krishnamoorthy created ATLAS-4176:
-

 Summary: [Atlas: Read type auth] When un-authorised user creates a 
sub type, in correct error message is thrown 
 Key: ATLAS-4176
 URL: https://issues.apache.org/jira/browse/ATLAS-4176
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Dharshana M Krishnamoorthy


*hrt_20* is an *unauthorised_user*

When hrt_20 tries to create an entity_type *sub_entity_1* with super_type as 
"*entity_1*" the following is thrown
{code:java}
hrt_20 is not authorized to perform create entity-def sub_entity_1 {code}
Expectation:
{code:java}
hrt_20 is not authorized to perform read type-def of category ENTITY entity_1 
{code}
 

NOTE:

This happens only for entity type and not for classification.

When creating a classification *sub_class_1* with super_type as *class_1* the 
following exception is thrown, which is correct
{code:java}
hrt_20 is not authorized to perform read type-def of category CLASSIFICATION 
class_1 {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-4175) [Atlas: Read type auth] [Regression]: User is able to create a sub-type with non-readable super type

2021-02-25 Thread chaitali borole (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole reassigned ATLAS-4175:
--

Assignee: chaitali borole

> [Atlas: Read type auth] [Regression]: User is able to create a sub-type with 
> non-readable super type
> 
>
> Key: ATLAS-4175
> URL: https://issues.apache.org/jira/browse/ATLAS-4175
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: chaitali borole
>Priority: Major
>
> hrt_qa doesn't have read permission on classification : PII
> hrt_qa has CRUD permission on classification : Confidential
> When hrt_qa tries to create a classification `Confidential` with super type 
> as `PII` , expectation is to deny creation . But tag creation is successful 
> and has the super tag `PII`
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4175) [Atlas: Read type auth] [Regression]: User is able to create a sub-type with non-readable super type

2021-02-25 Thread Dharshana M Krishnamoorthy (Jira)
Dharshana M Krishnamoorthy created ATLAS-4175:
-

 Summary: [Atlas: Read type auth] [Regression]: User is able to 
create a sub-type with non-readable super type
 Key: ATLAS-4175
 URL: https://issues.apache.org/jira/browse/ATLAS-4175
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Dharshana M Krishnamoorthy


hrt_qa doesn't have read permission on classification : PII

hrt_qa has CRUD permission on classification : Confidential

When hrt_qa tries to create a classification `Confidential` with super type as 
`PII` , expectation is to deny creation . But tag creation is successful and 
has the super tag `PII`

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)