Re: Review Request 73445: ATLAS-4350: Atlas - Jetty Version disclosure in http response
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73445/#review223205 --- Ship it! Ship It! - Nixon Rodrigues On July 8, 2021, 10:52 p.m., Sidharth Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73445/ > --- > > (Updated July 8, 2021, 10:52 p.m.) > > > Review request for atlas, Ashutosh Mestry, Radhika Kundam, and Sarath > Subramanian. > > > Bugs: ATLAS-4350 > https://issues.apache.org/jira/browse/ATLAS-4350 > > > Repository: atlas > > > Description > --- > > ATLAS-4350: Atlas - Jetty Version disclosure in http response > > > Diffs > - > > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java > 61aa3134c > webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java > 7a045749f > > > Diff: https://reviews.apache.org/r/73445/diff/1/ > > > Testing > --- > > Manually tested and confirmed that the version is not present as part for > response header: > > Before Change - > > Response Header: > > HTTP/1.1 200 OK > Date: Thu, 08 Jul 2021 22:49:45 GMT > Last-Modified: Tue, 06 Jul 2021 12:06:15 GMT > Content-Type: text/css > Accept-Ranges: bytes > Content-Length: 53485 > Server: Jetty(9.4.39.v20210325) > > After Change - > > > Response Header: > > HTTP/1.1 200 OK > Date: Thu, 08 Jul 2021 22:47:57 GMT > Last-Modified: Wed, 07 Jul 2021 16:51:30 GMT > Content-Type: text/css > Accept-Ranges: bytes > Content-Length: 53485 > > > Thanks, > > Sidharth Mishra > >
Re: Review Request 73445: ATLAS-4350: Atlas - Jetty Version disclosure in http response
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73445/#review223204 --- Ship it! Ship It! - Sarath Subramanian On July 8, 2021, 3:52 p.m., Sidharth Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73445/ > --- > > (Updated July 8, 2021, 3:52 p.m.) > > > Review request for atlas, Ashutosh Mestry, Radhika Kundam, and Sarath > Subramanian. > > > Bugs: ATLAS-4350 > https://issues.apache.org/jira/browse/ATLAS-4350 > > > Repository: atlas > > > Description > --- > > ATLAS-4350: Atlas - Jetty Version disclosure in http response > > > Diffs > - > > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java > 61aa3134c > webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java > 7a045749f > > > Diff: https://reviews.apache.org/r/73445/diff/1/ > > > Testing > --- > > Manually tested and confirmed that the version is not present as part for > response header: > > Before Change - > > Response Header: > > HTTP/1.1 200 OK > Date: Thu, 08 Jul 2021 22:49:45 GMT > Last-Modified: Tue, 06 Jul 2021 12:06:15 GMT > Content-Type: text/css > Accept-Ranges: bytes > Content-Length: 53485 > Server: Jetty(9.4.39.v20210325) > > After Change - > > > Response Header: > > HTTP/1.1 200 OK > Date: Thu, 08 Jul 2021 22:47:57 GMT > Last-Modified: Wed, 07 Jul 2021 16:51:30 GMT > Content-Type: text/css > Accept-Ranges: bytes > Content-Length: 53485 > > > Thanks, > > Sidharth Mishra > >
Re: Review Request 73445: ATLAS-4350: Atlas - Jetty Version disclosure in http response
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73445/ --- (Updated July 8, 2021, 10:52 p.m.) Review request for atlas, Ashutosh Mestry, Radhika Kundam, and Sarath Subramanian. Bugs: ATLAS-4350 https://issues.apache.org/jira/browse/ATLAS-4350 Repository: atlas Description --- ATLAS-4350: Atlas - Jetty Version disclosure in http response Diffs - webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 61aa3134c webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 7a045749f Diff: https://reviews.apache.org/r/73445/diff/1/ Testing (updated) --- Manually tested and confirmed that the version is not present as part for response header: Before Change - Response Header: HTTP/1.1 200 OK Date: Thu, 08 Jul 2021 22:49:45 GMT Last-Modified: Tue, 06 Jul 2021 12:06:15 GMT Content-Type: text/css Accept-Ranges: bytes Content-Length: 53485 Server: Jetty(9.4.39.v20210325) After Change - Response Header: HTTP/1.1 200 OK Date: Thu, 08 Jul 2021 22:47:57 GMT Last-Modified: Wed, 07 Jul 2021 16:51:30 GMT Content-Type: text/css Accept-Ranges: bytes Content-Length: 53485 Thanks, Sidharth Mishra
Re: Review Request 73445: ATLAS-4350: Atlas - Jetty Version disclosure in http response
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73445/#review223202 --- Ship it! For completeness, can you please add HTTP header before/after the change. - Ashutosh Mestry On July 8, 2021, 10:36 p.m., Sidharth Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73445/ > --- > > (Updated July 8, 2021, 10:36 p.m.) > > > Review request for atlas, Ashutosh Mestry, Radhika Kundam, and Sarath > Subramanian. > > > Bugs: ATLAS-4350 > https://issues.apache.org/jira/browse/ATLAS-4350 > > > Repository: atlas > > > Description > --- > > ATLAS-4350: Atlas - Jetty Version disclosure in http response > > > Diffs > - > > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java > 61aa3134c > webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java > 7a045749f > > > Diff: https://reviews.apache.org/r/73445/diff/1/ > > > Testing > --- > > Manually tested and confirmed that the version is not present as part for > response header > > > Thanks, > > Sidharth Mishra > >
Review Request 73445: ATLAS-4350: Atlas - Jetty Version disclosure in http response
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73445/ --- Review request for atlas, Ashutosh Mestry, Radhika Kundam, and Sarath Subramanian. Bugs: ATLAS-4350 https://issues.apache.org/jira/browse/ATLAS-4350 Repository: atlas Description --- ATLAS-4350: Atlas - Jetty Version disclosure in http response Diffs - webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 61aa3134c webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 7a045749f Diff: https://reviews.apache.org/r/73445/diff/1/ Testing --- Manually tested and confirmed that the version is not present as part for response header Thanks, Sidharth Mishra
[jira] [Created] (ATLAS-4350) Atlas - Jetty Version disclosure in http response
Sidharth Kumar Mishra created ATLAS-4350:
Summary: Atlas - Jetty Version disclosure in http response
Key: ATLAS-4350
URL: https://issues.apache.org/jira/browse/ATLAS-4350
Project: Atlas
Issue Type: Bug
Reporter: Sidharth Kumar Mishra
Assignee: Sidharth Kumar Mishra
Atlas reveals netty version in http response
{code:java}
GET
https://atlas.host:8443/gateway/cdp-proxy/atlas/js/utils/Overrides.js?bust=1601951148602
{code}
{code:java}
HTTP/1.1 200 OK
Connection: close
Date: Wed, 03 Feb 2021 14:24:28 GMT
Connection: close
Last-Modified: Tue, 06 Oct 2020 04:13:55 GMT Content-Type:
application/javascript Accept-Ranges: bytes
Server: Jetty(9.4.26.v20200117)
Content-Length: 8186
{code}
*Recommendation:* Remove the version information from the http response
header.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Review Request 73442: ATLAS-4150 Remove System Internal Entity Types from Metrics GET api
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73442/ --- Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-4150 https://issues.apache.org/jira/browse/ATLAS-4150 Repository: atlas Description --- This patch checks all the Super Types of an Entity Type. If any of the Super Types is __internal Then it will not allow that Entity Type in Metrics api response. Diffs - repository/src/main/java/org/apache/atlas/services/MetricsService.java e721108d3 repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java bea8eb8b5 Diff: https://reviews.apache.org/r/73442/diff/1/ Testing --- Thanks, Mandar Ambawane
[jira] [Assigned] (ATLAS-4150) UI : __AtlasAuditEntry appearing in metrics window
[ https://issues.apache.org/jira/browse/ATLAS-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandar Ambawane reassigned ATLAS-4150: -- Assignee: Mandar Ambawane > UI : __AtlasAuditEntry appearing in metrics window > -- > > Key: ATLAS-4150 > URL: https://issues.apache.org/jira/browse/ATLAS-4150 > Project: Atlas > Issue Type: Bug >Reporter: Rahul Kurup >Assignee: Mandar Ambawane >Priority: Minor > Attachments: Screenshot from 2021-02-09 10-38-46.png > > > !Screenshot from 2021-02-09 10-38-46.png|width=584,height=432! > As seen in the above screenshot, entries for AtlasAuditEntry are visible. > That is an system internal entity and should ideally not be visible in the > metrics UI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4349) no lineage in hive views
[ https://issues.apache.org/jira/browse/ATLAS-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377239#comment-17377239 ] t oo commented on ATLAS-4349: - cc [~nixon] [~prasadpp13] [~sarath] [~mandar_va] [~nareshpr] > no lineage in hive views > > > Key: ATLAS-4349 > URL: https://issues.apache.org/jira/browse/ATLAS-4349 > Project: Atlas > Issue Type: Bug >Affects Versions: 1.1.0 >Reporter: t oo >Priority: Major > > i ran import-hive.sh and it imported entities, but no lineage. > > below says it does not support? > [https://community.cloudera.com/t5/Support-Questions/I-run-the-script-tool-import-hive-sh-and-i-can-search-the/td-p/175545] > > how to get lineage of hive views? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-4349) no lineage in hive views
t oo created ATLAS-4349: --- Summary: no lineage in hive views Key: ATLAS-4349 URL: https://issues.apache.org/jira/browse/ATLAS-4349 Project: Atlas Issue Type: Bug Affects Versions: 1.1.0 Reporter: t oo i ran import-hive.sh and it imported entities, but no lineage. below says it does not support? [https://community.cloudera.com/t5/Support-Questions/I-run-the-script-tool-import-hive-sh-and-i-can-search-the/td-p/175545] how to get lineage of hive views? -- This message was sent by Atlassian Jira (v8.3.4#803005)
