Re: Review Request 73467: ATLAS-4363:Integration tests for Apache Atlas Client in Python

2021-08-09 Thread Shraddha Pardeshi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73467/
---

(Updated Aug. 10, 2021, 5:52 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Nixon Rodrigues.


Bugs: ATLAS-4363
https://issues.apache.org/jira/browse/ATLAS-4363


Repository: atlas


Description
---

Add test coverage for Apache Atlas Client in Python.

This tests can be integrated in build process.


Diffs
-

  intg/src/test/python/Base.py PRE-CREATION 
  intg/src/test/python/test_admin.py PRE-CREATION 
  intg/src/test/python/test_discovery.py PRE-CREATION 
  intg/src/test/python/test_entity.py PRE-CREATION 
  intg/src/test/python/test_glossary.py PRE-CREATION 
  intg/src/test/python/test_lineage.py PRE-CREATION 
  intg/src/test/python/test_relationship.py PRE-CREATION 
  intg/src/test/python/test_typedef.py PRE-CREATION 
  webapp/pom.xml ccbcc3141 


Diff: https://reviews.apache.org/r/73467/diff/1/


Testing (updated)
---

Completed "mvn clean install" run on local set up

PC: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/lastCompletedBuild/console


Thanks,

Shraddha Pardeshi

Re: Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

2021-08-09 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73502/#review223327
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 5, 2021, 7:16 a.m., Shraddha Pardeshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73502/
> ---
> 
> (Updated Aug. 5, 2021, 7:16 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
> Pinal Shah.
> 
> 
> Bugs: ATLAS-3917
> https://issues.apache.org/jira/browse/ATLAS-3917
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> -Actual Behaviour : While deleting parent tag if the tag is not associated 
> with any entity shows this message- "Given type {0} has reference."
> -Expected Result: There should be tag name instead of {0}
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  b9d41bbba 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
>  3242a33ad 
> 
> 
> Diff: https://reviews.apache.org/r/73502/diff/2/
> 
> 
> Testing
> ---
> 
> -Manual testing done on local server
> 
> -Test case added.
> 
> PC - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>

[VOTE] Release Apache Atlas version 2.2.0 - rc1

2021-08-09 Thread Sidharth Mishra 
Atlas team,

Apache Atlas 2.2.0 rc1, with the following fixes since rc0, is now
available for vote within the dev community.

ATLAS-4390 - Changed Atlas branch to release-2.2.0-rc1
ATLAS-4391 - NoSuchFileException for {atlas.log.dir}/atlas-metrics.out
ATLAS-4343 - [Entity Audits] 'Propagated Classification Added'
Timestamp is < 'Entity
Created' Timestamp
ATLAS-4387 - UI: Propagated Classifications shows wrong count for
entity type on Entity   detail
page
ATLAS-4386 - Relationship search: Sorting does not work when
relationship label is passed

Links to the release artifacts are given below. Please review and vote.

The vote will be open for at least 72 hours or until necessary votes
are reached.

  [ ] +1 Approve

  [ ] +0 No opinion

  [ ] -1 Disapprove (and reason why)

Thanks,
Sid

List of all issues addressed in this release:
https://issues.apache.org/jira/issues/?jql=project%3DATLAS%20AND%20status%3DResolved%20AND%20fixVersion%3D2.2.0%20ORDER%20BY%20key%20DESC

Git tag for the release: https://github.com/apache/atlas/tree/release-2.2.0-rc1

Sources for the release:
https://dist.apache.org/repos/dist/dev/atlas/2.2.0-rc1/apache-atlas-2.2.0-sources.tar.gz

Source release verification:

  PGP Signature:
https://dist.apache.org/repos/dist/dev/atlas/2.2.0-rc1/apache-atlas-2.2.0-sources.tar.gz.asc

  SHA512 Hash:
https://dist.apache.org/repos/dist/dev/atlas/2.2.0-rc1/apache-atlas-2.2.0-sources.tar.gz.sha512

  MD5 Hash:
https://dist.apache.org/repos/dist/dev/atlas/2.2.0-rc1/apache-atlas-2.2.0-sources.tar.gz.md5


Keys to verify the signature of the release artifacts are available
at: https://dist.apache.org/repos/dist/release/atlas/KEYS


New features/enhancements:

 - Introduced Deferred Action - Tag propagation will be handled as
a background process (AtlasTask)

- Added Re-indexing as JAVA_PATCH

- Created JavaPatch to add new super types to existing entities

- Supported for Business Metadata in Atlas Export API

- Supported HA for admin/task API

- Enhanced export service to export Terms

- Added new models and addition attributes to Atlas for Apache
Flink, GCP and ADLS Gen 2

- Added support to Configure HiveServer2 Hook to send Lineage-only Messages

- Improved and enhanced Bulk Glossary Import supporting import
with relations

- Dependency between Atlas and Kafka Zookeeper removed

- Improved performance of GraphHelper's guid and status getter methods

- Added new privilege - "admin-audits" for Atlas Admin Audits authorization

- Basic search Improvements - search text with special characters,
optimize pagination

- Updated free-text search processor to support Elasticsearch

- Refactored and enhanced Atlas Python Client supporting Python 2.7

- DSL Search enhancements - Support glossary terms and
relationship, can handle null attribute values, Java Tinkerpop
Traversals instead of GremlinScriptEngine, support search by
classification and its attribute, Caching mechanism for translated dsl
queries

- Enhanced Export/Import Service to conditionally Support
Simultaneous Operations

- Enhanced NotificationHookConsumer for Large Message Processing

- Enhanced Atlas authorization for Add/Update/Remove
classification on entities

- Provided option to add mandatory attribute to existing entity definition

- Fixed Atlas UI to load faster in case of large number of
classifications & entities

- Updated versions of dependent libraries/components: JanusGraph,
elasticsearch, JQuery, Http core, Http Client, slf4j, log4j, ant,
gremlin, Solr, groovy, netty, Kafka

[jira] [Commented] (ATLAS-4390) Change the Atlas branch at dev-support/atlas-docker/.env

2021-08-09 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396301#comment-17396301
 ] 

ASF subversion and git services commented on ATLAS-4390:


Commit 1a4735939f3ec3ed225f1d12e40653b8eaf610b3 in atlas's branch 
refs/heads/branch-2.0 from sidmishra
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=1a47359 ]

ATLAS-4390: Changed Atlas branch to release-2.2.0-rc1

Signed-off-by: sidmishra 


> Change the Atlas branch at dev-support/atlas-docker/.env 
> -
>
> Key: ATLAS-4390
> URL: https://issues.apache.org/jira/browse/ATLAS-4390
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Attachments: 
> ATLAS-4390-Changed-Atlas-branch-to-release-2.2.0-rc1.patch
>
>
> Update the Atlas branch at dev-support/atlas-docker/.env  to 
> release-2.2.0-rc1 so that docker build would use Atlas sources from this tag



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4391) NoSuchFileException for ${atlas.log.dir}/atlas-metrics.out

2021-08-09 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396300#comment-17396300
 ] 

ASF subversion and git services commented on ATLAS-4391:


Commit b5929eb56d06c7838bdda738e32b97db05b50a07 in atlas's branch 
refs/heads/branch-2.0 from mayanknj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b5929eb ]

ATLAS-4391 - NoSuchFileException for {atlas.log.dir}/atlas-metrics.out

Signed-off-by: sidmishra 
(cherry picked from commit 98b7118c1034c98ee403ab6083dc3c9670df5d1f)


> NoSuchFileException for ${atlas.log.dir}/atlas-metrics.out 
> ---
>
> Key: ATLAS-4391
> URL: https://issues.apache.org/jira/browse/ATLAS-4391
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Mayank Jain
>Priority: Critical
> Attachments: ATLAS-4391-1.patch
>
>
> Atlas startup logs NoSuchFileException for ${atlas.log.dir}/atlas-metrics.out:
> 2021-08-05 07:54:07,353 WARN  - [main:] ~ Error creating sink 
> 'atlas-debug-metrics-context' (MetricsSystemImpl:508)
> org.apache.hadoop.metrics2.impl.MetricsConfigException: Error creating 
> plugin: org.apache.hadoop.metrics2.sink.FileSink
>         at 
> org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:210)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:531)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configureSinks(MetricsSystemImpl.java:503)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:479)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
>         at 
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)
>         at 
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)
>         at 
> org.apache.atlas.web.service.DebugMetricsWrapper.init(DebugMetricsWrapper.java:43)
> ...
>         at 
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
>         at 
> org.apache.atlas.web.service.EmbeddedServer.start(EmbeddedServer.java:110)
>         at org.apache.atlas.Atlas.main(Atlas.java:133)
> Caused by: org.apache.hadoop.metrics2.MetricsException: Error creating 
> ${atlas.log.dir}/atlas-metrics.out
>         at org.apache.hadoop.metrics2.sink.FileSink.init(FileSink.java:53)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:207)
>         ... 63 more
> Caused by: java.nio.file.NoSuchFileException: 
> ${atlas.log.dir}/atlas-metrics.out
>         at 
> sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
>         at 
> sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
>         at 
> sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
>         at 
> sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
>         at 
> java.nio.file.spi.FileSystemProvider.newOutputStream(FileSystemProvider.java:434)
>         at java.nio.file.Files.newOutputStream(Files.java:216)
>         at org.apache.hadoop.metrics2.sink.FileSink.init(FileSink.java:50)
>         ... 64 more



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4391) NoSuchFileException for ${atlas.log.dir}/atlas-metrics.out

2021-08-09 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396298#comment-17396298
 ] 

ASF subversion and git services commented on ATLAS-4391:


Commit 98b7118c1034c98ee403ab6083dc3c9670df5d1f in atlas's branch 
refs/heads/master from mayanknj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=98b7118 ]

ATLAS-4391 - NoSuchFileException for {atlas.log.dir}/atlas-metrics.out

Signed-off-by: sidmishra 


> NoSuchFileException for ${atlas.log.dir}/atlas-metrics.out 
> ---
>
> Key: ATLAS-4391
> URL: https://issues.apache.org/jira/browse/ATLAS-4391
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Mayank Jain
>Priority: Critical
> Attachments: ATLAS-4391-1.patch
>
>
> Atlas startup logs NoSuchFileException for ${atlas.log.dir}/atlas-metrics.out:
> 2021-08-05 07:54:07,353 WARN  - [main:] ~ Error creating sink 
> 'atlas-debug-metrics-context' (MetricsSystemImpl:508)
> org.apache.hadoop.metrics2.impl.MetricsConfigException: Error creating 
> plugin: org.apache.hadoop.metrics2.sink.FileSink
>         at 
> org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:210)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:531)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configureSinks(MetricsSystemImpl.java:503)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:479)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
>         at 
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)
>         at 
> org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)
>         at 
> org.apache.atlas.web.service.DebugMetricsWrapper.init(DebugMetricsWrapper.java:43)
> ...
>         at 
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
>         at 
> org.apache.atlas.web.service.EmbeddedServer.start(EmbeddedServer.java:110)
>         at org.apache.atlas.Atlas.main(Atlas.java:133)
> Caused by: org.apache.hadoop.metrics2.MetricsException: Error creating 
> ${atlas.log.dir}/atlas-metrics.out
>         at org.apache.hadoop.metrics2.sink.FileSink.init(FileSink.java:53)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:207)
>         ... 63 more
> Caused by: java.nio.file.NoSuchFileException: 
> ${atlas.log.dir}/atlas-metrics.out
>         at 
> sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
>         at 
> sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
>         at 
> sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
>         at 
> sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
>         at 
> java.nio.file.spi.FileSystemProvider.newOutputStream(FileSystemProvider.java:434)
>         at java.nio.file.Files.newOutputStream(Files.java:216)
>         at org.apache.hadoop.metrics2.sink.FileSink.init(FileSink.java:50)
>         ... 64 more



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4343) [Entity Audits] 'Propagated Classification Added' Timestamp is < 'Entity Created' Timestamp

2021-08-09 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396270#comment-17396270
 ] 

ASF subversion and git services commented on ATLAS-4343:


Commit 62fdd911cf2f29e1f540403c036a7b493c025503 in atlas's branch 
refs/heads/branch-2.0 from Radhika Kundam
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=62fdd91 ]

ATLAS-4343:[Entity Audits] 'Propagated Classification Added' Timestamp is < 
'Entity Created' Timestamp

Signed-off-by: sidmishra 
(cherry picked from commit 8edec03affcc9881a3d55f0f3cf9893829bed3bd)


> [Entity Audits] 'Propagated Classification Added' Timestamp is < 'Entity 
> Created' Timestamp
> ---
>
> Key: ATLAS-4343
> URL: https://issues.apache.org/jira/browse/ATLAS-4343
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Umesh Padashetty
>Assignee: Mandar Ambawane
>Priority: Major
>
> The 'Propagated Classification Added' Timestamp is < 'Entity Created' 
> Timestamp. This is invalid since the classificiation is propagated once the 
> entity is created 
> For instance
>  # Created an external table with ozone path location
>  # This creates ozone_key and hive_table entity
>  # Entity Created TImestamp is shown correctly for both the entities
>  # Applied a tag to ozone_key with propagate classification set to true
>  # Classification propagates to hive_table entity, but the Timestamp shown is 
> in past
>  # For ozone_key:
>  ## Entity created: 06/24/2021 08:44:33 PM (IST)
>  ## Classification added:  06/24/2021 08:44:51 PM (IST)
>  # Whereas hive_table:
>  ## Entity created: 06/24/2021 08:44:33 PM (IST)
>  ## Propagated Classification Added: 06/24/2021 *08:37:06 PM* (IST)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4387) UI: Propagated Classifications shows wrong count for entity type on Entity detail page.

2021-08-09 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396269#comment-17396269
 ] 

ASF subversion and git services commented on ATLAS-4387:


Commit 024106faada51a21756204c735be9f93cdddbde2 in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=024106f ]

ATLAS-4387:UI: Propagated Classifications shows wrong count for entity type on 
Entity detail page, fixed

Signed-off-by: nixonrodrigues 
(cherry picked from commit 7917e548a9bf184fba9ed7b227bc153a7f11e949)


> UI: Propagated Classifications shows wrong count for entity type on Entity 
> detail page.
> ---
>
> Key: ATLAS-4387
> URL: https://issues.apache.org/jira/browse/ATLAS-4387
> Project: Atlas
>  Issue Type: Bug
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4387-UI-Propagated-Classifications-shows-wrong.patch
>
>
> The total number of counts for Entity types is wrong under Propagated 
> Classifications of the entity detail page. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4386) Relationship search: Sorting does not work when relationship label is passed

2021-08-09 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396268#comment-17396268
 ] 

ASF subversion and git services commented on ATLAS-4386:


Commit ef0a450ae1f13e984bc974cf82d0096275acdc2d in atlas's branch 
refs/heads/branch-2.0 from Pinal
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ef0a450 ]

ATLAS-4386 : Relationship search: Sorting does not work when passed 
relationship label

Signed-off-by: Pinal 
(cherry picked from commit e3cbaabfba4f0aeb606c696492747759a8d34423)


> Relationship search: Sorting does not work when relationship label is passed
> 
>
> Key: ATLAS-4386
> URL: https://issues.apache.org/jira/browse/ATLAS-4386
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Pinal Shah
>Assignee: Pinal Shah
>Priority: Major
> Fix For: 3.0.0
>
>
> Relationship Search is not able to sort when relationship label is passed as 
> a queryParam instead of attribute.
> Example:
> [api/atlas/v2/search/relationship?limit=25=0=cca5c29d-307f-4a9b-ac6c-79f41a08a90b=__hive_table.columns=name=DESCENDING|http://localhost:21000/api/atlas/v2/search/relationship?limit=25=0=cca5c29d-307f-4a9b-ac6c-79f41a08a90b=Table.DB=name=DESCENDING=true=true=true=true&_=1627902986338]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4343) [Entity Audits] 'Propagated Classification Added' Timestamp is < 'Entity Created' Timestamp

2021-08-09 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396266#comment-17396266
 ] 

ASF subversion and git services commented on ATLAS-4343:


Commit 8edec03affcc9881a3d55f0f3cf9893829bed3bd in atlas's branch 
refs/heads/master from Radhika Kundam
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=8edec03 ]

ATLAS-4343:[Entity Audits] 'Propagated Classification Added' Timestamp is < 
'Entity Created' Timestamp

Signed-off-by: sidmishra 


> [Entity Audits] 'Propagated Classification Added' Timestamp is < 'Entity 
> Created' Timestamp
> ---
>
> Key: ATLAS-4343
> URL: https://issues.apache.org/jira/browse/ATLAS-4343
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Umesh Padashetty
>Assignee: Mandar Ambawane
>Priority: Major
>
> The 'Propagated Classification Added' Timestamp is < 'Entity Created' 
> Timestamp. This is invalid since the classificiation is propagated once the 
> entity is created 
> For instance
>  # Created an external table with ozone path location
>  # This creates ozone_key and hive_table entity
>  # Entity Created TImestamp is shown correctly for both the entities
>  # Applied a tag to ozone_key with propagate classification set to true
>  # Classification propagates to hive_table entity, but the Timestamp shown is 
> in past
>  # For ozone_key:
>  ## Entity created: 06/24/2021 08:44:33 PM (IST)
>  ## Classification added:  06/24/2021 08:44:51 PM (IST)
>  # Whereas hive_table:
>  ## Entity created: 06/24/2021 08:44:33 PM (IST)
>  ## Propagated Classification Added: 06/24/2021 *08:37:06 PM* (IST)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73503: ATLAS-4386 : Relationship search: Sorting does not work when passed relationship label

2021-08-09 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73503/#review223325
---




repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Lines 1621 (patched)


What is the rationale for this?

The way I look at it is:
- Fetch edges with a label. (from line 1611)
- Checked if edges exists (line 1613)
- Found edges, get vertex that is not the passed vertex.
- Return the vertex.

I don't understand why StringUtils.equals is used. I think the outVertexId 
== entityVertexId should never be used.

Reason: entityVertexId can potentially have edges of different labels.


- Ashutosh Mestry


On Aug. 4, 2021, 2:55 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73503/
> ---
> 
> (Updated Aug. 4, 2021, 2:55 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4386
> https://issues.apache.org/jira/browse/ATLAS-4386
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Problem:**
> 
> Relationship Search is not able to sort when relationship label is passed as 
> a queryParam instead of attribute.
> 
> **Example:**
> 
> api/atlas/v2/search/relationship?limit=25=0=cca5c29d-307f-4a9b-ac6c-79f41a08a90b=__hive_table.columns=name=DESCENDING
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  f2290c672 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> ff7fd150e 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  a9fbd435a 
> 
> 
> Diff: https://reviews.apache.org/r/73503/diff/1/
> 
> 
> Testing
> ---
> 
> added test cases
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

[jira] [Assigned] (ATLAS-4374) [Send lineage only information] When a ctas table is created, there is an additional notification sent by hive

2021-08-09 Thread Radhika Kundam (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam reassigned ATLAS-4374:
-

Assignee: Radhika Kundam

> [Send lineage only information] When a ctas table is created, there is an 
> additional notification sent by hive
> --
>
> Key: ATLAS-4374
> URL: https://issues.apache.org/jira/browse/ATLAS-4374
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Radhika Kundam
>Priority: Major
> Attachments: Screenshot 2021-07-27 at 3.06.59 PM.png, Screenshot 
> 2021-07-27 at 3.22.47 PM.png
>
>
> *Scenario*: 
> create a table and create a ctas table from it
> *Expectation*:
> There has to be only 1 notification from hive with *ENTITY_CREATE_V2* type
> *Observation*:
> There are 2 notifications
> one with *ENTITY_CREATE_V2* and other with *ENTITY_PARTIAL_UPDATE_V2*
> {code:java}
>  
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"172.27.202.195","msgCreatedBy":"hive","msgCreationTime":1627372412791,"spooled":false,"message":{"type":"ENTITY_PARTIAL_UPDATE_V2","user":"hive","entityId":{"typeName":"hive_table","uniqueAttributes":{"qualifiedName":"db_mtkns.ctas_table_vwsci@cm"}},"entity":{"entity":{"typeName":"hive_table","attributes":{"parameters":{"numRows":"0","rawDataSize":"0","transient_lastDdlTime":"1627372412","bucketing_version":"2","numFilesErasureCoded":"0","totalSize":"0","transactional_properties":"default","COLUMN_STATS_ACCURATE":"{\"BASIC_STATS\":\"true\"}","numFiles":"0","transactional":"true"}},"isIncomplete":false,"provenanceType":0,"version":0,"proxy":false
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"172.27.202.195","msgCreatedBy":"hive","msgCreationTime":1627372412906,"spooled":false,"message":{"type":"ENTITY_CREATE_V2","user":"hrt_qa","entities":{"referredEntities":{},"entities":[{"typeName":"hive_table_ddl","attributes":{"serviceType":"hive","qualifiedName":"db_mtkns.ctas_table_vwsci@cm:1627372386732","execTime":1627372386732,"queryText":"create
>  table db_mtkns.ctas_table_vwsci as select * from 
> db_mtkns.table_gmqnw","name":"create table db_mtkns.ctas_table_vwsci as 
> select * from 
> db_mtkns.table_gmqnw","userName":"hrt_qa"},"guid":"-7790679096914344","isIncomplete":false,"provenanceType":0,"version":0,"relationshipAttributes":{"table":{"typeName":"hive_table","uniqueAttributes":{"qualifiedName":"db_mtkns.ctas_table_vwsci@cm"},"relationshipType":"hive_table_ddl_queries"}},"proxy":false},{"typeName":"hive_process","attributes":{"recentQueries":["create
>  table db_mtkns.ctas_table_vwsci as select * from 
> db_mtkns.table_gmqnw"],"qualifiedName":"db_mtkns.ctas_table_vwsci@cm:1627372412000","clusterName":"cm","name":"db_mtkns.ctas_table_vwsci@cm:1627372412000","queryText":"","operationType":"CREATETABLE_AS_SELECT","startTime":1627372412905,"queryPlan":"Not
>  
> Supported","endTime":1627372412905,"userName":"","queryId":""},"guid":"-7790679096914345","isIncomplete":false,"provenanceType":0,"version":0,"relationshipAttributes":{"outputs":[{"typeName":"hive_table","uniqueAttributes":{"qualifiedName":"db_mtkns.ctas_table_vwsci@cm"},"relationshipType":"process_dataset_outputs"}],"inputs":[{"typeName":"hive_table","uniqueAttributes":{"qualifiedName":"db_mtkns.table_gmqnw@cm"},"relationshipType":"dataset_process_inputs"}]},"proxy":false},{"typeName":"hive_process_execution","attributes":{"hostName":"quasar-eotkek-5.quasar-eotkek.root.hwx.site","qualifiedName":"db_mtkns.ctas_table_vwsci@cm:1627372412000:1627372386732:1627372412905","name":"db_mtkns.ctas_table_vwsci@cm:1627372412000:1627372386732:1627372412905","queryText":"create
>  table db_mtkns.ctas_table_vwsci as select * from 
> db_mtkns.table_gmqnw","startTime":1627372386732,"queryPlan":"Not 
>

[jira] [Assigned] (ATLAS-2989) Full text search based dsl query is not bringing the results appropriately

2021-08-09 Thread Ashutosh Mestry (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry reassigned ATLAS-2989:
--

Assignee: Pinal Shah

> Full text search based dsl query is not bringing the results appropriately
> --
>
> Key: ATLAS-2989
> URL: https://issues.apache.org/jira/browse/ATLAS-2989
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Reporter: Abhishek Sharma
>Assignee: Pinal Shah
>Priority: Blocker
>
> Hello
> I have created some entities(like test1,school,college) using custom type 
> that I have prepared.
> Each entity contains array of columns .Each column contains array of sources. 
> Each Column comprises of columnAlias as a field.
> Now when I am performing the full text search using the below mentioned query
> [http://172.29.59.59:21000/api/atlas/v2/search/fulltext?excludeDeletedEntities=true=key+where+key='c1'|http://172.29.59.59:21000/api/atlas/v2/search/fulltext?excludeDeletedEntities=true=key+where+key=%27c1%27]
> Even if I provide the key to be something which is not correct and irrevelant 
> ,it is still showing output and it is showing output even on passing correct 
> key.
> I have the following doubts -
> 1) Whether my syntax for full text search query is incorrect ?
> 2) Same pattern is observed even on querying using basic dsl
> http://172.29.59.81:21000/api/atlas/v2/search/basic?excludeDeletedEntities=true==columns



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (ATLAS-3768) Business Metadata import issue with extra commas csv file

2021-08-09 Thread Mayank Jain (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mayank Jain closed ATLAS-3768.
--

> Business Metadata import issue with extra commas csv file
> -
>
> Key: ATLAS-3768
> URL: https://issues.apache.org/jira/browse/ATLAS-3768
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Mayank Jain
>Priority: Minor
> Attachments: ATLAS-3768-1.patch
>
>
> If a csv file contains an extra comma(which gets inserted automatically at 
> the end of the file after editing and saving the file in a program like 
> Libreoffice Calc) and is then imported, it throws the error
> {code:java}
> "Provided UniqueAttributeValue is not valid.at line #1"{code}
> which is an invalid error message and doesn't inform the user as to what the 
> error actually is.
> It should point to the extra comma in the error message, or the extra comma 
> should be handled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4392) The displayed names in a relationship should be sorted

2021-08-09 Thread Mandar Ambawane (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396038#comment-17396038
 ] 

Mandar Ambawane commented on ATLAS-4392:


When we have a 1:N relationship then we able to see the list of connected 
entities in the Atlas UI.

These entities don't seem to be sorted in a meaningful way.

The correct way would be if they are sorted in alphabetical order.

> The displayed names in a relationship should be sorted
> --
>
> Key: ATLAS-4392
> URL: https://issues.apache.org/jira/browse/ATLAS-4392
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-2989) Full text search based dsl query is not bringing the results appropriately

2021-08-09 Thread Pinal Shah (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395966#comment-17395966
 ] 

Pinal Shah commented on ATLAS-2989:
---

Also can you mention the affect version?

> Full text search based dsl query is not bringing the results appropriately
> --
>
> Key: ATLAS-2989
> URL: https://issues.apache.org/jira/browse/ATLAS-2989
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Reporter: Abhishek Sharma
>Priority: Blocker
>
> Hello
> I have created some entities(like test1,school,college) using custom type 
> that I have prepared.
> Each entity contains array of columns .Each column contains array of sources. 
> Each Column comprises of columnAlias as a field.
> Now when I am performing the full text search using the below mentioned query
> [http://172.29.59.59:21000/api/atlas/v2/search/fulltext?excludeDeletedEntities=true=key+where+key='c1'|http://172.29.59.59:21000/api/atlas/v2/search/fulltext?excludeDeletedEntities=true=key+where+key=%27c1%27]
> Even if I provide the key to be something which is not correct and irrevelant 
> ,it is still showing output and it is showing output even on passing correct 
> key.
> I have the following doubts -
> 1) Whether my syntax for full text search query is incorrect ?
> 2) Same pattern is observed even on querying using basic dsl
> http://172.29.59.81:21000/api/atlas/v2/search/basic?excludeDeletedEntities=true==columns



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-2989) Full text search based dsl query is not bringing the results appropriately

2021-08-09 Thread Pinal Shah (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395965#comment-17395965
 ] 

Pinal Shah commented on ATLAS-2989:
---

[~abhi63269]

Full text search is not preferred to query like dsl (Ex: where Key = value). 
You can use DSL query/ Advanced search REST api for it.

> Full text search based dsl query is not bringing the results appropriately
> --
>
> Key: ATLAS-2989
> URL: https://issues.apache.org/jira/browse/ATLAS-2989
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Reporter: Abhishek Sharma
>Priority: Blocker
>
> Hello
> I have created some entities(like test1,school,college) using custom type 
> that I have prepared.
> Each entity contains array of columns .Each column contains array of sources. 
> Each Column comprises of columnAlias as a field.
> Now when I am performing the full text search using the below mentioned query
> [http://172.29.59.59:21000/api/atlas/v2/search/fulltext?excludeDeletedEntities=true=key+where+key='c1'|http://172.29.59.59:21000/api/atlas/v2/search/fulltext?excludeDeletedEntities=true=key+where+key=%27c1%27]
> Even if I provide the key to be something which is not correct and irrevelant 
> ,it is still showing output and it is showing output even on passing correct 
> key.
> I have the following doubts -
> 1) Whether my syntax for full text search query is incorrect ?
> 2) Same pattern is observed even on querying using basic dsl
> http://172.29.59.81:21000/api/atlas/v2/search/basic?excludeDeletedEntities=true==columns



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-2990) Full text search not working as expected

2021-08-09 Thread Pinal Shah (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395960#comment-17395960
 ] 

Pinal Shah commented on ATLAS-2990:
---

[~abhi63269] 

If you want to search with query language (Domain specific search language) you 
can use DSL search/ Advanced search REST api.

Example :
/api/atlas/v2/search/dsl?limit=25=0=hive_table%20where%20name%20%3D%20%27testMap%27

> Full text search not working as expected
> 
>
> Key: ATLAS-2990
> URL: https://issues.apache.org/jira/browse/ATLAS-2990
> Project: Atlas
>  Issue Type: Bug
>Reporter: Abhishek Sharma
>Priority: Blocker
>
> Hello,
> I am performing full text search on my entities. My entity structure has 
> array of columns inside it. Now each column has a set of attributes inside 
> it.  When I do full text search based on the particular attribute of the 
> column then I get all the entities that I created from the type despite the 
> filtering condition applied in the form of where clause.
> It looks like the where clause is not even working with the full text search. 
> Here is my sample query-
> api/atlas/v2/search/fulltext?query=%2C+columns+where+%3D%27%27
>  
> Now in the above query I only want the entities where the attribute is equal 
> to value but instead the full text search retrieves all the entities of the 
> type  despite where clause is satisfied or not.
>  
> Please suggest me if I am using the full text query with wrong syntax
> Or if you could provide some other DSL query that solves my problem statement 
> then I would be really thankful.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4392) The displayed names in a relationship should be sorted

2021-08-09 Thread Mandar Ambawane (Jira) 
Mandar Ambawane created ATLAS-4392:
--

 Summary: The displayed names in a relationship should be sorted
 Key: ATLAS-4392
 URL: https://issues.apache.org/jira/browse/ATLAS-4392
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Reporter: Mandar Ambawane
Assignee: Mandar Ambawane






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4386) Relationship search: Sorting does not work when relationship label is passed

2021-08-09 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395897#comment-17395897
 ] 

ASF subversion and git services commented on ATLAS-4386:


Commit e3cbaabfba4f0aeb606c696492747759a8d34423 in atlas's branch 
refs/heads/master from Pinal
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=e3cbaab ]

ATLAS-4386 : Relationship search: Sorting does not work when passed 
relationship label

Signed-off-by: Pinal 


> Relationship search: Sorting does not work when relationship label is passed
> 
>
> Key: ATLAS-4386
> URL: https://issues.apache.org/jira/browse/ATLAS-4386
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Pinal Shah
>Assignee: Pinal Shah
>Priority: Major
>
> Relationship Search is not able to sort when relationship label is passed as 
> a queryParam instead of attribute.
> Example:
> [api/atlas/v2/search/relationship?limit=25=0=cca5c29d-307f-4a9b-ac6c-79f41a08a90b=__hive_table.columns=name=DESCENDING|http://localhost:21000/api/atlas/v2/search/relationship?limit=25=0=cca5c29d-307f-4a9b-ac6c-79f41a08a90b=Table.DB=name=DESCENDING=true=true=true=true&_=1627902986338]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4386) Relationship search: Sorting does not work when relationship label is passed

2021-08-09 Thread Pinal Shah (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal Shah updated ATLAS-4386:
--
Summary: Relationship search: Sorting does not work when relationship label 
is passed  (was: Relationship search: Sorting does not work when passed 
relationship label)

> Relationship search: Sorting does not work when relationship label is passed
> 
>
> Key: ATLAS-4386
> URL: https://issues.apache.org/jira/browse/ATLAS-4386
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Pinal Shah
>Assignee: Pinal Shah
>Priority: Major
>
> Relationship Search is not able to sort when relationship label is passed as 
> a queryParam instead of attribute.
> Example:
> [api/atlas/v2/search/relationship?limit=25=0=cca5c29d-307f-4a9b-ac6c-79f41a08a90b=__hive_table.columns=name=DESCENDING|http://localhost:21000/api/atlas/v2/search/relationship?limit=25=0=cca5c29d-307f-4a9b-ac6c-79f41a08a90b=Table.DB=name=DESCENDING=true=true=true=true&_=1627902986338]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)