Re: Review Request 73929: ATLAS-4576 Backward compatibility for check provided for AttributeName in Parent and Child TypeDef
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73929/ --- (Updated April 26, 2022, 5:57 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Pinal Shah, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra. Changes --- 1. Addressed review comments. 2. Added test cases for ClassificationType and EntityType. Bugs: ATLAS-4576 https://issues.apache.org/jira/browse/ATLAS-4576 Repository: atlas Description --- Currently we have provided 2 checks for the Attribute Name: https://issues.apache.org/jira/browse/ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name https://issues.apache.org/jira/browse/ATLAS-4522 Updating typedef with new supertype should be allowed only if attributes are unique compared to other existing supertypes But in the earlier versions these checks were not there. So there may be a chance of Atlas environment having such data where these checks can cause problems at the time: 1. Atlas Startup. 2. Creating new typedefs This patch handles these scenarios and provides backward compatibility for these 2 changes mentioned. Diffs (updated) - intg/src/main/java/org/apache/atlas/ThreadContext.java PRE-CREATION intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 76bee36f2 intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 21ce23657 intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c05bb399 intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java b6055fa30 intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 742970390 webapp/src/main/java/org/apache/atlas/Atlas.java 7cf6e3eab Diff: https://reviews.apache.org/r/73929/diff/3/ Changes: https://reviews.apache.org/r/73929/diff/2-3/ Testing (updated) --- PreCommit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1084/consoleFull Thanks, Mandar Ambawane
[GitHub] [atlas] mneethiraj closed pull request #175: fix minor problem in list_attributes_to_params()
mneethiraj closed pull request #175: fix minor problem in list_attributes_to_params() URL: https://github.com/apache/atlas/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [atlas] mneethiraj commented on pull request #175: fix minor problem in list_attributes_to_params()
mneethiraj commented on PR #175: URL: https://github.com/apache/atlas/pull/175#issuecomment-1108947378 @cdoron - thank you for reporting this issue and the patch to address the same. I filed ATLAS-4590 and merged your fix in master and branch-2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (ATLAS-4590) Python - fix minor problem in list_attributes_to_params()
[ https://issues.apache.org/jira/browse/ATLAS-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527724#comment-17527724 ] ASF subversion and git services commented on ATLAS-4590: Commit 05716dc76a009e789177bc2b9419a7811c61a3f2 in atlas's branch refs/heads/master from Doron Chen [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=05716dc76 ] ATLAS-4590: fix minor problem in list_attributes_to_params() Signed-off-by: Madhan Neethiraj > Python - fix minor problem in list_attributes_to_params() > - > > Key: ATLAS-4590 > URL: https://issues.apache.org/jira/browse/ATLAS-4590 > Project: Atlas > Issue Type: Bug > Components: atlas-intg >Reporter: Madhan Neethiraj >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > A string concat expression uses an integer directly i.e., without using > str(). This needs to be fixed in intg/src/main/python/apache_atlas/utils.py > b/intg/src/main/python/apache_atlas/utils.py. > Reported and fixed by Doron Chen via > https://github.com/apache/atlas/pull/175. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (ATLAS-4590) Python - fix minor problem in list_attributes_to_params()
[ https://issues.apache.org/jira/browse/ATLAS-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527722#comment-17527722 ] ASF subversion and git services commented on ATLAS-4590: Commit 779b35271317200567a82cfa9858797c297493b6 in atlas's branch refs/heads/branch-2.0 from Doron Chen [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=779b35271 ] ATLAS-4590: fix minor problem in list_attributes_to_params() Signed-off-by: Madhan Neethiraj (cherry picked from commit cc47aca6cf9a7e05c9e81ab218a077f40af8d9fe) > Python - fix minor problem in list_attributes_to_params() > - > > Key: ATLAS-4590 > URL: https://issues.apache.org/jira/browse/ATLAS-4590 > Project: Atlas > Issue Type: Bug > Components: atlas-intg >Reporter: Madhan Neethiraj >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > A string concat expression uses an integer directly i.e., without using > str(). This needs to be fixed in intg/src/main/python/apache_atlas/utils.py > b/intg/src/main/python/apache_atlas/utils.py. > Reported and fixed by Doron Chen via > https://github.com/apache/atlas/pull/175. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (ATLAS-4590) Python - fix minor problem in list_attributes_to_params()
[ https://issues.apache.org/jira/browse/ATLAS-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-4590: Description: A string concat expression uses an integer directly i.e., without using str(). This needs to be fixed in intg/src/main/python/apache_atlas/utils.py b/intg/src/main/python/apache_atlas/utils.py. Reported and fixed by Doron Chen via https://github.com/apache/atlas/pull/175. was:A string concat expression uses an integer directly i.e., without using str(). This needs to be fixed in intg/src/main/python/apache_atlas/utils.py b/intg/src/main/python/apache_atlas/utils.py. > Python - fix minor problem in list_attributes_to_params() > - > > Key: ATLAS-4590 > URL: https://issues.apache.org/jira/browse/ATLAS-4590 > Project: Atlas > Issue Type: Bug > Components: atlas-intg >Reporter: Madhan Neethiraj >Priority: Major > > A string concat expression uses an integer directly i.e., without using > str(). This needs to be fixed in intg/src/main/python/apache_atlas/utils.py > b/intg/src/main/python/apache_atlas/utils.py. > Reported and fixed by Doron Chen via > https://github.com/apache/atlas/pull/175. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (ATLAS-4590) Python - fix minor problem in list_attributes_to_params()
Madhan Neethiraj created ATLAS-4590: --- Summary: Python - fix minor problem in list_attributes_to_params() Key: ATLAS-4590 URL: https://issues.apache.org/jira/browse/ATLAS-4590 Project: Atlas Issue Type: Bug Components: atlas-intg Reporter: Madhan Neethiraj A string concat expression uses an integer directly i.e., without using str(). This needs to be fixed in intg/src/main/python/apache_atlas/utils.py b/intg/src/main/python/apache_atlas/utils.py. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [atlas] cdoron opened a new pull request, #175: fix minor problem in list_attributes_to_params()
cdoron opened a new pull request, #175: URL: https://github.com/apache/atlas/pull/175 Signed-off-by: Doron Chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (ATLAS-4589) local solr started error on ARM64:can't find solr.log
hongsp created ATLAS-4589: - Summary: local solr started error on ARM64:can't find solr.log Key: ATLAS-4589 URL: https://issues.apache.org/jira/browse/ATLAS-4589 Project: Atlas Issue Type: Bug Components: atlas-core Affects Versions: 2.2.0 Reporter: hongsp Fix For: 2.2.0 Attachments: image-2022-04-25-21-59-35-574.png, image-2022-04-25-22-00-15-020.png 1、local solr started error on ARM64:can't find solr.log： !image-2022-04-25-21-59-35-574.png! 2、this is solr-8983-console.log content： !image-2022-04-25-22-00-15-020.png! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (ATLAS-4588) UI: Lineage Settings window appears unexpectedly and won't close.
Rahul Kurup created ATLAS-4588: -- Summary: UI: Lineage Settings window appears unexpectedly and won't close. Key: ATLAS-4588 URL: https://issues.apache.org/jira/browse/ATLAS-4588 Project: Atlas Issue Type: Bug Reporter: Rahul Kurup Attachments: lineage_settings_freeze.mp4 If a user performs the navigations as demonstrated in the attached video within a lineage tab, it results in the lineage Settings window suddenly appearing and this window can't be closed. [^lineage_settings_freeze.mp4] -- This message was sent by Atlassian Jira (v8.20.7#820007)
