Re: Review Request 73991: ATLAS-4605 Prevent NullPointerException when Atlas Vertex is empty because of corrupted data
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73991/#review224462 --- Ship it! Ship It! - Ashutosh Mestry On May 18, 2022, 10:41 a.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73991/ > --- > > (Updated May 18, 2022, 10:41 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, > Radhika Kundam, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-4605 > https://issues.apache.org/jira/browse/ATLAS-4605 > > > Repository: atlas > > > Description > --- > > Because of corrupted data, there may be a chance of having AtlasVertex as an > empty, which means AtlasVertex does not have any property present in it. > This can cause NullPointerException while populating System attributes as > well Normal attributes for AtlasEntity object. > To avoid NullPointerException we need to skip such vertices, so that they > cannot be used to populate system attributes and normal attributes. > > > Diffs > - > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > fcd8dfe7f > > > Diff: https://reviews.apache.org/r/73991/diff/1/ > > > Testing > --- > > PreCommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1098/consoleFull > > Sanity testing is done. > > Test Scenarios covered: > > Hive hook: > Create table, check column and table relationships > Create ctas table, check relationships > Generate shell entities > Check if added tables are generating correct entries after reversing shell > condition. > Update table entities > > Hbase hook: > Create table, check column family and table relationships > Check if added tables are generating correct entries after reversing hook. > Update table entities > > General: > Search for entities in basic and advanced searches > Save favourite searches > Checked for entity-delete and entity-purge scenarios > Applied classifications > Applied terms > Create and apply business metadata > > > Thanks, > > Mandar Ambawane > >
[jira] [Updated] (ATLAS-4583) UI: When there is no data, error is encountered on switching UI at a specific page
[ https://issues.apache.org/jira/browse/ATLAS-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farhan Khan updated ATLAS-4583: --- Parent: ATLAS-3887 Issue Type: Sub-task (was: Bug) > UI: When there is no data, error is encountered on switching UI at a specific > page > -- > > Key: ATLAS-4583 > URL: https://issues.apache.org/jira/browse/ATLAS-4583 > Project: Atlas > Issue Type: Sub-task >Affects Versions: 3.0.0, 2.3.0 >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4583-UI-When-there-is-no-data-error-is-encount.patch > > > In old UI, when there is no data for classification and glossary, if the user > selects either 'tree' toggle in classification or 'category' toggle in > glossary section, and then attempts to switch UI, they get an endless loading > page with the following error message: > viewType=tree: Unknown/invalid classification > or > Given instance guid viewType=category is invalid/not found > > 23/05/22: Also found an issue where after creating a classification, > switching from Classic UI to new UI and then deleting the classification > results in an endless loading within the deletion dialog box. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (ATLAS-4583) UI: When there is no data, error is encountered on switching UI at a specific page
[ https://issues.apache.org/jira/browse/ATLAS-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Kurup updated ATLAS-4583: --- Description: In old UI, when there is no data for classification and glossary, if the user selects either 'tree' toggle in classification or 'category' toggle in glossary section, and then attempts to switch UI, they get an endless loading page with the following error message: viewType=tree: Unknown/invalid classification or Given instance guid viewType=category is invalid/not found 23/05/22: Also found an issue where after creating a classification, switching from Classic UI to new UI and then deleting the classification results in an endless loading within the deletion dialog box. was: In old UI, when there is no data for classification and glossary, if the user selects either 'tree' toggle in classification or 'category' toggle in glossary section, and then attempts to switch UI, they get an endless loading page with the following error message: viewType=tree: Unknown/invalid classification or Given instance guid viewType=category is invalid/not found > UI: When there is no data, error is encountered on switching UI at a specific > page > -- > > Key: ATLAS-4583 > URL: https://issues.apache.org/jira/browse/ATLAS-4583 > Project: Atlas > Issue Type: Bug >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4583-UI-When-there-is-no-data-error-is-encount.patch > > > In old UI, when there is no data for classification and glossary, if the user > selects either 'tree' toggle in classification or 'category' toggle in > glossary section, and then attempts to switch UI, they get an endless loading > page with the following error message: > viewType=tree: Unknown/invalid classification > or > Given instance guid viewType=category is invalid/not found > > 23/05/22: Also found an issue where after creating a classification, > switching from Classic UI to new UI and then deleting the classification > results in an endless loading within the deletion dialog box. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (ATLAS-4583) UI: When there is no data, error is encountered on switching UI at a specific page
[ https://issues.apache.org/jira/browse/ATLAS-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540895#comment-17540895 ] Farhan Khan commented on ATLAS-4583: Hi, This patch has the fix for the issue mentioned in the description. Regards, Farhan Khan > UI: When there is no data, error is encountered on switching UI at a specific > page > -- > > Key: ATLAS-4583 > URL: https://issues.apache.org/jira/browse/ATLAS-4583 > Project: Atlas > Issue Type: Bug >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4583-UI-When-there-is-no-data-error-is-encount.patch > > > In old UI, when there is no data for classification and glossary, if the user > selects either 'tree' toggle in classification or 'category' toggle in > glossary section, and then attempts to switch UI, they get an endless loading > page with the following error message: > viewType=tree: Unknown/invalid classification > or > Given instance guid viewType=category is invalid/not found -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (ATLAS-4583) UI: When there is no data, error is encountered on switching UI at a specific page
[ https://issues.apache.org/jira/browse/ATLAS-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farhan Khan updated ATLAS-4583: --- Attachment: 0001-ATLAS-4583-UI-When-there-is-no-data-error-is-encount.patch > UI: When there is no data, error is encountered on switching UI at a specific > page > -- > > Key: ATLAS-4583 > URL: https://issues.apache.org/jira/browse/ATLAS-4583 > Project: Atlas > Issue Type: Bug >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4583-UI-When-there-is-no-data-error-is-encount.patch > > > In old UI, when there is no data for classification and glossary, if the user > selects either 'tree' toggle in classification or 'category' toggle in > glossary section, and then attempts to switch UI, they get an endless loading > page with the following error message: > viewType=tree: Unknown/invalid classification > or > Given instance guid viewType=category is invalid/not found -- This message was sent by Atlassian Jira (v8.20.7#820007)
