Re: Review Request 74061: ATLAS-4637: Import/Export Feature for MetricsStat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74061/ --- (Updated July 26, 2022, 4:12 p.m.) Review request for atlas, Disha Talreja, Radhika Kundam, and Sidharth Mishra. Bugs: ATLAS-4637 https://issues.apache.org/jira/browse/ATLAS-4637 Repository: atlas Description (updated) --- 1. Add new attribute - importLabel - to MetricsStat. It contains the name/identity of the user who is importing MetricsStat file from one machine to another machine. For some Machine A, importLabel is set to "self" for the already existing MetricsStat that collects the metrics info in Machine A, and has not been imported from another machine. 2. Update metricsId to contain both importLabel and collectionTime to continue holding its property of being a unique attribute. 3. Update MetricsService to implement REST APIs in AdminResource to realize api calls of: 1. Post MetricsStat with a specific importLabel obtained from a another machine. 2. Get MetricsStat with a specific importLabel found in some machine with a boolean flag that returns metrics with specific details, or with minimal information. 3. Delete all existing MetricsStats entities in a given machine. 4. Delete all existing MetricsStats entities in a given machine with a specific importLabel. 5. Get all importLabels. 6. Update MetricsService to include helper methods of: 1. Get a persisted metricsStat by importLabel. 2. Get a persisted metricsStat by collectionTime and importLabel. 7. UI support enabled. Diffs - addons/models/-Area0/patches/007-base_model_add_importLabel_attribute.json PRE-CREATION intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java 5a30cad06a8616184e09bd48fe99975b6750adc8 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9924b2e4ce2c7b2d44b64657b300e1592b2bd394 repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java 6af935ebbb1f3b5e03589d19ea16d51ba675d5db repository/src/main/java/org/apache/atlas/services/MetricsService.java 9ec2cd2cb249b1f881f01261e7ae7e10f0adbe67 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java d55ada77edd9d006d6ef31720c427e08984097ba Diff: https://reviews.apache.org/r/74061/diff/2/ Testing --- File Attachments 0001-MetricsImportExportUI-ApacheMasterBranch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/0eabb428-689a-4d59-bbae-55b76495c131__0001-MetricsImportExportUI-ApacheMasterBranch.patch Thanks, Beakal Lemeneh
Re: Review Request 74061: ATLAS-4637: Import/Export Feature for MetricsStat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74061/ --- (Updated July 26, 2022, 4:08 p.m.) Review request for atlas, Disha Talreja, Radhika Kundam, and Sidharth Mishra. Bugs: ATLAS-4637 https://issues.apache.org/jira/browse/ATLAS-4637 Repository: atlas Description --- 1. Add new attribute - importLabel - to MetricsStat. It contains the name/identity of the user who is importing MetricsStat file from one machine to another machine. For some Machine A, importLabel is set to "self" for the already existing MetricsStat that collects the metrics info in Machine A, and has not been imported from another machine. 2. Update metricsId to contain both importLabel and collectionTime to continue holding its property of being a unique attribute. 3. Update MetricsService to implement REST APIs in AdminResource to realize api calls of: 1. Post MetricsStat with a specific importLabel obtained from a another machine. 2. Get MetricsStat with a specific importLabel found in some machine with a boolean flag that returns metrics with specific details, or with minimal information. 3. Delete all existing MetricsStats entities in a given machine. 4. Delete all existing MetricsStats entities in a given machine with a specific importLabel. 5. Get all importLabels. 6. Update MetricsService to include helper methods of: 1. Get a persisted metricsStat by importLabel. 2. Get a persisted metricsStat by collectionTime and importLabel. Diffs (updated) - addons/models/-Area0/patches/007-base_model_add_importLabel_attribute.json PRE-CREATION intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java 5a30cad06a8616184e09bd48fe99975b6750adc8 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9924b2e4ce2c7b2d44b64657b300e1592b2bd394 repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java 6af935ebbb1f3b5e03589d19ea16d51ba675d5db repository/src/main/java/org/apache/atlas/services/MetricsService.java 9ec2cd2cb249b1f881f01261e7ae7e10f0adbe67 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java d55ada77edd9d006d6ef31720c427e08984097ba Diff: https://reviews.apache.org/r/74061/diff/2/ Changes: https://reviews.apache.org/r/74061/diff/1-2/ Testing --- File Attachments 0001-MetricsImportExportUI-ApacheMasterBranch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/0eabb428-689a-4d59-bbae-55b76495c131__0001-MetricsImportExportUI-ApacheMasterBranch.patch Thanks, Beakal Lemeneh
Re: Review Request 74061: ATLAS-4637: Import/Export Feature for MetricsStat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74061/ --- (Updated July 26, 2022, 3:59 p.m.) Review request for atlas, Disha Talreja, Radhika Kundam, and Sidharth Mishra. Bugs: ATLAS-4637 https://issues.apache.org/jira/browse/ATLAS-4637 Repository: atlas Description --- 1. Add new attribute - importLabel - to MetricsStat. It contains the name/identity of the user who is importing MetricsStat file from one machine to another machine. For some Machine A, importLabel is set to "self" for the already existing MetricsStat that collects the metrics info in Machine A, and has not been imported from another machine. 2. Update metricsId to contain both importLabel and collectionTime to continue holding its property of being a unique attribute. 3. Update MetricsService to implement REST APIs in AdminResource to realize api calls of: 1. Post MetricsStat with a specific importLabel obtained from a another machine. 2. Get MetricsStat with a specific importLabel found in some machine with a boolean flag that returns metrics with specific details, or with minimal information. 3. Delete all existing MetricsStats entities in a given machine. 4. Delete all existing MetricsStats entities in a given machine with a specific importLabel. 5. Get all importLabels. 6. Update MetricsService to include helper methods of: 1. Get a persisted metricsStat by importLabel. 2. Get a persisted metricsStat by collectionTime and importLabel. Diffs - intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java 5a30cad06a8616184e09bd48fe99975b6750adc8 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9924b2e4ce2c7b2d44b64657b300e1592b2bd394 repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java 6af935ebbb1f3b5e03589d19ea16d51ba675d5db repository/src/main/java/org/apache/atlas/services/MetricsService.java 9ec2cd2cb249b1f881f01261e7ae7e10f0adbe67 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java d55ada77edd9d006d6ef31720c427e08984097ba Diff: https://reviews.apache.org/r/74061/diff/1/ Testing --- File Attachments (updated) 0001-MetricsImportExportUI-ApacheMasterBranch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/0eabb428-689a-4d59-bbae-55b76495c131__0001-MetricsImportExportUI-ApacheMasterBranch.patch Thanks, Beakal Lemeneh
Re: Review Request 74061: ATLAS-4637: Import/Export Feature for MetricsStat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74061/ --- (Updated July 26, 2022, 3:56 p.m.) Review request for atlas, Disha Talreja, Radhika Kundam, and Sidharth Mishra. Bugs: ATLAS-4637 https://issues.apache.org/jira/browse/ATLAS-4637 Repository: atlas Description --- 1. Add new attribute - importLabel - to MetricsStat. It contains the name/identity of the user who is importing MetricsStat file from one machine to another machine. For some Machine A, importLabel is set to "self" for the already existing MetricsStat that collects the metrics info in Machine A, and has not been imported from another machine. 2. Update metricsId to contain both importLabel and collectionTime to continue holding its property of being a unique attribute. 3. Update MetricsService to implement REST APIs in AdminResource to realize api calls of: 1. Post MetricsStat with a specific importLabel obtained from a another machine. 2. Get MetricsStat with a specific importLabel found in some machine with a boolean flag that returns metrics with specific details, or with minimal information. 3. Delete all existing MetricsStats entities in a given machine. 4. Delete all existing MetricsStats entities in a given machine with a specific importLabel. 5. Get all importLabels. 6. Update MetricsService to include helper methods of: 1. Get a persisted metricsStat by importLabel. 2. Get a persisted metricsStat by collectionTime and importLabel. Diffs - intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java 5a30cad06a8616184e09bd48fe99975b6750adc8 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9924b2e4ce2c7b2d44b64657b300e1592b2bd394 repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java 6af935ebbb1f3b5e03589d19ea16d51ba675d5db repository/src/main/java/org/apache/atlas/services/MetricsService.java 9ec2cd2cb249b1f881f01261e7ae7e10f0adbe67 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java d55ada77edd9d006d6ef31720c427e08984097ba Diff: https://reviews.apache.org/r/74061/diff/1/ Testing --- File Attachments (updated) mypatch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/97326e65-43a6-46ec-8d2f-c9aa02617683__mypatch.patch 0001-MetricsImportExportUI-ApacheMasterBranch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/f5d8267a-f2ae-4746-ab14-d798793cae52__0001-MetricsImportExportUI-ApacheMasterBranch.patch 0001-MetricsImportExportUI-ApacheMasterBranch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/2d5eec26-eafa-496f-8164-28651a694fd9__0001-MetricsImportExportUI-ApacheMasterBranch.patch 0001-MetricsImportExportUI-ApacheMasterBranch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/0eabb428-689a-4d59-bbae-55b76495c131__0001-MetricsImportExportUI-ApacheMasterBranch.patch Thanks, Beakal Lemeneh
[jira] [Updated] (ATLAS-4648) Upgrade Netty version to 4.1.78.Final
[ https://issues.apache.org/jira/browse/ATLAS-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaitali borole updated ATLAS-4648: --- Summary: Upgrade Netty version to 4.1.78.Final (was: Upgrade Netty Project to 4.1.78.Final) > Upgrade Netty version to 4.1.78.Final > - > > Key: ATLAS-4648 > URL: https://issues.apache.org/jira/browse/ATLAS-4648 > Project: Atlas > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: chaitali borole >Assignee: chaitali borole >Priority: Major > Fix For: 3.0.0 > > > current version for Netty to 4.1.77.Final -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ATLAS-4648) Upgrade Netty Project to 4.1.78.Final
chaitali borole created ATLAS-4648: -- Summary: Upgrade Netty Project to 4.1.78.Final Key: ATLAS-4648 URL: https://issues.apache.org/jira/browse/ATLAS-4648 Project: Atlas Issue Type: Improvement Affects Versions: 3.0.0 Reporter: chaitali borole Assignee: chaitali borole Fix For: 3.0.0 current version for Netty to 4.1.77.Final -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74012: UI improvements to support Atlas Lineage fetch on-demand
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74012/ --- (Updated July 26, 2022, 10:38 a.m.) Review request for atlas, Jayendra Parab and Prasad Pawar. Bugs: ATLAS-4607 https://issues.apache.org/jira/browse/ATLAS-4607 Repository: atlas Description --- Atlas lineage for an entity returns all the entities connected in a single call, this is expensive if lineage is long and has multi-level. Lineage API response is large and UI fails to render the response. Diffs (updated) - dashboardv2/public/img/entity-icon/expandBtn.svg PRE-CREATION dashboardv2/public/js/collection/VLineageList.js bda649220 dashboardv2/public/js/external_lib/atlas-lineage/dist/index.js b31ee4911 dashboardv2/public/js/external_lib/atlas-lineage/dist/styles.css 2d7f9d9de dashboardv2/public/js/external_lib/atlas-lineage/src/Utils/DataUtils.js 1255eb070 dashboardv2/public/js/external_lib/atlas-lineage/src/Utils/LineageUtils.js 448a95ae6 dashboardv2/public/js/external_lib/atlas-lineage/src/index.js 3ceb3d90a dashboardv2/public/js/external_lib/atlas-lineage/src/styles/graph.scss ab1e82df3 dashboardv2/public/js/main.js 603e5ec3d dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 5f90b096e dashboardv2/public/js/utils/Globals.js c30f840f7 dashboardv2/public/js/utils/Helper.js f211bd055 dashboardv2/public/js/views/graph/LineageLayoutView.js e989c4719 dashboardv3/public/img/entity-icon/expandBtn.svg PRE-CREATION dashboardv3/public/js/collection/VLineageList.js bda649220 dashboardv3/public/js/external_lib/atlas-lineage/dist/index.js b31ee4911 dashboardv3/public/js/external_lib/atlas-lineage/dist/styles.css 2d7f9d9de dashboardv3/public/js/external_lib/atlas-lineage/src/Utils/DataUtils.js 1255eb070 dashboardv3/public/js/external_lib/atlas-lineage/src/Utils/LineageUtils.js 448a95ae6 dashboardv3/public/js/external_lib/atlas-lineage/src/index.js 3ceb3d90a dashboardv3/public/js/external_lib/atlas-lineage/src/styles/graph.scss ab1e82df3 dashboardv3/public/js/main.js 008fbb222 dashboardv3/public/js/templates/graph/LineageLayoutView_tmpl.html 5f90b096e dashboardv3/public/js/utils/Globals.js 5bbc71a69 dashboardv3/public/js/utils/Helper.js a242098b1 dashboardv3/public/js/views/graph/LineageLayoutView.js e989c4719 Diff: https://reviews.apache.org/r/74012/diff/2/ Changes: https://reviews.apache.org/r/74012/diff/1-2/ Testing --- Manually tested on the local for various possible scenarios. Thanks, Farhan Khan
[jira] [Updated] (ATLAS-4607) UI improvements to support Atlas Lineage fetch on-demand
[ https://issues.apache.org/jira/browse/ATLAS-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farhan Khan updated ATLAS-4607: --- Attachment: 0001-ATLAS-4607-UI-improvements-to-support-Atlas-Lineage-.patch > UI improvements to support Atlas Lineage fetch on-demand > > > Key: ATLAS-4607 > URL: https://issues.apache.org/jira/browse/ATLAS-4607 > Project: Atlas > Issue Type: Improvement > Components: atlas-webui >Affects Versions: 3.0.0, 2.3.0 >Reporter: Radhika Kundam >Assignee: Farhan Khan >Priority: Major > Attachments: > 0001-ATLAS-4607-UI-improvements-to-support-Atlas-Lineage-.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ATLAS-4607) UI improvements to support Atlas Lineage fetch on-demand
[ https://issues.apache.org/jira/browse/ATLAS-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farhan Khan updated ATLAS-4607: --- Attachment: (was: 0001-ATLAS-4607-UI-improvements-to-support-Atlas-Lineage-.patch) > UI improvements to support Atlas Lineage fetch on-demand > > > Key: ATLAS-4607 > URL: https://issues.apache.org/jira/browse/ATLAS-4607 > Project: Atlas > Issue Type: Improvement > Components: atlas-webui >Affects Versions: 3.0.0, 2.3.0 >Reporter: Radhika Kundam >Assignee: Farhan Khan >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ATLAS-4647) Upgrade Spring Security to 5.7.2
[ https://issues.apache.org/jira/browse/ATLAS-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaitali borole updated ATLAS-4647: --- Summary: Upgrade Spring Security to 5.7.2 (was: Atlas - Upgrade Spring Security to 5.7.2) > Upgrade Spring Security to 5.7.2 > > > Key: ATLAS-4647 > URL: https://issues.apache.org/jira/browse/ATLAS-4647 > Project: Atlas > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: chaitali borole >Assignee: chaitali borole >Priority: Major > Fix For: 3.0.0 > > > Current version for spring-security is 5.7.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ATLAS-4647) Atlas - Upgrade Spring Security to 5.7.2
chaitali borole created ATLAS-4647: -- Summary: Atlas - Upgrade Spring Security to 5.7.2 Key: ATLAS-4647 URL: https://issues.apache.org/jira/browse/ATLAS-4647 Project: Atlas Issue Type: Improvement Affects Versions: 3.0.0 Reporter: chaitali borole Assignee: chaitali borole Fix For: 3.0.0 Current version for spring-security is 5.7.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
