Re: Review Request 74061: ATLAS-4637: Import/Export Feature for MetricsStat

2022-07-27 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74061/#review224586
---



Can you please add unit test for this?


webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Line 22 (original), 28 (patched)


Can you please restore individual imports.



webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Line 95 (original), 104 (patched)


Please restore individual imports.


- Ashutosh Mestry


On July 26, 2022, 4:15 p.m., Beakal Lemeneh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74061/
> ---
> 
> (Updated July 26, 2022, 4:15 p.m.)
> 
> 
> Review request for atlas, Disha Talreja, Farhan Khan, Jayendra Parab, Prasad 
> Pawar, Radhika Kundam, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4637
> https://issues.apache.org/jira/browse/ATLAS-4637
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1. Add new attribute - importLabel - to MetricsStat. It contains the 
> name/identity of the user who is importing MetricsStat file from one machine 
> to another machine. For some Machine A, importLabel is set to "self" for the 
> already existing MetricsStat that collects the metrics info in Machine A, and 
> has not been imported from another machine.
> 
> 2. Update metricsId to contain both importLabel and collectionTime to 
> continue holding its property of being a unique attribute.
> 
> 3. Update MetricsService to implement REST APIs in AdminResource to realize 
> api calls of:
>   1. Post MetricsStat with a specific importLabel obtained from a another 
> machine.
>   2. Get MetricsStat with a specific importLabel found in some machine 
> with a boolean flag that returns metrics with specific details, or with 
> minimal information.
>   3. Delete all existing MetricsStats entities in a given machine.
>   4. Delete all existing MetricsStats entities in a given machine with a 
> specific importLabel.
>   5. Get all importLabels.
> 
> 6. Update MetricsService to include helper methods of:
>   1. Get a persisted metricsStat by importLabel.
>   2. Get a persisted metricsStat by collectionTime and importLabel.
> 
> 7. UI support enabled.
> 
> 
> Diffs
> -
> 
>   
> addons/models/-Area0/patches/007-base_model_add_importLabel_attribute.json
>  PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java 
> 5a30cad06a8616184e09bd48fe99975b6750adc8 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  9924b2e4ce2c7b2d44b64657b300e1592b2bd394 
>   
> repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java
>  6af935ebbb1f3b5e03589d19ea16d51ba675d5db 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> 9ec2cd2cb249b1f881f01261e7ae7e10f0adbe67 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> d55ada77edd9d006d6ef31720c427e08984097ba 
> 
> 
> Diff: https://reviews.apache.org/r/74061/diff/2/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 0001-MetricsImportExportUI-ApacheMasterBranch.patch
>   
> https://reviews.apache.org/media/uploaded/files/2022/07/26/0eabb428-689a-4d59-bbae-55b76495c131__0001-MetricsImportExportUI-ApacheMasterBranch.patch
> 
> 
> Thanks,
> 
> Beakal Lemeneh
> 
>

Re: Review Request 74070: ATLAS-4647 : Upgrade Spring Security to 5.7.2

2022-07-27 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74070/#review224585
---


Ship it!




Ship It!

- Ashutosh Mestry


On July 27, 2022, 6:08 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74070/
> ---
> 
> (Updated July 27, 2022, 6:08 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4647
> https://issues.apache.org/jira/browse/ATLAS-4647
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Current version for spring-security is 5.7.1 upgrading it to 5.7.2
> 
> 
> Diffs
> -
> 
>   pom.xml 1e32e45f3 
> 
> 
> Diff: https://reviews.apache.org/r/74070/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -Drat.skip
> atlas server running successfully
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74072: ATLAS-4648 : Upgrade Netty version to 4.1.78.Final

2022-07-27 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74072/#review224584
---


Ship it!




Ship It!

- Ashutosh Mestry


On July 27, 2022, 6:25 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74072/
> ---
> 
> (Updated July 27, 2022, 6:25 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4648
> https://issues.apache.org/jira/browse/ATLAS-4648
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> current version for Netty to 4.1.77.Final
> 
> 
> Diffs
> -
> 
>   pom.xml 1e32e45f3 
> 
> 
> Diff: https://reviews.apache.org/r/74072/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -Drat.skip
> atlas server running successfully
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74071: ATLAS-4649 : Upgrade Spring Framework to 5.3.21

2022-07-27 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74071/#review224583
---


Ship it!




Ship It!

- Ashutosh Mestry


On July 27, 2022, 6:19 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74071/
> ---
> 
> (Updated July 27, 2022, 6:19 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4649
> https://issues.apache.org/jira/browse/ATLAS-4649
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> current version for Spring Framework is 5.3.20
> 
> 
> Diffs
> -
> 
>   pom.xml 1e32e45f3 
> 
> 
> Diff: https://reviews.apache.org/r/74071/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -Drat.skip
> atlas server running successfully
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74072: ATLAS-4648 : Upgrade Netty version to 4.1.78.Final

2022-07-27 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74072/#review224582
---




pom.xml
Line 751 (original), 751 (patched)


I don't see a version update. Not sure if I am missing anything.


- Ashutosh Mestry


On July 27, 2022, 6:25 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74072/
> ---
> 
> (Updated July 27, 2022, 6:25 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4648
> https://issues.apache.org/jira/browse/ATLAS-4648
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> current version for Netty to 4.1.77.Final
> 
> 
> Diffs
> -
> 
>   pom.xml 1e32e45f3 
> 
> 
> Diff: https://reviews.apache.org/r/74072/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -Drat.skip
> atlas server running successfully
> 
> 
> Thanks,
> 
> chaitali
> 
>

[jira] [Created] (ATLAS-4650) Upgrade Apache Commons BeanUtils to 1.9.4

2022-07-27 Thread chaitali borole (Jira) 
chaitali borole created ATLAS-4650:
--

 Summary: Upgrade Apache Commons BeanUtils to 1.9.4
 Key: ATLAS-4650
 URL: https://issues.apache.org/jira/browse/ATLAS-4650
 Project: Atlas
  Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: chaitali borole
Assignee: chaitali borole


Currently Commons BeanUtils  version is  1.9.2,1.8.3





--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74072: ATLAS-4648 : Upgrade Netty version to 4.1.78.Final

2022-07-27 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74072/
---

Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4648
https://issues.apache.org/jira/browse/ATLAS-4648


Repository: atlas


Description
---

current version for Netty to 4.1.77.Final


Diffs
-

  pom.xml 1e32e45f3 


Diff: https://reviews.apache.org/r/74072/diff/1/


Testing
---

mvn clean -DskipTests package -Pdist,embedded-hbase-solr
mvn clean install -Drat.skip
atlas server running successfully


Thanks,

chaitali

Review Request 74071: ATLAS-4649 : Upgrade Spring Framework to 5.3.21

2022-07-27 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74071/
---

Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4649
https://issues.apache.org/jira/browse/ATLAS-4649


Repository: atlas


Description
---

current version for Spring Framework is 5.3.20


Diffs
-

  pom.xml 1e32e45f3 


Diff: https://reviews.apache.org/r/74071/diff/1/


Testing
---

mvn clean -DskipTests package -Pdist,embedded-hbase-solr
mvn clean install -Drat.skip
atlas server running successfully


Thanks,

chaitali

[jira] [Created] (ATLAS-4649) Upgrade Spring Framework to 4.3.30.RELEASE/5.3.21

2022-07-27 Thread chaitali borole (Jira) 
chaitali borole created ATLAS-4649:
--

 Summary: Upgrade Spring Framework to 4.3.30.RELEASE/5.3.21
 Key: ATLAS-4649
 URL: https://issues.apache.org/jira/browse/ATLAS-4649
 Project: Atlas
  Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: chaitali borole
Assignee: chaitali borole
 Fix For: 3.0.0


current version for Spring Framework is 5.3.20



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74070: ATLAS-4647 : Upgrade Spring Security to 5.7.2

2022-07-27 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74070/
---

(Updated July 27, 2022, 6:08 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4647
https://issues.apache.org/jira/browse/ATLAS-4647


Repository: atlas


Description
---

Current version for spring-security is 5.7.1 upgrading it to 5.7.2


Diffs
-

  pom.xml 1e32e45f3 


Diff: https://reviews.apache.org/r/74070/diff/1/


Testing
---

mvn clean -DskipTests package -Pdist,embedded-hbase-solr
mvn clean install -Drat.skip
atlas server running successfully


Thanks,

chaitali