[jira] [Created] (ATLAS-4652) Missing null check leading to NPE in isSoftReferenced method in AtlasStructDef

2022-07-29 Thread Srikanth Venkat (Jira)
Srikanth Venkat created ATLAS-4652:
--

 Summary: Missing null check leading to NPE in isSoftReferenced 
method in AtlasStructDef 
 Key: ATLAS-4652
 URL: https://issues.apache.org/jira/browse/ATLAS-4652
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.2.0
Reporter: Srikanth Venkat


The code inside isSoftReferenced method in AtlasStructDef class below:

   *{{}}* {{@JsonIgnore}}

{{    public boolean isSoftReferenced() {}}

{{    return this.options != null && }}{{          
getOptions().containsKey(AtlasAttributeDef.ATTRDEF_OPTION_SOFT_REFERENCE) &&}}

{{    
getOptions().get(AtlasAttributeDef.ATTRDEF_OPTION_SOFT_REFERENCE){color:#de350b}.equals(STRING_TRUE){color};}}

{{    }}}

 

Since the null check is not performed, it can lead to NPE in typedef resolution.

 

A sample typedef payload like the following can potentially trigger the NPE 
error in attribute resolution, i.e. EntityGraphRetriever.mapVertexToAttribute, 
where attribute.getAttributeDef().isSoftReferenced() is called

{

  "businessMetadataDefs": [

    {

  "category": "BUSINESS_METADATA",

  "name": "bizType1",

  "description": "test",

  "attributeDefs": [

    {

  "name": "bizAttr1",

  "typeName": "string",

  "isOptional": true,

  "cardinality": "SINGLE", 

  "options": { 

*"isSoftReference": null,*   

"maxStrLength": "50",

    "applicableEntityTypes": "[\"Asset\"]"

  } 

}

  ]

    }

  ]

}

 

It would be furthermore helpful to run SonarCube or FindBugs to determine any 
other incidences where this pattern of missing null check exists in Atlas 
codebase and address them. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (ATLAS-4644) [Lineage Improvements] When direction is 'INPUT' for a lineage which does not have inputs, the response does not contain guidEntityMap

2022-07-29 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam resolved ATLAS-4644.
---
  Assignee: Radhika Kundam
Resolution: Not A Bug

> [Lineage Improvements] When direction is 'INPUT' for a lineage which does not 
> have inputs, the response does not contain guidEntityMap
> --
>
> Key: ATLAS-4644
> URL: https://issues.apache.org/jira/browse/ATLAS-4644
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Radhika Kundam
>Priority: Major
>
> Input setup:
> Enable lineage improvements: *atlas.lineage.on.demand.enabled=true*
> Run the following to repro the issue 
> {code:java}
> create database scenario_1; use scenario_1;
> create table table_1(fname string, lname string, mname string, e_id int, 
> contact_no int);
> create table table_11 as select * from table_1;
> create table table_12 as select * from table_1;
> create table table_13 as select * from table_1;
> create table table_14 as select * from table_1; {code}
> Payload 
> {code:java}
> {
>     "": {
>         "direction": "INPUT",
>         "inputRelationsLimit": 1
>     }
> }{code}
> Response:
> {code:java}
> {
>     "baseEntityGuid": "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3",
>     "lineageDirection": "INPUT",
>     "lineageDepth": 3,
>     "guidEntityMap": {},
>     "relations": [],
>     "relationsOnDemand": {},
>     "lineageOnDemandPayload": {
>         "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3": {
>             "direction": "INPUT",
>             "inputRelationsLimit": 1,
>             "outputRelationsLimit": 3,
>             "depth": 3
>         }
>     }
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ATLAS-4644) [Lineage Improvements] When direction is 'INPUT' for a lineage which does not have inputs, the response does not contain guidEntityMap

2022-07-29 Thread Radhika Kundam (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573081#comment-17573081
 ] 

Radhika Kundam commented on ATLAS-4644:
---

{color:#172b4d}As per the design, when there is no lineage information/no 
relations, guidEntityMap will be empty and UI will simply display the node 
based on baseGuid. {color}

{color:#172b4d}Closing this Jira as it's expected behavior.{color}

> [Lineage Improvements] When direction is 'INPUT' for a lineage which does not 
> have inputs, the response does not contain guidEntityMap
> --
>
> Key: ATLAS-4644
> URL: https://issues.apache.org/jira/browse/ATLAS-4644
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
>
> Input setup:
> Enable lineage improvements: *atlas.lineage.on.demand.enabled=true*
> Run the following to repro the issue 
> {code:java}
> create database scenario_1; use scenario_1;
> create table table_1(fname string, lname string, mname string, e_id int, 
> contact_no int);
> create table table_11 as select * from table_1;
> create table table_12 as select * from table_1;
> create table table_13 as select * from table_1;
> create table table_14 as select * from table_1; {code}
> Payload 
> {code:java}
> {
>     "": {
>         "direction": "INPUT",
>         "inputRelationsLimit": 1
>     }
> }{code}
> Response:
> {code:java}
> {
>     "baseEntityGuid": "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3",
>     "lineageDirection": "INPUT",
>     "lineageDepth": 3,
>     "guidEntityMap": {},
>     "relations": [],
>     "relationsOnDemand": {},
>     "lineageOnDemandPayload": {
>         "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3": {
>             "direction": "INPUT",
>             "inputRelationsLimit": 1,
>             "outputRelationsLimit": 3,
>             "depth": 3
>         }
>     }
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (ATLAS-4643) [Lineage Improvements] Incorrect response when inputRelationsLimit and outputRelationsLimit is 0

2022-07-29 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam closed ATLAS-4643.
-

This issue is duplicate of ATLAS-4645 and fixed as part of ATLAS-4606

> [Lineage Improvements] Incorrect response when inputRelationsLimit and 
> outputRelationsLimit is 0
> 
>
> Key: ATLAS-4643
> URL: https://issues.apache.org/jira/browse/ATLAS-4643
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Radhika Kundam
>Priority: Major
> Attachments: Screenshot 2022-07-22 at 7.08.16 PM.png
>
>
> Input setup:
> Enable lineage improvements: *atlas.lineage.on.demand.enabled=true*
> Run the following to repro the issue 
> {code:java}
> create database scenario_1; use scenario_1;
> create table table_1(fname string, lname string, mname string, e_id int, 
> contact_no int);
> create table table_11 as select * from table_1;
> create table table_12 as select * from table_1;
> create table table_13 as select * from table_1;
> create table table_14 as select * from table_1; {code}
> Payload 
> {code:java}
> {
>     "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3": {
>         "direction": "BOTH",
>         "inputRelationsLimit": 0,
>         "outputRelationsLimit": 0
>     }
> }{code}
> With the following payload
> {code:java}
>  {
>     "": {
>         "direction": "BOTH",
>         "inputRelationsLimit": 0,
>         "outputRelationsLimit": 0
>     }
> }{code}
> We expect  guidEntityMap to contain only the current entity. But the current 
> result mis matched
> {code:java}
> {
>     "baseEntityGuid": "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3",
>     "lineageDirection": "BOTH",
>     "lineageDepth": 3,
>     "guidEntityMap": {
>         "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3": {
>             "typeName": "hive_table",
>             "attributes": {
>                 "owner": "hrt_qa",
>                 "createTime": 165849599,
>                 "qualifiedName": "scenario_1.table_1@cm",
>                 "name": "table_1",
>                 "description": ""
>             },
>             "guid": "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3",
>             "status": "ACTIVE",
>             "displayText": "table_1",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "008977e7-9860-4b67-adb9-8c55635d937b": {
>             "typeName": "hive_table",
>             "attributes": {
>                 "owner": "hrt_qa",
>                 "createTime": 1658495994000,
>                 "qualifiedName": "scenario_1.table_11@cm",
>                 "name": "table_11",
>                 "description": ""
>             },
>             "guid": "008977e7-9860-4b67-adb9-8c55635d937b",
>             "status": "ACTIVE",
>             "displayText": "table_11",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "e017a7de-803b-4f8b-8d2a-7568f930316e": {
>             "typeName": "hive_table",
>             "attributes": {
>                 "owner": "hrt_qa",
>                 "createTime": 1658496001000,
>                 "qualifiedName": "scenario_1.table_14@cm",
>                 "name": "table_14",
>                 "description": ""
>             },
>             "guid": "e017a7de-803b-4f8b-8d2a-7568f930316e",
>             "status": "ACTIVE",
>             "displayText": "table_14",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "e3244d74-25d7-4622-8365-d828802d0aa3": {
>             "typeName": "hive_process",
>             "attributes": {
>                 "owner": "",
>                 "qualifiedName": "scenario_1.table_12@cm:1658495996000",
>                 "name": "scenario_1.table_12@cm:1658495996000",
>                 "description": ""
>             },
>             "guid": "e3244d74-25d7-4622-8365-d828802d0aa3",
>             "status": "ACTIVE",
>             "displayText": "scenario_1.table_12@cm:1658495996000",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "9a41de44-d569-42d7-a30e-1c3e2b2c80c2": {
>             "typeName": "hive_process",
>             "attributes": {
>                 "owner": "",
>                 "qualifiedName": "scenario_1.table_11@cm:1658495994000",
>                 "name": "scenario_1.table_11@cm:1658495994000",
>                 

[jira] [Resolved] (ATLAS-4643) [Lineage Improvements] Incorrect response when inputRelationsLimit and outputRelationsLimit is 0

2022-07-29 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam resolved ATLAS-4643.
---
Resolution: Duplicate

> [Lineage Improvements] Incorrect response when inputRelationsLimit and 
> outputRelationsLimit is 0
> 
>
> Key: ATLAS-4643
> URL: https://issues.apache.org/jira/browse/ATLAS-4643
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Radhika Kundam
>Priority: Major
> Attachments: Screenshot 2022-07-22 at 7.08.16 PM.png
>
>
> Input setup:
> Enable lineage improvements: *atlas.lineage.on.demand.enabled=true*
> Run the following to repro the issue 
> {code:java}
> create database scenario_1; use scenario_1;
> create table table_1(fname string, lname string, mname string, e_id int, 
> contact_no int);
> create table table_11 as select * from table_1;
> create table table_12 as select * from table_1;
> create table table_13 as select * from table_1;
> create table table_14 as select * from table_1; {code}
> Payload 
> {code:java}
> {
>     "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3": {
>         "direction": "BOTH",
>         "inputRelationsLimit": 0,
>         "outputRelationsLimit": 0
>     }
> }{code}
> With the following payload
> {code:java}
>  {
>     "": {
>         "direction": "BOTH",
>         "inputRelationsLimit": 0,
>         "outputRelationsLimit": 0
>     }
> }{code}
> We expect  guidEntityMap to contain only the current entity. But the current 
> result mis matched
> {code:java}
> {
>     "baseEntityGuid": "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3",
>     "lineageDirection": "BOTH",
>     "lineageDepth": 3,
>     "guidEntityMap": {
>         "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3": {
>             "typeName": "hive_table",
>             "attributes": {
>                 "owner": "hrt_qa",
>                 "createTime": 165849599,
>                 "qualifiedName": "scenario_1.table_1@cm",
>                 "name": "table_1",
>                 "description": ""
>             },
>             "guid": "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3",
>             "status": "ACTIVE",
>             "displayText": "table_1",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "008977e7-9860-4b67-adb9-8c55635d937b": {
>             "typeName": "hive_table",
>             "attributes": {
>                 "owner": "hrt_qa",
>                 "createTime": 1658495994000,
>                 "qualifiedName": "scenario_1.table_11@cm",
>                 "name": "table_11",
>                 "description": ""
>             },
>             "guid": "008977e7-9860-4b67-adb9-8c55635d937b",
>             "status": "ACTIVE",
>             "displayText": "table_11",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "e017a7de-803b-4f8b-8d2a-7568f930316e": {
>             "typeName": "hive_table",
>             "attributes": {
>                 "owner": "hrt_qa",
>                 "createTime": 1658496001000,
>                 "qualifiedName": "scenario_1.table_14@cm",
>                 "name": "table_14",
>                 "description": ""
>             },
>             "guid": "e017a7de-803b-4f8b-8d2a-7568f930316e",
>             "status": "ACTIVE",
>             "displayText": "table_14",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "e3244d74-25d7-4622-8365-d828802d0aa3": {
>             "typeName": "hive_process",
>             "attributes": {
>                 "owner": "",
>                 "qualifiedName": "scenario_1.table_12@cm:1658495996000",
>                 "name": "scenario_1.table_12@cm:1658495996000",
>                 "description": ""
>             },
>             "guid": "e3244d74-25d7-4622-8365-d828802d0aa3",
>             "status": "ACTIVE",
>             "displayText": "scenario_1.table_12@cm:1658495996000",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "9a41de44-d569-42d7-a30e-1c3e2b2c80c2": {
>             "typeName": "hive_process",
>             "attributes": {
>                 "owner": "",
>                 "qualifiedName": "scenario_1.table_11@cm:1658495994000",
>                 "name": "scenario_1.table_11@cm:1658495994000",
>                 "description": ""
>             },
>             

[jira] [Assigned] (ATLAS-4643) [Lineage Improvements] Incorrect response when inputRelationsLimit and outputRelationsLimit is 0

2022-07-29 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam reassigned ATLAS-4643:
-

Assignee: Radhika Kundam

> [Lineage Improvements] Incorrect response when inputRelationsLimit and 
> outputRelationsLimit is 0
> 
>
> Key: ATLAS-4643
> URL: https://issues.apache.org/jira/browse/ATLAS-4643
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Radhika Kundam
>Priority: Major
> Attachments: Screenshot 2022-07-22 at 7.08.16 PM.png
>
>
> Input setup:
> Enable lineage improvements: *atlas.lineage.on.demand.enabled=true*
> Run the following to repro the issue 
> {code:java}
> create database scenario_1; use scenario_1;
> create table table_1(fname string, lname string, mname string, e_id int, 
> contact_no int);
> create table table_11 as select * from table_1;
> create table table_12 as select * from table_1;
> create table table_13 as select * from table_1;
> create table table_14 as select * from table_1; {code}
> Payload 
> {code:java}
> {
>     "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3": {
>         "direction": "BOTH",
>         "inputRelationsLimit": 0,
>         "outputRelationsLimit": 0
>     }
> }{code}
> With the following payload
> {code:java}
>  {
>     "": {
>         "direction": "BOTH",
>         "inputRelationsLimit": 0,
>         "outputRelationsLimit": 0
>     }
> }{code}
> We expect  guidEntityMap to contain only the current entity. But the current 
> result mis matched
> {code:java}
> {
>     "baseEntityGuid": "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3",
>     "lineageDirection": "BOTH",
>     "lineageDepth": 3,
>     "guidEntityMap": {
>         "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3": {
>             "typeName": "hive_table",
>             "attributes": {
>                 "owner": "hrt_qa",
>                 "createTime": 165849599,
>                 "qualifiedName": "scenario_1.table_1@cm",
>                 "name": "table_1",
>                 "description": ""
>             },
>             "guid": "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3",
>             "status": "ACTIVE",
>             "displayText": "table_1",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "008977e7-9860-4b67-adb9-8c55635d937b": {
>             "typeName": "hive_table",
>             "attributes": {
>                 "owner": "hrt_qa",
>                 "createTime": 1658495994000,
>                 "qualifiedName": "scenario_1.table_11@cm",
>                 "name": "table_11",
>                 "description": ""
>             },
>             "guid": "008977e7-9860-4b67-adb9-8c55635d937b",
>             "status": "ACTIVE",
>             "displayText": "table_11",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "e017a7de-803b-4f8b-8d2a-7568f930316e": {
>             "typeName": "hive_table",
>             "attributes": {
>                 "owner": "hrt_qa",
>                 "createTime": 1658496001000,
>                 "qualifiedName": "scenario_1.table_14@cm",
>                 "name": "table_14",
>                 "description": ""
>             },
>             "guid": "e017a7de-803b-4f8b-8d2a-7568f930316e",
>             "status": "ACTIVE",
>             "displayText": "table_14",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "e3244d74-25d7-4622-8365-d828802d0aa3": {
>             "typeName": "hive_process",
>             "attributes": {
>                 "owner": "",
>                 "qualifiedName": "scenario_1.table_12@cm:1658495996000",
>                 "name": "scenario_1.table_12@cm:1658495996000",
>                 "description": ""
>             },
>             "guid": "e3244d74-25d7-4622-8365-d828802d0aa3",
>             "status": "ACTIVE",
>             "displayText": "scenario_1.table_12@cm:1658495996000",
>             "classificationNames": [],
>             "meaningNames": [],
>             "meanings": [],
>             "isIncomplete": false,
>             "labels": []
>         },
>         "9a41de44-d569-42d7-a30e-1c3e2b2c80c2": {
>             "typeName": "hive_process",
>             "attributes": {
>                 "owner": "",
>                 "qualifiedName": "scenario_1.table_11@cm:1658495994000",
>                 "name": "scenario_1.table_11@cm:1658495994000",
>                 "description": ""
>             },
>       

[jira] [Resolved] (ATLAS-4646) [Lineage Improvements][Regression]On a single standalone table, lineage information is missing on the latest bits

2022-07-29 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam resolved ATLAS-4646.
---
Fix Version/s: 3.0.0
   2.3.0
   Resolution: Fixed

> [Lineage Improvements][Regression]On a single standalone table, lineage 
> information is missing on the latest bits
> -
>
> Key: ATLAS-4646
> URL: https://issues.apache.org/jira/browse/ATLAS-4646
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Farhan Khan
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Screenshot 2022-07-23 at 1.06.26 AM.png
>
>
> Just create a table:
> Eg:create table table_only(name string, e_id int, contact_no int);
> This should have just the table as lineage info. but with the latest changes, 
> it displays 
> {code:java}
> No lineage data found {code}
> Attached the screenshot for the same



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ATLAS-4646) [Lineage Improvements][Regression]On a single standalone table, lineage information is missing on the latest bits

2022-07-29 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam reassigned ATLAS-4646:
-

Assignee: Farhan Khan  (was: Dharshana M Krishnamoorthy)

> [Lineage Improvements][Regression]On a single standalone table, lineage 
> information is missing on the latest bits
> -
>
> Key: ATLAS-4646
> URL: https://issues.apache.org/jira/browse/ATLAS-4646
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Farhan Khan
>Priority: Major
> Attachments: Screenshot 2022-07-23 at 1.06.26 AM.png
>
>
> Just create a table:
> Eg:create table table_only(name string, e_id int, contact_no int);
> This should have just the table as lineage info. but with the latest changes, 
> it displays 
> {code:java}
> No lineage data found {code}
> Attached the screenshot for the same



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (ATLAS-4645) [Lineage Improvements] When inputRelationsLimit or outputRelationsLimit is 0, then it is replaced with the default value of node count

2022-07-29 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam resolved ATLAS-4645.
---
Fix Version/s: 3.0.0
   2.3.0
   Resolution: Fixed

> [Lineage Improvements] When inputRelationsLimit or outputRelationsLimit is 0, 
> then it is replaced with the default value of node count
> --
>
> Key: ATLAS-4645
> URL: https://issues.apache.org/jira/browse/ATLAS-4645
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Radhika Kundam
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Input setup:
> Enable lineage improvements: *atlas.lineage.on.demand.enabled=true*
> Run the following to repro the issue 
> {code:java}
> create database scenario_1; use scenario_1;
> create table table_1(fname string, lname string, mname string, e_id int, 
> contact_no int);
> create table table_11 as select * from table_1;
> create table table_12 as select * from table_1;
> create table table_13 as select * from table_1;
> create table table_14 as select * from table_1; {code}
> Payload 
> With the following payload
> {code:java}
>  {
>     "": {
>         "direction": "BOTH",
>         "inputRelationsLimit": 3,
>         "outputRelationsLimit": 0
>     }
> }{code}
> The 'lineageOnDemandPayload' should be same as that of the input. Here we can 
> see it is replaces with the default node count value 3.Check 
> "outputRelationsLimit" in the below response
> {code:java}
> {
>     "baseEntityGuid": "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3",
>     "lineageDirection": "BOTH",
>     "lineageDepth": 3,
>     
> {code}
> {color:#009100}...{color}
> {code:java}
>     "lineageOnDemandPayload": {
>         "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3": {
>             "direction": "BOTH",
>             "inputRelationsLimit": 3,
>             "outputRelationsLimit": 3,
>             "depth": 3
>         }
>     }
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ATLAS-4645) [Lineage Improvements] When inputRelationsLimit or outputRelationsLimit is 0, then it is replaced with the default value of node count

2022-07-29 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam reassigned ATLAS-4645:
-

Assignee: Radhika Kundam

> [Lineage Improvements] When inputRelationsLimit or outputRelationsLimit is 0, 
> then it is replaced with the default value of node count
> --
>
> Key: ATLAS-4645
> URL: https://issues.apache.org/jira/browse/ATLAS-4645
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Radhika Kundam
>Priority: Major
>
> Input setup:
> Enable lineage improvements: *atlas.lineage.on.demand.enabled=true*
> Run the following to repro the issue 
> {code:java}
> create database scenario_1; use scenario_1;
> create table table_1(fname string, lname string, mname string, e_id int, 
> contact_no int);
> create table table_11 as select * from table_1;
> create table table_12 as select * from table_1;
> create table table_13 as select * from table_1;
> create table table_14 as select * from table_1; {code}
> Payload 
> With the following payload
> {code:java}
>  {
>     "": {
>         "direction": "BOTH",
>         "inputRelationsLimit": 3,
>         "outputRelationsLimit": 0
>     }
> }{code}
> The 'lineageOnDemandPayload' should be same as that of the input. Here we can 
> see it is replaces with the default node count value 3.Check 
> "outputRelationsLimit" in the below response
> {code:java}
> {
>     "baseEntityGuid": "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3",
>     "lineageDirection": "BOTH",
>     "lineageDepth": 3,
>     
> {code}
> {color:#009100}...{color}
> {code:java}
>     "lineageOnDemandPayload": {
>         "f92a6057-f6c8-4c0e-a3a0-50dba5f507d3": {
>             "direction": "BOTH",
>             "inputRelationsLimit": 3,
>             "outputRelationsLimit": 3,
>             "depth": 3
>         }
>     }
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ATLAS-4641) [Lineage Improvements] The expand button is broken on the UI, but on clicking it, the actual purpose is served

2022-07-29 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam reassigned ATLAS-4641:
-

Assignee: Farhan Khan

> [Lineage Improvements] The expand button is broken on the UI, but on clicking 
> it, the actual purpose is served
> --
>
> Key: ATLAS-4641
> URL: https://issues.apache.org/jira/browse/ATLAS-4641
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Farhan Khan
>Priority: Major
> Attachments: Screenshot 2022-07-20 at 11.42.13 PM.png
>
>
> The expand button is broken on the UI, when on demand lineage is enabled.
> Attached the screenshot of the same. Not seeing any errors in the network tab 
> too



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (ATLAS-4641) [Lineage Improvements] The expand button is broken on the UI, but on clicking it, the actual purpose is served

2022-07-29 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam resolved ATLAS-4641.
---
Fix Version/s: 3.0.0
   2.3.0
   Resolution: Fixed

> [Lineage Improvements] The expand button is broken on the UI, but on clicking 
> it, the actual purpose is served
> --
>
> Key: ATLAS-4641
> URL: https://issues.apache.org/jira/browse/ATLAS-4641
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Farhan Khan
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Screenshot 2022-07-20 at 11.42.13 PM.png
>
>
> The expand button is broken on the UI, when on demand lineage is enabled.
> Attached the screenshot of the same. Not seeing any errors in the network tab 
> too



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74074: ATLAS-4650 : Upgrade Apache Commons BeanUtils to 1.9.4

2022-07-29 Thread Ashutosh Mestry

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74074/#review224591
---


Ship it!




Ship It!

- Ashutosh Mestry


On July 28, 2022, 11:06 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74074/
> ---
> 
> (Updated July 28, 2022, 11:06 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4650
> https://issues.apache.org/jira/browse/ATLAS-4650
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Commons BeanUtils version is 1.9.2,1.9.3,1.8.3
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/pom.xml a6ed51421 
>   addons/hbase-testing-util/pom.xml 982e9c85e 
>   pom.xml 1e32e45f3 
> 
> 
> Diff: https://reviews.apache.org/r/74074/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -Drat.skip
> atlas server running successfully
> 
> 
> Thanks,
> 
> chaitali
> 
>



Contribute

2022-07-29 Thread Patrik Marton
   Hi Atlas Team,

   I am interested in contributing to Apache Atlas project, please add me
   as a contributor.

   My Jira id is pmarton

Thanks!